From nobody Thu Apr 9 09:48:08 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93C73CB2F1 for ; Tue, 10 Mar 2026 04:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773115760; cv=none; b=kQ2exIHgXhUYA66bmcI8BHPpjP/cm4cyGSbeX4Y/+hRCGtC1VAfX1jAzvfwISJrIUj3A7b/NMxMAsElfFCgD/IK2Kd9LHwjre6l4ovDZ5ClpocokwPXrDnCU0/FYSpmz93IVULfkr/JI1XLx33WDB1ETIrX/eoCkvX76TdSZzpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773115760; c=relaxed/simple; bh=D7RSg4l0xMBxXV15aj1igeBvh6Yp99FxN4zSXnETrEI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CsUE7R9pXsNF+3npW+nip+XNggAyXRnR+NQKnk0wsC2XA811Qu+FqSw6ftnNDZQpelvle5BswJdSRkTrNLfviJRSNPozHf76YIQBoL61GCtH2h0OsxSlp94lc3Im2q+7LxjxWusBzZlghxteQnjITdCzYlOt8K0QbCHoFJ+hiXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LpCd0CYZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bsVqlvbD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LpCd0CYZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bsVqlvbD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EZKF1900137 for ; Tue, 10 Mar 2026 04:09:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IUB4/DuDC1wDE2keWJkPB0qFs6Egwe4FX8Up3irNpes=; b=LpCd0CYZdTjKwucw o+bM8TVWH0NMf5JqcorJ1K34tQKIi3EC5j/935sYAh6dJ4arNkJyJ1+SESXbuvzt RcwiQsNM4cGeTvWt97rrZGB940U1A7uyGUG7A58g0WZ+BYsvT2uVNxWTLc1mwN0A PkUhLYgiFvxaR1qohYZ/r+Qe3tJr2I6344/6sg3czjvumqa/whhXYiPbhBeFZZz4 3BD8XpkADQv5Ab+4pmywo1i2jVetbNLVmaS3bWm1lc0xx03VlDINjiUrfwYFD4Lh cKjkCAJClXjy1unPb5bkR4WLSQzjA2029WOgI5EO6sZUERFvyLvqPg7VcHvMx5qh /Nk9ug== Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cstsabk56-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 04:09:17 +0000 (GMT) Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-40ef793e45eso27466460fac.3 for ; Mon, 09 Mar 2026 21:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773115757; x=1773720557; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IUB4/DuDC1wDE2keWJkPB0qFs6Egwe4FX8Up3irNpes=; b=bsVqlvbDzRWGeTE+3huvv0Se01F0k3IL+zHMHrU3o7fzruaG8iqzMrPe2sTaeCLDvu 6rkX6C7S3E3fWxZrnfQvmDVYuJVE2NLJQ0J3eJn6XmbYtmruK1FPB79+1uuVKpQMAvUo 5/5Ye2FzZX2LIwhqnS2iD4HlqP2OzMBzZDXMA/VvOfqf7ku8gWB2rylVevGWkkDANPll 7gYoasEykHewcPbksCH6VJJoLOt8Vz/prk+hxxivGJ4mLYdLUTHiGUhOpOAgGOkAm6Vs yBlUcl4EW4VSC6l5nUQ2S6jTVXADz/znqQh4T/biNWHzIWYsUm6bsDmpc0dIbhhqFshv hT9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773115757; x=1773720557; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IUB4/DuDC1wDE2keWJkPB0qFs6Egwe4FX8Up3irNpes=; b=TpiQx8sA1CFsPE6Tn6aSmyP9uy5cwV9+ns5lpVbs2VS8iUyRA9FzcpqiUT+tBikXt1 6KZ0BE2LaxLdplCHkiuru7L+5BIYuKmXgfkkP7K0jSzKqZwondeQvMPri6cYGagUeixk xj6V3hjbNNkSgdhNXvzk9V0jKam76Yx1vzIQoANMZtSCNCyRlmxE87fe0OioFw9BBdYx DnyR+dZ/rI6QuBhHvlzVDorTdBFiMmPgY5Ht++XES9xv8ZoZlLEchcdgCZt8odaxCPlb QebOkDak4dPETDbjgdgA5ND1wAVydGkeD668tTYABwalK8v93V3W/BWjV0OOjKKRkarJ iU0A== X-Forwarded-Encrypted: i=1; AJvYcCWP88/SvgaaZ1+FLM0vULdM6rvytID+KAzt308sPCAy093l5FK1xtFgOnzTL8ueubLjjnZ47MkcSINKYhk=@vger.kernel.org X-Gm-Message-State: AOJu0YxDyupyVdRu2cVbfV1hcMWuirZhdKg/q0/Muy3bt/qQVGgDjLsj rdz+3gRvZ2KW05OasyQhfq6b8lPL/MkQ6boyyy/cK2H/TMU1N6xL1/QLHsJ3iM0/C7RDaxJdtQY PnGHmYJHWDvXFvkJAOKwKulzX6u917Bw3jBF60yIB6xK7OKp6HEZF6sR7hyzEsw5zbXM= X-Gm-Gg: ATEYQzwAQGAfARNXuFKXp9VKFdIE8p1E2h0gjHKU/Oa1ZFrDtQERsaIRHqE+6S12L1n BnkxM7T/RCo4mVgossHx125y9L87uWKp7BBBLEhaB9Ahkf+T4iQ6cz1Bf50oof1JTAH8u5jqeBE PotimePh36M0EdJiu3IVdV/xzNSXOhZMC7qoopHbGddN1qnBcdp2dqV6+WYaW2tI6PxSWGu0VMM p4whMY1w1Qw0aVuUZ+qA9s1KMux2jFym4ucmwjEI+QJyGhj4kzY7I/ZAP6q4MgO5xNNz7oz8d60 kM+vRJ+eSFSnEERmWBFBDibRk/2LpjE1nzhgoP2vWyNJs8k4F3Zh/ARDzQesVeipm/TOxf++xKx 9NIE/QelpwIJRrqeTY3hvpM0zX34HGpsoGLPoxHsXsD8= X-Received: by 2002:a05:6870:2154:b0:40e:a338:c8a1 with SMTP id 586e51a60fabf-416e3eac7b6mr8389215fac.11.1773115757320; Mon, 09 Mar 2026 21:09:17 -0700 (PDT) X-Received: by 2002:a05:6870:2154:b0:40e:a338:c8a1 with SMTP id 586e51a60fabf-416e3eac7b6mr8389204fac.11.1773115756943; Mon, 09 Mar 2026 21:09:16 -0700 (PDT) Received: from [192.168.86.59] ([104.57.184.186]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41756e24c39sm1595685fac.20.2026.03.09.21.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 21:09:16 -0700 (PDT) From: Bjorn Andersson Date: Mon, 09 Mar 2026 23:09:03 -0500 Subject: [PATCH 2/7] slimbus: qcom-ngd-ctrl: Fix probe error path ordering Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-slim-ngd-dev-v1-2-5843e3ed62a3@oss.qualcomm.com> References: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> In-Reply-To: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> To: Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1558; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=D7RSg4l0xMBxXV15aj1igeBvh6Yp99FxN4zSXnETrEI=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpr5lpYvZ+ct4IErTPa9Ur2dZl9HwXHOifOnPpm stchtoirQWJAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCaa+ZaRUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcUXTg/9G/PF5Gf2GSGQAlgzaO6XaXLSu+bf4rEzzYhXY2w z2kzQotKhcaGy57uXKawzo7hFMqeWhkfzdiCLvEksEG37vyJWF7avc2ucCx8UfYKn6e4vmiaOj3 oe2RkUcVq41+ZxQoAt7TTlo1bQyrjrYc7CLVv9P0ev/2WvCJ0nWx1Gd2llYFCYFzA+w3dhuexjF +ZMka3Fz1n0uSIesEFyhii4hpz10Glfe4YVEQeT/oT6rClqpuQIU9wwl9IebSRN7Xr0sSJ/F7v+ L6foAuYjH+XOxY+C1nNp+/ByYjXDsKkNfYB9FAeW8T7djBhmBxlm40oogjXFI7YgBPplJ4QVEXc rcEydODoIrLyMN1CgLHQao9SEa5k0Q4hC3j/6nAl/bWRXZlGpCPOLkTn+2m+9/wPqGOuoe5RpXt ggQgZycSARoWjBfJsbcc4i2PFj4Ep4fAW4mojnOG69bazCvDmi4xx4D5o/kp73e7vVH7J1XFbEl WRT0pARwX9+wcT/5gYnDyCF4FCx/rnMrw0Ck2NgF79Qdl9wXVyoXd1G5zi83f3e+7XxYD5UlNde vb4eI8d9+Y5Mk0f+hClophVqvIzXjd35E2d9pvhoqZl7qMwgSjWC0k6qObCN4maBXyE5Q25JYbs NuXt+llpUKl2QickmZ+VYBLKZPa3dCvlDM1YxtnOg5m8= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-GUID: UFXHYqAJs2E8HBMV8ES7rer2222G2b8W X-Authority-Analysis: v=2.4 cv=I+Vohdgg c=1 sm=1 tr=0 ts=69af996d cx=c_pps a=Z3eh007fzM5o9awBa1HkYQ==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=v7zRpcr-n2crOtZbBgkA:9 a=QEXdDO2ut3YA:10 a=eBU8X_Hb5SQ8N-bgNfv4:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDAzMSBTYWx0ZWRfXxnjqCYpDJQn+ I1bGLmuvXi3FKjaWLr2XQt+YcGnau2fLNYKTxYH43L1zzkUpcQ8Zx6ZGsbuq+kX33cR1ESsFlfP OWX0OXXV8bbBqcqJ6QyJzy6SurhdEdPgNti5wgqGr/7td2zgApUqcQ+aqwJafBhJX6drqokLz6Q vUeo3s7se4Q5m8XYVBic3T7aFYD+iRexETIn98D6UhCnGX0dbhshReZlOLZS2cCi68ZTYeRRK5z s3Zfa025JrHj/UVAwrhOJWn5wsAhbIp3lumHrsiSrJD881Lt/pPa+MBgBZ+iAHFV1M+wLn+pReI JIHAqJzTe3wnX+x4Fzc2zQ6/Ix75iFjdfSaiRgQbIrwHpLZpfGESDB4Z8da00kWZdHxURh70DpG wUs80v1QQiLC/e2I3R6oB7M0Exw6LQCtARdVHfR+8wqgfgweiVxE0GG20Ym0H3zo+cyey4EuJOb VAjpn7DwmY018tOpztw== X-Proofpoint-ORIG-GUID: UFXHYqAJs2E8HBMV8ES7rer2222G2b8W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100031 qcom_slim_ngd_ctrl_probe() first registers the SSR callback then allocates the PDR context, as such the error path needs to come in opposite order to allow us to unroll each step. Fixes: 16f14551d0df ("slimbus: qcom-ngd: cleanup in probe error path") Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha --- drivers/slimbus/qcom-ngd-ctrl.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index c69656a0ef1766d5a9df40bdf37bae8f64789fab..b34e727bab086c95dc7e760bf11= 41baac9ccf6a7 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1662,22 +1662,21 @@ static int qcom_slim_ngd_ctrl_probe(struct platform= _device *pdev) if (IS_ERR(ctrl->pdr)) { ret =3D dev_err_probe(dev, PTR_ERR(ctrl->pdr), "Failed to init PDR handle\n"); - goto err_pdr_alloc; + goto err_unregister_ssr; } =20 pds =3D pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); if (IS_ERR(pds) && PTR_ERR(pds) !=3D -EALREADY) { ret =3D dev_err_probe(dev, PTR_ERR(pds), "pdr add lookup failed\n"); - goto err_pdr_lookup; + goto err_pdr_release; } =20 return of_qcom_slim_ngd_register(dev, ctrl); =20 -err_pdr_alloc: - qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); - -err_pdr_lookup: +err_pdr_release: pdr_handle_release(ctrl->pdr); +err_unregister_ssr: + qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); =20 return ret; } --=20 2.51.0