From nobody Thu Apr 9 09:48:29 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2D253C6A44 for ; Tue, 10 Mar 2026 04:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773115759; cv=none; b=GqOO8zcO9Cs6jbnN6CJ7YrnWMyupF6bjOS5CZWiOk38YPYJZ+f++sDetXbaZWVBEVEfQii/bBp4u7+i4c0PxBDdKM5Sbn9PA8JKiZFQN8P2V5RUm1sZGDWqmLAHnAJsf3iPB6wQtXsHzhzgKnD6bz+Al7MN2OMgCr521eG3tsBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773115759; c=relaxed/simple; bh=3Cb5y1P/EwWDNdjU8vL9LecqHowixFacmPbBDFJoYGs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fPlYftO5w9XpU6k6EZPaJsXqiMwVyVSswMAD+Dti30RmjvR1VEJH22QNDEt9d+yqLFBJNxZiEH3/mAMSw7jpvjsIpUdmxIS8Ks44Qs0bF8kdbee0bWnV06L/LCoD3uvMo91k4dea3DAf7eju/nsvhVxANw0A+4rDscUaIo2tX5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CDj7FyQr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OKI0yQ9p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CDj7FyQr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OKI0yQ9p" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EM4P110866 for ; Tue, 10 Mar 2026 04:09:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e//oRhmp8fUgAIO1Epz+iBv98UyMhnprwAdMQTvXFJo=; b=CDj7FyQrVDr2WR5y njY4P9bVuHGyEG6rjCTheF3/wmF3jSw9cb4g+mZQuo6VfZFOeP07w2K7y1zUUcbb e+yOA05L86RPnGCDVhJiXzN94vC8AEuweLFfsRwHjZU+TVnv1tNB3pbVdq0Ek/xA gIhzQwGqL7NcSs3LkUZYZ3qgZg4mezLOzyxQ4gGp5Z1ItqQHo9YeHawKKoRHnYmP sh2WpqcSumF1HNMzKX54+h86GMXgGqqKl0OMTwLx1++ehEPriZ6tz4frcOJptibP 45x+rKi7yrpFBsEMvx+ye8XLDNT/nDMTtUp9g/ZiWcnmMAB9W1cMN8OLZ7jzIt0d q3d6Jg== Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csv5ub683-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 04:09:16 +0000 (GMT) Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-4170466438dso10292025fac.2 for ; Mon, 09 Mar 2026 21:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773115756; x=1773720556; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e//oRhmp8fUgAIO1Epz+iBv98UyMhnprwAdMQTvXFJo=; b=OKI0yQ9p3Qmvk93RsHFdnaNxZUa33siAos3DyufaSq5tqif50I+np5TIWenlphC4SH bjjf+nGgc6Yv6QdLAc+jfV+lugGC8/rdamIZhUQ03WLKFR90FuQTf/sgQ7tQT5mEK0M7 Pq/TSLET/ui2bulysnZfXoHUxt7EYJ1dmaEid2LfLMrqGZK4UssEkLaWB3apLe2STcEK PAnsaA1qPl6rGG+mieypVCiq1J5BZCph/ABsCcu58gAQlyuVo38C2bBWPrV15hUxqCRv UU8jl+MrrlafSjtji7iUC1hx8q3PQRPOS7lZtl8aLnyCmL/4gXubDovbEJ3dRecjLkyd H3YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773115756; x=1773720556; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=e//oRhmp8fUgAIO1Epz+iBv98UyMhnprwAdMQTvXFJo=; b=IiVq03Kv/k7jhp09jHzg7bQLEfS/JY+5HYMShTJxMx6/vNrRSzeH5RCSjhRxbDw2SG OJ7A2M1lZfir2yIm64TAMh5uffPKzOq7nGJu5MdYqhtKFDZT5q2TfLoWqlwb1OCKFlKR twC3Xo5auAX+f9SY36t0yQNnli3WnQ3XlCTgv2uWynUfUrXpdr3Ssgg7Gf5TzAh8nyom 2qkIKoAkmVZfij6U6WT6hm0buXeD//lNzSChoIRiYMRogvGotnnJJw6jZui3RlaDupyr UxdsmSHVe2y39ltdGqUlAQ3UUSuX1IQO7PCj58yINZTPYJeI/2BAdH6MgsJzdKj/I5Pb fGUw== X-Forwarded-Encrypted: i=1; AJvYcCUiHvDzvNmsUtQcQKiWenZ07zCTIueKrWrCZlGd/cNcCHRjCVIn9RTOZr5UMay3AnEAmPGvTFmMM4NWB8M=@vger.kernel.org X-Gm-Message-State: AOJu0YzhMt8S7SBpRPuDSvHsaYuXuQOZB2a95HExoDpgUE0tBMNaaPD9 GaGuqk/oCTzO84tYvM02nWDxBfpBRqrlzkHVC6GuE4s6F8tYe+cNLPL+zPG44slD4fgbf0TKc9I Smwm0WeYPQl88pwpwXbg4nU0qxE5nQ/9OlMnZ9joXpOmt7y0jvazhiZDr7qXX3SQx41M= X-Gm-Gg: ATEYQzxNpMtxlWTBmTmC+8UQVOfwnQdFIiMStUHV4AiL8k48yTOwiH9H4rHr61tZu0O uY76kXbp9AVolcPgqpQWw3uJK+dNhWVr6yx2gfP3C6eEbRzDLNTZibTWu6eD5BCZ7wL0dlrgV2D y2BTnboiTabnnaXkyW6jpfTQ1UIYax7/BkMFQEZxn+rcKTSLiw5gyheE3Pkfhbk0wflU2GQTSmK P0YM3kk7nT5c6hpxKuqsu+yvtj7ris5ap1y6kaH+sPT4dfag/MIukLggs1e5aioRB5N4L7w54fD SjDGE8Z4Q0ySVKSy93Iy/LoZVkUnOK3M3sBodnJJFTMyhiqXo40yn1deIYxpWNdKG6f9NS9WInl 5/bX0IJWFiJ57/CBdMeZ4pnJque5ss+4bppjmxMHOkQo= X-Received: by 2002:a05:6870:b288:b0:3ec:3685:34a1 with SMTP id 586e51a60fabf-416e406f8fbmr7071900fac.25.1773115756090; Mon, 09 Mar 2026 21:09:16 -0700 (PDT) X-Received: by 2002:a05:6870:b288:b0:3ec:3685:34a1 with SMTP id 586e51a60fabf-416e406f8fbmr7071893fac.25.1773115755618; Mon, 09 Mar 2026 21:09:15 -0700 (PDT) Received: from [192.168.86.59] ([104.57.184.186]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41756e24c39sm1595685fac.20.2026.03.09.21.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 21:09:14 -0700 (PDT) From: Bjorn Andersson Date: Mon, 09 Mar 2026 23:09:02 -0500 Subject: [PATCH 1/7] slimbus: qcom-ngd-ctrl: Fix up platform_driver registration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-slim-ngd-dev-v1-1-5843e3ed62a3@oss.qualcomm.com> References: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> In-Reply-To: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> To: Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2709; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=3Cb5y1P/EwWDNdjU8vL9LecqHowixFacmPbBDFJoYGs=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpr5loy7yRVecGED9eETlNTSgHoISRiezX5TjFr rLQI7M+i0CJAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCaa+ZaBUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcXL5hAAmPbhESMgQoZmt+1S7TaqAJrYaWBb7gOkLbPPcgs +8KONegyxNwiLPc8IvU8V6ZUs7I5MzRfZWsDfBrWI5WVgF8L9FLMdXuHcLZ6e1hgG4yPq7ECYc8 7qxDLRSjI9YsuEtXTU3jxRMHsvYZlm3nU7uh9JNItsEsj3VmOjg7ATlvsWfy95AFHY5iSgUvLi+ pyydiZqe3ofnMeRlCToAoclOU9MUZNB96gXQXchesPl8QVpkuml9BsMewvZExM08JCl3b8IYic9 9lXaAxDvsor+55N2AXRV5ySfloEFrN3f5tpAQTOkjbQ0LOjEFbgcy6wbDCBjp99ITnPNnmcvzrZ /RwIf4kmuu+o0WVcjLt8BqrCs8Eq/cSel/GB+tqC6z9ZLE7Fdflyx7j+OGUSSbFL1WtEeWtnhTw odH1sBOUv5KX0MYG/j6Ti1RqZwAiWxANw7O6VgtJWUQytgRGWi0hp8NfVfRiDmrNswsSBbPcR5h 4DNb5ROyx9NzoOHqWRWxPJ5qrgKDuJd4dblA0ni9+YU4SYgioL8G4nfdwEE66Fg/1Oh5UhhJ262 YX4S7e5kxhjJ8b+LZQ9XfjgJq5acT7sBJlJ0IOPk+92PdDjzVxTZ0Bxo0PDgkm9Buo/IL06DmbF 13/HOyDDA5lkU16l6ZHmv5ycf0wpl8ihf2M0VQENOyCI= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-GUID: BOKi74wdbGXEg1kTLLDeOt1SPN95e_5x X-Proofpoint-ORIG-GUID: BOKi74wdbGXEg1kTLLDeOt1SPN95e_5x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDAzMSBTYWx0ZWRfX7OqbJLCRDxOW 98ZDooh1vdvSsEuG7+lQjPF3eb8hVGilO5uosrmLRbwIB+bkceJLy6LDV1Yy+pPhDKj0CyrNYEs epQPXldtYzWAdi6xaEQ484aRGuim8bsb4ML8hQG9lyS8XwdS5gMoTB8D50Z1cXOFFQGq0OvuKMo 6xmd7cW0jQQC2+S2jApej5e3KAM+tvgrEUBDULe49bJJhGnTuQNeK0yCCCFlAmIFty0D3UI0CKO QzOY7hNRVwf4G0Scoa/XU3VLP+P/hpYFJSfOuyNIRDpHuhRPXbB72JUmJia4HkODaZLpznwpOCU hedNOiRWv+rovLwDO02/DsCcB4oGpmEij+cKCI+Gan746QGmaG1hUNwbdY543CQ6eWqnzTJttcj Z2I9rhiVa39A7aKapOyuV2kfhwRHCp5EiPKNkg95hcogvv1DoFCa/gvRnv9ulW7bRpeWlI/QXrG pWMqJmy3NBCgIVnd7UQ== X-Authority-Analysis: v=2.4 cv=Xr/3+FF9 c=1 sm=1 tr=0 ts=69af996c cx=c_pps a=nSjmGuzVYOmhOUYzIAhsAg==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=EWo_CA4GmUQ_SZ-sejQA:9 a=QEXdDO2ut3YA:10 a=1zu1i0D7hVQfj8NKfPKu:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100031 Device drivers should not invoke platform_driver_register()/unregister() in their probe and remove paths. They should further not rely on platform_driver_unregister() as their only means of "deleting" their child devices. Introduce a helper to unregister the child device and move the platform_driver_register()/unregister() to module_init()/exit(). Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha --- drivers/slimbus/qcom-ngd-ctrl.c | 36 +++++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index 9aa7218b4e8d2b350835626839371ed6e19860e2..c69656a0ef1766d5a9df40bdf37= bae8f64789fab 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1562,6 +1562,13 @@ static int of_qcom_slim_ngd_register(struct device *= parent, return -ENODEV; } =20 +static void qcom_slim_ngd_unregister(struct qcom_slim_ngd_ctrl *ctrl) +{ + struct qcom_slim_ngd *ngd =3D ctrl->ngd; + + platform_device_del(ngd->pdev); +} + static int qcom_slim_ngd_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -1664,7 +1671,6 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_d= evice *pdev) goto err_pdr_lookup; } =20 - platform_driver_register(&qcom_slim_ngd_driver); return of_qcom_slim_ngd_register(dev, ctrl); =20 err_pdr_alloc: @@ -1678,7 +1684,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_d= evice *pdev) =20 static void qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) { - platform_driver_unregister(&qcom_slim_ngd_driver); + struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); + + qcom_slim_ngd_unregister(ctrl); } =20 static void qcom_slim_ngd_remove(struct platform_device *pdev) @@ -1754,6 +1762,28 @@ static struct platform_driver qcom_slim_ngd_driver = =3D { }, }; =20 -module_platform_driver(qcom_slim_ngd_ctrl_driver); +static int qcom_slim_ngd_init(void) +{ + int ret; + + ret =3D platform_driver_register(&qcom_slim_ngd_ctrl_driver); + if (ret) + return ret; + + ret =3D platform_driver_register(&qcom_slim_ngd_driver); + if (ret) + platform_driver_unregister(&qcom_slim_ngd_ctrl_driver); + + return ret; +} + +static void qcom_slim_ngd_exit(void) +{ + platform_driver_unregister(&qcom_slim_ngd_driver); + platform_driver_unregister(&qcom_slim_ngd_ctrl_driver); +} + +module_init(qcom_slim_ngd_init); +module_exit(qcom_slim_ngd_exit); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Qualcomm SLIMBus NGD controller"); --=20 2.51.0