From nobody Thu Apr 9 10:29:42 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060D9395244 for ; Mon, 9 Mar 2026 12:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773058581; cv=none; b=rCrNmL1JKxSaIc3nmybWTVbIdnkd5N1NRe5pftEMWOrg43dIHsRbTetvSzN7JkG436lbpSv9wo4MVYY4UHCyR+ie/FsPjLQgm+T9Nl54JwzotbWDB+lkbijOjVHDXmS2hJnPLY3tecPvf/hwHgGds4upVeN+/K3xBD8Iy4sGnFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773058581; c=relaxed/simple; bh=ze6F7nLn47oIqw03rLTI4vCDxZRDfipwZbIzfTE5gVs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=loKKZpPNRNbHZwKBnwzMwukHEncnl0QHIRfr6pjWqvB3IfLu27+7sBqZMJ6hNDX5eycB458+NRPv+RtXF+F3KZNUYWdF4h3bFGT2SRZHZFSCsnV8jZ24EWz7o+BbO1F7IG/o8I4Ak/WrEjQ5QnAAVon4dfUaLhhaMf4DSIAgNC8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HkR1dhNJ; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HkR1dhNJ" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35982fd8910so3628398a91.1 for ; Mon, 09 Mar 2026 05:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773058579; x=1773663379; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z/4T5g8cuZpW2r5QmDZ0Rjhhfb9PQbIPZH06YKDgyWo=; b=HkR1dhNJuBa6/Ofzha6uVO29EUPxUBK9spUw0HM3uKOTFKdtrGpqLS7j/K5xLRQEuh v3e1mEwGB7uQux2FEhMVN1hO8XUiZlRAYuY3zAdslsTAYNTL8lpsJ1FdHQv1obnV/0EC OB8s2Bbb8Hb0xgh9pFIFAUd6NPYBS2Or/AoiC/w2yct2SiySNsNK8eV/9IccLyqB/DaA 5+T5F+fQbzoT0IYcJ4hcRGdKc5TwOnBGiymSKLk0uhKjRA3lrTiUhce/695QaI1KhiZM AgDo7KCkRS0BjmQqYB09Wa4hCVOWrM4YEPj/KIynH2ZcpGYgBg1mplpx5q/UaPcASR38 DBig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773058579; x=1773663379; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z/4T5g8cuZpW2r5QmDZ0Rjhhfb9PQbIPZH06YKDgyWo=; b=oR7hvkiUkUh7u6Xgrccl6nOj7E4KdKppfgM/Cq7rrGvDwPPpmtmX4CHprE2c4L2s0w xL+wcyAyE6URmt7XA/Gh0Jsdiw5aIhfhpHtaSvuBG6n6Q1yfGkUP6557dM0QV2mVbGSI EG4QfK6BjKKT4u1ol3vKFvqlEdiaU5SqrFv0d5NRROCK/oZhv4W8iQmnQgB3KbCTeVwT XtXe7JGerLKAuBc7HKkf2sxtZk/YAziW01S9egnbpTVRWGV5/fNykIGZrSFCvvZIUgBV K+3JhQbh+ZbFeCL3fEiC8lACXZekWPlkDbNxdEoazBfEK5VuPk98UPYTE6a2FTk9Ilkl 9wmg== X-Forwarded-Encrypted: i=1; AJvYcCWsiAyNqMGuz+wyXvsI6SP4eT5AHbQY2qgytnobeCJmoNIoOVgqQTBq/AgiCLmWsi56EAqhI0uWTIF9l4w=@vger.kernel.org X-Gm-Message-State: AOJu0YzzVz+lZ8lJKtDiz2v2Ct9tr11Q4QMStUgFIJKIMXd284SbN/UL jb6KIx/Un9syGfxs7zn/fMfMXtE8QK97WPNC+aKaB2mpV7bD3WkNQH4WJlsB2ylS X-Gm-Gg: ATEYQzxw6CQ2NW7J6aecQ9mTPkI/4pMHOzNlsfEEOM1BV5wKJfgxScChdKxjGDK+3gt Os/KF4PMVF3L0H5B5tof6wO1u+V46oCapXztajvwq0VyN4E0V8zAfbOAGsHTAMHuWBKQE2lryR7 vkvUH4oRIin8X8mEaw41QCIytN67EdN+FL5GRvfc9H/y1xTb/WZE4iHg1wukY1xDVMGfL0YImnc drd57j8scrJybTwCsxJLi7RgtHoAfUkNTWYeR/dr8QsXnTJMN4ZlRstwt062/WeC3HMKmIU95cF uCz5dpLAxDYkWfR9MrCw5l9HQ7CiqO1qdI5SchVSOgmTTeWvH7fQniE7Z4VmXgr2x/qqnIx3cns Aq4FvdxQETA38Bndg0EjWCLq12QnA5x8QNKVACHKVPgdtNFNJZnmPyTeUu8NHHiTJn1o2cig0KE gQqj5vlxgHpreH6g5gjJ4zXibyenTaz5/EqGbD X-Received: by 2002:a17:90b:4fcc:b0:356:23be:7ecb with SMTP id 98e67ed59e1d1-359be25a3c7mr10094583a91.12.1773058579365; Mon, 09 Mar 2026 05:16:19 -0700 (PDT) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:a816:d74a:dc19:1ab8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e0a7156sm9525693a12.2.2026.03.09.05.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 05:16:19 -0700 (PDT) From: Felix Gu Date: Mon, 09 Mar 2026 20:16:14 +0800 Subject: [PATCH 1/2] soc: microchip: mpfs-control-scb: Fix resource leak on driver unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-mpfs-v1-1-0dd89f34f962@gmail.com> References: <20260309-mpfs-v1-0-0dd89f34f962@gmail.com> In-Reply-To: <20260309-mpfs-v1-0-0dd89f34f962@gmail.com> To: Conor Dooley , Daire McNamara Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773058576; l=1133; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=ze6F7nLn47oIqw03rLTI4vCDxZRDfipwZbIzfTE5gVs=; b=ylmr5sBs1d1Ppk+RhiT6bo6yWNSoKKwwHBzRIdR3JVTGgLuGmBglRTPjobn6wy51jxhXl8ItT 4UW4xSSTi4WAR4dibnoCaxzFr/CC8IbLzY/wULjjzGM2YKCkcJhmvE1 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Use devm_mfd_add_devices() instead of mfd_add_devices() to ensure child devices are properly removed when the driver unbinds. Fixes: 4aac11c9a6e7 ("soc: microchip: add mfd drivers for two syscon region= s on PolarFire SoC") Signed-off-by: Felix Gu --- drivers/soc/microchip/mpfs-control-scb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/soc/microchip/mpfs-control-scb.c b/drivers/soc/microch= ip/mpfs-control-scb.c index f0b84b1f49cb..8dda5704a389 100644 --- a/drivers/soc/microchip/mpfs-control-scb.c +++ b/drivers/soc/microchip/mpfs-control-scb.c @@ -14,8 +14,10 @@ static int mpfs_control_scb_probe(struct platform_device= *pdev) { struct device *dev =3D &pdev->dev; =20 - return mfd_add_devices(dev, PLATFORM_DEVID_NONE, mpfs_control_scb_devs, - ARRAY_SIZE(mpfs_control_scb_devs), NULL, 0, NULL); + return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, + mpfs_control_scb_devs, + ARRAY_SIZE(mpfs_control_scb_devs), NULL, 0, + NULL); } =20 static const struct of_device_id mpfs_control_scb_of_match[] =3D { --=20 2.43.0 From nobody Thu Apr 9 10:29:42 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ECFB3A784F for ; Mon, 9 Mar 2026 12:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773058583; cv=none; b=o7QEzqJIe3uyN40kNfHJYLFfvKpZ6szJlwh0lf/whM66vdI24qM/byWk1GDh1V3UJOQ1yUOX/77H3hRrw0wGYhjMmiu1S7tIpGv3ic0Iu95ojKSXrEAQcZdlCpJUhF1AIA61vnV35+ec5EeVYiri+g1FS8JXeXsfN1BUfJWJ5qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773058583; c=relaxed/simple; bh=O/VunH/9UjAoQv+nRiPfxssAhhHa/MPTIs1QTwQxRWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sPtqVN55dJK31LJe+7J0054FIsjwe4YiMB421dxQG9g/MXrsc9NY3CLjmoQ7hKRVke4r7AyKKQ+OXhavpk4X7e5I+kMvYxWefk2itWeYb3rjiNWabYVc6f0u6LUNYhOa92Wd7slHBw3vKIP+WLt9SvUZPGSto7rjuxZHN6JyEow= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I7xuIdJm; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I7xuIdJm" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82989744ee0so3360391b3a.2 for ; Mon, 09 Mar 2026 05:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773058581; x=1773663381; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=25TZNPEwwPkYTHAgMRLn+Sz9ICp+r6IePTSPwttEBwg=; b=I7xuIdJmc1KA0aFPPXFJmMffFjKXm45vXEP71bwt5Lhei9cWLzoZbv8YzR3Njr8hBx 1tVMwEOVzf/h2gWJ+7ppPaAYKFEhnzeixkGrgaYhhwN7orQileDHzx76uUG71PN3vcGR Gt/1FT6bAqo1lJ5qM46UDjmyBEUt5zQHzBdFYAI2PwrgRnJcgD5WyFuziin0GxBOUXsA 58EYFCrar31tY9GmDFV8ZNoCs9x18LQPACTq+7VhGFWhfYzvnubMOCMkveV3dzN2rkpv IptghJLT5ZPeWv5nZXJDyf2rugFqbpMR+ly8RIQZl0dONitVw1cNo8IeDd1ulgfG4e5P rw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773058581; x=1773663381; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=25TZNPEwwPkYTHAgMRLn+Sz9ICp+r6IePTSPwttEBwg=; b=COmF00+ry+sg2pAMHlerxQbMLMUs9pwvyalohpCH9+DVzZxQstheaRQD/4pa7p/BX/ OxbBnTcDJkw9KzsQuFrLuGbpkRmT4af2SE1+AzIv1wjbJeB7CL/WQj2vFRCh93ZrU2bw Nb8/QjScdS+RZub/1rnilbj8FeeCjBCy9sxKZQHMvTTDCO/Cjxww7Ofag6geLZF6ZnCK P0neXlxIEoezo5prb1pGmFCjssd2hR3FtrSr5Yo2EI2tAxHgs4W2KvR6Ug+CQ4LqR6rd /jGL61SIMxgTTLDzr16U7lO1IzWt8ZqGLagUD8r78pHbvMKbyMBXzi3g0xMzHKg4SN7T 0w6g== X-Forwarded-Encrypted: i=1; AJvYcCW+z8sgMjrHUOyjGvPErhGIib2z7ASGYPecRnPh2dRuPwLqmqPhs9QzFaZd8Diys2UxMLkD6BiFoJjtrbk=@vger.kernel.org X-Gm-Message-State: AOJu0YyUGxlygb1CzyEbDfMN0rVQmNvHwVpRS0ooSKo3jbAY/hCqVdDq mYaOQnb7/pE2TrHJaS7NWJ0UqVA3qdzE6ov10+Wq/2qmbnm+EtDmYHIh X-Gm-Gg: ATEYQzx9XPDDzuOyAiuTqwjV/Q3WxNrD2jG3Zh/j9fF/jp9qeln4xLHZ8McnOW9ihOf LQ01w8kzSJA8gjfiWo3AsgQv4KZZ6V0TQqTObIcubzOw/zFM7N2r1jdKUo8E499StZNajNTUo9w aoUV+CbOpoHP4h+WOgWxXIdcCwBweZq+zlK9ElbaSZCn07qj0xbNWnWEGnS4FKu+RcrnzbdmkCa xGXWGWhVD/7xH/hgG8dSK/USlR9T3llEKJfNUAtPQpDIywJqQYY6/iZOkcNJfDesrZnz0B4D1ts p/JTlzXtSogYK4SVB5gMlO/rChbCt+6OtkW9lyhgKu5q5bvZXpAtmCdw2WJ4v50YFZN7cx5TUur /KdmNby207MxcsAXttshvvX4nz2ffp91L4jHQCuwAMQ6dAZDk3/Asvj6hmWwQPcPm2E6+SYoP5t 0IaQy0XffqSZ6zvX8FZ8pxdJWivjpcFq+X9Df7 X-Received: by 2002:a05:6300:648f:b0:394:427b:eab with SMTP id adf61e73a8af0-39858fb2ec0mr9506675637.11.1773058581257; Mon, 09 Mar 2026 05:16:21 -0700 (PDT) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:a816:d74a:dc19:1ab8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e0a7156sm9525693a12.2.2026.03.09.05.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 05:16:21 -0700 (PDT) From: Felix Gu Date: Mon, 09 Mar 2026 20:16:15 +0800 Subject: [PATCH 2/2] soc: microchip: mpfs-mss-top-sysreg: Fix resource leak on driver unbind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-mpfs-v1-2-0dd89f34f962@gmail.com> References: <20260309-mpfs-v1-0-0dd89f34f962@gmail.com> In-Reply-To: <20260309-mpfs-v1-0-0dd89f34f962@gmail.com> To: Conor Dooley , Daire McNamara Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773058576; l=1123; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=O/VunH/9UjAoQv+nRiPfxssAhhHa/MPTIs1QTwQxRWg=; b=w+0DV0seDzjqyUBQXtNmD6gk/M/p8cRtUKvcKz/I7wfEIZoZ1Zgb6MOoHJBN6AC+AjPGp1zHn KE9RxgHDkEcAfXJNS7fS7a/wS96k2XOaRxV1HO2mQBCuUkVqjm2i0S0 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Use devm_mfd_add_devices() instead of mfd_add_devices() to ensure child devices are properly removed when the driver unbinds. Fixes: 4aac11c9a6e7 ("soc: microchip: add mfd drivers for two syscon region= s on PolarFire SoC") Signed-off-by: Felix Gu --- drivers/soc/microchip/mpfs-mss-top-sysreg.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/soc/microchip/mpfs-mss-top-sysreg.c b/drivers/soc/micr= ochip/mpfs-mss-top-sysreg.c index b2244e44ff0f..b0f42b8dd3ed 100644 --- a/drivers/soc/microchip/mpfs-mss-top-sysreg.c +++ b/drivers/soc/microchip/mpfs-mss-top-sysreg.c @@ -16,8 +16,10 @@ static int mpfs_mss_top_sysreg_probe(struct platform_dev= ice *pdev) struct device *dev =3D &pdev->dev; int ret; =20 - ret =3D mfd_add_devices(dev, PLATFORM_DEVID_NONE, mpfs_mss_top_sysreg_dev= s, - ARRAY_SIZE(mpfs_mss_top_sysreg_devs) , NULL, 0, NULL); + ret =3D devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, + mpfs_mss_top_sysreg_devs, + ARRAY_SIZE(mpfs_mss_top_sysreg_devs), NULL, + 0, NULL); if (ret) return ret; =20 --=20 2.43.0