From nobody Mon Apr 13 07:13:07 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B1737F8A0 for ; Mon, 9 Mar 2026 09:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773049709; cv=none; b=hxzUpsRTIg1Sv9bxLgY6d2ZFo2lFNxwJ13CEAepoz9KOeLhv76XXNNw28TVHBju7RNrXg0PD4CFihMwqbWHFqcQWkmIpc6hE89JH9qU8f3QMFFgh8sFb5EHnKXjFGQZ5512m3OzUKUECeSvA4OBqu6z8Yk+P5bOjK1odPw6+skg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773049709; c=relaxed/simple; bh=QrDgnVgN9QaZlb9Pjj5rr7RirVn5w3K3JbRC4UnCJSw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XXDeRYHiAq6xiMALtFHlFcux93J/7V8IoqqZeuhaNsdxK+hRat0fO40vLTKJeGfXL0oRzsLkrFN76O54T71SjEq8BoUVXJiol+XMtmmzyGyJdSRX987o7c34Z/FGYMxrAy5IersPJGg8kIR97HRqJ1krbvr41YqfIOZ/BwKuSDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=biTdSM1m; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OlE9Idj1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="biTdSM1m"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OlE9Idj1" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62981GNq199406 for ; Mon, 9 Mar 2026 09:48:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /lTbduWn2JF6hflXdfZAESir+Ygdnj8CJ5d+aQvJmBQ=; b=biTdSM1m4se71qQ0 hxdNSuTApqld7yrnRvd4vLWTmunTo5HTJtjxq/as1tzfoO7TVigOzuJCymH9iL1+ Xvxc8gJcvyDHHzBH4G5c470xx0KLetraxqWSO4mV3V/ZYsWDe5/ckQ3VmdS58XL/ Xr/j8afTcrY61ue6/HpcIXyy3f4Ih7sHnnBNa5LBg2g8UvISSy3QyPs8h9SFv449 u62vMd1JCy+GUGyfvOXr0pVYzP+6WMXPR+L+yrNwkebHJU66QrQt1fgWPCRj/5Lk 09JPgPF6WG29FM3sHJcLeO55KE35rTc/bl4/Z3ql4rDC1DPz3u7VFyo76H+J5dtd qfQuKQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crc3vcu00-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 09:48:26 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae65d5cc57so308337325ad.2 for ; Mon, 09 Mar 2026 02:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773049706; x=1773654506; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/lTbduWn2JF6hflXdfZAESir+Ygdnj8CJ5d+aQvJmBQ=; b=OlE9Idj1xYh0efEYnDRwF+L+Z1D3ct1dKYQiCFaCBR/Qza8Hq7TFFd05D91XnF4Qsp INUBJrmocEx/ylYHChSB4PIFZB4TzIdONXQKZpuMGqbgIkfs4g5QLPbqSVBujyEW1PT9 ixl/ULQvW72SOQd3EW9jyTboJlkgjg9X3pTfMpuB4nYZbAnCXdPnYOds6+5P7FkAGuum /rjR8W/Wg9id0l7agb7X+v45jC8M6mU6TINhZuCL4jF1/9T72cU2q1EJBz2EZX1hsL9O weiOyHO+AliZnRUgjK47h6qOoHv0LkETvqRtOQil/dZ0/oisPl8lU95XwO7XNwPa2x9e uy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773049706; x=1773654506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/lTbduWn2JF6hflXdfZAESir+Ygdnj8CJ5d+aQvJmBQ=; b=LXuc9UhO0EADDRnRcb5VZJ0kIMYdik1lixxNwFHF4g4zPo34WlBgK2K7O/9xt4aQcE R1E7D+bu2Lo2j2GwqxcmwzNHAjTSry6vOzQYcnmk2exLDHlRICPknDtFsCLLc+9zaVpK U4iPDHY0vonmQRy0gPhVD/4hJhX4vFDT5zpKkfwalWBDZsayfiiIz7d1CSoerJMjIcCE /8HNhdRgmKzApbc/q2Zqat9jEnkQX1NitRn42Tfav520tNjPZ3MlC3b5fo/UySfMuOwr Iw7/0P6ExthPRHI2SJHR27eLF6iOyoHc/HK2NSs0WMsu99MKGJz0Nrdf2qfvRMdwkJ7W n4dA== X-Forwarded-Encrypted: i=1; AJvYcCVjMQg4CM/AsMDThWRsDMkagoDa7YOFxpbh5ON/j7HQUjZFXEwz3+cng42GbkuAStvvCN/R5NoIJhidsxE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7nH2mD8fDuPxXUbduQev0/JqQ2n8zDOvhs7oeNHUTd972boxs fBplYh47FftpYGclJUywxC4I4AlAa804Wwzphm5GViacvn/cwbj/hMXs3UVQ3z35lJYH7L5fA+V Sq8oizKrm8eIEPrKqyiO077TNp1GYEsrRZXBH9szALCpwQO5AfKa5MhiB1Yd4ncFIZI8= X-Gm-Gg: ATEYQzwcIAF5qcf0Oatb0cGdNWYNgi7TQy2y7D3k/FlnVrSwhJKM8h9/gQwdf33siQD 5irEYAwrDbU6h90agzUDMHT9RSAQct7yqfVGAOo27uAhN49LF7IdFZW53G2m3td8HslQaZgUHM9 L1BKgBy8v/ZvZvqmuXyv3rPgrQRw0n/xNBtwjj09EwDEXenmJbU5UBMOZVz5QIMbstwXYeVk0OT lFDN5Czg8on+ndO4kNvWGOlGwRMcpn2P0O8xesKlpttcfgPj8O9QqQFwDlKua8/r9zkS6n/i5UI 2jZk2YEdUSOCIPk1YDGRH/5ICMVIpOPGO2VFUgzy9StOKIdK59zVi1wWZPazCTIg7JI2xk4czq8 gaMP4SeA+3Cz2nwsVa3XiXTrcd4PPttrISfrY7X6kxAdAx/pUSZZkR/YmS5ha+OMiBxrt4Vm1gL ahdNlgAnt4 X-Received: by 2002:a17:903:40cf:b0:2a9:5db8:d651 with SMTP id d9443c01a7336-2ae823b349dmr103277375ad.25.1773049705968; Mon, 09 Mar 2026 02:48:25 -0700 (PDT) X-Received: by 2002:a17:903:40cf:b0:2a9:5db8:d651 with SMTP id d9443c01a7336-2ae823b349dmr103277085ad.25.1773049705400; Mon, 09 Mar 2026 02:48:25 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e575e6sm104948435ad.5.2026.03.09.02.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 02:48:25 -0700 (PDT) From: Jie Gan Date: Mon, 09 Mar 2026 17:47:42 +0800 Subject: [PATCH v14 3/7] coresight: tmc: introduce tmc_sysfs_ops to wrap sysfs read operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-enable-byte-cntr-for-ctcu-v14-3-c08823e5a8e6@oss.qualcomm.com> References: <20260309-enable-byte-cntr-for-ctcu-v14-0-c08823e5a8e6@oss.qualcomm.com> In-Reply-To: <20260309-enable-byte-cntr-for-ctcu-v14-0-c08823e5a8e6@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan , Mike Leach X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773049687; l=5200; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=QrDgnVgN9QaZlb9Pjj5rr7RirVn5w3K3JbRC4UnCJSw=; b=yxl9m8Ty4i26yQ6UJTJPydSgQqLp+CGWhP1ClwC6hg5uLbQ/+Vgjx+t+odguyBG2oDLHYXcn3 h7WKUo6vdHHBOc1Ah7ir+FojeGznSGL9aQnqEDrOwUW69m2LqA6SV9e X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-ORIG-GUID: sdwTkdps_6KmKhJUuqdojgRe77syLwT_ X-Proofpoint-GUID: sdwTkdps_6KmKhJUuqdojgRe77syLwT_ X-Authority-Analysis: v=2.4 cv=OOQqHCaB c=1 sm=1 tr=0 ts=69ae976a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ia3uihG--C1vaqsH_ucA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA5MCBTYWx0ZWRfX8tU2R779UjmP POS3qNRLnbgXqx3f4IVZnwtMcIHEs6sPRnls+JtWq7tWsOumEDqVKIERTXpSx5PJvkLsgg2dzaE a2nVc/vKvcCAlNw7EL1DplPOvHvF4cXPWHY4/loyf80yYfUDlkN+vUkq+hlMV0bjQXd9B7QhQeO XuaLgJjYe0i37NG6iQc4z0e2NmtiPRbS/HopcVCFa/5rZ67pQosIMNOJKPG2y0SJOcltIF+NqXv DEBsSeBC/l1YKKCXxrGW9/mnNJPlWwRGoNmQMOEg94kHNFV23NINryfGV8Zeamq+NfBzaKUPB22 SfQFsUdvfGmCZF2NYytQ+uNFFIqVzChPR/UaYTLSy3WJbtnT3eIE4+umtjGISzeTUBF1Ta0urYb BORt++Uksazr8lBdIvfyMVBlEAjuMvbbTmHb0X2YXCJuBb4mAbI8uhtycaeZJXEcVTX4mfgk2EA M2zxAsf0X862Z4SpGRw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090090 Introduce tmc_sysfs_ops as a wrapper, wrap sysfs read operations, for reading trace data from the TMC buffer. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 51 ++++++++++----------= ---- drivers/hwtracing/coresight/coresight-tmc.h | 15 +++++++ 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index bac3278ef4dd..110eedde077f 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -228,17 +228,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvda= ta) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_prepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -250,17 +243,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drv= data) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_unprepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -287,15 +273,7 @@ static int tmc_open(struct inode *inode, struct file *= file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } - - return -EINVAL; + return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp); } =20 static ssize_t tmc_read(struct file *file, char __user *data, size_t len, @@ -764,6 +742,18 @@ static void register_crash_dev_interface(struct tmc_dr= vdata *drvdata, "Valid crash tracedata found\n"); } =20 +static const struct tmc_sysfs_ops etb_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etb, + .read_unprepare =3D tmc_read_unprepare_etb, + .get_trace_data =3D tmc_etb_get_sysfs_trace, +}; + +static const struct tmc_sysfs_ops etr_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etr, + .read_unprepare =3D tmc_read_unprepare_etr, + .get_trace_data =3D tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret =3D 0; @@ -823,6 +813,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.sink_subtype =3D CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops =3D &tmc_etb_cs_ops; dev_list =3D "tmc_etb"; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups =3D coresight_etr_groups; @@ -835,6 +826,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) idr_init(&drvdata->idr); mutex_init(&drvdata->idr_mutex); dev_list =3D "tmc_etr"; + drvdata->sysfs_ops =3D &etr_sysfs_ops; INIT_LIST_HEAD(&drvdata->etr_buf_list); break; case TMC_CONFIG_TYPE_ETF: @@ -844,6 +836,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.link_subtype =3D CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops =3D &tmc_etf_cs_ops; dev_list =3D "tmc_etf"; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 5ac07e8dd5ff..69d55ee3895f 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -259,6 +259,7 @@ struct etr_buf_node { * @crash_mdata: Reserved memory for storing tmc crash metadata. * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. + * @sysfs_ops: Read operations for the sysfs mode. */ struct tmc_drvdata { struct clk *atclk; @@ -290,6 +291,20 @@ struct tmc_drvdata { struct tmc_resrv_buf resrv_buf; struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; + const struct tmc_sysfs_ops *sysfs_ops; +}; + +/** + * struct tmc_sysfs_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct tmc_sysfs_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; =20 struct etr_buf_operations { --=20 2.34.1