From nobody Thu Apr 9 12:08:38 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79157345757 for ; Mon, 9 Mar 2026 14:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773067171; cv=none; b=QBJH2O/K8RgTN4uhZSboNNjGqNISOAUdlsoUOOLWcYfHaxg8Q8xdsaPdI4iN6TDY7v/vq3okN+LFLEyzwA04RZOMf4Dy8xqzAmjpMn9pq1q+XxQgooLwxCYUM5qJ7dZXl08o88CCs57S6dgmwZaIuAlI/W8HkE7R5QPqReCsSdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773067171; c=relaxed/simple; bh=KGjGlg9+FVN2/hOowvBTMcATr+J7fq3fwpj4roBVI74=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZqkPkvmFtTF5CNiw6xlpwg5TSoHcqdoAhsbD6f0sYwuvTJVgtd2Gft9vayiaLEjrQH8CEzEXXKG29YonuneORDsrs0b88Q4V/k64MeMDPE9byS7YHhyn6q6Npp2FyC04sFijEUKJSZRYn6dwwpBlwgTgrKQgGuQWp4uh/UeAPOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L+4bLEbP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=abaoS8Uy; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L+4bLEbP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="abaoS8Uy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773067167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yYJKtYDTWyz8NMDHb7DCD1Fd834dm4nETH5Ial4epIw=; b=L+4bLEbP3nF0a3rPl99XmTvSUpEAneFL5l5S2kHJdj9MjzHeCgk+IL0+JMuqUrdhOGH9cM 1V2J6mikupuoAp83CPwfuspp+lF0f7G8fsqsVP11XHEpE6dcap4hiWkfYAyaFnbE8mERKC Kx+t4n8+mM06DmODAQGXCN0qU2VzAdA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-xcvvw_-bO4G_T_U8HZinLA-1; Mon, 09 Mar 2026 10:39:26 -0400 X-MC-Unique: xcvvw_-bO4G_T_U8HZinLA-1 X-Mimecast-MFC-AGG-ID: xcvvw_-bO4G_T_U8HZinLA_1773067166 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd76ff19d5so1171225185a.0 for ; Mon, 09 Mar 2026 07:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773067166; x=1773671966; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yYJKtYDTWyz8NMDHb7DCD1Fd834dm4nETH5Ial4epIw=; b=abaoS8UyqX+hkM/df44OxvX0N/P632TxuTk4Eii1YpEsYUh8It1PVRn7Uge2h/Vqa4 tgp67l2qv8vjDjAHtqE7UYd/GWNLVwwiJDuROP2xvTW3jz5empt/rWpJjF6XaI1upC29 5ZXH/yO6M9s+a6kydEp6oGlAKGVXpEuG7kpa/U40h0Dq5LHVY1Isk6aOAMKHFMSVVstp hkqIbpg9AKhA/Nh5OBgWJ7X+mdGBU9ODtBxd9Na+IQFz9RFzS4njYihZoD5hgtVwl4OX 6bBvImumUWo2Aj7ouWDcAzYrKOujZ2Hz4YT8Z9a6MW7Ly3cfBot+87K00huw3Vlp/i8W RT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773067166; x=1773671966; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yYJKtYDTWyz8NMDHb7DCD1Fd834dm4nETH5Ial4epIw=; b=ohDlH3REzhiDMVcL3rlyxDJ77LBRboYykW2GXsHgytyD2J0KDZW2xOfdN1J1qUFH0n 8MBGv4uy9WA22mQUm5CdniSzqJEwSKiCN+Kld8k2tVjyfTw+VXRZJOY6o9ASSb7Ijw0m QnDtkU9vq1XcsEb0TtQrNFxoFpRKRY0iAyJVVfTW6c5u19Bprdk2UOxMXHIWtFTsm1P1 qwp1Cb1qcizX4FeV0o1G0GvtzILRy93Wislr01fQP3sq8NwqcbOsl/o5NTButfS7UhTD qnxcbRFB+fC7iTUq9+Db77A0jcvsMz2oHTD9RuJc1jhJ4gAKX5+lQiwlYQRaEfGiAnay oMCg== X-Forwarded-Encrypted: i=1; AJvYcCX2iRnzsPInjhDTG7o2shbpg0hT7jbLgm6AqvWqgWZ0Gy1/GJqrE5IRJh+hGOSUBb5bfpn7jY45dRkc144=@vger.kernel.org X-Gm-Message-State: AOJu0YyfGekydlEy1fnJ96sDVNaiTguRBjf4uWj+iw41pgKh0JPTMr90 L0cQSd1182Fm4jkOz6Olo9A3dfdO8xHVltL/HuX7AULDzOcJfPJys01Ay09X7DrJze4NND5RFMB 7Q6q5JBs0YkaE+qQDj0ZTQL/pUbjQLgE9C3WbfejTrLfaThJ9URXd7qwniaayMdX7cw== X-Gm-Gg: ATEYQzyvDZHQhewPCYfuYsRCWJQJYIbpr0bQo5QbrynieCMOaWSrA8P2EgKXqpTXWgC otBW0Pm0Vth+6wTxcvVUI+sLquywDTTmeiMiP6jP9JtDb8yWomeEPsQ/r+hDW5UabTEVEAIOBjQ /n17r8epwQt9xo1rTS8YnITfc7ipBI5F4gCiAl8Sla9WgvCu4xRu/OFJFGsj0o7ry4bk8uy65xC 0mXh0Yrr4G4SK2j/xD/waTxKL/v0RRykJ0xUM3w3QPysSVRyocj4oc+oqXzH5VIx8jLoU95r9tm SjunylMaIN2ePBMCxQQu8Pa2tJc2PBRU6+TVeiaVRRnvfq5vVIPzIV48x8BLCoLrgOZmo6O5SdB dK5v/z4z3I11h+nQw0JzuQLZZyJ5s26S2P28i97dBgHbmyTyyxHcipCaE/XCyzA== X-Received: by 2002:a05:620a:4623:b0:8cb:3f0e:7740 with SMTP id af79cd13be357-8cd6d4d7cb7mr1379568685a.51.1773067165614; Mon, 09 Mar 2026 07:39:25 -0700 (PDT) X-Received: by 2002:a05:620a:4623:b0:8cb:3f0e:7740 with SMTP id af79cd13be357-8cd6d4d7cb7mr1379564885a.51.1773067165125; Mon, 09 Mar 2026 07:39:25 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd6f49fcafsm756064985a.16.2026.03.09.07.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 07:39:24 -0700 (PDT) From: Brian Masney Date: Mon, 09 Mar 2026 10:38:41 -0400 Subject: [PATCH v2 02/12] clk: test: add test suite for CLK_ROUNDING_NOOP flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-clk-det-rate-fw-managed-v2-2-c48ef5a3100a@redhat.com> References: <20260309-clk-det-rate-fw-managed-v2-0-c48ef5a3100a@redhat.com> In-Reply-To: <20260309-clk-det-rate-fw-managed-v2-0-c48ef5a3100a@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3612; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=KGjGlg9+FVN2/hOowvBTMcATr+J7fq3fwpj4roBVI74=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDLX3e5dXtd9Lef2xnV/4++Knb/2Ru764qlPXoq0GYj6s go0t5kHdJSyMIhxMciKKbIsyTUqiEhdZXvvjiYLzBxWJpAhDFycAjCRyM0M/6umSaUXOLMUKXu3 cS1heGep0B6/znvrDq0r8ZNXBR4MfszI0Pm1Nzu527333bkT6p5LXvt8PpGcdHCe5tG9J1tOPG+ YzQ8A X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Add two new clk tests related to the CLK_ROUNDING_NOOP flag: - Test that clk_hw_register() fails when determine_rate is not set. - Test that clk_hw_register() succeeds when determine_rate is not set, and CLK_ROUNDING_NOOP is set. clk_set_rate() works, and clk_round_rate() returns the requested rate. Signed-off-by: Brian Masney --- To: Michael Turquette To: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/clk_test.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 85 insertions(+) diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c index b1961daac5e22fb84f493f04feab1ff94a975d90..6745b63ee4e5188665825b56c5e= 0def51d68e10e 100644 --- a/drivers/clk/clk_test.c +++ b/drivers/clk/clk_test.c @@ -3541,9 +3541,94 @@ static struct kunit_suite clk_hw_get_dev_of_node_tes= t_suite =3D { .test_cases =3D clk_hw_get_dev_of_node_test_cases, }; =20 +static const struct clk_ops clk_no_determine_rate_ops =3D { + .recalc_rate =3D clk_dummy_recalc_rate, + .set_rate =3D clk_dummy_set_rate, +}; + +/* + * Test that clk_hw_register() fails when determine_rate is not set. + */ +static void clk_test_no_determine_rate_fails(struct kunit *test) +{ + struct clk_init_data init =3D { }; + struct clk_dummy_context *ctx; + int ret; + + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); + + ctx->rate =3D DUMMY_CLOCK_INIT_RATE; + + init.name =3D "test_no_determine_rate"; + init.ops =3D &clk_no_determine_rate_ops; + ctx->hw.init =3D &init; + + ret =3D clk_hw_register(NULL, &ctx->hw); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + +/* + * Test that clk_hw_register() succeeds when determine_rate is not set, + * and CLK_ROUNDING_NOOP is set. clk_set_rate() works, and + * clk_round_rate() returns the requested rate. + */ +static void clk_test_noop_round_rate(struct kunit *test) +{ + struct clk_init_data init =3D { }; + struct clk_dummy_context *ctx; + long rate, rounded_rate; + struct clk *clk; + int ret; + + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); + + ctx->rate =3D DUMMY_CLOCK_INIT_RATE; + + init.name =3D "test_noop"; + init.ops =3D &clk_no_determine_rate_ops; + init.flags =3D CLK_ROUNDING_NOOP; + ctx->hw.init =3D &init; + + ret =3D clk_hw_register(NULL, &ctx->hw); + KUNIT_ASSERT_EQ(test, ret, 0); + + clk =3D clk_hw_get_clk(&ctx->hw, NULL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, clk); + + /* Test that clk_round_rate() returns the requested rate */ + rounded_rate =3D clk_round_rate(clk, DUMMY_CLOCK_RATE_1); + KUNIT_EXPECT_EQ(test, rounded_rate, DUMMY_CLOCK_RATE_1); + + /* Set a rate and verify it works */ + ret =3D clk_set_rate(clk, DUMMY_CLOCK_RATE_1); + KUNIT_ASSERT_EQ(test, ret, 0); + + rate =3D clk_get_rate(clk); + KUNIT_EXPECT_EQ(test, rate, DUMMY_CLOCK_RATE_1); + + clk_put(clk); + clk_hw_unregister(&ctx->hw); +} + +static struct kunit_case clk_noop_round_rate_test_cases[] =3D { + KUNIT_CASE(clk_test_no_determine_rate_fails), + KUNIT_CASE(clk_test_noop_round_rate), + {} +}; + +/* + * Test suite for CLK_ROUNDING_NOOP flag. + */ +static struct kunit_suite clk_noop_round_rate_test_suite =3D { + .name =3D "clk_noop_round_rate_test", + .test_cases =3D clk_noop_round_rate_test_cases, +}; =20 kunit_test_suites( &clk_assigned_rates_suite, + &clk_noop_round_rate_test_suite, &clk_hw_get_dev_of_node_test_suite, &clk_leaf_mux_set_rate_parent_test_suite, &clk_test_suite, --=20 2.53.0