From nobody Thu Apr 9 13:22:40 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE33033B97D for ; Sun, 8 Mar 2026 17:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772989986; cv=none; b=kl/BzziG/hISHpjq+L8vNMk84h76BbIG8INgFzF7BPCgIovYOrerHVLyyncj1A5Gxoph0wmRO5pSJqNgraoTdU6QwEZDC14+S8TVAMmSXCT3fAPPuIAYjCUVV4vqG/5JUYIiZJpgg1GPg2T0IFlqLk7D6QshcDwjafot4NYbUro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772989986; c=relaxed/simple; bh=M758VzHgotlN+kfEhAbWbWKyGxRbK2JrlTQD1v/8ieg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WeqhLV1bvmaV13iRFLEgZpr7TQMXMKk+VMSsKJubo42zh/NnLnMhe7rbvAW5zUoBamyks5+OqtYDKbE9q6KlmYTKSNKEu263gMeI3TzQjxdtABcyaw3rrEI1/t4t+mNHfONEBaMs7hvnb28RKyL2XQHBKZ9slH/B1ObvFpipfB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nwo8qcOM; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nwo8qcOM" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439afc58ac7so8105707f8f.0 for ; Sun, 08 Mar 2026 10:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772989982; x=1773594782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aLX5DYLUxvDUfj3CKP+gBQBSQ0b6Y08NrMQKc5dZFp4=; b=Nwo8qcOMkzHKpJvmxVu5NwayL14t49rXBKnCxp+nB8pw//MGuxRA/xWy44z/kbfrh7 1oJgMYKhZ5EqVPH0j6AGUtlUErhjjP3k2wsVr1J/QOMN6w+lw/tlrn3ypoW4ESSBOSan 3C6fMbdgueQvXJx6hDMJITV2Na8MnKWx2cnlnwzDB57OZRxjXmipXAlWTDqpbuSUl5hw gTFPPazuy/s8wsx7sfP+zXmBrK+VDN4We7eVhA6pAOaKGiLcSHDwyL1W4Y+4EiT8YpOD JLFovbJptxbYZrqrRbvxVta93yp4uXvWvPYLn/s6rQa6KZB/5v9qhXseihAMIBxHJ7dD NuKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772989982; x=1773594782; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aLX5DYLUxvDUfj3CKP+gBQBSQ0b6Y08NrMQKc5dZFp4=; b=kkUq8VoTB3r0gVFLut/dsxT1fdfYGXNlj7m1Ya/781PHp+owjMsWt2i0GaXOU9LW5M nQjJLGUr9LShD52Tno+gfiGPs4hcwJ+eXQqONyKUoQ48edIdhJA4YRLesTPjFE/nqIIg 1MdXmw0Rg61lVUC/DY+h2fJAF0unuw0DOwVW2VfqMRBMUS42qJuzqf3MYv+x6R4AVuZl M2lx3e/znSR3fRET9ZfjRwoBWx+dUHTA0K744bwCgLiS7Z8t1TeUyNZwuV/kMASuKOI4 Ys30mJYi7Uf7kgk7LsB1L9AVjVZZTNHIOen6glz8o3osSPwe10uA77ULRdo6fYmNrv0U XSHw== X-Forwarded-Encrypted: i=1; AJvYcCX7xGlOh6hOKrnpYm6G5MkNGuspm8H3QFIayn/OjXS0npnm2BMckw1dp3XhEz3r2ohbYPMLKfOFJGbW9hs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6IDZxa8FNk7RdyECzoVLSfigwQPUA9ERhL+IpvgZbC3hE3NJA sOdeGz6sYF4jp0lNhsBvPMJgZUFGd1oWAchMp2LzUYyQ41Osig0zTjsA1OAIYcL3 X-Gm-Gg: ATEYQzyKSgNyfw7Ij+ZpRL/Gj0BtRiFr65mDiVxnhzDGfiwWoroaLWr32S+IF2IRoAH A9yhNXCmxMab9d0JAxJXqTuwIjWrpno3Hqk3RX9wZSDKinaxnKJ98lGbbvEb5kUNRK0xDWp7Nzr aUn4xnmX2Ojtz0aCTLq8nEoZNh7R8oxTQ72MzXUcnYQzjYPU2QbwmDJmA4c8xkoyltDddrOInM8 uvrgCZMD21Ec05w5KrP8kq+h5Fv88S/N5R9npurTXOYZ68zfBsIBG1darG9L7tAS6RxJCHYCG6Q eZ3moYl3ZrszedcR6+EWmLlQFD4GOBXncDAbSw3CR2MO9uZwDS4B0gtvru7kIqn6aeQRleSwa6m X3xQurPx78yyIs1s8E13hnP0v1jk/FLWlh3AhnwVb3DQjKGBb9IfRoQVEkUdhfPqp5modQKycf3 wI5FT0d8EjA5iVDoAR8OPoOmlsrrnRKwAvM6CW6Ax6jnm5sJ2ZdZXwb6WQ9+2gH1SNISSKMbZvz Uu0vqJlKxMd9G6mY99B9lhhGZBuCtNJDFCF+SO8vvY6 X-Received: by 2002:a05:6000:40dc:b0:439:c9d0:5fc2 with SMTP id ffacd0b85a97d-439da891b2cmr14527489f8f.39.1772989981670; Sun, 08 Mar 2026 10:13:01 -0700 (PDT) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2bdf8sm19871194f8f.25.2026.03.08.10.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 10:13:00 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH RESEND] x86/local: Remove trailing semicolon from _ASM_XADD in local_add_return() Date: Sun, 8 Mar 2026 18:12:35 +0100 Message-ID: <20260308171250.7278-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the trailing semicolon from the inline assembly statement in local_add_return(). The _ASM_XADD macro already expands to a complete instruction, making the extra semicolon unnecessary. More importantly, the stray semicolon causes GCC to treat the inline asm as containing multiple instructions, which can skew its internal instruction count estimation and affect optimization heuristics. No functional change intended. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/include/asm/local.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/local.h b/arch/x86/include/asm/local.h index 59aa966dc212..4957018fef3e 100644 --- a/arch/x86/include/asm/local.h +++ b/arch/x86/include/asm/local.h @@ -106,7 +106,7 @@ static inline bool local_add_negative(long i, local_t *= l) static inline long local_add_return(long i, local_t *l) { long __i =3D i; - asm volatile(_ASM_XADD "%0, %1;" + asm volatile(_ASM_XADD "%0, %1" : "+r" (i), "+m" (l->a.counter) : : "memory"); return i + __i; --=20 2.53.0