From nobody Thu Apr 9 13:32:58 2026 Received: from ewsoutbound.kpnmail.nl (ewsoutbound.kpnmail.nl [195.121.94.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9F7236C595 for ; Sun, 8 Mar 2026 13:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.121.94.167 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772977051; cv=none; b=WBjdabOyS3t39eW0/Sq+fH85rSJOaXdAjb7/9uHxPILtKUZcL78yeLPc/uXSkw9qXID7Lfg6+6lsI0tKpL/Pdo8qTJU+xAsId7ChFkB6CXTeTnejlmLW/6pfXTEi+5IGmMHT5FLBBiJmneAs+dw+nU9zaTkUQHq53KEuhsVu/d4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772977051; c=relaxed/simple; bh=0NvfC6vfW8WYD0Nk6N7E/5rGJ2db5KGh3f9xQYzzeOc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FeFGS/srveuIbGo0NeStka4L0Umpddc5gocaRLnxRNUJInyiRW21xEyXlwYk+PSEy5sSXp1avGrKXZXGsxLDhWLJcePfTXOO9UBfpfG7rytXlrmyFIjcHhtL1ljOyM4fn62ylS0m0e/2EkEvac+S9d3T+3QZS/QqI+7FcFQV5T4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl; spf=pass smtp.mailfrom=xs4all.nl; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b=eAanaU6m; arc=none smtp.client-ip=195.121.94.167 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="eAanaU6m" X-KPN-MessageId: f248eed0-1af3-11f1-969b-005056abbe64 Received: from smtp.kpnmail.nl (unknown [10.31.155.39]) by ewsoutbound.so.kpn.org (Halon) with ESMTPS id f248eed0-1af3-11f1-969b-005056abbe64; Sun, 08 Mar 2026 14:37:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=xs4all01; h=mime-version:message-id:date:subject:to:from; bh=3tY10PRCxb6Spz7EbJ5jkohqOnUvfcSP7anbBvZfeNY=; b=eAanaU6mSxJvrFs+RnW7GLxAGDnqxJw7rASXFTXXf6G3o9JWpygLG/eAuPR4TdZjtsm5Fc9Cg2a4f Pus9G1PbGYci7krebCtcnoAoE6s/+qICqgmVDpPgzxTbuYSfgoPA1V80Gv3s5+haOH6wet7JCtJBoG dnhoWYftR01FourzX5mwkMvGCsgYksSXJPUu3Oy36nbp5hAGAGeaQvLcFQ85Ig5V25xWREt4yTNa8o wyzz3mXc4xpY7+m5q5Dl8xfrOGOXuDCzIlrvNlSK+36/EfKrQ7ByOD/r3DFbjXvZxL3mJFQAm3ogRG z9F7pfNDy85COksrYrvdNpujz3UE5qA== X-KPN-MID: 33|JRRn5BnP7NQIE72njQ+Uhx5gaQeADMJWO/cc2ll9gBQzkoawKrwEI6ECzrm/MP2 ro1ndyGrPPLQtwm0zl9lO0G2ZjNB8fnA760gEmFVw/u8= X-KPN-VerifiedSender: Yes X-CMASSUN: 33|JvVbe5geC7FkzHxUFmMGtgvPTQevq4ZabhMT9HBBuUyDZqz0YQMzCElNJ5bFTuu JTKcwkN2GyPco2cwJExlVnA== Received: from daedalus.home (unknown [178.229.45.71]) by smtp.xs4all.nl (Halon) with ESMTPSA id ef9dfa17-1af3-11f1-8011-005056ab7447; Sun, 08 Mar 2026 14:37:26 +0100 (CET) From: Jori Koolstra To: gregkh@linuxfoundation.org, Kirti Wankhede Cc: Jori Koolstra , kvm@vger.kernel.org (open list:VFIO MEDIATED DEVICE DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] vfio: mdev: replace mtty_dev->vd_class with a const struct class Date: Sun, 8 Mar 2026 14:37:33 +0100 Message-ID: <20260308133733.1110551-1-jkoolstra@xs4all.nl> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The class_create() call has been deprecated in favor of class_register() as the driver core now allows for a struct class to be in read-only memory. Replace mtty_dev->vd_class with a const struct class and drop the class_create() call. Compile tested and found no errors/warns in dmesg after enabling CONFIG_VFIO and CONFIG_SAMPLE_VFIO_MDEV_MTTY. Link: https://lore.kernel.org/all/2023040244-duffel-pushpin-f738@gregkh/ Suggested-by: Greg Kroah-Hartman Signed-off-by: Jori Koolstra --- samples/vfio-mdev/mtty.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c index bd92c38379b8..792f5c212fd1 100644 --- a/samples/vfio-mdev/mtty.c +++ b/samples/vfio-mdev/mtty.c @@ -68,13 +68,16 @@ * Global Structures */ =20 +static const struct class mtty_class =3D { + .name =3D MTTY_CLASS_NAME +}; + static struct mtty_dev { - dev_t vd_devt; - struct class *vd_class; - struct cdev vd_cdev; - struct idr vd_idr; - struct device dev; - struct mdev_parent parent; + dev_t vd_devt; + struct cdev vd_cdev; + struct idr vd_idr; + struct device dev; + struct mdev_parent parent; } mtty_dev; =20 struct mdev_region_info { @@ -1980,15 +1983,14 @@ static int __init mtty_dev_init(void) if (ret) goto err_cdev; =20 - mtty_dev.vd_class =3D class_create(MTTY_CLASS_NAME); + ret =3D class_register(&mtty_class); =20 - if (IS_ERR(mtty_dev.vd_class)) { + if (ret) { pr_err("Error: failed to register mtty_dev class\n"); - ret =3D PTR_ERR(mtty_dev.vd_class); goto err_driver; } =20 - mtty_dev.dev.class =3D mtty_dev.vd_class; + mtty_dev.dev.class =3D &mtty_class; mtty_dev.dev.release =3D mtty_device_release; dev_set_name(&mtty_dev.dev, "%s", MTTY_NAME); =20 @@ -2007,7 +2009,7 @@ static int __init mtty_dev_init(void) device_del(&mtty_dev.dev); err_put: put_device(&mtty_dev.dev); - class_destroy(mtty_dev.vd_class); + class_unregister(&mtty_class); err_driver: mdev_unregister_driver(&mtty_driver); err_cdev: @@ -2026,8 +2028,7 @@ static void __exit mtty_dev_exit(void) mdev_unregister_driver(&mtty_driver); cdev_del(&mtty_dev.vd_cdev); unregister_chrdev_region(mtty_dev.vd_devt, MINORMASK + 1); - class_destroy(mtty_dev.vd_class); - mtty_dev.vd_class =3D NULL; + class_unregister(&mtty_class); pr_info("mtty_dev: Unloaded!\n"); } =20 base-commit: d466c332e106fe666d1e2f5a24d08e308bebbfa1 --=20 2.53.0