From nobody Thu Apr 9 14:08:11 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C011D28489E for ; Sun, 8 Mar 2026 01:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772935116; cv=none; b=e7QqxNgqAzGfskrqKWWNjC38faIDWj8mswW2Fg3GcqwSehvLqOG25QQCPRWgtACfTy9FQMH3SqtIUfF9DIiYhmau/D1kw3mz8M/e3b0LRBWzquYB/ueq4XWBofxasNOP/e4Fs4uNnPOmcZKHBtX8cYCGNaVyKoB3OZxcDoIXnNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772935116; c=relaxed/simple; bh=wihT8f2B57JCAW4+hnTQatiO39AokSGgcJkHwOJkhIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u4VBcDLdBsgPZZONd7ou0KHTYiu9lkRGdUrWnsmbvMPrMG1GQO2SSeFGJ8SyCkAPvWnG3FjWPDkJA4p7O0Pm9sGuT8QaNCbgl+2VVm5R2z9xraaQIOMKcnfKMmnd3eIfThC70ou/6MqQ9VDlM9u95Gv4eLTDCP7AdMjLX/lVWFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TihjCnJe; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TihjCnJe" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ab077e3f32so46274045ad.3 for ; Sat, 07 Mar 2026 17:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772935115; x=1773539915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uVzNmWbW6cP/6PYv9jBlbu21HDCAtNdYngPdNFBqaQY=; b=TihjCnJerl3SAwz4+SBURv3qOIA36sFaZvNhHgJ8MmSV7dA/kILfPb6SqkfbltAZSj 3ejotZOfh4N7mk/Qgq6qbuYOdzsJSs+Ww1dNJ9mtQ+C9WJKPc49BSgqLz4zrQ9jbtPam jeiqGl3WBeE4s2mKT7+DutrUdKTH8cLJBJP/l8MKYecYJmaqPtc5g4Tb63lZHjyZx0gj 3d6x2wwuKZaFR/aQRXVrs1oFzCTmHZS+uq6EmG6Kcuodo+8VnGz++Rd1h9fvKVpPuqS6 yKctLdePbxr5133LxbO6WMg0YwH2/S5Stxg8YZQ02sbeJU/gYRIzcdtmj5TXlM19YqSg gdlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772935115; x=1773539915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uVzNmWbW6cP/6PYv9jBlbu21HDCAtNdYngPdNFBqaQY=; b=VBrsVThqLr1PnlLf3yHwineDguMOTcL65SNlpuPjHiknXOkd5FMq/zIH4BC7/CtzyP vFTjWe0chooINudlMvQpgN6mOq/3Cu5+utx7Qg1PoAS4cAshWG54E7wMSSbdMeolnEz2 k11TMH7oz1TvRbQPgYlS751xOPTnLRkfVuW9uhmvG/xJIBRPbSv8TLRfuuyS6177q8X3 Ig1mYns3aPgvhMOFHHw28HszPQK9wmqRppic8H183JSzohJf0D/s2zrYjKZ7TcLj+jgR p/MfbrWiTRdkNgqoeyn+Ltn2JE5sFMJH6eRCGAEV+kYRDBXfvSG5twc6G9aiewMJnvRO 74gg== X-Forwarded-Encrypted: i=1; AJvYcCVGFhUdqzb3KjhxcTZSFG/jWZmwljvoKylFKk6rRgLla1VCGOiqXsI6Xs/vYxM9ST896RkHulOO2zZcCS8=@vger.kernel.org X-Gm-Message-State: AOJu0YxMnJBWKMPlbZhljsXvRn5FuH8g8zQkI9VxnGq81nkt/9glMLtJ 86x/ne6rIEGDr/L2UFB5UOBPm3ZBt4EU4PljyYXGj47MHWQYtXitXPJV X-Gm-Gg: ATEYQzz6hvk9Xj901S0m/xSCQSYyZ4j0uRaN1vRxITY3+6MssmrUw9IZTuBmJa/1+cp hKbwVXpQUO5l3ar+5hVgSmbeT4v3ZKxt3YA2AWdh7YHDJSxvBeEkcGFN5z31R8/9vF7spr4+Mjt qe8Bjyo0hN3bU3Ns9OKSO+2WzXY0ljIoAa4F2HPNracnwtaFvDZ435VBenZAWtuKteXOrSq/Usm qbo0/5FzSvH0xxbjXj8Y4FNM3x/0jG4gTzCiNDYgowJBQJYkg4zlrhUNEGNTSWTIq2RSMvALCPY ysx0orfvQTtGfGdR1Te1p9HkX6qojz5zUURLQPWAZvuB6/U4Mr9t644JCo/7pso+VwQY4Wtqr8y YxQplHH4uW8eX4YJ87R57ThoxDtaqjuHdKi+xrBpj/XTZeQvKajD+2Jke7A9h3X5dZNG0cKOczN oMXk5hg1hh3fb4hgMXJzz6RbNRPchaT7wxnivNXe2n2xZIxZ45J7M= X-Received: by 2002:a17:902:c94a:b0:2ae:698d:94a6 with SMTP id d9443c01a7336-2ae8241dd3dmr81651285ad.2.1772935115090; Sat, 07 Mar 2026 17:58:35 -0800 (PST) Received: from localhost.localdomain ([202.63.77.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e57b1fsm84141835ad.12.2026.03.07.17.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 17:58:34 -0800 (PST) From: Bevan Weiss To: Lee Jones , Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Bevan Weiss Subject: [PATCH v2 1/1] leds: syscon: Add tristate option Date: Sun, 8 Mar 2026 12:58:23 +1100 Message-ID: <20260308015824.2318366-2-bevan.weiss@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260308015824.2318366-1-bevan.weiss@gmail.com> References: <20260308015824.2318366-1-bevan.weiss@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit f7d98a65d031 ("leds: syscon: Make the driver explicitly non-modular"). OpenWrt builds with a single .config for a given subtarget, whilst boards below that subtarget may not want to carry the disk usage of all options. So there is a preference to have all functionality not required on all boards as modules that can simply not be included in a given board rootfs to reduce disk usage. Additional changes: - (int)(struct platform_device *pdev) =3D> void return - Add MODULE_DESCRIPTION and MODULE_LICENSE macros - Add tristate option to Kconfig Signed-off-by: Bevan Weiss --- drivers/leds/Kconfig | 4 ++-- drivers/leds/leds-syscon.c | 20 +++++++++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 597d7a79c988..ea3afc76a9c6 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -903,8 +903,8 @@ config LEDS_POWERNV will be called leds-powernv. =20 config LEDS_SYSCON - bool "LED support for LEDs on system controllers" - depends on LEDS_CLASS=3Dy + tristate "LED support for LEDs on system controllers" + depends on LEDS_CLASS depends on MFD_SYSCON depends on OF help diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c index d633ad519d0c..bc968e8a326d 100644 --- a/drivers/leds/leds-syscon.c +++ b/drivers/leds/leds-syscon.c @@ -6,7 +6,7 @@ * Author: Linus Walleij */ #include -#include +#include #include #include #include @@ -121,17 +121,31 @@ static int syscon_led_probe(struct platform_device *p= dev) return 0; } =20 +static void syscon_led_remove(struct platform_device *pdev) +{ + struct syscon_led *sled =3D platform_get_drvdata(pdev); + + led_classdev_unregister(&sled->cdev); + /* Turn it off */ + regmap_update_bits(sled->map, sled->offset, sled->mask, 0); +} + static const struct of_device_id of_syscon_leds_match[] =3D { { .compatible =3D "register-bit-led", }, {}, }; =20 +MODULE_DEVICE_TABLE(of, of_syscon_leds_match); + static struct platform_driver syscon_led_driver =3D { .probe =3D syscon_led_probe, + .remove =3D syscon_led_remove, .driver =3D { .name =3D "leds-syscon", .of_match_table =3D of_syscon_leds_match, - .suppress_bind_attrs =3D true, }, }; -builtin_platform_driver(syscon_led_driver); +module_platform_driver(syscon_led_driver); + +MODULE_DESCRIPTION("SYSCON LED driver"); +MODULE_LICENSE("GPL"); --=20 2.43.0