From nobody Thu Apr 9 13:42:40 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A07C3126AD for ; Sun, 8 Mar 2026 06:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772953197; cv=none; b=TULyT1jLgsn+SdgOmuqG2YOeKduUR8xjtLqI9Sb5OPswNqhBzF0tK1KYPpAti13X3iMig1HuuZdhsY3ONgvcJvd9CpHJMMJjdqFeCAYvq2w4rV6ABZ6aCCM5ssBOtft8ZCVyW+1p8GhNvWrRq+dHn8wyxLXu3KCeyrvzWH7pErQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772953197; c=relaxed/simple; bh=+RNmhyrfQMWHwu+8od84odlXgRn/4U7kSubd4dXtgmo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=iVuCU5ANivv6dhMaYstPC7Gfb7buj6sriC+Xogdk8sF0+diDMv6UuszQM2s28kySFh+XOpfchh4cwc3Ii4LOeIV9pDOtis+hFFqc3deleXQhdSdHQAMfRyBZgvGiP6clekclvE7uMlrm5rXflevMnQKFjnctZz7HcbomsRyy/uU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mvzYUbPK; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvzYUbPK" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3597b474cbdso4301778a91.1 for ; Sat, 07 Mar 2026 22:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772953196; x=1773557996; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=I0nWv8X0cARRJ4XJPERkEaD5MqJj6WxTqHyPFa/TlB8=; b=mvzYUbPKNixCeuuUrGiB3hBRFd2w44t7P7kkckQIytwxekxqjvnFuZutq+vPlptW68 sAhbP8bDJf4VHLrysUK6jvYi3BP8wraugz7AKz8c5BOx+kwmSBOFc1qWMun9K4rHRftp HT3cB1LMpHMAypMIYCSXNO7TU5lo70v5ryMyGDWYk7W3Px3PT2Y34QmiC/E0kDpgcu7G hu4i/UWz98h2U+wz0PDytm8nnTClrGxaoOo4HHAvS4QyqIZZxEKoq9Y75QyPIdbScktq lOCAu13pU4WfCkOeCyijmAT32V495ywwCA8IhwV9+dBJs7BS3h9J4cMt2yq9sUvk/Cia mV0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772953196; x=1773557996; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I0nWv8X0cARRJ4XJPERkEaD5MqJj6WxTqHyPFa/TlB8=; b=EOv/ndTYsmzhCfaLNybV/fTa8dyXXzdlg24dsM/yw7opZauSV/o0QYGLnXyA225hfM rqlYnxQ03mDlAJR0VigM4/n8FAeWwdHWPj0HJ+TUJAtOC3cYlFKRewhC+IW1iSMPEDwT 7FlMXnrDtf79naP3jI1RUhALMrgZJUUqstN2jcWzGUde+EXh42voc0Z+QE0jjIvK1Mz0 mQiUIUDrekAUgSxhFjiVuU9dRKHnIuB2zcqDExL4Ois39XgjdVrFI71vegUd9W89yivL 4w02EvZ2Rjv0imSiewx30fSCrBf2qLOEgrsVD/rPMrNTz9hqoT+cfvTQdnelqVS1e7RK LgUg== X-Forwarded-Encrypted: i=1; AJvYcCVXUdvAiKJRJxlzQEVPckCZLAVagiA4Bl5ga220DTrGkZTPfmqUgHOKiL11CUysbofGXO2kQyDz9dPnym8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe5tH6ZGIcwo4YBqKde5g1Os7F5njnZOTCIMKstwAU8Xsyf+Gg RRt21Q+JQaq80lNDD/i4o1D5/SAEsMH2ksZL+p3JgwofMO/Ulw3eFlmU X-Gm-Gg: ATEYQzwoa9oWyBAOBbtg8Gd1j9MwaG4VXALcrkYOURRIAldIT04G2H+pGrmoEMBnS7x O+AbaGNi2nUSG2f9d9ednhOnGfdqufLcG7zWasz6qWBjXKmmx3jmeLmZVT1GVCUOLqEA+5KS33n /Zda4SkaAnCqg71T9CpkQ2LJNUCq0DI+vq18KlfJIeoGSgalpLEsIB7tgKY/oI+olzLsYvivjoV OUfbH7OHYrZ3M+o0twqDzllGs8niWG4VAGotoqY/jBP8HfVF3ykIY51P5nCaoMSkzH7NDcyme6h 8KLqP43d86tUf6LHVeKY5/FhNMuu1YnyxbhnQGBnXmY2SOQvuMF3rM4oPUlJUlM8RR3dM7Z2PAu fZgkGDGtTKvELyhBvk5Q6S+oxWqGx/+AfS3gmCQo55tjNpHxbL+EYMuk4BsVxwYKOsoLyJnkZJa NNnYfK/h2quVm+Yok+4EAiwVoLr+pb16GvcgSdBlMIEru4Dw8= X-Received: by 2002:a17:90b:3c4a:b0:356:24f0:af08 with SMTP id 98e67ed59e1d1-359be28d404mr6645265a91.1.1772953195878; Sat, 07 Mar 2026 22:59:55 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:4507:7fb4:bc3a:eca9]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359b2e00177sm14464792a91.14.2026.03.07.22.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 22:59:55 -0800 (PST) From: Felix Gu Date: Sun, 08 Mar 2026 14:59:50 +0800 Subject: [PATCH] spi: amlogic-spisg: Use IS_ERR() instead of IS_ERR_OR_NULL() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260308-spisg-1-v1-1-4e209faf228d@gmail.com> X-B4-Tracking: v=1; b=H4sIAGUerWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYwML3eKCzOJ0XUPdNGMTo5QkC4skM/NkJaDqgqLUtMwKsEnRsbW1AEG WhcNZAAAA X-Change-ID: 20260308-spisg-1-f342db88b67c To: Sunny Luo , Xianwei Zhao , Mark Brown Cc: linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772953192; l=1524; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=+RNmhyrfQMWHwu+8od84odlXgRn/4U7kSubd4dXtgmo=; b=IivQ04b4Vat5+bqGtsxOs3thUBaQ4qZSzLSCErKbdMYgH9O5udI1OrEO0OIVeU7zaYEynhEKL 7JVo11RZSD5DP1oCd8kKsBx5xoGTFTrr5ibxXTg2UI39dFfvBr8ZQfn X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= devm_clk_get_enabled() and devm_clk_hw_get_clk() return error pointers on failure and never return NULL. So IS_ERR_OR_NULL() is unnecessary, replace them with IS_ERR(). Signed-off-by: Felix Gu --- drivers/spi/spi-amlogic-spisg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-amlogic-spisg.c b/drivers/spi/spi-amlogic-spis= g.c index 1509df2b17ae..665f889dc8d3 100644 --- a/drivers/spi/spi-amlogic-spisg.c +++ b/drivers/spi/spi-amlogic-spisg.c @@ -647,13 +647,13 @@ static int aml_spisg_clk_init(struct spisg_device *sp= isg, void __iomem *base) int ret, i; =20 spisg->core =3D devm_clk_get_enabled(dev, "core"); - if (IS_ERR_OR_NULL(spisg->core)) { + if (IS_ERR(spisg->core)) { dev_err(dev, "core clock request failed\n"); return PTR_ERR(spisg->core); } =20 spisg->pclk =3D devm_clk_get_enabled(dev, "pclk"); - if (IS_ERR_OR_NULL(spisg->pclk)) { + if (IS_ERR(spisg->pclk)) { dev_err(dev, "pclk clock request failed\n"); return PTR_ERR(spisg->pclk); } @@ -703,7 +703,7 @@ static int aml_spisg_clk_init(struct spisg_device *spis= g, void __iomem *base) } =20 spisg->sclk =3D devm_clk_hw_get_clk(dev, &div->hw, NULL); - if (IS_ERR_OR_NULL(spisg->sclk)) { + if (IS_ERR(spisg->sclk)) { dev_err(dev, "get clock failed\n"); return PTR_ERR(spisg->sclk); } --- base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f change-id: 20260308-spisg-1-f342db88b67c Best regards, --=20 Felix Gu