From nobody Thu Apr 9 16:20:27 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84AB21FBEA6; Sun, 8 Mar 2026 06:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772951267; cv=none; b=Aq841trZt5f+JWzZSX9mT6etBtBG4MkXTcv9uORcBvJqayAPFvjBB9t883xtKm2CjdOXOEYlqE1QnL4jc8PofGT7at0RO07e+bBofMkDLgGFF18GgvY+pvj1mbkJ9RnMVTLMPdi9aQ+YwcfjLxZVUMqSvykIMMvI7YsysM2QYN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772951267; c=relaxed/simple; bh=LJCdrjh5v923RUukUeQhbZ+wVdbGpVFn1ddvq4HPACk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EPWk7MzFlqLvO8RKiuCOmZqQylTLjKxVh2V2P/4tuth4oOx2CHvo6EAnMvSAuk47LKDxs9hz4MYcb2M9/aXrbHo6GiQdt745ce4p/2o2LefMM/xWrKQFJJW+dfZ7X5PB/TExrxYDMe2GV4US0WfuIEJMpBX2bwe5FUcYTK4c7j0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hGRBIHev; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hGRBIHev" Received: by smtp.kernel.org (Postfix) with ESMTPS id 441C8C2BCB1; Sun, 8 Mar 2026 06:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772951267; bh=LJCdrjh5v923RUukUeQhbZ+wVdbGpVFn1ddvq4HPACk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=hGRBIHev4i76DQ7S9gbOut30KdIk1ravHqeh6jSCMP3pnW6/1Y/62F4ubNBCuz8iA AIxtJDU5NqXEClUPozxFmz6/2CTy7xXLueoPL5o7CZOzLVNtnQDmSU5j3mNy/VJUmh ci9zJo4WLFhdypR4Jx5rReV/ZxUcU8VKvVFyqHIbvUx7AhYWzBEuTnDEI1vXaQLoxA rDFKhcOGHFg+9OU1FeGA9vNpJKlGXL75TDlrasA8GPJIDwypKbov0EI6D/yOI29ILg RPPg1fqaYq5o3jB3cJVKz+55ZOfmPIr0Y+nqXbADtPxUX8C/SNdxULuouCal6Y0GBh F88nAeBDlDQpQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331ABF55137; Sun, 8 Mar 2026 06:27:47 +0000 (UTC) From: Manivannan Sadhasivam via B4 Relay Date: Sun, 08 Mar 2026 11:57:29 +0530 Subject: [PATCH v5 3/5] soc: qcom: ice: Return proper error codes from devm_of_qcom_ice_get() instead of NULL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260308-qcom-ice-fix-v5-3-e47e8a44b6c4@oss.qualcomm.com> References: <20260308-qcom-ice-fix-v5-0-e47e8a44b6c4@oss.qualcomm.com> In-Reply-To: <20260308-qcom-ice-fix-v5-0-e47e8a44b6c4@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Adrian Hunter , Ulf Hansson , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Abel Vesa , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, Sumit Garg , mani@kernel.org, Neeraj Soni , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=5W0UnK5qBpVdfnHU+nHM5UdWdtySo1GeLE5V9qhPunU=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBprRbgWc3KZRLBWyRJTbhO7t36Vij9aWQSEiGST OV4hRQp4K6JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaa0W4AAKCRBVnxHm/pHO 9S6JB/9q+7rJhXTC7lYqxlaBySKsDLOPKEB9XiY19E7mEGK+qtj/sQ3zANElxjJM6xUC3xdJWJa fCXhHLb3ZXwHh9fP3EqAAW965o+m/Kkfe5t8w0wllLl20Aofwy6gTGNn2ZO9UasdNIlQNswWAdv MOaprm8yd24iMeG4Pli8yLh3GegteuDiBNWXya2YtxOFub7YuXC2sUcEfW7cXSXNwE6/RYIQrJ8 gr3IAyuw/NzXpzWwdtReNHZSEbvccFS1pkfaMUtdbQL8Xt8E1QrXCnmnS5+mOApvjb4N4uEv6LK YvTC5lvEFWmzmhJwghfdaWTrP3V0vATKsFtY4V5ciCFEClNi X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Endpoint-Received: by B4 Relay for manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461 X-Original-From: Manivannan Sadhasivam Reply-To: manivannan.sadhasivam@oss.qualcomm.com From: Manivannan Sadhasivam devm_of_qcom_ice_get() currently returns NULL if ICE SCM is not available or "qcom,ice" property is not found in DT. But this confuses the clients since NULL doesn't convey the reason for failure. So return proper error codes instead of NULL. Reported-by: Sumit Garg Reviewed-by: Konrad Dybcio Signed-off-by: Manivannan Sadhasivam --- drivers/soc/qcom/ice.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index 6fde282584d0..9faf099e40a3 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -563,7 +563,7 @@ static struct qcom_ice *qcom_ice_create(struct device *= dev, =20 if (!qcom_scm_ice_available()) { dev_warn(dev, "ICE SCM interface not found\n"); - return NULL; + return ERR_PTR(-EOPNOTSUPP); } =20 engine =3D devm_kzalloc(dev, sizeof(*engine), GFP_KERNEL); @@ -645,7 +645,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *= dev) struct device_node *node __free(device_node) =3D of_parse_phandle(dev->of= _node, "qcom,ice", 0); if (!node) - return NULL; + return ERR_PTR(-ENODEV); =20 pdev =3D of_find_device_by_node(node); if (!pdev) { @@ -698,8 +698,7 @@ static void devm_of_qcom_ice_put(struct device *dev, vo= id *res) * phandle via 'qcom,ice' property to an ICE DT, the ICE instance will alr= eady * be created and so this function will return that instead. * - * Return: ICE pointer on success, NULL if there is no ICE data provided b= y the - * consumer or ERR_PTR() on error. + * Return: ICE pointer on success, ERR_PTR() on error. */ struct qcom_ice *devm_of_qcom_ice_get(struct device *dev) { @@ -710,7 +709,7 @@ struct qcom_ice *devm_of_qcom_ice_get(struct device *de= v) return ERR_PTR(-ENOMEM); =20 ice =3D of_qcom_ice_get(dev); - if (!IS_ERR_OR_NULL(ice)) { + if (!IS_ERR(ice)) { *dr =3D ice; devres_add(dev, dr); } else { --=20 2.51.0