From nobody Thu Apr 9 14:09:21 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC8C1643B for ; Sat, 7 Mar 2026 23:45:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772927115; cv=none; b=P6bNv7vrigzYC/BX2V8Sm383gx/xUA2QH6YfPwmYAv68oIi0I9AEGJ9VssOdNV1AY1V2tRkRQr5AAmlzxXL9n9SOUMpVymbSbqPnwPywfVXluzHo3toPJ1pWjjecpxmvgukBmSROt8U6wZySsEDBkCpJpADuuNo/k6ERKLgX4Cg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772927115; c=relaxed/simple; bh=B0FMhBfrocAC+fIijCeunI5+OVR44/k33na+05sqr5o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=M/r11B4mf7hDyw99/KcYy5AiJIup+JxplqHt6iAjAw5UO+veXOj+Eii+pdNHqx/F52kcS6PwJ3/TdX0WmOGaT+UjjZoQOJ7pMmYWwpCQku8hdGhA9UPE9IGjBe+qDfFsb1oGhZNY5dwRegfsSN6mv1jFIfHw7/LAefTbCuWq0Lg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kW577S4F; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kW577S4F" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4807068eacbso87420475e9.2 for ; Sat, 07 Mar 2026 15:45:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772927112; x=1773531912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qjRKrJQ2J/VDkoqe2xizeTmn4PJSWMUuw8x/Xk5UYBU=; b=kW577S4FRR5AndfU8/5opz2HwzArmfkjl3uR/DGr0TflSrY3xgIYQeig6L1f+o2Gdr wVGsmqqletCiknaQfHHo8snlbgMVFImBzHk73Gzx9ha48uaxTF1LjliDQ9g1rjxqsib5 v/ma4AfRg6ieR1eKvZfaCdmH00lcGkFodnpeeMrago9EyM1yDyMHY0HEbLN5QoGuWGVZ d7BuEhUYXeuvf/M1Fm6vcUkwkiByC5JC8a+T/Bh1k0LEcYYfa7BttPuwNmkgrnGdrB5d Jnfj7E32KUn6mMHvck24Y3/HKTkxYExffp8Cu63uTLiGm202UggHF4w+Gt+HqgZvTJSe Q8yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772927112; x=1773531912; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qjRKrJQ2J/VDkoqe2xizeTmn4PJSWMUuw8x/Xk5UYBU=; b=StP65B4/GrY2XnZcl+eAEBQzB+z1kyEbAYTdAvgaSfHdTi54dBzn6aVbmeVg+yN+rK MM3U/MUjJB8mgF74NiayiBCvC6w0tVehiIhzI1JSPidbNvNLG/FHRzHgXoQSpSj+P/yO ggthEkoznPHkVp6VTNuQYzCyRwTvRX4KizSsj8DXS2Kx4uWyPGXz6tqTE0DZch37ocX5 MBcAu0bVZoQ8aDpAPKN8pAPCtPZ3t2YcaI54dPlsLLkIu96IN1bqJpXjxIa6c3WpwBAI CGXWKSiZ04NYdyLMN9CJ8ZHXjpi0ebhfakEzEkelAtjOdjqnabqsQqhvbugTMdBim9Pd ZnKA== X-Forwarded-Encrypted: i=1; AJvYcCUYNpiZp9l2De91edmUyBAptfx3O9DfdmIHB13UKU868tiN/cX0Hs1TGMjjt+VL5gb6jMyD30ek59TywBs=@vger.kernel.org X-Gm-Message-State: AOJu0YyUEITy3fmxM2Urh3Rw0a6236XndkmmgcAEYPU7k68vV5+XrigM eQpn2NOpTsS5qscRBtHN+cJ97KCNaBd3ckkrNOIrtrY7E5H9pi8mrWr11wVzsmB8 X-Gm-Gg: ATEYQzwQpHQwDKKVB9CKuHh9TQeQLWP+r+rAHmEqA28W4EISxuZQN95F2+S7FZv1HRX KyseTyNHlxZ4g7wXe7HHwtGIx/zqyEErxT1HTLzGTGFdno4JCFWR8rMMzjTkcdz/LXo+3QF1nMC 0iIvHBEDgLMT+MsRFUgTOZyVuR956+v31Bt4RE3qDait1fq+DxsTTeWTAj8R/ahgfDPBTBU5Bw/ 88l1eXZVpaESwRXY8Fcg8h1Jcy///0xpG5M5H/LrPe9PjLD/uyyfgnxLKLvZT7C0j593K0r6O4q OSdDpVvKI/kMlgGJEMxy3ZjFTK3wFMZVSUj3oQQF+GM5VNKxYQM61fCw07GAzpHIzf7cZs/gxAe WEhcyoqcBTRuFfLdt8R3ThO+PsB5+T863BFOdgd+N2Z3sFnzMVbc2L+z1+DD7E4tGlQS9AtRM5P oLwM1xvgXNhCrIbFJts4DaOyh9OopYxJ8rbvVJHLLd7M3KHugJiV3K27m/0DZL X-Received: by 2002:a05:600c:1e88:b0:47d:8479:78d5 with SMTP id 5b1f17b1804b1-4852690f599mr132855755e9.7.1772927112391; Sat, 07 Mar 2026 15:45:12 -0800 (PST) Received: from osama.. ([156.223.176.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485247029a4sm49900895e9.26.2026.03.07.15.45.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 15:45:11 -0800 (PST) From: Osama Abdelkader To: Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andrew Jones , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] RISC-V: KVM: fix PMU snapshot_set_shmem on 32-bit hosts Date: Sun, 8 Mar 2026 00:43:54 +0100 Message-ID: <20260307234355.69831-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When saddr_high !=3D 0 on RV32, the goto out was unconditional, causing valid 64-bit addresses to be rejected. Only goto out when the address is invalid (64-bit host with saddr_high !=3D 0). Fixes: c2f41ddbcdd7 ("RISC-V: KVM: Implement SBI PMU Snapshot feature") Signed-off-by: Osama Abdelkader Reviewed-by: Andrew Jones --- arch/riscv/kvm/vcpu_pmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/riscv/kvm/vcpu_pmu.c b/arch/riscv/kvm/vcpu_pmu.c index 4d8d5e9aa53d..045099ca904b 100644 --- a/arch/riscv/kvm/vcpu_pmu.c +++ b/arch/riscv/kvm/vcpu_pmu.c @@ -425,9 +425,10 @@ int kvm_riscv_vcpu_pmu_snapshot_set_shmem(struct kvm_v= cpu *vcpu, unsigned long s if (saddr_high !=3D 0) { if (IS_ENABLED(CONFIG_32BIT)) saddr |=3D ((gpa_t)saddr_high << 32); - else + else { sbiret =3D SBI_ERR_INVALID_ADDRESS; - goto out; + goto out; + } } =20 kvpmu->sdata =3D kzalloc(snapshot_area_size, GFP_ATOMIC); --=20 2.43.0