From nobody Thu Apr 9 14:56:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62DB72F8BD3; Sat, 7 Mar 2026 19:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772912963; cv=none; b=d6WFNFhdBvo/LDx0oXlDkYwSrQHaSvQjs1dv2muYkC6+36aBvygVxsfsBYTuEilGraForxaSiA7XO+NWl+EDkA5I3SFpuQcHBrvzBT0JNxhgq/6NDxV7zQWQKwcsUZWdOkuYpUpy/u2X7ayw0cdj2H9mw0+52L9kskU44/NkN9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772912963; c=relaxed/simple; bh=AJMBL1nNdjGC0+4eccv0L3v64yl/CaBJKvNB19kiMwM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oXV0nfG4Aqh44Un7M1YXj6SCfvXzC5GP03ENrTiVWyygT9bH5kLWGdaCEtyoWKo5m/IvEY5rfvsJfK1WXTNPhWJ3S5HYTg9iU8PFh4hjFfv2dWoyevgZEBJ29sFJ2Iu1XrQXKaS8xN6XXb+BvOlNpZ9f5Xiat/s5dLxaq8BvEnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=emdN8l1G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="emdN8l1G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B4B9C19423; Sat, 7 Mar 2026 19:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772912963; bh=AJMBL1nNdjGC0+4eccv0L3v64yl/CaBJKvNB19kiMwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=emdN8l1GafabJYJm9JIqEG+XGtuLJmZKKmtcfgcPtSLlJwl65IknEczw+BGHKkE/i gNKs0q8kTJbvvKKfgQ2VHnrurATgBPeQ9Ys//vKQ532fgcAcXBmdmxWLGmvcs5kJeN PTLCyp0A/gVhqjpQ/mPNgPzNM0PpGZm+cl5G+mPa/Kw29iM/nrB/xwYKjwZJNXG6Ns vfduOaGcQsNkVXYH9EHqDiRgoJHt5Tq05LJzhSv4X62Gv+65AdUKVwf1q78S1zhqTM fdUjhx+9llwZ3aBJshEaW0b/tlrixr77+w2e1Ais95/95ovQP6Zvq03tZV4n6FdBDT d/3lAanMSBL9Q== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 1/3] mm/damon/core: remove damos_set_next_apply_sis() duplicates Date: Sat, 7 Mar 2026 11:49:12 -0800 Message-ID: <20260307194915.203169-2-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260307194915.203169-1-sj@kernel.org> References: <20260307194915.203169-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is a function for damos->next_apply_sis setup. But some places are open-coding it. Consistently use the helper. Signed-off-by: SeongJae Park --- mm/damon/core.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index e8c44541754f7..c4c30824465ee 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2450,8 +2450,6 @@ static void kdamond_apply_schemes(struct damon_ctx *c) struct damon_target *t; struct damon_region *r; struct damos *s; - unsigned long sample_interval =3D c->attrs.sample_interval ? - c->attrs.sample_interval : 1; bool has_schemes_to_apply =3D false; =20 damon_for_each_scheme(s, c) { @@ -2482,9 +2480,7 @@ static void kdamond_apply_schemes(struct damon_ctx *c) if (c->passed_sample_intervals < s->next_apply_sis) continue; damos_walk_complete(c, s); - s->next_apply_sis =3D c->passed_sample_intervals + - (s->apply_interval_us ? s->apply_interval_us : - c->attrs.aggr_interval) / sample_interval; + damos_set_next_apply_sis(s, c); s->last_applied =3D NULL; damos_trace_stat(c, s); } @@ -2858,7 +2854,6 @@ static void kdamond_init_ctx(struct damon_ctx *ctx) { unsigned long sample_interval =3D ctx->attrs.sample_interval ? ctx->attrs.sample_interval : 1; - unsigned long apply_interval; struct damos *scheme; =20 ctx->passed_sample_intervals =3D 0; @@ -2869,9 +2864,7 @@ static void kdamond_init_ctx(struct damon_ctx *ctx) ctx->attrs.intervals_goal.aggrs; =20 damon_for_each_scheme(scheme, ctx) { - apply_interval =3D scheme->apply_interval_us ? - scheme->apply_interval_us : ctx->attrs.aggr_interval; - scheme->next_apply_sis =3D apply_interval / sample_interval; + damos_set_next_apply_sis(scheme, ctx); damos_set_filters_default_reject(scheme); } } --=20 2.47.3 From nobody Thu Apr 9 14:56:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79AF133438F; Sat, 7 Mar 2026 19:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772912963; cv=none; b=KbRqhPLPi8QdIP6LyIjg9hOcAAtS45O+qd2MNXgTNQBcIAoQ8cUFsndijW5rJmLXWfj+Sxj/QQsjZjFcJ1WHoK3qXoW/uYw1F0bQA8tL+lYc7/YkiR8kkHG0w3MChKEHmPrehab81nRhRdpx+/jlcP+p+SSBw6qf5t/tB/SOJYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772912963; c=relaxed/simple; bh=OtrKrhHbMS6GUq0Sgqh0AHIPZbCzyKkgoS3Ue4fyc6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ghka41twAzWIzv0domCXPzKSd+4IVYw918CeCnftdLH+NBs4qSc1RxG4BYQok+glUu40nk89ovYpU4TP3mxpAR6yqm3KJAq9ULx2mfrl7CbP6adS0dHfpRiyAsdlXIXg0sS6aOyzWkm8sXFMzC///+/p2/5At8jKUIeDkQ+QKp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PskDigiN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PskDigiN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40CDDC2BCAF; Sat, 7 Mar 2026 19:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772912963; bh=OtrKrhHbMS6GUq0Sgqh0AHIPZbCzyKkgoS3Ue4fyc6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PskDigiNybIdsVjKPIaaT46RjG8CG/QpBCHY83fnwV4RI2agMJJLQNVxw5B70ZI/p Hdgh90iIOArfgAFCwLU359T/DsTiFFZC52miEsz+JlE1RYpjtZA6guHv24fWB8B0Vd PlRln5R3CxwV99oGaI1VVJg6mLxgtsDg6nIdK9I3ATBivnKX/P6F3hJ0n9m1XAzdgW ByUAmaJ4/xKt3G1aivavVwZAZvol/JgwKP1qkphm0dQdxPJXVXrswYLHf8MS64OTZg NfDXIocfEBPXBwB9bgN35T0cYXlBBa4T4HItwC7q2KTlRoFfJj6F4NAjP8tfblxCBI oDqkN6aUhW72g== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/3] mm/damon/core: use time_before() for next_apply_sis Date: Sat, 7 Mar 2026 11:49:13 -0800 Message-ID: <20260307194915.203169-3-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260307194915.203169-1-sj@kernel.org> References: <20260307194915.203169-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" damon_ctx->passed_sample_intervals and damos->next_apply_sis are unsigned long, and compared via normal comparison operators. It is unsafe from overflow. Use time_before(), which is safe from overflow when correctly used, instead. Signed-off-by: SeongJae Park --- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index c4c30824465ee..4ede733a94cc0 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2095,7 +2095,7 @@ static void damon_do_apply_schemes(struct damon_ctx *= c, damon_for_each_scheme(s, c) { struct damos_quota *quota =3D &s->quota; =20 - if (c->passed_sample_intervals < s->next_apply_sis) + if (time_before(c->passed_sample_intervals, s->next_apply_sis)) continue; =20 if (!s->wmarks.activated) @@ -2453,7 +2453,7 @@ static void kdamond_apply_schemes(struct damon_ctx *c) bool has_schemes_to_apply =3D false; =20 damon_for_each_scheme(s, c) { - if (c->passed_sample_intervals < s->next_apply_sis) + if (time_before(c->passed_sample_intervals, s->next_apply_sis)) continue; =20 if (!s->wmarks.activated) @@ -2477,7 +2477,7 @@ static void kdamond_apply_schemes(struct damon_ctx *c) } =20 damon_for_each_scheme(s, c) { - if (c->passed_sample_intervals < s->next_apply_sis) + if (time_before(c->passed_sample_intervals, s->next_apply_sis)) continue; damos_walk_complete(c, s); damos_set_next_apply_sis(s, c); --=20 2.47.3 From nobody Thu Apr 9 14:56:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB75F38B7A3; Sat, 7 Mar 2026 19:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772912963; cv=none; b=Cl57KFi+DGjVBzbfcnHrOokCN8QqyV6kaf8+25JKsy7AguYF4dozPASL3RqQMGVsu5IeSmIAMh1d743gP9Is2qIyDV9le9Xoqd5kf6MVVIkVxnfqYz4eqHBkwB3wmhtZACOHeObJTh+gdtgymsJfUl3VwoYX4ghcQvfYtKvMw3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772912963; c=relaxed/simple; bh=Za6lpJwLEosOpDlDvwmJC/zKpW4MWLYWLFZqfZ7RdwM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pEoE6FSb62bIxNDJ1Q52mztqd7BwBoHeU2heVS+xHNGHQ94qqD86BnpPBDuqjwOZMiWBbHosGWxJRaf0LCTMu7lpaEGtYD+WcgBTfQBN2w99dj4Nzp5iCGJIoENMcLPFFvU3AAWHVeURxaiTKdlIsE6acbNKFmBEdbn4boPQEOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BEJvl+YA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BEJvl+YA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 778F0C2BCB1; Sat, 7 Mar 2026 19:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772912963; bh=Za6lpJwLEosOpDlDvwmJC/zKpW4MWLYWLFZqfZ7RdwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BEJvl+YAbT9PXtUETsi60jcymWiXmgJCPTrhnzWxWSUvDSfTBvVLKFqnSugR1lo0J rOenWaRUaGt7+2tbhuj0RZEyRWW07hUWI+5B9rvZIsh8BN5V8eWZ1mva31S2OEHyn6 iQ27N+x8TbtOSdBuPOqhoktX6nl54MzND32DrQqht5jCunuAYhYHU0/EwvSO5MCYIY EMrb25eq3ER+ik+BHGSFW2J/gWAXu/lqPxiU82etKjjbMPNljoNqMwnJQHojEFByA7 /znw6AgT8r5mAzZSDUFlNxfTK6M5a5reW1IHQVHd7LwvbO0oIzZ7B4KKlbSHGRpEsn AkGpuQo3l/FrQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 3/3] mm/damon/core: use time_after_eq() in kdamond_fn() Date: Sat, 7 Mar 2026 11:49:14 -0800 Message-ID: <20260307194915.203169-4-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260307194915.203169-1-sj@kernel.org> References: <20260307194915.203169-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" damon_ctx->passed_sample_intervals and damon_ctx->next_*_sis are unsigned long. Those are compared in kdamond_fn() using normal comparison operators. It is unsafe from overflow. Use time_after_eq(), which is safe from overflows when correctly used, instead. Signed-off-by: SeongJae Park --- mm/damon/core.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 4ede733a94cc0..cd2d7a8e3fe92 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2915,7 +2915,8 @@ static int kdamond_fn(void *data) if (ctx->ops.check_accesses) max_nr_accesses =3D ctx->ops.check_accesses(ctx); =20 - if (ctx->passed_sample_intervals >=3D next_aggregation_sis) { + if (time_after_eq(ctx->passed_sample_intervals, + next_aggregation_sis)) { kdamond_merge_regions(ctx, max_nr_accesses / 10, sz_limit); @@ -2935,10 +2936,12 @@ static int kdamond_fn(void *data) =20 sample_interval =3D ctx->attrs.sample_interval ? ctx->attrs.sample_interval : 1; - if (ctx->passed_sample_intervals >=3D next_aggregation_sis) { + if (time_after_eq(ctx->passed_sample_intervals, + next_aggregation_sis)) { if (ctx->attrs.intervals_goal.aggrs && - ctx->passed_sample_intervals >=3D - ctx->next_intervals_tune_sis) { + time_after_eq( + ctx->passed_sample_intervals, + ctx->next_intervals_tune_sis)) { /* * ctx->next_aggregation_sis might be updated * from kdamond_call(). In the case, @@ -2972,7 +2975,8 @@ static int kdamond_fn(void *data) kdamond_split_regions(ctx); } =20 - if (ctx->passed_sample_intervals >=3D next_ops_update_sis) { + if (time_after_eq(ctx->passed_sample_intervals, + next_ops_update_sis)) { ctx->next_ops_update_sis =3D next_ops_update_sis + ctx->attrs.ops_update_interval / sample_interval; --=20 2.47.3