From nobody Sun Apr 5 13:04:08 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3F530F80C for ; Sat, 7 Mar 2026 14:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892635; cv=none; b=CpKH/sKR3t4+gI52ogSVdtmGB3OKryldJF4b1FgWGDbYt+N/s7b4GkUJ0TizRUQkTJEqB3jsYOZ7kHcdXku4Qr02s2njJV/sx+NcPVf+5IANrecLmGCx4WysfAJaB1IyeiRnHvuSmdlpNw4Ugl5LfxUtMS+MqbESo15E9EkT3kY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892635; c=relaxed/simple; bh=bGtY6zAn83cYGnRqbpQR22ybZtt4cvWvzU8TZChJ2IY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qv54bJtTr6R0hE/4vxIAaWkwgVcdDPcm1c5/In/DMEz0SUG9TmMDBqCKI7ygTJZ7UDCWZ29Q7vbRYhkszwXfDd1o9I0b07bRwdFpS6YFMDoOEn1Q41VfcnyoIvH4PcVLsfLXxXJ7oQx1fIwbzcGZt1cAanhIajCgVW701pwBzb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p625L08B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p625L08B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F91EC2BC86; Sat, 7 Mar 2026 14:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772892635; bh=bGtY6zAn83cYGnRqbpQR22ybZtt4cvWvzU8TZChJ2IY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p625L08BJNtrm8MO/7Cfbf1xJsLw3/AUTXUolTtW8I5lXZSmHqWuyEZHPQzH22Oci aXDMyNH7iAiw7onk132ruaasCLqtXCyLCZ6g0pQ+4+8Pm35D/bFXOppNzRvITbr3FR l4jwYhMzIlGcQfeindKXLJPv6OmYdsz0PgAJUlfHsNew2OupyjQUIgbidx/6fDh39x Ji265FaLkrtN3gS+WqvtPxnMZ9hzLs+g3Kd4pH+GOj5RnQe4zsEmWI8gh/EmaxV44e hQCGmDSsWIYbgDec5VWYeS/iqFO36LeQlV8GrXYQ2FNVXdK11peJVx4ICn5zBU7wus TghPayNO/9Qxg== From: "Mario Limonciello (AMD)" To: Yazen Ghannam , Jean Delvare Cc: linux-kernel@vger.kernel.org, Borislav Petkov , "Mario Limonciello (AMD)" Subject: [PATCH v6 5/5] x86/CPU/AMD: Print AGESA string from DMI additional information entry Date: Sat, 7 Mar 2026 08:10:24 -0600 Message-ID: <20260307141024.819807-6-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260307141024.819807-1-superm1@kernel.org> References: <20260307141024.819807-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yazen Ghannam Type 40 entries (Additional Information) are summarized in section 7.41 as part of the SMBIOS specification. Generally, these entries aren't interesting to save. However on some AMD Zen systems, the AGESA version is stored here. This is useful to save to the kernel message logs for debugging. It can be used to cross-reference issues. Implement an iterator for the Additional Information entries. Use this to find and print the AGESA string. Do so in AMD code, since the use case is AMD-specific. Signed-off-by: Yazen Ghannam Co-developed-by: "Mario Limonciello (AMD)" Signed-off-by: "Mario Limonciello (AMD)" Reviewed-by: Jean Delvare --- v6: * rename print AGESA function (Boris) * check count explicitly * remove extra comments * Only print second half of string, look for full !V9 sentinel v5: * Return "" in !CONFIG_DMI case (LKP robot, Yazen) v4: * New patch (based upon older versions though) --- arch/x86/kernel/cpu/amd.c | 49 +++++++++++++++++++++++++++++++++++++ drivers/firmware/dmi_scan.c | 3 ++- include/linux/dmi.h | 18 ++++++++++++++ 3 files changed, 69 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 09de584e4c8fa..f4d1b4ee155b3 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only #include #include +#include #include #include #include @@ -1380,3 +1381,51 @@ static __init int print_s5_reset_status_mmio(void) return 0; } late_initcall(print_s5_reset_status_mmio); + +static void __init dmi_scan_additional(const struct dmi_header *d, void *p) +{ + struct dmi_a_info *info =3D (struct dmi_a_info *)d; + void *next, *end; + + if (!IS_ENABLED(CONFIG_DMI)) + return; + + if (info->header.type !=3D DMI_ENTRY_ADDITIONAL || + info->header.length < DMI_A_INFO_MIN_SIZE || + info->count < 1) + return; + + next =3D (void *)(info + 1); + end =3D (void *)info + info->header.length; + + do { + struct dmi_a_info_entry *entry; + const char *string_ptr; + + entry =3D (struct dmi_a_info_entry *)next; + + /* + * Not much can be done to validate data. At least the entry + * length shouldn't be 0. + */ + if (!entry->length) + return; + + string_ptr =3D dmi_string_nosave(&info->header, entry->str_num); + + /* Sample string: AGESA!V9 StrixKrackanPI-FP8 1.1.0.0c */ + if (!strncmp(string_ptr, "AGESA!V9", 8) && strlen(string_ptr) > 9) { + pr_info("AGESA: %s\n", string_ptr + 9); + break; + } + + next +=3D entry->length; + } while (end - next >=3D DMI_A_INFO_ENT_MIN_SIZE); +} + +static __init int print_dmi_agesa(void) +{ + dmi_walk(dmi_scan_additional, NULL); + return 0; +} +late_initcall(print_dmi_agesa); diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index ed6235ac576b6..a3f7dabd49554 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -47,7 +47,7 @@ static struct dmi_memdev_info { static int dmi_memdev_nr; static int dmi_memdev_populated_nr __initdata; =20 -static const char * __init dmi_string_nosave(const struct dmi_header *dm, = u8 s) +const char *dmi_string_nosave(const struct dmi_header *dm, u8 s) { const u8 *bp =3D ((u8 *) dm) + dm->length; const u8 *nsp; @@ -66,6 +66,7 @@ static const char * __init dmi_string_nosave(const struct= dmi_header *dm, u8 s) =20 return dmi_empty_string; } +EXPORT_SYMBOL_GPL(dmi_string_nosave); =20 static const char * __init dmi_string(const struct dmi_header *dm, u8 s) { diff --git a/include/linux/dmi.h b/include/linux/dmi.h index 2eedf44e68012..c8700e6a694d1 100644 --- a/include/linux/dmi.h +++ b/include/linux/dmi.h @@ -91,6 +91,21 @@ struct dmi_device { void *device_data; /* Type specific data */ }; =20 +#define DMI_A_INFO_ENT_MIN_SIZE 0x6 +struct dmi_a_info_entry { + u8 length; + u16 handle; + u8 offset; + u8 str_num; + u8 value[]; +} __packed; + +#define DMI_A_INFO_MIN_SIZE 0xB +struct dmi_a_info { + struct dmi_header header; + u8 count; +} __packed; + #ifdef CONFIG_DMI =20 struct dmi_dev_onboard { @@ -120,6 +135,7 @@ extern void dmi_memdev_name(u16 handle, const char **ba= nk, const char **device); extern u64 dmi_memdev_size(u16 handle); extern u8 dmi_memdev_type(u16 handle); extern u16 dmi_memdev_handle(int slot); +const char *dmi_string_nosave(const struct dmi_header *dm, u8 s); =20 #else =20 @@ -153,6 +169,8 @@ static inline u8 dmi_memdev_type(u16 handle) { return 0= x0; } static inline u16 dmi_memdev_handle(int slot) { return 0xffff; } static inline const struct dmi_system_id * dmi_first_match(const struct dmi_system_id *list) { return NULL; } +static inline const char * + dmi_string_nosave(const struct dmi_header *dm, u8 s) { return ""; } =20 #endif =20 --=20 2.43.0