From nobody Sun Apr 5 13:23:19 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E285D2E7BB6 for ; Sat, 7 Mar 2026 14:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892633; cv=none; b=OZw3SE5o19ZRjxglxogBMbk5bWvMSOgQzYo9tkzSnRloeBzpa7FthNz+PMma8QIprZ/gz12/To67CTUp/XGGDOsJUvF1PvcH9+y1MkRV7vRF/Spkowk2coAtqVfjM98GdXfHsjQQ+3hN0YyqEoMKmCa2b7wycARHoxu0FcDBRfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892633; c=relaxed/simple; bh=84Y6ThfIpAkKLwZ9CuqzVP+MukiAI1efPplzFkCqGRc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KzhcGzv9JZmB5P7roWiNcGzg4/dDoEdK533EAxT/kjU5Eptm5T/nHBeU2/Ano1QwZ5130tLB2G4a8Hk6lQ9E69XYumDHMp9qcvEJ+4BW3ffoRplalhDKDH5epzJcO3QIBj3OBs9jgEDSWMnhat0ciZ0Py160uzxE6vne07ClE6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mG29qwMj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mG29qwMj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09480C2BC86; Sat, 7 Mar 2026 14:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772892632; bh=84Y6ThfIpAkKLwZ9CuqzVP+MukiAI1efPplzFkCqGRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mG29qwMjicNRk0nvxiT8IiFIOG90zJAcjy2R0VbySz5IqdD71rUv2XgccwCveTqMv 4D24SBShIizRUQUhxPWiVb24E+HCNoTRbrPJbBKrVy2vIR2e9ebMCP0rp1X4PgTPpD HLftlTQ5DO5tzwFeNcM04PFv/km01eWKSPkzpRhh3L3ARMDEUbKS+jmjTUzaxouHdF HnIpK9dOEu2AK1vzPFwjWxugQAkp5kVJUBCEriW9FXAlAq2W3DKhmowcSvsJkwZ2Xd xgbOgoPjYpvFYKbSVaa8pf/xK+i8ggbIKWoqrDMOSiLWI+aXSmVZrgpcwFbNCcDtz9 kmbI8IOcPQNyw== From: "Mario Limonciello (AMD)" To: Yazen Ghannam , Jean Delvare Cc: linux-kernel@vger.kernel.org, Borislav Petkov , "Mario Limonciello (AMD)" , Jean Delvare Subject: [PATCH v6 2/5] firmware: dmi: Adjust dmi_decode() to use enums Date: Sat, 7 Mar 2026 08:10:21 -0600 Message-ID: <20260307141024.819807-3-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260307141024.819807-1-superm1@kernel.org> References: <20260307141024.819807-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dmi_decode() has hardcoded values with comments for each DMI entry type. The same information is already in dmi.h though, so drop the comments and use the definitions instead. Reviewed-by: Jean Delvare Reviewed-by: Yazen Ghannam Signed-off-by: Mario Limonciello (AMD) --- v3: * pick up tag (Jean) --- drivers/firmware/dmi_scan.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 70d39adf50dca..80aded4c778bc 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -484,14 +484,14 @@ static void __init dmi_memdev_walk(void) static void __init dmi_decode(const struct dmi_header *dm, void *dummy) { switch (dm->type) { - case 0: /* BIOS Information */ + case DMI_ENTRY_BIOS: dmi_save_ident(dm, DMI_BIOS_VENDOR, 4); dmi_save_ident(dm, DMI_BIOS_VERSION, 5); dmi_save_ident(dm, DMI_BIOS_DATE, 8); dmi_save_release(dm, DMI_BIOS_RELEASE, 21); dmi_save_release(dm, DMI_EC_FIRMWARE_RELEASE, 23); break; - case 1: /* System Information */ + case DMI_ENTRY_SYSTEM: dmi_save_ident(dm, DMI_SYS_VENDOR, 4); dmi_save_ident(dm, DMI_PRODUCT_NAME, 5); dmi_save_ident(dm, DMI_PRODUCT_VERSION, 6); @@ -500,33 +500,33 @@ static void __init dmi_decode(const struct dmi_header= *dm, void *dummy) dmi_save_ident(dm, DMI_PRODUCT_SKU, 25); dmi_save_ident(dm, DMI_PRODUCT_FAMILY, 26); break; - case 2: /* Base Board Information */ + case DMI_ENTRY_BASEBOARD: dmi_save_ident(dm, DMI_BOARD_VENDOR, 4); dmi_save_ident(dm, DMI_BOARD_NAME, 5); dmi_save_ident(dm, DMI_BOARD_VERSION, 6); dmi_save_ident(dm, DMI_BOARD_SERIAL, 7); dmi_save_ident(dm, DMI_BOARD_ASSET_TAG, 8); break; - case 3: /* Chassis Information */ + case DMI_ENTRY_CHASSIS: dmi_save_ident(dm, DMI_CHASSIS_VENDOR, 4); dmi_save_type(dm, DMI_CHASSIS_TYPE, 5); dmi_save_ident(dm, DMI_CHASSIS_VERSION, 6); dmi_save_ident(dm, DMI_CHASSIS_SERIAL, 7); dmi_save_ident(dm, DMI_CHASSIS_ASSET_TAG, 8); break; - case 9: /* System Slots */ + case DMI_ENTRY_SYSTEM_SLOT: dmi_save_system_slot(dm); break; - case 10: /* Onboard Devices Information */ + case DMI_ENTRY_ONBOARD_DEVICE: dmi_save_devices(dm); break; - case 11: /* OEM Strings */ + case DMI_ENTRY_OEMSTRINGS: dmi_save_oem_strings_devices(dm); break; - case 38: /* IPMI Device Information */ + case DMI_ENTRY_IPMI_DEV: dmi_save_ipmi_device(dm); break; - case 41: /* Onboard Devices Extended Information */ + case DMI_ENTRY_ONBOARD_DEV_EXT: dmi_save_extended_devices(dm); } } --=20 2.43.0