From nobody Thu Apr 2 00:12:48 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47BD2E0923 for ; Sat, 7 Mar 2026 14:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892603; cv=none; b=QYAwZAZ0wrSCFdw9WCZ1sol/r1L5KtSuY0tABBxNsC9trPXMBWGjSFAJ07g+6yMkPySe0npyWurPk1onFPEoCCa/xaAUILaN7a6dldHDLb4er3MvYgCFlP1g6psZ6/1JJxwmE3dv85D1tL5sPNP2931D+eMIPQCPZz1MCXOgJ+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892603; c=relaxed/simple; bh=KD+2tOKrOlbareEMhoIs6tHoWtHaZuqGmcL0jIFQO8I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YSJe0/OiAPqtmmNakyaWEg2k209KklQtzVp8GZWdPMH2SYDMEpQClWj41ZRlL6gIGKOYS3z11a5bU4WVPAOMs8wrtaobJ34uvq0p2PtKR/ros3b+UKFZ/78jzTi8YwECr1ejAm2xC/sY8oInFUcd3cX9z8vzWgFAn8ubFqBnNuc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fCYU9fkt; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fCYU9fkt" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-829b2019b39so465243b3a.3 for ; Sat, 07 Mar 2026 06:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772892602; x=1773497402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=czdNAj4K0eRQ1+jtOgU111t/1zRT7GMt/3oVDAa4ZYs=; b=fCYU9fktLOdjkhPef+5WzK6/Ezuq1tk6AVr7BA+1DHmYtAs26GDgR3Hmyv263jC4WG LoeL7WqeUgUlEPo+VVy7oIH/ZWCWactcElaoHFwQgJondJhlKUoGW8y0shkQf0a+hw/X iU8Gtu0VZXJLOGdGn1LybpSB7Jr9jKI4e+DLTbLCg7nSAKgyst55EjIKuqYiMjVZmwnX C/779QRINqn6IM6hoHedPdd1SAjbbi87ceEXb/lQhIxNLZZmiZ8UFn5oKfZ3cB8+WP8w VzUu6AMX65fpXhTfXqN1wxL4uxEofbS/0EVzhiS02KkupIfHatiw5hh1SYXty0WjTca2 zgvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772892602; x=1773497402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=czdNAj4K0eRQ1+jtOgU111t/1zRT7GMt/3oVDAa4ZYs=; b=I02M4tKH4i1yKeJJ8RessKBoaDezWd8SGC3f08rjjVli3lZFsVGYppxLDDEW8ardrY M+H2gPwwRDN96nnybBkx6FBBCIvl3EbJzGsPM6Lh2JZHd32KMPoL8V1Nlc7fTvgzTh80 kDbB7nfbihkB4vUCmMmDz2keb4+QXSE5OLgYJehPCtepBT4mt6y+dNohhbzqQCOeomAX BbYwlpm6375oB+LpLPTG7Upc6uomd0I32FGNAyD4JCLlSHyR5bG3KFs4PU951qc7JI1s Eh8JsSC09UxNtDtj2Lq28ZoNd1i20lPm9d7oETT4gwayeNJyX418eG2LWkdmQ7eoSvgG QlNw== X-Forwarded-Encrypted: i=1; AJvYcCU9wkV0GjGSNguxhHX7j75qU5OcnF3jOwhOY3hGh77oSWM7kbMM7dIkpf+XtL3XEPJt/1KEQ8ihIGzgp0s=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj9HJw/nbsNRD5bQMz1xE5sTvsdjYLcPfUHqrJvgJPcY2E2Rg6 04w+z3UW/6KQ7LNiRFdlN06CZ5eu5opsv7rJb896ps6YKrFqRCPZ3yxWC4zw1A== X-Gm-Gg: ATEYQzxvWFiaecV2oBIqe/Ojz1xS+AR1Y9PGqVbTPKfL4PSDD0eVLiXSthSyGsEZKA9 Y7XKYnbO7VsraGXDhSvvDyPQDttgxpbvM9DX+jC1m1TbUBiuywAH9tkCFrFwEtMxiZTYb9ybTr1 oN2mdCfLzfTHLmf8Ws+pkQ0RK54r1xeyFJLwGmnW/clFy+LGt7fmOvwGOk07TFPgdI8JWbAj8u0 oTkhxRcdT6bLtsryoDMI+xAT4X+jTIshRDTo3XbF6oLaxnXHTNr9aLGj77tnzoRxAQRWJp6dJOw qlASG2WCxro1E5+OsndYToe9i+WOJRRHgHaZj44EaDYzPygZEvhXJknB9evudYWo3lItYJhiGJg eOKkJ5w2zkXoS3uMbWpQUal5+mgTV/9pE6aLZ2NR6HYFFeTJw3vKwUl2uyTbnX3jjSEPw1BVePo /Z5AdWyct5jcbtVQPcHa4zbDK/H3KZdokVMCjQtezWnw8IUp7CGQklwchi4hH6NL1OZmMwknL8Q khtGzwljOcEwanDcDdhzP6Lx5yTcMfnfDs= X-Received: by 2002:a05:6a00:cd0:b0:823:c59:9cb0 with SMTP id d2e1a72fcca58-829a2db98d7mr5454772b3a.1.1772892602081; Sat, 07 Mar 2026 06:10:02 -0800 (PST) Received: from DESKTOP-7ISABPS.localdomain ([223.233.81.133]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a46765a6sm4784965b3a.29.2026.03.07.06.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 06:10:01 -0800 (PST) From: Rachit Dhar To: Cc: Rachit Dhar , Viresh Kumar , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Rui Miguel Silva , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/2] staging: greybus: fixed styling issue in fw-management.c Date: Sat, 7 Mar 2026 14:09:24 +0000 Message-ID: <20260307140930.1732-2-rchtdhr@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260307140930.1732-1-rchtdhr@gmail.com> References: <20260307140930.1732-1-rchtdhr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixed a styling issue highlighted by checkpatch.pl, that was occurring due = to improper alignment of function parameters. CHECK: Alignment should match open parenthesis + ret =3D fw_mgmt_load_and_validate_operation(fw_mgmt, + intf_load.load_method, intf_load.firmware_t= ag); Signed-off-by: Rachit Dhar --- drivers/staging/greybus/fw-management.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/grey= bus/fw-management.c index 5d01da6b6eb9..e20e9136c106 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsig= ned int cmd, return -EFAULT; =20 ret =3D fw_mgmt_load_and_validate_operation(fw_mgmt, - intf_load.load_method, intf_load.firmware_tag); + intf_load.load_method, + intf_load.firmware_tag); if (ret) return ret; =20 --=20 2.43.0 From nobody Thu Apr 2 00:12:48 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0BC2E2840 for ; Sat, 7 Mar 2026 14:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892607; cv=none; b=u15JSK/LymZ1B4HlECHsfsGBOiLN6pHNXvKsOWNZqt09FOW0V7vP6aZRjAyAl4+OZ5Mrt2Oe3tk8x1H0cYjLRek+hrDeveDY20YthScW6EraldcRZCbeKXuNFJq36tNMHrSEKj0izxvTT2hk6nl05lQoUhSJrmbhrZ5Xk/PBC9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892607; c=relaxed/simple; bh=jmEIE28vWDHD5ckD6Q3lCfUftsjDolrDenAEdgA8KRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kek2W75DrJxZPzRY1jbIoXYcGC4UsQsP45I+7hC5tDF/hTCX/5lfWF0mrc5w9DSPHmNKWturcsxpLbkkD1QdVZjIXbawWwemyoqZrH6jzz/nfE7lh5IDcmBTx1pUHStYzNFYaONlF1S5U7oOpLaHwYcRFGuuJzlI8odlKo1Ww8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S31EtTvN; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S31EtTvN" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-82735a41920so3875742b3a.2 for ; Sat, 07 Mar 2026 06:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772892606; x=1773497406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AlLqhfSeoTjEi2J59uhJ9PC75EMBz81L4kAgByHwzGM=; b=S31EtTvN4xjQ2pAtoYRGI5DRQt5Q0cjPKxdGySJX5f/emM9SNP7UXRGeeTdmmr2lFe l0g59TsX3iBDwGuO474y5qe/htrhjMCQJzGrshYK5YhCo1KnUxSMnWzGAn5XBu1iQGp3 he3SG+jPgMwicOpmopQ0T1I/dDuFr9LGoT3PQZ6JTvvyFkn5/bP0DCvPm/9Kv1cJgjpd BB2fokiZmPqQK7PlZl7c5PcFAkusxqUiyCykmRgqzOYM94LjITf3OKFapWhtKu/5HEH3 ZEHxIjaLZBkQuDv9xftS/l+RQv0gOH4ARamN/gqeux4ClGWPU6WYjNh5pvSRx8KtBdrE q5pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772892606; x=1773497406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AlLqhfSeoTjEi2J59uhJ9PC75EMBz81L4kAgByHwzGM=; b=W1590xRsky0jpto4YOIMndJlCzE3yL2S4ql0K8a/WsJECFr9In0F0bJZrh4bM93QWx UIvcFAGLM1haQECLnNpP5j3wb+MiUf6yVgyK5Ow6jQKAYtvtTACRSIdK/tj8HfpVvaJy MWCwg7AYanPYsCMTwKwOv/lxvazwAkciQgiJWw6EFTDVbEqWHrQKCCdavVTIEhKYSHOL OJ/SrJhdY/iEZgUslerfx0fj0YUaMWVm9YZNzQtVUy7QKCyvTnOdPKYnYFnmoHtG7ZnI VHijXa8zWf50bFkGwB14KSTkOEiN0ob+nLSSJEJXs/oGP0L60omdmy2CadDDIfhhuADV i1Lg== X-Forwarded-Encrypted: i=1; AJvYcCW67ngzmlf/vF7JV7eZTP0SIH9jFWGlTH5ier8a+1k4t+D0mIZt5Pc/MxwgqBChPPUCnZBsBNptU8/ASxw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl8MD1HaUy7VlZ8VxO91AY45zz6+Nxgjr85wy3I7q1vho0QaW1 Zn9ljgkWvDLu05KlcXxScPorVKClsO2xgh3YCkp7iNLLgLcTXI/9m5o5 X-Gm-Gg: ATEYQzwRw1flEZR3xIuxLLvqEYcvboZSosQ2NoKckOKTjLtMmm4HNfR7OXCQ85Lgx3J dUdL2BPfp+mFO4S979BBrB5lqifAoFvXBwMbbO1bcsTgedaMelyHAFAy1RhLgFfOCMfIerdN7EF 0XSjcoqT5B0z5R0r+eO+Rig0rTyZ8knA0hip1lGDR81OlV6anbKJb4O8G4E31XMTaxqikbC8Sp4 nBvnrPGvHtqsJQ1PROIfCy8zd2a1MA9Wmfsfa/WMBoav8Lvmq2qOexgwgkmC6WBX6usdH6CSzyS vxP6LjTiNrkDJXA5dStinzqcAvSydxXBxc74H4/7SfWv1KuC3UZCnvcuT8eJkDg86xABOnsQRWS svDvlfOXQI2I5fi5dS6Yz08abNx9A1R7ABwUM05a+JHhYam0eKA6lP83yymFU++M8g1mVVSOQXx rAKqCFcGqNU92JgZY6VJkqZVowsGzaM6I0zr14Gd1kYoTXazyUo1OA+X4kvqVI9lRWFyGscxY54 1wKP6PihCeO8GQOtOxbrfF7 X-Received: by 2002:a05:6a00:2d1e:b0:827:3845:921 with SMTP id d2e1a72fcca58-829a2e16119mr4416008b3a.27.1772892605629; Sat, 07 Mar 2026 06:10:05 -0800 (PST) Received: from DESKTOP-7ISABPS.localdomain ([223.233.81.133]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a46765a6sm4784965b3a.29.2026.03.07.06.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 06:10:05 -0800 (PST) From: Rachit Dhar To: Cc: Rachit Dhar , Viresh Kumar , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Rui Miguel Silva , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/2] staging: greybus: resolved checkpatch checks for light.c Date: Sat, 7 Mar 2026 14:09:25 +0000 Message-ID: <20260307140930.1732-3-rchtdhr@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260307140930.1732-1-rchtdhr@gmail.com> References: <20260307140930.1732-1-rchtdhr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added comments to mutex declarations, to resolve the associated checkpatch.= pl checks: CHECK: struct mutex definition without comment + struct mutex lock; CHECK: struct mutex definition without comment + struct mutex lights_lock; Signed-off-by: Rachit Dhar --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/ligh= t.c index cab02b5da867..1391c2b5d5f4 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -37,7 +37,7 @@ struct gb_channel { bool releasing; bool strobe_state; bool active; - struct mutex lock; + struct mutex lock; /* protects gb_channel->active */ }; =20 struct gb_light { @@ -59,7 +59,7 @@ struct gb_lights { struct gb_connection *connection; u8 lights_count; struct gb_light *lights; - struct mutex lights_lock; + struct mutex lights_lock; /* protects gb_lights->lights */ }; =20 static void gb_lights_channel_free(struct gb_channel *channel); --=20 2.43.0