From nobody Thu Apr 9 14:56:45 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB69344DB6 for ; Sat, 7 Mar 2026 11:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772884368; cv=none; b=mlOCN/gJebrIY2atZIA5L6yAOoGY+EriNP283/KauYqLXkteIjDSZBsmMPWxBgD+7uKv3CRKzHIgQxRYMYpGeupb18cCOGSAPv8xFMWFUC9TYwUMMNqWsAo5Lb31wm2/QX+UYMGBi8mnHEw4VA8TWbjy+SdQQ5LH1LLxNMEluA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772884368; c=relaxed/simple; bh=x14hvFkGwF04Zj4c1Booyr8tA2c9CZMGV8bNdLcE47M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=K7rgJnY/pDAh/4KXMA0oWf1idcJiEvAh2q1W1mVUOWxlvaH+tfZMR7I5ySXse+Obq0oxwat1z9m5Cv7IsxDR2CtItHIJUnraIiJyaP8J4cG5W8NwxXNbmL3JBKpZjAbhfXQuWi+1q2p2snvk27WlJbKg0S+3KvtaolBzma1Q/cU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RddsZBUQ; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RddsZBUQ" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ae8979dbb2so5720105ad.3 for ; Sat, 07 Mar 2026 03:52:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772884366; x=1773489166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dZDKh4IaVMdclzCWCv4XLUPdebdU7YmkNEuX3WsVI6M=; b=RddsZBUQEchcYXGAEM4WvCEidp/AHz52fq6kSzS242LxJQUJ1GMyt1tfBTO6hzcp0e W20dnzGLLnFX4oW6ZLLX9dmSFL9J/NA6PPE4NJeSllAdBLazCzWQYNAK5MA7YXytMGCd 4O98t/ZDrJjLWd4VRp8UKRa5qBBFpVlOj+CxIyez1Ddh9WuHfLScRE9/gvQsy6fcN6oU g9KkMjaN+nykzn6y1AcRGFJq+8s3GzmxyKwhZtOvHkih+LNH90/7U1kj/FTeySEcyW/V 9Rx/u9PVgv40jaZz7IQN7rjdKTYPRA/najf4HqG8H9XzFjZkax5jt+xbsvTO64VEI5NY HrnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772884366; x=1773489166; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dZDKh4IaVMdclzCWCv4XLUPdebdU7YmkNEuX3WsVI6M=; b=gW9hPRa54Re5KQS1Zx8/AtyoEa+dwC3DnivfXmRzpCiVZ0ujtPJbRo4xQ5YNQn9oCG Er74DcOFgDRkgkbPEIkUb/sHY+54imkCF5mrW6SOU1+0wgXbdtPY53KFns9aX9868Ter 3lfOIeM/lBBfFdHTjnuxuY5hgpXjwiWUD642GmVGA2VfRGy2ggKuWyeICLTxtmcWTGsf GSyg/OWFMZXG09S9LOhTHHf/5Zk4/C8I+ZMwghQKKmqrX30s5SDJU4jWty9YMKLlgIuj l6EJTQswfPBc3qzRzriTNvLelqdARJxsGWYje4Jpb3irGz7lhawWqYqArDVsKgNQeURn /ZQw== X-Forwarded-Encrypted: i=1; AJvYcCVYJ9DEa1ZF7fSC2ji3OruFCYXNFBi4gFGn94dIg9gOJdUOEGfPMx/6OTUR5DD6cpqUqzvagkX5MnEqwuw=@vger.kernel.org X-Gm-Message-State: AOJu0YxhKOAwzypasCD4Bx66Z6qMGbYwIbUdUplRbxvTDTSu0NWM4pRT 9ReeaRw4+qZuKNGZYIdA6lr9HgVTm9G2CyEQ23Kaiq2E1zfMzHbD2y94 X-Gm-Gg: ATEYQzxQkWQjr1u1b6PLCL4egc8RaYHAE+IqWOvIe0iPKspxOrbh5Zw8R609K5P5WMm MjmkozFyfYyBwOixUDOgy1sGKwyAhvqZZjIbW36lHV67mwsfFB47z9WP9VNi7b1C/SRr63J+D+P Qs4ln6fwsPEllrLeWOhY3kIX8f3sFn5APl/a7i4MnYvsTKyhCqQ8ZjgUWb4Bd7rfLNn0/P2IsYr CaW4FF1NIo1KMcdCpPiUbfrXH3HoghwQyqatLyBKU7KaVXXn7uyXPtGhjVmjF03fvoGfLRHtzsJ LRloS/bGX5zIf2I3YA/aDZGFZj9IU3tXhv2WIOmKQ0uGJNIhh9J5o7IkHwNEG+rkfI8ZsbjUD+k aRYUdhSV1foa5KHdyivrXxPzzQ+augrPv44f9B21Otn9H/xULaBdi71dHPS9IAnU1Afe+10NUcv A5izboILWLlHwW8NioAs+BU2v4QqD2Yc3GBsg65pTnUfhRugLtGQhK07nHEYEp016baumcrmP+ X-Received: by 2002:a17:902:ef08:b0:2ae:5b64:12da with SMTP id d9443c01a7336-2ae82506badmr59211005ad.45.1772884365886; Sat, 07 Mar 2026 03:52:45 -0800 (PST) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([2401:4900:4e5f:8ac8:a739:6c36:ff08:6f05]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e78f77sm67756675ad.21.2026.03.07.03.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 03:52:45 -0800 (PST) From: Tabrez Ahmed To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Brigham Campbell , Tabrez Ahmed Subject: [PATCH v2] hwmon: (ads7871) Fix incorrect error code in voltage_show Date: Sat, 7 Mar 2026 17:22:26 +0530 Message-ID: <20260307115226.25757-1-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The voltage_show() function returns -1 when the A/D conversion fails to complete within the polling loop. -1 maps to -EPERM (operation not permitted), which does not describe the actual failure. Replace this -1 error code with -ETIMEDOUT to better indicate the timeout condition to userspace. Drop the else block after return. Note: not runtime tested due to lack of hardware. Signed-off-by: Tabrez Ahmed --- Changes in v2: - Dropped unnecessary 'else' block after return as suggested by Guenter Roe= ck. Note: This patch applies on top of my previously submitted patch: "hwmon: (ads7871) Replace sprintf() with sysfs_emit()" drivers/hwmon/ads7871.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index b84426c940c5e..753bf77ce19b4 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -125,9 +125,9 @@ static ssize_t voltage_show(struct device *dev, struct = device_attribute *da, /*result in volts*10000 =3D (val/8192)*2.5*10000*/ val =3D ((val >> 2) * 25000) / 8192; return sysfs_emit(buf, "%d\n", val); - } else { - return -1; } + + return -ETIMEDOUT; } =20 static SENSOR_DEVICE_ATTR_RO(in0_input, voltage, 0); --=20 2.43.0