From nobody Thu Apr 9 19:25:18 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F130D36AB69 for ; Sat, 7 Mar 2026 10:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772878725; cv=none; b=Sus/4AKNNTtKhfYGLwRvUyqeqo6x8KLCJhEyqoL0KirpWguZjvesZYF6mlAqvMcAqm/Ty01L7BSKnRZ5uh1XxzrV7fPh9jSL64uh5IImplaa/WiiHHKgByqBGxwQDfWUOaHdBkSSUoiSMNCP2LyRpw/xxOQNeleegJaBg1v1GOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772878725; c=relaxed/simple; bh=/SmXTAY/xZRfSiD4uiSMI1Yh4L2ASRtyBwJyrX5qvvM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PcmQv4FWFJ7064bZhRuBK0YC5iWJ5w+QVQsrO+sHAoAVq/4hIx7KTb/JRv0GYQEcsw7SVa5ZMVl2amAEwI3bR0Tg/V3h0qb3gxi8NuGZ/IaLmIMIyQdc8sIUzI83U+UF/pSXSgGaoycK6Xz8bOIdV45WVYsVHODmRoJwnaI9XtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kN9UagkO; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kN9UagkO" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-bde0f62464cso3761296a12.2 for ; Sat, 07 Mar 2026 02:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772878721; x=1773483521; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M/I55kaLdBWzOitjkqtS2/HX//j8K3LJPhNqqPwMTTg=; b=kN9UagkOEmmEvEqTG6xjjVnRhdr6Gvtig7fgquq/78b5547MUNZ1JVfrnzlqkrSzCc rI0dg3ZBeAgGC7Q1QcMtwjAn+sis+YGib92cpVvET0VnJGqd3XjT3Vw5pJH9bDJXQQYd Mo2F+CnZFy95FxbnR+OeRyhaHcwuchv5pZiNyjCG51BvuMPh4wHB8sEth7ulbXeJvfic k8xR4vC8c5be/K6UEPaTmNJs20YOyeqql5xAC0pgfw2Nbp6qL0J2N2kkd9HrGnHol+gl ulw1/rBp//7FGR/dw4a3+gGCYnMF3px6QG5Vy02Qv9tehXWgG6dObOZtONjt5ANvGZtR FGvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772878721; x=1773483521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M/I55kaLdBWzOitjkqtS2/HX//j8K3LJPhNqqPwMTTg=; b=tC67DzTUwFMxhugvP8htDq2z7PsVTvmyQqzNdqvf1fOttMU+oaaWOEH7Bk2zAtdJuq 0mDwenQXuQrPUIx4QJ5gQJtkQImxJzI9mDJ8JlaPnF78d/XW55cjfLOxw+WgDj9/uB+i LLWsUVPgfdBg1PMhvBcHnd7yJwkrW6X6UHzwO4+Nuze1pKWsa//NZ/b1G1ygpdDtKSH1 OftGDCPP+XvpGXfHxp4n8GlP5/qn+1A56s6paiYmMrrn+w7bB2dfJlO9nnzlW2xymvtp MLLNKcbZv246YiJYr+x75cMBV12bMInqfmiLLkfpdgoV2Y7bBUJMQ9t0doXPTgdB+gAo 0zvg== X-Forwarded-Encrypted: i=1; AJvYcCUrWVC672SBKZbZOYRYAiHdyk0gS9yV/ldEhAUU7UyFXLeV90ZLBqeIJOSjugwY1aqCf1j4un+CX8N6/d8=@vger.kernel.org X-Gm-Message-State: AOJu0YwmubiBNXp8T2PO8MHR7l6gb7kVYgzZlv9t8lBMVYqkluj7lUIu 1cQPwr2pQHcamZrRoK3MBIsNr4STfrhpXt5Z10MtB+VFBTXpTu9kw2Rg X-Gm-Gg: ATEYQzx7NBLt8EFNDnBKbj9RGhRucP1lqDsaBwn0AA1W0mQFBoqNG3CoXJkRnGccKFC JD3opJpwNqzpkUORHnP3E/ObsxkvMMEZop2PfFTNQFOCSW73yQFzo7HZoy0EW4PoMjcepUbnOBs ++e/SuVp4GLqzisICvRCTXfIas5MCN7QTbtHmARCXLbHqBI8ecyggl0UODNBmSVBAC7ibrqW/UX 9ihVqVScWNDD3NFeQ9tuQQmOvX7qEMQa/d/Z/30HRnpKmpOKP2heGHw2TgH4feGRDeuH3QfMYm/ I2vum2+PZv8hXhWmYeKddmVVpgYekAP2wMF7c7uZEnYCJ5VlSXoovKOVKtHiZirbFpVDmS8jS1n Wk4oD2GBOe/uMGVa9C/O+ifSNpznbaxsQJGD02d9QxqcsEYIExUlBlfC6KBrX9DLfbutp9dS2LK m32XQdFbowyI/mVU6HUE6fMTIozsswm39EGSwe6wZxabgGJoi14aiU6MKsEMwl8gutTZIyKsC3R phZ7Qd4iusiQ2X5zzOHjeZn X-Received: by 2002:a17:902:ebc3:b0:2ae:512b:eea9 with SMTP id d9443c01a7336-2ae82430f22mr53741175ad.36.1772878721117; Sat, 07 Mar 2026 02:18:41 -0800 (PST) Received: from fedora ([103.215.156.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f7864dsm48381265ad.49.2026.03.07.02.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 02:18:40 -0800 (PST) From: Rajveer Chaudhari To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, puranjay@kernel.org, dlechner@baylibre.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v3 3/3] iio: accel: adxl372: convert to guard(mutex) Date: Sat, 7 Mar 2026 15:47:58 +0530 Message-ID: <20260307101758.50091-4-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307101758.50091-1-rajveer.chaudhari.linux@gmail.com> References: <20260306211152.65109-1-rajveer.chaudhari.linux@gmail.com> <20260307101758.50091-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in adxl372_write_threshold_value(). Remove goto label and return directly on error path. v3: Return directly from error path without goto. v2: Split into separate patch per driver. Signed-off-by: Rajveer Chaudhari --- drivers/iio/accel/adxl372.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 28a8793a53b6..340433782cf2 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -334,20 +335,15 @@ static ssize_t adxl372_write_threshold_value(struct i= io_dev *indio_dev, unsigned u16 threshold) { struct adxl372_state *st =3D iio_priv(indio_dev); - int ret; =20 - mutex_lock(&st->threshold_m); - ret =3D regmap_write(st->regmap, addr, ADXL372_THRESH_VAL_H_SEL(threshold= )); + guard(mutex)(&st->threshold_m); +=09 + int ret =3D regmap_write(st->regmap, addr, ADXL372_THRESH_VAL_H_SEL(thres= hold)); if (ret < 0) - goto unlock; + return ret; =20 - ret =3D regmap_update_bits(st->regmap, addr + 1, GENMASK(7, 5), + return regmap_update_bits(st->regmap, addr + 1, GENMASK(7, 5), ADXL372_THRESH_VAL_L_SEL(threshold) << 5); - -unlock: - mutex_unlock(&st->threshold_m); - - return ret; } =20 static int adxl372_read_axis(struct adxl372_state *st, u8 addr) --=20 2.53.0