From nobody Sat Apr 11 09:09:43 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D545E336894 for ; Sat, 7 Mar 2026 06:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772866463; cv=none; b=T9xVVeT8X7ecnUxh189anSppfthtrIGIeorTyaCETp025xsrYNsIDjyPM1hJeBpzMl2LDGUo6TSjPrCdZjyhw8l+wGj8T7jbOXlcVlSfR0h/RbOliC7mLO9PcR2YTspBaAJ+7+BkEdHozoznTIGkF4nLyJZ1MPh6ebh+R4LAJwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772866463; c=relaxed/simple; bh=bP6c3sT+V4RHEwFQm5V0XUbBDPOTQenKAaYyhZdLacw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TpBCJCTP66fWHwD/qikdMER0Auh8IeOP940odVYkFFB3fk96QWOoY0UDAtdFMjIiOA0Uq5BHRWSh0Y/1QmC/ZGPoIu7H0Vyz6wnE0RTOqlvFB0lcX576vkPjDNDKJD71Lt9bxgiUeZPejlMjXn9KAKHIIk67Tr51D/xDcOqtKjg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ix1y+yfN; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ix1y+yfN" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a9296b3926so75393505ad.1 for ; Fri, 06 Mar 2026 22:54:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772866462; x=1773471262; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CFh5xzf9mXTWKL8wgZ/1CT8NM6bT0JUa5sch2tV0MvY=; b=Ix1y+yfNHgYm3qDGQofYJzPoYUi+qzv36RlD9NlYj5IQhlgYTGC+bXn1AO06vNUVZR x65u/8WP6Y/Z7DUbiwDEztIPgf5zDeI6zaJ6G7uvRn11zBG9BvnRPRw0ypBCzRuXTS8d hPd5u/yULqU6ps5lOw+F8eoHYXXX6lkKapf4hkqwX9G4j9sD932TqQFdD2QTywGX7WUZ K3qXN1VkcC0gck6sSV4+vqjwxDArCdlRHSRGHD40ZlkwCF46pssSst+gnalEdzwNtZ17 Te4P4WdnvY1G2zKf6diEZMEdJMb5XLT6EGKVy6PORh3mQJkqfHqJAhX8yTYGKTf7GVO7 pY1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772866462; x=1773471262; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CFh5xzf9mXTWKL8wgZ/1CT8NM6bT0JUa5sch2tV0MvY=; b=wrEIsNn6e9P9lMfFaa84uru5+B5O1pjNCMrQZiUYxZKhfjCFaUbDL02Hpap/PvRIqL tiuDlpFIQduwRaHhXMhOdNDCiPCcmAeTSDsBwFtkz0c5sWMdNJ2BT95H5CVcXZ3cIurM 9L6PWyeFi0c6zxIMil3WTjt7uObpcr4xVaEdkn72248JJVhp+SO9z61feekmax0t95XW LXLCTZPZHWwwpfs9nPjW9e8XFtjN2KrfbEj+FAFSa0kC+jOwxhIJtyCnss8RwMauDN1v Ba1pq03dA6mgXM1CMqWt+ihEUBfy9fz0LhP7PrV9TQ2Q1mvYacRkUNSZITLQKiIQUQyA iy0g== X-Forwarded-Encrypted: i=1; AJvYcCXrc8D3WsME3XWLviI4x1TGgSeePloF2AIG8hxWwyGoteWu0SqlIsFm7aEx9kIb55wHWFMxx/P4B2iq27o=@vger.kernel.org X-Gm-Message-State: AOJu0YxRGgU7bjYhQQTJIx2ZD8FCtaC1FpO5CuA+9azmqi79OCtCEzWi GlDaGjvUXXZcawQPrbOO49boaozyenQVsjDyOBplC/dhCR5qi1SP1dbh X-Gm-Gg: ATEYQzxBqrTFgDf6qYCCf4wCd3aXMDTTw93e2fo/yyVt46TT3Q6yKnldosOaLR9u1Tk Tt7jHV+UyVMqDH1DjLATA++wAWbXzIpaGNuME2WsiOw2HbFV6uV025B1WWej3QJkLaafUC08fOZ CpoYcJckb+N2xmroFvGkVIUcHXcSKJsJ42bJKgkxKs7/SciNt6zccgxkQ0gtVtJlB8++oGWScXQ NqFAoARQoJYBVveKYMVIpXHlsAgsbFnIAPQW1qU3FJ4OXSclLVtVfnPO3Ov6wbdf8OtTkcfS2kE 9Frgl880fM5QLnCmQ2W6GaotJJ7PUjbgtlOGR2xQslOogJcYWLialFXZ1xPX4lOwopI1lGwYtoi MnuxwFuW3clOkyFg0AmJSPRYaMsMyEv4zAMfONSRBLdSDoxT2S+/YbjpMDZcHvkTidtOjqWZyg8 bkkh1Tp+AeCY+i1UpkVzoEXliSipkE+g+tsLriz+heKvQ= X-Received: by 2002:a17:903:120f:b0:2ae:670e:309f with SMTP id d9443c01a7336-2ae824f4d5fmr46909505ad.34.1772866462157; Fri, 06 Mar 2026 22:54:22 -0800 (PST) Received: from DESKTOP-3LEPQG8.localdomain ([119.28.20.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e77197sm41388995ad.20.2026.03.06.22.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 22:54:21 -0800 (PST) From: Xie Yuanbin To: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Xie Yuanbin Subject: [PATCH] mm: optimize once judgment with clang Date: Sat, 7 Mar 2026 14:54:04 +0800 Message-ID: <20260307065405.37473-1-qq570070308@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 242b872239f6a7deacbc ("include/linux/once_lite.h: fix judgment in WARN_ONCE with clang") helps optimize performance and size under the clang compiler, but the modification is not complete. Port the modification to WARN_ON_ONCE_GFP(), VM_WARN_ON_ONCE_PAGE(), VM_WARN_ON_ONCE_FOLIO(), VM_WARN_ON_ONCE_MM() and VM_WARN_ON_ONCE_VMA(). Cc: Andrew Morton Signed-off-by: Xie Yuanbin --- include/linux/mmdebug.h | 8 ++++---- mm/internal.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h index ab60ffba08f5..a167c5aa525e 100644 --- a/include/linux/mmdebug.h +++ b/include/linux/mmdebug.h @@ -60,7 +60,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_page(page, "VM_WARN_ON_ONCE_PAGE(" __stringify(cond)")");\ __warned =3D true; \ WARN_ON(1); \ @@ -80,7 +80,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_page(&folio->page, "VM_WARN_ON_ONCE_FOLIO(" __stringify(cond)")");\ __warned =3D true; \ WARN_ON(1); \ @@ -91,7 +91,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_mm(mm); \ __warned =3D true; \ WARN_ON(1); \ @@ -102,7 +102,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_vma(vma); \ __warned =3D true; \ WARN_ON(1); \ diff --git a/mm/internal.h b/mm/internal.h index 6e1162e13289..52367f52d623 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -93,7 +93,8 @@ struct pagetable_move_control { static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(!(gfp & __GFP_NOWARN) && __ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && !(gfp & __GFP_NOWARN) && \ + unlikely(!__warned)) { \ __warned =3D true; \ WARN_ON(1); \ } \ --=20 2.51.0