From nobody Thu Apr 9 16:33:21 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED8D7260F for ; Sat, 7 Mar 2026 06:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772864737; cv=none; b=syIkV4X5WSh2N2A5dzpCm+tE7RkqZSYnU3cakKCK7Swsqd3XzGQxna+ruBrk2IQ6aSm7g80DzESI5VLWctG8xdzOGn1I1HH6WeNR6Ic07CeIP2TzFTnRQPVRB+UPaqf1rfH6Bzz/JbhUmpTIQhv3rNxSqarqriVzCf0nKW95WCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772864737; c=relaxed/simple; bh=7GXPB5tPIENL1r010383M94Fh8cc+1SaXwJPoDMp1a0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UYdZx6xwKvUzUKaerMCKUPbX6QFNYFBiOcLYC+bVJ9Mhe+xEDjko8U14kFYmSqyuXjEG82pfQjCHSepYpTlCT69fDVGrZLwgFEO4sjSIDqP9sxmpsJmtkadbkhVzwig+ZaUyBzLdp7V5HvRjhmHNQhhKqR9E9yrLw2xmunB6zw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NwhOEqsP; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NwhOEqsP" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-829865a8471so2686107b3a.3 for ; Fri, 06 Mar 2026 22:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772864735; x=1773469535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hV+qom7OsL2lmYdSGEPwQnrfWB7wQ9siJwxTvLW3avw=; b=NwhOEqsP909ZmAvdJ1PxsyY3DpgsQ/2kt/UkqBmWRQ83lxZanJuqz7gd2rglGBIbpy i5mC+SLpuYuICRH5REJen4N+lbsQV3hjEXyYsRESWRNMYmwiLy5EL18W6dkQ1CPoUyul /Hw13eMh/c1pqW8t/MR3Fs8+p/Ue8/9El/oaU4cVGNblUbep37gRxKPglzE61VYoxR8F 5WfJR+4ydc0q/XGIggHQ2RMXT/yOFZ8CemgJ5qqqOiHql65uxasCGiRg2HeQN2ctbrs5 hS+4FUrdezYiPkrl16QYEogVkkNXIuMqDxDWffO79/reeHVwXLGxYGVjuTjfJePaoGh/ M6Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772864735; x=1773469535; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hV+qom7OsL2lmYdSGEPwQnrfWB7wQ9siJwxTvLW3avw=; b=kfL7bMTOaxErnFZjll0VfgVJZQXvNNg7VcAoWO7Eiz5lhMos/4gPlrT6dDB9mn+hT7 3Tq2f+lmBsJu3FjVKTv4QsWclUTqLJMBLNN9fRX/rpWLdWqFWg2XlFJdpWZ8daBS2OLf ASzaR15g4UWeFj+5aA27z7SqDVXmMeNHY9uAHYSxG0D6jUJnHUKAJYP6/KvFG71FsDxN mKiNfU7i9JGm+US4xQVFTO5ulf5RzEvPE9WZBS9zwy87REnh5o1RDDvkBQzmWT91/2xO FwZB74lo5Z2vla4Jb+B6P0vb+4QKJXsda0gzPssL6cpsSi8SoM8z/ovoRXZKMVxmc0iR LuMg== X-Forwarded-Encrypted: i=1; AJvYcCWK++uNMWptsGfOY0Z4syrHmZewv0ihblhvYRqHmkeGayU8PmRY8hA5qEX7lQ+0EdxauVWf6G9uIw7aS5I=@vger.kernel.org X-Gm-Message-State: AOJu0YwONGa6jlmjld9S1mqRKavbGqL660ktsssaeJLPAmRjEiCQOO0x Rq7UfQVFTg3I1Z4RJ6W2EiwSDPzxeYf6NiVAWeo5CldbjGzNqLP0K59kVMHAI+X7Rgs= X-Gm-Gg: ATEYQzySNECcdpIgDahqKZoT6X6dg1Fg48QM12R3D5whLl3G6ERYJ+H21BngRJHeOFI X2hNDT/99nRjFSFG7Dk2cFO6NZR/Yr6kDasqybjT0kH9OirBwdu4hO5IeJFKP+NZPAU0IwBjSOn ejoF1Ff+q7McMqW1zdQocpt48MIyG53CEn7thNa4otQLSIJngNgbz9pTphstTpfnKPXMBh7TWz5 KiGKqUlcgfLmJuxzvse2E5scsEuQqI2bC7ychnCx+AvfEChq1im3+3f4sep9y7OtPHf5L5N5z/a Z75wxcNErWsFo+ZxYX4CXXYBsbRTcpyli4/v4k7bCDlAI8IB77fLd3lpze+L4XkKR4crCr5pB0G LI/HtYrGYSi7AOI9xahqJLhJMVuYF0lwaP/z/kkeeQ/So+Tr8YWca6JFbwhiDb/YFN9nlpBAE7m kvZ2YoHW2Qjb0Qhyn6oynUtvX1BDQx3n7Rv/iB56LAcPCzf+VrXu7snpOn6mJrps6A/VZb+2WNq QG+GvXsvQtZdSpD X-Received: by 2002:a05:6a00:c95:b0:823:edd:20b9 with SMTP id d2e1a72fcca58-829a2fa9676mr4591649b3a.61.1772864735289; Fri, 06 Mar 2026 22:25:35 -0800 (PST) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a4866a72sm3451754b3a.36.2026.03.06.22.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 22:25:34 -0800 (PST) From: Mark Adamenko To: linux-staging@lists.linux.dev Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH] staging: media: imx: fix parenthesis ending checks Date: Fri, 6 Mar 2026 22:23:53 -0800 Message-ID: <20260307062353.22069-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove 4 checks for ending with a parenthesis by removing unnecessary line breaks, and forward declare a variable for a function call that would otherwise remain over 80 columns. Signed-off-by: Mark Adamenko Reviewed-by: Frank Li Reviewed-by: Philipp Zabel --- v2: remove empty line --- --- drivers/staging/media/imx/imx-ic-prpencvf.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/= media/imx/imx-ic-prpencvf.c index 77360bfe081a..2339b59af7b0 100644 --- a/drivers/staging/media/imx/imx-ic-prpencvf.c +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c @@ -315,8 +315,7 @@ static void prp_setup_vb2_buf(struct prp_priv *priv, dm= a_addr_t *phys) buf =3D imx_media_capture_device_next_buf(vdev); if (buf) { priv->active_vb2_buf[i] =3D buf; - phys[i] =3D vb2_dma_contig_plane_dma_addr( - &buf->vbuf.vb2_buf, 0); + phys[i] =3D vb2_dma_contig_plane_dma_addr(&buf->vbuf.vb2_buf, 0); } else { priv->active_vb2_buf[i] =3D NULL; phys[i] =3D priv->underrun_buf.phys; @@ -704,11 +703,9 @@ static int prp_start(struct prp_priv *priv) } =20 if (ipu_rot_mode_is_irt(priv->rot_mode)) - priv->eof_irq =3D ipu_idmac_channel_irq( - ic_priv->ipu, priv->rot_out_ch, IPU_IRQ_EOF); + priv->eof_irq =3D ipu_idmac_channel_irq(ic_priv->ipu, priv->rot_out_ch, = IPU_IRQ_EOF); else - priv->eof_irq =3D ipu_idmac_channel_irq( - ic_priv->ipu, priv->out_ch, IPU_IRQ_EOF); + priv->eof_irq =3D ipu_idmac_channel_irq(ic_priv->ipu, priv->out_ch, IPU_= IRQ_EOF); =20 ret =3D devm_request_irq(ic_priv->ipu_dev, priv->eof_irq, prp_eof_interrupt, 0, @@ -750,7 +747,7 @@ static int prp_start(struct prp_priv *priv) static void prp_stop(struct prp_priv *priv) { struct imx_ic_priv *ic_priv =3D priv->ic_priv; - unsigned long flags; + unsigned long flags, timeout_in_jiffies; int ret; =20 /* mark next EOF interrupt as the last before stream off */ @@ -761,9 +758,8 @@ static void prp_stop(struct prp_priv *priv) /* * and then wait for interrupt handler to mark completion. */ - ret =3D wait_for_completion_timeout( - &priv->last_eof_comp, - msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); + timeout_in_jiffies =3D msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT); + ret =3D wait_for_completion_timeout(&priv->last_eof_comp, timeout_in_jiff= ies); if (ret =3D=3D 0) v4l2_warn(&ic_priv->sd, "wait last EOF timeout\n"); =20 --=20 2.53.0