From nobody Thu Apr 9 15:44:35 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA6D274B59; Sat, 7 Mar 2026 01:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846189; cv=none; b=S0G0nWJovypPZ888d0OiFbHLS3Na6UBE55wMJognNftwkr9rGGNluPgBFX/F87X0uIH1mpm9rSOqKNhqcPE1dzZBv1Q6/k4Qijs+RI3HDtQI5iB487aDT0nVcVmio20n+tUFO1CCG1rzlxRAa9f+8OR5HLG1ZbA4ro6E0osUCjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846189; c=relaxed/simple; bh=/jM89V+CWLDBymMiRseLOgVvpispDMXp3ujS8XoteeQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dTztVaByAcoUnGvs1ecQhM/uJdsiDIBhnMW5Tb9SHZXq0XDl2nK3MqKX0C8gLCcxsoXffH2sjJP3FXFBcW39+DvzrjwTky4VVKpYNaMR9cmtET+FG2LKXMg+smYjzbTKvCcK1JmxLrPDnmIverYtK1qNRGq63K7t/Frf3gs0k4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jb8W/uJW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jb8W/uJW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8C6EC2BC9E; Sat, 7 Mar 2026 01:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772846188; bh=/jM89V+CWLDBymMiRseLOgVvpispDMXp3ujS8XoteeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jb8W/uJWv+P/jM3HZM0L3apVnUqxDgV2XzXA83iBKzaH58kYseKTfglznYBSIGCFW fafBuLWnn4pc2HqDQNRWu/3KaFWsEO+JWu4MPTek28ynTD6u8j/zde+XJaDtiQCMqp s2NP2Ipi4R1evWz2whr2ytB8WZBgjpuCtXdJ4XyISpy74VJsGmnVzQCt/ASSuKFE7V P7dB0Q/LvjE5gs9effQuFlhSvOmCfziF+LH9+QUpkdAdVECwJQB/WmvdM9zzWxxovU smaqQiFN8dvbdb9IQw0VdZrghYYHapQr12+e9kx+v9Z6UWd1slbr4MjCjxebWOHNn7 /Sj+5L03JmFrw== From: Yosry Ahmed To: Sean Christopherson Cc: Paolo Bonzini , Venkatesh Srinivas , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: [PATCH v2 1/3] KVM: x86: Move some EFER bits enablement to common code Date: Sat, 7 Mar 2026 01:16:17 +0000 Message-ID: <20260307011619.2324234-2-yosry@kernel.org> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog In-Reply-To: <20260307011619.2324234-1-yosry@kernel.org> References: <20260307011619.2324234-1-yosry@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move EFER bits enablement that only depend on CPU support to common code, as there is no reason to do it in vendor code. Leave EFER.SVME and EFER.LMSLE enablement in SVM code as they depend on vendor module parameters. Having the enablement in common code ensures that if a vendor starts supporting an existing feature, KVM doesn't end up advertising to userspace but not allowing the EFER bit to be set. No functional change intended. Suggested-by: Sean Christopherson Signed-off-by: Yosry Ahmed --- arch/x86/kvm/svm/svm.c | 7 ------- arch/x86/kvm/vmx/vmx.c | 4 ---- arch/x86/kvm/x86.c | 14 ++++++++++++++ 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 3407deac90bd6..5362443f4bbce 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -5556,14 +5556,10 @@ static __init int svm_hardware_setup(void) pr_err_ratelimited("NX (Execute Disable) not supported\n"); return -EOPNOTSUPP; } - kvm_enable_efer_bits(EFER_NX); =20 kvm_caps.supported_xcr0 &=3D ~(XFEATURE_MASK_BNDREGS | XFEATURE_MASK_BNDCSR); =20 - if (boot_cpu_has(X86_FEATURE_FXSR_OPT)) - kvm_enable_efer_bits(EFER_FFXSR); - if (tsc_scaling) { if (!boot_cpu_has(X86_FEATURE_TSCRATEMSR)) { tsc_scaling =3D false; @@ -5577,9 +5573,6 @@ static __init int svm_hardware_setup(void) =20 tsc_aux_uret_slot =3D kvm_add_user_return_msr(MSR_TSC_AUX); =20 - if (boot_cpu_has(X86_FEATURE_AUTOIBRS)) - kvm_enable_efer_bits(EFER_AUTOIBRS); - /* Check for pause filtering support */ if (!boot_cpu_has(X86_FEATURE_PAUSEFILTER)) { pause_filter_count =3D 0; diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 9302c16571cdc..2b8a7456039c7 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -8583,10 +8583,6 @@ __init int vmx_hardware_setup(void) =20 vmx_setup_user_return_msrs(); =20 - - if (boot_cpu_has(X86_FEATURE_NX)) - kvm_enable_efer_bits(EFER_NX); - if (boot_cpu_has(X86_FEATURE_MPX)) { rdmsrq(MSR_IA32_BNDCFGS, host_bndcfgs); WARN_ONCE(host_bndcfgs, "BNDCFGS in host will be lost"); diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 879cdeb6adde2..1aae2bc380d1b 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -10025,6 +10025,18 @@ void kvm_setup_xss_caps(void) } EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_setup_xss_caps); =20 +static void kvm_setup_efer_caps(void) +{ + if (boot_cpu_has(X86_FEATURE_NX)) + kvm_enable_efer_bits(EFER_NX); + + if (boot_cpu_has(X86_FEATURE_FXSR_OPT)) + kvm_enable_efer_bits(EFER_FFXSR); + + if (boot_cpu_has(X86_FEATURE_AUTOIBRS)) + kvm_enable_efer_bits(EFER_AUTOIBRS); +} + static inline void kvm_ops_update(struct kvm_x86_init_ops *ops) { memcpy(&kvm_x86_ops, ops->runtime_ops, sizeof(kvm_x86_ops)); @@ -10161,6 +10173,8 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *op= s) if (r !=3D 0) goto out_mmu_exit; =20 + kvm_setup_efer_caps(); + enable_device_posted_irqs &=3D enable_apicv && irq_remapping_cap(IRQ_POSTING_CAP); =20 --=20 2.53.0.473.g4a7958ca14-goog From nobody Thu Apr 9 15:44:35 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A06F2D3A7C; Sat, 7 Mar 2026 01:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846189; cv=none; b=MP7CJE6ZIKZkmgDC52Gi6FdP9kbgOJiOlCzrPa4IwLCV7+8uJfUqkH0wh4HTufV89WViAr8fQFu/PW3RO+UMxt5u52uLNMNL6lBP2LnF1+tf0meIgkhghfUtqXHFSRN4iG3H0B2zg0CBIDBwovPw8rVJFN3JRPddgzy9uUrEQeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846189; c=relaxed/simple; bh=pbvDC5cATKYlFj6xqezHC6kl2o6p3pGv/bHyMa5pBz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rKMKpDfWBZ9Mpa5B3dAVYGvapLslNOdAxF0WKwue5BGubMnQL9oTkneqPOTibSa53u3ujQENcpJQGPJdwBrI4KJMPIEwBQSMSkXLOrKymcBxGOqmjpNfQsPBHw3xI3QHDyB39UCaRXRKzeihYdnW+xeBXshVxwsyNhteWStrBIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mniWdhCX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mniWdhCX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17B99C4CEF7; Sat, 7 Mar 2026 01:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772846189; bh=pbvDC5cATKYlFj6xqezHC6kl2o6p3pGv/bHyMa5pBz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mniWdhCXQkUgmTaEFFzoQ1XjD1VCkhplQdY7Tp3Hp3bWPci8WT/Ykg0gIFVUw4yfe cqd+1hBnZ8q42ZhQu9oPtYaePn/JSxwPgPa3CJICfhManPZ2gkq6e6yRqPsApbWd7S iLC5mVUobKMZk7ZbNoQjc7jBDgQfDhZTk0UcozMMauJDI08QA9j9uUlRcXYjAyXeLw rWcWZtFY1nyjb8tgEV5EcYjnCYOSzz1Ytr/pc9aY0ik7PsWkvc3QnQtwMpMezJKFa1 dapsMEb4/vxuw+Bel6GyfFAv4ogbWZJuEGuf1xx1sVLIWaUNwk0N72iASF/DnDjTRi gsKMijnNzJzkw== From: Yosry Ahmed To: Sean Christopherson Cc: Paolo Bonzini , Venkatesh Srinivas , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: [PATCH v2 2/3] KVM: x86: Use kvm_cpu_cap_has() for EFER bits enablement checks Date: Sat, 7 Mar 2026 01:16:18 +0000 Message-ID: <20260307011619.2324234-3-yosry@kernel.org> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog In-Reply-To: <20260307011619.2324234-1-yosry@kernel.org> References: <20260307011619.2324234-1-yosry@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of checking that the hardware supports underlying features for EFER bits, check if KVM supports them. It is practically the same, but this removes a subtle dependency on kvm_set_cpu_caps() enabling the relevant CPUID features. No functional change intended. Suggested-by: Sean Christopherson Signed-off-by: Yosry Ahmed --- arch/x86/kvm/x86.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 1aae2bc380d1b..0b5d48e75b657 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -10027,13 +10027,13 @@ EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_setup_xss_caps= ); =20 static void kvm_setup_efer_caps(void) { - if (boot_cpu_has(X86_FEATURE_NX)) + if (kvm_cpu_cap_has(X86_FEATURE_NX)) kvm_enable_efer_bits(EFER_NX); =20 - if (boot_cpu_has(X86_FEATURE_FXSR_OPT)) + if (kvm_cpu_cap_has(X86_FEATURE_FXSR_OPT)) kvm_enable_efer_bits(EFER_FFXSR); =20 - if (boot_cpu_has(X86_FEATURE_AUTOIBRS)) + if (kvm_cpu_cap_has(X86_FEATURE_AUTOIBRS)) kvm_enable_efer_bits(EFER_AUTOIBRS); } =20 --=20 2.53.0.473.g4a7958ca14-goog From nobody Thu Apr 9 15:44:35 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF0062D7DD2; Sat, 7 Mar 2026 01:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846189; cv=none; b=ghXtl3mx2Sb9S9IXXxXO3Wt01LuxlmIj6f0/3JrhuM/SxYPGhp8ap88gpyuRg8iAF7M5Qyf911VZDMADIC3/T6v8D+62PbKM3ozzXxq6EK/l8gtY2rOFdkX8mv2h4qTiulzXxn7BsMLmYLhy1TLJMAzGHEHnduAk8EnFR2cnHzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772846189; c=relaxed/simple; bh=m8zySj9DBqQy/fDY4oXr5d3p6i7ivV2qeHI61VTnFQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s/JpiPPZFMNgNwpI2/fEUZplxumsTuzxc1bdKrHrZtpy/A5lGNCILEk1nqUf0Cv5Y6TBsrASUH4hJPXjsi7OV6N0pDwdsv/ST7CZ/+l7BJ/DaZ2nEXZFDoFfNVLkctYH37mc1/kErbT6KZtctX4BCLhz4hovuWSuyYH04TLOAq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WMOvNERC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WMOvNERC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B7BAC19422; Sat, 7 Mar 2026 01:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772846189; bh=m8zySj9DBqQy/fDY4oXr5d3p6i7ivV2qeHI61VTnFQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WMOvNERCh2jK0vh5JSSovVD6XkDSJ21dsnEotI4WjahX0QmaFMrLHl5GeHVyoRC1y bpye2nIKvfIdTUZjPE0uhmnd98f2furc4C2acnk5qJjGjlekWGowTb2W9wsjAga6L3 cJODMlVahrEDcIdfj+4QoBWGs70uI2iiU0EGcH/IMYf2zw/bFfwbXA48LwV2yS/ycW VYIvkmhaEdZSf+tMH1dMZWzJrau1u25Sd1B0WTQGSt4aZG6vgBUp2Ys9BD9a8Vg7f/ MD+lR05hJoLoxc42uZj3X+bA5JxZvQSxoo1TfavJvwM/70kr7YzsEaJoXJkVy6oJu0 fYyeGkdUJPsyA== From: Yosry Ahmed To: Sean Christopherson Cc: Paolo Bonzini , Venkatesh Srinivas , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Venkatesh Srinivas , Yosry Ahmed Subject: [PATCH v2 3/3] KVM: SVM: Advertise Translation Cache Extensions to userspace Date: Sat, 7 Mar 2026 01:16:19 +0000 Message-ID: <20260307011619.2324234-4-yosry@kernel.org> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog In-Reply-To: <20260307011619.2324234-1-yosry@kernel.org> References: <20260307011619.2324234-1-yosry@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Venkatesh Srinivas TCE augments the behavior of TLB invalidating instructions (INVLPG, INVLPGB, and INVPCID) to only invalidate translations for relevant intermediate mappings to the address range, rather than ALL intermdiate translations. The Linux kernel has been setting EFER.TCE if supported by the CPU since commit 440a65b7d25f ("x86/mm: Enable AMD translation cache extensions"), as it may improve performance. KVM does not need to do anything to virtualize the feature, only advertise it and allow setting EFER.TCE. If a TLB invalidating instruction is not intercepted, it will behave according to the guest's setting of EFER.TCE as the value will be loaded on VM-Enter. Otherwise, KVM's emulation may invalidate more TLB entries, which is perfectly fine as the CPU is allowed to invalidate more TLB entries that it strictly needs to. Advertise X86_FEATURE_TCE to userspace, and allow the guest to set EFER.TCE if available. Signed-off-by: Venkatesh Srinivas Co-developed-by: Yosry Ahmed Signed-off-by: Yosry Ahmed --- arch/x86/kvm/cpuid.c | 1 + arch/x86/kvm/x86.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index fffbf087937d4..4f810f23b1d9b 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -1112,6 +1112,7 @@ void kvm_initialize_cpu_caps(void) F(XOP), /* SKINIT, WDT, LWP */ F(FMA4), + F(TCE), F(TBM), F(TOPOEXT), VENDOR_F(PERFCTR_CORE), diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 0b5d48e75b657..f12da9e92475e 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1743,6 +1743,9 @@ static bool __kvm_valid_efer(struct kvm_vcpu *vcpu, u= 64 efer) if (efer & EFER_NX && !guest_cpu_cap_has(vcpu, X86_FEATURE_NX)) return false; =20 + if (efer & EFER_TCE && !guest_cpu_cap_has(vcpu, X86_FEATURE_TCE)) + return false; + return true; =20 } @@ -10035,6 +10038,9 @@ static void kvm_setup_efer_caps(void) =20 if (kvm_cpu_cap_has(X86_FEATURE_AUTOIBRS)) kvm_enable_efer_bits(EFER_AUTOIBRS); + + if (kvm_cpu_cap_has(X86_FEATURE_TCE)) + kvm_enable_efer_bits(EFER_TCE); } =20 static inline void kvm_ops_update(struct kvm_x86_init_ops *ops) --=20 2.53.0.473.g4a7958ca14-goog