From nobody Thu Apr 2 06:31:34 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E48F03ECBE3 for ; Fri, 6 Mar 2026 15:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772812170; cv=none; b=ta2JH4BcjN7FvC4Td1cdxMWgqnIInTR1CdwYRLGmE/GLwLx/YiWCsFaFPMnUfPIzy5SnGBqrgZjSTJB8nJ8dCyAndvP731vl4goAJWW4H1a2YAEoNqOPGHs/Pcm17htEXTt5no4Wn+XBpwHs9emWQw+Ih3Rmanv+4xsu3U4aeek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772812170; c=relaxed/simple; bh=3cpgGyRLj6sul9nzYAxLQTLt55Ny7PN6onFZ9bvvoZo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q08ijNhxGeDAO5B8n6l8J0GXRjc2E0T1or/mfu9wQd0WZ43nRLaACTFw62n5/ASel19xR0EXh2zGGj3sUSe17DrrhdMrBoPd06eoN0w/sjGKu/3Smok8EYGn6r8mqan+6CYDZydvaAACvEKluk1XDtdOZNLkpJ2yC5rV0aAtV3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HRBrHklH; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRBrHklH" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-358d80f60ccso4669222a91.3 for ; Fri, 06 Mar 2026 07:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772812167; x=1773416967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+UmJ4tUBHK8D2f6KPBQS77aZz4Lp3+MUVhaUhscsX3o=; b=HRBrHklH99MBWdkWOh6xCeOg9yP+G+K4mujvFTXYKTPKa4wz+9BNVYRzEu8YRgi1mU g0YegNHBLN8eLpgTIqe+W7EBw/TKdkHwWUsjwot+9xBxDUJx2q7NfKhRsX7eCgMUj6vK lKuURxI5rqP2KkwWLXKq7IZ0pnS3CCt5AsM1QYC+BO7SOxaPuQ4M8QfTXGGZ3UdkBTWZ JO+JJwRq3eMDfQKfwO7le+4MZMT5tKyR+zDH2Pm/FLwKfVYXtJ6pi4nAZ0yGxW2Fl9vv cjsi9ni1jB2tUc6GLX8/UlY47bi7WQSxRgljwa37ROwPN/YX8Al/x/8evDHwmBETDasr vk1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772812167; x=1773416967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+UmJ4tUBHK8D2f6KPBQS77aZz4Lp3+MUVhaUhscsX3o=; b=eaB6fvJH38FRPWhCfVnPuzrBa7YGpZs0SHB+fUo46BH6IiGBBVP8jn5vEZ++q3fEBy NIFlUA48z6g1glpo53d0qWhtKBAHeHaMcdYuQOk8ZTOOrFL4/RzfbNNdeGFvz4npzV09 dbctuM5ecIbP8goo/+W5Clp+439daEY+KaT0PaW4D/NCQ1QNnmBjNxaV3x35Ro7KY+3u tVTZTBWx3ESLFMJXjz4PPPJ2yPkbvjUwZKzIn31XygWkcpu+a3lVctHAwzQcLMIpWTCX LVUi/gps6yt4HBtlJCc329/Of2YAJ4jiT8NI1E50VTv8KQFU77Zo7IsasP7JHx/19hLX ujgQ== X-Forwarded-Encrypted: i=1; AJvYcCULOVKRU89rmBVwHkOF2PtoyD+hOEnjf88hVtXmTk9DiNibZZvrHGXMQ0pBOAQ6kwtWsgQTw3Kc2oYzpyM=@vger.kernel.org X-Gm-Message-State: AOJu0YzXO3W4Red5WYTjkXwk9YH9BNPPjr9iN7eTFlPSQuXwLpkq1IT1 4ZI17G+xANyLPm3oAXUZ23QN9wQ/ZmKSkjnbzqcZhE6PDl2XRkNDayh4 X-Gm-Gg: ATEYQzwT0TorXjU+IbJrE38NqagP6IwoXTbuRd0A/oaFKBxv4654U82EEPJUxC3F5Py Jnn750TpNgSm5m2kIZ4mXIaPrE8pqQVobgWIvUOWD/OfDt0D8E6qzW9lz74jfEjBCv7DbmmvOSi sk3W/STrA4fdkIvcPdPcW9I1kDkmMB8h/rnNJZB16BR1RAEeZwHh9F3kDCofLLVHPlvQgDUHrAs 7mxRpf3zcgeCizIkierOV3Ew/qE1ntRirz53ab76EOKCACWLlRzeXrZoWN6Pv+f5XykEKxtthGT 1/Kl1ubsj0j/EIknK2z9K+U2Xh2XWd5JHnZrPj0Btx3ZEXY0A/2cIsZCDUlffW5h6G132+1gOeD w2ru7SYCrlK9oUIXqVG7HXM8D7Pbrq2Q47hEK/5uxibnSWMpITO6+b/ElWvtpeqPGnmY5futfJ0 G/YEl5w862hzqcRbpTqtNaNoy+CKFkarQpYua1ZsOqC2A4 X-Received: by 2002:a17:90b:2ccb:b0:355:35b0:8b83 with SMTP id 98e67ed59e1d1-359be38ffdemr2215431a91.33.1772812167105; Fri, 06 Mar 2026 07:49:27 -0800 (PST) Received: from d.home.yangfl.dn42 ([2603:c020:800b:d7ff::38]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359bbaa5fa1sm1532769a91.0.2026.03.06.07.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 07:49:26 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next v4 1/2] net: dsa: yt921x: Return early for failed MIB read Date: Fri, 6 Mar 2026 23:46:26 +0800 Message-ID: <20260306154637.3126497-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260306154637.3126497-1-mmyangfl@gmail.com> References: <20260306154637.3126497-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is a prerequisite for another patch, no behavior changes on the success path. Though rx_frames and tx_frames will no longer be computed using the partially-read MIB values if any read fails, we do not bother with nonexistent consistency. Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 98e8915dd6c2..a968a3fb56f8 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -711,6 +711,12 @@ static int yt921x_read_mib(struct yt921x_priv *priv, i= nt port) WRITE_ONCE(*valp, val); } =20 + if (res) { + dev_err(dev, "Failed to %s port %d: %i\n", "read stats for", + port, res); + return res; + } + pp->rx_frames =3D mib->rx_64byte + mib->rx_65_127byte + mib->rx_128_255byte + mib->rx_256_511byte + mib->rx_512_1023byte + mib->rx_1024_1518byte + @@ -720,10 +726,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, i= nt port) mib->tx_512_1023byte + mib->tx_1024_1518byte + mib->tx_jumbo; =20 - if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "read stats for", - port, res); - return res; + return 0; } =20 static void yt921x_poll_mib(struct work_struct *work) --=20 2.51.0