From nobody Thu Apr 9 18:40:09 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 241DF186E2E for ; Fri, 6 Mar 2026 14:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772808209; cv=none; b=aJLH4uLdKYDwyw0xcgHCz+WohUreubj026eTTUOtcSdbrNnnDG+PEhv+BlDZHKZtw113/bBbzgmTv3eQwz0mpUjyiodmqCuRUb65Iw+ym5ERR/+qodqmVAmA+AEDvpTTSMxAWNOmgp9a7EpBf7z9tpRn42E0wgcyivPUSSf3eeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772808209; c=relaxed/simple; bh=8tkDEwM2asPohBzdRdZz2Gu73uJ0yd4QUYX/86HGjpc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=JSO/4pS0qlWrRpodTKBqbwQNbQRxTiwSxvNhxGpRJ1xPiyEnyDVHLpz05RdYRxNXK67IlP2ik+8jHr+ziKM1ZfrKBCZwWa0AQBUWcvefmaK3jSF2lHBKWY5psMqJpQ6H38atcwKeFz2q2bSVzJC9m9YiHAZD/V4HkbhFg1UB8ME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SokgLTTU; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SokgLTTU" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48375f1defeso70270095e9.0 for ; Fri, 06 Mar 2026 06:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772808206; x=1773413006; darn=vger.kernel.org; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mnkBKbiAwsVbbilQBNTs5Gb2aWXP6aakLa1Sqz5ipyw=; b=SokgLTTUr2H751OQnXqWIiOqjxmZ+y26EbscThH/7RBjUtuy9z/er9Yyd5GTqaGwzz ZO9l77s+X/K9nuYWhP3G5ZNdY6AY9N/SKydHxnqeBCNJMgOFLAo3ZAd1ccAsJsJ3ZJ3J +pwP/L7+5ovHhH2LULzpvD+cRSD0EDMNViBsXv6Be8EllFyWnYsDPTrOriYLapTsVacb T7vIKDA4EYFIgZAm+CuJH6HAiUvSIsikXyqhkLUeuLk0J6o3LC93/gMLinjpiXmw2uuk kR0eYxvG0mgERN4/8VrSBhE4NM6ION1bQuk4GEzDKOU9Tm8THQS5Yn/+/k5k6TboxNg1 +uiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772808206; x=1773413006; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mnkBKbiAwsVbbilQBNTs5Gb2aWXP6aakLa1Sqz5ipyw=; b=JEwo1RAmKzL/92p2PMd25S2r68scsfHKMRHMr/5+m1N+hKP+1o74O0+b7W70TRnApB hmnY9C5hrhVfK+RYKX8EysScjVgBuAP4fCUsLZKNE9ej7PqVA9tCFXOebp4fRXvavop/ 49G+W/S90g4jty9h3aEZ1gUx7/R1KOmguu4wI+W5zMxB/nKIDhyCVXY5rZy1EPrxK7QU HQpafSQbWIfKgIWaOHeJvsMW2QM3x1IvPCAG24lj50pcr5rU/rDnnckVcf/CEIDkOFYT WODEXI6DES0oYMGArmgVq3bMCWpiUq6MF1dFh0FkUcRCaawlkvzajD+TJA2R7Gf9IlAT 0vQA== X-Forwarded-Encrypted: i=1; AJvYcCUgRFIF8Fmjw4GX1LG2xsa1z5dtzGjIHJlnuXDUwhjL+6SF9vQ6XB6jqd6o0MqVMW/FrhLagpjxjVIwe1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzPk5T21/oGNLp4t9RQ2hu4e46Lc3KlrOYdwZFXAcfxViNWcH4g DJJt/bJMkZ9ekTs30l9RQorw6oK77fV3SUKPcRgFeWDpEdZgBYZrT5suoAhoq/wilKE= X-Gm-Gg: ATEYQzzdZXqvcE2pVZyBp2swHGExZJX+RP3Ljp+VUNTn4P7AokV9T48W1a9kceVFbNh L0NzWkR2qfqAX4LFKUhrANTNf6FthL/fc6StMZkUMI4kBalZkgwcYSML0yt7Xs0PA5KAzLCO+B9 Fbudh8EJT6vcNtaKGqIOXoYuV8W6cKNzw+ZxiSdUrdAOyzqtPykKDyGwXkclAmLasQKsRQB7V0W s5L8pKUBmQIQgVk1Dbv0pX4yiOCcEIhGRtoJYhxal+XKOril8Sk+vu0zJ0b9cS8WeZThKew7h/X 3LUq63F9jQxGSDnA7kvOW2I1B92I7I4ZxUhFWN2rUQy+6OY1OWrZFszCVmlx97dL03X547ZP6dJ 7kdg3zfGr90hahjJTm74jyCDpfnxje7uezeaTmasSCs2IPAdzhx9nqGK2GWlBSPJJ5BYYI5KHkT x/AFk3r/F+mNjEzDcuiOrmtZVmhABe6vyM+5e1ensPsgTC/D8PpA== X-Received: by 2002:a05:600c:474f:b0:477:af8d:203a with SMTP id 5b1f17b1804b1-48526964c79mr39805115e9.27.1772808206465; Fri, 06 Mar 2026 06:43:26 -0800 (PST) Received: from r1chard (1-164-74-26.dynamic-ip.hinet.net. [1.164.74.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840ad894sm32276145ad.80.2026.03.06.06.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:43:25 -0800 (PST) Date: Fri, 6 Mar 2026 22:43:20 +0800 From: Richard Lyu To: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Lyu Subject: [PATCH v2] media: staging: ipu3: img-mmu: fix sign-to-unsigned conversion Message-ID: <20260306144307.670648-1-richard.lyu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.51.0 User-Agent: Mutt/2.2.13 (2024-03-09) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" imgu_mmu_unmap() returns size_t (unsigned), representing the number of bytes successfully unmapped. However, when the alignment check fails, it currently returns -EINVAL. On 64-bit systems, this negative error code is implicitly converted to a very large unsigned value (18446744073709551594). The same happens on 32-bit systems as well, although the resulting value is smaller. Return 0 when the alignment check fails to correctly indicate that no bytes were unmapped while resolving the following -Wsign-conversion warning: drivers/staging/media/ipu3/ipu3-mmu.c:393:24: warning: unsigned conversion from 'int' to 'size_t' {aka 'long unsigned int'} changes value from '-22' to '18446744073709551594' [-Wsign-conversion] 393 | return -EINVAL; All callers ignore the return value, so this change does not affect existing behavior. Fixes: 26f5689592e2 ("media: staging/intel-ipu3: mmu: Implement driver") Signed-off-by: Richard Lyu Reviewed-by: Dan Carpenter --- v2: - Added note that this affects 32-bit systems as well. - Clarified that all callers ignore the return value. - Added Fixes tag. - Link: https://lore.kernel.org/all/aarQeHfQuq20gXH0@stanley.mountain/ --- drivers/staging/media/ipu3/ipu3-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/media/= ipu3/ipu3-mmu.c index b196a5815903..fcea125e5935 100644 --- a/drivers/staging/media/ipu3/ipu3-mmu.c +++ b/drivers/staging/media/ipu3/ipu3-mmu.c @@ -390,7 +390,7 @@ size_t imgu_mmu_unmap(struct imgu_mmu_info *info, unsig= ned long iova, if (!IS_ALIGNED(iova | size, IPU3_PAGE_SIZE)) { dev_err(mmu->dev, "unaligned: iova 0x%lx size 0x%zx\n", iova, size); - return -EINVAL; + return 0; } =20 dev_dbg(mmu->dev, "unmap this: iova 0x%lx size 0x%zx\n", iova, size); --=20 2.51.0