From nobody Thu Apr 9 18:55:17 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2F113AE18B for ; Fri, 6 Mar 2026 14:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772805823; cv=none; b=AHbv8yeuKT5ohptDBEQZ2AuFPh+5mDeVMJIDXFcXesCi41OCXXa1xnkV2jcmOhN4l5s85rJEPK+EF72f8dwkknwjsouxHiKzLpAWx6O4v8QMq0i0QKGpt5ndWpPlVtGEQLQe/E/puZTYC4Hx1VoGx4fTwoQ+lK8Te0ww5DjUHBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772805823; c=relaxed/simple; bh=ELlzxJVqqauBzRnx2M/V3kWxTpAmlO4Sa9vwg7vpvVA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rwGMMBCFbs7p1O/o15mKF/xKoldH5LQ6H6kGXh8r4DC5J9oyqc7cr0uFJPJzGddTMPQwZrJ83v/Maxk3yQKBCrmKBlkcnZnhkzjBWyayiXIw5mivCzreVZHzUiexALRVGvezE6GQILXTt2QEvvd0goG+aQmSXQmKA/JjXw/JibQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iJ3ZT/i9; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iJ3ZT/i9" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ae88e16485so778505ad.0 for ; Fri, 06 Mar 2026 06:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772805821; x=1773410621; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lEmGv2FLRFuslu4qBQwLsjeV3m7Edv0VCgYCAY8R+hU=; b=iJ3ZT/i9pT5F+PL/lUqgCmJRyC7ErME0o8I+Ll/35cu1pjYYAe9qKaZNTUA2yGqoNe mjsGXB3YdGYRHwlgUIvrNxe2bbUY+Lm59Ft1j3uN7WuntEyCOsDGKaob4mvFFAd+5uZ4 1cJhqhWr8vIjASvLOcLyZT8/DOjiT3vc4SUHsAnsGQ49Da7bQI8yHG+Oe1EmSfsBYtI7 zKLX+rAbRJ7LvSrQWcsIYqAab48bYf7355ZK8R/DjUthaci+TYhqAu2NT7seRVJdc/yD 5wceVOlymYEnoiINxwH9sL6wcB/fpIl7B2oeHZSh0iROCPqlGX2MvZNr33AMoY7733Z1 bGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772805821; x=1773410621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lEmGv2FLRFuslu4qBQwLsjeV3m7Edv0VCgYCAY8R+hU=; b=T6+LeTunb1qJ2tu1b91nNaqHyaGJTpjdo6tsy1oSgXFdyc8B5ZhPYf/96F9UX7CHXk cUFad4h+9mdtLDrqmu7i11Gzwa+TYuo7cjXoMRBkzZti2iz48zpLOtq96u8KPNCQBmyk nEQqGVYcVqN7tJrajCOo9BpUe2GLwWC4mKNT8vj1aEOJc2lQ1CMmqJexwD1JP0ukjJAk d2m4hXHM1yo5y10jvRFFl558sXzhJoS3G+9RvTHfucsI95Q8+UC3M1BDa/8G3u3ag7ow P6ozB1pOIZoOFHvl3N7VNq05Psy4ArvDnAo0aJSUVojnzSEVTtPd8XHTM9msXzA/Dmi1 0pQA== X-Forwarded-Encrypted: i=1; AJvYcCVHnEpUHemfRie+YZfWctUp7Hsowh3mHKwgtdE0t90WvY9zm5XwstfxWJ+CdcseSd608ePGsIecrJfV1zg=@vger.kernel.org X-Gm-Message-State: AOJu0YyJFsG7gl3QudC6AR6oST9b5WgGkflUAjVNThtY9+ykjY9gCs0Y dQeMXNgrn29czDw0qHZ92Xdi/iV14Ec9fLdT6pMM8fWGYoBc5kySSlOo X-Gm-Gg: ATEYQzzRP/lLTWJ9Lr2lNwBcF4S2soYqUBjZ1c9bWW0xqVJpQwTFzrprig+p9KzRPlB P+Vuer0dGxzfajl7maqSTkWPfe8MBHJO21DgzVLeJLMoZP9vZhheLA+YQHmqSv464T/2JejEVCF 51mh1kRkrrJyslkDz50qTHarP+QS/74FMiDGVNQsNPQHOYbcXBkdqiE6SwF01plfNu05I+GYJvF 0sHWKUCqIs1Qli/yilQ/+PlpTG+3AZ4cF+7cK+C78hgyWEYatizhYzHTbLftbvOhCAI8sDWcSz4 rJLxA9rGkaDxL7Ru3Y821Cmd+Lxdg7M9PRxuXSswkvkh9590afo5AozaSQLgKdenZ48O63Zoyc9 Un80J0pOisRoEYAVGMUjlNyAzPxCzBm4fd6cpjwWXHZTAhGNhKVr5+T6QffawehcOmtpH7fEuec BzTxsMwjMasXnK02xVf3UVnxGFgLBf+tcWeVuA158s5l5+0PXwPL8T0V5XZcPaRuGe9JGI7bIjA SCwIJglz8LnZA== X-Received: by 2002:a17:902:c94a:b0:2ae:41d1:344b with SMTP id d9443c01a7336-2ae82418016mr27067745ad.6.1772805821034; Fri, 06 Mar 2026 06:03:41 -0800 (PST) Received: from mi-HP-ProDesk-680-G6-PCI-Microtower-PC.mioffice.cn ([43.224.245.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840ccb6csm29134715ad.92.2026.03.06.06.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:03:40 -0800 (PST) From: zhidao su X-Google-Original-From: zhidao su To: tj@kernel.org, sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org Cc: void@manifault.com, arighi@nvidia.com, changwoo@igalia.com, linux-kselftest@vger.kernel.org, Su Zhidao Subject: [PATCH 3/5] sched_ext: Use rcu_dereference_bh() in scx_bypass_lb_timerfn() Date: Fri, 6 Mar 2026 22:03:23 +0800 Message-ID: <20260306140325.2710927-4-suzhidao@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306140325.2710927-1-suzhidao@xiaomi.com> References: <20260306140325.2710927-1-suzhidao@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Su Zhidao scx_bypass_lb_timerfn() runs in softirq (BH) context, so rcu_dereference_bh() is the correct RCU accessor. The previous rcu_dereference_all() suppresses all sparse warnings and masks potential RCU context issues. Add a comment noting this is a transitional state: when multi-scheduler support lands, the bypass LB timer will become per-scheduler and the global scx_root reference will be removed. Signed-off-by: Su Zhidao --- kernel/sched/ext.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 053d99c58802..c269e489902c 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -4170,7 +4170,13 @@ static void scx_bypass_lb_timerfn(struct timer_list = *timer) int node; u32 intv_us; =20 - sch =3D rcu_dereference_all(scx_root); + /* + * scx_bypass_lb_timer is a global timer that fires in softirq + * context while bypass mode is active. Use rcu_dereference_bh() + * matching the BH context. When multi-scheduler support lands, + * this timer will become per-scheduler instance. + */ + sch =3D rcu_dereference_bh(scx_root); if (unlikely(!sch) || !READ_ONCE(scx_bypass_depth)) return; =20 --=20 2.43.0