From nobody Thu Apr 9 18:46:43 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CC6030EF9A for ; Fri, 6 Mar 2026 13:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772804556; cv=none; b=BiPau0veQ+vE1ddTWwp5sq2RIkwiwCMC5svHo1MbNS/lfsoV3rhqwx9Unqtr3k5d3cbEHIAorvaEM07GA6RJdlS5RjTZh7AcfZBlZpglcAR9/rYCavOjDXbYrR/Zxg2S/ZlPOhu8RuECucMHcQRrCeieSI/JYKa42exKtKTO5ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772804556; c=relaxed/simple; bh=oDDmA+qtseMoqwvqvrsoGzJksVvbHRORAHe+YeEPpbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iDrXav0HCeKHRTkgOA2+2yc14H23r0zxixF4I1OC3NJ2kvd0mpGsrPijL4y7oZ7tAj7EisPCe4omCdapvBKjZ5d4krLjbyeQbs3lfHgeL//CLhvl47plgocVwanK5XPtMLef4BvlDR1NG+zoou1b1EnEZic3ivFSYn3lBO16E64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YRp7ZHT+; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YRp7ZHT+" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so106397095e9.1 for ; Fri, 06 Mar 2026 05:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772804553; x=1773409353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w7HfjRvaTulj2GfsP2nDOzeVXSEKKzPOa36MxET5CCs=; b=YRp7ZHT+ekkk+WHpMEKikB2NB8guV38oViVAjZ4xZd9kSCUPMgRxi1APcgzDcf2YbU m45NUs0A9FH/oJ6OOw8n+AwGTPYEWCiuqfwHJZdHrYkVH4E73hZT2BGvwM3f8FaNCqlA WMgpTVz7BwtWheaeIPE09+MGg3F1Jy4ncihqVQFCea0zNc7IuyCv/u769DauWG1eEVyx omRSeq9JPfzDvkuuWDyIST2P2hdjRcOzBB3TK6/272Ost5cJ6O9mpYxwk1mcWWoD5f4Q c5iGgiI2OC4DoA+mT6Urta/F/+PjvNmgKv5BnK/fsh+cqPAcefpwlSaQDrqJUmyPUjcV 191Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772804553; x=1773409353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w7HfjRvaTulj2GfsP2nDOzeVXSEKKzPOa36MxET5CCs=; b=qQiO6UPOISsTZoc0oWfSK4Vtpl2gZoq1eRVDPxjpHkO8IEGPWvW96qmlRdnz+rQfp8 fr2FnXM/xypjTeKKsnEfe7UGbucC4mqcK8pcl0yhkTUYOcbty+XEL0EJSCMtjz6LMcbe IqmUqRDc3ffZ++ZXZHvFsjqhbUWQkbKmpzm+wHQtXTjk2f48P2PE3BjoW0ZFv9uJl7YL 10w8B/WQu+JhBax3qXkYbAC7rbchLj+DfEqckg5KsXh5yPkKetHjx6Z7iQqItEKQkUEM j3ytLHB+sjXqeeZ+zD8fylNav9cE7ZTa25iqWJykPBUIZ0FZ+ojNr/27bUYvS8A5Ick0 mWXg== X-Forwarded-Encrypted: i=1; AJvYcCWJ6qWXiQHSsnXczujV8s5WPZOITw+/W1asjDlul/0zDgdY6/iEaoZPLFuYAr+hjaHSZLqTs7qYlMetw0c=@vger.kernel.org X-Gm-Message-State: AOJu0YxfJkp8rIp4jlxsWqr4lBGwCAXfjB2zdQIS8SVhmLRxcA3n4xJG jLNaosUzd2TYtVcSTUfMTjKyEAB2vRebWA3e9T9PpMUBV1CQkW+mMHPP X-Gm-Gg: ATEYQzyrnFg7yhv3i5Egz/Z1WL1MZjXT/4xdwWKW1+TygCh0Va8e3V4+jUvg3eoYEhu m2+uk5hFltPf0WWJuZSBSYrhx+ABXuoD2hoHZgInLDYfrxjOjUZEZBOQ/qs7Ng88bhr783SGhkS XQmvcU5A+DpyN64g+ccaMOAP3uIUWyZ9QG7dJQcP2e9UZwYbHA4fLfC579+5Ya4l0xkKA0kH4jJ xICSXFwgIz+ySiThFSd0vCreC19CllFlAc85G7u/r27ZJGJsR0G/p/p6TKpbACiT6fI/uAqlVAd e/Y+QbImJWzzKWXL0bdTy2/6Xck8UdWSe61J8c6XHN7GE234/lzAT83h1sEQfLbkyowPKrBsujO ZqmWXHSN0Td/klccOHBk9VeCar+PNi+tlZFsdUJKA2Z0Kq3XzfsHx54crRpL8CklZiNnrR9//bk 2F8p+dJipnZ4cVR2yE+gQBC79sXzifIoR1Zz7miAqf2DaA2c8= X-Received: by 2002:a05:600c:19cb:b0:480:6c75:ddce with SMTP id 5b1f17b1804b1-485269791a9mr31478995e9.33.1772804552665; Fri, 06 Mar 2026 05:42:32 -0800 (PST) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:d0f3:534:36a3:523a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dadb85b8sm4223790f8f.17.2026.03.06.05.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 05:42:31 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH 1/3] clk: renesas: rzg2l-cpg: Add support for critical resets Date: Fri, 6 Mar 2026 13:42:23 +0000 Message-ID: <20260306134228.871815-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306134228.871815-1-biju.das.jz@bp.renesas.com> References: <20260306134228.871815-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Some reset lines must remain deasserted at all times after boot, as asserting them would disable critical system functionality with no owning driver to restore them. This mirrors the existing crit_mod_clks mechanism which protects critical module clocks from being disabled. On RZ/G2L family SoCs, DMA reset to be deasseted for routing some peripheral interrupts to CPU. Add crit_resets and num_crit_resets fields to struct rzg2l_cpg_info to allow SoC-specific data tables to declare reset IDs that must never be asserted. Introduce rzg2l_cpg_deassert_crit_resets() to iterate over all critical resets and deassert them. Call it both at probe time and during resume to ensure critical peripherals are held out of reset after power-on and suspend/resume cycles. Signed-off-by: Biju Das --- drivers/clk/renesas/rzg2l-cpg.c | 33 +++++++++++++++++++++++++++++++++ drivers/clk/renesas/rzg2l-cpg.h | 7 +++++++ 2 files changed, 40 insertions(+) diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cp= g.c index c0584bab58a3..8165c163143a 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1765,6 +1765,15 @@ static int __rzg2l_cpg_assert(struct reset_controlle= r_dev *rcdev, dev_dbg(rcdev->dev, "%s id:%ld offset:0x%x\n", assert ? "assert" : "deassert", id, CLK_RST_R(reg)); =20 + if (assert) { + unsigned int i; + + for (i =3D 0; i < priv->info->num_crit_resets; i++) { + if (id =3D=3D priv->info->crit_resets[i]) + return 0; + } + } + if (!assert) value |=3D mask; writel(value, priv->base + CLK_RST_R(reg)); @@ -1802,6 +1811,21 @@ static int rzg2l_cpg_deassert(struct reset_controlle= r_dev *rcdev, return __rzg2l_cpg_assert(rcdev, id, false); } =20 +static int rzg2l_cpg_deassert_crit_resets(struct reset_controller_dev *rcd= ev, + const struct rzg2l_cpg_info *info) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < info->num_crit_resets; i++) { + ret =3D rzg2l_cpg_deassert(rcdev, info->crit_resets[i]); + if (ret) + return ret; + } + + return 0; +} + static int rzg2l_cpg_reset(struct reset_controller_dev *rcdev, unsigned long id) { @@ -2051,6 +2075,10 @@ static int __init rzg2l_cpg_probe(struct platform_de= vice *pdev) if (error) return error; =20 + error =3D rzg2l_cpg_deassert_crit_resets(&priv->rcdev, info); + if (error) + return error; + debugfs_create_file("mstop", 0444, NULL, priv, &rzg2l_mod_clock_mstop_fop= s); return 0; } @@ -2058,6 +2086,11 @@ static int __init rzg2l_cpg_probe(struct platform_de= vice *pdev) static int rzg2l_cpg_resume(struct device *dev) { struct rzg2l_cpg_priv *priv =3D dev_get_drvdata(dev); + int ret; + + ret =3D rzg2l_cpg_deassert_crit_resets(&priv->rcdev, priv->info); + if (ret) + return ret; =20 rzg2l_mod_clock_init_mstop(priv); =20 diff --git a/drivers/clk/renesas/rzg2l-cpg.h b/drivers/clk/renesas/rzg2l-cp= g.h index 55e815be16c8..af0a003d93f7 100644 --- a/drivers/clk/renesas/rzg2l-cpg.h +++ b/drivers/clk/renesas/rzg2l-cpg.h @@ -276,6 +276,9 @@ struct rzg2l_reset { * @crit_mod_clks: Array with Module Clock IDs of critical clocks that * should not be disabled without a knowledgeable driver * @num_crit_mod_clks: Number of entries in crit_mod_clks[] + * @crit_resets: Array with Reset IDs of critical resets that should not be + * asserted without a knowledgeable driver + * @num_crit_resets: Number of entries in crit_resets[] * @has_clk_mon_regs: Flag indicating whether the SoC has CLK_MON registers */ struct rzg2l_cpg_info { @@ -302,6 +305,10 @@ struct rzg2l_cpg_info { const unsigned int *crit_mod_clks; unsigned int num_crit_mod_clks; =20 + /* Critical Resets that should not be asserted */ + const unsigned int *crit_resets; + unsigned int num_crit_resets; + bool has_clk_mon_regs; }; =20 --=20 2.43.0