From nobody Thu Apr 9 19:00:49 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B328C303A12 for ; Fri, 6 Mar 2026 12:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800906; cv=none; b=k6qKnjBlpSDIhjWLprY+ZlZhtft4gJPqjefeW3QknckNH77Oxg1jhkPQ6xJQVxY4Y1WsZxTvuxtuVHYnRekuUe/aQXeQrZdUDehvKYOOvx593OD6xEHseQgdBm5q2kj5/EgaMPV1fa/D3vrwC53OloLwERi7xfLWl81VJ86LaMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800906; c=relaxed/simple; bh=zMC8Z35n6hZqb+F6CM9QqlHZLYZ6S/y6G2PDsOYtUHQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W4qOB2DBqjObftypGoeQSQSASypp18FiWhq/0vIj4o3Y9KkgpbtzmDPwmWEGWBMqgCuA8Vg2KfbbTXAiQu2CfJ9xbF1tPUJI8kha+V5oNGNoOIYE0/62OekDKBhNNzRmhwQP1ypqrD4SYUOhAJnQfE5EbaVzPoaTC84tTggs5mU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=M3mgMlM/; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="M3mgMlM/" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4806bf39419so74921105e9.1 for ; Fri, 06 Mar 2026 04:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1772800903; x=1773405703; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=djodlEhOqxbj01WP7bf1DpXdR4vQl3fw8jTNz3jaE3g=; b=M3mgMlM/Jp9a1z+gVPXJ8IxZJTHvybbgRL82752E/YwqRZURITyQ03y/rabHbm2oJ4 uqoEy7n0+j9LCA8bScZjRh66p3VesD8l9aFIqHONkdMNZq+we4WTshbNrMTswdHeiwu+ QPUtmZCbAdCOviBgoCpd7kveutPlrJuKczR9hhZ/FQQ0nKFkgqCeHKix2iKLv28A0G+8 lh60WnEJN1y6Pp8dhzABTgl75MUtgl7Kem7uu+cY/j0nvEjPoE54WC1kfzDmFnukq/Zm 0HkPVPDmyvJfP8Yy/ECqK2B4+Ia1hDPyjVE4G0ACcE25kSWwnXavZLkn/Dox1NHgl5vM CQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772800903; x=1773405703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=djodlEhOqxbj01WP7bf1DpXdR4vQl3fw8jTNz3jaE3g=; b=bYEGZde7UmA/lVqy2aoeYOEWskwS4OXWarNsZ9/TrPiGNLovRJxpEA6svOuyj2WxaV JOl6PbQBbNfNqpch5ED/C/SCF5jkg0k1j0jUc5VtBji6u2A6NvMmrlzCNQKL8ImBvaAF mgrEWfbRqajMQu/cMTsTSUxTR396l6xrAVHOblJwp18eYmj4pk0Jg/eJ4sxEvil1OThS NsRg41nmgSSZQ1UOD353tm4gGTS5F2+4K92bLytkm4Q8dlOb6pia67DrRhOn3/4oRxVs jpZeiwxFhCSThAcyq8y9a7n47gvZw6vNLVpS2H2qEzH/LWE6JJQ4vW/eLIlGW4t7HyrG 7dLg== X-Forwarded-Encrypted: i=1; AJvYcCVFvU7jf6gaWN8JvnWSHkyvB+vkaydcZrERyIpaEx/msdylPIDJECnmqvXokDd67CbX1IdeoM/5XkBpg/E=@vger.kernel.org X-Gm-Message-State: AOJu0YzMUrWP1fcFqgoMpt4RPmjVOOsJNxZHkL4zfIJ+WbQwP2vDTy95 cd9sy3iXpKPqct35qZDh9FhxZlgBEjTLjKqdhPutWkwC02dX73epQMEKEIN0P57NvCs= X-Gm-Gg: ATEYQzwxCpOvFbECbkd1lQJfIRfZwcWiQaciqy5PzGTZiABwmQJ1x5cqc330SanvTPE ALVbeFOR40E2FoqGzGj6e1o4vJYgH2Q8CPIMZdqXZFw6v7ZNqKPUcc/TSUirwjeboHWe3mHYhIY UFVhV6OzqZOgTqRv4FO37ks9U/3sgRcA5MZRMP7M6pGF3MO2jWOgmaogAj9wXMHOdx9SgG1zW1z AQNxCoT6icV4qWRW831F4HM2GlAQOR00WdPs9yB2OF491Tt1+SkRf2THK4z+O2N63xg5rYdP5wU fSAWyP2eNSvyhZ8IXYCZgLY+5Ma/OYSw8E8sYfh5zPQ3uAg4kC2WR7Dp1JypPpbbBz81Y6gRaYq aTXSwj94gjf6djBHRllqx6N+LdNap+abKk9c7RbBOgFqQ4hBIOZlzZXM6tKojBfFztCX7JMToRk Nr/NtgdlBn2IE10Zctn682Wdansxfw63uSGG8bRuqgyzaGNKqhPWqB8JxvDmysVS0= X-Received: by 2002:a05:600c:8b2b:b0:477:9890:9ab8 with SMTP id 5b1f17b1804b1-48526715213mr28640755e9.3.1772800903039; Fri, 06 Mar 2026 04:41:43 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485276b0c38sm38150505e9.9.2026.03.06.04.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 04:41:42 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, Frank.Li@kernel.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, fabrizio.castro.jz@renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , Frank Li Subject: [PATCH v9 5/8] dmaengine: sh: rz-dmac: Drop unnecessary local_irq_save() call Date: Fri, 6 Mar 2026 14:41:30 +0200 Message-ID: <20260306124133.2304687-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306124133.2304687-1-claudiu.beznea.uj@bp.renesas.com> References: <20260306124133.2304687-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea rz_dmac_enable_hw() calls local_irq_save()/local_irq_restore(), but this is not needed because the callers of rz_dmac_enable_hw() already protect the critical section using spin_lock_irqsave()/spin_lock_irqrestore(). Remove the local_irq_save()/local_irq_restore() calls. Reviewed-by: Frank Li Signed-off-by: Claudiu Beznea --- Changes in v9: - collected tags Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 4bb446c1cd67..9c159c53e3ee 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -266,15 +266,12 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *ch= annel) { struct dma_chan *chan =3D &channel->vc.chan; struct rz_dmac *dmac =3D to_rz_dmac(chan->device); - unsigned long flags; u32 nxla; u32 chctrl; u32 chstat; =20 dev_dbg(dmac->dev, "%s channel %d\n", __func__, channel->index); =20 - local_irq_save(flags); - rz_dmac_lmdesc_recycle(channel); =20 nxla =3D channel->lmdesc.base_dma + @@ -289,8 +286,6 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *chan= nel) rz_dmac_ch_writel(channel, CHCTRL_SWRST, CHCTRL, 1); rz_dmac_ch_writel(channel, chctrl, CHCTRL, 1); } - - local_irq_restore(flags); } =20 static void rz_dmac_disable_hw(struct rz_dmac_chan *channel) --=20 2.43.0