From nobody Thu Apr 9 17:15:55 2026 Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazon11021110.outbound.protection.outlook.com [40.107.57.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BB9E2236FA; Fri, 6 Mar 2026 12:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.57.110 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800448; cv=fail; b=godnRj0g7Ca5FLs0OO14qk4ozIk7xG+Y3zHaYavl8S/3Z0MI9JELXr5XrHW8Pg6iB9yjCpoqV2pSiBamsNNRY00Twj7JlRSOyIJTiBZScGYyl7InQMhE+qj4Bdiwg8/bgmT6VDF1gb38mIoewjVD2e43w6lCYsX4YcEGD/aT+fQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800448; c=relaxed/simple; bh=j487d20LzsiCx/dx1n6YsS+JuGGlgtgMjxJCngDXOYI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jpJ7RcSP5TFre2vyegyAt1MZ1yaQEj0aYdR18jh4ZoMaCFBQLhbsG7U17uBDyWZEfbFvXLIbevntM4Og5Pen+y0YAQYAC4d1XdYqPWokpIM3NNcTTIzf3zX+/vnMmY98z+vHnTq3Ut2b9skTTazos6E2JK5bWQ61+JFe7lmDK5Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=WXWL9oFr; arc=fail smtp.client-ip=40.107.57.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="WXWL9oFr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bNhe/rbDas5TtEP4Nm4v4kdVArE55yUoJOyJbaWJa50AN40eKDzSDvis5I0T1jeXXuXMBftTSvNGFIkoxPacfzKyNeAdy1kvXuQAP9rBCvBRNdr3CaHlKmCzrGZwY/9NqGzwPD86pK9e3taKQD8wm6MetLej1BxOxWvWDTS2NI+PhLdATTM+bxygGtUdZIJuYxqzU4WfYsYeYH+HOzcruMMUmW29KGHxn6ib/d7F3iRlzIvSWLpKzTKygkl7Tt3OaIrLShavfxNGw/ys7HB8QGWl4p/VFC2UxOVMZd+SSdFjkYKQqL3oxlfE4Pz/cNat9Vn9Dft7gQ4ckdUtjuz47Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZfT1FTWH07/GhM1HnVYZesFAMZixZd7vBbWVj2SjaJ4=; b=deSJsY4/QL1KC+7aTWMEtTL56E8HpSAkqnIGDk3bggkdLbYTXubuIEro2BgPorKWZrmCYSXEVVTbSQB0+EpwYCWBQJZUdkKZlY0V6MUt1HKLFusayLWNKpxR+XQRBHqkCUWAQ/fN/FJkIzSEGdUq28tY++Z9FkC1Q5fOdYwjpJMZ6+TqN5CMv83C2kxThbtjz47e9kqKNTojlR9z8/hb931OeKrvALl3MNtWSsI0COqAQOlfgOoPJy39NcLJIe1ncgiZwOobbh+ydE9C4thNUlkMDBLLFoYefuqDqfQO1YHAMwYv5JD8b6zfzvGskTzfFPVudKiOKsXAyTjSJUxIUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZfT1FTWH07/GhM1HnVYZesFAMZixZd7vBbWVj2SjaJ4=; b=WXWL9oFrxHJXdX5gUF7W57ujiy+LXNaLKumfhVuzIH5vT3BzvX3Zcb4IpV49dNAXk+kxP40JOqeArpWoH7DGAQT6qoraCqziOBqQV6EMT+50wWHrUpi8KZvOiNNlbFtAa624gBvH91550mzZkv9G0GMw6ERxVKeurhLxxOEy5rbQoptqGqo1oncwEpTSu6fIf1sS6TevYvw2tzbBPkY2UYuMiV8ZPHKxysLuCtNMX6LLxZzGZ+4JHhg8KCZ6wxw1xs1q1M+qZxA6/q29jjgZj2tq8SrVsBpsnHnJEs2qg22iNkkqNdvQSoUPOfX1EHXE+PaoK28iGE3lHPY1SyuHZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB4150.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:28f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:06 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:06 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/13] media: i2c: os05b10: drop unused group-hold programming Date: Fri, 6 Mar 2026 18:02:51 +0530 Message-Id: <20260306123304.76722-2-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB4150:EE_ X-MS-Office365-Filtering-Correlation-Id: 49914508-e6bd-4f3c-80a8-08de7b7ca7fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: 9fqeJ31nS4iNBNASVFhIleUqJGAcJV+Olx+gv51Y92Vj1lL8kGxoWS/fZdlCr162qMkyRhKiKpue25NSII+/rAVq5jcYg9arqNzm1LJm7yrarZctxQUnW1ncue4vehHJyx0mzumyKInsl67J0cL12GEuC/awCbsdTF0uwYzh5fmE2H4DhEX/+j4fN4Lm/B5xN2wsAXXiy2gjUc4mRrIGc/eRlRA8Or7XSo+uFieR9//qU9Z9gXoFcWwIqhmHi/ShPHazg98jVv0Jm9ZDvTI0/s8UnJ/4pxCcJ6dV4pXElnvPzGkxUsad65uqP8EJFpgfItslhqdyqDyCWxHaDVaonTI5altL4upakcN/FwR+u9ksytR3NT8dWCtbrftZz3shz2bJltRFfC3v/PFPMXQUfprwdFVRr0VKJeu7cP77U7zkygTxV2eKHjeVSt1S9j2104B6jnT1u3FJ/Uvq2XEYTDIqIBQD64Uex+S5r7wUZe8ufvdg31LQLdgV42FagQhXCv8xn/2FUGh38IJsUeqX3Hfr9yj1cyqiTMUMR6KlAtZ6tCCn3R4KoIabZSvd089cBI85u5PuOOatiHE4dGIZt6F2dPg6RR01BDcT1sbH6DpkcYAG368DJZpd7kOo3daM9eu+JDYHpJ6XmQYp3MF8XKtYD93wvLDseO/UevMfozaCBQKkADG3U2TTaT6YanQ/G/xBeeAtr80Jvdxr424qbVVhcDjtW+V9n1bv+DoOzji+bOFRRttFjgieFVCKkObgZAhV6UgiyxXvByHIBDiy3R2tllwcoUEjoqvrWwlvI8s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QB2Jwwggw8Gsd45fixiRPYnLBeDXrL7aCsbfrbp0Uf8KeiuqKU5D4HN4J0sI?= =?us-ascii?Q?gVhRxp+qMluOiTDNg0z8veN8sSxcFqL5Acd9YsNa97uxGFKIY6B+8qN5FZqr?= =?us-ascii?Q?OnPjAPOsqLuY+mabp2EOy9y1OYDtOQS47e2IFDPBBOPu/KzsAZa0b1kCD523?= =?us-ascii?Q?8d0p4n9Avu0ZHADhWUenTjetUW8PxOJJdFr8xwr3MFl9OX6xM6Zk4W7O1J42?= =?us-ascii?Q?CMu2eKwjDaYEOgbTqNvhOlqr1cWNK7fjpfJ0D14ZXOGzKhG+J5ct2SPGBhwR?= =?us-ascii?Q?Gf+Cfhh+0D+JbFMOzgfW80AWIg6pyG0zM+9N3hYWee+37lFlkyaam7zL5jDh?= =?us-ascii?Q?sl2IFozefdCjoHfUXvBEd2r3DMALW8FatXoIROLvL8hknaJpGDwLhzS6fIoC?= =?us-ascii?Q?QEnsN4mEo1A9IZjCxbuJQJ+ntnegHia4B1VZN05TRNOLJMbMB0RvBzdJjriH?= =?us-ascii?Q?rZRzh6xF4n7t89f+klbUJCiyneSDWn/rDwNI9LEAhGEFJoZTC/VNTIRP0Hhm?= =?us-ascii?Q?Pz864kCNkt/vl5X1jZkr98/HYJBW6nTzWVd9PGmv3QS1o0qgC42OKtvZc/Bl?= =?us-ascii?Q?2XESVHGQ5bK/T3r2nreToCM6Tgln+psIgv/j3A2PHsomUmYykZu2qWUqj2y+?= =?us-ascii?Q?3E51ngUwk4SzJoalEPqnNzl4yTMIDOWc01xcliqcsC3n9ou50ajjtNB1fK+n?= =?us-ascii?Q?wHTYmih1joj3+RrvAQJxSWBAwqgvtz1dW8EjivGZH9PQ36YowOBiusScsucS?= =?us-ascii?Q?ISewT2G38EK0RgZ6bcNHV6sHhW6zHceG3kHpcoa4a7nRdpvR5E5Q9PZ5qnuE?= =?us-ascii?Q?p51mwy4/kVwV6ZWIoWOOjXlTypKhr1uxrlU/LQgn3BMqjewmaIetXoWEevZq?= =?us-ascii?Q?nu3+WJ0RuU5C0kKehQ6Ci+XSHxZCMZIP+twHus0fDqhwgbHP9N0mOWERF3HI?= =?us-ascii?Q?h/3VnKTEdeMAmuzIs42c4PMa74P4wpJA/bQSgN9qehemQKvJXTD2Q4ySbCWi?= =?us-ascii?Q?BWb6vBq6axS3ZG9WhCFvma2UBe4FoipEWI3SDuf00lwrEHaCfTsCXHiami6h?= =?us-ascii?Q?D824oDTaGYJJQ/Jw0DLXSlg4Ct/0M0lu/0A5BbtF6niL35Szxgihdg375q3s?= =?us-ascii?Q?RPVebfPDYcEHI5BPD6CV1TejrFfAs+9ZXcw1van5fdXnyKXWe/dJAt1Tutxv?= =?us-ascii?Q?9uMdumaJcqsjbjGcnnLBO4GjxOi2whHsOsWsxjTfOLCRPLKm/U9+M9zxE+Eh?= =?us-ascii?Q?eL5vrxzfpUawoCmXzSSqF2aqpzx16uZU3EB458ENB648VquxArW/l/KoVNJw?= =?us-ascii?Q?Mq/7AddPxW1egcJT4rLVwdry2kenDJGF45CQtMP6I1sjD7dt6Tl0aFJDEKqo?= =?us-ascii?Q?RDfTqvgn1Nyn8AYAsvHUTzSQ20BoTERVWxMTLVEFpC40Ks8fkEuoaYoECDq+?= =?us-ascii?Q?1OVhq9/Suhuqirk1KhzKOmC0qMQAhiNFm3z0sPPYHau5JHmTkK++5ncklvp3?= =?us-ascii?Q?mlzssS29dscaXIa7xSJRLq8lKMD/Rgf3ZY2FdiEQ65E4J8J5NRZtGZtTfmh6?= =?us-ascii?Q?AV2CMQC+z6RkLJLCoqoXwirIkW01PMzstv5DbKtVX17J3UVln0YRNFGWMImj?= =?us-ascii?Q?YNKg7AQvjYBTdVA8oeNPykyp6lqdiuZMtGBD4hMdIQSVhDCAhDafPxdx1jgy?= =?us-ascii?Q?AG3ka7kriU4z3eMJwYzeoGGa9uD/5Y69a3nIEhTLdnQSMZnXLvp2UhKWc4zt?= =?us-ascii?Q?IL4WTLloEtsbNYigT+PSvJXU2XkbUAU=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 49914508-e6bd-4f3c-80a8-08de7b7ca7fb X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:05.9526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l4/iakg5RB++GCAYaz40tlX+CRePkunPb2pG6rC0pOtl7UbHNtgzahq7ceK2io9WCuP3o33XoufOZHFVQvICUCu8PE7kVyDCCSZEcDUVzLE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB4150 Content-Type: text/plain; charset="utf-8" Register table included group-hold (0x3208) sequences for groups 6/7/8/9 that only stage alternative tuning values in SRAM but are never launched by the driver. Remove these group-hold blocks. Also remove a duplicate register entry for 0x37bf. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index e0453c988e4a..7f32e3b1e7bd 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -250,7 +250,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x37ab), 0x0e }, { CCI_REG8(0x37ac), 0xa0 }, { CCI_REG8(0x37be), 0x0a }, - { CCI_REG8(0x37bf), 0x05 }, { CCI_REG8(0x37bb), 0x02 }, { CCI_REG8(0x37bf), 0x05 }, { CCI_REG8(0x37c2), 0x04 }, @@ -415,42 +414,6 @@ static const struct cci_reg_sequence os05b10_common_re= gs[] =3D { { CCI_REG8(0x5820), 0x00 }, { CCI_REG8(0x5821), 0x00 }, { CCI_REG8(0x3222), 0x03 }, - { CCI_REG8(0x3208), 0x06 }, - { CCI_REG8(0x3701), 0x1d }, - { CCI_REG8(0x37ab), 0x01 }, - { CCI_REG8(0x3790), 0x21 }, - { CCI_REG8(0x38be), 0x00 }, - { CCI_REG8(0x3791), 0x5a }, - { CCI_REG8(0x37bf), 0x1c }, - { CCI_REG8(0x3610), 0x37 }, - { CCI_REG8(0x3208), 0x16 }, - { CCI_REG8(0x3208), 0x07 }, - { CCI_REG8(0x3701), 0x1d }, - { CCI_REG8(0x37ab), 0x0e }, - { CCI_REG8(0x3790), 0x21 }, - { CCI_REG8(0x38be), 0x00 }, - { CCI_REG8(0x3791), 0x5a }, - { CCI_REG8(0x37bf), 0x0a }, - { CCI_REG8(0x3610), 0x87 }, - { CCI_REG8(0x3208), 0x17 }, - { CCI_REG8(0x3208), 0x08 }, - { CCI_REG8(0x3701), 0x1d }, - { CCI_REG8(0x37ab), 0x0e }, - { CCI_REG8(0x3790), 0x21 }, - { CCI_REG8(0x38be), 0x00 }, - { CCI_REG8(0x3791), 0x5a }, - { CCI_REG8(0x37bf), 0x0a }, - { CCI_REG8(0x3610), 0x87 }, - { CCI_REG8(0x3208), 0x18 }, - { CCI_REG8(0x3208), 0x09 }, - { CCI_REG8(0x3701), 0x1d }, - { CCI_REG8(0x37ab), 0x0e }, - { CCI_REG8(0x3790), 0x28 }, - { CCI_REG8(0x38be), 0x00 }, - { CCI_REG8(0x3791), 0x63 }, - { CCI_REG8(0x37bf), 0x0a }, - { CCI_REG8(0x3610), 0x87 }, - { CCI_REG8(0x3208), 0x19 }, }; =20 struct os05b10 { --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021086.outbound.protection.outlook.com [40.107.51.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6891F2236FA; Fri, 6 Mar 2026 12:34:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800455; cv=fail; b=N6ADKWp2fBBkL3PPOAmPaFc8BaNCuoRFPEdMgQP1r2q0RrUY5tpubd5o0pnKD8WVzQ+sURLjwGNV3sHnYWak6MugQtFR9ci7Ta0N+YJ9csCqg+BLvSkbpWNLHgS5cWLCB0i3GDpSVbPq1NWqS6KUUB/AuZd+TiZNrYXueMphXzo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800455; c=relaxed/simple; bh=LaDZ868PfOAHcvT6VWywRAkeIgswrlAYVkdiC2zXOzw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mA1ASY6tlWgqgO55nRP/0PSjHk0Wt1HiLkmGMvJe/G1AFSO075hOQhq67jf/eoqI4ZgmYaOQ2Qqit24v42LdJPsttpC7jOMlZYjwE8zVSZFnKjRWNPD/m2/SKqiqe5IuOnNjMEcqiQDXxOxsFSqSmTijtRo5OxPNU9odp3SeHjk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=d51D89Mv; arc=fail smtp.client-ip=40.107.51.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="d51D89Mv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qpqQ7jNYETGc7Nsjmi1f8pJGutz5MHsRHbuJYTJ9rr1RD9rMcFO3m3x5A0vUjZ/adIACWSEKzif5LcBkXI7UGQiSCd+pPi92p5iEtMiuXJ+bYghQJHJI+iNjiZYFZpCaMo4Qkwl26whp2B+z+C7JhNe8N3PlEqswLTGJWHEwbk4j7I70HIsCOAGOtVZpCt6rsjOkqvd20Ptobuo3MsrtW4ztaIEKficre0i0/EqeV99cdhCn2wmRL70l29a8q9MMRc3WUZYI3c0P7Lxm97F+d98q93LGQWGARaaEKMD8tUxlNP25WO+FcFpBHOXF3lF4UhqYxHwwtfRZP6U0Xzi+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qSTpUYWnha2BsXEn5KWH7iXwlFCIoiHzWNc7Exd3Prw=; b=n/3/ODMnCf7ppLN7k5ACWjUgJYkZ8g1OzOP9/xb11XeuHWHMmDaHVZJLhWV9hVDgJc9viJHI3jk5JMqjHZxd/Pc0FyC5A/sxgWXrUzPU3tNzi7OyGuqGsiU5vugw37lz/7AErQVZJ7Bilu2IgeSSTr4QtYRzabArRnxlEbOuYPQOiwf0Y+sTDc1ldZmQV1MKlLN8EZjSJiE5lMIKh9G5bK1MCQl5cBHprkGCnY2qoViZmLmA8BaV39bA8BqDNCVRzqHSQhKx3I+oQ6UmNDF4HdtySvJ8mwRkv24VGoKeY6MZ4WekkNmG8xqYOWUMFPwtv4/2MWIOxy92yOwxy37cMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSTpUYWnha2BsXEn5KWH7iXwlFCIoiHzWNc7Exd3Prw=; b=d51D89Mv05UaiHX/WQJobjbX0Pe48ECKoEXoqZTTYcYaQNzXI3ZZKJVgCbkimq/ps9VxGvfr8tC+bWVkUtQ5LjBvj10MyxYN/Gar93LBKsZKz4tb5WZKWE8ElH7vBRJrr0YEyPzR7S5RTkpq+VQtwbmcdnyrCyUgKeyca1/Ko/OZR3SVyuL//TVRCIC1NCIQnepyNtCt4vM800DJMVS7b3lE2YSl3ufdSICQ2sweXKbRP3dkgjZHQB1XbFP20dk4QtnAzA/FBwf7zzrfAK7WXsh5UqWgVZ+cY+JD0st+k4e+Fwm5OyII8ebrXa7dWrrb9evT5Vvy+DHj6r/990OZVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:09 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:09 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/13] media: i2c: os05b10: add register definitions and use them in init table Date: Fri, 6 Mar 2026 18:02:52 +0530 Message-Id: <20260306123304.76722-3-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 81776846-8cc9-4c3b-d4f7-08de7b7caa2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 4MjEZjXlWrPNS01Odmnx+0QATJE6QSVxzW2WtFaNEDdR8tBXal4r0j/Z/zDwtiwzX9bTEYgqtkilCtGoXigAOP/pP8PaEeeiy/CH0jUWtaW3KQp7vkU8R5VE5AzY4ffOQZvUFDBYeTINYs7P/ThZTkG4Z+s/QBsBYcJdL3To1a0psRHHhN+0ioCt91B7V09FRmtskiX8UD+uYSYO4nVHDvsb4PXZXTBLThKnWNm/EERisa+VAyHwMaGlD7YTSsgyLBNliUEmYpE2+Y1rg2AGc2LRpYLRZcJ0zg6/KXQkLXo7W1sdmSaVYio3Er4fEtEEUQTXfrPtNNRHlp4qxsk5eK8CtCPBrCaJ2opywAjJ2Qezuvd4+JgG8l+pkql1Sf+5biCGHSqA6qSZC05Lr0MFci2sd90CChqwpd9o4w+AoXh+rnfJf0XUyV1G6+bR8x+Fm3i/oim0H9mKaphB0GybwAyw420wNTAAkzSuGCmNtVNVMznd7fw17A+XSXPPn6c/JfZ80K+qEDqARzrc4cRQGVswahvfs8i1wDh/s1XNyNakOnL1v+W1rXDsPknkxbd2/ewBuG9Qfsl83yRj0jvEeq1VVA2HZOfGqRywKgixo39H5xT2xzFwFLQZz8tmZuFZxXHAR24J1xvfav1fu62GyYPuuFQ3Llp6LG5BHfjLq5OUC5ItuH5ixJImR/LCtnJcxkTm9wqA5QZwp+D9Ni6BtvxmVADlzh1KQpz7aFuNlWazZYFLteARaX2QLoaeHGPbJ1IGxtp7KPvkGmDmcJSsT3CaD/VDdRYcXDDg1txonHY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wl+fE0CcWYjpYxUaJIrJo7ohEJ94cGY3C6OL6eun6lUXIifYH/8RbPNNP6vg?= =?us-ascii?Q?RZE/HMsqTvcqBcctshGctrzD67xj6FWPYFEOR3yf3NCjRpZ1QcWrFTqIuoHS?= =?us-ascii?Q?D2o1xea6gdo3SrhCwhrZbdcoFbeB1qNmhtfVhahNoR6E+Fs8G6YnfsVBH+1B?= =?us-ascii?Q?Jvwu38w9E1jldg4GEVGwuUlsI1GNEKpdZQuL+r4p4ogFg25NhZycM48AGmY8?= =?us-ascii?Q?RRkMJsAbZvHzn0ZZucdAY83TyrBS7173zYEyCyPhsWK4n8SDgkA3uc+5Hrm/?= =?us-ascii?Q?os8r0SSG8jmCagmn56Y1m7zsDcuBsMjA0UFxBjkhDqm+AhQ1r7p1oC1SyvzV?= =?us-ascii?Q?i8TPu/i9d7oG3OkjmpxfbhGsRDjo917JZjcziMte7eE24RchIl/7D6AzVpfN?= =?us-ascii?Q?0SnWsl+6426u6wjWjZggvPnHVQoWjGqhwMabX3yLpZhY94GMJU2hHUdOryTr?= =?us-ascii?Q?DUbhpk+v/RzA/+MQQwLmJ88RfxlEqCVvouprzlzqm9InRGdCxsAABHj//s6o?= =?us-ascii?Q?9Ev8d++7XYd1aR3v61mPc05esOK2jhAyJZLjNFziqGQlpLo/u7n/sixsvEtK?= =?us-ascii?Q?CdM9i47A2N7yYIjdk9b3Vim1kie1bpA3+LB0TVHiwCwQEK4DHyhmcHMD5aSA?= =?us-ascii?Q?Jed1T+PZVahsoEiEGaVJXBfMqTzdWBH0rgNmU1vGVVQ0Czr1XLLUNjj+hsAA?= =?us-ascii?Q?VyhR6drWSbLraayl31nOlak36I6SgmMl/xOFUaYUcTLPOTWF31xFO8JE9i4k?= =?us-ascii?Q?KO85VOJHt/tka4aGAm0ZY+CS9tq8yYC4c4IhRl34wHmA4sbqLZS042Ho0V/k?= =?us-ascii?Q?LJEH7Pr07KpHfQZVs2zBkczpi56yTnYnafXSGDEhDUxChvEy4vNAtFvYdM62?= =?us-ascii?Q?wIae5rt6Zn505YM0FSC3Xgsfin4SNgvtwQKRDHhjs+EKo26CyZkBJgw/Dz7Z?= =?us-ascii?Q?GAb7i8YRf+aVYIVunL2vYehFXQNH9BPTSQSACy872fRI3XKUMnWA8PVG2kKy?= =?us-ascii?Q?BxHPR5soHLyp3tuENL2982Hcx2bp4ZxIKKnNlu7rX1QmrM7fj8HjXKHDoEVE?= =?us-ascii?Q?fZJqMUJbVlTOLDmfrAoViARZMYFlGB3bBRyUZ6HsmaN9gVJPegLOb+OO3tRo?= =?us-ascii?Q?5PWeXUUiUR4OGgRPRUM9uAi8iNhWife6Rvpr2umsIG9/HFj3MA0GbUvo22ZK?= =?us-ascii?Q?3VUbL/UelTtpuvCz19sJMYZsQ1wAwd0zRKjuSY+04yV+1fHfl/f+fxXWIReQ?= =?us-ascii?Q?UV5WU0M/Eu2Q9N3wIMRHHCk2Ttr2HQ23J0W4D/RIoqXCedDoLeCNk/mI65pB?= =?us-ascii?Q?+McG7hDLttzQu67wG10LKgOxtXx14Yjnen6XVFYPiI63e8ZDyQn2PU++M2/v?= =?us-ascii?Q?Yq1IC83kR3VFNZiyZnQgFu7tdfIS66ZiY0m+j0JyUwixvb2aqulGvua6n/S/?= =?us-ascii?Q?DAPc8bW1D/Bv7VAVlR0VRgHYNjvkcpWdvBVeIC+iisO3ctjbYsCS0/GjQX3Z?= =?us-ascii?Q?VpvIPrhYFNs+lcgNCOJ9ARCsmrFyyZpASEjZhmChHQ0hC3YDfoUGtnXNSx/M?= =?us-ascii?Q?H8uio8/lJhAT3ZK4jQGtiXqijQPWtYanD3kmuS4hiQ8sRjpVnb3wsp+O99Ui?= =?us-ascii?Q?5swJbmw80/Qa04aNZcQFBhSqLgE0I9LTDvcQ/nf+QLDPx7qR6SL+j4LddUGM?= =?us-ascii?Q?U5esRpN8xarGrvPe9BvuhSiMHaQWZmXJyWpvBetmWr+7IwojTVA2EDjrh88q?= =?us-ascii?Q?ts4RUYRw5B1GFO1oYpXvb+fKq0hXweE=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 81776846-8cc9-4c3b-d4f7-08de7b7caa2a X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:09.5966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jr4r55udi+2G7c+fvrUBvn0QaZ2GfZNmz2gSzWx2bQrlemMGr3b/3BOzLindSFswXQxE7+f6jOOG7pU25V30xnuofLrPJeqkQa1CXIMw9q4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Define named register macros for OS05B10 and replace raw register addresses in the common initialization array with the new definitions. This improves readability and maintainability without changing functionality. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 111 +++++++++++++++++++++++------------- 1 file changed, 71 insertions(+), 40 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 7f32e3b1e7bd..89a564f70818 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -38,6 +38,20 @@ #define OS05B10_MODE_STANDBY 0x00 #define OS05B10_MODE_STREAMING 0x01 =20 +#define OS05B10_REG_PLL_CTRL_01 CCI_REG8(0x0301) +#define OS05B10_REG_PLL_CTRL_03 CCI_REG8(0x0303) +#define OS05B10_REG_PLL_CTRL_05 CCI_REG8(0x0305) +#define OS05B10_REG_PLL_CTRL_06 CCI_REG8(0x0306) +#define OS05B10_REG_PLL_CTRL_25 CCI_REG8(0x0325) + +#define OS05B10_REG_MIPI_SC_CTRL CCI_REG8(0x3016) +#define OS05B10_4_LANE_MODE 0x72 +#define OS05B10_2_LANE_MODE 0x32 + +#define OS05B10_REG_MIPI_SC_CTRL_1 CCI_REG8(0x3022) +#define OS05B10_10BIT_MODE 0x01 +#define OS05B10_12BIT_MODE 0x61 + #define OS05B10_REG_EXPOSURE CCI_REG24(0x3500) #define OS05B10_EXPOSURE_MIN 2 #define OS05B10_EXPOSURE_STEP 1 @@ -49,11 +63,42 @@ #define OS05B10_ANALOG_GAIN_STEP 1 #define OS05B10_ANALOG_GAIN_DEFAULT 0x80 =20 +#define OS05B10_REG_DIGITAL_GAIN CCI_REG16(0x350a) +#define OS05B10_DIGITAL_GAIN_MIN 0x400 +#define OS05B10_DIGITAL_GAIN_MAX 0x3fff +#define OS05B10_DIGITAL_GAIN_STEP 16 +#define OS05B10_DIGITAL_GAIN_DEFAULT 0x400 + +#define OS05B10_REG_ANALOG_GAIN_SHORT CCI_REG16(0x350c) +#define OS05B10_REG_DIGITAL_GAIN_SHORT CCI_REG16(0x350e) +#define OS05B10_REG_EXPOSURE_SHORT CCI_REG24(0x3510) + +#define OS05B10_REG_X_ADDR_START CCI_REG16(0x3800) +#define OS05B10_REG_Y_ADDR_START CCI_REG16(0x3802) +#define OS05B10_REG_X_ADDR_END CCI_REG16(0x3804) +#define OS05B10_REG_Y_ADDR_END CCI_REG16(0x3806) +#define OS05B10_REG_X_OUTPUT_SIZE CCI_REG16(0x3808) +#define OS05B10_REG_Y_OUTPUT_SIZE CCI_REG16(0x380a) + #define OS05B10_REG_HTS CCI_REG16(0x380c) =20 #define OS05B10_REG_VTS CCI_REG16(0x380e) #define OS05B10_VTS_MAX 0x7fff =20 +#define OS05B10_REG_ISP_X_WIN CCI_REG16(0x3810) +#define OS05B10_REG_ISP_Y_WIN CCI_REG16(0x3812) +#define OS05B10_REG_X_INC_ODD CCI_REG8(0x3814) +#define OS05B10_REG_X_INC_EVEN CCI_REG8(0x3815) +#define OS05B10_REG_Y_INC_ODD CCI_REG8(0x3816) +#define OS05B10_REG_Y_INC_EVEN CCI_REG8(0x3817) + +#define OS05B10_REG_FORMAT1 CCI_REG8(0x3820) +#define OS05B10_MIRROR BIT(3) +#define OS05B10_FLIP GENMASK(5, 4) + +#define OS05B10_REG_FORMAT2 CCI_REG8(0x3821) +#define OS05B10_HDR_ENABLE 0x04 + #define OS05B10_LINK_FREQ_600MHZ (600 * HZ_PER_MHZ) =20 static const struct v4l2_rect os05b10_native_area =3D { @@ -77,30 +122,25 @@ static const char * const os05b10_supply_name[] =3D { }; =20 static const struct cci_reg_sequence os05b10_common_regs[] =3D { - { CCI_REG8(0x0301), 0x44 }, - { CCI_REG8(0x0303), 0x02 }, - { CCI_REG8(0x0305), 0x32 }, - { CCI_REG8(0x0306), 0x00 }, - { CCI_REG8(0x0325), 0x3b }, + { OS05B10_REG_PLL_CTRL_01, 0x44 }, + { OS05B10_REG_PLL_CTRL_03, 0x02 }, + { OS05B10_REG_PLL_CTRL_05, 0x32 }, + { OS05B10_REG_PLL_CTRL_06, 0x00 }, + { OS05B10_REG_PLL_CTRL_25, 0x3b }, { CCI_REG8(0x3002), 0x21 }, - { CCI_REG8(0x3016), 0x72 }, + { OS05B10_REG_MIPI_SC_CTRL, 0x72 }, { CCI_REG8(0x301e), 0xb4 }, { CCI_REG8(0x301f), 0xd0 }, { CCI_REG8(0x3021), 0x03 }, - { CCI_REG8(0x3022), 0x01 }, + { OS05B10_REG_MIPI_SC_CTRL_1, 0x01 }, { CCI_REG8(0x3107), 0xa1 }, { CCI_REG8(0x3108), 0x7d }, { CCI_REG8(0x3109), 0xfc }, { CCI_REG8(0x3503), 0x88 }, - { CCI_REG8(0x350a), 0x04 }, - { CCI_REG8(0x350b), 0x00 }, - { CCI_REG8(0x350c), 0x00 }, - { CCI_REG8(0x350d), 0x80 }, - { CCI_REG8(0x350e), 0x04 }, - { CCI_REG8(0x350f), 0x00 }, - { CCI_REG8(0x3510), 0x00 }, - { CCI_REG8(0x3511), 0x00 }, - { CCI_REG8(0x3512), 0x20 }, + { OS05B10_REG_DIGITAL_GAIN, 0x0400 }, + { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, + { OS05B10_REG_DIGITAL_GAIN_SHORT, 0x0400 }, + { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, { CCI_REG8(0x3600), 0x4d }, { CCI_REG8(0x3601), 0x08 }, { CCI_REG8(0x3610), 0x87 }, @@ -274,34 +314,25 @@ static const struct cci_reg_sequence os05b10_common_r= egs[] =3D { { CCI_REG8(0x37f5), 0x00 }, { CCI_REG8(0x37f6), 0x00 }, { CCI_REG8(0x37f7), 0x00 }, - { CCI_REG8(0x3800), 0x01 }, - { CCI_REG8(0x3801), 0x30 }, - { CCI_REG8(0x3802), 0x00 }, - { CCI_REG8(0x3803), 0x00 }, - { CCI_REG8(0x3804), 0x0b }, - { CCI_REG8(0x3805), 0x5f }, - { CCI_REG8(0x3806), 0x07 }, - { CCI_REG8(0x3807), 0xa7 }, - { CCI_REG8(0x3808), 0x0a }, - { CCI_REG8(0x3809), 0x20 }, - { CCI_REG8(0x380a), 0x07 }, - { CCI_REG8(0x380b), 0x98 }, - { CCI_REG8(0x380c), 0x06 }, - { CCI_REG8(0x380d), 0xd0 }, - { CCI_REG8(0x3810), 0x00 }, - { CCI_REG8(0x3811), 0x08 }, - { CCI_REG8(0x3812), 0x00 }, - { CCI_REG8(0x3813), 0x08 }, - { CCI_REG8(0x3814), 0x01 }, - { CCI_REG8(0x3815), 0x01 }, - { CCI_REG8(0x3816), 0x01 }, - { CCI_REG8(0x3817), 0x01 }, + { OS05B10_REG_X_ADDR_START, 0x0130 }, + { OS05B10_REG_Y_ADDR_START, 0x0000 }, + { OS05B10_REG_X_ADDR_END, 0x0b5f }, + { OS05B10_REG_Y_ADDR_END, 0x07a7 }, + { OS05B10_REG_X_OUTPUT_SIZE, 0x0a20 }, + { OS05B10_REG_Y_OUTPUT_SIZE, 0x0798 }, + { OS05B10_REG_HTS, 0x06d0 }, + { OS05B10_REG_ISP_X_WIN, 0x0008 }, + { OS05B10_REG_ISP_Y_WIN, 0x0008 }, + { OS05B10_REG_X_INC_ODD, 0x01 }, + { OS05B10_REG_X_INC_EVEN, 0x01 }, + { OS05B10_REG_Y_INC_ODD, 0x01 }, + { OS05B10_REG_Y_INC_EVEN, 0x01 }, { CCI_REG8(0x3818), 0x00 }, { CCI_REG8(0x3819), 0x00 }, { CCI_REG8(0x381a), 0x00 }, { CCI_REG8(0x381b), 0x01 }, - { CCI_REG8(0x3820), 0x88 }, - { CCI_REG8(0x3821), 0x00 }, + { OS05B10_REG_FORMAT1, 0x88 }, + { OS05B10_REG_FORMAT2, 0x00 }, { CCI_REG8(0x3822), 0x12 }, { CCI_REG8(0x3823), 0x08 }, { CCI_REG8(0x3824), 0x00 }, --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021086.outbound.protection.outlook.com [40.107.51.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E5A2264DC; Fri, 6 Mar 2026 12:34:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800457; cv=fail; b=OdHYO25Gbo4tsyH0/pkAVxlQ1feHFIK3ZG/YninVpGcZ2N+IZe9NWw/65lTSpYjiDoYHUjN4uENAiAghv1PdqnXin5FgZPwcOtp9Tp9QdekRvxrucGvW6L0KDemZQ8NX+CJfhAI3+wuW7l3vHphY7k8FfImOD3vl+F4LaUC9fU8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800457; c=relaxed/simple; bh=fwdlHQgGpzJd8qdYRVnTWNlFUfgbrkvqFPgVET2ARAE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jZ/Pd3oQU/FvhMTgkQbcxPuURduDS4RynPokBlKum2+FiQ/CMPwcLWzmRjWKPhW+RwYWu/mIYSt+kV4/heJ3nFnCmdTgTfOviMJUQ70kpl3ycCZDmIIFuXqz0ZunNOKKQhHSVYLay02iRSzyx3DIRb5PPhvcj6tcskeFipWDv7E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=aYajRy1X; arc=fail smtp.client-ip=40.107.51.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="aYajRy1X" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qbcBWZnGBjwhj0atTksN6QH952N6LQ4Ggm/q0e0sgwWikJxRBeIadACiqisu7fx1XRls+NHo7/ToEuE2gDePkrW8rQuCrbw6U7ANdFQIggDbsubA1LnVrhTcpLZHZ+ieohZfSAo+/ksWUY6S4KNIf56Jpt//nM/GcWOb2FlN6L3/Dt7TZno+F06pH6ZLHWcbhtv7ZMRV1bPrEhpb8cTOt9IRIVJwJYf+J+CUt/ygOX++KBG3wXoYCgM8hL68JWK93DhoVXAo8cuc0OLOwnS11gr0+QvBOUiFy2ueIv3XkAj/oHxR0EbY+wWAgo8SHwsPe+B+yZ1IV75qhtGfB9HXFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHkWPMnKM0x5p+lioiRbQkQ0krv1WZMGAkFOTB8UGUY=; b=vdXE6smSVbdEb/Dd48t61DxPwWzM8SN4rZ9etEimutqO8cgb3yJNrBIZNnoA3CXckaYsFWyww5J+Y06zgObeIQNRTct+upFUHahNvrpSHWxVbAGumDpicTRQ/NtHmlehOfy8I3NxGFSCE4VQm8u7G4KreM163jZLwOr8OCgsRkbSSvtHbDNMJA4KN0KBNeq3hCSL4kDHYEY6j2MCxw9iWUWe97qaT3W6pTCG3dpWzChDlb2uLKtEfNN4Juf6XRET0K4yQWBMGS5almXEoP9QN9GLHo97de1D46UUh/3Sh0CZ9m8YucJzvt55PlU7f1dy3PnkP8mEcIGeuSYr5vkE/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHkWPMnKM0x5p+lioiRbQkQ0krv1WZMGAkFOTB8UGUY=; b=aYajRy1Xv74PuH55cJKqY4XZggJhayVu4zWPSJnQw8+yB6Tg1QrU3whAxqZEW1dKVK5eOYvcTbsoR7lfEqt/esL6kIQII9ZFGCYNcPFsyWNqq/MxEccMFL5LlU5pFDLpY3fgahQW9r2wVFt4A4g7GZQHp7rMzEFGA8oLLXnCc9prXGr7K+FCUtoWIhvJXf+h43IHdsWau+tcOwId6keNPPH8wjgakmLsJSi76/TV9l+ZRz3dCcIE9Q0sBuoDM/Dv8319vgs/bJXk/NTjD5LDpWqOG3AnDCkQewwrZZM7SM7LKJo1rXvUPciM5g2yqyeoD5tmeijzVJqQcB2Wzt49pQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:13 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:13 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/13] media: i2c: os05b10: split common and mode-specific init registers Date: Fri, 6 Mar 2026 18:02:53 +0530 Message-Id: <20260306123304.76722-4-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 1050c43e-213a-46a4-de27-08de7b7cac57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: l3ib90Wdkr1bWCy1nWZXs0bsKz+ejiwJOey0kZjxn9uI/mxH0VHxwf1kiI38vj+NZ3zgr2x7cALuZ1yR6SNioRGPqBlI8EwVpralsnTXxKD7fx3SshAAL3v/aOgQtBf7EXusdz5mkE5BhvDdDFts3P4wc2DY0ALgespnkkhEu3+8V8whOFDZLreq3wiueoJ3VxMGCQ3Yp2b6NMEe3eu3axnkaucdSBW2VQc9/WNpTjJeBy7uz0/MRZQbHWcktMvXuYwRcpVNPIYME3RxUqnrJUvR7mfit4v0/CUNxNuSbT5OJhLYJdxI5661s+0kYcdW6IRH4qSoZPsJY9x8em5nOZtD2Q/32m3gUeFi2eJNMS3muw60mU4auO+MDRmJgWub5/8jtpZZWpzRM1P7XGQo4ziB9plvBgoI+f+Oq6LfkybnMdJHyctaWJQ0EYotlRXpdlJHtHXjGUiDdNOcJa4ShhI7b5IFLBViSfOY9Sj1Pe5DkA051HtRU1Pod4Xra/BFMxc6XMGe/wAJSf9WcJFmusAV/GDU4sOPNc+t4a/vnEW80oc8ECZKPEAqpzE7CT57NgVJYvSBbHwqIM6Uyg+S4+2rXb/1rOsbu9U++iluVAUmz6h1HF2WPOrXUFoT4Hs8y9z4SHhH82EgaOlhIc9rDelCuyoJtDDmz5dGTW4Hupqrqxlu6uwcoEEK/H1O92dYE/zMK8UH8MIsHH4QSkEJRbVzQnnaSuLLa5/06HEoH3xcDXjoYeKAJyo3qp+bYJStOZi1f1+JAS7jUs61PHpbeaJ1hy45j8oGrbEVAj0BLwg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C7HxadRLfI1hmx0fweAiWXXeAPoGP4tqMuEC5B6WN/89xIhkRCIEZ4OrGkEL?= =?us-ascii?Q?XdcBIeIzXLIZccmPEUVPgv+fLEYSDkJbamNiy/QY2yPoENaLiwkfq9AXZpe6?= =?us-ascii?Q?P7UG45VPcuIyM/1TgPOoXv7oc9Dpne4dVMHBP0DwGuesMLcc5upM098XjF+V?= =?us-ascii?Q?J9vtDKc5mPcWhSiqyYDzliL4x0sJsT1v7CclzD3PFYvjyS/qQZ01nOwmP0U4?= =?us-ascii?Q?0kI/hxtzFE80MYHOo3x4gNplJUaC9wvunF7AYVCNuGMbCoU3CsJ1Gh1enNcS?= =?us-ascii?Q?GG11oClFmwUuPGOnuWXgM2W8S88RfOmJXskE2m1OsGSCRtKFV3L7cDJik29W?= =?us-ascii?Q?YNXxTVWxwfi0TECqSwpvGtVKf6QjBm1wig2L4r6J4em5tkoM/iXIVk1/rhZp?= =?us-ascii?Q?xpKAW+HzYOKz8t1iRT4VxL8ZxA6OrgMTXhUyGiwV2twk98uLk81tRz3NjQXJ?= =?us-ascii?Q?TiEmR0gs4w0B3j3XRRt1CB3sR5KWXJHh0SfDCS1Yz8tI8SjyBlkONhe9Ia3r?= =?us-ascii?Q?8uI7zGH5GbPCD0vhzooQtu/NC4G2GBCK5jyhutcHrY6pxyjnhXynenrPlFi9?= =?us-ascii?Q?pEf5x2jtGMIdhpjtG9/aNcxtk7jkovWYt99c35Jj+p5wMiXTV/i9wgTHZ9yw?= =?us-ascii?Q?SxjzwzskQ8xIV++5guO4tTD7jb8QxDaYac4t1gZTEs9FfeK3n/WTjAi/H8cP?= =?us-ascii?Q?r3RJ+bEvFAmj+3I75AwdQGcXOWbC6OWPjdIE/nyihwMLcTYQbvBFFM4jczEZ?= =?us-ascii?Q?WZZ7Y7z+Q5rwAraZadoLnn2WDb/e/qIJgjn2M+VpgUk2UELldhohVKwD2G7a?= =?us-ascii?Q?Nc0ir2CF/GCE+KDGRgNsrA5NWW0LZskJ2aynyOAZLjqdmUGmuiK2GH++LWnT?= =?us-ascii?Q?b4SvZALPR7JeXn/u/K5AKsHCuZO7LftTjgp/bTN4Tj89bAM8pyXVFQMV3Jyg?= =?us-ascii?Q?px9QqBFkgRvOnP7myTZ99KcjEUf8ZYiAROlcV3YjUYjdwAPwx7RfTFMggLpB?= =?us-ascii?Q?yRHkbi2qHt+SW436rSS4KyPXZES+vwlc/QKcGP+iYE7IOhyzPmBFUbgZaenK?= =?us-ascii?Q?O2c6Eg/xkhTrqC695M0i5g2CnhtZXS6DVfUzJ59cniXseJ5p1FZKjzQVtBWL?= =?us-ascii?Q?JiEQhecFuHdgys3tsHjQkBawCgjJJN0AkXqaYy8BcmGY/CqeZ5s6ta7rFUB2?= =?us-ascii?Q?NiEXIMGOFQMZp3AOqN9KBqqJQVxGYuqQ360otbU/RNikUMcWyp0a3P9XCcyb?= =?us-ascii?Q?XmYR6vLqMVRJPbsqstkljsSKcJVXpwXTL1vLnPJDGYxTB5tKOSiLc6GZkrel?= =?us-ascii?Q?jz3u7qUSp0JXuWS8sS47uSmgJ23oA4htMBFn5tFr1hr0Gv+2dFeXdirtIvMp?= =?us-ascii?Q?hCvKW5ijRQmL4VXmsdKZXyYqNMJvMkjocolSItG3i9aXR4S+KlIVi9EP/WzD?= =?us-ascii?Q?h5M0TczlXw3U2MzxDcH1xDOWswkZaUOzsrfSm4xbrq72/4xOF5dCFU5mZPt8?= =?us-ascii?Q?7OTRu/TcXoxqlKgccDnUpEVYWzzusfTLcSbriwuT5/tYfv944pDWEPRMDtkS?= =?us-ascii?Q?a4TMVowz4gHNM1+CcXF9phH0PpEtP0PMM69ZfwRnEm+D2gu8yi2nd7jgjMZJ?= =?us-ascii?Q?p0L4qxTIwM3DTyHHxOGdDq+xz7QiDnabvgwnZAagf1hHtCvSacXgq4fHY8Ka?= =?us-ascii?Q?D9RPo+NJz00/vlEda3yM5HJvjcOWYMNIXcpJtLrhDqcJ4odL5Ps1KmHtAQH5?= =?us-ascii?Q?gEfdptERytUY332S4QxM+7TZyzNR2JQ=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 1050c43e-213a-46a4-de27-08de7b7cac57 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:13.2644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o09c9TFw5Upx521uINu/MntNDv8lASN09p+Orix+ZvhRoeFMM706wcErpeqyrbMBxyOsr5lyAihTzN9un1PSfbWe62YknN/1qeW/sBZGPC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Separate common initialization registers from mode-specific settings. Move resolution-dependent registers into a per-mode register list and program them during stream enable. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 118 ++++++++++++++++++++++-------------- 1 file changed, 74 insertions(+), 44 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 89a564f70818..b1d9eaa473e4 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -122,37 +122,34 @@ static const char * const os05b10_supply_name[] =3D { }; =20 static const struct cci_reg_sequence os05b10_common_regs[] =3D { - { OS05B10_REG_PLL_CTRL_01, 0x44 }, - { OS05B10_REG_PLL_CTRL_03, 0x02 }, - { OS05B10_REG_PLL_CTRL_05, 0x32 }, - { OS05B10_REG_PLL_CTRL_06, 0x00 }, - { OS05B10_REG_PLL_CTRL_25, 0x3b }, + { OS05B10_REG_PLL_CTRL_01, 0x44 }, + { OS05B10_REG_PLL_CTRL_03, 0x02 }, + { OS05B10_REG_PLL_CTRL_05, 0x32 }, + { OS05B10_REG_PLL_CTRL_06, 0x00 }, + { OS05B10_REG_PLL_CTRL_25, 0x3b }, + { OS05B10_REG_MIPI_SC_CTRL, 0x72 }, + { OS05B10_REG_MIPI_SC_CTRL_1, 0x01 }, + { OS05B10_REG_DIGITAL_GAIN, 0x0400 }, + { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, + { OS05B10_REG_DIGITAL_GAIN_SHORT, 0x0400 }, + { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, { CCI_REG8(0x3002), 0x21 }, - { OS05B10_REG_MIPI_SC_CTRL, 0x72 }, { CCI_REG8(0x301e), 0xb4 }, { CCI_REG8(0x301f), 0xd0 }, { CCI_REG8(0x3021), 0x03 }, - { OS05B10_REG_MIPI_SC_CTRL_1, 0x01 }, { CCI_REG8(0x3107), 0xa1 }, { CCI_REG8(0x3108), 0x7d }, { CCI_REG8(0x3109), 0xfc }, { CCI_REG8(0x3503), 0x88 }, - { OS05B10_REG_DIGITAL_GAIN, 0x0400 }, - { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, - { OS05B10_REG_DIGITAL_GAIN_SHORT, 0x0400 }, - { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, { CCI_REG8(0x3600), 0x4d }, { CCI_REG8(0x3601), 0x08 }, - { CCI_REG8(0x3610), 0x87 }, { CCI_REG8(0x3611), 0x24 }, { CCI_REG8(0x3614), 0x4c }, - { CCI_REG8(0x3620), 0x0c }, { CCI_REG8(0x3632), 0x80 }, { CCI_REG8(0x3633), 0x00 }, { CCI_REG8(0x3636), 0xcc }, { CCI_REG8(0x3637), 0x27 }, { CCI_REG8(0x3660), 0x00 }, - { CCI_REG8(0x3662), 0x10 }, { CCI_REG8(0x3665), 0x00 }, { CCI_REG8(0x3666), 0x00 }, { CCI_REG8(0x366a), 0x14 }, @@ -236,7 +233,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x370f), 0x1c }, { CCI_REG8(0x3710), 0x00 }, { CCI_REG8(0x3713), 0x00 }, - { CCI_REG8(0x3714), 0x24 }, { CCI_REG8(0x3716), 0x24 }, { CCI_REG8(0x371a), 0x1e }, { CCI_REG8(0x3724), 0x09 }, @@ -245,7 +241,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x3730), 0xe1 }, { CCI_REG8(0x3735), 0x80 }, { CCI_REG8(0x3739), 0x10 }, - { CCI_REG8(0x373f), 0xb0 }, { CCI_REG8(0x3740), 0x28 }, { CCI_REG8(0x3741), 0x21 }, { CCI_REG8(0x3742), 0x21 }, @@ -291,8 +286,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x37ac), 0xa0 }, { CCI_REG8(0x37be), 0x0a }, { CCI_REG8(0x37bb), 0x02 }, - { CCI_REG8(0x37bf), 0x05 }, - { CCI_REG8(0x37c2), 0x04 }, { CCI_REG8(0x37c4), 0x11 }, { CCI_REG8(0x37c5), 0x80 }, { CCI_REG8(0x37c6), 0x14 }, @@ -301,7 +294,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x37cd), 0x17 }, { CCI_REG8(0x37ce), 0x01 }, { CCI_REG8(0x37d8), 0x02 }, - { CCI_REG8(0x37d9), 0x08 }, { CCI_REG8(0x37dc), 0x01 }, { CCI_REG8(0x37e0), 0x0c }, { CCI_REG8(0x37e1), 0x20 }, @@ -314,25 +306,10 @@ static const struct cci_reg_sequence os05b10_common_r= egs[] =3D { { CCI_REG8(0x37f5), 0x00 }, { CCI_REG8(0x37f6), 0x00 }, { CCI_REG8(0x37f7), 0x00 }, - { OS05B10_REG_X_ADDR_START, 0x0130 }, - { OS05B10_REG_Y_ADDR_START, 0x0000 }, - { OS05B10_REG_X_ADDR_END, 0x0b5f }, - { OS05B10_REG_Y_ADDR_END, 0x07a7 }, - { OS05B10_REG_X_OUTPUT_SIZE, 0x0a20 }, - { OS05B10_REG_Y_OUTPUT_SIZE, 0x0798 }, - { OS05B10_REG_HTS, 0x06d0 }, - { OS05B10_REG_ISP_X_WIN, 0x0008 }, - { OS05B10_REG_ISP_Y_WIN, 0x0008 }, - { OS05B10_REG_X_INC_ODD, 0x01 }, - { OS05B10_REG_X_INC_EVEN, 0x01 }, - { OS05B10_REG_Y_INC_ODD, 0x01 }, - { OS05B10_REG_Y_INC_EVEN, 0x01 }, { CCI_REG8(0x3818), 0x00 }, { CCI_REG8(0x3819), 0x00 }, { CCI_REG8(0x381a), 0x00 }, { CCI_REG8(0x381b), 0x01 }, - { OS05B10_REG_FORMAT1, 0x88 }, - { OS05B10_REG_FORMAT2, 0x00 }, { CCI_REG8(0x3822), 0x12 }, { CCI_REG8(0x3823), 0x08 }, { CCI_REG8(0x3824), 0x00 }, @@ -342,7 +319,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x3829), 0x03 }, { CCI_REG8(0x382a), 0x00 }, { CCI_REG8(0x382b), 0x00 }, - { CCI_REG8(0x3832), 0x08 }, { CCI_REG8(0x3838), 0x00 }, { CCI_REG8(0x3839), 0x00 }, { CCI_REG8(0x383a), 0x00 }, @@ -363,26 +339,19 @@ static const struct cci_reg_sequence os05b10_common_r= egs[] =3D { { CCI_REG8(0x38a7), 0x04 }, { CCI_REG8(0x38b8), 0x02 }, { CCI_REG8(0x3c80), 0x3e }, - { CCI_REG8(0x3c86), 0x01 }, { CCI_REG8(0x3c87), 0x02 }, { CCI_REG8(0x389c), 0x00 }, { CCI_REG8(0x3ca2), 0x0c }, { CCI_REG8(0x3d85), 0x1b }, - { CCI_REG8(0x3d8c), 0x01 }, { CCI_REG8(0x3d8d), 0xe2 }, { CCI_REG8(0x3f00), 0xcb }, - { CCI_REG8(0x3f03), 0x08 }, { CCI_REG8(0x3f9e), 0x07 }, { CCI_REG8(0x3f9f), 0x04 }, { CCI_REG8(0x4000), 0xf3 }, { CCI_REG8(0x4002), 0x00 }, { CCI_REG8(0x4003), 0x40 }, - { CCI_REG8(0x4008), 0x02 }, - { CCI_REG8(0x4009), 0x0d }, - { CCI_REG8(0x400a), 0x01 }, { CCI_REG8(0x400b), 0x00 }, { CCI_REG8(0x4040), 0x00 }, - { CCI_REG8(0x4041), 0x07 }, { CCI_REG8(0x4090), 0x14 }, { CCI_REG8(0x40b0), 0x01 }, { CCI_REG8(0x40b1), 0x01 }, @@ -402,7 +371,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x4305), 0x83 }, { CCI_REG8(0x4306), 0x21 }, { CCI_REG8(0x430d), 0x00 }, - { CCI_REG8(0x4505), 0xc4 }, { CCI_REG8(0x4506), 0x00 }, { CCI_REG8(0x4507), 0x60 }, { CCI_REG8(0x4803), 0x00 }, @@ -414,7 +382,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x481f), 0x30 }, { CCI_REG8(0x4825), 0x34 }, { CCI_REG8(0x4829), 0x64 }, - { CCI_REG8(0x4837), 0x12 }, { CCI_REG8(0x484b), 0x07 }, { CCI_REG8(0x4883), 0x36 }, { CCI_REG8(0x4885), 0x03 }, @@ -447,6 +414,42 @@ static const struct cci_reg_sequence os05b10_common_re= gs[] =3D { { CCI_REG8(0x3222), 0x03 }, }; =20 +static const struct cci_reg_sequence mode_2592_1944_regs[] =3D { + { OS05B10_REG_X_ADDR_START, 0x0130 }, + { OS05B10_REG_Y_ADDR_START, 0x0000 }, + { OS05B10_REG_X_ADDR_END, 0x0b5f }, + { OS05B10_REG_Y_ADDR_END, 0x07a7 }, + { OS05B10_REG_X_OUTPUT_SIZE, 0x0a20 }, + { OS05B10_REG_Y_OUTPUT_SIZE, 0x0798 }, + { OS05B10_REG_HTS, 0x06d0 }, + { OS05B10_REG_ISP_X_WIN, 0x0008 }, + { OS05B10_REG_ISP_Y_WIN, 0x0008 }, + { OS05B10_REG_X_INC_ODD, 0x01 }, + { OS05B10_REG_X_INC_EVEN, 0x01 }, + { OS05B10_REG_Y_INC_ODD, 0x01 }, + { OS05B10_REG_Y_INC_EVEN, 0x01 }, + { OS05B10_REG_FORMAT1, 0x88 }, + { OS05B10_REG_FORMAT2, 0x00 }, + { CCI_REG8(0x3610), 0x87 }, + { CCI_REG8(0x3620), 0x0c }, + { CCI_REG8(0x3662), 0x10 }, + { CCI_REG8(0x3714), 0x24 }, + { CCI_REG8(0x373f), 0xb0 }, + { CCI_REG8(0x37bf), 0x05 }, + { CCI_REG8(0x37c2), 0x04 }, + { CCI_REG8(0x37d9), 0x08 }, + { CCI_REG8(0x3832), 0x08 }, + { CCI_REG8(0x3c86), 0x01 }, + { CCI_REG8(0x3d8c), 0x01 }, + { CCI_REG8(0x3f03), 0x08 }, + { CCI_REG8(0x4008), 0x02 }, + { CCI_REG8(0x4009), 0x0d }, + { CCI_REG8(0x400a), 0x01 }, + { CCI_REG8(0x4041), 0x07 }, + { CCI_REG8(0x4505), 0xc4 }, + { CCI_REG8(0x4837), 0x12 }, +}; + struct os05b10 { struct device *dev; struct regmap *cci; @@ -469,6 +472,11 @@ struct os05b10 { u32 data_lanes; }; =20 +struct os05b10_reg_list { + u32 num_of_regs; + const struct cci_reg_sequence *regs; +}; + struct os05b10_mode { u32 width; u32 height; @@ -476,6 +484,7 @@ struct os05b10_mode { u32 hts; u32 exp; u8 bpp; + struct os05b10_reg_list reg_list; }; =20 static const struct os05b10_mode supported_modes_10bit[] =3D { @@ -486,6 +495,10 @@ static const struct os05b10_mode supported_modes_10bit= [] =3D { .hts =3D 1744, .exp =3D 1944, .bpp =3D 10, + .reg_list =3D { + .num_of_regs =3D ARRAY_SIZE(mode_2592_1944_regs), + .regs =3D mode_2592_1944_regs, + }, }, }; =20 @@ -655,8 +668,16 @@ static int os05b10_enable_streams(struct v4l2_subdev *= sd, u32 pad, u64 streams_mask) { struct os05b10 *os05b10 =3D to_os05b10(sd); + const struct os05b10_reg_list *reg_list; + const struct v4l2_mbus_framefmt *fmt; + const struct os05b10_mode *mode; int ret; =20 + fmt =3D v4l2_subdev_state_get_format(state, 0); + mode =3D v4l2_find_nearest_size(supported_modes_10bit, + ARRAY_SIZE(supported_modes_10bit), width, + height, fmt->width, fmt->height); + ret =3D pm_runtime_resume_and_get(os05b10->dev); if (ret < 0) return ret; @@ -669,6 +690,15 @@ static int os05b10_enable_streams(struct v4l2_subdev *= sd, goto err_rpm_put; } =20 + /* Write sensor mode registers */ + reg_list =3D &mode->reg_list; + ret =3D cci_multi_reg_write(os05b10->cci, reg_list->regs, + reg_list->num_of_regs, NULL); + if (ret) { + dev_err(os05b10->dev, "fail to write initial registers\n"); + goto err_rpm_put; + } + /* Apply customized user controls */ ret =3D __v4l2_ctrl_handler_setup(os05b10->sd.ctrl_handler); if (ret) --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021120.outbound.protection.outlook.com [40.107.51.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6579626FA60; Fri, 6 Mar 2026 12:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.120 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800463; cv=fail; b=oGyPEN9/uHcLSP60APTXVK0abrMMpsV4bSHRz8VeVIMQbKyPi9zX2lBSdG7ETSBeAw0FKRxHHvqHPlpbsV6JjoqRtZ65KTkmowJ0gMsQsce5xNE0b4Jqr/EewFMGCMxMH8q4UfCs109Lgg7gMWxj+xXsiT+Cr2JbpE36tejMuqo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800463; c=relaxed/simple; bh=jAbmwCMBAJphxclgn7oy7HbNz1vximIBCh4zsBiy+O0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=O4Z7IeoHzHkIQMmhoSe5BaeUrWr6gDZKd+Um4PM3DcT2hJ5gtMg+XBmit0wrCQnFMdJGboatjhWMcCaM3Qhlknu/dIj3MMfBNXCqVR2CF/eAxxH+UUWyU1iNDqKaKfAB2AUMGv1PPPYhywKu6w832POHvJE8ABVHsW+zlGpKI4Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=a/UoLawk; arc=fail smtp.client-ip=40.107.51.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="a/UoLawk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lgbJM8ocqaJMSnhimIFppAlIVwjlwXapQduAZynep+IHeRKKm8G/zW0WL4somQsNx0FF9ZsQR6CsfKJpzLeWS7FPJHeR9tmdEQbDTsFFLQ1j3V1P8PQvHVGTUxlFR8KKdHuilt+DVumzZNXT3noFQ6ENCm4UiDMV3VsPXqdpjWqhwQV1e3C2hjfL6mnNSgo+cIiCmrxQr78qrpj37urBavTrz/G2E6LNs0Z/6UxlEub+q3HM3CpwxQhSEcA2MoUNw9PD46ot+Hx3YLEHIbdYG1mYB8DZ5d+psN6jI36M9r6JVCT1WV45hThieeJ4ddrbTPyXMaKqCz7ry1dP7k8ZDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7CipjDsgnS6DRNSBDxe97Imcr+CU04ME9sfvZN3zWwI=; b=RzdTwtbm+fVEH/ox4JO4zGKNlBknmBUlZerCetUWEo6JKx6H8HUUuGU1kH2WWSDnRWLXqHXc4Td3HNjUXIO54L9xAWAnyH5xSuRigYKvDdYdTy+MsyWJ1GQvQxpTLnU4ZmoGZsztolSf1KzWi96rpWrQ0pNzY7hTJJTIW/JbDpwT6ICg3PlSRBjFEcRpYTX+bAgQ8Mi/+RbqBwHTkp3aqhFEcU9aFTezb9kRBpROAnIz5O5V9Lf7AgMpOdexW+k2ReNdsRgfeEwjI43OblXOqI50cmbxJnBRJvyezlC5Hqg8zDCRMtRON9IxanPYYd3zRPVnNKYhIeZbY4t+w6pq3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7CipjDsgnS6DRNSBDxe97Imcr+CU04ME9sfvZN3zWwI=; b=a/UoLawkdVQ5hqOoh8AgC1NxuFkvwJCaUROcJCtBTw9TRtba/MMSpO5jRPgez3a/plGg5Y7TFDNmX1VWuoO8qVSpPM+m1H619WVDL63SUYpD76hpguGNtm3T6SbDAVFmxXbScvGx+Mb0Ahuh5pL9iwMSdmRyqzK+ZtXJoOPLGeRR4jGtQd7aslk72lQx2gDY9f4mTnqSYkmdL7IhmlpvJ3aBQFPUZNZdJk5YV4uHJrhT+5gJFLtCeqLz+QFXjpJdPRjLh9NmbtaAw8aj2+pGd3IlKrcNiM4gQH5SoArrex+9RM26hozFDouYZ6b9JGn8ukyNCmND6d4ICLb8gVDV2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:17 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:17 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/13] media: i2c: os05b10: add V4L2 digital gain control Date: Fri, 6 Mar 2026 18:02:54 +0530 Message-Id: <20260306123304.76722-5-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 3caa8edf-4c9f-4333-ec0b-08de7b7caea8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 9edv6ys0Yy7JLY9Zvtu3v/jHRMTDfTUn607wlxsUS3BPklfI/5F0qxqYJQd73hZ9pvZDEHYy4+Ir2h+29RxwSZDnITGXvxxjW6aXnHBMGgTjbsW1uFmmktHiF2pW3C9U6azSYdieWo2Wuus1h0poGqRZlOw64+XJgk2NhQlUTpsJGY3ZaCHWAo+hulwyrpK7E22UgRHJqYC/pr0Ia21S3Ce6VDjjBTvKL6NyxBc4ICs8a/kDmUnU1tUaDcac7WmGgASSnqZeVmsi6lflhJG7U/pWx5+pcfWCHr13ZRdzubj6iyHuOfkhbVsVRB3IHKZB6iUzCN3pX/httiJrvIZGqjhNrziKby1DGXsDWq4fiWaxvqIULKeeXFXBNf39Z/u1TGa0gIsByIfZHf4OpvvUnfjFmWpyHVkzskPppZFTZJ7UV3DaIYlCXJgyQo6xWj3OHxzVQq9CB3QEaPG5/CGsB2fPEZhVJk999rCj2cQJRRknakPE5HiF4dN/241Ua2eFcQm2Uw4FHZMuePcgwOCLa00+cKk7ugaqs+t5xu3x0y1kILdGGkVk/pXdwPADCP0q1z5Yr2xAuWK+HhtiEkx95m8HpkA2nVdQVFJVLAjBj73AvEhdbA9wZEUjsrvNbdk88klP7We3Y5Pmj7u7y2Ri4t9Z5Mjour8lcciGSoT5LAS8NYTO9x0mO0lR4iZRCjpGBNqHSUHZrcKCUQYllrXNMoFPhPF0NAitCxGD2+fo6e0+bnASLcozy1sRoJVoaIfo5IT6DzTKp9oCCs5dZCLkkl7PbKvEFhtSYO2Jyu2B298= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lN3dR4ZZO4Jm2uqx+ehVZOVtv1mwO3dZzG1XNIR74DxqdRSvRK3rxqx9II28?= =?us-ascii?Q?mFWCObX2j2Qq/GphksRwlsPzaXMrl02atFdbwXhQ62Blu0xCTdIODG9yctzD?= =?us-ascii?Q?QfKHrwUenQ/KQrVONqM470i5yw+IJ9RsMVfXfgIaS9Z7Q2wNQeEIuwsuK8se?= =?us-ascii?Q?ZE+S5q7b3TQZfYY6ErO9LLoZjsq5PbjYTsXFBgviFuW4+Rhv3zMhDoQDqwCP?= =?us-ascii?Q?UNu2izLUYImTj48E/TW4paKbmQkmJxwC5MkzSnQE7n9Pjdx9RF/evKXJpoeL?= =?us-ascii?Q?MljhylQC+Tcgg2btRcIfMxjonC39JIJM76D4sPXJiDgC8SdAJNJ17OcDLnVe?= =?us-ascii?Q?YdJpd/IXr76M+pIqA/l3YI99I4YfPLWf1CTOJuw1QUf0meEAkc7mUAyCQSbv?= =?us-ascii?Q?tvr0sjp5FVVkTRNg9mv32StobF9oBxOSQhBLma3753EjmifbP5KgNOhdy4M8?= =?us-ascii?Q?35nOktv3RGB/PKZxGE3VDo/Yd3JHFUPimddNR2Eu5CD6+3CHpQDoiG03l3WX?= =?us-ascii?Q?tZAvKUr0mhE9T0PsFW5BtDUprfy2F01hRAm9FSr8XBYZbBBC8WT9Gkw40yiE?= =?us-ascii?Q?peUxDxGhaCI++H4IgCSBEbVgCh0lPF60olnrtUxNLpGibw0HRhfCe9GSsBNk?= =?us-ascii?Q?e8BcEYaCpLY8RGW2yNRtuplQwrtMIxyIVhlQzj1tqhrc0KRciF4pe5H9FpeV?= =?us-ascii?Q?+ObTva7TkGZufxAmoOHhuwiji0V8MXELm0ZKZiWq/p1WnVB1RKhG5md6EQ8o?= =?us-ascii?Q?/G/lRJMqzlnsCGYJ3uOCXPxpqd0Kz54yI2kbNH2eoUIqcX021jcZscZW5oPQ?= =?us-ascii?Q?txDeSsVCNJKWAocsLK+0sycOdS92UYkI05fBv2G2Qh2uWUg2RvzjSI+LSOC6?= =?us-ascii?Q?n1lafvmCr4iU/mqn86xspt0EZTN0DlM//TomCSIq7vRHFAtzteAF1tUphgDO?= =?us-ascii?Q?QHmTwNrfTdXcFUJ0MUP1upxdgF8Mnrn9PWCnlOCZUs2MGgwYis16xT8oxG8V?= =?us-ascii?Q?YNjrUMmXnI24Oi2ODYzqa+l30dufjEXKmVN5t/+T53p1VMW6+LMD0cEDMath?= =?us-ascii?Q?iy1K0LdoQbYNkQHIDJN8LwFRqyAREo+J7oYzBO6gzvzGNKgzuw3A3lYa5x1V?= =?us-ascii?Q?qaBWhkd/jwJKhzi42oHkTsko44XrUTbUyKOGMPYQidHQeJvCNKlaTGjnrMA6?= =?us-ascii?Q?OWXbZDYSgWZFqPkmKQdSkWaF/xyqk4w/gBW2vzxlP4f4yc42goFh4TuMkjvN?= =?us-ascii?Q?vaGAJtiKHifxeUfsgm60iXEIUh1l2uwAYVDseLdKF5ZDA3cZVPfi/A+iATvC?= =?us-ascii?Q?JwtVPUEZhpXcxuzSGQXN37Aup9kx1YH5oFDgwMqGIjVYVCtjcQwR4aH8rcQa?= =?us-ascii?Q?yYq5IdGce2kPL9oBYR/WkRWFQLeteXRGlFFwMcmRsqBUDOlOg3Rw1EGhb09e?= =?us-ascii?Q?70bGpxTjB422uRUviCqdpxfXZLGhRaiQjrPtL7acxOFZKV2JrledjCC84QUo?= =?us-ascii?Q?RC/jRwi7XQYH5XE3lPz6JgtOfse6msdHaA8e6sTkfaZAmaH7E8OepIdfsCk1?= =?us-ascii?Q?zHq0oiSNfyO1OAV600tN5ZTWkORY/kBnCzwGCkk5a3HDuen+qHnLuSwLXnbn?= =?us-ascii?Q?Jpy5UZEKD98UmsnQ3gEh5kUiRw2TRTUYk86uVkMVJZbMzr3apzpz1j1oFXil?= =?us-ascii?Q?BPfYVbWDMDwTKodfpj1lsnH2emZF5/0mXcjF/WSNqJJy4Iuo7y7ZTHSxcfaW?= =?us-ascii?Q?cpNVrgJjYoQU+vpdDTcZYee0F3wCfN4=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 3caa8edf-4c9f-4333-ec0b-08de7b7caea8 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:17.1339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b6msrNxoeG6hHs9F0k3SMBtX527ozY7FNbVtJ59HnfkAdYrSCa8vRlB90x92RcLX13Korvcr026awm/fmHjZpaoA8ehuQVfWnv4JCazZCEM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Stop programming digital gain in the common register sequence and expose it= as a V4L2_CID_DIGITAL_GAIN control. Initialize the new control and handle writ= es in the ctrl callback. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index b1d9eaa473e4..a9a8000a8154 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -129,7 +129,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { OS05B10_REG_PLL_CTRL_25, 0x3b }, { OS05B10_REG_MIPI_SC_CTRL, 0x72 }, { OS05B10_REG_MIPI_SC_CTRL_1, 0x01 }, - { OS05B10_REG_DIGITAL_GAIN, 0x0400 }, { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, { OS05B10_REG_DIGITAL_GAIN_SHORT, 0x0400 }, { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, @@ -550,6 +549,10 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) ret =3D cci_write(os05b10->cci, OS05B10_REG_ANALOG_GAIN, ctrl->val, NULL); break; + case V4L2_CID_DIGITAL_GAIN: + ret =3D cci_write(os05b10->cci, OS05B10_REG_DIGITAL_GAIN, + ctrl->val, NULL); + break; case V4L2_CID_EXPOSURE: ret =3D cci_write(os05b10->cci, OS05B10_REG_EXPOSURE, ctrl->val, NULL); @@ -926,7 +929,7 @@ static int os05b10_init_controls(struct os05b10 *os05b1= 0) int ret; =20 ctrl_hdlr =3D &os05b10->handler; - v4l2_ctrl_handler_init(ctrl_hdlr, 8); + v4l2_ctrl_handler_init(ctrl_hdlr, 9); =20 pixel_rate =3D os05b10_pixel_rate(os05b10, mode); v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE, @@ -968,6 +971,10 @@ static int os05b10_init_controls(struct os05b10 *os05b= 10) OS05B10_ANALOG_GAIN_STEP, OS05B10_ANALOG_GAIN_DEFAULT); =20 + v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_DIGITAL_GAIN, + OS05B10_DIGITAL_GAIN_MIN, OS05B10_DIGITAL_GAIN_MAX, + OS05B10_DIGITAL_GAIN_STEP,OS05B10_DIGITAL_GAIN_DEFAULT); + if (ctrl_hdlr->error) { ret =3D ctrl_hdlr->error; dev_err(os05b10->dev, "control init failed (%d)\n", ret); --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021120.outbound.protection.outlook.com [40.107.51.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2A62701BB; Fri, 6 Mar 2026 12:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.120 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800466; cv=fail; b=sxhayhXLtol1mfVWBkb5X4jYHy//sAHSzI8ITzKOzQ/NcIs239XB4EUtcIejnhhERrs2YmJ1aMUuRuNUnU/eIAP0otg3hDEYqJeTPSkoRf6NO9foCR1BqikBzW7PaPBJZvUr/aqDJWK0jRDiK67tPyeiGqR3GHhpU6bwSymj//A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800466; c=relaxed/simple; bh=RDsji2ddP0lBsHg6K/gojwC0OywIRWNua6l4ruNuN/M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=TWizsrsspgCDxFzanHNlOE/Kbf8fFnF7wAIfyQHrW0gaqY2sIhLaHSZMg9HIv9/IgHhaYRdDsUHnqnrAm2merIKLxOYm3l/m/psq09Df5HZchBpnUQ2RG73Zvtp8bytuUt5fCSrOeGE1EPTUQ/bel0NPhF9sq3dbB7Jb5SYj41I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=Q9Gk5Zt9; arc=fail smtp.client-ip=40.107.51.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="Q9Gk5Zt9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HThI1J+gcUbrvfM7E8FBtUJ1PFuYbHYYg7oNB/ovtZAnQNtafLNFaUHuoJMDUThbfrcswqLKdF6iIHnw64N5JsdEgjxvUlDQDj6YcVdJ+DdbO9If/T5xUzEeRSlNFub0VLwVt1TtOrKJh6/ZTwqBIQ9FYkheqDaZyU3bH541IbKDYCTRyzeg4irE5GYC47rlaf9WgxGQBSebL/y8wcStx5I/UolZy1p0DZR3nDp9Ky568ljl+ocrIu8O6fEXDOGXTLfdxhJxwCtwwCsXRcrI4ulGLysVAKc91X1LqTKvA4ttBwbLUGvqcP/mWV4Pmupd4p6cVr83yvwXfHo3u4gC1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9vE4NENhHcobocm62QdQ9zd0bcsLtTJZJ/HI8JGG0vs=; b=mAytMqGPCxmJNN4NFwSmeNWq9VNIq81DXERVcLMuOgRhuOh/8bxYObtTEU519Zn36GsR64XrFMzIGwIfHacaLqFUV6kYeMOYwSwpbbkBW5PEltMrsIJRmd155fMw0cXGawZLwe4y/uJ32sXUF6eRdFIKCxpg4Rm5pYZZ0eii3Nl4mXKwYa0cRZllVNBOTOVlFdVggyH5wl+xVLl/JCrEDc/Se2Cv6Yo9ks8Ub4GYAN9dfxMfhUXNMpsFzIA1eZHTQnji3aJFoStf9cH9AZEwvkkolm7C29wILU5ZYYh9YIA+DFCzA8D/Hx+ygBb8zR0m+19P0mUQEBTJRmeJaVkd1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9vE4NENhHcobocm62QdQ9zd0bcsLtTJZJ/HI8JGG0vs=; b=Q9Gk5Zt9cmVdjNC7wreLfdl1NQLDyZjAAknUIk51Wj/BL6FVa0B8PdbzJKoQIIz2W1P73nUV+EWz3gX42s+OObLSUKqkmiKXcPiFIzfKOKU4/Ntbirx5RiqIOcI7RbCfvDrCGNFKDS9mji0tYQ3IkfxE/+llNkKqyGKpvmOvBZmjyo7Z0EuqyuuIUTrl3xAneC5si+iZz48BWYJXxn+1X0IPH/Ge3QR/x1qaizarn0Nxp30WHXXmsHrU6BrU04FRm7Z6Kc2eC5m3sEbrS6p1kFqvv1WN7ENlLKJ9zIdYcKSg74z0o34ma+bWuhd75BV46neKdKi19jVxCDPA6rAsDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:21 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:20 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/13] media: i2c: os05b10: Add H/V flip support Date: Fri, 6 Mar 2026 18:02:55 +0530 Message-Id: <20260306123304.76722-6-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 055eb9fe-bb26-4026-eb38-08de7b7cb0ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: JJ671YUMLDSH1ntwsx1BVWssF7yf+nxzp+3mOhj5fMI0wDr72al59qDw+EoAD8pKflLVdsfm1FlEf44CZcY5YqQbEXb3QpDMAxcIQhvt3sAFKjkXqTjjqwt42NS1z8PSeh3ET0bIFMeXPuP1splylsidOhOD78grBZWOCL2mOJ5ATc+EMZdIEMmIp2InMhoHbWRFLYStAUlmKO2wAaPrnArOIfcENwtC16KciBbqTf63KbkF2R6SuN3t3707CrAw3TJloIgxouHylHEdbwqWYgiWaK7NkiKIQGIap5IooNdS1sm/LT9TyaB3oQmf1yiT8FDjElMmAnU0pTEzCqBnTTgKfzEratRepNCIGGWKpGlibtVdz4gFSAsAN7m2ncg7hh1WoyHEwvyHllu6UfDfxLAfeQVFA4hDQA6vhARojqvCa7Qb017dt5fHKN1vCn0JXpQD90RjiB3DUYS83AZN3LJf7CSpCBuflkXNkpt42KWewj8B0KvAd1yO5jYqQR/rO1b/oo/lQkEUNac/HQZYw+9FmqzsP0t53DReKqo5K7cgfi3JWitaKwEX52p0g+zacfxiImQ81HLWEJQP7Cuoyucv6RfR+XeDe5+wCcCq/Dc5QHDu+udUbKoiPTYaCsYFCdiAffGL6RUxGwzt9AFZ7iq3z3BeIIEzz52++2UKGqpa+BdO/bV6gZs6IcpUETAO5sgmJKvdMdaaMTefqv0zz2173VtKcYzu3l9FQDXCXOTqA3KV2H6SUmHiZsTtEuBCUcNMfynbTfBGVcHX4pHJ/cPj+RSNZAY8a25AJkTwLyk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3zpWD7MYscZl2ETUGcXKli8ngPpffPNul/q9lGtfBcdj7qWiQAM2oNhV7gqm?= =?us-ascii?Q?WrQobC+VpuCaGrGcfU1T1iqu1bbP/hCAXfv8nwEvf51aeog2hP95JUa6fmpM?= =?us-ascii?Q?87AFcuw01dawTknpO2AHtwzb0nxVF7GaYQCiZrZoc/9MXShG52tKZKMf9iLn?= =?us-ascii?Q?gzr7zN7qEVC02i8XSuyO0UQCS9oCfNak6lz/xEXmtrYCdUHykfaEijW0e1dt?= =?us-ascii?Q?ZTU/TTpWMnd6Z7Hrn9pRciLJgMMIXW3gbku9KVbdCLinyp/uuLkHfB4EcxAh?= =?us-ascii?Q?HKJowVmQQsOl317dafF3rxl28EtbI2HKr1to1OioXquVqsnf5jMpimxPo3AM?= =?us-ascii?Q?HV05DFIfzkZNrrS4YNd4KluyYqJ6tX0gdE6lju56YbqtMhl/00rBRAqjpgOX?= =?us-ascii?Q?8dqCwb9Kk1hrg/mLbWkRU2OHUqgK4RTaHuRLF7an5RfmG8VBgfrkD4/pFhRn?= =?us-ascii?Q?XoryCIeMbpvVSnOCITyOtSCcmrMTH5KJSiMa0xSKsbeUT9ubPnB0pIb3B01a?= =?us-ascii?Q?FzLw74UggP5tdXw7Faf6VLlYncYrJ7Wgg1V4HTZLdEXWm9hsm8MehFb7ipF4?= =?us-ascii?Q?ECeeFwdEA6zAXFDF6AkbB9KTrzZWxGz7lwdbj0rGrd7ZRcFroSwvy7pdWhK3?= =?us-ascii?Q?PlH9vpIuiOdrnXTAwb6Juxu5yLcJufgoGTdtc2gLrAIdNky18cm8qULQCPOr?= =?us-ascii?Q?j5dJRbZbL+SI3P+e8Gh7Oe9qs6CSuJXmCJUXAAjRQPYDYawSOQCJTGTJd0sj?= =?us-ascii?Q?Ut+L57ie5Rm1+KalCha+7pjiPSSlQ1RUImf91wc8Rp+EFUX8uYOAqfvsEx/F?= =?us-ascii?Q?JVnLFAAfgmy46q/fyflbAnquGV1zilX60O3RriBwtCO2SSqmJ8PRjtELJaH0?= =?us-ascii?Q?jtenPJv8HTIHguIxRQr5+Iv+KsXLBrp+ViXpPbqdlpGE2LMMfJHvwOuh8Vwb?= =?us-ascii?Q?wufwMNAHxF787/gKlTemcqLu39y8QuO9zS9rpNEwmqJSj0/H/rT0EYw3qdRF?= =?us-ascii?Q?OM8fLjp7xf/E11CnaAKDnDpiLhgYBVWASdVnhmd8BZFBF0eXw9IcyAA31fWP?= =?us-ascii?Q?O6CaOelek8AVGTP5ENXucZzTw+r0EyeP5rYO/q2jW4EY5cFXrEMaZqrP2XPf?= =?us-ascii?Q?XGcVFS29smgUYACstUp4wAwBoCfqYZVvVCxZ8FyZIS+lvVBVeM8Yvle7AkmE?= =?us-ascii?Q?B3QqAbd/F1bHjhZe049dEJOYbKq7fFuDItLjfUkJIfWCiWNEut6qbk0DGJ56?= =?us-ascii?Q?o/6MBVhkHf8z5r+rAqoyarJgCWuqD1T+QlYOfxiPukot7T23y25/2LJT6qmw?= =?us-ascii?Q?xDbtJCZ2CjiOscWi5jxURtyAYiqATeiREG5K6OktcqVNmmYlZjX1R+Qex3tY?= =?us-ascii?Q?nepdCm8M05QEvjyV8jTASKG/e4v+BZf3RrDUJKj3yHNNFzAkD543D9QtegfC?= =?us-ascii?Q?KGKUl6wMmTLOsrlSW++7aKWKIxjevAL+XVwcPLtLPSE8wHZQsTuTBOt8rF7J?= =?us-ascii?Q?gPvHCyJYmDGDn/ttrqla/N0yJJtYvyHaXYAfTFeXB73+Q1mDwvTh7r5n8CW8?= =?us-ascii?Q?tTHF3WxMyCqMCamn9FPrI558DFwojWC95nKsYhiq3AGCrYErmGYcd1IVNIYc?= =?us-ascii?Q?mn2/cpZP1UVyE9Obkxm0WUSWEWADYKG+Xbxc7jsmatZY6kCUqkOkpeqGoaPt?= =?us-ascii?Q?O3zQ2DkYsl/PCxTbgbe2dv5w1jQlLflyVFhX8viikVyKF9xLNszUgU29ONxP?= =?us-ascii?Q?czNdLURWmUGvjGGqP/Uaz2bgkeqGfJc=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 055eb9fe-bb26-4026-eb38-08de7b7cb0ee X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:20.9505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k4IPqWlKkVhicBeRc5ZQ+V5uIl/yxxLmHn+0KQccSDj/4CLxJ5mtQsempbmgPwPc6lALvJg1b8bmjEI3OwQEAs2yTwReq4adNloEHgJpcSo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Add HFLIP and VFLIP controls, lock them while streaming, and update the reported Bayer format based on the flip state. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 58 ++++++++++++++++++++++++++++++++++--- 1 file changed, 54 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index a9a8000a8154..009097a00eff 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -96,6 +96,10 @@ #define OS05B10_MIRROR BIT(3) #define OS05B10_FLIP GENMASK(5, 4) =20 +#define OS05B10_REG_ANALOG_FLIP CCI_REG8(0x3716) +#define OS05B10_FLIP_ENABLE 0x04 +#define OS05B10_FLIP_DISABLE 0x24 + #define OS05B10_REG_FORMAT2 CCI_REG8(0x3821) #define OS05B10_HDR_ENABLE 0x04 =20 @@ -232,7 +236,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x370f), 0x1c }, { CCI_REG8(0x3710), 0x00 }, { CCI_REG8(0x3713), 0x00 }, - { CCI_REG8(0x3716), 0x24 }, { CCI_REG8(0x371a), 0x1e }, { CCI_REG8(0x3724), 0x09 }, { CCI_REG8(0x3725), 0xb2 }, @@ -466,6 +469,8 @@ struct os05b10 { struct v4l2_ctrl *vblank; struct v4l2_ctrl *gain; struct v4l2_ctrl *exposure; + struct v4l2_ctrl *vflip; + struct v4l2_ctrl *hflip; =20 u32 link_freq_index; u32 data_lanes; @@ -514,6 +519,18 @@ static inline struct os05b10 *to_os05b10(struct v4l2_s= ubdev *sd) return container_of_const(sd, struct os05b10, sd); }; =20 +static u32 os05b10_get_format_code(struct os05b10 *os05b10) +{ + static const u32 codes[2][2] =3D { + { MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SGBRG10_1X10, = }, + { MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10, = }, + }; + + u32 code =3D codes[os05b10->vflip->val][os05b10->hflip->val]; + + return code; +} + static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) { struct os05b10 *os05b10 =3D container_of_const(ctrl->handler, @@ -557,6 +574,20 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) ret =3D cci_write(os05b10->cci, OS05B10_REG_EXPOSURE, ctrl->val, NULL); break; + case V4L2_CID_HFLIP: + case V4L2_CID_VFLIP: + ret =3D cci_update_bits(os05b10->cci, OS05B10_REG_FORMAT1, + GENMASK(5,3), os05b10->hflip->val << 3 | + os05b10->vflip->val << 5 | + os05b10->vflip->val << 4, NULL); + if (ret) + return ret; + + ret =3D cci_write(os05b10->cci, OS05B10_REG_ANALOG_FLIP, + (os05b10->vflip->val =3D=3D1) ? + OS05B10_FLIP_ENABLE : OS05B10_FLIP_DISABLE, + NULL); + break; default: ret =3D -EINVAL; break; @@ -571,10 +602,12 @@ static int os05b10_enum_mbus_code(struct v4l2_subdev = *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_mbus_code_enum *code) { + struct os05b10 *os05b10 =3D to_os05b10(sd); + if (code->index >=3D ARRAY_SIZE(os05b10_mbus_codes)) return -EINVAL; =20 - code->code =3D os05b10_mbus_codes[code->index]; + code->code =3D os05b10_get_format_code(os05b10); =20 return 0; } @@ -713,6 +746,9 @@ static int os05b10_enable_streams(struct v4l2_subdev *s= d, if (ret) goto err_rpm_put; =20 + __v4l2_ctrl_grab(os05b10->vflip, true); + __v4l2_ctrl_grab(os05b10->hflip, true); + return 0; =20 err_rpm_put: @@ -733,6 +769,9 @@ static int os05b10_disable_streams(struct v4l2_subdev *= sd, if (ret) dev_err(os05b10->dev, "failed to set stream off\n"); =20 + __v4l2_ctrl_grab(os05b10->vflip, false); + __v4l2_ctrl_grab(os05b10->hflip, false); + pm_runtime_put(os05b10->dev); =20 return 0; @@ -741,6 +780,7 @@ static int os05b10_disable_streams(struct v4l2_subdev *= sd, static int os05b10_init_state(struct v4l2_subdev *sd, struct v4l2_subdev_state *state) { + struct os05b10 *os05b10 =3D to_os05b10(sd); struct v4l2_mbus_framefmt *format; const struct os05b10_mode *mode; =20 @@ -748,7 +788,7 @@ static int os05b10_init_state(struct v4l2_subdev *sd, format =3D v4l2_subdev_state_get_format(state, 0); =20 mode =3D &supported_modes_10bit[0]; - format->code =3D MEDIA_BUS_FMT_SBGGR10_1X10; + format->code =3D os05b10_get_format_code(os05b10); =20 /* Update image pad formate */ format->width =3D mode->width; @@ -929,7 +969,7 @@ static int os05b10_init_controls(struct os05b10 *os05b1= 0) int ret; =20 ctrl_hdlr =3D &os05b10->handler; - v4l2_ctrl_handler_init(ctrl_hdlr, 9); + v4l2_ctrl_handler_init(ctrl_hdlr, 11); =20 pixel_rate =3D os05b10_pixel_rate(os05b10, mode); v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE, @@ -975,6 +1015,16 @@ static int os05b10_init_controls(struct os05b10 *os05= b10) OS05B10_DIGITAL_GAIN_MIN, OS05B10_DIGITAL_GAIN_MAX, OS05B10_DIGITAL_GAIN_STEP,OS05B10_DIGITAL_GAIN_DEFAULT); =20 + os05b10->hflip =3D v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, + V4L2_CID_HFLIP, 0, 1, 1, 0); + if (os05b10->hflip) + os05b10->hflip->flags |=3D V4L2_CTRL_FLAG_MODIFY_LAYOUT; + + os05b10->vflip =3D v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, + V4L2_CID_VFLIP, 0, 1, 1, 0); + if (os05b10->vflip) + os05b10->vflip->flags |=3D V4L2_CTRL_FLAG_MODIFY_LAYOUT; + if (ctrl_hdlr->error) { ret =3D ctrl_hdlr->error; dev_err(os05b10->dev, "control init failed (%d)\n", ret); --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021120.outbound.protection.outlook.com [40.107.51.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C3527F736; Fri, 6 Mar 2026 12:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.120 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800469; cv=fail; b=Iqa6ItSZCYJAqX3QbioTtlpuNO2eXJuwVdClkdD1f72gVG4CGkRZZRt1/B17wpbw6YvrDAqr2MMqQCdjbvx93uM2i1ariHBXBfHQQI1POZIdOv9VrYUKVSwwqdCxnBLPgSK8FlPiE8GziSFqTx2oV270V7KB4gRNIbYSyfD7BkA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800469; c=relaxed/simple; bh=T+ZIir6sWJVhdK6ctRdis9c6RPX/1JBimi73zaR/z7E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=h9FyBNLbEJ3FiHwysHYNZesrBCRcj8rAlZtBS6d822Z0DjAkENT1zyx3uTcD+35lq1Pp1viP5jGtuEi59gxImrSyRQvSHslrW23VyYCsEVhhW5VUQnaixkAUnanRUzUrFwy49JVjIQRfPlDXGImSomV09JT5ClltzryhO1BiFRw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=PjbmeZ6M; arc=fail smtp.client-ip=40.107.51.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="PjbmeZ6M" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l9E/bfMzVl50Rao0bMz2wjkpY/QsHfvVOVluEWMa1SaeiykU6zcZOOwLTyAU/H/WoX/xBpnTCkNkkCuFmkX794KIVTwlqgjkpDizOyX3QhQPPVGjHu0SH69EiMUvt7bsgj1qTIREtSBA4S0pYKDetef56mH72OLCWjX8g9tcsIcV+2hLpZtW5SC/bm29hhTL3VJtXLOlIZ/MrTbAC5oS+rIY6rq65iamE+opmfEd7ftf8jrGZtX16xboSuCfh1pjmKfQMjl6aCzBbnXPrnhqxIXrmJ0Y2TIFX87J15TE//xfIwv8GuXMXuGpLdZf9WBjuBUgALlAdAWecWa15R2PKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0RqVKv6zGDQg75ZFHFdTurZUD0GC+WMbokWEkIJIMNA=; b=GOi4iLL/VYIBkIUZcgqsYqZn5zIWc/Kh2mYoCpLb9P9YQvw5FQbl8NfL3FSFgKiZyTr2LVzeEl6CH/K4BfWvUHuhXtKT9bbpoAtcuKhsZxcDj9klxYAttTlyC5KoHSDaI4J3g3Lxv5W2hIY6ZsX0ee34voPM88/qLhZ54b0xYCoZaZwidQsctste/K/cPrCN4fRS7UE8O5lowe0lvK7Ye8cbgTBQBzFNBzs+9lU+iZXv3XD3L3L0mJslgzE5enn1oDbcOYSBOACboK7K8sikMD0Ss2P4pXC8JyhweWbsmI59HJTGeJpTYCrBZdbYiILNggcVELaiP5pmhBkUa+svdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0RqVKv6zGDQg75ZFHFdTurZUD0GC+WMbokWEkIJIMNA=; b=PjbmeZ6MUj99p9gcqJ0tZTQk+a5snpNUOtpC54Flw2GG8pNnRs5YYL/hlrtMP/aw2ByHhVH1mFi17V4eUbhJzK2GZPt0pqt99+6bW+6dbVkChKKQyocxgu614gh9h9VXdJHwWBYtIdND1GuV8hJBaRY7kEkC/6jbS+86odbkdzyrXjiScf9g6f6IJEoclafEdg+sGSY2DSL48m/tmAVQNK5dSOvLx/egX7Zv/cUSzTXEwhUHEUCusZWEmtFIsO5RJsAJ5Pm91j92CTQKIDtfU9dVJHARNAq/34byyuYmAzFV01O3sVYJ9eZLrOzU/gRh3DYxcjb1vmaXyVUUrsC64Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:24 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:24 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/13] media: i2c: os05b10: Add test pattern options Date: Fri, 6 Mar 2026 18:02:56 +0530 Message-Id: <20260306123304.76722-7-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 047ad3c0-acc3-4f20-0b24-08de7b7cb31a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: HOpigP2d5burOlprCL/VvRbZmjME0/6L+DsyLUIUe9MQv2U58agYbjtWMFO0rw62IeYJ5jliJnIrnK5taTantksoAuj2MsYgAtTAOZ4LhBvJaE873wpdYq1xS8JJjOShkKBsppo9VU+CGBucHBW/SShEKFutcbGFs1O533g+FRJqxi+PwefMkR7hRQbIrLZSJmEY8GCIk/EnrrGP/NhymQAjWwsf7L8k8VB4S9SddXtXj4i0Go7s8QPVq/zZGtWfthg/Fa6gvT571nfGCfwpFTihqBW1QM3nwMCP+lAcQyaVvUemh2RqtHQGVWzNe/LkZvkMsltwYnYrVjRJ0liPE5aUqx1eDjoimb3mdY5hI/NEu9Crp2+S0UgAD0JXE0SaHuyD4K0oqkV3A7tv2Z1ceUYKx9gXnW+htDvw4HVccgRxtJySJYigjI/B4RvABTqgwnXB0WmwsyvFOVWgvnIBaUPRJRSIzuT9ghCfvpDl4wktVsFPZFaWVDmdB4AvndwLY/go3W9cBj7mncW1vmhs3VSKeq/RQt4d3mVICbYcz+0ClXxoJb8sy6wxwkSBWT0KMAoBZry40I4Vy2W6H+BGGLqwDKMp76ZdtpPVLh/9t074HLXz5z9vGDQUoRNi/60Ot0AsnNEVFbUK27+qbDUBp0IxNmDRPo5NoZ4alQmbTCGpVTnL7YqvWDn2gC6qare7RWaOTC0c7WN9RkgKwGCsAzU1iPxIFzyMweOSgRW8Zc2zRy1oTdkPjC5i1CvDM5qCNGbrnJM+Hh/5r947dk/EGMkqVhlB+3VlBuv+5upHNhs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bn3sK+DkIEAZ7+uIPuVLnLdzuHhKm3fleWo/2J7emrmo6ZhgQBLMJCbZsY+Z?= =?us-ascii?Q?ORQuCh3i6jiVynMQBg2pncqdH4FX7DWfhT3R3gV93VGzlcsQd7Gm6mH4u6ls?= =?us-ascii?Q?iE4skaWzzzKTZYs/a8IF7o+x7jpEtYJvlGkYkK+TQhDdAPGdCoQnMqAvDpVJ?= =?us-ascii?Q?0YNB31P1mb0KDY/M2OeziJ4LnOz/MH2hsNkM/rTyv6YMyPlHW3I11024kAi3?= =?us-ascii?Q?FTMgzjr/OIXgshuqdFUmsa7mnPSeNlFdPf6Ly/7slu6yNkLnvZyfWs4vgZtu?= =?us-ascii?Q?KTugJTuyW1NlJkZrmQkITlfAmtcytuq2j2pTXZhfmuxB6Vgz/WzfcR8nPeLw?= =?us-ascii?Q?QFQY67c+Efc3SJGCxCVJZYFExdl1uOI/D1ij+MnoFln/nf1XPWOPxHSSkiWt?= =?us-ascii?Q?A2seKBBVU9p5Ho0mZzdvWH9Vl2IrxuABW1adHfIiI9756DBa7PRs3AflGSuy?= =?us-ascii?Q?RO/ScUKYthxUVcciNBBaIOsXThXMK3CluO1u7KbDAl52TVNuMRrSra1Tq6IB?= =?us-ascii?Q?B9gnC51jCj5m73agucsRCLA+w1iTzLTlShZhp6EFn7braTq3Lj1DmGodJfyB?= =?us-ascii?Q?4ZztVB+a4r8wXQHg+uKbra6s5NTCC67yqbqWErcpBsBQ1ryfVAgwGnt3rz8X?= =?us-ascii?Q?oRKHuhj/u10/U3BqhzIqOHbaKmoLsEqDwTFnnJhuC8hLmVKdf6ktGSY+FUXT?= =?us-ascii?Q?BDvr6AeMn8slnY9CR75zDaYaNMAWR50kdksXYL/q/NMPUF1SEcXK0bD+wwLx?= =?us-ascii?Q?d1Z8crcuQ7P4xU05jLGH6KtIWsAE7B4Cdmh3QbGoNx1Ny8Jy4Meu+TZUfyBD?= =?us-ascii?Q?AeHKkI5tGWU4tRkJj9d0EcJ0N+dCxWrfxNspbmm1RBec9NZiU+7O4CpZ+zLY?= =?us-ascii?Q?wXo+dqs6nrPIuOaukTpVxirFOkvOAX12gDogLIAaMlpMX+sESnERpCxd6uKo?= =?us-ascii?Q?eVqMZaC6OaT366kU8BHC1JOlFI9WZI7zAakOnwaLm44rTJk4KG4WwELvgcuy?= =?us-ascii?Q?Y/TscrGxs9qEbXnpUMdWZnEHqdJKSBDQ+1k1Wa9HgJ+VFx0u66gfEKaNTWvE?= =?us-ascii?Q?e2S+1qjq1jYkHsKEQNCJRWK7Nkb4DlWXbT8OcFTeCWJLFCNvSZppT2DcG4tD?= =?us-ascii?Q?ShMlHt/z6pwXZMZy+FIg7KUucJ1yDX01ybuSFUgjUcvDV0tWG6QWuSXrTjYN?= =?us-ascii?Q?Tr9N2d0+q19MM/ERV4bvGq7m0fV05EsbQlk/ztFHOWTIKytmKlM/xZv9v/IW?= =?us-ascii?Q?qASBbILltpWlISGqrspH74Q20MlCQS6zx7csYyykHf88uDVoaq3OXjTsSOfw?= =?us-ascii?Q?CtihY6zns6PUGPQFmn0JGWJU3Dm8aeZyjYmWpMT4RF8ZejOaUEjKzpKeU7ra?= =?us-ascii?Q?MUClBul5Tm80BMT+HLdg5ceFiQMf3nQ2WQayDisuYS1CrVpzUI0QxAIZNuMS?= =?us-ascii?Q?kQDSE4j0k2IJp0LinwK+JA1GgFr648l5sPr98bAlXv1WuSZ6Rmp92ztFHKr2?= =?us-ascii?Q?SX826rAk2V0fbIOdJV9AayRHR3PW0GW4TZLvOg5QQzu1w/fLGSJEu/IpWmuv?= =?us-ascii?Q?1chl40t714IDobho60Gv7LbANw37l9De3lWLRC6ieA9d2ryQTzqsdlyw35Mq?= =?us-ascii?Q?3+HnaVMuM2j5H2U0dPxmJMxw8zFENF9XZtqFXQiyymRerArL08ijA3wspknF?= =?us-ascii?Q?+wq2Yfkxy7gijUq63Zf9IUv4PjEXrD+nC0RrJY+y+agLyRMNVqUHohTxAW+n?= =?us-ascii?Q?Fh+iJon5JuwCgb1Oi52mbqgWkoqm1Wo=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 047ad3c0-acc3-4f20-0b24-08de7b7cb31a X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:24.6095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lHwlBcB3OMrF2FzFD+3NBN+Nc4SXAtSMPDUT98LmpemQuwpLV+1LMZfs2B0Ytgv90/B6ZEpIM5UFWdgcdIsmXK82Z4W5WW8iLiaOAKvNJzc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Add V4L2_CID_TEST_PATTERN support with multiple sensor test-pattern modes and program them via register 0x5080. Drop the fixed 0x5080 setting from the common register sequence so the pattern is selected only through the contro= l. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 55 +++++++++++++++++++++++++++++++++++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 009097a00eff..fbc191e1d505 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -103,6 +103,17 @@ #define OS05B10_REG_FORMAT2 CCI_REG8(0x3821) #define OS05B10_HDR_ENABLE 0x04 =20 +#define OS05B10_REG_PRE_ISP_20_0 CCI_REG8(0x5080) +#define OS05B10_DISABLED 0x00 +#define OS05B10_COLOR_BAR_1 0x80 +#define OS05B10_COLOR_BAR_2 0x84 +#define OS05B10_COLOR_BAR_3 0x88 +#define OS05B10_COLOR_BAR_4 0x8c +#define OS05B10_COLOR_SQUARE 0x82 +#define OS05B10_BW_SQUARE 0x92 +#define OS05B10_TRANSPARENT_EFFECT 0xa0 +#define OS05B10_ROLLING_BAR_EFFECT 0xc0 + #define OS05B10_LINK_FREQ_600MHZ (600 * HZ_PER_MHZ) =20 static const struct v4l2_rect os05b10_native_area =3D { @@ -396,7 +407,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { CCI_REG8(0x5004), 0x00 }, { CCI_REG8(0x5005), 0x0e }, { CCI_REG8(0x5036), 0x00 }, - { CCI_REG8(0x5080), 0x04 }, { CCI_REG8(0x5082), 0x00 }, { CCI_REG8(0x5180), 0x00 }, { CCI_REG8(0x5181), 0x10 }, @@ -514,6 +524,30 @@ static const u32 os05b10_mbus_codes[] =3D { MEDIA_BUS_FMT_SBGGR10_1X10, }; =20 +static const char * const os05b10_test_pattern_menu[] =3D { + "Disabled", + "colour bar type 1", + "colour bar type 2", + "colour bar type 3", + "colour bar type 4", + "color square", + "black-white square", + "transparent effect", + "rolling bar effect", +}; + +static const int os05b10_tp_val[] =3D { + OS05B10_DISABLED, + OS05B10_COLOR_BAR_1, + OS05B10_COLOR_BAR_2, + OS05B10_COLOR_BAR_3, + OS05B10_COLOR_BAR_4, + OS05B10_COLOR_SQUARE, + OS05B10_BW_SQUARE, + OS05B10_TRANSPARENT_EFFECT, + OS05B10_ROLLING_BAR_EFFECT, +}; + static inline struct os05b10 *to_os05b10(struct v4l2_subdev *sd) { return container_of_const(sd, struct os05b10, sd); @@ -531,6 +565,15 @@ static u32 os05b10_get_format_code(struct os05b10 *os0= 5b10) return code; } =20 +static int os05b10_update_test_pattern(struct os05b10 *os05b10, u32 patter= n) +{ + if (pattern >=3D ARRAY_SIZE(os05b10_test_pattern_menu)) + return -EINVAL; + + return cci_write(os05b10->cci, OS05B10_REG_PRE_ISP_20_0, + os05b10_tp_val[pattern], NULL); +} + static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) { struct os05b10 *os05b10 =3D container_of_const(ctrl->handler, @@ -588,6 +631,9 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) OS05B10_FLIP_ENABLE : OS05B10_FLIP_DISABLE, NULL); break; + case V4L2_CID_TEST_PATTERN: + ret =3D os05b10_update_test_pattern(os05b10, ctrl->val); + break; default: ret =3D -EINVAL; break; @@ -969,7 +1015,7 @@ static int os05b10_init_controls(struct os05b10 *os05b= 10) int ret; =20 ctrl_hdlr =3D &os05b10->handler; - v4l2_ctrl_handler_init(ctrl_hdlr, 11); + v4l2_ctrl_handler_init(ctrl_hdlr, 12); =20 pixel_rate =3D os05b10_pixel_rate(os05b10, mode); v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE, @@ -1025,6 +1071,11 @@ static int os05b10_init_controls(struct os05b10 *os0= 5b10) if (os05b10->vflip) os05b10->vflip->flags |=3D V4L2_CTRL_FLAG_MODIFY_LAYOUT; =20 + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &os05b10_ctrl_ops, + V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(os05b10_test_pattern_menu) - 1, + 0, 0, os05b10_test_pattern_menu); + if (ctrl_hdlr->error) { ret =3D ctrl_hdlr->error; dev_err(os05b10->dev, "control init failed (%d)\n", ret); --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021105.outbound.protection.outlook.com [40.107.51.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0AC257845; Fri, 6 Mar 2026 12:34:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800476; cv=fail; b=Z40rVv22DPNj7yBFba2ZzqqPxjWtv8F/f9Shav4MdNhJQDexnX9kehUXZ3Fm3G4IKESyi6B6yorIldfbjPENXL4CxPNeNrzJXea2myP50wOxrQmEfqvGbELDwjpHDChJ4ubrm511btMG1lVn1aJQ8DpaaCxPdLwhcX0Lew2MyDc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800476; c=relaxed/simple; bh=/Pv/+7QlGge5YTSovO2InzgRYHuctrPXq1/IWTwfFm4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=opJgIWHu3TRp41tbRtEjKAcHZvI7xKKoD6+iIAOrY4AxDP6mBUnFg6aZxJIVbtkfrwYNp+U0H1zsLvjrqqT973jdy6gGc3VhyRsOGH+dcu4Iw5qZ7Zu+A1GSRo9vwx1D5+1eO0KREr8oT+n9W47dAooZfK1C6VrWZIRbHFr4DFg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=ZUM9jTBz; arc=fail smtp.client-ip=40.107.51.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="ZUM9jTBz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=auJmnwm8UfdqIK4epnxfXqgL0PLIFSLmTeiiT7w3Q+Fyhmos7FXbM+UZfN4BFSLMVgfzPbuhI/xWwPGql0qdO+HStJTA1TVPNeqEQxm5PIaPJrJ4CoRdrJsvWjrcEgrvfqB5abRJT87i2pRVQGGYjjwQvH7ToPRaFeNDR0pTcVXl8VOwvfsH5F0JBCN148q/uB7DsZ+5dFPIalRBMttOTPl/CcN/reTgbo7H0mCgGAYEJ2dY1cMEOgf75fwyOOpKYifqV59U3s6rPc9w16VRK4WBSV72wVMOp/yKUgqLOwn8weWADgvWBTR2ST0hual1M+ijOylwuOEdl/QtScDMOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c/te+pYpqskJAfmFO5hVBf6JsmHy/zpu/x/+4H2K3JQ=; b=qTm94a7TBf1QPa93UYETpcVHcVqDZqnJWn8dTJOhL+uDlpczcioOvc8p1JroyPskf18wUp0nLJZY3TlxSQAe9tzOrbyg1HBLCT9EfZpQHDLl0xQTj+iQeYM87bMmyhGpII1KCp8Fto/mbkSHJuCz6sRTMNSczaoBJlA6l4ofLwOYckhaICC/X5H6L/SDc4KDnxgG0ZZT/FmbUTtrAGFNhtmxY+LK85uB3z1BmPDjCNwBFFO34eeD3RKUMYoRPSzBs1YhPspHsyA3gTHXfUoewOYg9zsC3aNSuoJrj2/hBh/jTVs9gbRfJg6dR+ItQvPclPyqmgGgr5FP0082oGBaQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c/te+pYpqskJAfmFO5hVBf6JsmHy/zpu/x/+4H2K3JQ=; b=ZUM9jTBzoVki8q7jfx0o81vkhURCXQobRNPB9o3uyLdGRYCa/zaZxhuxnTCgoCDW+jA3o2AVDONtZDL6xHPMKE1LDHq5gibl1FUeLaipSkBQtGgbXoa8crOQRjVUj/uH7Vx7CLlpR+8RVesvQI++CR0F0j6cuwolBEYHm4OyYTLCfhIEJ/BHe1hKy5Pgvs0lTh0fMosOgCW9OWB4t6oGEMUqqLsogOdnMjiM2Pso7V9ZN4dJnNFl9q8/A6F1w1wClnKYtWMPKuRI4+VuLk4vhV98g7hMdtJOBUvgFXehPZA1L6leBrSrGr1MnddcWnBtTPCtB12ar+Evlm3gi5vOPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:28 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:28 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/13] media: i2c: os05b10: add 12-bit RAW mode support Date: Fri, 6 Mar 2026 18:02:57 +0530 Message-Id: <20260306123304.76722-8-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 36623072-009e-4b71-e752-08de7b7cb541 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: CMTeglj11gexBG58GiJkFpR4zD4Wn/SKyQ+z8SF84NTWKXAeIJQKYMKUAfvGzen4lGYXg0T+LkyyE2hDYbN+W4+nWHTbVSSHuRiBszLMA0IT223OMgcvhQnL8MfkIW/ME1hpp8NNIs3Hu28SNauq7PhiGzTaaZKtKxl8bzzXwT82m/9q0b1zlcf5/PpwJmicZM2lHE1BKHPVXyhuUUOLGJ9v1NUhZHZMahbHFa60Ua6fjUsDaxkYBnalCcJgW3A3QYSlbxyhSj7cTjv1EE1gDnc8HbfEA2WfZVFL/mkXkHC1bJssdxMBJgMNw5xLD3S8szZBX//M5+zduEjbwqJ5t6837OrFXTpIWiPRu0NT0T1oVHR3fXw5SoAjvPOLIc6YYpqxGB9LRfOVf5hvCP4NJvgHjlpxqe6VsH+m5gJmhdaMNv4LKCIcKn1ukWGoH9+HC+B76cWdWiQ9DQxIlosk1G44ryuLYfzEoeHkvYnUGxUU18abfHNxZcQpkgJOKzOcWlg/zbTFHJlWSNWGZhiYulPmbnvTnd6uOIHkEhAogXExy+q20RsMfkEZU115/GVxxHfgRvzRq/KJtcgupIwCtnl2LwpxOHgSUByhxHTCcIoW0c3cPg7+YIPa0iyEEOjHwCL9cKzqU0L3IBvmae/ZWrZTp4ITDxTN+VfR9DohzGk5sPUKds4/elPVsRh17Q1HSQu1P49yacM5PsrM0HupRwbGXz0Gr9GGFlL7dw52RiqDvaNIdKYhEoyBxk9zRZH+m7D+S+YlxsNbqEXW99bG9/37eCekX5tzGSWH33N1BFY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wuZbSEUBYBtPGiijsvbdV9vnq63m7ZuggbXNwE3T4zIzsRfE6bUijwTpHThl?= =?us-ascii?Q?lFvt0oWyHqLJPO6EDJYFIr00pTwKEC7Z5wDoGkV7+j13yAV8O7hAKYeICGXx?= =?us-ascii?Q?Y0Mh+4uiz3WPURaNz715TR8hciX3NGhJnMka6iwiaU4U6c2iYHf5WEdduN3C?= =?us-ascii?Q?x5pxBu3TDPObPU4L6gCaW8QPe0BNUKVihELwGFgUAQ9B2P30s6AA6tizEW8g?= =?us-ascii?Q?7zVP8tvhqzjF6W7HqsidOpPCHW9eXXfUPwrAi7wcxImqOYJInrpWXJnddQ8B?= =?us-ascii?Q?Jzp4e+npdWNg2WPw0+MO/wYWIG+JIS45ZLgSr66a9Nt+yP2LiaUBlsrmS9fL?= =?us-ascii?Q?XrIj95x3NRprRXoiXTpfRdhiI1jklk7vlKeQEzhj3/jXvyPTezadppwx85rY?= =?us-ascii?Q?T7LrlbBdlLUrnRU93912F/LoKCV6v76+m7s0nsyUsK5Zk06hKza1SiO7nZYB?= =?us-ascii?Q?R4GbprdCZ1eMNEhOcIQ9qDkOjyg20T0FXphsz6m7HDn9f2DuUozoSSBUGxSV?= =?us-ascii?Q?LnLLFt7uJ/2e7JVGUCBgpEl1ea+DNNP+7BSPtfaPnWDJDzdLqBVkT4ETCZ0d?= =?us-ascii?Q?9fSicybebHPhOzLfwZuRFMi0KzL3UgIx+044QYpacBwVXCpsImQAM4DccF6D?= =?us-ascii?Q?31XCgu4clfUWDawO7I+MuKWEQEM8BB6d9L4oX3THmD0wfClD90WFev5HdKJm?= =?us-ascii?Q?F1zadbGBnnwGvDBSr2Br2IHjfkKOX5LfiJiOvhJP/BnpF1hax+9jB3SX0/rA?= =?us-ascii?Q?QkWwbZMpjX9nbNE6HsTbaTpASNd8AG8YE4deL8AC3gnfR59DhcdsYlQ7h/pd?= =?us-ascii?Q?y/bBsQlnqNg+qrak9CXQ4v13dEQMbav4++A0yU8K6HyDi3RY9nDbpTCBj4Ta?= =?us-ascii?Q?juxxrDR4K8tc8EUfE9dudsXSYtHa/d/eIR4KNCH2IsptR+4MYnKG9wkh+3Nv?= =?us-ascii?Q?xJEEFtiSE695T2252PZHFcyHqEKA7FXq4iiK2e9vWGC+UKnp/ZhwwxsMuF0J?= =?us-ascii?Q?Y1yo+pDl7iIk4zbWiRN1lOdc9/8e2tX5Z+pocpNnWCy9FTe0zMGoLx995vp0?= =?us-ascii?Q?DUlOOtET48IGMpcqIA0+QBGw2LrawG4q8gCjzMQESzl/IMuPoVOxe1gok4ye?= =?us-ascii?Q?Zg40UJ5L8LvwceSKI0LJdRByRT9LE5SI3UHrqTqZLBQ/Tn2BDBq+gOrKVNhh?= =?us-ascii?Q?RVy6q7LnR3V6Xgq13Swjq6DuKayfE5ocq5NZXuuT9kn7S/0kEMkq/ynoEz2g?= =?us-ascii?Q?l6RkZ5nXPqh3cb+7gSQRbAgsKiEFLOZD/X4GT321xrqABUMdS9sNUyaSHZdv?= =?us-ascii?Q?pO8suwkBVJd4riVa3krossRlRd4G5KvdcLJRjS7M//YCd7EUS9EMzTEC/TsW?= =?us-ascii?Q?quO23Cg8XKtt5Oe/pfBIBEGaQCnNx61gGb7qwUAqAn5IFR8A9cevV6fSwT6v?= =?us-ascii?Q?takMFdOUdBclt1j97Sc3XZgKqPz/7OBv++sKXXl/SpsnpG2Sm6YEmhKCY/ro?= =?us-ascii?Q?PSWZNnIZj/lQgUpzurJOBwr9k1DsBJsC+WDf49Ju5Ql9oVN8FJ251Pa67FWQ?= =?us-ascii?Q?UxAe4gep10Edqke/GygrA/t047HdwdRUdfBUycRrdZEnmAKrOptZxlrob1C1?= =?us-ascii?Q?ewtdD0038nJ1SSILuRGahhmv9f7J8Uvb/3kAzGTkz1/th48dD0X7SWSYAA9Q?= =?us-ascii?Q?Nc66Qq99gjsJ5JBytQwTEcRlkJsPk/EFzDG4wsjeONFUfiU4YZKXdFI+sxRY?= =?us-ascii?Q?TDKh8Q9Vk7LK5z9H9hjv7L2N8f9yvO8=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 36623072-009e-4b71-e752-08de7b7cb541 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:28.2086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BWj+y+Qom8Szr+UlcD4CXIF7DvfFTAFCoiKOyFYldatE13gNFpwJcQ5ZckKKPIAg+XgHCSEVb2ScqzEaQD4Shkt7NuZ4GydjEEB+slS9TCA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Expose a 12-bit Bayer output option in the OS05B10 V4L2 sub-device driver. Add a 12-bit mode table alongside the existing 10-bit mode, extend the enumerated mbus codes to include RAW12, and select the correct mode table based on the requested mbus format in enum_frame_size and stream enable. Also move OS05B10_REG_MIPI_SC_CTRL_1 programming out of the common register list and program it at stream-on depending on the selected mode bpp (10/12). Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 97 +++++++++++++++++++++++++++++++------ 1 file changed, 81 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index fbc191e1d505..d51b7d18d28a 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -143,7 +143,6 @@ static const struct cci_reg_sequence os05b10_common_reg= s[] =3D { { OS05B10_REG_PLL_CTRL_06, 0x00 }, { OS05B10_REG_PLL_CTRL_25, 0x3b }, { OS05B10_REG_MIPI_SC_CTRL, 0x72 }, - { OS05B10_REG_MIPI_SC_CTRL_1, 0x01 }, { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, { OS05B10_REG_DIGITAL_GAIN_SHORT, 0x0400 }, { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, @@ -501,6 +500,21 @@ struct os05b10_mode { struct os05b10_reg_list reg_list; }; =20 +static const struct os05b10_mode supported_modes_12bit[] =3D { + { + .width =3D 2592, + .height =3D 1944, + .vts =3D 2007, + .hts =3D 1744, + .exp =3D 1900, + .bpp =3D 12, + .reg_list =3D { + .num_of_regs =3D ARRAY_SIZE(mode_2592_1944_regs), + .regs =3D mode_2592_1944_regs, + }, + }, +}; + static const struct os05b10_mode supported_modes_10bit[] =3D { { .width =3D 2592, @@ -522,6 +536,7 @@ static const s64 link_frequencies[] =3D { =20 static const u32 os05b10_mbus_codes[] =3D { MEDIA_BUS_FMT_SBGGR10_1X10, + MEDIA_BUS_FMT_SBGGR12_1X12, }; =20 static const char * const os05b10_test_pattern_menu[] =3D { @@ -553,12 +568,19 @@ static inline struct os05b10 *to_os05b10(struct v4l2_= subdev *sd) return container_of_const(sd, struct os05b10, sd); }; =20 -static u32 os05b10_get_format_code(struct os05b10 *os05b10) +static u32 os05b10_get_format_code(struct os05b10 *os05b10, u8 bpp) { - static const u32 codes[2][2] =3D { - { MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SGBRG10_1X10, = }, - { MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10, = }, - }; + static const u32 codes_12[2][2] =3D { + { MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SGBRG12_1X12, }, + { MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SRGGB12_1X12, }, + }; + + static const u32 codes_10[2][2] =3D { + { MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SGBRG10_1X10, }, + { MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10, }, + }; + + const u32 (*codes)[2] =3D (bpp =3D=3D 12) ? codes_12 : codes_10; =20 u32 code =3D codes[os05b10->vflip->val][os05b10->hflip->val]; =20 @@ -653,8 +675,8 @@ static int os05b10_enum_mbus_code(struct v4l2_subdev *s= d, if (code->index >=3D ARRAY_SIZE(os05b10_mbus_codes)) return -EINVAL; =20 - code->code =3D os05b10_get_format_code(os05b10); - + code->code =3D os05b10_get_format_code(os05b10, + (code->index =3D=3D 1) ? 12 : 10); return 0; } =20 @@ -683,15 +705,42 @@ static int os05b10_set_framing_limits(struct os05b10 = *os05b10, OS05B10_EXPOSURE_STEP, mode->exp); } =20 +static inline void get_mode_table(unsigned int code, + const struct os05b10_mode **mode_list, + unsigned int *num_modes) +{ + switch (code) { + case MEDIA_BUS_FMT_SBGGR12_1X12: + *mode_list =3D supported_modes_12bit; + *num_modes =3D ARRAY_SIZE(supported_modes_12bit); + break; + + case MEDIA_BUS_FMT_SBGGR10_1X10: + *mode_list =3D supported_modes_10bit; + *num_modes =3D ARRAY_SIZE(supported_modes_10bit); + break; + default: + *mode_list =3D NULL; + *num_modes =3D 0; + break; + } +} + static int os05b10_set_pad_format(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_format *fmt) { - const struct os05b10_mode *mode =3D &supported_modes_10bit[0]; struct os05b10 *os05b10 =3D to_os05b10(sd); + const struct os05b10_mode *mode_list; struct v4l2_mbus_framefmt *format; + const struct os05b10_mode *mode; + unsigned int num_modes; int ret; =20 + get_mode_table(fmt->format.code, &mode_list, &num_modes); + mode =3D v4l2_find_nearest_size(mode_list, num_modes, width, height, + fmt->format.width, fmt->format.height); + fmt->format.width =3D mode->width; fmt->format.height =3D mode->height; fmt->format.field =3D V4L2_FIELD_NONE; @@ -730,16 +779,22 @@ static int os05b10_get_selection(struct v4l2_subdev *= sd, } } =20 + static int os05b10_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_frame_size_enum *fse) { - if (fse->index >=3D ARRAY_SIZE(supported_modes_10bit)) + const struct os05b10_mode *mode_list; + unsigned int num_modes; + + get_mode_table(fse->code, &mode_list, &num_modes); + + if (fse->index >=3D num_modes) return -EINVAL; =20 - fse->min_width =3D supported_modes_10bit[fse->index].width; + fse->min_width =3D mode_list[fse->index].width; fse->max_width =3D fse->min_width; - fse->min_height =3D supported_modes_10bit[fse->index].height; + fse->min_height =3D mode_list[fse->index].height; fse->max_height =3D fse->min_height; =20 return 0; @@ -752,13 +807,15 @@ static int os05b10_enable_streams(struct v4l2_subdev = *sd, struct os05b10 *os05b10 =3D to_os05b10(sd); const struct os05b10_reg_list *reg_list; const struct v4l2_mbus_framefmt *fmt; + const struct os05b10_mode *mode_list; const struct os05b10_mode *mode; + unsigned int num_modes; int ret; =20 fmt =3D v4l2_subdev_state_get_format(state, 0); - mode =3D v4l2_find_nearest_size(supported_modes_10bit, - ARRAY_SIZE(supported_modes_10bit), width, - height, fmt->width, fmt->height); + get_mode_table(fmt->code, &mode_list, &num_modes); + mode =3D v4l2_find_nearest_size(mode_list, num_modes, width, height, + fmt->width, fmt->height); =20 ret =3D pm_runtime_resume_and_get(os05b10->dev); if (ret < 0) @@ -772,6 +829,14 @@ static int os05b10_enable_streams(struct v4l2_subdev *= sd, goto err_rpm_put; } =20 + ret =3D cci_write(os05b10->cci, OS05B10_REG_MIPI_SC_CTRL_1, + (mode->bpp =3D=3D 12) ? OS05B10_12BIT_MODE : + OS05B10_10BIT_MODE, NULL); + if (ret) { + dev_err(os05b10->dev, "failed to write pixel bit registers\n"); + goto err_rpm_put; + } + /* Write sensor mode registers */ reg_list =3D &mode->reg_list; ret =3D cci_multi_reg_write(os05b10->cci, reg_list->regs, @@ -834,7 +899,7 @@ static int os05b10_init_state(struct v4l2_subdev *sd, format =3D v4l2_subdev_state_get_format(state, 0); =20 mode =3D &supported_modes_10bit[0]; - format->code =3D os05b10_get_format_code(os05b10); + format->code =3D os05b10_get_format_code(os05b10, 10); =20 /* Update image pad formate */ format->width =3D mode->width; --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021105.outbound.protection.outlook.com [40.107.51.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9448C2848A8; Fri, 6 Mar 2026 12:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800479; cv=fail; b=H2UF+JbMAYmZ2VLuKvsGCXKoAiH5NxYLrmnd80xtTrvafIFS7xPgWeIRR34TVjer+CnUntjfgWMqlD0eh84pwdXmMJ4isP493oqkUBYYf+uHDiWNYAzRH5cX77a+P8LRKWkVzlbNjzxrLZUBht79E+hlIY8LSx9C7ZyngMlPcL0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800479; c=relaxed/simple; bh=hVmBI08svfxC13TZjWhd8MA8+eHxJfeP3uKmyjpHZGs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=fGxGfPRg5xBKb1eJ/UdpWYhVlPlTGevcWSDB1UYQxE9azjMhYBgkO2i7gvJwjtzgiROa626/K7IjClgNb3OmCZ0zo/Kr/cByo/ah0QsiT5P11OkTCW0Q74JiJK+GszyqkH8Es+09QFmLtsY0XElfRF2PCKe8/n5fdfE7HwwXauo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=L+BA5yc+; arc=fail smtp.client-ip=40.107.51.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="L+BA5yc+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uwgxhaNNG9fyrEnDqDTUIb0Y7bNxaYmrmlqfpY6Oq58XYvFto7bhUVExKalCH5fpX/9p0BaHziKmkQ2YyPfpuwaQcDjUyM+Ix64SV+OB+b8k+f55+x0IECMRPmf2tVv0HzoAtZt/LY0Kpt+oxuTcvhk/UT/23eV1KaNkQpVneFPvb5H0cd/qfMpIMOqHjyCJ6lk3OT9blp4KSlqIiRPyZnv2Lq2iwWlhrNWqiWclW6ffhOWHA3FRMY8zwYzAY/pTlB2tuOI+J4c768rr/V9rIb3NwctY/oF4mahla0zubH2CavztQKdTHMvq+8U+7mSyWJV71WNK+toEelNkNIpViA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=22dTkebjDElSlUQsAkELWOUsw9+ckofKL6X7DOEZSmE=; b=eksgeYrrsS5lcWHqPNsY2+1on93rkfhScEiDV36h3q3vPUEXCTWHT5NHFda+KEzBNr4nYGnmZf+ySrmfs0vVkGoIfeZcdaqAL2JgXqinUUEwmf3lkPhAyHoFMeaGD57U+jg1z12+yZFyadCl72S1f/L9Mf62+5ugqtoRsxzdAUud3xgf4hUYCzIVTNJeFB59vTkXvay5C0RgCljvwjivqrVi8N8RxFU1VOft3j00TGk+yIOcCIc2PqWmbUuzgOJNCYceqI8fOufzyLrpzGISmg1rkgYVUea7a14tYTb7EEGnZ93q8jNwG8XjgoCetmEa7BeIV3KN3ER/zKngdObrAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22dTkebjDElSlUQsAkELWOUsw9+ckofKL6X7DOEZSmE=; b=L+BA5yc+z66dZsmpFPEdN5fDojOOBTy8sIsc5hKjfBCGOaI/UpU9sGo5UcIf0+nhINu5OeW52t/J82r+IinpOP9as/uZAONitiASM3atYv1rlZhRVC9i660RF1tF1lOEaHTcB7n0ckwTZ0xWrPq3RkWLNuBRDdCmJj8vs0CZtLTXqzdCe/4sd65JN48WpAEJHFSwlAswgucDH6Xx6du3P7Ejy8h6mrIixeYQyurxaNC115zKpvNwd4SyYjGfz23nK+0/soG3G0hhArTE+KUGsG6zRARqXvMMF0cvh6HmGIA18Knmyhi7bEpvABVIVZjhyLf/xd/Vyb9pLWu2TSobBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:32 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:31 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/13] media: i2c: os05b10: update pixel rate on 10/12-bit mode switch Date: Fri, 6 Mar 2026 18:02:58 +0530 Message-Id: <20260306123304.76722-9-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: cf8bf35b-d909-4f11-e637-08de7b7cb779 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: boCzr78lI79sr/2nV7VLy5b/TDnnxyo3nqrajIgbiWaMsO8gjePwhaLuUssfjD+0uHaQA6YDS63n25JmNz7NZF1KhwLHekdTy3h25f8PD+/gyv7tPfCv59OU3TghcktChL/ziuJvI30qAnkp/oNMur3CX+aY257ouXvlAeCZvEuXHAaHaIKywLPxsBXB/h++QS2OBWbs56J2bdKh2L8W3BVERXRRRocJrkVmL3669QOGwOi42kUIoL+e7W6SZZ6FwC4VJwG0JkVvIwO2GpzgKRHUfvv0I0tEAZfC9Zkwy8vQ2twxRaLMOat19uA8ZnZgOdBKxe9eBWu+wVGuiqU92k9H991gvBzopsyh+9gV8kBucYv3dlKDBjkbibFOcI4SEJxcrmYEcjKlLJiQW2uF+/YTlzuVSrRbE0hxMXC37qTAJ4tUK0OoxQOdCIrgttM66cUESH/Za3f2UOh5TD8wI81iSaOERcYWu8tcFrKRAcfCc4A8mcJIgrychxV6iMqaAba9fZq5PKavRAN4KJ7161nWNTF7h5RzsUoi/LuTjqka+9tDkDnt9F3kDfqRA9kZIUkN+VXH53uKcD8oRiS8B4wCoCmW+cuVo//nF/fxZAUv8zhM+8fIwvr1tQ3mEDre0QafBVr81h4yMUxTnwjgma38s7iSwLBa4mQd+56+RGDi0VPAj1/3WFMVtr+dUepoQYpyBBK67gw2lse56xNbBIte1qKPZSQZ1Scoa1uVsMBFzBByLBYToLy5hFpw9GcUkoQXK2Zfg1GOmd0pe5WvLC3gH5u1eEK0y33jBJ9dfYs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LYJYVaOZ6byNfrEXs2f8hmsYvlN4c8mPT/HKoB860LvA49/+FabWatyWoUiV?= =?us-ascii?Q?hqq81ckt4CaQFFHEX/7bfo9g4NqQQb2FrNPV2uPX8j93J7CN+AS8RJSucZc7?= =?us-ascii?Q?bYmrxbj+NAY5yCgENSGSHMVo9NH9csitEzT9jHOX2hLS7bR5pEVqDC+/ji+W?= =?us-ascii?Q?eE+5qUMVLanoUZ5mbjbaI7/ISUtJ6u+0RBrNFvkc6A+grQTTIhf4DS1FTvz3?= =?us-ascii?Q?pLkMwDUAEBm+nw9NfJ+nMGU/Ryy2BQvyW3XIjGWHqedsMhKY8bMoRT9DKhCH?= =?us-ascii?Q?KFCDioEPbPjIaiE7oQn770qwnWvEycetY6SckkZVqa4TYJLk7lyfQ3ZnQJ8s?= =?us-ascii?Q?eEPZSSieB61Vo35uc8VCL9GdqxJKF3azbu9rHPlIaGS2p7Kz+MTVI3EYrRnm?= =?us-ascii?Q?1EKS+n5d/ysodySk87COKxF9ABHL67U18McnOlBx8F6UXScIZR4GBDjmuk5D?= =?us-ascii?Q?Rq+HWJEPvOQoqzSrXn/Mn3G4bbZhZtaqgISyAC3YFwYdZDm/l6MqXdG80/na?= =?us-ascii?Q?R37btfREiX98+3u+g+ZtRPpGb5bfh+gse39P+WKSO7hluy0DtLMfVD5+1Qxa?= =?us-ascii?Q?GILnHAj/eFipIsdEHKy2Ing0UqnJg3iknKAXWTap94QN39p/f4iESvLqGRHY?= =?us-ascii?Q?5oL0tMgbvh8yGQDCHpCoTcTnlscJt9zI0F/LP9INFtTTWsWkVij9R3tR3gTP?= =?us-ascii?Q?E2t7apwibpECbwKcZGFx7++rR0mrHR0AQ2P0xYD9pPCMabLb/VlIlELyPU/m?= =?us-ascii?Q?DcIhW4yVKkrdrCB88D97VEPoqcf+oZez6K2V8VO63bvIRCUwXpgp1OCCa8t5?= =?us-ascii?Q?4OTRs2tj/powdNJXdEb2M38Dyv+pc4ILmVEE8kKxp2xkiist3LiHCXGZ46Kb?= =?us-ascii?Q?f9gFmRceKYkrxCO0QlpY6Y53vltuHR8Rf2FnPO7i/Uv5M/w34hkQDwvypsHa?= =?us-ascii?Q?kmoSvC+x+hwUOjcVNP5bL4JwGgPmmYmvm15H2YBOCz1HGds420s+euBXAUJ+?= =?us-ascii?Q?m4mIQjnlDOFloGLOwByb4aadxOubdN+NXSGlM03HoiCbZKwnvVAq0TeDq1DQ?= =?us-ascii?Q?iotWnNb75NTPwTDo0g+8hIUGVjXcR84TJzlfvVsFQviWs4h7mlBqA3QpHU2b?= =?us-ascii?Q?BKohl3ery6YFiQK7YDN6Sao0d3i7/DkjuW3HJDmEwbX8f2MIiAUCtJmmpwXK?= =?us-ascii?Q?x1V0ZjSjoLT16SCHgx89s8xahS9LWmvDbuMQ1jdKxzQzxY5xsrXs2kuPJmj5?= =?us-ascii?Q?HU57CsAGS+SEruJ3utGzY6X348VeD8UBj0255ZEe2c8lR5yq0QrCHaBzoahy?= =?us-ascii?Q?1ijzrOnV7rihup4ZfD6cS7QZV3tOxi2f5cBGmWmXeN888J+9esmUBblNy41v?= =?us-ascii?Q?Xki0TQvJ8MfdrLEGX3fezLRtte+TszmCpwPjQhBu/1tdRQt+eRD3fcYt3i/M?= =?us-ascii?Q?yZ3WTHnWGSA4DSLv28Cn0n2A58Kh1X4TlqsPnDSQvxK/1o5yNPcJ3JDlkhRH?= =?us-ascii?Q?Go1AOF4u/BTSPKaRBMBsI1i0GT+pRvbSPz4ZFhFIPMtaSCLbyLkZVzbpFIg2?= =?us-ascii?Q?yJwZvB6ra9+yBn/uix+REHLYEO3Ck3tsSmt0lUlnXn20Zoo2Cy8VmYrH3/0a?= =?us-ascii?Q?RZ1FasjYmxSckgYjLnI+SJPXz6Jsc5WPWYpPnpVpcgbvUe/JgDP947SvEGxu?= =?us-ascii?Q?S2SAEnaZDr5Snw8R1EJrfS7G9qTfQnwkh6L1Ko1hBqriA06O/WrBqNeolpSi?= =?us-ascii?Q?T0mMyJyJbj9O8+NykOTZJsY1BwTUtkA=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: cf8bf35b-d909-4f11-e637-08de7b7cb779 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:31.9321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gXHgeAh3ue+sgvpZL07LiiIDSbiaBHprkp/yCvD2QYI44rhgXwJKLNaSB5zHS/YS4/u9AMF5lkiJREIUpqCsTOrNn1+o21OBT2YEEm9Y+7U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" After adding 12-bit RAW support, the pixel rate depends on the selected mode bpp. Store the V4L2_CID_PIXEL_RATE control pointer and update its range/value when the mode changes so 10/12-bit switching reports the correct pixel rate. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 41 ++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index d51b7d18d28a..5ffc7aef0ed1 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -474,6 +474,7 @@ struct os05b10 { /* V4L2 Controls */ struct v4l2_ctrl_handler handler; struct v4l2_ctrl *link_freq; + struct v4l2_ctrl *pixel_rate; struct v4l2_ctrl *hblank; struct v4l2_ctrl *vblank; struct v4l2_ctrl *gain; @@ -680,12 +681,35 @@ static int os05b10_enum_mbus_code(struct v4l2_subdev = *sd, return 0; } =20 +static u64 os05b10_pixel_rate(struct os05b10 *os05b10, + const struct os05b10_mode *mode) +{ + u64 link_freq =3D link_frequencies[os05b10->link_freq_index]; + u64 pixel_rate =3D div_u64(link_freq * 2 * os05b10->data_lanes, mode->bpp= ); + + dev_dbg(os05b10->dev, + "link_freq=3D%llu bpp=3D%u lanes=3D%u pixel_rate=3D%llu\n", + link_freq, mode->bpp, os05b10->data_lanes, pixel_rate); + + return pixel_rate; +} + static int os05b10_set_framing_limits(struct os05b10 *os05b10, const struct os05b10_mode *mode) { + u64 pixel_rate =3D os05b10_pixel_rate(os05b10, mode); u32 hblank, vblank, vblank_max, max_exp; int ret; =20 + ret =3D __v4l2_ctrl_modify_range(os05b10->pixel_rate, pixel_rate, + pixel_rate, 1, pixel_rate); + if (ret) + return ret; + + ret =3D __v4l2_ctrl_s_ctrl_int64(os05b10->pixel_rate, pixel_rate); + if (ret) + return ret; + hblank =3D mode->hts - mode->width; ret =3D __v4l2_ctrl_modify_range(os05b10->hblank, hblank, hblank, 1, hblank); @@ -1058,18 +1082,6 @@ static int os05b10_parse_endpoint(struct os05b10 *os= 05b10) return ret; } =20 -static u64 os05b10_pixel_rate(struct os05b10 *os05b10, - const struct os05b10_mode *mode) -{ - u64 link_freq =3D link_frequencies[os05b10->link_freq_index]; - u64 pixel_rate =3D div_u64(link_freq * 2 * os05b10->data_lanes, mode->bpp= ); - - dev_dbg(os05b10->dev, - "link_freq=3D%llu bpp=3D%u lanes=3D%u pixel_rate=3D%llu\n", - link_freq, mode->bpp, os05b10->data_lanes, pixel_rate); - - return pixel_rate; -} =20 static int os05b10_init_controls(struct os05b10 *os05b10) { @@ -1083,8 +1095,9 @@ static int os05b10_init_controls(struct os05b10 *os05= b10) v4l2_ctrl_handler_init(ctrl_hdlr, 12); =20 pixel_rate =3D os05b10_pixel_rate(os05b10, mode); - v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE, - pixel_rate, pixel_rate, 1, pixel_rate); + os05b10->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, + V4L2_CID_PIXEL_RATE, pixel_rate, + pixel_rate, 1, pixel_rate); =20 os05b10->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &os05b10_ctrl_op= s, V4L2_CID_LINK_FREQ, --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021105.outbound.protection.outlook.com [40.107.51.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB42223507C; Fri, 6 Mar 2026 12:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800483; cv=fail; b=oecttTDVkLKlnM5MhgZ9cNDysD6jt2jmAtOImKz8McD/rPRgXly8Mtx6zp4u08aPDEkcI1wG3M8BChqp4uJCCOuf77R0IUuWDeQ/33NYDR6MiIEabNQRQqqfkI2oY1E//n0n2gHSWp2lFlbbWbDaw4taqdmcTl3cDV4ji/9Upgo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800483; c=relaxed/simple; bh=jFS2T0EAERbAtB6YTmyKzun4TOdMKVyfhqA9iQxOwo4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=sym30+O++vfDAplE8DUT/ny7dtEnBEz0GA3bDapMUwKjwSCTyjE63cjcPBEKPySe90L6DGMrLY2kkXN6veklZbZGrQUTVSmMS3mIiuCcc8QOw0pP+2+SE2xZXR6r5rQFnno/Bz4gWyQC4ruQHEdisP9UNDqEnT7ZQyxNJGSVgsE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=UOjPS7k8; arc=fail smtp.client-ip=40.107.51.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="UOjPS7k8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aWZ2eamK5JZY8EKoR0KBotKQbVfucZrkU0WiDrIZ9dU3joFxycVFiEr9ROelBSxLskHtPeUvTWqLdwaDKaTcFeaToB80JOWo+JCd4RTqtGBJIghbjn0PfS36KIIfUKCV2L7w0C9N3prloJssKQ1EwdDsTi285mimTmPN0mE50o5haGmIKH32F0umkCpH0xGQJVcCsqirIi+EKUUZmKRpTiqyITd3QtwBcptFLNLpuDkpMYDqiPWJ7mCIVEudqXy9z3DQC7bjWw0nffr33CNC4IYuUMUtoAu8/7iplyaIIVIUky3ixjN6ybyCmPKgwqlsUGxXklOqY/NS4xC7P5QctQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TeCTJqIZ1LUyrTLx8AQBWdNu72KFhXMQpnYw+cPl9jg=; b=lnvmHIegMFKaa269+5wjdkMHJKYAbKEos69Qm3S9PqZr+tA42SwrQFHuWqzRVzDHKKlGNdbOEa7R3YOc3gfcYi7XGrf7UNor8TFktvDaEK5Rx0+KQYTj/n86z7UWf+oRxQmyD8/Sv66kt6Ow/gzXJPD3ALYoGMNva28br13beP9DojY8S32vexxnPLBtdfWGHKs1MhIGVw0PQYjn1hG5a7MOGFhBvnuGjYuyBJJEbB8rdAoHcFvC5dU1yoHLHBQE7NKoz2eU3z7w4C88nUBUsZBHBuoHOCNRCFbHLZEQQWZSZ9ZpyDJt9h2pBVa0AS3fnBjDjR7MG5X6fo9wMXeYMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TeCTJqIZ1LUyrTLx8AQBWdNu72KFhXMQpnYw+cPl9jg=; b=UOjPS7k8A+NjlDHnjgvDgz4/skmfWOIV8Q5Cqn68pfK1pwNDArmMbNU3qEt1mGpVcFvNLY1quuonBdnt+p8jyaykam+LZgYDBgqakiqyZWYQodOUvBncwPL+D3ozAVXKnvm4/9jcynPzk6y6Da50ycu+e86/DJ7ESPHYvg6Eae86JYSfUbO3Dfakjw/GIc+F5YvOJ+4Q3mRv126qFEae26orKOaGZ0zJefb13pWgW71bFr6mJs4LbVH3qzvK0OoSSIC1mkYWS/5GTwfIPlBQ8vRgNr9v7/aL1v1Jxn62xzP11LhSs18sl1wuKwzIYStnVK/zPUtqVKl6kUoDLyeeMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:35 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:35 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/13] media: i2c: os05b10: Add 1080p and 2x2 binning 720p modes Date: Fri, 6 Mar 2026 18:02:59 +0530 Message-Id: <20260306123304.76722-10-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 18b3b198-79e1-4211-a5f6-08de7b7cb9b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 4zzaAhGQs42oBgsXhVUsFNcXN6151kd2d0FNovYK3R7mNrtmKMwvs5xGHk18RVAUbcU9bR5jY87XsUNOL+4FIjmoLmmfJxwRM2v11BFjK5S+WSa6NRYU/lY02USZTAmg5ahVbEHT/Z6NN1ovyefuDfM+IHRjNYNPyQdBo1oazCIMvUDOB9iDfLAL96+kJI6269e92tIZwgFVjE77GGww2cropsQk8Vf+R/HxlO0jqk0yW8Cr2S0tfV790tHp4zS3UKmyKAoNVYSB9nQHh31xwUsOzbgmDIzZRk0qa4m6sG40TrNIcd8cCLpo0R0S19R4r6oXvJiYJ4iCUxEOUDiZn9KZGC3Gw21RPAzntHmE43ClsGhNAR0SpSZsZLYgMEN4jBMRCKgPnNCu25e3toPnQ7pHNXuAE7dFZaZ2rh8VgR90J5wUufEFJSZ3SbFRHkyYGN/NT5/JqLKYobfV9w5lgK/RFnYt54oU0i5aHeHDbVS32fYrfuQOkklyd7x+EFFoJkwy4PI6WbXAZ6T2J5vZSqXIX6mYXMqcewhnHcRys+5+FW0hKDdz4JvvZnuUaTqaADj8fLYIKa1trUXFA9dZcknEwuYPAXbjbpemyPWM5Z88R9eLu2YIhGF12CHnpAvKSkG9lRdqjn0seCfiTOtlF5qaBHFeT+CQJqkX+hQg8dk8NIi2x6gCtgC++KeqMxyC+QkUYY0N5+ofeGpvP68A4t0gnFNfe4XEbyeVc8bWAuIxlHw9ABt7hpMD5JTqDOXd45Iy+QICJtWz6ZPU7gL9+QiidQNa9eh/VjdhzWLbB1E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2sts/lYx1QOOKrYsgTBC0KFPxufnm8P9oTI9ybHiAtwErPjHr8qk//TvgXSQ?= =?us-ascii?Q?B1/LM2ERNnnP1QOByvzyhsmdJUeR0ScJ6O053n0LcHui4D9rYTIsUTA7jSy1?= =?us-ascii?Q?7eabUt8bFLt6PnHO/ALyEIP1tyZYtueUj9CuLCva6f/LHnbX5lna3pG46Dd0?= =?us-ascii?Q?63sib1yEicILjIC9B/iIO/tzES6DoZHwv4f/sHoMwvnz6rU3r/fpo2oEG367?= =?us-ascii?Q?MiVqJRwxSllcjC1AKCnQMjVDxqyeuT79tpCK6dj5LcnMaF7W70f3LJ2oOtzs?= =?us-ascii?Q?nRBuKOvJgjqEglp6VSOZNcC3Ij9OSv2SsmNEGFl4jeecxQ4xS3pe1sK0baH8?= =?us-ascii?Q?MjjBdCgSqvoDT1diw+f5Sr84jNITEBVOH5xOVrOGnKB23qF3hnWhwVyqHidR?= =?us-ascii?Q?0SkOy7onqWJ8ecxly50tTVhvU2WkC3hjgVjiHLZFoAOc2Pgcttmnle15FH4a?= =?us-ascii?Q?C9UgfVAPvdzXv8pQh5g6Ji+rdvmJbNJ3GYrOYDylTh2Kp2qgyUZDDFt8gNhq?= =?us-ascii?Q?C9CYEuVTV/Nsa4xpoGh8tgZdB/3j/KPA80pQsmXPx0AMEKTbYs8zeekJjF0J?= =?us-ascii?Q?02PXWef7ZLJLTFqqmED3Q8b3y3PGk+XWqf1un6RkLJNzT7E9JN+ExDhWrzYx?= =?us-ascii?Q?3aBbbsPkRc70n3RLMt9LVNsBgr5Zk/pCo3E9ZIpl2KqQkHZTIdOfQjecKtNx?= =?us-ascii?Q?vdPPm/t29yztu1ffUtI+eZjov09/t+UtJjvWul0C9tPU9ve9rzXly2vltB0N?= =?us-ascii?Q?HAe7eHwi1rFs//wc5S8qYKWRyEylGXYM9f124h7f5ZyuuxpBgBracUZqHPOj?= =?us-ascii?Q?Pg6st0QjYDWyQQ6nKVa4GBCN/TfPfmyLWQYWfNt22DcPf/LNskw5Pe0ra0kX?= =?us-ascii?Q?DxOOtyE8+rUG1HxxcSycvI7hOhgaU63sAjivw8gfd6ARvHMCJA6g01z+E3Mp?= =?us-ascii?Q?oVkxVfU22mn+MnVmi7TqtOJqZSGLsCPjuoTb+PET6fVPBdC4zQe/nDOe2qg6?= =?us-ascii?Q?y3I6O2rF/3xrVSNIoWY5fdhUwxwofQFIAdti4mGFMRjLFv7AOuYgmsS8Xll5?= =?us-ascii?Q?HlweK2jLdB6cNgIDANaRzNngU/65lBvB1b8yk4bFT3hkvst9kPMoAox1bo6a?= =?us-ascii?Q?gQ03cMEki9J0ic0MM+9WzXPLuVdwASj4aJVxERoqC9rEUbBRUHNQxxedhaBq?= =?us-ascii?Q?fbNgWeEg4Mu3swIgq5KY1rEriYFaU4lU6B8cTa9nE2BHQy3dtEvR9ck/yzOU?= =?us-ascii?Q?EkSBKRXaXq9yYa8adxQ55yMyp6tKidxQf5GYnhoCwSmQTtu5ZQ7KPjRoPQ2/?= =?us-ascii?Q?isiehu6A/EUK/zycXIVp0PtB8bFrs56O5YX6gZMOILCsEz2IjN3/SXIXH0E4?= =?us-ascii?Q?pt3diLpe0QB0ajzdR2/tvQTDdFEqMtMgDHNZiXm4/F9A4tVceaC51p79eC6p?= =?us-ascii?Q?eyDwlJyX5+0255lOPM1GSjZUpT2+0hEnrGp0Ttxt+IXQtphQcfqlhMQYaEzs?= =?us-ascii?Q?H8fyIaZbK83SKyGrxY+yiEEkggUVDhLjSFQq2qbaaATozHzot563JsaLwm9c?= =?us-ascii?Q?8dknzhetb/QpOr6c2ymBseDW6LJ6J+PQOMeoKzCDkLZUcOe+UowELst7NyvP?= =?us-ascii?Q?qsY5g4L2FbtKjKhBmxWrxcpSG+6543NUD9udU4E+w0wInRv26fpxwHPLATwS?= =?us-ascii?Q?0wJ6cVJPx+FmCHDlcYvOoWovTV2Bqmd5TPVQP9A12ypF9dnCHrniQWrR33LK?= =?us-ascii?Q?zRc2UUVJtK8sL0fTVOBkKgkHhQIjLB4=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 18b3b198-79e1-4211-a5f6-08de7b7cb9b1 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:35.6583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GJ2Up4XAn0H40tR2erAswMg252rMS5yosacf+odGg9ozUeKGSe1WsKfuLKWDoWd6/cXNikQY3eWCRhF5xpcFD595pyxxBAGe0grekyVpkbs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Add support for 1920x1080 and 1280x720 resolutions. The 1280x720 mode uses 2x2 binning. Both 10-bit and 12-bit pixel formats are supported. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 121 ++++++++++++++++++++++++++++++++++++ 1 file changed, 121 insertions(+) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 5ffc7aef0ed1..d8d776de5f35 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -461,6 +461,78 @@ static const struct cci_reg_sequence mode_2592_1944_re= gs[] =3D { { CCI_REG8(0x4837), 0x12 }, }; =20 +static const struct cci_reg_sequence mode_1920_1080_regs[] =3D { + { OS05B10_REG_X_ADDR_START, 0x0280 }, + { OS05B10_REG_Y_ADDR_START, 0x01b4 }, + { OS05B10_REG_X_ADDR_END, 0x0a0f }, + { OS05B10_REG_Y_ADDR_END, 0x05f3 }, + { OS05B10_REG_X_OUTPUT_SIZE, 0x0780 }, + { OS05B10_REG_Y_OUTPUT_SIZE, 0x0438 }, + { OS05B10_REG_HTS, 0x06d0 }, + { OS05B10_REG_ISP_X_WIN, 0x0008 }, + { OS05B10_REG_ISP_Y_WIN, 0x0008 }, + { OS05B10_REG_X_INC_ODD, 0x01 }, + { OS05B10_REG_X_INC_EVEN, 0x01 }, + { OS05B10_REG_Y_INC_ODD, 0x01 }, + { OS05B10_REG_Y_INC_EVEN, 0x01 }, + { OS05B10_REG_FORMAT1, 0x88 }, + { OS05B10_REG_FORMAT2, 0x00 }, + { CCI_REG8(0x3610), 0x87 }, + { CCI_REG8(0x3620), 0x0c }, + { CCI_REG8(0x3662), 0x10 }, + { CCI_REG8(0x3714), 0x24 }, + { CCI_REG8(0x373f), 0xb0 }, + { CCI_REG8(0x37bf), 0x05 }, + { CCI_REG8(0x37c2), 0x04 }, + { CCI_REG8(0x37d9), 0x08 }, + { CCI_REG8(0x3832), 0x08 }, + { CCI_REG8(0x3c86), 0x03 }, + { CCI_REG8(0x3d8c), 0x71 }, + { CCI_REG8(0x3f03), 0x08 }, + { CCI_REG8(0x4008), 0x02 }, + { CCI_REG8(0x4009), 0x0d }, + { CCI_REG8(0x400a), 0x02 }, + { CCI_REG8(0x4041), 0x07 }, + { CCI_REG8(0x4505), 0xc4 }, + { CCI_REG8(0x4837), 0x0d }, +}; + +static const struct cci_reg_sequence mode_1280_720_regs[] =3D { + { OS05B10_REG_X_ADDR_START, 0x0140 }, + { OS05B10_REG_Y_ADDR_START, 0x00fc }, + { OS05B10_REG_X_ADDR_END, 0x0b4f }, + { OS05B10_REG_Y_ADDR_END, 0x06ab }, + { OS05B10_REG_X_OUTPUT_SIZE, 0x0500 }, + { OS05B10_REG_Y_OUTPUT_SIZE, 0x02d0 }, + { OS05B10_REG_HTS, 0x0368 }, + { OS05B10_REG_ISP_X_WIN, 0x0004 }, + { OS05B10_REG_ISP_Y_WIN, 0x0004 }, + { OS05B10_REG_X_INC_ODD, 0x03 }, + { OS05B10_REG_X_INC_EVEN, 0x01 }, + { OS05B10_REG_Y_INC_ODD, 0x03 }, + { OS05B10_REG_Y_INC_EVEN, 0x01 }, + { OS05B10_REG_FORMAT1, 0x8b }, + { OS05B10_REG_FORMAT2, 0x00 }, + { CCI_REG8(0x3610), 0x57 }, + { CCI_REG8(0x3620), 0x01 }, + { CCI_REG8(0x3662), 0x08 }, + { CCI_REG8(0x3714), 0x28 }, + { CCI_REG8(0x373f), 0xa0 }, + { CCI_REG8(0x37bf), 0x05 }, + { CCI_REG8(0x37c2), 0x14 }, + { CCI_REG8(0x37d9), 0x04 }, + { CCI_REG8(0x3832), 0x00 }, + { CCI_REG8(0x3c86), 0x03 }, + { CCI_REG8(0x3d8c), 0x71 }, + { CCI_REG8(0x3f03), 0x1d }, + { CCI_REG8(0x4008), 0x01 }, + { CCI_REG8(0x4009), 0x06 }, + { CCI_REG8(0x400a), 0x02 }, + { CCI_REG8(0x4041), 0x03 }, + { CCI_REG8(0x4505), 0xe4 }, + { CCI_REG8(0x4837), 0x0d }, +}; + struct os05b10 { struct device *dev; struct regmap *cci; @@ -514,6 +586,31 @@ static const struct os05b10_mode supported_modes_12bit= [] =3D { .regs =3D mode_2592_1944_regs, }, }, + { /* 40 fps */ + .width =3D 1920, + .height =3D 1080, + .vts =3D 1504, + .hts =3D 1744, + .exp =3D 1472, + .bpp =3D 12, + .reg_list =3D { + .num_of_regs =3D ARRAY_SIZE(mode_1920_1080_regs), + .regs =3D mode_1920_1080_regs, + }, + }, + { /* 2x2 binning 120 fps */ + .width =3D 1280, + .height =3D 720, + .vts =3D 1003, + .hts =3D 872, + .exp =3D 970, + .bpp =3D 12, + .reg_list =3D { + .num_of_regs =3D ARRAY_SIZE(mode_1280_720_regs), + .regs =3D mode_1280_720_regs, + }, + }, + }; =20 static const struct os05b10_mode supported_modes_10bit[] =3D { @@ -529,6 +626,30 @@ static const struct os05b10_mode supported_modes_10bit= [] =3D { .regs =3D mode_2592_1944_regs, }, }, + { /* 40 fps */ + .width =3D 1920, + .height =3D 1080, + .vts =3D 1504, + .hts =3D 1744, + .exp =3D 1472, + .bpp =3D 10, + .reg_list =3D { + .num_of_regs =3D ARRAY_SIZE(mode_1920_1080_regs), + .regs =3D mode_1920_1080_regs, + }, + }, + { /* 2x2 binning 120 fps */ + .width =3D 1280, + .height =3D 720, + .vts =3D 1003, + .hts =3D 872, + .exp =3D 970, + .bpp =3D 10, + .reg_list =3D { + .num_of_regs =3D ARRAY_SIZE(mode_1280_720_regs), + .regs =3D mode_1280_720_regs, + }, + }, }; =20 static const s64 link_frequencies[] =3D { --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021105.outbound.protection.outlook.com [40.107.51.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06E751A8F84; Fri, 6 Mar 2026 12:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800485; cv=fail; b=cHQ53r+ewVRec8hMlUbSQokURhTlH6dGFd1nvbjQstOEbXxRbnvxqewiF8TsLdbfyCg79A1FPzjPHyds/BOukN8YC0JCf2IUFahOd9ECrjlQspahzASrjhG3BFCbY6Ff04mUZbGuwEltyxJRQtT75qSWEW2HHReNNIdMGw+lDSM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800485; c=relaxed/simple; bh=ujrslm8Fe7+QfsUWkHdE5ahgotuRFdopsq42MJABLVw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=l5HIlOGTqO1mjUZkeN+9A4y2B7V3RNK7jsE+geijmbPWsFR6iV41WWfCA6pgvQbgkP2X/BtlqtTjBK78oLyEDFlyGqvoEE0APg2bqOBrNuCdoiN/IRgwBZiG7kiQ6VrmPiN1qRSjtmclqboFkK/+RO4EeA6bduEadR9+F5XMEkw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=A69ezPr3; arc=fail smtp.client-ip=40.107.51.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="A69ezPr3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NgDShZb9cSFhiRd13T6wvzC5cCc+MB4jrGefrHyu7risW+a1Zbzr/IxuO1Ol3oRKAZVoFdXftSUozzRjYjVRZsf2EYGbN7KkrzFY8rxStR5Rz9ok1sUO7xHFPj97EOjlilfg7YkXiP/zE7hirlcRhfaD8StFaZJCvAd5SUTYj5c/2t6Oc8EGUjZRBxO0dduXwTduJlLsf1aRSurqG9yqroIA0D6VuL4CweyEZe1a2885GM8xn880lzd5VyRZFKJw5niAxKhZrB46C8vkdqmx3IQ+M5SfkckBlaUUnXkqSyzWsCSadnlgOnP6rXaszhC0Ol1GNCTLxtY7haWLcSNBkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F63xWCx/Y4pqMfM4DG87Qp0tDMGtBnYQ8NSoMOayghE=; b=iyXN9vtW15uiDX3A1zt+Ou95+gH98k0n95KsZaBtRutgw2OU7JqKy384WOQDNYfHO3gVlN1WOiutC4zee7wxPWqy4ff4PBr/bDpH2upvXmKtu5FJZT4pn9S65ift4MQRIfgZ6JWvOeSXSXQqhl4jekQ6YMS+2Fm3YHu7Uk5CeaQd0FqayNcUwaXUaXJFCPfcRr4n57toTAutE3JiLrZYd0bruwwH7WJL/Wnx4QxBn0w1YDdtFm7Vj0lMWfqpzhN2YdQNuNCefFN9Jmgoxhz+Dyq9pHx0WgDMdZeyuDad5cAiOZOVaWjMNrLmoZcYuZtryQ0H1MXWq/stvdIgB+IseA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F63xWCx/Y4pqMfM4DG87Qp0tDMGtBnYQ8NSoMOayghE=; b=A69ezPr3Gwa1eP+JBQ4stbTOCa8G7GVRR98bpibWbM5wpsEWomc09QNnzr9TnhfFFTlQKL6NgsVBV+bwD6lXpPvjY3y3sOFpvP1Lqbv+qPmgbNN3SNP09mu1Ptur0kx4yGrRG2L0d43geZXPHyxBjKaAATSMNyZV2bMZMvroXjTw+p6R7K2qNHeLjTlDtLu482CPwWTycHEGij7BR7J5EhJggMQPZVZNQBN7AEgYgN2Ooygni2IvmfJqVc6yxLSxw4JiGn7eSG3aBDuprd2wjsXA6E3wrQJLh7pCMPsdU2algHLCzgMku29RCazMcgJnz2K+obB3C+1bYAWQAeo7bg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:39 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:39 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/13] media: i2c: os05b10: keep vblank/exposure in sync on mode switch Date: Fri, 6 Mar 2026 18:03:00 +0530 Message-Id: <20260306123304.76722-11-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 2637f237-94de-4d99-6db2-08de7b7cbbd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 7mP63QYASVEvATF1kkdKJpOoY8Wowddanr8Ijq4Dn4lkQNcmEEjb0vfvaCGRDUITFcxGB1hdkx/W4Z3+eAOfhZPMamn5dV9DdWqsBtUS/nR+B86ilVSCHFvpSP10FfTA/hwwIA9oeZGtaGKu3gDSYia2ONDhOuc/hUIv05aLtZDNf9Im80LmOSebD39OJVjfJLQAWKAAt79ctneE2q1mIpamaS0WUHOz+L8Ll5m7uAXMAJ8VCPXNacfJVNjLqDAqgotYuM1zXVU/vV/fd3uI3DFlwmvhy31nYeuKhMkB2/kDFckGL9No2PlyB8jZXgWy+8YM0hD/TiYh6C7DtyyNZn+5NIxmjQbMWRmU8aszjKhJq6uw58zRGvKI6kBmdgt8UwbpDqGsqioMPqcIrdUGQFxZsd3ziStfrcLDSPwd9CRAPuEniqXxDMUy+eO6caCCf0pY9UQ9BKFKaDnOoivZoaBMTzsjdaKC39xmHp51ReKUqe0jc7Jn1vATo+m284Ts7Ikcw2bsTXEyz7rLZGyt0ie0+tZMKMv496PbFPekOHSzxhgLK0U6sx8RiI/kz5ZTY0n+dagXnxNmaXi+VO8VC3MuJGxPn0ppEhENho+Q8Lqk2XuvHvEOtJFfscSL5IeUPwacFTUeecOX0KFuDT2JzLooVRT/kGFKM5tr6K7CV9TyUaBlOyCjFngQjR3uJX3VgJSEiKZ5TVoVqEbFWCC1yN5hG5Gsed/GwxXIsEitVagslDUbh73n77ikPXkCIINLlKcFb3j42wlKcacmu2uUoZSD+JYA+vQnOYzH6of6jj8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GD6fAEHiKx3iT+fzQLzYDN8IGKI+qUZ+hSKJRJVuHL2nBei2MnNNzQY+cqvC?= =?us-ascii?Q?0mlXRghGK4GmNov5mk0x9wUdwZAF+fZ0pO3OkTgewa9x6vVRY/Zx93OkIFir?= =?us-ascii?Q?Rm4QBTVnl+MKQWnOPxZvEhop7eM3aGiUGQzTHq2PUHyB+Y/G570f0Y+3tkZI?= =?us-ascii?Q?I38xrOxeAFCFb0kTTs3HSshWG05aIxi20o4prpMxtFhSgGzOER0VL+QNeM1n?= =?us-ascii?Q?R9OBSbKT26dg+qsbgh5+taOuPvq6sgW9zNXetTYHJRcLO6XoJhBwYrBn0NQq?= =?us-ascii?Q?P9Zqfc+oD3ccgasPu7qnTuXRgH7o9a+lq6x3VJiZQuqgORaOTJqWpgqAuS2r?= =?us-ascii?Q?LYG6nvSxJyEcylqJaqCngvinoH6vT9oaedz1dJKRipSPZEYwKacuMcf92HWq?= =?us-ascii?Q?+KK+JctAmr8Ktjo881k6JvGkw9XyDy9CX5DlOzgBIX9PnuMDBNpq99hTaytr?= =?us-ascii?Q?GcRSBvMwRuAzQHDxYM3K6eOfrxj4HAXx3gO6awoHf7bMTQ/Vm4pB7WeDiUPP?= =?us-ascii?Q?A/4QJoCfralCww+tiXFF6D5tR4o3I87nERTjDGFrMVv2qlUwwfWR0MZ+lOCw?= =?us-ascii?Q?A5kNLLkhOEA94BLzNzQiOWBBF68Kc+dBQTt55CfDwMQ5U80d7wVaW5LALfl1?= =?us-ascii?Q?cQ/jaStCs9N662p8xGSoAKoC3oKiqJcGi0DpOLM1+ie45E/NmAkVZwi4dCN8?= =?us-ascii?Q?a05EBhkvUaBNUH0U+wCN71bia9CFuVzWFGw0jvLi9lQpEfQS7aMwNuYakorz?= =?us-ascii?Q?OLLq3OClZlkur8IfbPfLVYeCXknyDHTIUV8G+Eke9DeDXlJun8IDOW5svUL6?= =?us-ascii?Q?RHlQU2h2WlNMbyJgqikzDF4PT7He8EYFeIX5N71vFo0gYUDoidLiHrPxxkKk?= =?us-ascii?Q?8Y9wt37Ad4reLxdvMaCT8ES96YP73IOaE80N7YcDkFa6Q3wJ6tdpoooo45cn?= =?us-ascii?Q?ZJNDuXmRfkS1Jqz41KQ6BYGSCpz4qedH8DH68eqkVuOS8EjfHZ1yswFuwe62?= =?us-ascii?Q?k6wKmYEgX8JDPZxA/B27/bAOGkWoIFZemXsBroBChlg4WJTF5oe/NBbcJIfp?= =?us-ascii?Q?n72WBvsaYQxyd8oazDQ7KnX44xLoOnkip2kqTSpCyJAmaGpk5PAmYunDp03T?= =?us-ascii?Q?bSf18jeWq+eQ7wgDROrSwxnO8QitqXtZ99NP0AhWjiVoFfnWH5hKg+WDs1Rm?= =?us-ascii?Q?0ppZ2rdnFliqP21Is2ZPRijoDoM7ZpPOE49PfOVpW373FeQb889AC2YGQpJT?= =?us-ascii?Q?3e3BKHt17+sJ602afOh4jI3CBaE0QIFbzRgwV+lAAC7Q+TWGZvaBUMdnOgKT?= =?us-ascii?Q?jz+un45PWHDrQp3FFBslcCOEbSCfM7MsGYEXq3p0XfHCIKHMAkjziJJDC69S?= =?us-ascii?Q?+tPAdmuXCa5etRkviPEk5GDVD2cJLLnLrHMyZPZfkbcOAhG2NIeQXPjIeWhw?= =?us-ascii?Q?d7KJl0LypTzzsC3j3LipUUXfxYh++1hx04f2nqKRksLL9QhgEd8r6UPMi2yL?= =?us-ascii?Q?FXr4yrpU7NvOcj7dHTEkMeVS23lTo8jzMtFJ4KSeIH8MY2SPEqh+XUU7FE8d?= =?us-ascii?Q?Bu61QkwdytQ/U0ofq4MlVddt00cdX7bAu/dloQlvpZPnZCIsvjJtBcIY+IvX?= =?us-ascii?Q?LtbJeCndizoRyjwfFrSGvA25UjDddu7JHQpzSSPT6YSazXmMzvMtxNBdNFhE?= =?us-ascii?Q?dWEaVydYq3AOMUk5iA4Wy4hS+Gha6Z7FTEpXc3eZtcGhPlal1hxNSX9xhtVU?= =?us-ascii?Q?CvnrzVp2OHUPiUjLfiewOunlUD5YLrkEvg0ElQtzocnIJCh0AhJU?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 2637f237-94de-4d99-6db2-08de7b7cbbd9 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:39.2551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AE5YJ0ueRrPGLs35s5+yt+HlWqHvymGLh3G+rejsDa1C6WhC5P3o/l0jv5BuxhmJqWSolurdrUdbjeerftFLzptahJ8A6LJj482rW1vulr4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" When switching sensor modes, V4L2 updates the vblank range/default but keeps the previous current value, leaving vertical blanking unchanged. Update the vblank and exposure control values to the new mode defaults after adjusting the ranges. Clamp the exposure default value to the new maximum to prevent -ERANGE during format changes. Also use pm_runtime_get_if_active() in set_ctrl() to avoid touching the sensor when runtime suspended. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index d8d776de5f35..4601e33b7e8f 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -732,16 +732,15 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) if (ctrl->id =3D=3D V4L2_CID_VBLANK) { /* Honour the VBLANK limits when setting exposure. */ s64 max =3D fmt->height + ctrl->val - OS05B10_EXPOSURE_MARGIN; - + s64 def =3D min_t (s64, max, os05b10->exposure->default_value); ret =3D __v4l2_ctrl_modify_range(os05b10->exposure, os05b10->exposure->minimum, max, - os05b10->exposure->step, - os05b10->exposure->default_value); + os05b10->exposure->step, def); if (ret) return ret; } =20 - if (pm_runtime_get_if_in_use(os05b10->dev) =3D=3D 0) + if (pm_runtime_get_if_active(os05b10->dev) =3D=3D 0) return 0; =20 switch (ctrl->id) { @@ -844,10 +843,18 @@ static int os05b10_set_framing_limits(struct os05b10 = *os05b10, if (ret) return ret; =20 + ret =3D __v4l2_ctrl_s_ctrl(os05b10->vblank, vblank); + if (ret) + return ret; + max_exp =3D mode->vts - OS05B10_EXPOSURE_MARGIN; - return __v4l2_ctrl_modify_range(os05b10->exposure, - OS05B10_EXPOSURE_MIN, max_exp, - OS05B10_EXPOSURE_STEP, mode->exp); + ret =3D __v4l2_ctrl_modify_range(os05b10->exposure, + OS05B10_EXPOSURE_MIN, max_exp, + OS05B10_EXPOSURE_STEP, mode->exp); + if (ret) + return ret; + + return __v4l2_ctrl_s_ctrl(os05b10->exposure, mode->exp); } =20 static inline void get_mode_table(unsigned int code, --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021105.outbound.protection.outlook.com [40.107.51.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4422D2C11D7; Fri, 6 Mar 2026 12:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800487; cv=fail; b=SRGYGSE0K2RAs5mUYbKxA0WdBuOzS3t4v1ZjY/+DaLbX+K5bSnliLSZWD6KmcF2DXGSnMR2FrPvxfQLhexsh5XDDhulquMUdAdRrNUMt1hXzrCdxN5W4tQpql9W9/46itSZjvTwFM7vtT9KGOsWYASU/S4x1kHfmC6KVmSR5NWc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800487; c=relaxed/simple; bh=Jwh0JBe6lgddryNRkKwG5TsYl5I8x5N5p3OwD725r+M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=uY54ma2VP1Qv+qJsMTkMxUfUqsn5kssxJZNMCpVLptw1UIIlPBtcBRtUflf41l8fz3Nb6AHdNjpZR+g5NkRTVuxmCErlFIHK+OoRARYgMPBzkyClOh8FoRzRdOfHgUK2mWWqbLxdCt7QuPSipB8oSIVW1izQ+HQMl+fI799dujc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=QWSmilCi; arc=fail smtp.client-ip=40.107.51.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="QWSmilCi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x6mj0ZpYlL/LbAlGn9NeDCp9mPjJcaYPKjYjPYLbkxQ2/t9rdkCZgLnXcYPV9phhV/ZujLWo1z3Q3O7q6IL3h2k/Ro5w5pAYZgRlUnlXPlSpZjNDqkMWqKYXfksS6OHGukQnKwpOWpBtAESHOrIJ/bNQmmwQnfg1P83k0qJrcRwIDPwk8YJHbuyg6HAGPwFz8LkRh5/fpttsH+XoQr5Qmr3VbzHG+cjc2li1+H8hNVwPeoCFt5j1EsYj2be0Z948FHHUMZHzAm82ZejUrXnCHtMDsyUGfCqnWp+4EuBzISYR9jHSPfSQ65BEF3EEKQzxqTHNo/b3bvjleWUnGqFe3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZS/B5eOxeYyCSr/UGlVuPh+u7OhtdkUtgBsG/GHCDWQ=; b=SOMceKSJppoNWNmQVZ5exP4MV2sT+PMmCwAnPu/++L9KFEUynZKzwlj7LxnXQKIvOrIktdKMqweBajLlbShm49RXDo8ExudydBYIz4sAjGaBJidFFzDeHFYZO873Aoz6r1KVNJUbYwleNJdArDaTfrq8GWX7iOz6ErZXwLJ93K7BDRey2j9Vt4fy0cHTTJ3Ay8e+ps04GBA5D30YKY7FhJTX7YdUUJ7W4YbH0rQIlYm2D+Fsi004GhbLfKGrCQI4NGA52tLYzLt5XtldDXSd0Uv8TF/k++XKmXXeY21CNRyRYcLJFp5M+BOgikOlE6m+KksF2cRBj7/hMKGH4kasvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZS/B5eOxeYyCSr/UGlVuPh+u7OhtdkUtgBsG/GHCDWQ=; b=QWSmilCibcERjsW5QszLmIg0qLGjkiA0oStPUqf6zg1vt2DwShHXjBqXUhlSh6zz0RW5WM69lUM9a11c0rFJ6LeZnntcovJMob/rEqSkQMxG8NSNXVqDrCt0K0tRKRLYO/VXhyaiGE3wdrFCMtQ1FysISbvdGemeMv7Uqp8AZlvBlTm/dN1runzvV5dcucZMyuNSknJhLFuJ8dVp2C3F8COVHoub0JD6i+OdKHfAbc05/w3FusAh2j5nkhMd35bD4LpSykb8eN5asY94h/0ybVQApzwWpBelzYeiVQf7MfKIeakBTV31AW3UiJzVa4POd7ZoUtPFIcXUy4NkUFBujQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:42 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:42 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/13] media: i2c: os05b10: Update active format before adjusting framing controls Date: Fri, 6 Mar 2026 18:03:01 +0530 Message-Id: <20260306123304.76722-12-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: bb1e0e95-e737-4368-da1a-08de7b7cbdef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: h92BynEpXol/lUO6yp6rPRw+4drvWI1nyZnYYVJScNUJ4arF4N3jVx0GEyQBz6ecrok8TmJfS9aAjYo+CeWvkLHrsuxb3N+1mjdnl/NTPwGdi4ZqIJxl/hhxyI52D2cqXlGa3sTE7s8z4oDph3ZqAa4Qh941iauNt+ZHX6rrV9ntrSS7cDJTZM8zeAR8BwA1lq+uj2kshddjx3Kb54xNXKKIDeSS5RUuZt0oCPkbsIO9IhlCvBN2YW3/pl9wsB4U0uL2+UUj/zTTq0798Gqgram6n0jQKoSXx9DF5o0a03gxYQcw88B4SM2jGjcp5LDxq6SYyL1PtV3vMZjOAfMdzwL8V9G2fzBJZ4d4EbPLBjIngLfuRbyFeUC5NkWYOEVIGvmB+fqZVXdqhnOaJON7KgyuhQOvcT9HYrzDNrJPR+4UqO8hX+fBrX2XSbtN0k2tUdSD52fxwGEPr8m/6i8w7pOtjPA/YfUOSzJpAsT9GFjUduQhYjPQASHCFy1nqEgUvxEYDLe6lKaf5dXVNJQPUX0/VLV5E8Y99vi4lpMjBRRM3g0LYLoLBKFwdD5Az/xklwwIxhvDbR/Nfb+A+8dfKxCjBp3okjvLGzJj7dTqc1C2+28aR49zXgYWoeHDtLt2nSCS1T1rnllUXqUA18VZzhvitdKkKVBvsOQje4IHgucRwHvdg3i8QksMyon2wcT/ALu8uZwJlkbxZSw6Kq+3AqHEQIZaJtC95HRrwC8auRgtC9wJFAtrXcPtiDg5s3TF32s2RqNbFZOnwQar60c+nfrefz85N4a3QXOmRVjhXJs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AfcomcBfYx5gJeN//DOzQtq/GbKuUGD9bxYUwhqcAY9iQYG7DXmE2XfG4X3i?= =?us-ascii?Q?2F4xB+WB3aZDBobpiMrrVa0oWCunePsxm9TwmHMlMJX52ZFxWztydmqCbme0?= =?us-ascii?Q?aNq/fPcij6fsrUga/jZJ7TdnMI9rO8XTI/oREFwQg9he5WykeNC2uc6qRSWL?= =?us-ascii?Q?9yeDJ0ZuvGKuEbGn2eqTvt9BTDmKPYCz79W5ezibqTDS7BsKLHs1iSIm1n14?= =?us-ascii?Q?MVs54leXs5HeoogS+UEOxY+PjzE0Qebs3fSIUFqbEfVSce8fw54sKbve2qgJ?= =?us-ascii?Q?RKUdZTQm14EOIOy5OVhfwRgk8UExOZvkTPZENTMcOkwBB5kVAiDyipwFgF+l?= =?us-ascii?Q?WQSpRCFA9DEk+EUaoQs7kK1Dvn/1Gg945Wwq08ZLKq2X6Wkf0VZcTmzRWMNn?= =?us-ascii?Q?t5ybfVFhBNApjYnzVvbQ5EBAGYvfe7qRiA2GGJn0On37Aya6800dc+Pn88Gc?= =?us-ascii?Q?1Qh01/ATdfEvOFuxlM7rWHc/BnJZH9ybQ5iuHWq+YnDiRpg8Kjr2JmgyWxQA?= =?us-ascii?Q?D+W53heeZvsjhcMvbSsCwcSeNK/CCLgHCv/jvkPyaB6jCTe9y/lri3lj+Ihp?= =?us-ascii?Q?cwGpkN7ZooH19q51AWy/Rp+UHV7QdtaOM1lGgye/L1K83KozPeH7bgGp94tK?= =?us-ascii?Q?WmHQTyCnhw966mIJb901gyKStEbDitEgOctJVx+TOchSzQKqCqip048rkx8A?= =?us-ascii?Q?pQKWcpro4sEOEtWSqUzzyp8fAbtunrb4l1xfkPULvGAgGgsCcWIhwEwDN8lp?= =?us-ascii?Q?mjKlBof3mh3F9vtdw6qWiKv90pSN+4yy0/IQI8ggDDSOROtShgaeco5kYwaM?= =?us-ascii?Q?ezZTax/aGxQvEhG8UfU5ROgynnclQmPXAppS8BmAmh/3A72fo7rWcNeZgNZl?= =?us-ascii?Q?XvKTsaW1W7GJNM5aFnDAqN2Bmfr8eAzm6VNPufuF3GNzyVZoDZw566pIW76l?= =?us-ascii?Q?HhHnapnFgMFLOHUUoPTeYUe7PdguFOmU43mrSxZGe7aAD3+MkLOe7SD80sz9?= =?us-ascii?Q?TkIYZXldF436mthqOTzz2PhmUnOSyj6KxB8WnwxjsaL/itodNrQMtaSrwbih?= =?us-ascii?Q?ZIA8HPOdO/3r87LzrmtzmaMK+3o1YM1q/J/eURlZqp1RDcbwwl80GoMzuX+J?= =?us-ascii?Q?oNiS1sNr/4J4O4J3aS13Ev8OC6IiZSk0Hg8hgTx4yn9X37x0qtXioPHm+iAE?= =?us-ascii?Q?Y0+YweOHyyFw/UAvgzWY9N7kl/qPEqxrNQOY8dtLZ8sD06K2Hi3aUqQM2FGs?= =?us-ascii?Q?iyFLSTXQ58Qf7x0g5HRmqaDKVzXS8uzejEy//bXszzMczIdMpu7ohU8QrKBK?= =?us-ascii?Q?o9B0AaUs1LHu+Y0FsW4HJq/3t5TapAZqpRjbQGnMZPNuYrOEnCPa4p+Cg/5q?= =?us-ascii?Q?/zZ/BDqZV1zBVFyuI4WNtK3Hx8aTb7PLxHBeQNUASvKPMaIeFUmR5EDNlNaz?= =?us-ascii?Q?SDNLZiwSVcxckthbxsYmh+VT3qJfDe05jDw9dGvogt/+qIJszmjZvD6cG8rx?= =?us-ascii?Q?DNamT4EuKZftmFd0jhlRZedOB3LvV6hvmRSWGFFlMotwVF7CUOs4NSQepvWW?= =?us-ascii?Q?9pqZitq3Gn1n8OZsjZMXFSagONxVC5669rK28nelT4X+ZT4Me/UsdhcrBkvY?= =?us-ascii?Q?TDG3HzmGkTRdCpBmpGnsUkwLAyTSxdpUYAN4eksg87DN1DKERxszHrbjbZyy?= =?us-ascii?Q?ysHwlF8A+8AVNMgXS44PEK4Rd0oC+fO4jTAnM3M3YqkRNVsAZnnegKYYe+yE?= =?us-ascii?Q?2I2jS8z59u/qLSjnHxaJhyqAW8IxeVN1zSH5bEzrYS2h88wXp+Mk?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: bb1e0e95-e737-4368-da1a-08de7b7cbdef X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:42.7686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8/mG1wVGeKmSC3AdCaXGr1sgtAr1zqbn/Xd+2CTPQZGMxfutiua3qrRkEuC6Wwdp+hq6HhUX5e5V/dioYSIbmooGQ02Mo2mTN61BKqicZfk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" os05b10_set_pad_format() calls os05b10_set_framing_limits() before updating the ACTIVE format. As a result, the VBLANK control handler uses the old height when recalculating exposure limits, causing -ERANGE when switching to a larger resolution. Update the ACTIVE format before adjusting framing controls so control callbacks use the correct dimensions. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 4601e33b7e8f..476dbcb49351 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -902,14 +902,14 @@ static int os05b10_set_pad_format(struct v4l2_subdev = *sd, =20 format =3D v4l2_subdev_state_get_format(sd_state, 0); =20 + *format =3D fmt->format; + if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_ACTIVE) { ret =3D os05b10_set_framing_limits(os05b10, mode); if (ret) return ret; } =20 - *format =3D fmt->format; - return 0; } =20 --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazon11021109.outbound.protection.outlook.com [40.107.57.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F0527F73A; Fri, 6 Mar 2026 12:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.57.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800492; cv=fail; b=a2wi6EOYxBXOphRNlQr3zq97Y36Uq95apb4Z9YmjZZWDkrxG9K4xrvvw8PTchyXtVLT7jkYmGrrqUAx3xVuZjhtgFDiDuMdhFVoujLGpaHAgkCbZNZF6lD4a8RwccACrpocnAwIwFU1EuRcmbVC4wQRXHs2kVK/m2SV3SbOno/c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800492; c=relaxed/simple; bh=FKnsS6xBzsVLokGoYzpE0GH8Vvc9VT61O8JazkeJ/7A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=haNdtM4Qb0KwhT7H/1vq6Q3D30GDUbSursTik8MbvS8JCJWoKdJ2i795Uym0GPJMiHv6WzxJjpKR343JtkBj52evdfpYHMNJTzrpOu2jPsU8oolYSBVVXmmWMyvI7xpVC1965m01Ym48bBAq0+sPQ9lS720AOWUmEGKZtZlMEZI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=LOjmadkY; arc=fail smtp.client-ip=40.107.57.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="LOjmadkY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=okTNZjUfU/syuh3cEfVtKuEOSoCD94XR+NI0z1kEelXVeuQ83artXrWSXt1TteBSHu6i9tL5EDM2b53icx1vKsHR8ZfXRvtsvVHADkZ8MihRw0dvs411jsU17Ul8wV7tFgS1ykQe8wrswh8N2yJmHwiN+JnZKn2qeECo6h4iPULlnztqQqmefr5lyfiiqSAvDY5puqGXYXwcgxkMSfkI86kyLOcUXJihhunE0pW6tB/kJIoBWkeIrkkOVMfPcz498J5EPGhcfOUj213ZB/sL72Vud5sL2vjiU9vu/XaRMtjnr6YU5sWSiXWrEZqtEbCk5ChMKVy+hziejUwzTpWgkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOFzUf+yf6R7y7+kGjJe9lxRj5QQwxI1J2L5ixWASQ8=; b=WTgNbmnonGfSFyRI6mIuSDur/FbRZDfYCyS0EqbYbH6vu2ztRRwtlufQpQss9+VQeUM09AcybkPGs4dnoSKCtHoaWtXDnCmyc2+wghPnr4FbNhFvqr5gf+0tLibiucPRUbGhpkLs8aArU6FajEtYsGB2ZFizpsYw/lywaPeXv9uKI/y6zGl8ZXlEj47QONMYqZ26v6c60tYOldn5FpNdhRBqz0RV7fb1aZtnWfutJYMhOX+ycAl6mAC8VvK4SeoAgAAdZaX6VkyKJ03uSZxDxvpSla6WdVIyjn1h6V+zVf6RaCSzhue50lQ/VYZ4VIJNq3pAXrUlhBK/IzyJQBKN8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOFzUf+yf6R7y7+kGjJe9lxRj5QQwxI1J2L5ixWASQ8=; b=LOjmadkYGDFlwYUaVQQ9h9KiVd8PS1+QNr4/3JKI4z+whY5+q7GqeEzQ3p1edTPOa9gL1+WH25DlgRprQDVPtCVqxpA8I9feRxt2a8QhxKShQiRjcx6syqRt5OwtaxyLK+OeuocRpaq3DeM+dMv/cnbin0O3EO3PVdzFuVR0jGL5mIV8MLeee3Gd7dHjnitKxIjY6iXKLHBQlpqtqBzhh/b37Ndb8DAelXOPMIABaofqcTV7o7JH0aV+R/G+hGKFY3QwfvsSClmFNxyUR4X1GvYJPPd4sNilSOlKTXFqtDljCJT/DwF+GcnJm2CEJxNQhVXMw/lxTb0mLhU8Dzyj7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:46 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:46 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/13] media: i2c: os05b10: Rename vmax variable in VBLANK control Date: Fri, 6 Mar 2026 18:03:02 +0530 Message-Id: <20260306123304.76722-13-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: edf97dc3-6344-426d-05e4-08de7b7cc000 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 6A7KipMI2uxZtRP3bg615dwA/W82nkD4bW109bKZxKKxdvpQD/lqcbNy72yp7gwDyyoLvwwbgtmGBzx71RtJ7kQo7LNmdOpp93NLD6PI/GsDqF9DyUcerpL6IvjKM6CEWQGwuUnRt+0rrsr8hv3hY2mo1GoObZt6w1DI6xJBMVJJOYHOfw1b7fUDXxtWsfZBGo2Vpl9uSYDdjYpDnHBsea8UHGvFDgfPmv8pX+QjStpmE7lCBdExacxJsb06i76aDAFmYV6zQiRz65TeDkZelUmJIb6oPBm9rbgmdY8y3Ja31xmGLxTiZbhisJKdzPhqYKVz/AYNYMuJqTU6gHOwTknptSor8zAuBoIZ7ocAEBTJ3WCAzJ4iQ6tP1VajB+4CD+rh/v657RTq8h3tuZzVhzXYfVFgVM+gRuda8QScdlGNmWJWDkxM9EtFHp/JZwPBEx7OHQDI9e11eaJ3Kc9tQi+EkT2eJlg3DicRQQFFnuBYxumGm6JpmT85ZtAyjpWd69fL/S5LnQRoltfMxgUGcfyvX3sMK5wdaQE8X6zWs8gSSMIwu5EZz0KAhbz2MKe3nzi0gXG25zXpM/yjf3aqldpEWgjhhb63/8eUcH0GnoOiqwMsqnwTzVGhtXRfKYI/2rgD1AoHx93IFQtlofH7v/2LAFB13HDxr6/UMEwe3AZSMo/VJF+/oB91D7epNMEbOjWwh3+qM0tJLZD+QjeZqwD4AkaZLZ5a36GSvRJIn84ksQss9Xdr09+dPFZOIHCSNksN9CkoWFBZer4OOQGPogwf7Y0wfLsq7+3dnFuT2Do= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yMZWWpAVfR0xcLRpr7ow6eSVbclAO8J6aowUo8LF26YD3PDzAO+X+MMbqGzp?= =?us-ascii?Q?IlEjwJ4E24WyYe6Xun5/nnr8qddBBtOMdbIDOU9jZi9g+1ZpRKRgD1BOpFiU?= =?us-ascii?Q?/b60u4yaNnxZiMN3uM+wrNhCcnI3G1vYwTuE5AaGcF3DpxAuhVbKkOMUT+DM?= =?us-ascii?Q?TtoJtUcdYMZLr7n/Xo9m4YhRQc1wwMPyNRTsuQmt7GeFIYCw9cJQTnsh+Xwu?= =?us-ascii?Q?8gL0EHZ2d62CMa4PMzW60w99t9C/sq9BPnDcbxIXRcVKsNdkIQYJ7FrtCeRP?= =?us-ascii?Q?hANiaWHQFebZPh/bLJyG7lmKYkGOST947xkBatlQl2S7lVKRGNvtvDpBAZFs?= =?us-ascii?Q?zCIv4IhIJEnxEy9f8FBJQOTLaYrhzlYQ2ytC19HdlkrZcrW/gVfBsjZfbE3e?= =?us-ascii?Q?OWbJ6QLS9oq18DVvP8NxX4jPu/nLKNgg5W6NdBD32V84p4uvkeBsFYJhmOzM?= =?us-ascii?Q?C/WMmlDIfyqqfD/2EefayPOB9kFxEOOM94D1TmSrynBsw+K1WQEE59g/8VB/?= =?us-ascii?Q?X7l8mpSRqc/3atZSkZdnXfRgX3vV+Z51eUhC0Bk+xpH++c/Ijq1lhVHXTmmj?= =?us-ascii?Q?oGoassqiUVnRfrOFGNPasoeGwwb4vC+gitqkVGOCtVIP47v9ERLDzH+P37Se?= =?us-ascii?Q?krAA95wGW5bpGQFdM3u474cyaBcwMr3xwjO7ksuyhPuEp4yCuTDsdEC4Bdmi?= =?us-ascii?Q?GZSR5z0dKx+TcPFfpGDSo//u6uePjy0IUDvr62Vl8DfKBAlIVgWIxdgesuAY?= =?us-ascii?Q?jRRKTobbgFZobKsR8MNBusZ5doNkmu9ndNN7d2ye6tTxSC1PQcHAiF6R8Wj6?= =?us-ascii?Q?z30W1A+zpG4Q4VIIerwfpz1X7EM/avEupecGgQj+uaBTvbvOO0zPwZxDf1Zn?= =?us-ascii?Q?qNFjhhjDMfsagyyeyPYQRk3GO2y45XWVQchBANZxL9ItXuiU9aaBD6uvrpJo?= =?us-ascii?Q?gBmLYvYX30ouYD9vjVBFbkWE0CzFl9UojPf7WBUUfadr+s+fuZ1KtCzWQ7Ue?= =?us-ascii?Q?dtbvr01Jr858JQ+w5uOKXFgBnrn4FBnrTVwQY/m/Sx8dgErYVILhDCZpvOAK?= =?us-ascii?Q?rxh6VjKITqsx3r7eaglLfDNtZnOSSPKfPSRr+JkAhAzg2p0sHgcG1A0lHvn6?= =?us-ascii?Q?jus677NMJd5mZJgMMPZ+exSyg+DTRQ2C36Blvp1EgZAtJV0iZ6ab8Kk43LrF?= =?us-ascii?Q?TUU6otXxUQp/i2HTTgNJzAOasRrCiM63vCPFHwI91SjuoIO8gV7X9RG9Sp6W?= =?us-ascii?Q?EMebDNoCFe+WWvRb0rLDkybD9zIpACSHGYqf4e/Z9/tZV3Kv20DMPMaHYM2w?= =?us-ascii?Q?37uR9VgIP03+OzbmYPM0A8NBGZX5CIffMUO1+GGlfcHYb/IsySb873XL2Xgo?= =?us-ascii?Q?Vmb7YLiVpIn63kxFJE0s/cKN0Y0zCTvuZQ5+HDOfYp3T6p0R81Uhv88A8NtK?= =?us-ascii?Q?xkAsremfcy8BS84+OnXai9ls2V+a7wSN0LCvviDdMwJN7xQ5kh22dCb/HZl2?= =?us-ascii?Q?LUjjJ23uaImjNKGRiyURrjyTKm8LI1Oe1zJQ50mFBQNbJGLmbFJBzgXGUF1q?= =?us-ascii?Q?tOMDC8eZPU1PJxXTw67lECH4VSoD5lHw4j2+rI1uUqM3BF1TTpRDVC59wRXL?= =?us-ascii?Q?obXy7Cm2fbYQ82kssIYgZAIDhEgOdRnYGOq49mIsiv85IshHHcDvchZP2m02?= =?us-ascii?Q?d1yF3f5SsG6EO3DIMeKPfDwrar/bpYXh3iDniwpQWbjsXLmK3oSMlZPe2PZj?= =?us-ascii?Q?6fjXy0kCQJajl2bUvCiUGl4/zA1jjU+2kPoDPFSi1FSWh8wl3U+f?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: edf97dc3-6344-426d-05e4-08de7b7cc000 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:46.2511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gnZ+JlfOVNUqnC/jvelAa0AUg6u8OW50EfwGbF1NfPfu7c2fG+nPXGb+tdJFAxkiVdkRr086DyOEc00sVhXli6WOU19BPF47clCDd+ovF8Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" The VBLANK control programs the sensor VTS register. Rename the local variable from vmax to vts to match the register meaning and improve readability. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 476dbcb49351..1393c7b5d860 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -724,7 +724,7 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) struct os05b10, handler); struct v4l2_subdev_state *state; struct v4l2_mbus_framefmt *fmt; - int vmax, ret; + int vts, ret; =20 state =3D v4l2_subdev_get_locked_active_state(&os05b10->sd); fmt =3D v4l2_subdev_state_get_format(state, 0); @@ -745,8 +745,8 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) =20 switch (ctrl->id) { case V4L2_CID_VBLANK: - vmax =3D fmt->height + ctrl->val; - ret =3D cci_write(os05b10->cci, OS05B10_REG_VTS, vmax, NULL); + vts =3D fmt->height + ctrl->val; + ret =3D cci_write(os05b10->cci, OS05B10_REG_VTS, vts, NULL); break; case V4L2_CID_ANALOGUE_GAIN: ret =3D cci_write(os05b10->cci, OS05B10_REG_ANALOG_GAIN, --=20 2.34.1 From nobody Thu Apr 9 17:15:55 2026 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021097.outbound.protection.outlook.com [40.107.51.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71C7D37FF5B; Fri, 6 Mar 2026 12:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.97 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800496; cv=fail; b=fmNGxnI0EI0HlMbOBdgAp84Wc5uFUKpAPYRXyCklqfm8IHjYr52a6XFloKIUvgBWlxNSa4ysiozLTPdb4x3L48P64wK64AC3gfd9H/iGB1rKzWaNeX9/SuHfy/YguSSigeOVrJI0nOGrl8Ixg7iJoow7dZJpxGcGUo96k6y5gSA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772800496; c=relaxed/simple; bh=8vW6hKIOuYbA6p8tg4a9iVQtofTq9Qe2osCPw0sqlQU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=UjFjKCTGZJwnrPOLfrchDLtGEWClflrcy0ydI/wj/3bIkGMGC7R6wpi38Oq4iuQudY9Oge+h+DHVgIkpPscg3Zaa6Qv8uwOxEyp58gBS0VR8W6M61ivl0PdI5VEueQZHP+X9pmJgLBSOCkIMauDPQyH6ahqpf1xBT6U3/xVi/Gw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io; spf=pass smtp.mailfrom=siliconsignals.io; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b=J1XTNYfr; arc=fail smtp.client-ip=40.107.51.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siliconsignals.io header.i=@siliconsignals.io header.b="J1XTNYfr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xPZUytdWns+TgO8wm5kfJuJfBsE3Bl8q32uDG54Yv/RSxJSY5xHJWorv0Uq2pPfDaYPTs+CAUcIx05QCYQgBOPp0ZdwmVookaEJxPB+yHT+cTRXVC/dOkrVU24hX3z5hrz2Vqdpdu78T8c4o+JYTbqjWpOCRoEARAPL4HZmcXFvTmQvWggkwZ2HW9qfuEKML1TTeZ1tXEpnR9knyEZpaiqud0PsTBry/JXoFWmVfPTXSVP91zSINbMqlMhavlWEprrNat1WO3nHjB8JygjIfgOpenzft+R+ReLgR8Qre5j3LYCTkyyJtD/21DZkjvHgOy9a0xdAVQi7TTc2yeGhxgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pShkqziqgYQgxboMD9cIHMuhnmY1id4iTVd2TP4eQHY=; b=y1XkVuda6+5onVzHURAuqKZUq2QlN8dICYMXG59SM74G4wn8Qk+9oTH7//RILe0Jir5TcL/817n25+4IdFTrnuwMDU/7+vJ2n5bM2rZak0RWLMMWUBO+blJU561+raNy3xZz/vUSZkYcFsbMtCDdVTprlib/tw1HOtX1oFIyAjxNyITjAYp7UQQlUw60+cvNFOm0I0EHJBxmebHZrdlQMwSz4GSKms6XTGts6XUa2kNjqjdh5kuBfO2GzB1Mw/zaMvsI4Ksq3d9zB2AKv4QTiUndX00bObBGCgiUvzGHP0fBO+UH7YLck0Etl8ygkTNLxzDrFerVMtfKhH19fmPfqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siliconsignals.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pShkqziqgYQgxboMD9cIHMuhnmY1id4iTVd2TP4eQHY=; b=J1XTNYfrSvGCqOrJRx/JdHqWFmCyjuVSyggpbr7w+zBlCmyqLccMFYukglIcNkSPBShTQIY3ZbJqKKmSU23J/yFritYrKIIdbAqW8xdRM7glLIFg1BagrqpQgHlQnEB6XIxprrz5LzjojOKaA1259l3VSnH/BcpgtAJ79w3cC3pI/HOVQVR/ctQSw3flMb2es/XzHcyoAqrg8/LYKT7sPK40Er4W1u19JBES0yrH3Y0Gbht1nJu/gkR2jNR6iU6ry55h8i74ZrQdsl8K/D4eubk+Zos5YjFSHvC06sHKJsDhKZuoEJoPQilRB/7Xmss7b+IqbrxnWjSBoCWwA/58pQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) by PNYP287MB5365.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:30b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 12:34:50 +0000 Received: from PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b]) by PN3P287MB1829.INDP287.PROD.OUTLOOK.COM ([fe80::ce63:5749:b390:508b%6]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 12:34:50 +0000 From: Tarang Raval To: sakari.ailus@linux.intel.com Cc: mehdi.djait@linux.intel.com, Tarang Raval , Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/13] media: i2c: os05b10: add 2-lane support Date: Fri, 6 Mar 2026 18:03:03 +0530 Message-Id: <20260306123304.76722-14-tarang.raval@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260306123304.76722-1-tarang.raval@siliconsignals.io> References: <20260306123304.76722-1-tarang.raval@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::17) To PN3P287MB1829.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:199::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB1829:EE_|PNYP287MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 023023f9-5f16-4054-641d-08de7b7cc256 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: SIpo1rFzRCsnD1j+dZHpDeXVHwwzYlGIgFPfbxESYajYZyzeXkNrhrnsyLkB6OORuSUkhmYvbseVLCSa0sp0AgXnueoFd/3Z8p+bs3nV2XIAmg/tbaE+CxocjgusNfcg0zwISE22uoakQXPiC5SSBA/STcbhf7gaBA6jcgXq74bKg3EQxKQk6iqv/cwhRlWIpoN7mB4WkkdSWTjBqQHt6YtQ/cG6IEWRDpBWqRCJK2mbuPJE/9HlhHV8xqKt93r3Au+CvJyNSNwn7J4n9zp07vLeQtuRxCcDBWHLeqhoBkb3tAm8OxZizB9EfkENcQzLkfi+qVaD7ZuzEHc2Az43LLnXwUzpzQt9N4nWP4TOFNNja8DZptQtFZUBEQgneRNoM0cgihneFYFFn+rA+CCzHPYAEsYDeJYU2p1zbuGZ/0BB6Tskb0mVGYSMAZjUppZY0w51AG1lGCeV/UDdLiaeoKZqSZZR8iXZG9JsG3t0KXrB6VKpv9ureq/iI3o4GriYxxkLqWASdJSW/smxeOubFs8QvBcI3qV25vYI+4xW9S0+gybcAJ3PMa+3iz5Oix2He1SIOoveg9Y9c0okD8eqYA3KYYH08xdOLS3oK135pdJFjwwelv6aoaw/dfXKFP8mdnLkbuLt9TLz1ZhlkbUOAl6ps1m7N9pOqRTmYU0pg9hbwQRFJ3tqR83oP92bn3I0oC92yNPFn+4bmwo34tfsIQwb+BHdds/G7d9Grrh26U/TcdgSum09wX3Zo79HW4gwG6AhL7HZrjFmkJlRxJn/nhUEePKriWjXxBSGDSq6pA0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB1829.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MpGY1jPRzHeILavv3ntRnJ1uA7ONEbxTvqLKIX9+mglbGXhzSt0BMM8WRw1K?= =?us-ascii?Q?dVMAiIG9BfWW9eXGLlr9f48E3nQXVTKNUg0DCfVcQ/z5OiEVqC0YMr4HglbZ?= =?us-ascii?Q?QTAPEHS2fgLV7rlB4RcUfs9u7QetOqvDJqByjsIGjXTP7riuDYZ51JxMgOyH?= =?us-ascii?Q?gxtKsvhFAYD8sr1Fe+K5a1zVmKC2pEQILzwINfr/ZWo5ZtTxc2/f06bpyCh9?= =?us-ascii?Q?ERJB4+nvCrt8mVx8AKRzR57CjWApDhMm67pXdPqADWOMhdO28qqW3A6li6x+?= =?us-ascii?Q?ZW2cxPKgFZtZ2PFd3cZO5QDRjN6GOjQ7j2Z0cBD6Ab48sstEA6RCuzgwEuSo?= =?us-ascii?Q?Qm+wgh6f17vXqi5EkYSMddv2l4ljhhW+HJ3NltLQ8A7qW4MPPaKE/20kf34E?= =?us-ascii?Q?WR0ltn+nChMBB4kkqodOaT3jxBa4umy0yiiXuDS6JmgPahWdyjKP5/YBsHEI?= =?us-ascii?Q?EX5MUbRX1vb2aZ8dMWglMT46ugCdCsk7JptkTISoJ1aVSPORKxa/Jn6PEBiy?= =?us-ascii?Q?Q7tS88Px/r1HVEEFHsK5/piM6+FV3Ys1C+AWpLjustpMuwK8XbMTTCtsf5LF?= =?us-ascii?Q?aJYsSWvLAKzxkZBY43pI0iWP707p8eTpgte6pAgnkn7Y9llGxkNdo+A50XeS?= =?us-ascii?Q?WBwGrG1in2eyQfAivGjUb48ZDyy0BzD2QvEc3/Bp1g3PZyWR2hiNgE9lOXjk?= =?us-ascii?Q?esNwNYtcjGjU24SDUo4tJnkw7WS4B62fNH/HmaULSGQe9ceA6xqTDCICjWWk?= =?us-ascii?Q?EWNs6EAuv+wE5/QMddAmFBUPzB9vrK0GR0QKfUHfwj6B+hKu2z+OaNBNkAwL?= =?us-ascii?Q?WQqQY+iKZ7IE0L7vRjpj13bZHJWjbtP0pB41Khy5M/d7YyhVMI1zPNVfQ08h?= =?us-ascii?Q?4exLsv9l1wpbDeEGx6Rte3HW3e737jJAtModGEyEXVHBTWTTy/X+qx2O39a2?= =?us-ascii?Q?EETzM+EHbAIL+LOlmpj8RaIPBhF0EJgkUCZNSQA6fHC7xc1lNSww8atzbBi4?= =?us-ascii?Q?rQXdFa6tZOwgcI2TUhBpx7YamDZATA0wDyvSnvn0x5OzH+SOJCnkEQjqkEQB?= =?us-ascii?Q?HkYg+UpXjwOZl6SZ0ovTZy4Ln/EasnW6ZON1RZrmMcL3LNKChlDsg1wsCoAI?= =?us-ascii?Q?d98t0Hpz5YYwFCjKEeAWkKhGfg5SRwbfSchf0SH+6XTZGEYJ2wkgSV4l2t1Y?= =?us-ascii?Q?zCHYNAoizCgAEovTt8HIhtyxSN36fJxEszWTDt2oO1v1sRIThYMxf9gENAKy?= =?us-ascii?Q?YsGDA6RUofmK5OugTyRdRM4evJSo78Qufic0mBrNZHWDQppfeOmiHHU1PDOn?= =?us-ascii?Q?LVPOAY2MNxgVYMwEYOZNQI9BvJOiasmfxs8wCpjgmzzNuiVAzps1NScfQM+M?= =?us-ascii?Q?9PLoRsTbqtmCi4hQRpigsZcqz7v8ierZgregvt1kFdaQnoJkmDHxCzqEKnK8?= =?us-ascii?Q?5QVVjQ/IqMNLLcusIfAUn+LMXIzE7XWSP0dSdDxWRHK9CMguJwIumVdA5u5p?= =?us-ascii?Q?X0f5hPj1LGwpXIOsQi5KcAYu/jbTK0gvRTY136/xC86lvR4dd1skF4R5i2Jj?= =?us-ascii?Q?2ZMKuq19z99LA/s2XfSgUgiXfSFgb3uGBFtOnc03tazSP/kcTSHyZIW+0ocr?= =?us-ascii?Q?PmRGKt3zmSPzJdmyS1CUuAXsmq2NXspvuXSKxlYa/7iGsKaFOvZ0qi/QlW8U?= =?us-ascii?Q?jANG4C+erGyq6NViiK+JdNCssB2nb4v8Q9xMhQDS6kxPN9BC0AlmEOb9b448?= =?us-ascii?Q?sVI1ldbck1nsnUeLDjHnRQay+30Sb5e24qR/7n6ltyDHywspZL+z?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 023023f9-5f16-4054-641d-08de7b7cc256 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB1829.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 12:34:50.2040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7PfF6cdBf6D1QjZnVBbVo19vvLBhi8AyPTVonfqiO+GVndm5q86G2x2/cVCiX+R4HcADKtGsOe4ol11+hj+Xi/3577CARr1qzQMle94VSBY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNYP287MB5365 Content-Type: text/plain; charset="utf-8" Add support for 2-lane. Update link-frequency handling to select 750 MHz for 2-lane and 600 MHz for 4-lane, and adjust pixel rate computation accordingly. Extend endpoint parsing to accept 2 or 4 data lanes. Signed-off-by: Tarang Raval --- drivers/media/i2c/os05b10.c | 94 ++++++++++++++++++++++++++++--------- 1 file changed, 71 insertions(+), 23 deletions(-) diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c index 1393c7b5d860..7107a69157e8 100644 --- a/drivers/media/i2c/os05b10.c +++ b/drivers/media/i2c/os05b10.c @@ -114,7 +114,8 @@ #define OS05B10_TRANSPARENT_EFFECT 0xa0 #define OS05B10_ROLLING_BAR_EFFECT 0xc0 =20 -#define OS05B10_LINK_FREQ_600MHZ (600 * HZ_PER_MHZ) +#define OS05B10_LINK_FREQ_4LANE (600 * HZ_PER_MHZ) +#define OS05B10_LINK_FREQ_2LANE (750 * HZ_PER_MHZ) =20 static const struct v4l2_rect os05b10_native_area =3D { .top =3D 0, @@ -137,12 +138,6 @@ static const char * const os05b10_supply_name[] =3D { }; =20 static const struct cci_reg_sequence os05b10_common_regs[] =3D { - { OS05B10_REG_PLL_CTRL_01, 0x44 }, - { OS05B10_REG_PLL_CTRL_03, 0x02 }, - { OS05B10_REG_PLL_CTRL_05, 0x32 }, - { OS05B10_REG_PLL_CTRL_06, 0x00 }, - { OS05B10_REG_PLL_CTRL_25, 0x3b }, - { OS05B10_REG_MIPI_SC_CTRL, 0x72 }, { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, { OS05B10_REG_DIGITAL_GAIN_SHORT, 0x0400 }, { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, @@ -533,6 +528,24 @@ static const struct cci_reg_sequence mode_1280_720_reg= s[] =3D { { CCI_REG8(0x4837), 0x0d }, }; =20 +static const struct cci_reg_sequence os05b10_2lane_regs[] =3D { + { OS05B10_REG_PLL_CTRL_01, 0x44 }, + { OS05B10_REG_PLL_CTRL_03, 0x02 }, + { OS05B10_REG_PLL_CTRL_05, 0x64 }, + { OS05B10_REG_PLL_CTRL_06, 0x00 }, + { OS05B10_REG_PLL_CTRL_25, 0x3b }, + { OS05B10_REG_MIPI_SC_CTRL, OS05B10_2_LANE_MODE }, +}; + +static const struct cci_reg_sequence os05b10_4lane_regs[] =3D { + { OS05B10_REG_PLL_CTRL_01, 0x44 }, + { OS05B10_REG_PLL_CTRL_03, 0x02 }, + { OS05B10_REG_PLL_CTRL_05, 0x32 }, + { OS05B10_REG_PLL_CTRL_06, 0x00 }, + { OS05B10_REG_PLL_CTRL_25, 0x3b }, + { OS05B10_REG_MIPI_SC_CTRL, OS05B10_4_LANE_MODE }, +}; + struct os05b10 { struct device *dev; struct regmap *cci; @@ -652,8 +665,12 @@ static const struct os05b10_mode supported_modes_10bit= [] =3D { }, }; =20 -static const s64 link_frequencies[] =3D { - OS05B10_LINK_FREQ_600MHZ, +static const s64 link_frequencies_4lane[] =3D { + OS05B10_LINK_FREQ_4LANE, +}; + +static const s64 link_frequencies_2lane[] =3D { + OS05B10_LINK_FREQ_2LANE, }; =20 static const u32 os05b10_mbus_codes[] =3D { @@ -804,7 +821,9 @@ static int os05b10_enum_mbus_code(struct v4l2_subdev *s= d, static u64 os05b10_pixel_rate(struct os05b10 *os05b10, const struct os05b10_mode *mode) { - u64 link_freq =3D link_frequencies[os05b10->link_freq_index]; + u64 link_freq =3D (os05b10->data_lanes =3D=3D 2) ? + link_frequencies_2lane[os05b10->link_freq_index] : + link_frequencies_4lane[os05b10->link_freq_index]; u64 pixel_rate =3D div_u64(link_freq * 2 * os05b10->data_lanes, mode->bpp= ); =20 dev_dbg(os05b10->dev, @@ -972,6 +991,17 @@ static int os05b10_enable_streams(struct v4l2_subdev *= sd, ret =3D pm_runtime_resume_and_get(os05b10->dev); if (ret < 0) return ret; + /* Set pll & mipi lane configuration */ + if (os05b10->data_lanes =3D=3D 2) + cci_multi_reg_write(os05b10->cci, os05b10_2lane_regs, + ARRAY_SIZE(os05b10_2lane_regs), &ret); + else + cci_multi_reg_write(os05b10->cci, os05b10_4lane_regs, + ARRAY_SIZE(os05b10_4lane_regs), &ret); + if (ret) { + dev_err(os05b10->dev, "failed to write pll & mipi lane registers\n"); + goto err_rpm_put; + } =20 /* Write common registers */ ret =3D cci_multi_reg_write(os05b10->cci, os05b10_common_regs, @@ -1184,22 +1214,39 @@ static int os05b10_parse_endpoint(struct os05b10 *o= s05b10) if (ret) return ret; =20 - if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 4) { + if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 4 && + bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 2) { ret =3D dev_err_probe(os05b10->dev, -EINVAL, - "only 4 data lanes are supported\n"); + "4 and 2 data lanes are supported\n"); goto error_out; } =20 os05b10->data_lanes =3D bus_cfg.bus.mipi_csi2.num_data_lanes; =20 - ret =3D v4l2_link_freq_to_bitmap(os05b10->dev, bus_cfg.link_frequencies, - bus_cfg.nr_of_link_frequencies, - link_frequencies, - ARRAY_SIZE(link_frequencies), - &link_freq_bitmap); - if (ret) { - dev_err(os05b10->dev, "only 600MHz frequency is available\n"); - goto error_out; + if (os05b10->data_lanes =3D=3D 2) { + ret =3D v4l2_link_freq_to_bitmap(os05b10->dev, + bus_cfg.link_frequencies_2lane, + bus_cfg.nr_of_link_frequencies_2lane, + link_frequencies_2lane, + ARRAY_SIZE(link_frequencies_2lane), + &link_freq_bitmap); + if (ret) { + dev_err(os05b10->dev, + "For 2 lane 750MHz frequency is available\n"); + goto error_out; + } + } else { + ret =3D v4l2_link_freq_to_bitmap(os05b10->dev, + bus_cfg.link_frequencies_4lane, + bus_cfg.nr_of_link_frequencies_4lane, + link_frequencies_4lane, + ARRAY_SIZE(link_frequencies_4lane), + &link_freq_bitmap); + if (ret) { + dev_err(os05b10->dev, + "For 4 lane 600MHz frequency is available\n"); + goto error_out; + } } =20 os05b10->link_freq_index =3D __ffs(link_freq_bitmap); @@ -1229,10 +1276,11 @@ static int os05b10_init_controls(struct os05b10 *os= 05b10) =20 os05b10->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &os05b10_ctrl_op= s, V4L2_CID_LINK_FREQ, - ARRAY_SIZE(link_frequencies) - 1, + ARRAY_SIZE(link_frequencies_4lane) - 1, os05b10->link_freq_index, - link_frequencies); - + (os05b10->data_lanes =3D=3D 2) ? + link_frequencies_2lane : + link_frequencies_4lane); if (os05b10->link_freq) os05b10->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; =20 --=20 2.34.1