From nobody Thu Apr 9 18:48:12 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C9F37C114 for ; Fri, 6 Mar 2026 12:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799734; cv=none; b=asFsTcFxnHaFoJ4uEPmVDcbPK7TqKLaCxoAXKs/ZMuU0dAm/Isb9f6X0qOBAlOt4bwnpr0v4SrFTwhRtOM6uE7MjvTm5OK+49y29Wasb6ZoYGNKaFEJswKcemI5h1/E2GS3fD+EMgGhKRNyis4qrJ/rRor4ZvA5Fu+MeKRVfigk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799734; c=relaxed/simple; bh=AhoflfyPSEypIadA7rENraHqNcIi0OFcEnzEL9v8we8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KoPfNYCQYign/jcVNTWinN4CYYwWBe4U6uGPZWOPEEZ3zHOkV82voGrhQEeUDD22pxrNd2WFDout8ulPks7Ul11wKIejLsshuQc4GUJypo4esffC0/bff/B0F4vMUp5R1kiQRY0/YWXVTrS9VANKONxWJva/YbS7VqEKMxjS//c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VYETanTp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OHrddHAo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VYETanTp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OHrddHAo" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626BbKTe3257100 for ; Fri, 6 Mar 2026 12:22:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=PS19lL6QwLa ikI1GyQO9iydtpc90HsQ6A4ACO7BE4wA=; b=VYETanTpP9TKbfw8VB9Q1wzGu2f 81uLF3VdflICc8WVRkd1rvVwhCU0iaAZSYRe+unDyhiY3uBXgaTw5T5a6xGtJu5o v0Cosrptta2XIYPalxG6L631WHKhnC+6i5f3jf4M/HFrTK6eQyI3ORYhStO101MW q1rdH4DQTZumHS1d80YmIz9musaIzLNRee6uOzHdX1ntq6fwzriEOD+IKTNZsMEZ oqzgAHxwSA/efwk8DSGikwhsP85ee3oEznxbDFq+IJCdGc4X4ZcY4PuWgz3vKIyw lFoAhp4rZSZRfBmQiQln8Iy/59MOPQ2hTgohXfXGBXtBDfuYKLiLSHJAksA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqg09u1y0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 12:22:07 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb3a2eb984so6320234685a.0 for ; Fri, 06 Mar 2026 04:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772799726; x=1773404526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PS19lL6QwLaikI1GyQO9iydtpc90HsQ6A4ACO7BE4wA=; b=OHrddHAo83B86rMGxrGrGa2eUuvzQmYMnxpA361W5V7qoTwTz2v/nJIov1Xc3vnnJ4 hAQvodmRq610hxRuQR7b1SiuW3qNLBtvMt2xypB0DIoTYFhqWt70wYma9hE0Xt8/HKKH 2vFu72LndCOXlUPTO6XeDMfEsPpR4MPbiy/e1t7oX8tFwn3vm59yZqDm9sl4ZdV7bkSj lw8hVar/XoDITX9upja7IWfWFiBAKyQsOW/87JycuLn/Ku5SvIh2mXq6P50CGRPUbkQB 90DJ+tH+Reyo8IARq93H8yoSAmG/rTmoHnHZiKb9THd/7nssiaVuRuEg04sZa4T1xwYn s5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772799726; x=1773404526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PS19lL6QwLaikI1GyQO9iydtpc90HsQ6A4ACO7BE4wA=; b=iPRkIWW+FiXerMDy9fnmFPJSrtnGiHfyH0H+cUPTBU1Q24mGparnwFuIziWLnqOX7d m803HaPYq5+fO+NhfGWU4EXxd468pnlw/BJ3jc9JkioyBN/0yvHZXUD3xcP+b4S+Fawc ygf98zHgo9NNFntr/AaNf53Vy0sl6bkASKgHzBZDOW6ONQyHaiTQ5h76YGBeGsFMmeRi LMFgRIuQEHn+Hg4AV3DiQZsNrhqXjnJqoWyRoAPQDP17dD4/fVuEE2/EytyxTLd4l8xs TYWWEy/MgFiwlIVHDRUhUoA86po7TK1VadHXN28F5DYqlrzCAHs2FtiAP/+8o2MqffFm c4mA== X-Forwarded-Encrypted: i=1; AJvYcCWiIBtBb3lVirb4fOg75mJpss9SZTavH7gbj33TVqUlghO0GlDjNE51PNI3xJPUlGilOn6OouJjwnSTgX8=@vger.kernel.org X-Gm-Message-State: AOJu0YxnLSE1pXTzUCTa6Sc9IdlcfblFAp/7CKkU8LlT1YUFJJ7QAx1J AcENJogQXvBbRCPGRY8N/87WigEGyAz+/LmDhXfy810kH6rVStZHMB+N8Xx7tWMhjpupqkbc12Z XpVU2jUdQmN4og+8Ti2d4FFgYOHVmoEJgQSNXT+ZCrDy0RJs91ZKuRr3ZgiTcrbYWRRQ= X-Gm-Gg: ATEYQzxvVQud6mOlB+54LMiazFYrJZ75wShzZOscF9Th4HvGeiirZNY2GoM88Y4YlPZ 8D+KE6a2EZLR68RWYnB/RgYj9alvtjfgTUTYFngPFcI9hUjFmhkezYYnCJFNgLvAeWe3Y/4Rhzm wYHBwL93hxcPO2bYx+cvtL98MGsIJwTSfVRn3MC/fPU84K2li9U8aUjWRPzUjy2KOdUAGKCSHRa FWbvgY3CQ3v4we4Bh/af8tdoxtlmuy5GPlP0UpBaEsu0Ywdh7JWk5lLguNNfdCgMf6l6w0HVJSW BZSjeQmsDAKHmAg9DylrpcBc6xzdpgf+gO3h7nPes1WzDpcot1eK/lCzbw1D9gTVfk4TNI3JHOg fOkly+M7OqWtp3pfS2kIlbrDvl6FULpgoUBddERWGm3e3lYBr6+YM6UI= X-Received: by 2002:a05:620a:d8a:b0:8c6:b247:4c with SMTP id af79cd13be357-8cd6d3ecdeemr229073585a.2.1772799726350; Fri, 06 Mar 2026 04:22:06 -0800 (PST) X-Received: by 2002:a05:620a:d8a:b0:8c6:b247:4c with SMTP id af79cd13be357-8cd6d3ecdeemr229069585a.2.1772799725934; Fri, 06 Mar 2026 04:22:05 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fa87e56sm111972395e9.0.2026.03.06.04.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 04:22:05 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v4 05/13] ASoC: qcom: q6apm-dai: reset queue ptr on trigger stop Date: Fri, 6 Mar 2026 12:21:07 +0000 Message-ID: <20260306122115.509705-6-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260306122115.509705-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260306122115.509705-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: yku7s1ZOeP2jnARj-UgjrXTTRcOwRaC1 X-Authority-Analysis: v=2.4 cv=b/u/I9Gx c=1 sm=1 tr=0 ts=69aac6ef cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=w9bA4Yi6UXS1dLCTJJEA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: yku7s1ZOeP2jnARj-UgjrXTTRcOwRaC1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDExNyBTYWx0ZWRfX1ttNe+LnW9JK A+/loqwvhDcuBxUY2SQi8Q26Ntz4kv+2QpRIOMyt4tQYtqw+/SVHXGmtSA4vrxArLOhYzmBhH5O POqrYBl0KusFmPXZ5qXNvEGHngGSt7oAtzgS82//Miw8cIBtkOw8eD/9k0F9VYZOSOqUPp1Vusq BntHJd0xGyc11WPN4I+YkHomc4N88Ng3SsxSy4OUjNX+/7p3w0XroEjNWJvwQUW6xYyhFN2lITD PfP/zInLqpB5CURm/esKVHKp2p9pxGeXRDmcoRsdCTZKB6tNAyKwxqzSm6vshYo23if4JfYR/iI krq31Z28dTxOlxWdQdKgOBmJX9xPIkpHoUig6+RjOsPBs9jo1ahra+jjxVlaWRFWJ/5z6Z6sVcL JNJ3aMw5MUAPwF2aXvvvsFdlMb9um91KJYGm9bb6XkAEa2rPlfDH9aXtgXsIeVB3fg3RQSsXRJq 6+JspSkjgwPywR8MWHw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060117 Content-Type: text/plain; charset="utf-8" Reset queue pointer on SNDRV_PCM_TRIGGER_STOP event to be inline with resetting appl_ptr. Without this we will end up with a queue_ptr out of sync and driver could try to send data that is not ready yet. Fix this by resetting the queue_ptr. Fixes: 3d4a4411aa8bb ("ASoC: q6apm-dai: schedule all available frames to av= oid dsp under-runs") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-dai.c | 1 + sound/soc/qcom/qdsp6/q6apm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-= dai.c index de3bdac3e791..3eff45b241c9 100644 --- a/sound/soc/qcom/qdsp6/q6apm-dai.c +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c @@ -317,6 +317,7 @@ static int q6apm_dai_trigger(struct snd_soc_component *= component, case SNDRV_PCM_TRIGGER_STOP: /* TODO support be handled via SoftPause Module */ prtd->state =3D Q6APM_STREAM_STOPPED; + prtd->queue_ptr =3D 0; break; case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index ebd5e3ac0366..f190ad5e912a 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -215,6 +215,8 @@ int q6apm_map_memory_regions(struct q6apm_graph *graph,= unsigned int dir, phys_a =20 mutex_lock(&graph->lock); =20 + data->dsp_buf =3D 0; + if (data->buf) { mutex_unlock(&graph->lock); return 0; --=20 2.47.3