From nobody Thu Apr 9 18:56:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83B1238F93D for ; Fri, 6 Mar 2026 12:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799732; cv=none; b=EJFjisuxjLxTcIJXUkBGB/qkx8dgwS8frwzGt55Sjlbku+9epT2xWVg2tJUgxJwsXY2re9sFKucjupQb6Cl8GBFSPwtY9yBAm/+X/bnDRr+dJ/A7x017Y5cZRnqfmQzNLwsFpHfT2Xx03xHUbNyBzswOeqWiTEAX8fuUZd0ByMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799732; c=relaxed/simple; bh=6jShP5otc7Z/xglFZY5mqaUqDhEckaI1JOm+jwe6kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DthMmR/8FV1njo4W1APsc05JkH1Iifyg8wYZDnkNM2X//1av+o063iu+YpYjXONkWjcHVT4MmDWUwSd1wXSi90potpQqJcx4KcCWrFU3y0Q8YJHPdGaBu7owTJ3mkxXg6oL/7Bz/ZpWVzs1gJJOJXX2dSpK3XOL2Uuw4R6XZ744= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fwUHlBx5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iPU75X/q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fwUHlBx5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iPU75X/q" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626BauSP864945 for ; Fri, 6 Mar 2026 12:22:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xKWL+GAYqNp +tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=fwUHlBx5Up/NCWMRPmiMRow97nW 6NwmwsX87GzBm2jr4Fm8IwkbYkUcShqcGpq0Wf16LabS0y0hFq8o3d2S+Qk2Tfig Szo4u2A9mKyO3x+nFGaat8FC4S6JSVNEHkUPxUPJTrYJvudTurH4CsczbVZ7ZSYd x8L92BHrmpEIJDkoqhhDX2bxUC16kf/ssGd3J8q4kQ3RBJhLnQGvUfvRtDXVxWia lzc6+jLpFUaJMa/HUj3rAHBd25CqnIJ/Oum0rozLfuEVt3Szx5F6uNCYRf+FVSe6 /3deDb4zyLEDxwn8lWeiNQviRYotEuZ+1Fa1Fk7RMdoT0FDUXeYNDLO4v/g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqrf5sc7e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 12:22:03 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c70ef98116so6029542185a.1 for ; Fri, 06 Mar 2026 04:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772799723; x=1773404523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=iPU75X/qUDdg94+sqBZ4xw9yIWI3mBv3YMKQvNOtKSAyJtfhjGVLw7cYp3O65u/9JD pIylQxbAfMRD+J1GPYNQvIBq8Jqgwc0xdN68MYKPJf+LjaYSFjMSFn4gS7e8NrhwnJSC 7XXmMCBLUcQtZU6j3QnNLQuutHcJtBJcaL+CBn7fHE2C+WVcOJtaBoQ1NrwOomjdSvfN OeNaNBfh4XraqMzB8lrXNLtY+BeBVbHv/T1aQsBYIKL+0EXBlNmOwi6foWUWMSnv5QWG xptbI1To5exTCvm/Y2ViQbr3xU/gihMQQxhPULOpJCURD1ta6FDtJCzg2ya33pZEt/tw Z0UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772799723; x=1773404523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=APBg+DHIZb5cFrvsiuKXfuBRLSHhCWRcJT/gvRRW3J1oxrb3aU2f3RmElggsfEziqk Yk3LOTwfjzcXySsJWoEjaIfNEPEgOq3kfLTnn1bDVSiBF76CKQtyswdkLcVi3sxKvKwI BXAkOjchVVHd8EbTEMJ4YFaICIleUSAy3GUDIORQpbftoYolRNtbNeCmcRlfbtk3Cqcc QiKDGLPYbxtXSUSeIJm04QdV8CqGqCqRRG5RIEFGtHG51tbSftlIhC89lTPmF2ZBblhp wo2kXuuzXSughXIBujREt7uQDOP71gMzMa9GLH7bmp6DjUxZcwPdZSg4NOlBg3VGWFFN 3xVA== X-Forwarded-Encrypted: i=1; AJvYcCWSFC/N1/ac9X59PlXxRwOWqRyKlwDEz7gcposvENXI+5mQCWbIhRipQ7O8KbTUr6Qz02MHqOkAN4MIr/E=@vger.kernel.org X-Gm-Message-State: AOJu0YzTuC9c3Sp13FICmjU1RZKe+JKYTEmfflTLzurrOViZnhlziVTo LbBa4pvwiVNkzsqSuB/lKDIave6hV0KwjU9t34fp/tFu6aiqDW8vRAFLPqp9I/SDxRV9a2iBI6m 6iZmR641Q42/LDWSrWMjzUEWp7yYrEemoX4EKIS9L9m6DpkcpXhy7u01bzb/irpvBnRk= X-Gm-Gg: ATEYQzyIXaOs+JtsFO6Dpie6nnGeCi/OBk7T/F70zLS2gVBwEHoF1zZrzoB4Xal52F4 ZqTsBIuCgrFZCnoOV3L6U7ZfM1A7kCYzLFguiB9/ysdBNPDAQ0KDuBl8jM2vBa+wZeJTMZZ/p0Z DdYmg+nPRON5s4lqT7mYcPr3xuJqIaI3x8pMp/wsAkwv/axOAfXMxHSqHmA4zCmWxcMgaqMuyXX 9c0ifm4xECodbnosOMgVb2tLbo2Jpcfu4PNIdlK979o6WMfQEJ5bdVTcA2ODyvQwWf1kga0rY8Z P5L3wq/agwskVpdjTcC4moQJnNTcWOMe7+CAKrXsn1hPzz7DOBQd6BaTaVOjUPtwKFjShbtQqTT 6lLrx9+QcjNX1NRutvnLqe5Jom8teg45hoQ6jbYD7m/uuOpX1Fd429sE= X-Received: by 2002:a05:620a:7115:b0:8c5:22b2:8b4a with SMTP id af79cd13be357-8cd6d40d21emr227967285a.16.1772799723408; Fri, 06 Mar 2026 04:22:03 -0800 (PST) X-Received: by 2002:a05:620a:7115:b0:8c5:22b2:8b4a with SMTP id af79cd13be357-8cd6d40d21emr227964185a.16.1772799722936; Fri, 06 Mar 2026 04:22:02 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fa87e56sm111972395e9.0.2026.03.06.04.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 04:22:02 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH v4 03/13] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Fri, 6 Mar 2026 12:21:05 +0000 Message-ID: <20260306122115.509705-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260306122115.509705-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260306122115.509705-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: qvQP08qpUTvvQ6VE3qV6nIJtei__vynG X-Proofpoint-GUID: qvQP08qpUTvvQ6VE3qV6nIJtei__vynG X-Authority-Analysis: v=2.4 cv=L+oQguT8 c=1 sm=1 tr=0 ts=69aac6ec cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDExNyBTYWx0ZWRfX3C6a/EPSwMH9 KA862Gl2XdZiTXHcQzZHDezwzjRhD1rr/Zv5B0VXDb03aR8WeFKajQKhGHxA9mnd0ZdY7JZVEXM WLGbl09JwgVZMDtnuslqzY+5PTnCWJecjcsksj0hjn1mnp1vf19DMudzHG8kZWiwS9K/OXfT7FF 41G4Uv4hucApMqkqPK7fej0nf/ukEfjImI4TlzM65yYz2z9gglw1S+6F3uzs7BS2QtTKTNMwW1X mfWE6acgzYu8lvZ3uryjt5qngo3UZWZxk+zAtqvSWiCZ1k+TCcWVrriPbTO8BkelzK3uBQarFn8 nPGYcq0zCsb9/vwcaQ3CY+j/UZcQxjd4KbAMfXiIt1hSbS36vAVTwYm315J+1/nJ/7YvAIWnE7O 6vGASoUfEop7c5rZuIqZdxedaqgS5fwYsRLcrmB0HWB94D6cZ2UUql41d4Ckf647FG8Y+zPWzYA uKWBzvdrY4BMlrPzzsA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060117 Content-Type: text/plain; charset="utf-8" Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index e732fac9b8ca..1f69fba6de26 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_comp= onent *scomp, struct audioreach_container *cont; struct audioreach_module *mod; =20 - mod =3D dobj->private; - cont =3D mod->container; - if (w->id =3D=3D snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol =3D dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_com= ponent *scomp, kfree(scontrol); return 0; } + mod =3D dobj->private; + if (!mod) + return 0; + + cont =3D mod->container; =20 mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); --=20 2.47.3