From nobody Thu Apr 9 17:10:07 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00E3A37C90F for ; Fri, 6 Mar 2026 10:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772793851; cv=none; b=R2u/cpFSW/od7YwKF018mU2kSxZDVRrtfK/jrxbJ1T7+cEq7il/D/k4QPrXXNkJQsAC2iLQgYz0mM+CE45KHh7pZHC48FT52vjZ2umpf3odwhqCbx9eLXEOe8HfrZAPpIYB5eWUhFuSGUblHeaJFwFBI2CXRImeAb+5ZDVeY19k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772793851; c=relaxed/simple; bh=G4C6n0KMnLAbNREaFm3UQE/ADReUrPqJdWAyBHHz9As=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Mjx3tk/1pkRZtxTQ/x3+eauotTbDRoAZ2hwgfS5elLqqqqxYS+HCNvQ25hKoarZxZP1OlmjDyrpwSH64t/IX1/C3+077yUEJAYx5V1c8ygl+63whzSgtYxNBUa66nPdTb/63sdVOYGNCLU9pYLsT0cn04RdI3ZzVj152ldgSYZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Lgro5ND7; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Lgro5ND7" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4836e3288cdso61285765e9.0 for ; Fri, 06 Mar 2026 02:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772793848; x=1773398648; darn=vger.kernel.org; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9DOpbj26ZJnxNbWf0s+w7ImwLrI/solFuJ1Hpz2a8Z0=; b=Lgro5ND7+5uYlpmXgGioxaFdbbRdh7ys2j9TSl4DW8LbroWL3MTJR1RAjlal2ifl7c E7D2lUS/b3grM82/ucrl7UveITCSgtMXf88RJ/dxXuct/h+EjvS/ZsBW+U5jtTqSVG0E eYEJFP4KEyq2KlcmX2Nd25FC6ENcwmEcYvwyPjQqNBnHhUutUm+3maBQiG5zSjMPXao0 w5YglE1HHGbj3q2vD/63FMrlyWP/717eTVr24SUJwPolV4bIJODPNfokGt/LOqUJnIZ+ RhbPNJ5C/tZEj8CQrSxFMHy436F6QJmAPOnSnbZ8aGET63lPt70co+WV3B+DSn18TQSj m18g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772793848; x=1773398648; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9DOpbj26ZJnxNbWf0s+w7ImwLrI/solFuJ1Hpz2a8Z0=; b=Dl/t5qKUdqorpt41DhH4rB1IloCIlAFaVzuqjt2jnuSAeejdYUYzfaykm0C+yHWFaa Lj7KYvzmHI52evite3AfJ4qV4DoG0F/t+7+joP2XmXo5/fTw3WjbiS3K2y3HARXrqeHF 46fAyWmOoC2MEc5PzzrRE4ShhbsHoREEdC0iag6TRlacYQ+OJT9LvAN1kX/rAXQaEpJd G+1kjMdcJ7cv/QFs5xECH5dFEfLurh06yLdk/ghy7J31qtelUUd975PjUtcdPCqlsWWF NN6FROw4RyEgUOFE4v1qW7V1jwlov2ufwbsoHQkWEYJxAuClmT5UJnGXVgiuyuEnQBri U9vw== X-Forwarded-Encrypted: i=1; AJvYcCWbBZt6qh+CQlaZ3d9l8F+68ltO19G2IVMZxjQigWATn9uFKSG+Xlm4/Xe33+k+7eCIpZ9VZytJgidGMOo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb3V40bxyeW3ljE9CbUOWEz8QHYgZFMdqoRjbR5xFAiHTPY2JJ MqippHTn8es5LXCBW6wTZfFnimsJ0L6/9YmmkPZ4r6H02OG9aW5YdvI+6+j1rlbvHRk= X-Gm-Gg: ATEYQzz9vSr6rvZoaxqn2cQS0OWq8cHlx5FGVRnYdUgGo4JaLrSLw5EUwGL/JRPCORF ZHT9KwZnYwo4fEwIZi2wJT/pVQaajO+Vge94dQBxBaZdRR4PjzEwTBVvHmOtiVrWdKFqDqOdepg 6rwktY7fuLh94Oc2EqnB6t7Mowz8nbWkp7NzQVVyeFGV/jCxKh1cixPJE1XyBS5PPBCT6oRvhkG +390Wz9GgVpGIeExHXoUQ/0kuAfhboukWs2BnAUET/NBrKqpDh5g+oq5zaMdT9QoygHmgZ2Sljo FR50TTU6RxuCmyF4+hzPdnzJKd1LmfBg07SbFtSOxsG5IYL1g2706hVgcPMqGqvI1tImSqTaDcn o1hdfvGd5xdgk7IWR9CLVDxRuvkt36XJ9D3xXe6YvqdTTSQ07ZY0k6qphn4vMwLeGF6lFqAdMZT BaEdevR2DVgairu48hjQWaCzqcsHAmqfvsAWrcbhynk7xTz+LjXNK9sv8QxzNh X-Received: by 2002:a05:600c:8586:b0:47e:e0b3:2437 with SMTP id 5b1f17b1804b1-4851ee73b5dmr92071435e9.5.1772793848259; Fri, 06 Mar 2026 02:44:08 -0800 (PST) Received: from r1chard (1-164-74-26.dynamic-ip.hinet.net. [1.164.74.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dadb29fdsm3098875f8f.16.2026.03.06.02.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 02:44:07 -0800 (PST) Date: Fri, 6 Mar 2026 18:43:59 +0800 From: Richard Lyu To: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Lyu Subject: [PATCH] media: staging: ipu3: img-mmu: fix sign-to-unsigned conversion Message-ID: <20260306104352.629177-1-richard.lyu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.51.0 User-Agent: Mutt/2.2.13 (2024-03-09) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" imgu_mmu_unmap() returns size_t (unsigned), representing the number of bytes successfully unmapped. However, when the alignment check fails, it currently returns -EINVAL. On 64-bit systems, this negative error code is implicitly converted to a very large unsigned value (18446744073709551594), incorrectly indicating that memory was unmapped and potentially breaking the caller's logic. Return 0 when the alignment check fails to correctly indicate that no bytes were unmapped while resolving the following -Wsign-conversion warning: drivers/staging/media/ipu3/ipu3-mmu.c:393:24: warning: unsigned conversion from 'int' to 'size_t' {aka 'long unsigned int'} changes value from '-22' to '18446744073709551594' [-Wsign-conversion] 393 | return -EINVAL; Signed-off-by: Richard Lyu --- drivers/staging/media/ipu3/ipu3-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/media/= ipu3/ipu3-mmu.c index b196a5815903..fcea125e5935 100644 --- a/drivers/staging/media/ipu3/ipu3-mmu.c +++ b/drivers/staging/media/ipu3/ipu3-mmu.c @@ -390,7 +390,7 @@ size_t imgu_mmu_unmap(struct imgu_mmu_info *info, unsig= ned long iova, if (!IS_ALIGNED(iova | size, IPU3_PAGE_SIZE)) { dev_err(mmu->dev, "unaligned: iova 0x%lx size 0x%zx\n", iova, size); - return -EINVAL; + return 0; } =20 dev_dbg(mmu->dev, "unmap this: iova 0x%lx size 0x%zx\n", iova, size); --=20 2.51.0