From nobody Thu Apr 9 18:41:04 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B6337D124; Fri, 6 Mar 2026 10:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792759; cv=none; b=NG1BcQYR8/ozkd9kv/SQSrX/BFX5ITVwwuk62iu1WzMOVD70kxyDKL4oRXgKec4JCmtfspFEDZMF8JrpSrEUyRR9Yo9LWlQ87jPvObv0C03w/nc8GerHTJIxam0cqIa48+5HoSUt0CVUM7v1Rer2bmIXu/OqTOn+Gkf9ToWge6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792759; c=relaxed/simple; bh=vX1KMbKvYu8KWxG4UfRSHH0cK1PoMh5jMHFxaF1ekI8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z0Hj1gS5Vc11Vw5nxZrUEokxBORrR7l4J4futwskvDD93WzgSX1SVg3ywqO7xKrQ6neT6ACvl5IT2ckHyKkTNrM2/+u+mNAisswUJf7K+q3nuGZ5EkNHtNA5dOqLwmLf0HrAQTjbLKCFzVdp7coowZI/GUGQEE/pLcbVGIwCATI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=csmgdNJF; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="csmgdNJF" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6267w4dE2140142; Fri, 6 Mar 2026 05:25:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=WIVb9 lwQahzaODILRrg//qJldxfJKgyPSC2odl7vSnU=; b=csmgdNJFeGrsW83PieRb7 +2zJTjMm+uOtoFwk85jomWFPJ64BxPbof1utFmlrvGdNjZ+Ye2UABo2BUmTqxw7M h71o3AsAvQllLVylWHrZXDGC40nxhfIuBzaFRaVNbPGbvIAvnGEX1eNymTI8w+c5 SytzoCgHc2sfrcPWT4qmCfg5qnnoAJ1HkmuQ6Sr99T6MPvnOuLLp+KEgQ9Umo98o T2GTF7uUuA2LIkXWJcmrk/6ZFYwzXfCJBwP8sEUsP9eLF3AfvzZhxhQsaqRof0AN DS6L+3YzoRqW1rWCSmhUf3C0T6WSwrmL0j0T6vn0tJTmuQejBZQBzpiC6+jCfGhN Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cpd6hjyxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Mar 2026 05:25:33 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 626APWjv007759 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Mar 2026 05:25:32 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 6 Mar 2026 05:25:32 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 6 Mar 2026 05:25:32 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 626APG2T003684; Fri, 6 Mar 2026 05:25:25 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus Subject: [PATCH 1/4] iio: frequency: admv4420: add dev variable Date: Fri, 6 Mar 2026 12:24:45 +0200 Message-ID: <20260306102504.42395-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306102504.42395-1-antoniu.miclaus@analog.com> References: <20260306102504.42395-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA5OSBTYWx0ZWRfXz3vsnM840d2y +bXEymY9/szrTiVlgv6CUGFL9bJaTCUtmVWbtWJejBmtBL+jo8gbYaCeZ0i7JJ4VROmr/wREa8Q kQ9nLuu25Icq8yUfeX+txkC5zCgzbiJRmN4wQxvV8QzVYyKQUblQk+6mTo5XJwb3k6whZjzTbUC aNJrHnMrisI3PpTVy4UicvbavxE3GAUb/Q26xmp5Auirp3x/UPg1MoGjIjg21/gudNuxc5WIzoQ F9rc4sUJ11phXCrsLiErmwEIJAicfaiHpa3j4Obp9dHZ/KlTEKxZPNBEU8bte2q5mzlJ53NPss0 ANsZdDbDVkpe14tcS0FwhM42zMc69cSpBlyUKzH8INDeJR0oroty0o/J5jMlcEG78CBWn4fe//2 6Dmo2KezZ4j/jMFZbXOiSqxkOjFhCYBNgk/I3I0qZhQRN+bIFxyUYdABfWqSdmtNMfgTdWLwf9G AEOP6m2f2PQbHxwnLkw== X-Proofpoint-ORIG-GUID: sUyfRjZAUNSeLsWU7WNgdKZyfxuJLag5 X-Proofpoint-GUID: sUyfRjZAUNSeLsWU7WNgdKZyfxuJLag5 X-Authority-Analysis: v=2.4 cv=Jtz8bc4C c=1 sm=1 tr=0 ts=69aaab9d cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=lZ2AnQk9egpdupJ9vqsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_03,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060099 Content-Type: text/plain; charset="utf-8" Introduce a local struct device variable in admv4420_probe() to simplify subsequent conversions and improve code readability. No functional change. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/admv4420.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/frequency/admv4420.c b/drivers/iio/frequency/admv4= 420.c index 8748d9747639..6ebfe08fc211 100644 --- a/drivers/iio/frequency/admv4420.c +++ b/drivers/iio/frequency/admv4420.c @@ -344,18 +344,19 @@ static int admv4420_setup(struct iio_dev *indio_dev) =20 static int admv4420_probe(struct spi_device *spi) { + struct device *dev =3D &spi->dev; struct iio_dev *indio_dev; struct admv4420_state *st; struct regmap *regmap; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 regmap =3D devm_regmap_init_spi(spi, &admv4420_regmap_config); if (IS_ERR(regmap)) - return dev_err_probe(&spi->dev, PTR_ERR(regmap), + return dev_err_probe(dev, PTR_ERR(regmap), "Failed to initializing spi regmap\n"); =20 st =3D iio_priv(indio_dev); @@ -373,7 +374,7 @@ static int admv4420_probe(struct spi_device *spi) return ret; } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct of_device_id admv4420_of_match[] =3D { --=20 2.43.0 From nobody Thu Apr 9 18:41:04 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FB433B2A0; Fri, 6 Mar 2026 10:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792755; cv=none; b=mg8JIs+QMszlytOmnZWXp9/hEAT/+wcRgqhEDbZ9r01ewRKz9kaSmQXLkvn+bG14U0ftjhNdgCIgGuQXp/lGT6fA3oon/kYPF2EBrkWCJYzIumqLZYHchVo3CQRhc71B3Y6CtuyAL9TeOp/iVDpzOC0QdivdwkcPfeUdJnq51os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792755; c=relaxed/simple; bh=/1ln1f5ASvqMEhGgj9sKTz/Svc5XSdHZ5ERyvUNc96A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UYcDGnTNKk2c182qjZ9rj0wnwNei3GF0jzjOlhTiMOQ4j9spmVwEM1qGmeWkIULinKqwT0tc2uGcynFsbgkrPyZZL9V0axQrQGw41Aeg2hvubBPyeClAS4RkEpy6pmohXXmCpcHxjASNTJnOmLzDyl8l/N4dNbw7Mk2AUf5Pg9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=odjmE6R0; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="odjmE6R0" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6265mv8H2756978; Fri, 6 Mar 2026 05:25:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=JMH9Y cstxDSXDcLa5QjRkSbMp3wKb8bGd3J0Yg343RU=; b=odjmE6R0WdkEcFjYyrAzw V8ATQmEskqcfgCEej33ovI0pLHx179K0MubPWVW4z0ZVgXcw1lxhp++Z2yPKJiDz iWUV/WWNW6+mAI7uQpXQIsFvGfpYeBecpj6/r4wL3OZZkGtkxFs+IWg8vCQupPhW 86w7z4scm5eHTzfTJNCSYbxOQoa1EVrlI+i1Gg6OlrGPUQLG48l+ibMtq2Z7JLQl heHaKOuSyEEX971WA0PG8skC5IYFPJbYo1hyE9fWBqd8x/Ga5FRGKY+EChDJHUe6 zJUGQKJ30bW6wEwKvZ0XkOj7fgM0sdLap6bYcwOQPLOq6c06cTjgXZGwwGz5/kFa Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cppt6gxvm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Mar 2026 05:25:33 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 626APWbx007762 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Mar 2026 05:25:32 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 6 Mar 2026 05:25:32 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 6 Mar 2026 05:25:32 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 626APG2U003684; Fri, 6 Mar 2026 05:25:28 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus Subject: [PATCH 2/4] iio: frequency: admv4420: use dev_err_probe Date: Fri, 6 Mar 2026 12:24:46 +0200 Message-ID: <20260306102504.42395-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306102504.42395-1-antoniu.miclaus@analog.com> References: <20260306102504.42395-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA5OSBTYWx0ZWRfX+8Q9chPrhgYV UXJZO9vRMKeffQXY9SoiQt+kqiTASY94IYjp2CBkLNy2Imq2IpmiWZtDG75CX/knNiJw7n+fKyQ ysE+aV2Na6KDyKnFiZ2Q8l7fN3XTe1OMPDM2LXnn8P5g9SqAUoN6QoO905+1RRn1GcNlSVp+smo FlN6D/pRztt6UcsX7PVsljU5Mgk/SJJZ/b4v+rtcaC0e4RoV+zKW3WKfT2y08NshykQTr6idv8q SuLYu19upEAkD11t+oLsBxL1LJmqEnp6si57t1AW7qgPmdBwGfV2Avj1mvLrXWXGNWwaKDA7wJA uLSFi4CnCbDUa6NOfHW42eRZNERsRZbpJuvlcSNWM5FOyZhHKOdj5h+KqeVEJRapSwgvBykq4Uv lVsi32nO67Nufuty5RLsR+l3ug9ddqj4jCZvsIJ/TtKD9O4ulq4GUP0bNhzV6So+ynP0B81CeRX WVUlCSpv4zmH0OoSMzA== X-Proofpoint-GUID: h-QtoGPWu_dxhm9FTLvWqeiu92ZpCpFG X-Authority-Analysis: v=2.4 cv=EKkLElZC c=1 sm=1 tr=0 ts=69aaab9d cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=rh7gjDiLLP6ny2FSsboA:9 X-Proofpoint-ORIG-GUID: h-QtoGPWu_dxhm9FTLvWqeiu92ZpCpFG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_03,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060099 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/admv4420.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/iio/frequency/admv4420.c b/drivers/iio/frequency/admv4= 420.c index 6ebfe08fc211..2416fe850ecf 100644 --- a/drivers/iio/frequency/admv4420.c +++ b/drivers/iio/frequency/admv4420.c @@ -279,10 +279,9 @@ static int admv4420_setup(struct iio_dev *indio_dev) if (ret) return ret; =20 - if (val !=3D ADMV4420_SCRATCH_PAD_VAL_1) { - dev_err(dev, "Failed ADMV4420 to read/write scratchpad %x ", val); - return -EIO; - } + if (val !=3D ADMV4420_SCRATCH_PAD_VAL_1) + return dev_err_probe(dev, -EIO, + "Failed ADMV4420 to read/write scratchpad %x\n", val); =20 ret =3D regmap_write(st->regmap, ADMV4420_SCRATCHPAD, @@ -294,10 +293,9 @@ static int admv4420_setup(struct iio_dev *indio_dev) if (ret) return ret; =20 - if (val !=3D ADMV4420_SCRATCH_PAD_VAL_2) { - dev_err(dev, "Failed to read/write scratchpad %x ", val); - return -EIO; - } + if (val !=3D ADMV4420_SCRATCH_PAD_VAL_2) + return dev_err_probe(dev, -EIO, + "Failed to read/write scratchpad %x\n", val); =20 st->mux_sel =3D ADMV4420_LOCK_DTCT; st->lo_freq_hz =3D ADMV4420_DEFAULT_LO_FREQ_HZ; @@ -305,10 +303,9 @@ static int admv4420_setup(struct iio_dev *indio_dev) admv4420_fw_parse(st); =20 ret =3D admv4420_calc_parameters(st); - if (ret) { - dev_err(dev, "Failed calc parameters for %lld ", st->vco_freq_hz); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed calc parameters for %lld\n", st->vco_freq_hz); =20 ret =3D regmap_write(st->regmap, ADMV4420_R_DIV_L, FIELD_GET(0xFF, st->ref_block.divider)); @@ -369,10 +366,8 @@ static int admv4420_probe(struct spi_device *spi) indio_dev->num_channels =3D ARRAY_SIZE(admv4420_channels); =20 ret =3D admv4420_setup(indio_dev); - if (ret) { - dev_err(&spi->dev, "Setup ADMV4420 failed (%d)\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Setup ADMV4420 failed\n"); =20 return devm_iio_device_register(dev, indio_dev); } --=20 2.43.0 From nobody Thu Apr 9 18:41:04 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EC1537CD32; Fri, 6 Mar 2026 10:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792758; cv=none; b=MWTv0DU1Rsx1YH9qfpkP/gjt3SIyqrh0dS6O1awdi3yioAqCiJzi3Z8TYdmtHJ74CYFD2xsE5mIr1QOUJ6sSKffvPlqIMK5OIWn1Yp6CgLEUhzM2+nlrJUJCaodk299Hx64tYrmOkStxzXevxCu4slLhsT/a+FCskquOXr9awog= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792758; c=relaxed/simple; bh=1uEQ7V5Zslugz68x+KNuTmlmcSELM0M1byik9KPH7Mk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tJ1GNNaf+mX04BAGHzd3zxdp8m13590Lwz1nQKRfVF3GhVGF20euoA9xP/zW6BSEjJ9F4mXhmpAVuVY/bWAwfvD4/Phf4Cy0FRVlAY+6F7goq509Na+mGJvFiFXltkpIOvxv2SufuXbAWhomxre9ThKpoTd4EMbIE9b+LMFnwjk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=r/p6C8QZ; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="r/p6C8QZ" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6266JRjc3330887; Fri, 6 Mar 2026 05:25:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=xVYxq fXiLj+HbUbaOc3ciyuopxWYtbOl9LWu8NDiKHM=; b=r/p6C8QZf0AHL5xjZjU7J +eB1WVxXWRqb4JZcI/kUPPwRwB4/8F8/xtzbuatmtjHH63sOI1QDkkKZY6k4AxN2 jmrV2v0tOymUdnhm7dC2fRDjKro76REGncbEU1U8edGMmj397K8wpuTP7iz41WqN 6WExVqaRjimySV5Z/1z8whwtWXunalnrUh+zxA6D1GZ2bDn9R9XG8DDl8qoZOods fDRU2OplWyKk8nR3jUx9Xt47RAXiLClOByVnP8YIoCTN0z/SddpIvBE8p2hpUtwu OrzgKq0geDUE7jg0uvlDtX/KOVN4D3UNgCAVrE2pxJy9ARt1BJJl/SzeTgfyUocP A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cpb6jugmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Mar 2026 05:25:37 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 626AParR007781 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Mar 2026 05:25:36 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 6 Mar 2026 05:25:36 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 6 Mar 2026 05:25:36 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 6 Mar 2026 05:25:36 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 626APG2V003684; Fri, 6 Mar 2026 05:25:32 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus Subject: [PATCH 3/4] iio: frequency: ad9523: add dev variable Date: Fri, 6 Mar 2026 12:24:47 +0200 Message-ID: <20260306102504.42395-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306102504.42395-1-antoniu.miclaus@analog.com> References: <20260306102504.42395-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=J4inLQnS c=1 sm=1 tr=0 ts=69aaaba1 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=9Uukg2pZKlto5Ld3BdsA:9 X-Proofpoint-GUID: VAgIifdVLGY56lDD0hLz4AXskDBjW965 X-Proofpoint-ORIG-GUID: VAgIifdVLGY56lDD0hLz4AXskDBjW965 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA5OSBTYWx0ZWRfX6XCKfoZpM7YX V74yj/mR23X4FnbXCF9opyrlPt0C/v9uBZQZIO3nnumm0zLh9g47Ax6ZKRAx4nqMEp1YyoPVa8Q uSVayCeuloY7XFijodbQpcDcROtAIkcoWC0MTiPbBZK+qsmxS05y4eMswsIiR4YlOrmz8qpoh9W gEpXssKkKdcRxrhbnKAz20FNXQvRgD1IJYdILvdF87yxTkdXPXXWmiMoZnkJ9rnqJtDgPOQCHkK +ryBC3MOjcWk6mktCGt9Vi9B6FU5taCkeAVT0a8GwEjxJk2OHuVF2GTOdr6ZsgGwZi9RGlLmLvc 1vKI5+zoEQp38zEdZqOVx/YsueC3czI9E1vU4ZCztf7OnY32xowEquUJEUD4V1vldZKg+HLL4E0 N6b9dCJM+jso8JPyVvCoKimmQzHTgYzdvAm0dbG/6kgAfs4/wYG/IbQ7nVSyQSwCBsyV1zg7dg7 1j3JMIFuQ88fibyUHzA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_03,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060099 Content-Type: text/plain; charset="utf-8" Introduce a local struct device variable in ad9523_probe() to simplify subsequent conversions and improve code readability. No functional change. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/ad9523.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index ad32eb66edca..6d15ec648280 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -948,17 +948,18 @@ static int ad9523_setup(struct iio_dev *indio_dev) =20 static int ad9523_probe(struct spi_device *spi) { - struct ad9523_platform_data *pdata =3D dev_get_platdata(&spi->dev); + struct device *dev =3D &spi->dev; + struct ad9523_platform_data *pdata =3D dev_get_platdata(dev); struct iio_dev *indio_dev; struct ad9523_state *st; int ret; =20 if (!pdata) { - dev_err(&spi->dev, "no platform data?\n"); + dev_err(dev, "no platform data?\n"); return -EINVAL; } =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) return -ENOMEM; =20 @@ -966,16 +967,16 @@ static int ad9523_probe(struct spi_device *spi) =20 mutex_init(&st->lock); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "vcc"); + ret =3D devm_regulator_get_enable(dev, "vcc"); if (ret) return ret; =20 - st->pwrdown_gpio =3D devm_gpiod_get_optional(&spi->dev, "powerdown", + st->pwrdown_gpio =3D devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_HIGH); if (IS_ERR(st->pwrdown_gpio)) return PTR_ERR(st->pwrdown_gpio); =20 - st->reset_gpio =3D devm_gpiod_get_optional(&spi->dev, "reset", + st->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(st->reset_gpio)) return PTR_ERR(st->reset_gpio); @@ -985,7 +986,7 @@ static int ad9523_probe(struct spi_device *spi) gpiod_direction_output(st->reset_gpio, 1); } =20 - st->sync_gpio =3D devm_gpiod_get_optional(&spi->dev, "sync", + st->sync_gpio =3D devm_gpiod_get_optional(dev, "sync", GPIOD_OUT_HIGH); if (IS_ERR(st->sync_gpio)) return PTR_ERR(st->sync_gpio); @@ -1005,7 +1006,7 @@ static int ad9523_probe(struct spi_device *spi) if (ret < 0) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad9523_id[] =3D { --=20 2.43.0 From nobody Thu Apr 9 18:41:04 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 336F931813A; Fri, 6 Mar 2026 10:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792756; cv=none; b=mTC62UVMu9XqBpec0BC93smfY2Dfte+Wl/+H2ZCWgnQIqiG7mI5LcLswMaPIXM4NnzbIe5NFfFkbEWFROmCNawG1x1j6R1+Y5n9zT0N2FOCK9+wZhYcALnH90IwvoQpaG2FnSF67sBwFcDUUUdbN4IS2Ig6VVQuQzDpeoIVB4dM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772792756; c=relaxed/simple; bh=BEDENE93mr/O/VlY4Fg81J2lwWMSVmdiHr5oDfS62FY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k9iULCkQnB8fz2yj1iDFujRccUgIVtJa1gq7cLl6WoqaEbArlBctTKvjGzMdkTc7LlEikrVV/Kuyl5PUnHmMRsi/W3ThyMV7rJ8ZmoDomg//IgGaW++hHmIFZDDnEL9oHFVw/xjHab7izU+CPwJshskhp6a6yTneh7akwQoyZ4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=E/8IaSUs; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="E/8IaSUs" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6267Xxwn3363772; Fri, 6 Mar 2026 05:25:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=7p0fV yXk8LTSEupQnzHnoAo9i+YCR5ECDHM7vi9lyXM=; b=E/8IaSUsyw6ZMA2/WjHLD K+A/ywJRxL0u7N+pBJw0T2+qrV3rW9qG90N5QX5N0VYaSPljOUaN7+xvsNPoq8mv s56r9uj7pHeDseHgghJMPS8TUtIM2ShfcFRKevvSNDBc1Hp1YcYeFR3XeoGU1QQl 0ghxUt9Bp9dyGW6kmneXLWIE5ufjoCpoGpFUucxEfpEViFTKHv5qBymzt2/fz34D 4rYu1q7Lmc932RbPknsMkdRwE1bqTXXLeMzV0Hj5EZKHYB41iMXuKaeH4x4Y804P ASsoDy4L813mNMmHfXXdVmjfQvAvBwWsCm19cnpXMmSQdW/rIBOHWAKL8hism121 A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cpdyx2pwe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Mar 2026 05:25:41 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 626APebl007793 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Mar 2026 05:25:40 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 6 Mar 2026 05:25:39 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 6 Mar 2026 05:25:39 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 626APG2W003684; Fri, 6 Mar 2026 05:25:36 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , CC: Antoniu Miclaus Subject: [PATCH 4/4] iio: frequency: ad9523: use dev_err_probe Date: Fri, 6 Mar 2026 12:24:48 +0200 Message-ID: <20260306102504.42395-5-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306102504.42395-1-antoniu.miclaus@analog.com> References: <20260306102504.42395-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Mc9hep/f c=1 sm=1 tr=0 ts=69aaaba5 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=sjRy_tYu0K-qpKjFe64A:9 X-Proofpoint-ORIG-GUID: -GwOLAorVbY5JGoGnJpNVW6VyCgGbSFM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA5OSBTYWx0ZWRfXxUHEhpNvuosM 3iVwefw9nJ/knNDhFpE0gZgmtiuMRUXbLErxrCwUdaEvLVouIlgkGY8y3clO4lPjhMyXDG7dJIO mC5w6/zjwiFjwYvgsg0kRz3+YO2Sred2J9G1M/0JCkOQ9rtBNqq8pSEHITBPlQFn9XpL+tNL/n3 AtT4i/ZVWiewjUWcPE5y/OuUmui4h7EcllB48cAFbMgES1tZwvM4VGgH4y9aXAgVVxDfMkKq14l 1CyWu1Oq1V985squhOLuOPx0l1adrQd0FAiZbipWNUQ5ALVwruQL7VbcyPNapuAok72tm3YyNst lBi4txQ8yghI1fpiz/AqNJ2siTPr/Hxa4SrquWYRo5BxBt/e5Yog/TLTxB86nCc0cjL4TprL2vR 5anBGAGcDclhu7gJ3UqcjftJ23a+CmM1ydwWtYiD7PhGHaaeuZz3/Ieg/S2P3vH1Z0M8e294iLP 8IgZcqFa9+7eLcLCqhg== X-Proofpoint-GUID: -GwOLAorVbY5JGoGnJpNVW6VyCgGbSFM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_03,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060099 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/ad9523.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 6d15ec648280..f29a45837565 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -954,10 +954,8 @@ static int ad9523_probe(struct spi_device *spi) struct ad9523_state *st; int ret; =20 - if (!pdata) { - dev_err(dev, "no platform data?\n"); - return -EINVAL; - } + if (!pdata) + return dev_err_probe(dev, -EINVAL, "no platform data?\n"); =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) --=20 2.43.0