From nobody Thu Apr 9 18:03:01 2026 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931A933CE88 for ; Fri, 6 Mar 2026 09:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772788035; cv=none; b=h+f7l2zRS0nsDa2VkgVr0X4x9zKrnGDkFs2dR3Ht2DH/4fcTDmkN3uSX/lkJY1QjKD6oiCZ3sHTimvLdmiL3zpGbSDVNU1Rba/3tItf/y6XcXGArP2LACyrE2vXtTXjpwkYklKe/bd1UJA5jGQWVKDGZJh0tODlaG4tFQ5/u5ds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772788035; c=relaxed/simple; bh=fmpuIUrjXVvpSnWsUCR4SK8dYfNMcvPYl9aPlUXcjko=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=be1iWPMFyIShErFaI58Rd/1ZKDlne87tVNHqkl7Ew2OyTy11eSMqCjvX1nVFQRtTCx2QLIYGiz/n9RH2BCv5+QOZ/kwHajRmD0CwZzy/X79xtHzWlzznt3yLVoZGr+QztkTlI4fC8CfQCX/YOYmMmBnYnqTgzglf7ZQJY3Tp7gY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eRW28Q8b; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eRW28Q8b" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-8298fad2063so793873b3a.3 for ; Fri, 06 Mar 2026 01:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772788030; x=1773392830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=h/XkAPBi7k7ykpD0UT2uW0E/tNzSIZSxb+xSJZFxgiA=; b=eRW28Q8b8+QLiZXkM3PiX+EjJM4BhtHblqUajEJQAGu7nzbb/N9pmtssQjq2dzC8yp vdh7xultLyYq+NiPjd4GUpihOpo/w53r8RodSVUq1D5ki7ogPwXM5QxKLEzA3XncHHIy alWIz7Xa5NHdIP8JuAj5zwu+vuhuPkLXEVB78R5iJPFj9d5AJPPopmMfpp6ljphyM86d +LhWQJN2ssqUuGvjxHTA3795HYKKQ8qocANBOx2nGxrCOQlghze9h4G6r0mph/LxRB9K KLTHg0HfgRoubLBHWbL5zVx+JucDL3DStADLDywGba+yUl29PGRtHGWvZIvyEdd7CB5X 1AGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772788030; x=1773392830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h/XkAPBi7k7ykpD0UT2uW0E/tNzSIZSxb+xSJZFxgiA=; b=C1EXJe5BJGxKXSqIydkP0t9s0eDjHVPfTE1Dy3tj5CCcoKpKPdHjHAIy0MNI19DOSf kOnDe4yj4sQ6dzDNLHb+bFaqvM5NBFke6FmrcMqA2FoQo3NNlUDmhLxMugOQME+CdaAy pzijzYYRe1Cj6DFyp8A0wdLDWX0TqzWIQqOdWKccRW8trfGlF3lkbd/E+cFOtFuwsx2Y F9vbrdmeogqeFpV1s0NycJJc4UAzZbS+IYH/761dNHxVoeY5QNvL+ViK4KsKMqlslf4M 8ti6nTmMedz7xcShiTICzgsqIqqXc5YwgKo0G8bzI201PwTPS2i+VKG2WX7zYdMB/AOO 0qYw== X-Forwarded-Encrypted: i=1; AJvYcCUKfCg2BDDrQNj9w7BPAW/1fb975MM4XFJFNI3MBg4eb0AXQBE+HBDQzH79wRxWl7rX+JjHjAYW4IAqdlg=@vger.kernel.org X-Gm-Message-State: AOJu0YxlexjS+SP7zq72n2ApvTyQwfLfWVe/EIN8PSMyds9n2wqNPzKU HSNU8g9l08RkR5TRaSAkn96+x+gAYr/7MeUkQAmOFHvBglm3QbxHzgiF X-Gm-Gg: ATEYQzzyRZWwCV7LUkfiGPCvICnwHzvjCMdGW7wMNabNSlUSVHSUjEU+oy05iZyKG/w 2r8fur6oXguNcdT4JoJr5o4XilD7c/6XBOUW7QuDjBtCRnyYFc/2fLP93RWNMIkuqTHYg0y0zgA nx5q3pTlh8cRGIZdbvZJGDhFjv0Nxs5GkctheaG8vEHUtwEKFtiGJjszKFMaNd8MoRRU9nLcYCf oIg7BSWqnd11fCMTsm0WuyBRr3BeTqcsgfoqcs03f/+KFxO8HG9PRYR4HerMNNf9xOlm+kREqj0 PNAfQlBRRKzG9oIxIHsQ+vIJRLBd3SH6BD4f6HTb7GFYa0Au2RT9fWoaD8FBIM1AGnlqrcnkQir JG3Ji/fM/i1zv7/xub+B/+npatvFwiepxEhJ7nMAiERf6iWQmaVzFndamQCKP6x/y4eglAg/6DJ 445a+vRz8R5dWC3LmJS+XIGkfW+qlrMImfwiS5iDVKNkmwtQKVIr4zWOUoMAxMQbqQKBcr X-Received: by 2002:a05:6a00:1943:b0:829:91f6:e533 with SMTP id d2e1a72fcca58-829a30d8953mr1341268b3a.63.1772788030538; Fri, 06 Mar 2026 01:07:10 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a4867e54sm1166142b3a.35.2026.03.06.01.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 01:07:09 -0800 (PST) From: Zeeshan Ahmad To: Thinh Nguyen , Greg Kroah-Hartman Cc: Dan Carpenter , linux-usb@vger.kernel.org, smatch@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH] usb: dwc3: gadget: use explicit 0 for success in __dwc3_gadget_kick_transfer() Date: Fri, 6 Mar 2026 14:06:43 +0500 Message-ID: <20260306090643.47383-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch warns that __dwc3_gadget_kick_transfer() might be missing an error code when returning 'ret' at line 1691. While 'ret' is guaranteed to be 0 at this point, returning an explicit 0 improves readability by removing a level of indirection and clarifies the intent that this is a successful "no-op" path. This change also silences the Smatch warning. Suggested-by: Dan Carpenter Signed-off-by: Zeeshan Ahmad Acked-by: Thinh Nguyen --- Link: https://lore.kernel.org/linux-usb/CAPBWGpEi77+sksNLazw=3DdtyA3d6fBn-r= 10917k1rEzwzT3M=3DgA@mail.gmail.com/T/#t drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 0a688904ce8c..3d4ca68e584c 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1688,7 +1688,7 @@ static int __dwc3_gadget_kick_transfer(struct dwc3_ep= *dep) * transfer, there's no need to update the transfer. */ if (!ret && !starting) - return ret; + return 0; =20 req =3D next_request(&dep->started_list); if (!req) { --=20 2.43.0