From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 977A437B406; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=LI5nsmuMSGMFEQljEqz5ZpF2hwAmLRnhmvI0izCy2ElpKP9i4xNqOHGltkvb0hyI5TikOWP0vc2rfZKWkt8h65fEy3r20c4uqQLFnomN/YqzRpB6ExzhhOT6MNZiLhm6l9+IGoI0xGQl6qaS61hIcnllSKz7xxz5ssj41XxpexM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=YBI08jfhYlQX9Gx4zol78geSQz/rAVKtS3Ypl1NPKR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SBlg7/ylPPFbatuR/a35UK8PPqdhwFnaqYN3TrJOGj6MAsEgB+/v1SQUantlvFyiMbWpxDKUImK3TWtN+hhQKIW2P6K8et+5g04cA0PxHNE6G8kRekRBGbtiHoOg0GyysF6A+I4iahFKlsG5TVhCU+Bi1SsxlWhuKt3zSzP0KgQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W+l1wrw7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W+l1wrw7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F973C19425; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787136; bh=YBI08jfhYlQX9Gx4zol78geSQz/rAVKtS3Ypl1NPKR4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W+l1wrw7DmuyZLjDSr1+P62LoEwbSVyDRBPrspuXhrMQ0kOXtNIdWRdkbPb7Ffkvw 47p8Mj8Sox1nh9goSbEhBTIQpmhbbHMO+epPtTAq8mYJk+FN5Uf8r+QCerm70ZTsqy SyNue6d9w2d00z6sEA68valC+IKJmyGngtS9mBbpgcPcIwhleCVASD7HTvr3zpRHie C2ih5k3DotP4vNfV/ia7bEjA55asOe+LGMMn6hZg5mjHU/psW8MCtAHykR1krPBJJ6 XZkciuRz5kbsmmGiOljHraapz53yWLbw7DslcPIzx17kKn84tD6CgI3ohbfpqLeWKz 38YB7yz5saJ9Q== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AL-3Pwh; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 01/18] wifi: ath6kl: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:27 +0100 Message-ID: <20260306085144.12064-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/ath/ath6kl/usb.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/a= th/ath6kl/usb.c index 852e77e41bde..814faf96f1ff 100644 --- a/drivers/net/wireless/ath/ath6kl/usb.c +++ b/drivers/net/wireless/ath/ath6kl/usb.c @@ -1124,8 +1124,6 @@ static int ath6kl_usb_probe(struct usb_interface *int= erface, int vendor_id, product_id; int ret =3D 0; =20 - usb_get_dev(dev); - vendor_id =3D le16_to_cpu(dev->descriptor.idVendor); product_id =3D le16_to_cpu(dev->descriptor.idProduct); =20 @@ -1143,11 +1141,8 @@ static int ath6kl_usb_probe(struct usb_interface *in= terface, ath6kl_dbg(ATH6KL_DBG_USB, "USB 1.1 Host\n"); =20 ar_usb =3D ath6kl_usb_create(interface); - - if (ar_usb =3D=3D NULL) { - ret =3D -ENOMEM; - goto err_usb_put; - } + if (ar_usb =3D=3D NULL) + return -ENOMEM; =20 ar =3D ath6kl_core_create(&ar_usb->udev->dev); if (ar =3D=3D NULL) { @@ -1176,15 +1171,12 @@ static int ath6kl_usb_probe(struct usb_interface *i= nterface, ath6kl_core_destroy(ar); err_usb_destroy: ath6kl_usb_destroy(ar_usb); -err_usb_put: - usb_put_dev(dev); =20 return ret; } =20 static void ath6kl_usb_remove(struct usb_interface *interface) { - usb_put_dev(interface_to_usbdev(interface)); ath6kl_usb_device_detached(interface); } =20 --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A53333A02B; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=eR7YwDKFb5tZARYgAZU5DZCc3GtaYyOAVGNQkI4qXT9Fz8k3ZQVitBYnK20wnyd3a80Vv1sU5p0cvWupc6iR8zQnZ7skE0FbZCC8Z2Irm/3Uyu6ivIOlJeNNDHJBcDmoxYi7woXdz7UefJ708l6wfVqAuGbbb/bpzm4MHj5oX54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=BJvbZkWynHLgBgJjsx12cqTdSqkHD6VpiScwFoXBO2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R2KV1iEHNKWRh9HhV+TfiaZDJ9JacgiBQKW0ubVp/EvJF5FJ6oyE5ij7445hVn5QpVUYMyhhLvQ0+J6Vls3bIw2ITcZaZmX5erGAn5+OgA7YcekukbwiacwfMnvl+BP9hS7o9NniCH/N2KAuKL5HxZ65RY9bfObdRm3aT12g99o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N8Jz2X30; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N8Jz2X30" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 950EAC2BCB7; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=BJvbZkWynHLgBgJjsx12cqTdSqkHD6VpiScwFoXBO2w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N8Jz2X30asuT03WkVMnqHDL+Lwb3vmpaUJFnGwGQjfN6hZFSHlvZklAfVlbnVSW8e NkSx/w0DjjxY2q1wDgQC5ansgflJbi6Rc0sMKD0FfbZcRbGw2foLl91jqt2/LFfYCA mW3TB6K5Pqk5NTRkYz4G40eMxY0MNdQ33JsMeYLNwMGMjPGfLvBk/DARIZLEE4Ul+J 2SznEp+Q6dCGO9HmToqXgxO3D+xIfHb7icajF3M/YFIDLXXA530wqmE4X7mx5CfqQ7 5rjn9/N0j2Ea3zsqlSKuZjnR8TYWkAhK+s0iNYbLVGDepOMy5KwbJTgVfj1hkbyAVh aXS3E6IQGddNQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AN-3ShE; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 02/18] wifi: ath6kl: rename disconnect callback Date: Fri, 6 Mar 2026 09:51:28 +0100 Message-ID: <20260306085144.12064-3-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the disconnect callback so that it reflects the callback name for consistency with the rest of the kernel (e.g. makes it easier to grep for). Signed-off-by: Johan Hovold --- drivers/net/wireless/ath/ath6kl/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/a= th/ath6kl/usb.c index 814faf96f1ff..79c18f5ee02b 100644 --- a/drivers/net/wireless/ath/ath6kl/usb.c +++ b/drivers/net/wireless/ath/ath6kl/usb.c @@ -1175,7 +1175,7 @@ static int ath6kl_usb_probe(struct usb_interface *int= erface, return ret; } =20 -static void ath6kl_usb_remove(struct usb_interface *interface) +static void ath6kl_usb_disconnect(struct usb_interface *interface) { ath6kl_usb_device_detached(interface); } @@ -1227,7 +1227,7 @@ static struct usb_driver ath6kl_usb_driver =3D { .probe =3D ath6kl_usb_probe, .suspend =3D ath6kl_usb_pm_suspend, .resume =3D ath6kl_usb_pm_resume, - .disconnect =3D ath6kl_usb_remove, + .disconnect =3D ath6kl_usb_disconnect, .id_table =3D ath6kl_usb_ids, .supports_autosuspend =3D true, .disable_hub_initiated_lpm =3D 1, --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC37B221540; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; cv=none; b=hyGqwSOFeAio0faeoiYKRho462OSsygrOtebPxi8uHcf620kbSWF5HLEewh3Umwfcj7+GFpvo6gxrJaWhC9MC2SNs+hQzb0uKBKDTbDrNYi/uTCmuwir13fG5wBGNseLslkfh6/cZJ1KwiyHrL62WZIhrxAlqXvtkkA1OtwUFz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; c=relaxed/simple; bh=CldXdF4K1Mffbg5Hf+ZzFSSzMyz/wwpC433QQhvr9WY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kBSRaF/RKMmlRq641KAhUHHIOSK3H44hwcvqcD1hWATuZoi8DXJNQDwNU6+tY1A5PvpJGFiGO7bl713UeSsun5C2BgUWmJL6DWVjibE1qvPbRSM07til77fZDcs67f4Dkb1+GvxyNItKwiqeLDE7Pkig6jzX3cOjKAG3HZwR/Ug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l3HfQI9X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l3HfQI9X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72BF9C19422; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=CldXdF4K1Mffbg5Hf+ZzFSSzMyz/wwpC433QQhvr9WY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l3HfQI9XxCSFGw0VakBBYXmokEmmYt1/tlAQo6BgUVIer8N+lRwolY3OaUyj1SWaJ HwzjTy/vLa9Ed0giVwm2v90wLgjqEEDKLhTSm5bFh7Po3pU4FQ+e++GagItyxlV4k6 SgMXplOVAn4cdFI4Cf7dEIosB3jC1dB5h13hMRah+5/Qx39Yz5lQgKFKmx2YAvBima ICpPzBE0NaM9K6fEuydKpNliNgikNE+1QvDLxAMvYp8yFXPXdQ+5DfEKY+41m0wivM wgMVQjvdVOcIMBFYLMcKU7CMxuoWbl+0zbWRUEQPqpSm2xZc/MTibJF+VAzrvzl30Y Rs77w1Zhsm0Yw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AP-3VK8; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 03/18] wifi: ath9k: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:29 +0100 Message-ID: <20260306085144.12064-4-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen --- drivers/net/wireless/ath/ath9k/hif_usb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireles= s/ath/ath9k/hif_usb.c index 8533b88974b2..821909b81ea9 100644 --- a/drivers/net/wireless/ath/ath9k/hif_usb.c +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c @@ -1382,8 +1382,6 @@ static int ath9k_hif_usb_probe(struct usb_interface *= interface, goto err_alloc; } =20 - usb_get_dev(udev); - hif_dev->udev =3D udev; hif_dev->interface =3D interface; hif_dev->usb_device_id =3D id; @@ -1403,7 +1401,6 @@ static int ath9k_hif_usb_probe(struct usb_interface *= interface, err_fw_req: usb_set_intfdata(interface, NULL); kfree(hif_dev); - usb_put_dev(udev); err_alloc: return ret; } @@ -1451,7 +1448,6 @@ static void ath9k_hif_usb_disconnect(struct usb_inter= face *interface) =20 kfree(hif_dev); dev_info(&udev->dev, "ath9k_htc: USB layer deinitialized\n"); - usb_put_dev(udev); } =20 #ifdef CONFIG_PM --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 978F337B413; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=EgrHDdBe5SwQjuEtvqd7CXQ6ptN/hT8x4L/Mn51BB0qLxJ1JzsC/0L9IHkYGM9pYQeS9MpA5CNmhskTJgEU7ewyQcpCgS7uCwv4qDebZMA59SARK12OSukqo2yP+v1TWloDxE1+J68haTznFLg1KuUghIfbDSBtxU5/yh7IhL98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=FN0VJHU1PjM85EHuCcDhs9wmITRbjTHJ5B2iAepNjnA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A1+4Wgol2fNrlHD/5Y+xfoR2RUMwX56ObbtVC+atWaZ8JLQGtBHpDjN0b7umyYPszlnrP/FUNgPR08ch55TS6DakqKGNb+Dae0N4skqtAjSM05vTFFbWvC+J85BhS1x3IKVxXbqBs8ds+um906Puez7ESUUkYnmPrxOAHQ8FOaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qlMFBmYt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qlMFBmYt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FEFDC2BC9E; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787136; bh=FN0VJHU1PjM85EHuCcDhs9wmITRbjTHJ5B2iAepNjnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qlMFBmYtZUCIHK48xkIvLAAS8mRvw1pXCfwsq8eWwybG2xRBft35+0wDz+0d9A1U4 bFTRzeHAtdmXivQvqaLXGSx1Wx2yonpD5KDb1ps+lnxi2pB41B68X1mkl1KNzQNOhC bzgYqSQNTatS9KyP1lxwW8BtDHerWcHRZe0Vq++t/XqkR5nzvQ1YuBwHKCxV6Kj9im WkIh0dW0mp6K4rRnYEHfXRrNGNS8Z1SmZBPsiEw/7gh2waUSd/id+8HN2JitWRRYt5 F57sPNCsjGdKyvydX2VNI/+9G3Gh8Z8tHUjW61xPSg7Jrdduu2Id9XvmGgAwZibYQV ziJACLB/YGXyw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AR-3Y1A; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 04/18] wifi: ath10k: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:30 +0100 Message-ID: <20260306085144.12064-5-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/ath/ath10k/usb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/a= th/ath10k/usb.c index 6661fff326e0..ad1cf0681b19 100644 --- a/drivers/net/wireless/ath/ath10k/usb.c +++ b/drivers/net/wireless/ath/ath10k/usb.c @@ -1016,7 +1016,6 @@ static int ath10k_usb_probe(struct usb_interface *int= erface, =20 netif_napi_add(ar->napi_dev, &ar->napi, ath10k_usb_napi_poll); =20 - usb_get_dev(dev); vendor_id =3D le16_to_cpu(dev->descriptor.idVendor); product_id =3D le16_to_cpu(dev->descriptor.idProduct); =20 @@ -1055,8 +1054,6 @@ static int ath10k_usb_probe(struct usb_interface *int= erface, err: ath10k_core_destroy(ar); =20 - usb_put_dev(dev); - return ret; } =20 @@ -1071,7 +1068,6 @@ static void ath10k_usb_remove(struct usb_interface *i= nterface) ath10k_core_unregister(ar_usb->ar); netif_napi_del(&ar_usb->ar->napi); ath10k_usb_destroy(ar_usb->ar); - usb_put_dev(interface_to_usbdev(interface)); ath10k_core_destroy(ar_usb->ar); } =20 --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7472331A43; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=tG7yVTcDx+ryR07BMfSVlBjLdAHpgy15Aiu19irxnlDl8FS39EHgLTw43O6IHXyEvQ4tQ8Y3zxv5zI2bkcWgzOzxwgBPY+LZZhgXfOYWlCJFoHXTDuhLO47wenpTKrs7BGpyToEKh/WIvV7EJ1A5pPM+k4tZGWL4pZH8E+E2miY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=Ke1gkgIAYNvXJE3uYWjze9f3v5h9YO7tPFOsLk607jg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lr2S2Fl1ueHsl+McKjRU0TQeTbdXPTwZskrhJDxp2ojG6c3c6BVyXQfPbP4InHPtPp2OipwKyqkESIMvAXIpfVhM30oZTETkdKhFmd39WlA74BWKo45jpo43wT5TWLRyTI4fqplxY7Vofzuo34jZ2g+2EJvy55ftpU6r5KhMrmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RkTQdAht; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RkTQdAht" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E031C4AF09; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=Ke1gkgIAYNvXJE3uYWjze9f3v5h9YO7tPFOsLk607jg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RkTQdAhtU9OR9wvXzGhf4ByQYCL81x9oU+6JIn2zapFSOpWh3n500gV1EOvKfElR6 4YL6PJn2Wc5gU2T9gLfblYVDs4+/HxQ47n/CboaYY0S7FMhjUi81erdWyrcbk+jvyd kkg/0ejujbFNPj6TJVGkeP1Oa11mjtxFTJRDX2fE9fdiOP/iDDsDCoeTA3e52/NzGo oFRf3SlOQW4uBnsdMOZK+YHUOk6Ia5MSxzI8sNTbH567UxMTfGGsXMa2hhoKO++dzs nhNttX8+IvfLj082op/P53vR/pPknfF9cuPa7FfVYf06bGbYBVgKnJYYBw9/syBPL+ R+m+pVzH8l5xg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AT-3aeF; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 05/18] wifi: ath10k: rename disconnect callback Date: Fri, 6 Mar 2026 09:51:31 +0100 Message-ID: <20260306085144.12064-6-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the disconnect callback so that it reflects the callback name for consistency with the rest of the kernel (e.g. makes it easier to grep for). Signed-off-by: Johan Hovold --- drivers/net/wireless/ath/ath10k/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/a= th/ath10k/usb.c index ad1cf0681b19..987d57a01ddf 100644 --- a/drivers/net/wireless/ath/ath10k/usb.c +++ b/drivers/net/wireless/ath/ath10k/usb.c @@ -1057,7 +1057,7 @@ static int ath10k_usb_probe(struct usb_interface *int= erface, return ret; } =20 -static void ath10k_usb_remove(struct usb_interface *interface) +static void ath10k_usb_disconnect(struct usb_interface *interface) { struct ath10k_usb *ar_usb; =20 @@ -1113,7 +1113,7 @@ static struct usb_driver ath10k_usb_driver =3D { .probe =3D ath10k_usb_probe, .suspend =3D ath10k_usb_pm_suspend, .resume =3D ath10k_usb_pm_resume, - .disconnect =3D ath10k_usb_remove, + .disconnect =3D ath10k_usb_disconnect, .id_table =3D ath10k_usb_ids, .supports_autosuspend =3D true, .disable_hub_initiated_lpm =3D 1, --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C69DE32ABCA; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; cv=none; b=V5wKRWiRWQMdR6LRhhP7N4uiRwasrniHGlgPqdyyxz/Y+mtFqtPUUo0gfzoCdjeZEy2SKeah1GD9wgog/fDYBH+/zIcVBcaLzLtsUoV+8jDrxnpi8uuGZ1yTC6O9YZqOC6tZ0akMVrQBL/qLXbVnzfJI6MDyUi3CTNujY8eS/so= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; c=relaxed/simple; bh=JAu4aGrnPPyf8CrNrqLPSHkFG5LAr0AmkxM6UI5mqdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YSyAls4UhM+nQgyjsQZFutPTPK50UsmVfycpknj7lGA+hxR8EWGcXQlDHXxEODK46kS1UvmWuj2XMux/h4U0Q+PeGZMU6mnJ7PXs0XBvK8PLTo3VOcYtxJd0GgDyT23UzjnyRuwnNJ56wkAKra9JbOiWzOhIJby9HklZFkd73tM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cBbq+bqg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cBbq+bqg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D94C2BC9E; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=JAu4aGrnPPyf8CrNrqLPSHkFG5LAr0AmkxM6UI5mqdE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cBbq+bqgGOzJohI3myC/rfmWyVTrUMYfGt24Auc7rMLkPX5htugIF32oay0ULQKj3 M/7ztsuslvGQU2BRKlQbEpLeJb/0+4DjefPdOaaawI9lYQ/hM9smL801tOHLeo0X6i 5UYECwfxN8dB2bD73fqskcY3G0RZFj7rPNsncA5g4Zm66sE9WW7kH91urn5X8ESQpP pDZHjlNhAA/cKob7SHkgA00ihWO38siJEvu3LpgVaaMy4LCsO6vT1U4z5Qoe1C8ata kMI3IWvmffe7R3sxlQktltQxG2ER5ly37if+2BWgVjApsnSYSbcVvtJkMl6IFmfuCl 0wGveMa0liShw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AV-3dQg; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 06/18] wifi: at76c50x: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:32 +0100 Message-ID: <20260306085144.12064-7-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/atmel/at76c50x-usb.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wirele= ss/atmel/at76c50x-usb.c index 6445332801a4..44b04ea3cc8b 100644 --- a/drivers/net/wireless/atmel/at76c50x-usb.c +++ b/drivers/net/wireless/atmel/at76c50x-usb.c @@ -2440,13 +2440,11 @@ static int at76_probe(struct usb_interface *interfa= ce, struct mib_fw_version *fwv; int board_type =3D (int)id->driver_info; =20 - udev =3D usb_get_dev(interface_to_usbdev(interface)); + udev =3D interface_to_usbdev(interface); =20 fwv =3D kmalloc_obj(*fwv); - if (!fwv) { - ret =3D -ENOMEM; - goto exit; - } + if (!fwv) + return -ENOMEM; =20 /* Load firmware into kernel memory */ fwe =3D at76_load_firmware(udev, board_type); @@ -2534,8 +2532,7 @@ static int at76_probe(struct usb_interface *interface, =20 exit: kfree(fwv); - if (ret < 0) - usb_put_dev(udev); + return ret; } =20 @@ -2552,7 +2549,6 @@ static void at76_disconnect(struct usb_interface *int= erface) =20 wiphy_info(priv->hw->wiphy, "disconnecting\n"); at76_delete_device(priv); - usb_put_dev(interface_to_usbdev(interface)); dev_info(&interface->dev, "disconnected\n"); } =20 --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC42223D7FF; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; cv=none; b=Y8L/tyGpMWwBQ0DzEW9jO33pYGSHMmqgZhVZyxKog48HDV3OuNkYeIieodUjPEAYnO81OD0Y/PXbUWZKGSkdxyQSbQ+s2bmgwS/W5j037O8HZZnegE1+jRbCca5hQht45EBmQQpiDG+pu9VgfbmXkzPe/ugIbDu7LgoXo11gNws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; c=relaxed/simple; bh=kaq0JBNHyQqQlidhi1/aPYh1/H5njyrGvo0l9Tfow5M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZgOkb5JcHKBy94Wf76ogFQUOZosq+W5wgVkHmF4AiaSV7L+1nxtSe8Y9/wYs8pw+sZK3HI0MD5KzCDDyJ4q/jMazb8rNM1jBbupa/Fs96lmiVpG8i9pt9J1YitGyfS+KvB7d2wGg9phME0BUWK1OIf8klIZ17iwu/sW9VCvvrBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ezpeRrkt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ezpeRrkt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7055CC4CEF7; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=kaq0JBNHyQqQlidhi1/aPYh1/H5njyrGvo0l9Tfow5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ezpeRrktOFKOzNVq65yGXnie5Ezdwl7U//BjLWxRPul4V5XZ2Wxd3quESPYHJR5xP 309PaUP2Yt6zPfEYXna3tH+VKzCrmYAYpTSX0QYCAy00W6w0dCBt/VBf/Tk5RBsZT2 SiMnMDkzBwkmB2cTH++4tUx/ainTE28zXAei2CNWf9RIyXS0mSvID8reru+33lCRnJ JZASEcaOEQiL6g2ZBDDYnCIUxp73XeA73j9HTYcW3GMFjZzZahCLV1oBsMI7K+nhF9 dJCuF+ZbNn8V02mrERYpSHCxk0zaF5xS6Fq2bW99vKVOZwlJz3F5b+DcSMZVeWHOw6 m7YzmLzmCfqXg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AX-3g6H; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 07/18] wifi: libertas: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:33 +0100 Message-ID: <20260306085144.12064-8-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/marvell/libertas/if_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/w= ireless/marvell/libertas/if_usb.c index 8a6bf1365cfa..05fcf9cc28fa 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -276,7 +276,6 @@ static int if_usb_probe(struct usb_interface *intf, =20 cardp->boot2_version =3D udev->descriptor.bcdDevice; =20 - usb_get_dev(udev); usb_set_intfdata(intf, cardp); =20 r =3D lbs_get_firmware_async(priv, &udev->dev, cardp->model, @@ -287,7 +286,6 @@ static int if_usb_probe(struct usb_interface *intf, return 0; =20 err_get_fw: - usb_put_dev(udev); lbs_remove_card(priv); err_add_card: if_usb_reset_device(cardp); @@ -321,7 +319,6 @@ static void if_usb_disconnect(struct usb_interface *int= f) kfree(cardp); =20 usb_set_intfdata(intf, NULL); - usb_put_dev(interface_to_usbdev(intf)); } =20 /** --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 447DB37269E; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=T/VTNF+6a29s42FOOEPKIFw1SWz1ShQ2hm2/aWsPmjqFu8abH9oLTGSaIfrPJz2dwkxRKN8vED8o0i9P5rREnGOhtlgJsZA40Wxx/h5A0wM4N8lk8R7RY6b0+UzwtaFezVhWHN1pxJ4ef9HGLeQPB28esu6OOFAlj8r09DC4Ik0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=Wg9PdiYnvFewTYn81qDhfXqKVkfZq7jAfwyGUQeiiBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EfLdnZ4h/qCqdu3ZAtjC+zXhjw8ZMOaasrseWAUm/ddMlUKU1lilTU3cWg7dxfF4IKrhIWsjBJ70MI+V9uEbAuoBBYawJipa/5Ey5if7et0xRhF8ssV3EOaPr3Afax969CB7rUaenyH2kB+RnA6bI3W/yhEABeK2BhGBDECYaHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VHP7JZ4W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VHP7JZ4W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A58BEC2BCF4; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=Wg9PdiYnvFewTYn81qDhfXqKVkfZq7jAfwyGUQeiiBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VHP7JZ4WHODayaL/lRc5G+Ol3AvbHNSE6IBp15uYa9mkQcm+puMjYGNqJijHif5v8 fRR5k/P9qGnooaPzCszQq9yOsiGB2t8u9wdpC5DAoDvvv5Ihshz1xeILsqe7JB9otu 2lCtIY/1OQFAnjFDezG7//xwOyVsStMwvwi+mRvwPEXSYmuwHz4G43kHyZaMGxOLSy e0cfNcexUBi5uLH5w2x3Ek3/hnrkxz6zXjFb/tDV5z5J8a9aSMxdXWfuPw8SQH32nk MVYOzQ50axncaW4ByKPwPUtRMFmJ3ZrD9vfBMvHjaZ4UD/B0WnWV32+amuioAzLR2n v4/6NvdJcE5hQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003AZ-3j22; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 08/18] wifi: libertas_tf: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:34 +0100 Message-ID: <20260306085144.12064-9-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/ne= t/wireless/marvell/libertas_tf/if_usb.c index f49151c18b79..07b38f2b8f58 100644 --- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c +++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c @@ -223,7 +223,6 @@ static int if_usb_probe(struct usb_interface *intf, if (!priv) goto dealloc; =20 - usb_get_dev(udev); usb_set_intfdata(intf, cardp); =20 return 0; @@ -258,7 +257,6 @@ static void if_usb_disconnect(struct usb_interface *int= f) kfree(cardp); =20 usb_set_intfdata(intf, NULL); - usb_put_dev(interface_to_usbdev(intf)); =20 lbtf_deb_leave(LBTF_DEB_MAIN); } --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4BC329E57; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; cv=none; b=KMWP3CY7p/oUTNcXBLc8GnusXM2nND7lSYQpbpHhZov1z8OuOi8F4QcjGFtjF+ry5eDd+TPin+zXXb3wv3KEmS8nFyNK3rIi59iwMreAHs91tNE8NzL1WODU+boeDsN+juoImrDgp+4zUshhOWMgo7pZyBYJfPnTjGSnVdAw53A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787135; c=relaxed/simple; bh=+n2gwwI5ICbPV5XOVnFHvtm0RnUfCoQpce3aU1BVfTM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Al6gtFa6TLWdzSAIkhkclqK19T21mtDcZSi2AoZWX5IH7hdOvK8HyUNIs9YYzaxSHPLacTE/bn9MGKYsNQoEOeGVLIo2tnhvTV/o3VDxIp+V0y7MjZCPPpqPR2ZAlaHnLpGZmuETxAtoD/X6sDrKvwbbTLCv28evz2TBs9SSE4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HTZBBKZt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HTZBBKZt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75B7CC4AF0B; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=+n2gwwI5ICbPV5XOVnFHvtm0RnUfCoQpce3aU1BVfTM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HTZBBKZtuSCAj2lJF5fx0z3B+G2qxYh7V/TS0bw6J9UfmOlMedNp+p5WqFoWwMdbc JWtz1eS7zYpFaIOWdcPEcGIrulFjnnH0uPHrCfizZzxENov9uR7j/5aZLM4zWtsrmt 4axX6JrODte7fw1LT8QpcXf4+CVfU7ppf+sVBdrwrPILdqIgncHoDV/02GAJfZf9qv GaB8SxL1RarkA8hD1F16VzvRnmuTmiQdErUuqy22WowYBiVC0IdVvJPNXtK78l0fxH JQhENdv4J2sR90Jj8hs1mXs9CNWfWiRcanfx/3MPv/rJk7j1OBZSSeB7PCT+cbJyNE lkIhLYUspGxFQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Ab-3lpS; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 09/18] wifi: mwifiex: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:35 +0100 Message-ID: <20260306085144.12064-10-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/marvell/mwifiex/usb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c b/drivers/net/wirel= ess/marvell/mwifiex/usb.c index 947ecb0a7b40..f4b94a1054f6 100644 --- a/drivers/net/wireless/marvell/mwifiex/usb.c +++ b/drivers/net/wireless/marvell/mwifiex/usb.c @@ -520,8 +520,6 @@ static int mwifiex_usb_probe(struct usb_interface *intf, return ret; } =20 - usb_get_dev(udev); - return 0; } =20 @@ -666,8 +664,6 @@ static void mwifiex_usb_disconnect(struct usb_interface= *intf) mwifiex_dbg(adapter, FATAL, "%s: removing card\n", __func__); mwifiex_remove_card(adapter); - - usb_put_dev(interface_to_usbdev(intf)); } =20 static void mwifiex_usb_coredump(struct device *dev) --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8665333429; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=eY0S4ZvvR4B4sBeJqhIZmb72oUmMgpu7TKkbMt2rNiu3j/zIjbinVIciNSTZLIeuIUt+EbwcLFyzgeuBHGu1HUJO2iNfoJnGYYZnBOOZvcbe64cZFVfvaYrEx6EgRXgKY1uRAvsUhnyFxHmLSQ52tQ8zdHrDA6N7+ci05Qt54dQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=42Ws8GlzTjjM4nukmpyywyMHmPwKfyyiFsTL7Pg3heo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=asjd2pxjjuzUnvi/WKwZp0RR/HePnCEAH7+5bRA73hEuCKcn0uHbN3V6jwkoXYLLZCMsrNIHRWcr43bwW4e7REla65ID3YsFuC1uS5gTk1/jEbTxRuTT/tA5kQibuPZ143PSLac57ey+35cIgYWoajsfHSR3mzr101kYy0VmuP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sySipilL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sySipilL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BAA1C2BCB1; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=42Ws8GlzTjjM4nukmpyywyMHmPwKfyyiFsTL7Pg3heo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sySipilLYKw2fVi0oo+KmwpwgUgh+BtcY1QfdMT6KloIrIYssI4xHJFWwPg2abiv0 QU32Lo0oxFc5hwM3HFQvFVlybNq1LmdRxqXLrRWJwaecw0PI+z/v9J6XtHvz4ob+ZR t/xBUS4WMvzqbcnnCf1O5loBxBmrwR6/b3guM3BGHHNG8c3aeqMvxDlQsBrxdHsQre 6zUPiLHKM7P+WP4WXK+n8+J/4SEmWPTzFEomyFJvIYZBqvigSkCNtacJWi+6rSL0Cj kBfAjcMiiuErA49fuh7AyXq0TEAgOf7yOS0UpuohfDpMDpMwX43L+PO/ihsgT6jErG hhuSTWTb6z6nQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Ad-3orG; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 10/18] wifi: mt76: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:36 +0100 Message-ID: <20260306085144.12064-11-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt7615/usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7615/usb.c index d91feffadda9..bab7b91f14be 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb.c @@ -151,7 +151,6 @@ static int mt7663u_probe(struct usb_interface *usb_intf, return -ENOMEM; =20 dev =3D container_of(mdev, struct mt7615_dev, mt76); - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(usb_intf, dev); @@ -193,7 +192,6 @@ static int mt7663u_probe(struct usb_interface *usb_intf, error: mt76u_queues_deinit(&dev->mt76); usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); =20 @@ -211,7 +209,6 @@ static void mt7663u_disconnect(struct usb_interface *us= b_intf) mt7663u_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); } --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E85E3331A7B; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=VdLA7Zjt3kIvAhXsvTEAIQnM+3gzey9gFHMGxZ63Nd7RO6CBsu2lkCrbKUvYumFwPB2AXKm/iO2pS/04CshCxKd+3HUOZWuEDey+GwM+ogg/RkI5k+YIdr40DAiDVfcc2MmE20ReKobWo4Sqj+1RRnXC0usXFDC+W7OBQ7+AOyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=0v5Gv1OSiBL9CUheGKWW1u2VaL5UzKQuFEiUKbDcGSo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Iu7SJ9F5s5TqJOE93Jin3hDiFJz+/JfLNNO7ABE8tMlp7w4Zdp1pTet4r2d0vJR1DrSUogQdd00mcctWN6j1csNCE2AfBSCvDnkpLFPgM4eh2atdejZSjoC6/EHsmf/WPUSoQcy+zxQg8d7Faro+UbgReuoB32wOsGMQ4uXzO1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b23fHuz8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b23fHuz8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91352C2BCAF; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=0v5Gv1OSiBL9CUheGKWW1u2VaL5UzKQuFEiUKbDcGSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b23fHuz8rrHVyIuJwvRkrLPMyxr5r7rqL7HeSGX+K3Z4LxJZYwPCbus0qFNjXvNry kXm1mUmc1MEN5jqZ2yi31+67b7T3bRNzF4uQIPOD3iknccilxukCf597Tk3ri9m34n ynhz3xkoMQ1edC5/afzZuthxYsvCBtUKOanRCeeI+MVmHi6ZYhYmww8tVeAi48dEBg 8tfOcHWghrcHv4CUu19Osj24G1muf1kAUAR0RCAE4OGM1VA0LCPLx4VxHGFtumVAdM w1zMVBU65xZHhDlcaWfQ/+D4yVA4DXHWTkqKxVHUByRy6FFPijaNyXAu1iYeVBk2Bl VR7vHvm3rI2KA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Af-3ruV; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 11/18] wifi: mt76x0u: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:37 +0100 Message-ID: <20260306085144.12064-12-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt76x0/usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c b/drivers/net/= wireless/mediatek/mt76/mt76x0/usb.c index 90e5666c0857..2acce121fb14 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c @@ -245,7 +245,6 @@ static int mt76x0u_probe(struct usb_interface *usb_intf, if (id->driver_info) dev->no_2ghz =3D true; =20 - usb_dev =3D usb_get_dev(usb_dev); usb_reset_device(usb_dev); =20 usb_set_intfdata(usb_intf, dev); @@ -284,7 +283,6 @@ static int mt76x0u_probe(struct usb_interface *usb_intf, =20 err: usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); mt76u_queues_deinit(&dev->mt76); mt76_free_device(&dev->mt76); =20 @@ -303,7 +301,6 @@ static void mt76x0_disconnect(struct usb_interface *usb= _intf) mt76x0u_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); } --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E70C5330B28; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=jNibq8/+eHSfcoFmxdGANqg90Bb83kMpT+42Dks7mqhD75Pps4thaTCVGN1iAri9FBv11obO5tyAt7hvqMjswXZS8IZVQNdIQYuE7B7qxD8RRKm2x7bFTo2SJW2rmZH19EwhKOzAxRxpNWspV26GFfI7r+xYPNaY+q9ss84cyP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=xCEaqUoallq2NdTzWqQElwbwYb5T0f2rYJwsXpRUAaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M2Oz7iiFSYvyUUjSofQ/dEu8D/UlBYz4RLtG9j7qknAzyM+y7Qk6HsPcS/WvGChyLX2ZUoFuIU51Hw83NazI/oE8d2BhuOas+F/BGPAykg63cnKxROgBob6Y6nvG19VdpdgRwQ9vCe6QbSsjlM6uK1vwF/MmOPY2I2Nbo0sfBkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kvNzqT7N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kvNzqT7N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B781C2BCB0; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=xCEaqUoallq2NdTzWqQElwbwYb5T0f2rYJwsXpRUAaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kvNzqT7N5X+8TX19x8BWY6BvUmFfbUw+2yOT1rmMozBVqR/gYrGArQP7Z964wci73 VZPVvz7GrXGDDp4EbRr7XAccgN78dx5juaLxyu2poNjJkdiE7DkNsdPoPMeSIwpOh7 OeduSMouDflTVP4VbTPWbnKja/arjy0CJ5hVIo433js3ACXjYpAbJFqfnQqI49eskK ffQhibux2LDYrVWhB3CmB7Q2C7JqXr81plwts8I1yGcOHEc7DbSL+UJGB2+t85dSKr bGq7ioN6/vODGnLtx0Chw6Rm2MnoR6sL9GYC7xO8tUE45XIs/FwFk40a6A7txv0qH2 HW3TWLoNYGsyg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Ah-3uu1; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 12/18] wifi: mt76x2u: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:38 +0100 Message-ID: <20260306085144.12064-13-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt76x2/usb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c b/drivers/net/= wireless/mediatek/mt76/mt76x2/usb.c index 01cb3b2830f3..8af360bca643 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c @@ -57,7 +57,6 @@ static int mt76x2u_probe(struct usb_interface *intf, =20 dev =3D container_of(mdev, struct mt76x02_dev, mt76); =20 - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(intf, dev); @@ -84,14 +83,12 @@ static int mt76x2u_probe(struct usb_interface *intf, mt76u_queues_deinit(&dev->mt76); mt76_free_device(&dev->mt76); usb_set_intfdata(intf, NULL); - usb_put_dev(udev); =20 return err; } =20 static void mt76x2u_disconnect(struct usb_interface *intf) { - struct usb_device *udev =3D interface_to_usbdev(intf); struct mt76x02_dev *dev =3D usb_get_intfdata(intf); struct ieee80211_hw *hw =3D mt76_hw(dev); =20 @@ -100,7 +97,6 @@ static void mt76x2u_disconnect(struct usb_interface *int= f) mt76x2u_cleanup(dev); mt76_free_device(&dev->mt76); usb_set_intfdata(intf, NULL); - usb_put_dev(udev); } =20 static int __maybe_unused mt76x2u_suspend(struct usb_interface *intf, --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9C8371871; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=YCbhH+UkSAk8AXSbOMg/Lrx4QbIp1CmVgEnk8SQjpt7aSpZMY8dmYnTRLYpeG0gxq5MDAhwBNCOqlA/HxS82iW88dRGanaM/Ybthck4S8a0DtZiXILHwxsFNo0VE+4aZK/mWhNdeuGG+iBf4TqixVgEV3Np8Vo3jsOnbLM8UN3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=tGJ7KOHEEm7rLo+cGLabikKcGHzDBaTAEAtltw3d7rk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NosKY5Yc/2PdnjEmsx4wCUDwLDW3ZMcsrVqCzzE2ac51bJsklr3fELrsFmzxjI9vVwEpeftjU2SPq02u71F13kFKq15d3YX2xZCue4HXjFpA8V3BjhvjH1N74S3QYPUjRzUea11aKXWitvVnJ21eKGddFkcbBSJ+dysmu+1Kdqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ViKDPWHJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ViKDPWHJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A05BBC2BCC9; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=tGJ7KOHEEm7rLo+cGLabikKcGHzDBaTAEAtltw3d7rk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ViKDPWHJLMng888Uois8njx25ro9OZdDMiV6HPXZP4xWUV43wk2G/thngDeEz17Ty dFD2dg5CQoexDnb7HGfO0GknRTqV7MKD4uXz6SZWCxxcbTk7DOQ4/69wj+rYoNE8A3 YygmHDI4vcanqvAwDsVNlOX4pTya/jaqQlVZ2NehQfaf48jlErICpaEgyZG1wsrfVl 6MXOxsLe4tGa3d/YCLRppgDeYOCxy6VlaP2sKvCskg4Hv0jJ+9FA6Thq0+FvDkJk9Z ne7m40CmxwhWEEzhPdBaXPhFVuCybtRQVA6YfQUdbZmcyog9cYZyG7qOEep5OtJj5u CTQ5aADWqBcUA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Aj-3yHd; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 13/18] wifi: mt76: mt792xu: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:39 +0100 Message-ID: <20260306085144.12064-14-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 2 -- drivers/net/wireless/mediatek/mt76/mt7925/usb.c | 2 -- drivers/net/wireless/mediatek/mt76/mt792x_usb.c | 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7921/usb.c index 17057e68bf21..9bfc234f306f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c @@ -197,7 +197,6 @@ static int mt7921u_probe(struct usb_interface *usb_intf, dev->fw_features =3D features; dev->hif_ops =3D &hif_ops; =20 - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(usb_intf, dev); @@ -246,7 +245,6 @@ static int mt7921u_probe(struct usb_interface *usb_intf, mt76u_queues_deinit(&dev->mt76); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); =20 diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7925/usb.c index d9968f03856d..84bcebbf009a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/usb.c @@ -185,7 +185,6 @@ static int mt7925u_probe(struct usb_interface *usb_intf, dev->fw_features =3D features; dev->hif_ops =3D &hif_ops; =20 - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(usb_intf, dev); @@ -234,7 +233,6 @@ static int mt7925u_probe(struct usb_interface *usb_intf, mt76u_queues_deinit(&dev->mt76); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); =20 diff --git a/drivers/net/wireless/mediatek/mt76/mt792x_usb.c b/drivers/net/= wireless/mediatek/mt76/mt792x_usb.c index 552808458138..f827e8a56a18 100644 --- a/drivers/net/wireless/mediatek/mt76/mt792x_usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt792x_usb.c @@ -306,7 +306,6 @@ void mt792xu_disconnect(struct usb_interface *usb_intf) mt792xu_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); } --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DFF633ADAC; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=jKbz/PAxnTJsxKIZpxFMRVU0ADVKHS6zl1JvV1V++EALK4rcOokaD3Jvq1fcJCPb9lofJi133GcLQvD4r3Amr2K8h8W5Rz1rJJdRPzyWQJRFO/OjaQ8sfSUxZk/D9RIa9DUmIyB+idlsVHykLHkc5WBm+/b09auAncuHL9CZR4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=TeJWcibhwqPsG9lU0UCk3JLuhDg4KJLJiyLETuN7pPs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eU23/Wv6Pi2TbnwCBec6lyzdjsb5m1jHjKCnp3jlWHa0MC0uSOmbI3L1k9SjBrCXo3a+uLChfcNaobBbCTRzGFqYJWtiD38P7n0YnykcuMOhVa3Cng5SoHvniV2bPf7GTLOZbHkHkWdO6hDbZtPfXXDLBOW6vrR7Fa4S93g+RUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=klZj7x9d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="klZj7x9d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97E1FC2BCB6; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=TeJWcibhwqPsG9lU0UCk3JLuhDg4KJLJiyLETuN7pPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=klZj7x9delzZfbAIvM8n1rR+sod6Iaoj5YkgZK2CNfCFUCtq1Zx8I3SN4K3sY0I39 kQxgExDdKIFIiI0d7ZXBuEvxKzh0JHShYU+taf4t7jPcAyegRd2KY7qSoRG1g9cAUV qYGV/eKj1mCq7K3nDrmzEQ8HzfADcA1UZalh8RoMGiZ4dGyAapkeeim5z3LWDp0TLO 1LOJLFZEWJ8MrmNep7guDWX4chcbzNM9sCyaiNfyLeUEm0eEjGZMi+Sz/5qy3zF09j q09a2vzciBsh5Gv3J2y7wYiQpVNQqmnP2CcgxvnENbBLO1JKfPe9eQhkBKRhtTiyFk fbvfyHC9uqxmg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Al-41Q9; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 14/18] wifi: mt7601u: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:40 +0100 Message-ID: <20260306085144.12064-15-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt7601u/usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/usb.c b/drivers/net/wire= less/mediatek/mt7601u/usb.c index c41ae251cb95..9306870cbc91 100644 --- a/drivers/net/wireless/mediatek/mt7601u/usb.c +++ b/drivers/net/wireless/mediatek/mt7601u/usb.c @@ -274,7 +274,6 @@ static int mt7601u_probe(struct usb_interface *usb_intf, if (!dev) return -ENOMEM; =20 - usb_dev =3D usb_get_dev(usb_dev); usb_reset_device(usb_dev); =20 usb_set_intfdata(usb_intf, dev); @@ -319,7 +318,6 @@ static int mt7601u_probe(struct usb_interface *usb_intf, mt7601u_cleanup(dev); err: usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 destroy_workqueue(dev->stat_wq); ieee80211_free_hw(dev->hw); @@ -334,7 +332,6 @@ static void mt7601u_disconnect(struct usb_interface *us= b_intf) mt7601u_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 destroy_workqueue(dev->stat_wq); ieee80211_free_hw(dev->hw); --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CCC53783D1; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=NNoF9Iw0Jf5eV7CN8DT4KvhTnMlcErU1OtMj6Hhe9te1uKqYnoLyeWuAqcRTkK3gWzOD/Q6Mh8HOXOaxsVxW25083UReHrKQKGsVMRanGGwmevROIxrfMvs2FFM7b9YeoxDhwa31f2s4QRYTHloLM4ObYzbOOKiiT+9ne4B2Q4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=zJISFJhAJ3tf7TyuqSsMvehn32gIa5K1gPFzzFRKP8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U6dUuoHzZ/wAq5bAR+F2VW/EIV52riVvJGUZpI28SmTLJCWy0tzx0xWzkHikHiRKBRFVQ2MmO37LX+xYPR3QzXZUIcY7bPWWhm4qPfrcb+cP5PjgcC0TkWFAO5Wl7Tpdrj6HRvFKUehYBEni96xEz4TPLVtUZS9gbMAxFUtom+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TAs5q0ZY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TAs5q0ZY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABC18C2BCC7; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=zJISFJhAJ3tf7TyuqSsMvehn32gIa5K1gPFzzFRKP8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TAs5q0ZYlFwz583GQPrQmrsQnUxArfq3F34w4U+2sCMDvC/nXug/+Nr4+DTI1QXYk ivnmXzPWhY4Qu11fWvgRpVQbGpK/R6c7qh5ieqe7m8/PUTyxD2VJCaFX31/3B9nNVC qo7adzvE+ujCgdwLHHuZ+4q59sMZIJ5UVKCzAhWwwi4DvOjrGABK12wzS8svlHzPrn JaHjy8Wb7+UDQU57svziBpWYZtqmmeR3GXfN7VfESLpq5fwX8uf8VFoNU3RO34ZFfw YBcjxakHEXZCweTNoHT76uOyL2/lSsrXD7xMvMaAZ5NXtQWFOXssxsIeLLMdKM2EXL 8mY23MYpEQrgw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003An-45wU; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 15/18] wifi: rt2x00: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:41 +0100 Message-ID: <20260306085144.12064-16-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Acked-by: Stanislaw Gruszka Signed-off-by: Johan Hovold --- drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/w= ireless/ralink/rt2x00/rt2x00usb.c index 54599cad78f9..83d00b6baf64 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c @@ -802,14 +802,12 @@ int rt2x00usb_probe(struct usb_interface *usb_intf, struct rt2x00_dev *rt2x00dev; int retval; =20 - usb_dev =3D usb_get_dev(usb_dev); usb_reset_device(usb_dev); =20 hw =3D ieee80211_alloc_hw(sizeof(struct rt2x00_dev), ops->hw); if (!hw) { rt2x00_probe_err("Failed to allocate hardware\n"); - retval =3D -ENOMEM; - goto exit_put_device; + return -ENOMEM; } =20 usb_set_intfdata(usb_intf, hw); @@ -851,10 +849,6 @@ int rt2x00usb_probe(struct usb_interface *usb_intf, =20 exit_free_device: ieee80211_free_hw(hw); - -exit_put_device: - usb_put_dev(usb_dev); - usb_set_intfdata(usb_intf, NULL); =20 return retval; @@ -873,11 +867,7 @@ void rt2x00usb_disconnect(struct usb_interface *usb_in= tf) rt2x00usb_free_reg(rt2x00dev); ieee80211_free_hw(hw); =20 - /* - * Free the USB device data. - */ usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); } EXPORT_SYMBOL_GPL(rt2x00usb_disconnect); =20 --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623B137997C; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=CYTp19KuD+iSBgAKO30qWT18D18K/O82IJAruSIo2Gq6zVn//3zdV09tBfBB/f2H9NR7Bxa9aZS73thGdt1zaL1m0prGkzbRyH8QPKRDgjsW/tluhasmTlg0czAD4FHqMEcA49YsrNGbo8HZ9+JRJvU9sooSQ6ym8e8ZyEFDONw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=WlcQfuVYUTxHWCyVOtszC/tk9vnPA9GDI5j4ICmNw7g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nTpqEZtPCsq0ozteO22sa2D9t9E2XDOcxJsqaVPu1JZ/7sDGMiong7PruISx/3CjXZKPilARZYbhppeysGL7CxZ2uu3NdK58PrAkk00zFsAsnnwfKpYuHZToQtMZHEwW3vN2Q71G5QnJvPfufPTFdAGnSYLMGPfipjb+u1ReAcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=przSOu5P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="przSOu5P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C21BCC4AF4D; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=WlcQfuVYUTxHWCyVOtszC/tk9vnPA9GDI5j4ICmNw7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=przSOu5PuvIYdQz0nQdNK9TMVRhYHr+Dvb5ogOLy+sx1xd8eJaREzt3IX+4pyhWRs kPSAu2IBi7T+W4TBFr5geNKnz5J6X3UmrM4jAnE3XuBzBv0BMyphJsgaWr5qnxtJSL LcfeVNgfx/67KPtdCSS6VIN7n/YUnClAn6U4C7gxkP+mcb3aaqe0qjFwM/HfTovZql tca8nIPE6V+qh7Y5mDX1RHtMs99E4jTYFymDM4/SYaYFxd6kX3R+uRMfYNNUZj2jIU AO4SBXrqRIGRFH4t51RzpzcIs5bZZjEKYtVPgANgvEDgFEXQaw5uVq4zpp8w6zLjOH ymw/XawocPHxg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQuq-000000003Ap-48xZ; Fri, 06 Mar 2026 09:52:12 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 16/18] wifi: rtl818x: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:42 +0100 Message-ID: <20260306085144.12064-17-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/n= et/wireless/realtek/rtl818x/rtl8187/dev.c index f7e0f6573180..1d21c468a236 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c @@ -1475,8 +1475,6 @@ static int rtl8187_probe(struct usb_interface *intf, usb_set_intfdata(intf, dev); priv->udev =3D udev; =20 - usb_get_dev(udev); - skb_queue_head_init(&priv->rx_queue); =20 BUILD_BUG_ON(sizeof(priv->channels) !=3D sizeof(rtl818x_channels)); @@ -1663,7 +1661,6 @@ static int rtl8187_probe(struct usb_interface *intf, err_free_dmabuf: kfree(priv->io_dmabuf); usb_set_intfdata(intf, NULL); - usb_put_dev(udev); err_free_dev: ieee80211_free_hw(dev); return err; @@ -1685,7 +1682,6 @@ static void rtl8187_disconnect(struct usb_interface *= intf) =20 priv =3D dev->priv; usb_reset_device(priv->udev); - usb_put_dev(interface_to_usbdev(intf)); kfree(priv->io_dmabuf); ieee80211_free_hw(dev); } --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 472C6374732; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=o7iRMsXXrrvZ69uEVsU4y2e19bB3FOwe12oKRCjfftgp6I4CKrrI9TWvlllFl2rQKWNfDsgYdn8sYnBfR7C9rd+SFpTf5UnGkvN2jn/2NUjwfTaicWaOvbaphIR9o4k+1eMU6ANHhX/eJk4biZLAUQ/3RjDWMvH4VEzrQNE2JbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=NAiZqhx2oUYerFceltwHy39/hwOjKejdOi1pvDPT46M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DUWDoCGE1A27WCo9Pw1AQm05EpCego8K74byUjnDADlQTt+1ARfjpubrIbd+r0BhaVUkGDLXcSq1QqKqltX2ihnvmkO9caxrZK5iJNelBZFx92hv00ePhnn4jsLXYuxCNyC2dzr05K5gL2zTZfokTtHJCz04wnNOg6O0/Xg4b+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=atldsAuE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="atldsAuE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAB94C2BD00; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=NAiZqhx2oUYerFceltwHy39/hwOjKejdOi1pvDPT46M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=atldsAuEvpPkmPoqtTEpB6yLhgXMGWekk9BzauzOG9Nrra7tdMUU2n0C6WZaVpIO1 YEME+i+5mj9ZQ3aYPWHZYGbbLUti2WgpR+GMuLG6pbUYuFuV2jgjbyW9yJKJvcdjbQ W5skiFMy8SPu4aW1kNeASMlenif2NNv+0HnIL3H1wPGwxjDqDpb5MPK4XEHVbIQ66E 7y4dgjFPkhnWqUu0SAaaQ496nSu14Jdcx9IIFzfpZRN73FOdhNxWJed4vlesLSZJqI lIm8bOUX8ifBa6HfdmAD/EpF+lH4OnT11pz+zPC9frmFnBIhYKeUQ36ZWdBhCdn/g9 1w22iK7Mp7kmw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQur-000000003Ar-00Av; Fri, 06 Mar 2026 09:52:13 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 17/18] wifi: rtl8xxxu: drop redundant device reference Date: Fri, 6 Mar 2026 09:51:43 +0100 Message-ID: <20260306085144.12064-18-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/realtek/rtl8xxxu/core.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c b/drivers/net/wir= eless/realtek/rtl8xxxu/core.c index 794187d28caa..f131ca09ae43 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c @@ -7698,7 +7698,7 @@ static int rtl8xxxu_probe(struct usb_interface *inter= face, int ret; int untested =3D 1; =20 - udev =3D usb_get_dev(interface_to_usbdev(interface)); + udev =3D interface_to_usbdev(interface); =20 switch (id->idVendor) { case USB_VENDOR_ID_REALTEK: @@ -7756,10 +7756,8 @@ static int rtl8xxxu_probe(struct usb_interface *inte= rface, } =20 hw =3D ieee80211_alloc_hw(sizeof(struct rtl8xxxu_priv), &rtl8xxxu_ops); - if (!hw) { - ret =3D -ENOMEM; - goto err_put_dev; - } + if (!hw) + return -ENOMEM; =20 priv =3D hw->priv; priv->hw =3D hw; @@ -7901,8 +7899,6 @@ static int rtl8xxxu_probe(struct usb_interface *inter= face, mutex_destroy(&priv->h2c_mutex); =20 ieee80211_free_hw(hw); -err_put_dev: - usb_put_dev(udev); =20 return ret; } @@ -7935,7 +7931,6 @@ static void rtl8xxxu_disconnect(struct usb_interface = *interface) "Device still attached, trying to reset\n"); usb_reset_device(priv->udev); } - usb_put_dev(priv->udev); ieee80211_free_hw(hw); } =20 --=20 2.52.0 From nobody Thu Apr 9 19:16:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6245E379ED7; Fri, 6 Mar 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; cv=none; b=VdaUTRmQ+lLUzVU7+TmTG0JX/1v601BbhviKrbVsnjKW3/4zsxLBFBFaBK8WQfZ3WvJj9aG40FTE9AAcg6VYT99e8iDhySfMep1wV0auK3PCNe+WaBD3ycUjpijWqHMxlSwXhL3PfrsQ0DQDghbsYig+2LfUU1N0r9LaoUO8Q50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787136; c=relaxed/simple; bh=j7gUhRofsdD3lZ7m1JTxHiv5hjhqUXzgfkH4RMIENgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MG2wFHpYPYxOBinL1AougBJZ1zD6+LRgFgGP6L1HqgBjRRKqtfaG56ED6z+ESk2fGsu8pvI8UyxvMBiH+hYIk6dOTZF3OftM7VUVrEDHEcs43yDOE7KKV8hG63S++5NIgFSQYKTNxkraAdOb5GMTwtgiShZM8aPNJcWfqMkz32k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TkUyQMXw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TkUyQMXw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8F15C2BCFC; Fri, 6 Mar 2026 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772787135; bh=j7gUhRofsdD3lZ7m1JTxHiv5hjhqUXzgfkH4RMIENgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TkUyQMXw1BJFV6KsNwejWWLgx4bEIHvkYpDlIGpJKn+vAlX30qx7Wy/val7jPRkam AqQIRQc886O+KJgZ02LM7ZAuRl8uemn9326u+rRLNGl/MVkFJ6kpv8SWDWHNp+XbfH Wj9PyKrY3E2l9nJhIPW6LQPhQpQLdeVqF3SDrXs+JAxP/XGpuKsU6+VsfDbYYt8zVZ 3ZedjE66C3w/x6svNiAKm/GENTgzjBXSSmt2j5uSeyEiUAKQrSLCMRMt0cepMl+Zja PrTMIT4YK4c4LD6rzM4nubEhADBNEWhu4VRUmDy7YP506Rosr/x/gCIKedqe9jcQuI XEMDzuuIG3gXQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vyQur-000000003At-03JJ; Fri, 06 Mar 2026 09:52:13 +0100 From: Johan Hovold To: linux-wireless@vger.kernel.org Cc: Jeff Johnson , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Sascha Hauer Subject: [PATCH v2 18/18] wifi: rtw88: fix device leak on probe failure Date: Fri, 6 Mar 2026 09:51:44 +0100 Message-ID: <20260306085144.12064-19-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260306085144.12064-1-johan@kernel.org> References: <20260306085144.12064-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. This driver takes a reference to the USB device during probe but does not to release it on all probe errors (e.g. when descriptor parsing fails). Drop the redundant device reference to fix the leak, reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of further memory leaks. Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support") Reported-by: Greg Kroah-Hartman Link: https://lore.kernel.org/netdev/2026022319-turbofan-darkened-206d@greg= kh/ Cc: stable@vger.kernel.org # 6.2 Cc: Sascha Hauer Signed-off-by: Johan Hovold --- drivers/net/wireless/realtek/rtw88/usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireles= s/realtek/rtw88/usb.c index 433b06c8d8a6..718940ebba31 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -1041,7 +1041,7 @@ static int rtw_usb_intf_init(struct rtw_dev *rtwdev, struct usb_interface *intf) { struct rtw_usb *rtwusb =3D rtw_get_usb_priv(rtwdev); - struct usb_device *udev =3D usb_get_dev(interface_to_usbdev(intf)); + struct usb_device *udev =3D interface_to_usbdev(intf); int ret; =20 rtwusb->udev =3D udev; @@ -1067,7 +1067,6 @@ static void rtw_usb_intf_deinit(struct rtw_dev *rtwde= v, { struct rtw_usb *rtwusb =3D rtw_get_usb_priv(rtwdev); =20 - usb_put_dev(rtwusb->udev); kfree(rtwusb->usb_data); usb_set_intfdata(intf, NULL); } --=20 2.52.0