From nobody Thu Apr 9 19:20:15 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC3E372B3A for ; Fri, 6 Mar 2026 07:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772783980; cv=none; b=sXBT73bk/uJQkV2RGfk/GzBn+S5wbmjGGirmWlfH0MpP37tpwqRahqgrW6A0tQWBe5U9sTf5SyVi4yjlOqQC3JcOJux/hOb3Us4hbkIssJ452NwtdO4dJw5eSd1f26i/XNaez9Bxuyhd144xu6AMMz/9Vvs3cy61k7WVM8zutVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772783980; c=relaxed/simple; bh=ry3sehuoKFfPIQDr095OlRAfL4Ko8+wyhALrbyTEGEQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cZeSCJeUTRPnx7y4RW8Z2HF77d4HJeyKb4eBEWdq8vGmYcMh8/XmjXuSvaN/LPC/UK0fa2fcz2yKRefUqZJkwc5ZgnIHkeSS3TrFdf3ao162N9kjFv7ZSbhpx1GY0F5BvZit0pyckxuDl1dL+7LR7/lLXav64F0Dw98aXH3G8Bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com; spf=pass smtp.mailfrom=shopee.com; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b=GhDvtjpm; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shopee.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b="GhDvtjpm" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3598b2318c2so3245703a91.3 for ; Thu, 05 Mar 2026 23:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1772783978; x=1773388778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VPUcTtKDdmEGo0dCBXR6iAhs14HBU2LRhPqQ4/x+vks=; b=GhDvtjpmk7QNMJNfhgH/GpTrPk+Vpq3RO2rbIrzgJZqBtvw43z3we1GMIvgtGGNjel eScxRvahcBbe7JPgGHoEb55jiAfUHrR8nuZP6Kd2eeJM4OEyBdgcnN3AVKcJQuZi7q+y CsChX2luwCexdDay7XraIFv60FGCp21VGM+6i7MARZlhOtBfjkch7pDusVDyiuhaOmF0 MZce8PBwyRkLudAK4es/i0xYrH7DYwkfWtA3XUbJ9noplOfvMQPvKDRbky9BNj2IQN9h MAAoUY3ZYGkA8q36mwghSwqrX1QYTN9Ts4AiGv2jYvaZE8xvjfewxs3Zu73as5E0pPpD W/Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772783978; x=1773388778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VPUcTtKDdmEGo0dCBXR6iAhs14HBU2LRhPqQ4/x+vks=; b=wsyB/Yn6CowOv3neQmSI/yaVM2lzkwLMUDYU1OdulvxeB7bjn1tSbqUMzezi6jNPD8 US6rfAlOSJZj7jJTwYZx99P6vjIlETBE2sw8V87vtMui7rhfm9d0K3yaYKJ6W2Ari/sR 9C095KV5oCZIBjKPUL7fUvgMiXEpCI4WnnFtYBzndeZzRoyF/z/+MaMK6FWP6+u+hJHk anBpxSN0XetF8ZxLmWnOz3S/qZMfxVJ4qwrk5QT7YJpIoCoJM6A8MJjusSyvBBcm9aUG NcBO/KsAC6QxHGJa6YrBv+rlfWX1tDpscqfI8ffFdLzUwlOIkLJyKnyNGfPp48gVcZhu tiXA== X-Forwarded-Encrypted: i=1; AJvYcCXIIm8E9Kiww7FK4eRuSG2tfrlQ2zbnC+PmHzc35Yiq3712yAB5VlB1fh6I1ZNAp+7HuNDAMntiTnqPdhI=@vger.kernel.org X-Gm-Message-State: AOJu0YzJusVuLr/xcFBo/1+bXKHEFMCRs2jeg+cGYlczEFxn35D8b0g/ /vQyUprNxzatOPPu/HZLun37rkBsOP/TVY5G+NX2/wAueH1fMGVa4r9o0pD5wJm21CHhe55GQQF o1cnQY90pEg== X-Gm-Gg: ATEYQzyV6PNxzYhaZQLUqG5aOpqrRdoEILGTAT0DbPT1UppnU2ZpoHegygU+rtOLBkc i7IS/CGKgv/0KoXinEE7sXCK7br4wBn6H92K3jlpOCJ8uxhVMoDYIeY968LTgdJb1fFRwxj8MjT 2WGvS0RflkxASyBGY6erffxlCnD169hADoXwH+zV9qOg8gwDGVW6S8JyXrw/rq/hZWGYEYRkAj2 NldtzJMAl6t4bgW9eAfjO4yWYei6uJtrzC97x7GT0G4qLDm+BVDWCko1v3nzbb6ZsRdKg8zuG9t NQuzgtzGMth4DGout4ZCbopWB4Ivu81NYnL03dtPJRIlWmGdvP57kHAuAzBrXUD5sI+k+PirzJ0 AaQauHUBM9H6wNs1KIQe610l5w9W7Gx11VcpYxWJyrV99TtsKDYG+XYfaSVAdGI16/g97mB6sls vs4ZpWdk5B+AZjKlJuNFQRccUsFaU8WgXJmAhPDw== X-Received: by 2002:a17:90b:3c90:b0:32e:1b1c:f8b8 with SMTP id 98e67ed59e1d1-359be375c6dmr1246016a91.26.1772783978384; Thu, 05 Mar 2026 23:59:38 -0800 (PST) Received: from localhost.localdomain ([147.136.157.2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359bbaa0d83sm804787a91.0.2026.03.05.23.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 23:59:38 -0800 (PST) From: Haifeng Xu To: akpm@linux-foundation.org, david@fromorbit.com, roman.gushchin@linux.dev Cc: zhengqi.arch@bytedance.com, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH 3/3] mm: shrinker: remove unnecessary check in shrink_slab_memcg() Date: Fri, 6 Mar 2026 15:57:56 +0800 Message-ID: <20260306075757.198887-4-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306075757.198887-1-haifeng.xu@shopee.com> References: <20260306075757.198887-1-haifeng.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If memcg_kmem_online() is false, only non-slab shrinkers are recorded in the map, so remove the check. Signed-off-by: Haifeng Xu --- mm/shrinker.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/shrinker.c b/mm/shrinker.c index 52ea0e6391af..c8b090e8a972 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -654,11 +654,6 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask,= int nid, } rcu_read_unlock(); =20 - /* Call non-slab shrinkers even though kmem is disabled */ - if (!memcg_kmem_online() && - !(shrinker->flags & SHRINKER_NONSLAB)) - continue; - ret =3D do_shrink_slab(&sc, shrinker, priority); if (ret =3D=3D SHRINK_EMPTY) { clear_bit(offset, unit->map); --=20 2.43.0