From nobody Thu Apr 9 19:20:15 2026 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195EE343D9E; Fri, 6 Mar 2026 07:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772783729; cv=none; b=EBSl9q1kuopIf4CStpodGxZVllHzC0BPGqVpSD2NIWMavUJc5FuWrECNvAdtL4VYQ3xBhw1Ol49mw+DNGJR2uFDi/LSQVgOo1C/khseHc9sqmLG47wxWo6Gh32StMSndI1ZWt7p/joiWpNf0oKFSmOdxIHjym26Nd+xog1xJB9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772783729; c=relaxed/simple; bh=GMW5B6JMgI6j9/cDHFQ4K87UJU3ZWkxxvDTWvZBAAGo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TmBuNek8MDc1p2q0qbuuQ/TFeCmncpqcRlvDj6MfKJ+E0I/LTIzOGWcoQVhRO9Zj5o85A2pl0ASV+TXwOIqtb4l0QSckwgJgzgkc0H6Q+PGgKrC/FFTuevlQK3Zgy4A9PgxJUXVR7IRKwlP+iDqBMjV5UMJ2KbzPQZFYTM7MBCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=WLT1etob; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="WLT1etob" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6267qkHU32977155, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1772783566; bh=km0x8u84UprX6FKm0eCiSzTfi+chOgnkYlBpdfCRF1w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=WLT1etobrskNSLFgL4x45S6Ky1Cm9gNTB+vnKSIkod9CeqM9cOCCzKdrAEgHipxWr BdlOc9I2pTzQM3iK0lKibDnU0KNUWBa67kd8n8GNC/jwsOoct1MGAgsptQMaXEc/Hx yaiojwYtdIIjgcnts0x86B+HztlPNQqRqajMp9zTJbKm/T00OprrKM75piso7CdMfu DCRyTSs4uj1c2CxvnidR7Or8gDCsoWaOO8ZNHrBaNS3RbNceurLNXiXayExji2cMyj CoAzSzm5WOA/EujpgFVQOfFu08J0iuIkfUmJY2kzRLtSTLC+InM9mJ/1wVQwcoAclf Z5C4Pc9tK9MIA== Received: from mail.realtek.com (rtkexhmbs02.realtek.com.tw[172.21.6.41]) by rtits2.realtek.com.tw (8.15.2/3.21/5.94) with ESMTPS id 6267qkHU32977155 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Mar 2026 15:52:46 +0800 Received: from RTKEXHMBS06.realtek.com.tw (10.21.1.56) by RTKEXHMBS02.realtek.com.tw (172.21.6.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 6 Mar 2026 15:52:45 +0800 Received: from cn1dhc-k02 (172.21.252.101) by RTKEXHMBS06.realtek.com.tw (10.21.1.56) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Fri, 6 Mar 2026 15:52:45 +0800 From: Yu-Chun Lin To: , , , , , CC: , , , , , , , , , Subject: [PATCH v2 04/14] pinctrl: realtek: Simplify error handling with dev_err_probe() Date: Fri, 6 Mar 2026 15:52:34 +0800 Message-ID: <20260306075244.1170399-5-eleanor.lin@realtek.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260306075244.1170399-1-eleanor.lin@realtek.com> References: <20260306075244.1170399-1-eleanor.lin@realtek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the error handling code in probe() to use dev_err_probe() to enhance semantic meaning. Reviewed-by: Bartosz Golaszewski Signed-off-by: Yu-Chun Lin --- Changes in v2: - Add Bartosz's Reviewed-by tag. drivers/pinctrl/realtek/pinctrl-rtd.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realte= k/pinctrl-rtd.c index 56fd3093c206..382bdae54bf3 100644 --- a/drivers/pinctrl/realtek/pinctrl-rtd.c +++ b/drivers/pinctrl/realtek/pinctrl-rtd.c @@ -566,15 +566,14 @@ int rtd_pinctrl_probe(struct platform_device *pdev, c= onst struct rtd_pinctrl_des data->regmap_pinctrl =3D devm_regmap_init_mmio(data->dev, data->base, &rtd_pinctrl_regmap_config); =20 - if (IS_ERR(data->regmap_pinctrl)) { - dev_err(data->dev, "failed to init regmap: %ld\n", - PTR_ERR(data->regmap_pinctrl)); - return PTR_ERR(data->regmap_pinctrl); - } + if (IS_ERR(data->regmap_pinctrl)) + return dev_err_probe(data->dev, PTR_ERR(data->regmap_pinctrl), + "Failed to init regmap\n"); =20 data->pcdev =3D devm_pinctrl_register(&pdev->dev, &data->desc, data); if (IS_ERR(data->pcdev)) - return PTR_ERR(data->pcdev); + return dev_err_probe(data->dev, PTR_ERR(data->pcdev), + "Failed to register pinctrl\n"); =20 platform_set_drvdata(pdev, data); =20 --=20 2.34.1