From nobody Thu Apr 9 18:53:53 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0D62366DA6 for ; Fri, 6 Mar 2026 03:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772768467; cv=none; b=Jrb0U0TQqJDIX9naTspaJSz63ehfa2UrOaUU/xqP6POm6ObnnkR/8v0YZu8Xzesj0uCua9EmDxf6++12EZaHXA6NiU0RiR6y/4Co691p2UWVa9tqaLF3lExTHNh3hgCIxK1n0XfCSKDEZhSeS9He4nDXK6v+eAljcSKKb8925ck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772768467; c=relaxed/simple; bh=o7fIf5OOycLC9qngUuRxTqt9gkAdOEzhp3E9nahQNQ0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=TxB+o0XrHbHGc91jAWypZ7phWb5sC1Bc/KlilQUMF/hPxZI4r6RLu/9AU6lC6IiQqq3WFkACNTI2v7i95jG7UXjktHW3cW2rwS4grualNBZ6nkZeYi215v4//X6/SdnK6s9OcuYBblY9kklN7iRbImrZhUBnl12MruahYlnCL7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kUNtFG5H; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kUNtFG5H" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b9358bc9c50so972718366b.1 for ; Thu, 05 Mar 2026 19:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772768464; x=1773373264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=8wglCAHOQz9caPuUxvse8NP45XIi3Vs8/MIsuXO4kGI=; b=kUNtFG5HNfJYHFuiXhSgQeX3auqxiZxYkJ57NjsR5KQnvsmnNvM0nPw09HUSDjQ5Tn Q2DC8ipd0gTYchIWq+N50HAC3ivoDCkyuSLxBoGPq23fT36j7ztsQOiw8hwmtn3hWusD Dqk6/zAqNkte719lcKCO9s60Gr9ODSuxg/XZW39xJmITWbBJLfjkevnV/bBEdxuxQPn9 4t95lM6RwAZT4SB9inE6ZCNFjkkOze6agjzuxqnY4YDiqPVEpRwAaG5Dv9iovLEhwl+q WqyMo1WjUE8D8/7NAL2mjaXWohK2Nb7u5jcZK9HMZG6y6VhElzOVLDglpysuc8ZUdxe+ H0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772768464; x=1773373264; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8wglCAHOQz9caPuUxvse8NP45XIi3Vs8/MIsuXO4kGI=; b=b0LSgyeZOdiII8V7nBMXWEVnFM3GzztTFWKqBrwHwUSLl7UZpgE4UCtt8w11jLL3H3 HiZvTPI3RskwS1yOe6/M3U9m0zb0RYIsb9p+iIEaichPaAngi0oMpKpjyJzFgCb8glcF RxFE85PFAuI16T0Dz1wBSrgtNnwUtxP66I2iRtiTw8So40/xw1DeP+YnHS41skNrHFkJ hFGMs06tx415W0oQTyFd+z1Yiye3TBTtsPXYpQJLzqsyNX2vrxCjUEyggblZghfRrYg3 d63Ej4BO4+UWraysbo1uD2xgm0fTqzEILgnGuYHR3Jy+5LXdCoH0MTbNdHwiKD8jvTzA 0VbA== X-Forwarded-Encrypted: i=1; AJvYcCUplGLvS9yTCbICDCm7YkbhFd+w0biRsxx5KQ7Lh9o5GFUY37zyT/bmba/DWOUHHrw71fFFq+lV/NsxvCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx38zKMW7w9hkv/eliydoXWArVyEnAlsM1bRDoaqdn5hSTIyoiI cx7uUnkOMdPuGMZvS3yTRRFnzzd3RjZAaJIH9nISPTtxflLt8D/eBN0/ X-Gm-Gg: ATEYQzyXia8Vd5m0Y7xyDNFdErbVkCKUgPp8xajGuhBOPAkY2fN90RRx2BbQWic31yu vXx099YaapY0wes/ITmA08lfNc+9R4SgyxnzzhImHbPZ4aoNOiIGd82IszPGEjAHTQ56Ih7IFXz sIt006VT0o+8K0BX48Xq5tZj3ivzXM5B4+WbL/mc59LiyNUg+IDqzhTml1WR2VL7DMCo+4z9iS1 lAIT8ygXaFQYCeuOgpviC+r/kQ7Ow/J13LO9sPJrY2IK+M+5UXxeW2n1YmQ8x77t7KgS0VYr/sS dK9oqA5f6Sg18LT7N7UwNt+rkkaigz0oCQ1lpGVs09vmKe1i+5/b2cL3z+uZPyz8tGDg4M1QhFe 4isjJGfOg7jxuKc3yO4j1ex/gQf7styydSDvRBngp4xBuuM934YaektWWI6TMCE/FRli9c6Eh6U bS4H2aHAWaQ/xPXw== X-Received: by 2002:a17:907:26cc:b0:b88:5ef6:17f4 with SMTP id a640c23a62f3a-b942df77fe2mr28205966b.17.1772768463919; Thu, 05 Mar 2026 19:41:03 -0800 (PST) Received: from gmail.com ([2a09:bac5:4e27:2705::3e3:31]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942f13a3afsm14979066b.40.2026.03.05.19.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 19:41:03 -0800 (PST) From: Qingfang Deng To: Jiri Kosina , David Sterba , Greg Kroah-Hartman , Jiri Slaby , Stephen Blackheath , Ben Martel , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH] tty: ipwireless: fix memory leak in do_go_offline() Date: Fri, 6 Mar 2026 11:40:58 +0800 Message-ID: <20260306034058.386747-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ppp_channel is allocated and registered in do_go_online(). But when the channel is unregistered in do_go_offline(), the driver forgets to release its memory. This leads to a memory leak each time the network goes online and then offline. Fix this by adding a kfree call after unregistering the channel. Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem") Signed-off-by: Qingfang Deng --- drivers/tty/ipwireless/network.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/ipwireless/network.c b/drivers/tty/ipwireless/netw= ork.c index ad2c5157a018..ec0353c1005a 100644 --- a/drivers/tty/ipwireless/network.c +++ b/drivers/tty/ipwireless/network.c @@ -303,6 +303,7 @@ static void do_go_offline(struct work_struct *work_go_o= ffline) spin_unlock_irqrestore(&network->lock, flags); mutex_unlock(&network->close_lock); ppp_unregister_channel(channel); + kfree(channel); } else { spin_unlock_irqrestore(&network->lock, flags); mutex_unlock(&network->close_lock); --=20 2.43.0