From nobody Thu Apr 9 18:54:24 2026 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 850814502F for ; Fri, 6 Mar 2026 03:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772768422; cv=none; b=BWusfdHYkh519pq4WV93CZaIGoualttc0z9MMSlOYpCGedmOCgS2ZrRLcMl/C0gmusG19yPBRhKzLf5nZTZ0E1gDdpRg8PNtOugPtX8mR0wPXYpc2FlvsACxJD4iK8bDZWHzgKQgxihj3OH34isVI7wk1vdyZk1pMRHltnCTLdc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772768422; c=relaxed/simple; bh=ZKGQMmynGH72RNGVGSJeWjju/XTm1pbnlX08xLpX844=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=POVB70R4K2KkzGIwTTmLKVKweN+6Wz8HC1xlG+sCAyNC14c/zO9WngyWBbaSV//qh3sXhTuNj76OfkeDmCbHJ4Ko/yu0DL2V0vaWSlGweeyy3VcWwQCoFVtRh1SWQGn5ZyeCF7vMkL9jgL669+9/82rqtoTAS8maz4JEJdhGx38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHxeyGom; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHxeyGom" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-89a1347051aso58141936d6.2 for ; Thu, 05 Mar 2026 19:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772768420; x=1773373220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=myrPwAZMujLUe8MJ6Ba22b/AUfkQBCrFe4aRwPYkeIA=; b=bHxeyGomsLiPvjHUQ6QJ5EM1oIHaa6BIC4AJtQoQaXaBZ9IPHK0ZHoK2sYyxqv/Mpq iMeSf1gUN0TQQ6cbqwPb1qX2V3W74vuBDfXuy6i8RBEIR1SwYhU3I1RZREIW/8lraMzO pYwNfNPzvwFZSj/pOQG13U7lsmxYy/zeTsLBnPM9RQd3cWqDKe5YsNYkVubFqZ8Z/a6c kuLUYQyqVi/UgDhjHtqdJ/4CvPdiCaUr/aECTz4WrbKFHFAXA71ihqmxEPHPGoHCp/6/ X+sO0VQFVsl2j7j9p/BeRVja2KourQVop7op3Vm9rzFa30CSaZjbU3UititmedSpcvjf mGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772768420; x=1773373220; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=myrPwAZMujLUe8MJ6Ba22b/AUfkQBCrFe4aRwPYkeIA=; b=LV9SUGLPdAQAH3tOtskxDvO0wQXh0XqIjfW6BUby5VyUYVp/nUHck3gB9ubrI/KfGA qqZ/mtOcPg3OcVnBcvtZG0KdB8rhw10vn6j9Uf8oxLajvIs4zUKV/iSSShDvgFAxyyAJ o5aJ9Ah4v8qlwuh+JJSey7ueMWBCj5OnVefk5LH62xrV6GFf2SSUOP8pBLlXSPT0ynLU c4OkrKQTEF/w8tG7ONRWXPfbKGhEpwtwRc+603MCzmOVRQ2v+ecGrxQ8nK4EKLQ4LtIH X7UT78WbD9a0ZYD7X02icBQSEl6jdH/05Zau6ietjmvU2U1Lne2fzTCxPwhRZD9bz+JS +R2A== X-Forwarded-Encrypted: i=1; AJvYcCVj7GXsq3D/BL6ode42mGdsyVF9Yv+/5az8Oo1XjK9aXG6ppfYhTHtn44a7o8urevlZmwX+L72QCJn05SY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz68uD6U2D1O/DKF60igZ5Wyd5sOHScFVRHM7JR7vZvLq6iLzz/ DPZNrrQUAnaU9H5a3pzvawIprSJQOqnVztMgR3TvQE59PaEqNCrg/EeS X-Gm-Gg: ATEYQzzfH2DMTOGVOivRL4Tle18GevQa40Rq8Jw08JHxSw/6imsavgMw6bCnKmXldJL fGZxLndCOVyXFglGwW7v3Y+uJvyg5E6Yw2NY4NlpiNkl0hIHnBADWyQ/2/5dTwF6sDDX7sWqp0h dL/twJ43GqsNiuQksT7lTOU3LjR05YtT6dFY5HMz9RRToggV6rlFnwwkpC6BCjgroxT1s9S5Jo+ lT/cIGjBSAKOuDz/KIc808HFyZIyrjxCxtT4JJVGiAuE9pjntg0dAy6l4TNhwhKf/1Ghw4OKA+t 9FmDNxvMQWsEUXnt4W1e3oEOzigQvu/YlTJ6QYXj7wN2S57JSRar+SDqbg3ytG1X2fT1VqTmYYT jBH1Q6yS7SVCIJFpW3nwcxbn/Q/Ta2TP4UvnBa2ckPnMxQx9V89fWNwWah1fd3ErWOXA04PF3a2 HmqprBYOHeiI29DBaOdS8ZwMAJjfI2lFMSz4QvPR0czHXT6WN6gZCENw== X-Received: by 2002:ad4:5769:0:b0:895:c06:8cbf with SMTP id 6a1803df08f44-89a30c2b8b3mr7786186d6.62.1772768420459; Thu, 05 Mar 2026 19:40:20 -0800 (PST) Received: from I4-L-HQH5357-01.ad.psu.edu ([130.203.159.160]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a316f8228sm2158306d6.38.2026.03.05.19.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 19:40:20 -0800 (PST) From: Shuangpeng Bai To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch, gregkh@linuxfoundation.org, horms@kernel.org, jirislaby@kernel.org, shaojijie@huawei.com, jiayuan.chen@shopee.com, alan@linux.intel.com, Shuangpeng Bai Subject: [PATCH net v5] serial: caif: hold tty->link reference in ldisc_open and ser_release Date: Thu, 5 Mar 2026 22:40:06 -0500 Message-Id: <20260306034006.3395740-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A reproducer triggers a KASAN slab-use-after-free in pty_write_room() when caif_serial's TX path calls tty_write_room(). The faulting access is on tty->link->port. Hold an extra kref on tty->link for the lifetime of the caif_serial line discipline: get it in ldisc_open() and drop it in ser_release(), and also drop it on the ldisc_open() error path. With this change applied, the reproducer no longer triggers the UAF in my testing. Link: https://gist.github.com/shuangpengbai/c898debad6bdf170a84be7e6b3d8707f Link: https://lore.kernel.org/netdev/20260301220525.1546355-1-shuangpeng.ke= rnel@gmail.com Fixes: e31d5a05948e ("caif: tty's are kref objects so take a reference") Signed-off-by: Shuangpeng Bai Reviewed-by: Jiayuan Chen --- Changes since v4: - Fixes: reference e31d5a05948e ("caif: tty's are kref objects so take a = reference") drivers/net/caif/caif_serial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c index b90890030751..1873d8287bb9 100644 --- a/drivers/net/caif/caif_serial.c +++ b/drivers/net/caif/caif_serial.c @@ -297,6 +297,7 @@ static void ser_release(struct work_struct *work) dev_close(ser->dev); unregister_netdevice(ser->dev); debugfs_deinit(ser); + tty_kref_put(tty->link); tty_kref_put(tty); } rtnl_unlock(); @@ -331,6 +332,7 @@ static int ldisc_open(struct tty_struct *tty) =20 ser =3D netdev_priv(dev); ser->tty =3D tty_kref_get(tty); + tty_kref_get(tty->link); ser->dev =3D dev; debugfs_init(ser, tty); tty->receive_room =3D 4096; @@ -339,6 +341,7 @@ static int ldisc_open(struct tty_struct *tty) rtnl_lock(); result =3D register_netdevice(dev); if (result) { + tty_kref_put(tty->link); tty_kref_put(tty); rtnl_unlock(); free_netdev(dev); --=20 2.34.1