From nobody Thu Apr 9 17:15:55 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4545834A794 for ; Fri, 6 Mar 2026 10:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794020; cv=none; b=kWh79mvH0KMu4oIMKQI8QCg0tJaYNsc9oAXKBFN6R6/bexTxAzHJFfYy53L2fQa7slHutE1Tz/6euJPgezPpnJFiQvQLSvgQdM1BMM9cyKrq0DCcHU/186jOrZSK+pxhPWW7ywi9MAjen5tM6TC83ylQ5z/jzbW/8zbz9gpwG3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794020; c=relaxed/simple; bh=+g9uXWjjG483076ir/8hnQdd1FarEW6sYPGPB72gwsI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=dTzrMcYfLk8BYOXs+HI4alVGv3zRTg34BwrumH4f2133gkatjcX+i/urFJhU0vKPwYMImNh5ORcT9p1oh/NEXW36PVEFWiSj4G+Rm4uJlgu4p86NyxC9FON+T0DDXK2abN2ZKZf2NL/TWQibzfWE8TNXNwDwqRAatT9AB1ym0gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=J9gnNIrT; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="J9gnNIrT" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=kOjDJLuttEwzTlLOau0koOU3TCd3D/54r3VmisJPPh4=; b=J9gnNIrTlNq6aEtb0VS9d4fZhx BQyfdE0tXzF+pn5Dk2UB6XWaEL/93f0Z6ydD9Yc/XHg2hd/LLueDOxht0LMAyKcF4Tn7a584kHbRj /qJdFmWKfVxUtui7uqKfHLr2EKKNqFBiASX/OjOGdAvKEppsGvzuornD0L+F3jP5LyU6Pc8DC2DOm iculj7A4OFk27f+nWA7Q8Bt28KXPklV9gWFBpW2UmU7RjfMszB35P2U5qPx68Oi+pPx0r14rxuoeZ lGNBxHz6PyiTDc4pGp2ZrLJd3BcFqOlSQTFyBUvNZEaLooP2ZT5nXy2BylKkW6qvf4z6du8cB1YoY zh2COhiQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vyShr-00HRmU-7J; Fri, 06 Mar 2026 10:46:55 +0000 From: Breno Leitao Date: Fri, 06 Mar 2026 02:46:42 -0800 Subject: [PATCH] workqueue: Rename show_cpu_pool{s,}_hog{s,}() to reflect broadened scope Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-wq_rename-v1-1-c6df69dc42a5@debian.org> X-B4-Tracking: v=1; b=H4sIAJKwqmkC/yXMTQqDMBAG0KsM39rAqDG0uUoponFsp2CsSf9Av HuxXb7NW5ElqWR4WpHkpVnnCE9lQQjXLl7E6ABPqLhyXLMz76VNErtJjLNHywce+8YGFIR7klE /v+t0/js/+5uExx5g274O0XB8bQAAAA== X-Change-ID: 20260306-wq_rename-6494080fb54c To: Tejun Heo , Lai Jiangshan Cc: Song Liu , linux-kernel@vger.kernel.org, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=2335; i=leitao@debian.org; h=from:subject:message-id; bh=+g9uXWjjG483076ir/8hnQdd1FarEW6sYPGPB72gwsI=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpqrCb/8zEzekRs3SyzCK0GdcO0D9QsfgZ1PnLz wHFbMKjmdyJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaaqwmwAKCRA1o5Of/Hh3 bTkSD/9hzFGHqmS/nZ+tH3iBsm59u58izkpJ0zw7Rmoq3OgJ3kFJKzlcq6ctZNnetNkCWJ23XIX fXbAbWz7zr5Ajnen01t9Lv18IuCC37HGn8R4cpPDfvtsombZAbHvf7t0xeHuWxS171ukgJV/Q+u M0x99B5BhhN+S22mVjScevTWbDnEZCKKjB7xu3p6TgA2gULnXmLF+fPGvesGHRoyGNvq+gIYxcn KC5d9fCL32SYg4zdfS/g8qNWGdPwqYO1Kdkf78uTDlcK5BTl5e9Rtxw7Q/cnGqxUyf3ALLeYqOe YgABv98h7U5UW31t5LddEP0jgBiV3DSrbuzWn7RZSdJHXu2A5OAXkoGPftRbIzfY1b5y1eumMri XUYvyouTHTuW5gZhK/G1Xa4FgWELGxUN5+Eh81KaGn2qld8o0oojK0ix9wxCfeStDtPscPsxc+3 E1eoV20pwD679yJcSYC3DTnJd7m8TvoX62YVqgAaEZRmKm8Secx/Z0UhS5sv9RiC3vwJLNKPRRc RNmgXj8noxDgn16MmRLAdjtFIOOlATlD82mPhNQBILd5YTmHppUtKdnD7Xhk1FHPVrWwNXrJTl5 wyLn6vCPzXN0EI37fiA98N7gfuuAhA1fTIsMjmfkfeWSuyvqaX9/V5T/4V6SgxmrerwLlJTLk2h 5QfM0/jIIRgSyew== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao show_cpu_pool_hog() and show_cpu_pools_hogs() no longer only dump CPU hogs =E2=80=94 since commit 8823eaef45da ("workqueue: Show all busy workers= in stall diagnostics"), they dump every in-flight worker in the pool's busy_hash. Rename them to show_cpu_pool_busy_workers() and show_cpu_pools_busy_workers() to accurately describe what they do. Also fix the pr_info() message to say "stalled worker pools" instead of "stalled CPU-bound worker pools", since sleeping/blocked workers are now included. No functional change. Suggested-by: Tejun Heo Signed-off-by: Breno Leitao --- kernel/workqueue.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 09b9ad78d566c..b77119d71641a 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -7587,7 +7587,7 @@ MODULE_PARM_DESC(panic_on_stall_time, "Panic if stall= exceeds this many seconds * wait_event_idle() with PF_WQ_WORKER cleared) can stall the pool just as * effectively as a CPU-bound one, so dump every in-flight worker. */ -static void show_cpu_pool_hog(struct worker_pool *pool) +static void show_cpu_pool_busy_workers(struct worker_pool *pool) { struct worker *worker; unsigned long irq_flags; @@ -7612,18 +7612,18 @@ static void show_cpu_pool_hog(struct worker_pool *p= ool) raw_spin_unlock_irqrestore(&pool->lock, irq_flags); } =20 -static void show_cpu_pools_hogs(void) +static void show_cpu_pools_busy_workers(void) { struct worker_pool *pool; int pi; =20 - pr_info("Showing backtraces of busy workers in stalled CPU-bound worker p= ools:\n"); + pr_info("Showing backtraces of busy workers in stalled worker pools:\n"); =20 rcu_read_lock(); =20 for_each_pool(pool, pi) { if (pool->cpu_stall) - show_cpu_pool_hog(pool); + show_cpu_pool_busy_workers(pool); =20 } =20 @@ -7720,7 +7720,7 @@ static void wq_watchdog_timer_fn(struct timer_list *u= nused) show_all_workqueues(); =20 if (cpu_pool_stall) - show_cpu_pools_hogs(); + show_cpu_pools_busy_workers(); =20 if (lockup_detected) panic_on_wq_watchdog(max_stall_time); --- base-commit: 9e83d5104a70d8545bad61a77e166190d9447e1d change-id: 20260306-wq_rename-6494080fb54c Best regards, -- =20 Breno Leitao