From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B1E41B344 for ; Fri, 6 Mar 2026 16:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815651; cv=none; b=En1ZK/Uwryc8jvr9vIEmsYJYyvrjIgNHdTEwhuTOrixrgRAhRSr1PTW7DXnOIX+iLCuNzcnk86xw8VFggiTgSaaHeJiLMIRmh/0s7K5qLgaxU0siESmLBm3PNEUhQZO1ZOJjVYKuLQ8VVfPUkweIUHkmQsv2iQzKin2JaJ7/r1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815651; c=relaxed/simple; bh=dSBWM2x+kwZjmcQFVewwgxBgzRu48ixGoJYbIjzhJjM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JMMQuy1l9BPz8q8/o5Az+WuOqZ34XCNlSosBTc++97lt/Vxd57p9N1fhzsvmzBgCanX+d0MMsvokDsuGeO+kodJYuIjnHwlnTPDXJ4fwmpDK5A4FRbDdwm88b2KpXDxlIlhQUta/n7Ocj++9fQ1kOQI3nXixl8IaoRZ3hR64Ke0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jQHU/CJH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DOFqjMGL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jQHU/CJH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DOFqjMGL" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr6f8079998 for ; Fri, 6 Mar 2026 16:47:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ylSabl4CClj6t/w9cxf3ZToG54oIITlqCJttWo/AVWg=; b=jQHU/CJHY5MIn6ZY aCSa4lqOAqgPrFoHJiZLiatiMeY3RG7EoVpygYZKTT+feeX0KHXAChnzoNtelO48 zbrLl1vLkjDaJLWiYYdI+RwCOF4DSXOTT5+IHLWeZt9vNxXGMTBu+F4Ou3Lz95rs Rt+7KUNev0Rtgr/aFoUFV0RdAbn83m4TfVPZ4NZ/6Y3hZnJzqW3qvZoSoXzzj51j geHtdb16JctMLyLShtDDoV2zpu3iQ4x+V4QKUt4uvBmIwa+PDxGtQdkD8b8C+I1I ZNLXNe4PS2eiEV/qGU5Iw4SYHnhspL/H+uSIVitmv0mgac5uYpEbnYmPQcsK4ZOZ +1IIpg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp43k6e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:23 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c71500f274so1017713385a.1 for ; Fri, 06 Mar 2026 08:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815643; x=1773420443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ylSabl4CClj6t/w9cxf3ZToG54oIITlqCJttWo/AVWg=; b=DOFqjMGL5V6eYkXjj8rNThXx8IobGA9gYsKJb6iQmQInvXCXAU65Nkcu44mj1fpRhJ LsakhUJokf6Hax4kaLz8ZME7C6V69fPuXCMMIyRLZpkG7kw8WmChdRD5oegt85s0QGzT c3tXwF6uc8nJlW6Wd6w5WrS8TaxKqJOHqzpESQ8MmF/z/fK3r+Ng2M6DuZM6vS7dtV65 5rQ1PxloBcxsPtjjKsWNDhfNMzEuTR+pcWI+ObufLeUqWujV9DBf3GW8WjqwZT26HDpL VU+THHaUMxYaALD7mfwk/x/4otRRpblVSENaXOD8jROmj2/AGuG7F1SkaKaTZeS4fBHt eLiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815643; x=1773420443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ylSabl4CClj6t/w9cxf3ZToG54oIITlqCJttWo/AVWg=; b=HLgmWDRTu2YBAArFmNilfhRyDlLvopCocNiIAhvNjgJFa1pFkHJq6Pw4UoHFQgFM2v tY1cB2k77M19NC6C0oPi/6Z3hdlTvi/X0heMG11ZzjXPpl2hiJUN+mR5GqN2ojTlW+VY UeEirJ+6Fa1nDwo2VXDe6c8e5Dh8KUfeqX4LJWtFEBbYWbo9gC8A7z3ud1IUhVutWNaN 5XgNwFHHBJmPnoCWwj0LQhX3LA4Wu39lHs3b2nFXD3xBBM2fY6RAB/s4pITP20VJ66kw lqoxWUb2VQUitkfSacWt/upFw2JR2Azq3BygavX691ZrCBFonOsDF3t+aWJUS5xW5uds s8NA== X-Forwarded-Encrypted: i=1; AJvYcCVJS51WneorCGQ77Dz1brVAJGw6fZkJN5Szuw0zDFTiDPuD+fFexLMzWDqAM9EjGhq8YUx5REZkSiLaPmQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwII0K79zXhfitd8wL8Q+QR5HbnrXivyF1xHPdTG3q3kHKDNa2w r1gNFtF9MVoDTI4EOFpp9HuImRevIU9CyHzYot/yNsoeTIdoAHTqfr99Py741TzGygqNUMUqhTU bE5J9DBzrN6gmTIkzKiDJxS/hSuQSYcPKE0kmtlzXvQhdWpFgniWK5L5jaslYcWptuswiwwoFch U= X-Gm-Gg: ATEYQzz+5sdaY+/dh3UAhMBAFp6nyk6s2LHArWlcTrFHcfRCr4JKwIa5LK+nUl1AfmU +XrLtjC243GT8ufO535SoHNvvCNAoKOyak6PVlWwPWajNUatS8DW1/6N6jrcOFxlU3D3B5QSLec BSeQmS6mGkFG/eCCGgqBOEf0YnkAdWvRWsEEiQSagiRbj5aEUEx2tx349GUQie5yqgbFnP0IpZx v4VgpUa0XLCs4grF/gk3CpDkLOyQ68oTWH2dKq3dNQL+iFOlK88lcKmjANy0CRNor54ZoTE41kp ytsFDFpZx9/sVfX7vpvXTvLdbl00PG3uDrDxbjCf4wmuudVLHuCxAFs66PKvlwCxQTe9MLsp6IS CSeV/WiLw/Zk74fTZnZD3gCm3i8WKhpuu0j7V4MxXE2h1yyGjkuXIcq5AYz78mhEOC/gq9YMgtW 24BAT+dYB8VcZ9uCOqUQ4BjViC+2kgbWT1wgo= X-Received: by 2002:a05:620a:46a6:b0:8cb:4ef2:f3b4 with SMTP id af79cd13be357-8cd6d48d6bdmr344382785a.73.1772815642592; Fri, 06 Mar 2026 08:47:22 -0800 (PST) X-Received: by 2002:a05:620a:46a6:b0:8cb:4ef2:f3b4 with SMTP id af79cd13be357-8cd6d48d6bdmr344378085a.73.1772815642060; Fri, 06 Mar 2026 08:47:22 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:21 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:11 +0200 Subject: [PATCH 05/24] drm/msm/adreno: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-5-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2867; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=dSBWM2x+kwZjmcQFVewwgxBgzRu48ixGoJYbIjzhJjM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUNAqeJoTbTsD3xfc25tA2JTYbYyry1SyyAB JBOvxzy/+KJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1Up4CACjWn/4ferCxCSGdGqQBb4i8bAXXaYWwL4r+o7o1tnvLZy9TM5DgjZtTw6j9wSifHZVjJQ KpB0lVk3zwj1ON9SsrFJ6HvaP5dKhfhCBShpUBLB//PBv/ho+l3htScn1PPfLY1jjb2nCEjAzE9 gwhanlPxIrIzvd2h0MxJhZ5dsQK7w0mGxrAY0TrvsiNzOVM76gd2ILAGl2rK2ZwnuYfVKiv4W8g BDhBVO5jiqVAkW8UI7PkdFFQUbCSKIo/NQ7HksoTxx1y61/Gba7feWW/PRgFNJqOSxT5ZqnTMwx VDurHEwjSuCaWkIwV1eur+Cdc/iv1KbnCIk9j1Y6gAT3JbmA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: ek8h-cuYS9rqHBjmPN8tINLTESgd57OO X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69ab051b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=QjZuzksZpR1x1fsoQ4cA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX0uh0wWGtjBoG P0aLJ8up+jiKMPg0ytFCdMhmIRqYppIwD9LD8+Fs303p2xS9CRZaCZLgMgFcjDRDE6LUhbyMn2K txVANEnQsqPgNbi1YJpzegsXznvjH/r4sso0zjqzqDYyb3i8NEfsauPLf7tIMwMqm7EYZrFXiWD dHN2FBgm8gnppCI4PBVDpnaeHAQA5fz6054B32h4qhYWJXSWAjM7lD+Vugzmi3+OEnhH2+y2hk7 k7bnLF3Zkq8jquvDWXdXPsSOCFw4GS6Lc2PlR57I9H6kSN+HpFEJqDLfXbzQWEzGAURgJRYl9E8 ZlC/B3yEyPnSzaZXTJL45J34rl5B08lOGdEz0aEBWCNjHy0gpZUnWv1Pa6WxUv6hWWTb1zAulT8 MaHpVBQVGpZSR9r2XRG6hUg/smT4aTvLaI0rpWABfef+33lAggWUPWsqZce2pHyy0SvaN16pvrt ZeBIuKnncCHP/jycyrw== X-Proofpoint-GUID: ek8h-cuYS9rqHBjmPN8tINLTESgd57OO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 8 +++----- drivers/gpu/drm/msm/msm_mdss.c | 16 +--------------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index b1887e0cf698..6dc1d81fcaeb 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -272,35 +272,33 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D false, amsbc =3D false; bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); u32 ubwc_version =3D cfg->ubwc_enc_version; - u32 hbb, hbb_hi, hbb_lo, mode =3D 1; + u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; - mode =3D 5; break; case UBWC_5_0: amsbc =3D true; rgb565_predicator =3D true; - mode =3D 4; break; case UBWC_4_0: amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; - mode =3D 2; break; case UBWC_3_0: amsbc =3D true; - mode =3D 1; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); break; } =20 + mode =3D qcom_ubwc_version_tag(cfg); + /* * We subtract 13 from the highest bank bit (13 is the minimum value * allowed by hw) and write the lowest two bits of the remaining value diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 9f81f43283b9..798a23fbc906 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -204,7 +204,7 @@ static void msm_mdss_setup_ubwc_v6(struct msm_mdss *msm= _mdss) const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -222,20 +222,6 @@ static void msm_mdss_setup_ubwc_v6(struct msm_mdss *ms= m_mdss) else prediction_mode =3D 1; =20 - if (data->ubwc_enc_version >=3D UBWC_6_0) - ver =3D 5; - else if (data->ubwc_enc_version >=3D UBWC_5_0) - ver =3D 4; - else if (data->ubwc_enc_version >=3D UBWC_4_3) - ver =3D 3; - else if (data->ubwc_enc_version >=3D UBWC_4_0) - ver =3D 2; - else if (data->ubwc_enc_version >=3D UBWC_3_0) - ver =3D 1; - else /* UBWC 1.0 and 2.0 */ - ver =3D 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 --=20 2.47.3