From nobody Thu Apr 9 18:03:03 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A22D430BA1 for ; Fri, 6 Mar 2026 16:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815673; cv=none; b=HpEV3wx8iFD2EmYs6nyYhpDHBA9wZFZfMmxgH3R5zl1reyLP5sCqu8p8KQwR2lfD8c+2mR8g+MzTKFrZ4GRD6S43+CLPzKuTPGIOjJ1RqguEBWohGuARl22nzbhFGI3nAHSoQpxoTcM2I7yfpGjc7VElyQp+UXn94/ad7NtUL/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815673; c=relaxed/simple; bh=mDvAIGusOne0ET0zqDfmYH/uZpA3s+5yjk3GrtdImQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tyb/bV80QpynqTN0hQxD5+ATlX87kzkL+ziTFjkKlmbHKttgXxVpyf9kfKs422SefW19VTYNgQIqqwRATiKvBpqP8ITflDGxTk4KCEAX5zf1C5l9Sr+ZNMB04greSK392SlFuWhRZeDSGKGsueL/uMoxxAaP3G2mX194zdH0kfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d+iW9e8B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Li33hvkJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d+iW9e8B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Li33hvkJ" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrIQp1743495 for ; Fri, 6 Mar 2026 16:47:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0OCwYQ2Sg4X39o+2p54LoIZKEdb8rGR+XgJMOS0WD3g=; b=d+iW9e8BFoL4xh7j FCnltjm/CNSaq7IrNakHc72lQ9UK6c+bFMQaRjVE6nlL1I1HA6Caa9efRaQHSRtm 3Q/G73wDHAFWbJff87TIN3H6ixBbikfTQ48wz+h4biWgWhMGMSjuCFxTUXKEDdU6 7/jpTAKiN2YrDs4+su6xKcr5vpqcPQev8hvGHNAJbTIixetMaDAdVWInrIH6wgXY V7qj9enuvWw8JbGtvqLLEIS6UpCq2yhPF60pLYhD6zGhEf1xW1pTbVWGmCYm6hIe klJe+3uU9ltejgx9AnzlshyBJyP+kQQlTxyTwIRo3OIE3CQpy+jcmRm3y3qHRMLd 5Vjqqg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqx14h0bv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:48 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899e76aa555so279264206d6.2 for ; Fri, 06 Mar 2026 08:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815667; x=1773420467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0OCwYQ2Sg4X39o+2p54LoIZKEdb8rGR+XgJMOS0WD3g=; b=Li33hvkJmNittdAHKJKXKggYJNM1m4t066XLsqQkGlV1isLnNVWdDtVlOUU6PK5sgc 3b5AW4S3yM6b6bjbrQNyXwf1I4ePfgqbto78Rd9sruLeU82QewBIC/uzVjpSRWJklr6f JZsA29Sl61Mdi83SXWGN+BeZw3jxEoiN/gXH/2ZD6L5oepXxj8Mb2bEAZhtoLg4mXq12 XzToIfJ4yyv/RO90yHPJStev+vcYLJx0RskoXBCH/E0mLv0I9qiMc6GaY856WfWh9Quz aujoUzNxU/SGoLyIIeeYQxJ1HhZT/FUBDV64fs1YBY2VCth6fgCNkSoGUiNTmmFXIlgj +Hiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815667; x=1773420467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0OCwYQ2Sg4X39o+2p54LoIZKEdb8rGR+XgJMOS0WD3g=; b=aGP9FfDOqo9uObAa6MQoW+UKomHXxCW5BUOuvA3zzK1BKrOQXr4AFWIp3agJORhj1z wvPE/E8Daoxm5MOa8qVw339g6fIl0F/PfrtPfXPA+CxbLyZNRzAuaLWNdNe2g/XD7NJP puC99NtJ2Emq9GT6vetK4pfKW4/TFBbmZCkk4MKJhuOvm/8t+5GvUXNkZacfG4Rtz+AX ntWyZ2Bg8gnG361R14IqEXsr7s5PpifibpRcCfIA+S+FwhwsZeC8jzCyHAvmFfjC8g+7 xpMSF9c/QgVoLLLOSoZt733DqGPbzK7paNMc8bngp6iOKPoQGwa6Lw74dNorFc9SSFxr 9zqg== X-Forwarded-Encrypted: i=1; AJvYcCUAgSh9iXWVhfumj2z1S6UEucfiSPwTvKgO46FLGXv1nSpHtrHvT0acH1YshVEHHSw8o87Ca3JO61BnKNU=@vger.kernel.org X-Gm-Message-State: AOJu0YwwvnSTW6ulEO3gZHpo4yC0PDRl2Cf3sXcln2UiwF97xYdFWPDg 4v5/4Nbmb1gVrmPhoYTKzmwLhUBqOKyT7fF3CfLiEk+RR1oF03zFbTHGs5ZkQqjwLM0PHpKspDC Z0v/5P1XMm3gbZMjI4piXiWCb/Sihv7FUkJ5Le6T5ttFZIrb9GCly+QPtJBB/FNkszLp81HFy/v c= X-Gm-Gg: ATEYQzyIyUFzUnRdSCp66Q0GejCyc2hZbXfk3r7UKZoJE0gi+fcuKc3k5tfqsxpNF13 R8URMgADLqtlJIdPejEHlW/hr4myB5NhHcDjnlc6R35scNCE8truZ4dz8RAmtRm4yJ9TKppbvi4 DQpmgyFAtyXf8leAXIylfuoP0PdlagBdLyDxwQ0x4MdZU5tuPuNh+VdqigQR93z/txcPNRj4Rrr BKQXWS2jFYKuqOgKPgEaw4aDGSbGVVg7SpPxcS+asrKgHAV2nb6MbcUSYjsoXVSqm8mmWWKfXk6 evBf4Kj+33nT+egiyVQVG/Z7gpU6ki9N5kBjFdM1mfwIv9LndYAcSWEgay1rMIhcBRndD/HE4y0 AF9PljTTpymvVKW+IySlDPStsiOKpeQUts61MEawMlw3NY5UAEUwA8HjRgDjFoje9MCmLbaaF3N y19TYfPs+7J2+lZbwJ1bzSWGJQTpp3Y/vCqPk= X-Received: by 2002:a05:620a:4586:b0:8ca:2ba8:b988 with SMTP id af79cd13be357-8cd6d44053dmr354356385a.41.1772815666943; Fri, 06 Mar 2026 08:47:46 -0800 (PST) X-Received: by 2002:a05:620a:4586:b0:8ca:2ba8:b988 with SMTP id af79cd13be357-8cd6d44053dmr354349785a.41.1772815666266; Fri, 06 Mar 2026 08:47:46 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:45 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:26 +0200 Subject: [PATCH 20/24] soc: qcom: ubwc: drop ubwc_bank_spread Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-20-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5229; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=mDvAIGusOne0ET0zqDfmYH/uZpA3s+5yjk3GrtdImQU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUPFtY6u5zVLvLenx4CUnulpHnNP6pHdDvS2 9vT2ZvTUjmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1TlnB/9VSPpVHj4eq2C76Ph/xyzmxPrCnKrdpIAWV5wSf9C8Pbg3OjbUiUkj6t5GMkzeblM6Vrb eerbaQyi9IpBjeF13fKvFv0TXxdlbDjq8yr0Svyo6LTQGnl0X9pYNA9/Kx3LEVU8xG0pKDG3spM W36kseSYDPCxH/h6k6pm9yfE5YsRGRfStCHAehsO2lN8yRjzrRoZ4jNCQ30mbC07D5D0YKo0Art T6C8eCw1afRpqoSb9qbnYqYmpi3e0486K/VUelYJAjLPe2y4y2fpfZbIv+3tZ5MTPecMSvyzdZE Ss1Bwc/O3lDPC5zQqtZcKCcO7mjOEJBoz1yHLRYH47snTNJu X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX/8LTQ6Pdw5Qe 6KP+sINM7fYsyzV8u3Dwnc67ILzo2sKL5ISOhYTOlDB3tArKH8XN9pfz2JBUKxOznb4WaWZ263H aLPBqR58yb5KNghyuZI5XtSHcf0xG1LnG7TuFOT0SBJfyuOmadko1ITiakWeSthUJmV3/vxCBP2 EolH7477aylk8ceQhXk+94DPTdVe3EfHNAjkseN1n993VkAC0ghRnITfEX1LpdtG7L54hfZzfN3 SQbul28/5huwj92rHLp8qWvJx2y9VzyhrK9BbIlrLyBk8Qxak37xKodydbv1wXWMv3S/5w9unIa BElkQBOkcctyTFZ3sqPPAw11Vrw0pIZoIsjLYIlK9s/T9M4HzqAqRCN/1Ps2Yb4uITrWjc4fKNs FS5OK2Np89OT/ntbk9uJxNfROJYYR0Rt2O5PslmEdYs/WYe+ilCuoVh3oZUta/kkqSSOJACwl2x ZBdIJKFYVNsmqiEtHIg== X-Proofpoint-GUID: 2YLnwxMv7og4IgD-x6BHZZgCQNwxmjyk X-Proofpoint-ORIG-GUID: 2YLnwxMv7og4IgD-x6BHZZgCQNwxmjyk X-Authority-Analysis: v=2.4 cv=e/MLiKp/ c=1 sm=1 tr=0 ts=69ab0534 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=j0qWcOM9GDCbVNQ44DEA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 According to the documentation, UBWC bank spreading should be enabled for all targets. It's just not all targets have separate bit to control it. Drop the bit from the database and make the helper always return true. If we need to change it later, the helper can be adjusted according to the programming guides. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 13 ------------- include/linux/soc/qcom/ubwc.h | 3 +-- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index c5c7fcb4d013..070bf97e134e 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -20,7 +20,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_enc_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -49,7 +48,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -58,7 +56,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -67,7 +64,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -75,7 +71,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, .macrotile_mode =3D true, }; @@ -92,7 +87,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -116,7 +110,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -139,7 +132,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -161,7 +153,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -171,7 +162,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -181,7 +171,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -190,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -199,7 +187,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index c5f049eab07d..405d83f8d95b 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,7 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - bool ubwc_bank_spread; =20 /** * @macrotile_mode: Macrotile Mode @@ -88,7 +87,7 @@ static inline bool qcom_ubwc_macrotile_mode(const struct = qcom_ubwc_cfg_data *cfg =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) { - return cfg->ubwc_bank_spread; + return true; } =20 static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) --=20 2.47.3