From nobody Thu Apr 9 18:03:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26CBD421A06 for ; Fri, 6 Mar 2026 16:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815661; cv=none; b=JFFeVsp4z1hS+pRyw9sX2rFxRRNCIIVsfC7HeOJw1iBHCxT5+WunNdK0uRoXBs8UrMNto0GpfdqjQbs0ufROu8n51FGAQZruoByxTJr/ISLa5dsapZnX/bQ7hpm3GdwqtwDc21StUSVYeen1p1UQmxF2oieNrFAcCyUaJImyFy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815661; c=relaxed/simple; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uPjD6P+PUgZz0oAYNDWMxT+RUSaG5nopyWP9cB7P5tA/SnCVFZi3i6r4iJKZlyWjGA7Cus2DdfmE//dXHC1AA6NBmq7yBJSi9u0ZdbDI84L6Yb9nZNsgkwz40foTTyNjxaYopNukJ9+1X9PD7EXA2K9/tFbXG+c7tD1eXQ8R18Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cW81b1BY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=InMPEqcI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cW81b1BY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="InMPEqcI" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr8c9080007 for ; Fri, 6 Mar 2026 16:47:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=cW81b1BYiUy2ELXh BzCE03Hei4NK6Qkx+HQeA9DKgLOTIUxtVkBxK7kZfJta+IAfpVXG8JGltlc2wtrr LRdLoM0Xqq5Xl+89uqD3tOQuB1usfHWpVkfb6Npam0mkeJhkD2mJRmvoQab5jn0X VHlf0mYp62MCWcynvhLtQ/iYv8AHaeaaYBDBzIXWhvxS/DMj6YTtvCA4HsGuy8VH 9ENQIckaf1N5O0169V+6olSGSlT0DiJOIYLmwjqGmlSk4PvJWh7YgAj+jQ3ioQX0 XYeBkrhQ69FNtay535XQNpTqOU+gLBHwt8DnhEa02eRkZAb79/7mRzyfTzdT50MQ GD0GSQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp43k78-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb4d191ef1so1258668885a.0 for ; Fri, 06 Mar 2026 08:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815653; x=1773420453; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=InMPEqcI1qnsAxcpdv+zzmes3wvlAoJVNcQRA1vsD3exVfu/whEhYpO4ZNhnzMKGKn Km507mHT9pC2Vzn9g87LMnAVVOvq3/a2HX1dK8y699QW+6mxFtpCkrBTkkiNlVGoSwsy JJKNxgDoBpJWnXXX+iwUiziADgf+ds86uTQB5yl0qOza2SJ3iMEiodqKAuMgi0wu5mK+ P+wDh5b8zpOQoAuxk6OnCHyLK9m5oO+3mUr7YWBCjCgv1LFspe9TYm/rGzPo0U29BFlu nv0LYas//OhCjCWNi9X0uipnQBk/jc1lj1fSv9y1NWMIR6RfAjfS9A3GkgCCAm2aFNgh 2W7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815653; x=1773420453; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=AeDmGa5i1/uveoyrzua0KpLZw+cN9Wgobins8rQJTp2TCuPq1MgSn7TaO9PWhh+kPX +RehHC/FjmrOKdKZGamt93ERmteuF/QnIOu/7omnT7xBOJu/tEiA8Hn71Odrxnh3G7y5 01SZMeTL+8gsHJUCjpAJsIrQn/oziRPWyoaQ1eqn467FbgfJ81+c1eiYScUclmLt7yem aClSYkhNNovtQP70FOBcJycVIfagn/iLZHfy3xz9YtU6DG1Q0MsvxsMwFek51m4gES2v MqRGXnTLHIPd/hJ7er7lkqDwRtJ8ZL2R27c0EmOhmMGao9m+LWGp1cSj+IQ3lCM39vza 3NZg== X-Forwarded-Encrypted: i=1; AJvYcCWavD8CTGXf1fOj954O0vqJzbUtGs6BzVeCatK09GiPIYdodXjuCdqUTMDCqnfgtkXLkGnXGhz3Ii4RMd8=@vger.kernel.org X-Gm-Message-State: AOJu0YwwX3U4gnY1H5dDRiZGYuIlET5pIxa0tZtXBHFK/p4Ke/NL8Ytc Z+p0GcmvSe9FyDVh6tCQGuI6KDOlnQ4D0e/qPoWtUoJDn93dzOHklYwV2DwxIamGcdz8RasuiHn vmCOMPzaQGgQEb8CGY6RG/cPia1SrIYxfVoeGBpJSUBS1rdYgCutkVjzYwrLhWVzCEuqgqIwFk8 w= X-Gm-Gg: ATEYQzwDeT/L51x8hMOiQ9TgFHWqo4y9OhcyMBrylRUO6+jTt4/bcEWm5rqpFzV+7pQ BP3htoac91qSWnb/G5dzezLjLA6+j77z86/buyUMvuWaWgCFhiuGptR197+WVDXslGGwXJsjYfR ppJoJ6Mg7o+hUTSfBeWtB8bEqyGCwvHGalU/sUeD+I8LGwkCGaC6t5BjUqpZDk7ZmqLwqQWnS+W Mwn7IASoNjwCkLPF0viOXqqgStcnZcvpCdHat05B7vOIjlOBmdbJGW7Wf52X8EZdVo2sM5HMmJU pmjSnp8palvKk9/Xy3zFYkLL5LVbfLJkgbs/ecWEY5f0PRrUYqDyO1CmhLr5Mr8xpPm4PD9DAg6 5h54J+FWC4Adtzzqvx4j7E6WMzm8nmyASIIpvjNTntFcDMeBpC6U49tdMYAb5fNNVQK1r9oHKRR lyEdEyV0BwbQBxUvCBSKRePMUyPAjlj7uQNiQ= X-Received: by 2002:a05:620a:4607:b0:8b1:1585:225d with SMTP id af79cd13be357-8cd6d4a6d76mr316673585a.82.1772815653099; Fri, 06 Mar 2026 08:47:33 -0800 (PST) X-Received: by 2002:a05:620a:4607:b0:8b1:1585:225d with SMTP id af79cd13be357-8cd6d4a6d76mr316667885a.82.1772815652532; Fri, 06 Mar 2026 08:47:32 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:31 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:17 +0200 Subject: [PATCH 11/24] drm/msm/adreno: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-11-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2707; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUO+cW8IttvRxZ7kZaN6gVeCBanRcrfHvEmx kmoALrut5GJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1YJ4B/9qW5rJ1SwBReASY5/KyLYyVFXtnjWwxBXVf4i7cC5e28xYc9gm8NT7GoRPB20/E0y2ou6 0GNyzRYWdMTmAECPm6+7kmuGlYLCc5pGOZCdyhIFOKESeIfanckIhENp8b+6Tq/yZivgUKeVs40 XTV7DyLtlZ7TRwDGcnSwwwtQtF1hBVIF6+mxyJdVnpor3bs6u7FY949gj6rzXaKozsCRfcbaPWf n6uccbmnA3zHYVmh0W/CDobRy2tS7xp8HGf4NdA4ewB8t7dM6q/tkP3cSuqulcoU5fSRIszdYaJ HctLR77k44CBc/zt3DPSj6H+8Oz22e73q0GvlOKyDpLXo1WK X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: WXAtsJyjU3U5bqbMXy98_6D-KL6WbTyl X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69ab0526 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=0JjmiBfSQHijSEXDZO0A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXz2NAmEOAiW/P KFZekJB+TflW4kYOV3BJX8Gq6XIiqVilSPbHcL8MwPErnJ7gZ/qkDnfNxIemdExOh00GpwjN+5i HYVGRuua3N25OlLBvgGz0cC7Sc35b5nrIocYlULOK42dGSgbgsD5HMpTFbVEvOjq7STN5J6qfeY bjky5g3a8juHthPPzdXNOg5jzRHViFjQ2uyA5Te6yVxCN4HyXRkUsC7wMimuWJ0xqQk4bNn/OuW SPSNQ5uKwswkUf0turAXQlOKekMauiPeleEDXM3E0zYw9GU4rpNe7G/z2NTYVsBtq1mZ0UxSBKi Dls77wct6pKtlOVGzcStMuu3oAUyNqnW354yd2ERrqQ3H4hTQHGJgY4h8omrQeVbNAviI096AwR bH3XkyyV3zJ6rb2s58/RMNE1JrDBInCZ4zdWmF1/GrCDaiMS/W6t7L+ARIuUeXXn/nfjkM3k2Fm a2nDnBVMJobNYW6PjqA== X-Proofpoint-GUID: WXAtsJyjU3U5bqbMXy98_6D-KL6WbTyl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 56a820ffa613..7be31de3b525 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -741,7 +741,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) BUG_ON(cfg->highest_bank_bit < 13); u32 hbb =3D cfg->highest_bank_bit - 13; bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; bool min_acc_len_64b; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 6dc1d81fcaeb..680f0b1803a1 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -265,8 +265,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); const struct qcom_ubwc_cfg_data *cfg =3D adreno_gpu->ubwc_config; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); - u32 level3_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L3); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); + u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; bool rgb565_predicator =3D false, amsbc =3D false; diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 4814233d8dba..cc21b41cae26 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -432,7 +432,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + *value =3D qcom_ubwc_swizzle(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_MACROTILE_MODE: *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); --=20 2.47.3