From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8103B3ED124 for ; Fri, 6 Mar 2026 16:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815643; cv=none; b=Yd8a1xif6VLUGLK28UpSkfOrXcmXuGhtHUeGHrrhOtZBztnmI1gLwo1RmMjnOTiFsmc5O7Fte3tKJocXwW8na+mDiKvzfe+MbbgpmC6mf8L/pVF6iXYN6pLXPPWQk5jc4O0oHyejbP7y/RfVxCYcX5UHImnwKMqzTZQIfYFrRrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815643; c=relaxed/simple; bh=X/lCVaBuy9kW6TT9FJf3ZpTkOHqx73+qmE28wl58iAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Co8nMJEkEZ6AM90tXFs+Fd7n7SDOGLVGR2zMVazHHi9ds28xjbpu8a0IrbS4jYYUQ5eriUk53fT7RVAaJWFuG0EZWjh1vZM8TexjR/hbDF04XsUuc1FhZzs7XX9OJ3YUEp+8qIeXMuhk0ogXsWiDQS66oV2fD4MRbhWX/tkGMjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JpWZnSd3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P5VpHqRy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JpWZnSd3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P5VpHqRy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fqvw5549904 for ; Fri, 6 Mar 2026 16:47:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z5a8jUnPxApIBxmt4U76dukkSArjMceSh/RhKIkdDCA=; b=JpWZnSd3+YfVTzrr fMvF5DKn17hwQVZCKb2tu7QIUUkZf41RWGJwyQE29rAWR6Gbwtz1CyKXXWcQGHtr SAjh+g5wOM4YVRTDvOPNoczTquipJYBJT8GoRUi145uAtpB7LCZYFLng7e4UbA4o WRqYpb9OfgRsmqEB5qR1UhsptVGveXvqa4pvUBxF/C2h2PH+ZOFCYn4kd5U1HHCZ CLe3OXCt8uksu95qvNx8u7CTtu8KhQfSr0nwE+gVsHvXIWjgX8skFIZsuAtBmrS5 +Wcsm3uNB0jcxZguMXyIXDpc9EdPBtqUsFsI2HKvwjRDX6aNrM+1gDa7f9tR9Qj0 HD/bWA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka666-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:17 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c70ed6c849so2001357885a.1 for ; Fri, 06 Mar 2026 08:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815636; x=1773420436; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z5a8jUnPxApIBxmt4U76dukkSArjMceSh/RhKIkdDCA=; b=P5VpHqRylfNrzYO4F1sIzXf7wge7T+VHYYMzPpw2iRiwUrH9jxL1Si4OCG8oiwdMxf oFxPOg/EDluCzESW5M9divWqhxnAn5Uu1kwBD76bCFFd48sadWVHedJr8X9Ddhx3OiY+ JSQIEq8BctNsx1a6e47blNJd7GPYlJ7FQxrp9LUYcduOVe8+wXgiiRVng0mwFdjfGce5 ET2uOzLp+FhyAAxXCKdc8xnA/xzqcqnrZJHY0Q//cdQ+qDtsoFbNL1alZOWYwtiyfWDK ldHvfYTgsqTrF888jHqLpxUNKDtnoKOP1zYi44FF4n9gEM0I23ijZfRwgUTvGIWzrC4+ 1Ugw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815636; x=1773420436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z5a8jUnPxApIBxmt4U76dukkSArjMceSh/RhKIkdDCA=; b=eD9gHfDCHNdbLTvAHHuRlIgmbh62Wo7Jhs8ylVjXkZ3zutBKfuDaNriaUynmdlC/ML mNQn+WW4Tj7st6tc9x6IdA9c1yeCJJpt4jZnX05apIMXgvzOHLdaiJRhXbMOhoMCG14P 8NSU/T+xmBvli8JexsEfa2A/n6CMyY+RgPaDfuCxYpr/0fEE7eQlUur3jQn1lamMgzCt VhllgcWzCgdnumhX5kg/830nMTU3K+r71v+ryRPzGR5hH2XrkrHOuhOifF2tmcCi19fq uB25Y00djQf4GYadNZDVriVeC6hWolrFjHpXC3ORaAn/x4yl/NFbzt1Z5Qi+MiW18n6P 4lOA== X-Forwarded-Encrypted: i=1; AJvYcCUrqdLWSr+S8gSW/lkyTV/FxgG35WYngtzz2avhsLVrJ2iAakdCBP2HrB2llgqvEyKh9PlTA1QtbbbGnCo=@vger.kernel.org X-Gm-Message-State: AOJu0YwRMiU8gTYGbGOmmqYyaKliecrp13MzDyBJP5co4M4YuUU2lOuS XM/kWwibCb7bFz4MCLjPV1GlIh45yHmjt3MJMTvYFPqYvU9zk/vBzxKWTW+b94JM47UYvXvFH2a 9WX2nvzFHjEXArfwmTcXHDj0KwbnH3r8ghpuk0mShUnTeQSxTG8AJJkkDPjzqqLo9YREVwpLpvZ w= X-Gm-Gg: ATEYQzzuLCLzGNGm+HjPjWstIlnWaY12Xho+bJWrvu9r2afDtsVTTGe6tUIDYM8VdQo qUEJmPPA0qdeVoABClnh3o6E66sDa4uZ1nHWSO6Vv2p8Q9uOxfb874/9AKpf+L5kGMyBZvrBbxQ Ecuqx7/wviT1KYGwQZDhODYcguTa60cGxeBlNVXaNY106ikGUSMR8gXT/+IuZngc9hM9p+8CCEY GYNjh2iE7bVKVZEwyfAYo3W/abfVb8UchhmCqUds7WDb5mgFwipKTKSuduEdGowAv2ABy/U/usw MCUXzbilrXn0UCpxAbF2JrrZmP3xPbASHHtLL1e3+kD+T1K9pmjfGSI3GSoEx071ZW4PUc4pU0U Xp1Uc1nGKM4TUMuDgvv5JOkg3aBIlV5r+6PpNNBVOC9CUVecerVvSxYyw3mUIdYMYVhKHMbhS7M 3nphPRa1eXEgDuXyJmC8cbqwZwsbTPPia3Ez0= X-Received: by 2002:a05:620a:472a:b0:8c7:1106:1a44 with SMTP id af79cd13be357-8cd6d4b5daamr342002785a.79.1772815636130; Fri, 06 Mar 2026 08:47:16 -0800 (PST) X-Received: by 2002:a05:620a:472a:b0:8c7:1106:1a44 with SMTP id af79cd13be357-8cd6d4b5daamr341998485a.79.1772815635488; Fri, 06 Mar 2026 08:47:15 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:14 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:07 +0200 Subject: [PATCH 01/24] drm/msm/mdss: correct UBWC programming sequences Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-1-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6916; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=X/lCVaBuy9kW6TT9FJf3ZpTkOHqx73+qmE28wl58iAU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUMJ6tLpaGWdZ4kB2K8/RV8sUbpJpzmtOl0o +rInaDMbpyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDAAKCRCLPIo+Aiko 1cASB/9ZMzti9r6MplOpgi9r9VXlfLsjT0Y5z1+SJf+yK+YN47mzAP1vvpcGwqKESKujP0iQYMA B+N2m5uZ432UB//bQ0+TGt20hw9faBKGTsE1mqUSHH06YO2ecJu2/C393xqqS18ehaCUnRI90Av +tGVRSjzK6bqAvh0hq52de1oAyfumt8q0Ifo86mWRi3rs9nEGzdhOoLL4AAGvsG2ENjBEvhSlwE AGuI9qc3c+ydzsxCe7RH7vW6i9CrNclDTyyb+C8ag0ekDBjnBnV9xgTrReK1cE3q16qvPrtvEaH +wfffgvquM7cnn7TVOWWRIwMKlB9jOI7i3xniAjQSckrJ9Kp X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXyf1ityecW2PN 7EZUSr6BiDG32Trxba6aZjo7/7PCmDNlf+yRE97ROgjcat9tShw6oLUWt3yGeBMfE/cVHeaQuXe UrxOlM9X6RkNA07yVxG1rPaZ3iJ+hFMdsBGR8YWpAhrAjhXWvbKA78BGWycCxz5R2nkVvZ9tkbt dnqH/MWSWzOC9JiTuBZAw4LRC/4fmHjV+Cb7/jK13YbJF/U0nk4zaILiOzyRq4+J3XJiCzD8yKY I2FDr/1pnFa+uZGSZMn9hG8Wi7BCg8cB4Wtn4nV+jTofkdh/8bEpItMiUkTOQTwegHNCaTHMdoo a21y1ApDQ+no3svOu9Ffi6/Tq/RrYrFH75dMt91Sefa+i5/Ju2n0mB77cjF8XgPEa8duQ1DwsID f4ohGBUDKJuv5Q9ffnyTNUE5mzOXR5oBvpKEabsadIXTdiNgHTzBGLC0jbFdWa9v0FG4vbNEno1 fhEmpPr1pX6n4WMb2aw== X-Proofpoint-ORIG-GUID: fLQSoMtWpAqS3c3j205151PPwsYiv-mq X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab0515 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=hQCg4X1xv2bm5S_WMKMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: fLQSoMtWpAqS3c3j205151PPwsYiv-mq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 The UBWC registers in the MDSS region are not dependent on the UBWC version (it is an invalid assumption we inherited from the vendor SDE driver). Instead they are dependent only on the MDSS core revision. Rework UBWC programming to follow MDSS revision and to use required (aka encoder) UBWC version instead of the ubwc_dec_version. Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 120 ++++++++++++++++---------------------= ---- 1 file changed, 45 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 9047e8d9ee89..9f81f43283b9 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -166,27 +166,27 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *= msm_mdss) return 0; } =20 -static void msm_mdss_setup_ubwc_dec_20(struct msm_mdss *msm_mdss) +static void msm_mdss_setup_ubwc_v4(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_bank_spread) - value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; - if (data->ubwc_enc_version =3D=3D UBWC_1_0) value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } =20 -static void msm_mdss_setup_ubwc_dec_30(struct msm_mdss *msm_mdss) +static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 + if (data->ubwc_bank_spread) + value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; + if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 @@ -199,11 +199,12 @@ static void msm_mdss_setup_ubwc_dec_30(struct msm_mds= s *msm_mdss) writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } =20 -static void msm_mdss_setup_ubwc_dec_40(struct msm_mdss *msm_mdss) +static void msm_mdss_setup_ubwc_v6(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); + u32 ver, prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -211,45 +212,42 @@ static void msm_mdss_setup_ubwc_dec_40(struct msm_mds= s *msm_mdss) if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); - - if (data->ubwc_enc_version =3D=3D UBWC_3_0) { - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - writel_relaxed(0, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); - } else { - if (data->ubwc_dec_version =3D=3D UBWC_4_3) - writel_relaxed(3, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - else - writel_relaxed(2, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); - } -} - -static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss *msm_mdss) -{ - const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - - if (data->ubwc_bank_spread) - value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; - - if (data->macrotile_mode) - value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; + if (data->ubwc_enc_version =3D=3D UBWC_1_0) + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); =20 - if (data->ubwc_dec_version =3D=3D UBWC_6_0) - writel_relaxed(5, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + if (data->ubwc_enc_version < UBWC_4_0) + prediction_mode =3D 0; else - writel_relaxed(4, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); + prediction_mode =3D 1; + + if (data->ubwc_enc_version >=3D UBWC_6_0) + ver =3D 5; + else if (data->ubwc_enc_version >=3D UBWC_5_0) + ver =3D 4; + else if (data->ubwc_enc_version >=3D UBWC_4_3) + ver =3D 3; + else if (data->ubwc_enc_version >=3D UBWC_4_0) + ver =3D 2; + else if (data->ubwc_enc_version >=3D UBWC_3_0) + ver =3D 1; + else /* UBWC 1.0 and 2.0 */ + ver =3D 0; + + writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 +#define MDSS_HW_VER(major, minor, step) \ + ((((major) & 0xf) << 28) | \ + (((minor) & 0xfff) << 16) | \ + ((step) & 0xffff)) + static int msm_mdss_enable(struct msm_mdss *msm_mdss) { int ret, i; + u32 hw_rev; =20 /* * Several components have AXI clocks that can only be turned on if @@ -275,43 +273,15 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss) if (msm_mdss->is_mdp5 || !msm_mdss->mdss_data) return 0; =20 - /* - * ubwc config is part of the "mdss" region which is not accessible - * from the rest of the driver. hardcode known configurations here - * - * Decoder version can be read from the UBWC_DEC_HW_VERSION reg, - * UBWC_n and the rest of params comes from hw data. - */ - switch (msm_mdss->mdss_data->ubwc_dec_version) { - case 0: /* no UBWC */ - case UBWC_1_0: - /* do nothing */ - break; - case UBWC_2_0: - msm_mdss_setup_ubwc_dec_20(msm_mdss); - break; - case UBWC_3_0: - msm_mdss_setup_ubwc_dec_30(msm_mdss); - break; - case UBWC_4_0: - case UBWC_4_3: - msm_mdss_setup_ubwc_dec_40(msm_mdss); - break; - case UBWC_5_0: - msm_mdss_setup_ubwc_dec_50(msm_mdss); - break; - case UBWC_6_0: - msm_mdss_setup_ubwc_dec_50(msm_mdss); - break; - default: - dev_err(msm_mdss->dev, "Unsupported UBWC decoder version %x\n", - msm_mdss->mdss_data->ubwc_dec_version); - dev_err(msm_mdss->dev, "HW_REV: 0x%x\n", - readl_relaxed(msm_mdss->mmio + REG_MDSS_HW_VERSION)); - dev_err(msm_mdss->dev, "UBWC_DEC_HW_VERSION: 0x%x\n", - readl_relaxed(msm_mdss->mmio + REG_MDSS_UBWC_DEC_HW_VERSION)); - break; - } + hw_rev =3D readl_relaxed(msm_mdss->mmio + REG_MDSS_HW_VERSION); + + if (hw_rev >=3D MDSS_HW_VER(6, 0, 0)) + msm_mdss_setup_ubwc_v6(msm_mdss); + else if (hw_rev >=3D MDSS_HW_VER(5, 0, 0)) + msm_mdss_setup_ubwc_v5(msm_mdss); + else if (hw_rev >=3D MDSS_HW_VER(4, 0, 0)) + msm_mdss_setup_ubwc_v4(msm_mdss); + /* else UBWC 1.0 or none, no params to program */ =20 return ret; } --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A68853F0775 for ; Fri, 6 Mar 2026 16:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815644; cv=none; b=TIHgSQMMX9FuollvHFS5Du0xM4SeDoUVrKWtcpx5AfJ0xRp+vTvBAXvMddNQIHzEHbf23dNnCV6fd53/FaUAZx2IQ7RJ8BH2M4A/f74fKEb6vowN8056/eFhsdcjnLU622fcz2AN1GYt/u8PD5xtAjpNra8HleQ1dlO2f3eqc7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815644; c=relaxed/simple; bh=gyfzpHMr9AFOWazAVx4QmamvMyFfTKzuDUatnY4dW/c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C7QrRCetUhChD3a60FkBokFk3HOxH8a+qnlipm2tQcy50AJy4/mIIbuMbAEXf1nPQce25nwQc7Oo3GwnATXVOaojk1QgFBWKhseemv41AcgHLeJkCJ1QiQKcaPDo7aWhcxcHUDXyvvU8SUQ0rgsiLYWaFOdy3vxiRh449sriiwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bv5Fhilt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JtVplnOC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bv5Fhilt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JtVplnOC" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrBeM082793 for ; Fri, 6 Mar 2026 16:47:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UtUApVEJ/1Orhd8h1qyFB7XAj1MeiJ7Xj8cHRafwRsI=; b=bv5FhiltoMAIomZs Y+66hH20cOKirup9XszOx5Cd1xY+kllXCO4uo+V7iWdbuSfssB/8riEvk0UPqr4n c0UE4fPp1GcgYpiUrxRE1svfkk44OzbQpnTZLcLK7XFEd3IF0DXKGWZnBP8/7gup hcXjcUttWpHbIxrSOfN4myMXEIKozL8Fh6Yuh6QdvI9ntfQNylU4qEZmyFI5w0pm DV3bvHz8CuozIXQ9Cd7JJVDuBNWVy+Yid2fdIaaGmR9JefjyXz7gVH1DZbmtEMRg Qi4SY+wqGWypRyicd8n2xdMB+49fNuVoE3PnL/KxWp3TCVRF3x307oGC6lg/7kO/ FsJUMw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98hbyj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:18 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb413d0002so5927860385a.1 for ; Fri, 06 Mar 2026 08:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815637; x=1773420437; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UtUApVEJ/1Orhd8h1qyFB7XAj1MeiJ7Xj8cHRafwRsI=; b=JtVplnOCCp5IopOM6n3J4x8OLdgzLJAc2qOaJKMU7v4JXtloJ23ShAfUqWp4wn9Mmr 0DIE6MKMKFsgWYhqoCLKF9/BTb8VE8K1vqF44fXHyiLbjTa5EDKeYNsf5OTPWZmvbFaE +ImUGN4z/0d5CXyVA0wnmpe77fX3mUajop34RYsnuxrcYZFphs305RDgx7jRtIKHwP9N r2WEpOdnwy9P9Atpm+6n8H3mR2PCPS7fTkWE5LWE1z4RPFZE0yGfuzGrUw/SmFViUJSl Zu+OrwUu67r9IwLaixTGUmAkXYEb3DWN4m0Xsv3twXHLO4JApY5NZF2He5LN1Ib6gAOC rhiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815637; x=1773420437; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UtUApVEJ/1Orhd8h1qyFB7XAj1MeiJ7Xj8cHRafwRsI=; b=fR9e0Nvexq5IfBzi7Kux84V7o3GoKjWZ2tjBEQjX8awgPMfuvMv7qSIzburPG5kEA5 BbUumataqca/MdSqENAWrbRDeDxDRF1G2UyPWIU1pN1jm36JUSV+uv8XpPXJrUmNHHdF vfcEEti2JQEE0Y770LXfE4yxiP0P1C4kmHvAnE9HtLRJsxmox7K4ah8+dd6d8AihH35V w6MtQrXgLdZ7rpE9YrcDN6eyOaEAbbhzssC975kTA6ikpKd8+QG/FOhaaOYVs38qY4W4 Fcgy4Lejj672Cp2wzvnuTHornA5jlLpPcA0LU4+12ILehGf29PkAQLrk0k+3Xd0XPIP9 vUbg== X-Forwarded-Encrypted: i=1; AJvYcCVh44LWlZeujHBdNWc0izGS2rN5rFPBZ4SDwTIbkEXgC98yc3ad8x7UR6pC2pTrB+HkK5X8aylWPjIokzg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5GiiYRoZomnCMiCUMiUKqoHdmi10KN203ASYoog83p196nVbO dT2EkUJwwaOSYtEdUqPamwhviFEJQRD1ZHNcKCWDvttXmfHQJL29rnHKRSarzZSJKCmqUrv/lix eA72mUyQZ7cEF9Oc7mvWsLn5DXQrRYS4DU9x5FMG9MnXIFfeo7mqUjpRwCrgpRXohz0sGuX8dtI Q= X-Gm-Gg: ATEYQzwDdMbSUSPsIzLeKzhS3dLXqfdhdTTiv1sMRKzrOVvrN7h55aIHF3h/RsLK1Bu GeRVKHkSSpn9ZSOWZw+Ox/TXuzQywsyRef8+Gz/LVCm8Q9hNuqR9S/gUfFYOzy4v2MDY/vQPVh7 FM++rvR+Y35Mk0mp/mSEzp0DeF0leW3YwDxLgh6RhajsAr6+VDPgQcdTc7mB6cI6NSyyKqowV4Z /IpF+KaV9iQgesow1AexBulWpGhSOSQpEMk7AnIee+c2aU+o1lI7zSnfu0W9en2s9FXPDLMAoKI lHfWdmADGsPmlKSViQkyzy/rQ31HJJB6nILayBqX/ulDeuAMH4euIcSu96tC02QufjtyI5Wwh2E dMJwZOVaXt7HNIJphTQ0LdiLhwS4XDLUTKEiRGKhZWfsFVizBCmC5GWE61wTZQ58aXBWUvhYbA3 Z8DP8wI2OotvplqMczIPUu5m22//FDmFKWkoo= X-Received: by 2002:a05:620a:46a9:b0:8c8:82cd:1a85 with SMTP id af79cd13be357-8cd634bc781mr792068585a.21.1772815637588; Fri, 06 Mar 2026 08:47:17 -0800 (PST) X-Received: by 2002:a05:620a:46a9:b0:8c8:82cd:1a85 with SMTP id af79cd13be357-8cd634bc781mr792064785a.21.1772815637077; Fri, 06 Mar 2026 08:47:17 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:16 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:08 +0200 Subject: [PATCH 02/24] soc: qcom: ubwc: define UBWC 3.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-2-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=853; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=gyfzpHMr9AFOWazAVx4QmamvMyFfTKzuDUatnY4dW/c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUMU+f4UG0tqZApANYtH8Mt0fedt/MOSLCtl Iwy5CVmI3OJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDAAKCRCLPIo+Aiko 1W9AB/9KADo3tGsl2w9+dxT/ofcURJ1iki7kUElQUZx/WuZXjH70ZNU5UC9q9JLLUJQ3/Sw4ThL v5QQpfXj6MzIj1C25LcSdfkuiNKwBQbbU/vjWU8INyROJyqK8nTonYR8qMva2dCTb8+l477Vipv 5K5eJ00VGEPVFtnvV50Cn3nf+kl5bwGNL2HP3Ew3Eq1uqpOzyrlJjAoDexx5DI8JMP/oXvlvmug bSRWRWTvkUPgEdD8Pvvg5khu4G48LtbJt5po4zhbPYVIvl3RYxJDVRhNAiVM01ooVKCU0uhtGNX MDoR4OXYtLUbLJclvMY4tp+CYYQFpFVQCPXzFUTTUuM5Nc6Y X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: tc_mYCmG9MLYv8nPZF00A89CbQn9uq4H X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX/ZO7tul/zvtT 21fXmbIR3Wt6jZhv0kP8vv+9qhfzt5hpo5Ghry9ZT0GBkQ6v+IHS8EE2BwC44tzTrLz3ptAo9iB QwfJKFgq7mLSTRC168LKsfG2xyuCUKrjDS7ygEQRQ8a9o7ovTCpmw3XsdEgTxAu+1mwHltYyO+q w2gTKl0A9in9ihL/tQGuue8Oh6DYJCIcrr0VEfX+AL8bRZbTiHtEK+xee3zsRUsmwtzQWQd4YjV AM/+35nClJ4I38WXt4tR7PZJPeserZI3OmP2WS3echo0ocLP8mvCeLvFwBo9pFLtSZ7fDDQ0obc g1UUZrJOmlQsMC4CRvyeamylNWkcnQp/r9bNOGiCMrPRAGbZCFyZVbwjQS64WcSUM9Tk0G3M+vA rAoRIDRbWj8wTi9gpqJ77itr7+DF2BdJKrjO/wkSR0v89bR76db+W1YCKvsJ7abVvSiv42ofNbj VpOMvfKE8FLnt0lA3oQ== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69ab0516 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=o8D1m1ilSIXDguKSM1sA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: tc_mYCmG9MLYv8nPZF00A89CbQn9uq4H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Follow the comment for the macrotile_mode and introduce separate revision for UBWC 3.0 + 8-channel macrotiling mode. It is not used by the database (since the drivers are not yet changed to handle it yet). Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- include/linux/soc/qcom/ubwc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index f5d0e2341261..319caed88775 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -50,6 +50,7 @@ struct qcom_ubwc_cfg_data { #define UBWC_1_0 0x10000000 #define UBWC_2_0 0x20000000 #define UBWC_3_0 0x30000000 +#define UBWC_3_1 0x30010000 /* UBWC 3.0 + Macrotile mode */ #define UBWC_4_0 0x40000000 #define UBWC_4_3 0x40030000 #define UBWC_5_0 0x50000000 --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EEC4411632 for ; Fri, 6 Mar 2026 16:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815649; cv=none; b=rWpm7MCUzRFkGqAcbu97Svry3oSMdUSvaAllB0sam1Ypd69YcRBxcTP1O4dovtxI4fTfffwNhIbNvw1nv7eUVBbgnxpVJ0CQCqCrsDRrbioF37t/uHX33IjVwnMr4W3P/FbO8I58rAw7O09ynDeEYHdHZoOEwVh48dKSyQMMwmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815649; c=relaxed/simple; bh=u+vxmRBv/m3rH6HnQZVzi2jrY6vhcP5vRXG7as7GjtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VNCj+HGDeCiQgWR4TZe0rxepQ6FlLgHIdyKcB+rp10cId44X1SXvjuNjQWKa+5kVqija502immEXGlzYjO1SnTbKLrGeKNicaSUz/mlyWWStf5knlUrj7Abw6gmOmTk6+pn6GPpxjjoYOOzSoFJltMUNbqQx1jKAQ3QoscUat/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WhYq1c7I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PnwP94Am; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WhYq1c7I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PnwP94Am" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrQ662008935 for ; Fri, 6 Mar 2026 16:47:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZDkaGfNA4m2bbYX9iLbxU16Hm29lTm2hzt5lBB0S9XE=; b=WhYq1c7I0Dya7pX2 E6+6WcL5nlGWe9dEIuoI2IHOavaQ2MYTPptgpV0Hjar7QJElDNf7BaTuIr+VNJlC q2DInbHclD0Ppuj4l4qbb9q2zvWMLybeDdaash278t0Xy+/N1tuPFyWNF42SkCKn XcyO5BogP307Vex2NxBzdWPsBvVHTdrRzAktlJUBjyaMcxTo6+L3Mz3wYUZT/3S7 7bbUCUCBmqcp0jfw8YIJmdSWYltlpvtd2YplnLyWAIRf6hi7XtMYoo+dvHrVM4TP 23NlatTfK+Wx2rZwHlPSkdemmgyimnOmS7zXOtF6S+Ea6OgaKWLsA9f8hLvKDnB7 lI77JQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv9ahchr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:20 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb3b6b37d8so4944043585a.3 for ; Fri, 06 Mar 2026 08:47:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815639; x=1773420439; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZDkaGfNA4m2bbYX9iLbxU16Hm29lTm2hzt5lBB0S9XE=; b=PnwP94AmcJHEzHKJEr4gp3gcpagjKoxkU0koHd/NnaeLelWHaZg6RXzYqpgzXlumbs ZzimoyazlAGHqPz/Hq8XEJwLh/l3CQy8TO36AkFSTLEQAOQ8y3F8OdMS+lckmQSgHRFp UMprHIHhzKwALYtFnVboWp1gf5MhZE85GhakPrV2/Mf4drtVbvTqA7fxIwe9nuwwra4m MIS0gOrRb6sDZWIZY6fakMwod6ikfPRnEvv7tbbyR1nbPiDMbs4LoGIwZPUHdecIdElT 0lyL8mOawUQ+ChWFPxgj64UaXHjlpT+sa2NXG6d1Mrz7Np67hz2CuAupLZW2DyP48rxG eGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815639; x=1773420439; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZDkaGfNA4m2bbYX9iLbxU16Hm29lTm2hzt5lBB0S9XE=; b=Ss8lrftvw4tbFmOyt6WEFEskDkLCuYMtWAEDE8YxxI0znLdRmlt6xDk4VAcnUGocM6 Ny+Y5M7GAevO252kDWtmezkpQaPxMuYZthNBRYL8NoJ7LWOdIcYW01g7Dg1BmxkAZxYX foqxvACjQ9aTf1tjLhYBQTWhy2nHXCvXsZGMV+lGQv65YIcHX5XEMzjHECSijvWuiHl/ uFCWQ4CiJj4Xz0EBFHbdw0LZDD6YXm8J0F0hjKoZ4p7sIdSozzSkI93tMtHrQER2k8CL oWzia7ZlICLbXdy5/lwlKevrI7tfP7VVSjkHiIuJsJjJdP88rXFFVwVQkb+q6ioI+XzZ YxXw== X-Forwarded-Encrypted: i=1; AJvYcCXFoOhDr/x7kK3xHLuxH5UwbJhqw7SEpmeX/LKrWqUZ+13gZF7BiKKh6+J96L6TspfetXbvGO0h9pnWjro=@vger.kernel.org X-Gm-Message-State: AOJu0YxITttlOaYznVG0WRTCZGHY+A1tw3xeBU6jfMdcBX8xP4rJWUwe it04biVl9fmSbp27SiqwkOyzSiXCFUBJISeUp4Rb3GQwq0rYEti+XcTg7qt/h03htiibnwdln00 VyizOzcUPjp6bIF8wfvjCM1F8MfoqOcJzLTicMpw9Uw/hyKXDKZ3nha55SS/EMpSVRnJmDt3IKa 4= X-Gm-Gg: ATEYQzzoTY2O6OKxaO5Jwlhv87PwtFyqrKlBxdXDMfDzqvuNiEcFUtVmnvH0u2eSrkn dE6IQPY6Zjn/FHeyUx7GkqRWhg1BJObuZgbJHBfasaxNzYriEPsbEcF6awulSh5ph7br2vpPgAT 8rjPyD0WyjZ3aEWTWr8Az25JwWOnWN3n3xXBwqJr4Gy9tYaDLvcBMAAZiDGKwBzKguSr7kwlYRf 0lES9G/ULyB9493rySF/g82slA+TKXDhrc2mWSrZmEbCXlZKgE83Na8I4jQFwSy0G6BgdKJUSRH os0pQOYVHUdBEzIpHjd/9hKfMZcnRFmsuLBzTquGumNE+8KmCSTqHSL8Q9+BBLC7t0JNl9G6Xhb N6bB5JbSYlPKHgwjVlZZSON81fr8kaokSn/myvuy8TSjir42hxwtlTWjvWepfjYqN4cmV/FiRV8 gN7vnbAcWXOgdMYWgbCXmWPiHCzmGaDkUnUoY= X-Received: by 2002:a05:620a:4006:b0:8cb:b22c:90f8 with SMTP id af79cd13be357-8cd6d4d6990mr360807985a.49.1772815639188; Fri, 06 Mar 2026 08:47:19 -0800 (PST) X-Received: by 2002:a05:620a:4006:b0:8cb:b22c:90f8 with SMTP id af79cd13be357-8cd6d4d6990mr360802085a.49.1772815638621; Fri, 06 Mar 2026 08:47:18 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:17 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:09 +0200 Subject: [PATCH 03/24] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-3-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1000; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=u+vxmRBv/m3rH6HnQZVzi2jrY6vhcP5vRXG7as7GjtU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUM7N4X6eR3LGLFRjazm2xRzYWjDGnOlOJ8L ccvyHvadEuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDAAKCRCLPIo+Aiko 1Ue5B/4zIgy9Zf4+P1P63mxB7QHWRPliFAHhRZIEXrCrmgJjieALVXacknOmbc/IiOYz0eMz3/f 9EUgBlhlExw/5HFBhvwLN+/5SuD/TJL0LKkOB2o8b8cIqoIMOuw3BhEw3D88KqB7F9e/CXtZe30 bh/rKVOMnVqAXvb/jn2GMiaS4AtPKAj1biGmGV6fJPNlUEp3oWaRYG5CBrDXPvWnTfvinG5aSWv 1qkyoETRISyrvbroMgwWUuZMJKvPo0CPODkEZsHL1MycB9u5fvWIqgwqFnu4XBOV2Pvv9yKGnlq 6NFNGk7NIwtk+jSdVRv3kunq1dxVGgnIm7c472Stbw/fjKsb X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: IuTNSYdOMY_wgS-fW9qBfAWs9Qt6Srbf X-Proofpoint-ORIG-GUID: IuTNSYdOMY_wgS-fW9qBfAWs9Qt6Srbf X-Authority-Analysis: v=2.4 cv=G4wR0tk5 c=1 sm=1 tr=0 ts=69ab0518 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=UzRrU4X3WlmsSrSSq8kA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX1YxB+/8hRwBh idj70q9Sr3vnPO4tRnQbrjWvUzg4vL8Wygvf3PvvlUNYk8Ob52VVo5pR/AKXWNhkUdVHoawd/jq b4NO4+SGexp8XWeLJn/pFOWT3NnJxpAKIQdpIKhMpptD8C/rW+feD6HvXQP425OJq1/fn1701uw 4fnKfCNeNCj6qDs+75MSJKbiO9LoIyewz7s0HonBFgnwWUCSgkUCLI6V4pcgFB1kKPmPUlsmkLu jMGENoA60jGD45/6vT3o2ebhxqlzDZ4gEkgey0ygNJ+8fkb0cd6+LfZLQTkSmLVRVL9IUpPGNHY 3nLuUe2gwmJsno0K5F8JU4A6ZuWs1bfWH7NXts3EJ5mHHwXPNFEBVJNkLDHG5CYrq+VEP2MMSIe luXyrIqSlq+e+CwtGn9FbtTG400dNjENfxpjY9/prq4k9Pgc8o8UeSChTlxcQOJO/UzLxkcy7Or qAINDbmIHMVUq4evfAQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Define special helper returning version setting for MDSS and A8xx drivers. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- include/linux/soc/qcom/ubwc.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 319caed88775..8355ffe40f88 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -100,4 +100,20 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_= ubwc_cfg_data *cfg) return cfg->ubwc_swizzle; } =20 +static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *c= fg) +{ + if (cfg->ubwc_enc_version >=3D UBWC_6_0) + return 5; + if (cfg->ubwc_enc_version >=3D UBWC_5_0) + return 4; + if (cfg->ubwc_enc_version >=3D UBWC_4_3) + return 3; + if (cfg->ubwc_enc_version >=3D UBWC_4_0) + return 2; + if (cfg->ubwc_enc_version >=3D UBWC_3_0) + return 1; + + return 0; +} + #endif /* __QCOM_UBWC_H__ */ --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DCB14014BC for ; Fri, 6 Mar 2026 16:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815650; cv=none; b=NZiVjAgjECuvtpPCAU7dyI4JsGRip/c/rD0/foxYg3nDo7QHPbzjVswIbcvDlRGmcLYLeSo/KDCwXQevEwTRMlYRwie9W0GcSJMGfIL330Xbv9t0x1a2v0XNYxWqoLVEIqcFTqXlOTlktYTzdzKYVTAbqEPBdOzz+anXtlQMqOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815650; c=relaxed/simple; bh=gndBRl4Z4xRh4kFQivFGZ2SUW+Ocdg1Tl9bo+8948vQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ljzRjeT1e7cDmMw2KYk+N3cYHkaY9bsZZR7v40659Wv7PHHTiYTAgKbIFLut0KNWaquTzKMWYUOR/l5njmPRyif4sCEwQ9YLbSFopvvSBeJMHSBXX1/O4yEV8Z+2VPV8bx/c6jG/4FaNGYLMaDih723RIICs1c6m90Lo2CEvTJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AR/QBSVF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=escnOiou; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AR/QBSVF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="escnOiou" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr9DO550304 for ; Fri, 6 Mar 2026 16:47:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wdo2GXNLuey4il0IRDIYFRsck7+hcgeJ1IZK0URwteg=; b=AR/QBSVFwClPDB+4 l/HAexU3pYvX4cVToD+jpZAcP8E3/Mg+NmRwxxY2Nvr0GKlDs0R4ufepixHJ3JRN G6sYsWtKj5nWTKySjqFexMw9N4EzMl8d9Dp5PQi+g/a4H9YGNYUa8bazgaOwLuWU 5zWVjhOP6+xkt7mZmT19rcniO7drEKsFHUtwGrhXu3Ro/tyBPhAGlKt0MJe3iGlS NGlHw/oC7La/5Bgor/E0v8BYQc3CCZUGOXA0gU3U9P6iJocKbfPD/UkLexFAUK7V MBrlnFlaC2vHHeSglMFYLJ6NS+JWHcCZGQonpQnKWvS4LLKmFVys/SOT6giszHT0 0/JoLA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka66q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:22 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb4d191ef1so1258634585a.0 for ; Fri, 06 Mar 2026 08:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815641; x=1773420441; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wdo2GXNLuey4il0IRDIYFRsck7+hcgeJ1IZK0URwteg=; b=escnOiouLrU4TkG7p0qDXPjwkrqzAHzHl1KG4sZKxALzBhXAv5n1juONaf61/NPvF+ Xrn1ucBUEHIpD4nCdyhJA9xI4MIDtWkuOt2inNr0HoH3YJt5haYMj5LzNSjl+CGI79Bq BG98QmlCpbU6jP9hTVFKYKnhYKJiRxKM6mQGbVSxk2alULxWRR+NPuMDi8klxqp/umx6 mrIYKtUs507P6r4hDxkw4uRKPEkr1ecYYQrpA7k5sqgeox/ey6Ck6baJLWx0yC/My022 kC6kdhAEk0f27JLpBVmu3eITI6cBjitC0R6wUCRYv3MjN5m5DnNu47UKBN5qIode0vqO XrLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815641; x=1773420441; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wdo2GXNLuey4il0IRDIYFRsck7+hcgeJ1IZK0URwteg=; b=QPQHcHG+L9jhemzT9Lrs1cwrLL4xe8oD+6aMin9Liw9PXjc9MHj30Ix52Op3lRIiB6 CqjZCRzYYC2RA0JUf2zmQcfCEAHUSnN55sQdxeVClDAXColn0jRHcYClVhW7Y1R+Ndez Y67gsXbUVjuc3fx/vHoHqBPPoLZ3cUM9cfeBlK+FYIyWo2zNcNvjg2SZEeqsHmujSgBG wt5I3nR/tmHuk88SJVmuWi53NeEvZOLWQxcqteIJFPKSQzYLzzj5SOhRsRhFJCI5MWWU 7T25OoATZFQ77HMH9+XCOhF/IID3kqo3MRq50OAHEzxgi8Pj49aCHrRfwb7oXkrT1Fpb dAgQ== X-Forwarded-Encrypted: i=1; AJvYcCVjTg344c1IQgpDBUASwGQMGqT0mDs5RJg18amZEnSDXk47DOZeBbBVl7sTATEDRqH9fEiGgfQfvqHoo3U=@vger.kernel.org X-Gm-Message-State: AOJu0YwxS4cpIJJMlLIdgLLeKI1KMLl7Xwi29b5t0poZKfa3G6gCydsJ mXwqR12V3OGXrChUhVXJo5wPXk9U0eIhrqL/aOmjFLLHDMqxz2LHydvaF0U2qPs35eaRwQw+cic mSOB2ql+VKzWpCGHXUK0mtolxlvIdA2JyNqN0bBFU5j0Aqmibk86Gc2zmf5rZc0OmWPWUHOgJ2D A= X-Gm-Gg: ATEYQzx6LvzUTzIN/HkJiSk334e5DtNq9Tlmc66HRsfGRUcKgtm8cATHYyj2bFKIUBg rZu55FyiDlf1O3ISGoJbq8tdCoCaAWrjvGbk7uPmpHdvWHERMHsenzxUt95d6bjULBE4QBcJ9PL arwJG5i+5Su/w1+dvH4P9UYp4jE2YR8NjRPXa/Q1mBYrXD+/IeYXW2dPwkJk36LFyP9xXzfI7BH wJ02FwZITFNKZNZAYVYqhAcXd1lxth5JSHoD3xC+9u02nfxyI7D5s+uFqlmpQppw1Ibu/q/FDKJ Ija9Rjp5UgyUlxFA63R0+DwXTw/8h68Vv7UJ93b9kWYcOUntGwUxUi6nDI0NbCIQehzAarb6JwP el3NwCFW4IHUcK9CDS0iO/pU28fzhoIrpBJtDGkUzNCoNOuvjFPU7oM6jpLAxXb1z/Xwf4R71Zz O4dhTi38Yb7DOzeAirqCR/h2kPlSEDWLiV+2s= X-Received: by 2002:a05:620a:254b:b0:80e:3af7:7a0c with SMTP id af79cd13be357-8cd6d427f57mr320733985a.43.1772815641159; Fri, 06 Mar 2026 08:47:21 -0800 (PST) X-Received: by 2002:a05:620a:254b:b0:80e:3af7:7a0c with SMTP id af79cd13be357-8cd6d427f57mr320729785a.43.1772815640568; Fri, 06 Mar 2026 08:47:20 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:19 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:10 +0200 Subject: [PATCH 04/24] drm/msm/adreno: Trust the SSoT UBWC config Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-4-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5880; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=E5AQkqpaNuM1RXBAxJ/mn1wbVur7sOZpcfQb1l6t7DE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUNcrd3Clb2VbkETRm3VJ329lWcfofTbuf+R 8sNyI+pXsOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1epOCACPBE/Ez45bG59m+rxF+b7Y+dB+iiT1mwMky3RRe9bKHf+QAjNjEQgUpYb19T/GX2Q5v6W /E2LxY41xBx9FsTo8wfrPEEWJAYO6k9oNY7Te5BQStmhWBjARC5LiiBx4je2u5tV2R8WDYvymeZ 0idyRf3YdUvqHz//58i1PeeLLruv24bwZa2b9wzC4vEWNHtPVEdMkS+zxhHtNLHgd9lsASJG4O2 MvpWYQoUXvCwkZJtGpEhSNJqUupfGc/QVhXhFbhP7nWRfGQKvzo2YpZ1vCVEuHC17Yqr8NzJaqN SQ5llqmoB7a5fTZYVldyzMRYgW3nqKnAiCRCzRmQ2IyyrBL/ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX58EmfK4LTzqi 3sToOqFKMC2aRytZPwuSwz+1M8SS31rG8APSUAbdyT9eFZAS7yYYc0hETJc3WqCQnEkyWp+JIoj IL0SknG3vHFLYS6IIVCykEI+n9YSFdUiSNfqnWy7XdnJBHyOfzRUMWqDHPyuvphvqKD3tE1OCXu BLjn4wIuaYBRe0GqMi9YV+LF0cuY5myPg1zKb071sxud2BfBU+nVqrsCLLN5nPdERvql5GWXJF+ j0RB1xmbGl+bv4rG6mhq2xaF71CZ5L97IYnqzMFWGnLkmYQnEjAfyFqdp+iCdn4kBJ594UIigAO 1hBOF2uu5hGoE3FG1CliqbsW8lYg00VaszSQcgZ5zssG3DvlrURna9Vtwc3EAy4/vDkkxlrfNZS i3Ow2dTDifFqj1mG7n73E4JAEspEEUNHuCqlLSiMu0h2U/tH7irVbTwWSpq7WqPjpr3hi33UmK5 QiIj84MFayUBqZderAA== X-Proofpoint-ORIG-GUID: ObMYDUv9SRuMyC68YND5xOScwP6kpqQQ X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab051a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=IhcC-CrlSmvFA89tYH4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: ObMYDUv9SRuMyC68YND5xOScwP6kpqQQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 From: Konrad Dybcio Now that the highest_bank_bit value is retrieved from the running system and the global config has been part of the tree for a couple of releases, there is no reason to keep any hardcoded values inside the GPU driver. Get rid of them. Signed-off-by: Konrad Dybcio Reviewed-by: Rob Clark Reviewed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 11 ++--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 ++---------------------------= ---- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -- 3 files changed, 6 insertions(+), 92 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a5xx_gpu.c index ef9fd6171af7..513557741677 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -1727,7 +1727,6 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_devic= e *dev) struct msm_drm_private *priv =3D dev->dev_private; struct platform_device *pdev =3D priv->gpu_pdev; struct adreno_platform_config *config =3D pdev->dev.platform_data; - const struct qcom_ubwc_cfg_data *common_cfg; struct a5xx_gpu *a5xx_gpu =3D NULL; struct adreno_gpu *adreno_gpu; struct msm_gpu *gpu; @@ -1765,13 +1764,9 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_devi= ce *dev) a5xx_preempt_init(gpu); =20 /* Inherit the common config and make some necessary fixups */ - common_cfg =3D qcom_ubwc_config_get_data(); - if (IS_ERR(common_cfg)) - return ERR_CAST(common_cfg); - - /* Copy the data into the internal struct to drop the const qualifier (te= mporarily) */ - adreno_gpu->_ubwc_config =3D *common_cfg; - adreno_gpu->ubwc_config =3D &adreno_gpu->_ubwc_config; + adreno_gpu->ubwc_config =3D qcom_ubwc_config_get_data(); + if (IS_ERR(adreno_gpu->ubwc_config)) + return ERR_CAST(adreno_gpu->ubwc_config); =20 adreno_gpu->uche_trap_base =3D 0x0001ffffffff0000ull; =20 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index d6dfe6337bc3..6eca7888013b 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -729,82 +729,6 @@ static void a6xx_set_cp_protect(struct msm_gpu *gpu) gpu_write(gpu, REG_A6XX_CP_PROTECT(protect->count_max - 1), protect->regs= [i]); } =20 -static int a6xx_calc_ubwc_config(struct adreno_gpu *gpu) -{ - const struct qcom_ubwc_cfg_data *common_cfg; - struct qcom_ubwc_cfg_data *cfg =3D &gpu->_ubwc_config; - - /* Inherit the common config and make some necessary fixups */ - common_cfg =3D qcom_ubwc_config_get_data(); - if (IS_ERR(common_cfg)) - return PTR_ERR(common_cfg); - - /* Copy the data into the internal struct to drop the const qualifier (te= mporarily) */ - *cfg =3D *common_cfg; - - /* Use common config as is for A8x */ - if (!adreno_is_a8xx(gpu)) { - cfg->ubwc_swizzle =3D 0x6; - cfg->highest_bank_bit =3D 15; - } - - if (adreno_is_a610(gpu)) { - cfg->highest_bank_bit =3D 13; - cfg->ubwc_swizzle =3D 0x7; - } - - if (adreno_is_a612(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a618(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a619(gpu)) - /* TODO: Should be 14 but causes corruption at e.g. 1920x1200 on DP */ - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a619_holi(gpu)) - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a621(gpu)) - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a623(gpu)) - cfg->highest_bank_bit =3D 16; - - if (adreno_is_a650(gpu) || - adreno_is_a660(gpu) || - adreno_is_a690(gpu) || - adreno_is_a730(gpu) || - adreno_is_a740_family(gpu)) { - /* TODO: get ddr type from bootloader and use 15 for LPDDR4 */ - cfg->highest_bank_bit =3D 16; - } - - if (adreno_is_a663(gpu)) { - cfg->highest_bank_bit =3D 13; - cfg->ubwc_swizzle =3D 0x4; - } - - if (adreno_is_7c3(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a702(gpu)) - cfg->highest_bank_bit =3D 14; - - if (cfg->highest_bank_bit !=3D common_cfg->highest_bank_bit) - DRM_WARN_ONCE("Inconclusive highest_bank_bit value: %u (GPU) vs %u (UBWC= _CFG)\n", - cfg->highest_bank_bit, common_cfg->highest_bank_bit); - - if (cfg->ubwc_swizzle !=3D common_cfg->ubwc_swizzle) - DRM_WARN_ONCE("Inconclusive ubwc_swizzle value: %u (GPU) vs %u (UBWC_CFG= )\n", - cfg->ubwc_swizzle, common_cfg->ubwc_swizzle); - - gpu->ubwc_config =3D &gpu->_ubwc_config; - - return 0; -} - static void a6xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); @@ -2721,10 +2645,10 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_dev= ice *dev) msm_mmu_set_fault_handler(to_msm_vm(gpu->vm)->mmu, gpu, adreno_gpu->funcs->mmu_fault_handler); =20 - ret =3D a6xx_calc_ubwc_config(adreno_gpu); - if (ret) { + adreno_gpu->ubwc_config =3D qcom_ubwc_config_get_data(); + if (IS_ERR(adreno_gpu->ubwc_config)) { a6xx_destroy(&(a6xx_gpu->base.base)); - return ERR_PTR(ret); + return ERR_CAST(adreno_gpu->ubwc_config); } =20 /* Set up the preemption specific bits and pieces for each ringbuffer */ diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/= adreno/adreno_gpu.h index 1d0145f8b3ec..da9a6da7c108 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -237,12 +237,7 @@ struct adreno_gpu { /* firmware: */ const struct firmware *fw[ADRENO_FW_MAX]; =20 - /* - * The migration to the central UBWC config db is still in flight - keep - * a copy containing some local fixups until that's done. - */ const struct qcom_ubwc_cfg_data *ubwc_config; - struct qcom_ubwc_cfg_data _ubwc_config; =20 /* * Register offsets are different between some GPUs. --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B1E41B344 for ; Fri, 6 Mar 2026 16:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815651; cv=none; b=En1ZK/Uwryc8jvr9vIEmsYJYyvrjIgNHdTEwhuTOrixrgRAhRSr1PTW7DXnOIX+iLCuNzcnk86xw8VFggiTgSaaHeJiLMIRmh/0s7K5qLgaxU0siESmLBm3PNEUhQZO1ZOJjVYKuLQ8VVfPUkweIUHkmQsv2iQzKin2JaJ7/r1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815651; c=relaxed/simple; bh=dSBWM2x+kwZjmcQFVewwgxBgzRu48ixGoJYbIjzhJjM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JMMQuy1l9BPz8q8/o5Az+WuOqZ34XCNlSosBTc++97lt/Vxd57p9N1fhzsvmzBgCanX+d0MMsvokDsuGeO+kodJYuIjnHwlnTPDXJ4fwmpDK5A4FRbDdwm88b2KpXDxlIlhQUta/n7Ocj++9fQ1kOQI3nXixl8IaoRZ3hR64Ke0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jQHU/CJH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DOFqjMGL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jQHU/CJH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DOFqjMGL" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr6f8079998 for ; Fri, 6 Mar 2026 16:47:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ylSabl4CClj6t/w9cxf3ZToG54oIITlqCJttWo/AVWg=; b=jQHU/CJHY5MIn6ZY aCSa4lqOAqgPrFoHJiZLiatiMeY3RG7EoVpygYZKTT+feeX0KHXAChnzoNtelO48 zbrLl1vLkjDaJLWiYYdI+RwCOF4DSXOTT5+IHLWeZt9vNxXGMTBu+F4Ou3Lz95rs Rt+7KUNev0Rtgr/aFoUFV0RdAbn83m4TfVPZ4NZ/6Y3hZnJzqW3qvZoSoXzzj51j geHtdb16JctMLyLShtDDoV2zpu3iQ4x+V4QKUt4uvBmIwa+PDxGtQdkD8b8C+I1I ZNLXNe4PS2eiEV/qGU5Iw4SYHnhspL/H+uSIVitmv0mgac5uYpEbnYmPQcsK4ZOZ +1IIpg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp43k6e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:23 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c71500f274so1017713385a.1 for ; Fri, 06 Mar 2026 08:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815643; x=1773420443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ylSabl4CClj6t/w9cxf3ZToG54oIITlqCJttWo/AVWg=; b=DOFqjMGL5V6eYkXjj8rNThXx8IobGA9gYsKJb6iQmQInvXCXAU65Nkcu44mj1fpRhJ LsakhUJokf6Hax4kaLz8ZME7C6V69fPuXCMMIyRLZpkG7kw8WmChdRD5oegt85s0QGzT c3tXwF6uc8nJlW6Wd6w5WrS8TaxKqJOHqzpESQ8MmF/z/fK3r+Ng2M6DuZM6vS7dtV65 5rQ1PxloBcxsPtjjKsWNDhfNMzEuTR+pcWI+ObufLeUqWujV9DBf3GW8WjqwZT26HDpL VU+THHaUMxYaALD7mfwk/x/4otRRpblVSENaXOD8jROmj2/AGuG7F1SkaKaTZeS4fBHt eLiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815643; x=1773420443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ylSabl4CClj6t/w9cxf3ZToG54oIITlqCJttWo/AVWg=; b=HLgmWDRTu2YBAArFmNilfhRyDlLvopCocNiIAhvNjgJFa1pFkHJq6Pw4UoHFQgFM2v tY1cB2k77M19NC6C0oPi/6Z3hdlTvi/X0heMG11ZzjXPpl2hiJUN+mR5GqN2ojTlW+VY UeEirJ+6Fa1nDwo2VXDe6c8e5Dh8KUfeqX4LJWtFEBbYWbo9gC8A7z3ud1IUhVutWNaN 5XgNwFHHBJmPnoCWwj0LQhX3LA4Wu39lHs3b2nFXD3xBBM2fY6RAB/s4pITP20VJ66kw lqoxWUb2VQUitkfSacWt/upFw2JR2Azq3BygavX691ZrCBFonOsDF3t+aWJUS5xW5uds s8NA== X-Forwarded-Encrypted: i=1; AJvYcCVJS51WneorCGQ77Dz1brVAJGw6fZkJN5Szuw0zDFTiDPuD+fFexLMzWDqAM9EjGhq8YUx5REZkSiLaPmQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwII0K79zXhfitd8wL8Q+QR5HbnrXivyF1xHPdTG3q3kHKDNa2w r1gNFtF9MVoDTI4EOFpp9HuImRevIU9CyHzYot/yNsoeTIdoAHTqfr99Py741TzGygqNUMUqhTU bE5J9DBzrN6gmTIkzKiDJxS/hSuQSYcPKE0kmtlzXvQhdWpFgniWK5L5jaslYcWptuswiwwoFch U= X-Gm-Gg: ATEYQzz+5sdaY+/dh3UAhMBAFp6nyk6s2LHArWlcTrFHcfRCr4JKwIa5LK+nUl1AfmU +XrLtjC243GT8ufO535SoHNvvCNAoKOyak6PVlWwPWajNUatS8DW1/6N6jrcOFxlU3D3B5QSLec BSeQmS6mGkFG/eCCGgqBOEf0YnkAdWvRWsEEiQSagiRbj5aEUEx2tx349GUQie5yqgbFnP0IpZx v4VgpUa0XLCs4grF/gk3CpDkLOyQ68oTWH2dKq3dNQL+iFOlK88lcKmjANy0CRNor54ZoTE41kp ytsFDFpZx9/sVfX7vpvXTvLdbl00PG3uDrDxbjCf4wmuudVLHuCxAFs66PKvlwCxQTe9MLsp6IS CSeV/WiLw/Zk74fTZnZD3gCm3i8WKhpuu0j7V4MxXE2h1yyGjkuXIcq5AYz78mhEOC/gq9YMgtW 24BAT+dYB8VcZ9uCOqUQ4BjViC+2kgbWT1wgo= X-Received: by 2002:a05:620a:46a6:b0:8cb:4ef2:f3b4 with SMTP id af79cd13be357-8cd6d48d6bdmr344382785a.73.1772815642592; Fri, 06 Mar 2026 08:47:22 -0800 (PST) X-Received: by 2002:a05:620a:46a6:b0:8cb:4ef2:f3b4 with SMTP id af79cd13be357-8cd6d48d6bdmr344378085a.73.1772815642060; Fri, 06 Mar 2026 08:47:22 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:21 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:11 +0200 Subject: [PATCH 05/24] drm/msm/adreno: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-5-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2867; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=dSBWM2x+kwZjmcQFVewwgxBgzRu48ixGoJYbIjzhJjM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUNAqeJoTbTsD3xfc25tA2JTYbYyry1SyyAB JBOvxzy/+KJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1Up4CACjWn/4ferCxCSGdGqQBb4i8bAXXaYWwL4r+o7o1tnvLZy9TM5DgjZtTw6j9wSifHZVjJQ KpB0lVk3zwj1ON9SsrFJ6HvaP5dKhfhCBShpUBLB//PBv/ho+l3htScn1PPfLY1jjb2nCEjAzE9 gwhanlPxIrIzvd2h0MxJhZ5dsQK7w0mGxrAY0TrvsiNzOVM76gd2ILAGl2rK2ZwnuYfVKiv4W8g BDhBVO5jiqVAkW8UI7PkdFFQUbCSKIo/NQ7HksoTxx1y61/Gba7feWW/PRgFNJqOSxT5ZqnTMwx VDurHEwjSuCaWkIwV1eur+Cdc/iv1KbnCIk9j1Y6gAT3JbmA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: ek8h-cuYS9rqHBjmPN8tINLTESgd57OO X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69ab051b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=QjZuzksZpR1x1fsoQ4cA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX0uh0wWGtjBoG P0aLJ8up+jiKMPg0ytFCdMhmIRqYppIwD9LD8+Fs303p2xS9CRZaCZLgMgFcjDRDE6LUhbyMn2K txVANEnQsqPgNbi1YJpzegsXznvjH/r4sso0zjqzqDYyb3i8NEfsauPLf7tIMwMqm7EYZrFXiWD dHN2FBgm8gnppCI4PBVDpnaeHAQA5fz6054B32h4qhYWJXSWAjM7lD+Vugzmi3+OEnhH2+y2hk7 k7bnLF3Zkq8jquvDWXdXPsSOCFw4GS6Lc2PlR57I9H6kSN+HpFEJqDLfXbzQWEzGAURgJRYl9E8 ZlC/B3yEyPnSzaZXTJL45J34rl5B08lOGdEz0aEBWCNjHy0gpZUnWv1Pa6WxUv6hWWTb1zAulT8 MaHpVBQVGpZSR9r2XRG6hUg/smT4aTvLaI0rpWABfef+33lAggWUPWsqZce2pHyy0SvaN16pvrt ZeBIuKnncCHP/jycyrw== X-Proofpoint-GUID: ek8h-cuYS9rqHBjmPN8tINLTESgd57OO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 8 +++----- drivers/gpu/drm/msm/msm_mdss.c | 16 +--------------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index b1887e0cf698..6dc1d81fcaeb 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -272,35 +272,33 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D false, amsbc =3D false; bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); u32 ubwc_version =3D cfg->ubwc_enc_version; - u32 hbb, hbb_hi, hbb_lo, mode =3D 1; + u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; - mode =3D 5; break; case UBWC_5_0: amsbc =3D true; rgb565_predicator =3D true; - mode =3D 4; break; case UBWC_4_0: amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; - mode =3D 2; break; case UBWC_3_0: amsbc =3D true; - mode =3D 1; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); break; } =20 + mode =3D qcom_ubwc_version_tag(cfg); + /* * We subtract 13 from the highest bank bit (13 is the minimum value * allowed by hw) and write the lowest two bits of the remaining value diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 9f81f43283b9..798a23fbc906 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -204,7 +204,7 @@ static void msm_mdss_setup_ubwc_v6(struct msm_mdss *msm= _mdss) const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -222,20 +222,6 @@ static void msm_mdss_setup_ubwc_v6(struct msm_mdss *ms= m_mdss) else prediction_mode =3D 1; =20 - if (data->ubwc_enc_version >=3D UBWC_6_0) - ver =3D 5; - else if (data->ubwc_enc_version >=3D UBWC_5_0) - ver =3D 4; - else if (data->ubwc_enc_version >=3D UBWC_4_3) - ver =3D 3; - else if (data->ubwc_enc_version >=3D UBWC_4_0) - ver =3D 2; - else if (data->ubwc_enc_version >=3D UBWC_3_0) - ver =3D 1; - else /* UBWC 1.0 and 2.0 */ - ver =3D 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED573B4EA4 for ; Fri, 6 Mar 2026 16:47:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815653; cv=none; b=t6MbXVEEfx0dOHbCFH/8F7wQ9HNRUCJc6R1NBOE4fT+aq6fp5UOpoiu3kTSET7NCsp4F8nBr3S+JFPJFnultbddEiUYeLsCRpy6gt+krmjSR9QdfLOp1QkRJBXbkHm5zf8TeptA6P2Sui0jCxM8PECFGIGVGagX6Cmv+9uiykS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815653; c=relaxed/simple; bh=vcRHbEAGLYLgXe4iaZftIzhetGkuS44tvnfyt/ZXY1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sYJFm4/svBo4cWtsMUkMMGLCithYAbTammLa9nGumOtgvYN/gvX9qibj1k9fwRfJrNxqgNV0GIrgx4OEoOKNO8ayIsqx9uoNwmQtj1AiQBGDoEnosj6PlgNeEx1/scaEt8YgZkdfUvJtr/QlY95staJMwKMQW6WMpNSOp6CiASM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lLFbSbs1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fTIyG7bM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lLFbSbs1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fTIyG7bM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr56D082635 for ; Fri, 6 Mar 2026 16:47:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=lLFbSbs1utfFOzhT MNqN4JdLQ/gvQYGAXTfaKD4P6yfbNcY9uzCf41ZsXgKMJadHItt83twX3qhbC8lf hUDsr8jEaGbGCSZZN6GJCTHR74h/854kMP0QlCWQsc67v3c3mOt5m6qP90seRu// CcuvZtP/pl8aQDOFhHA6UKUKX9om9xK57tUVkKiIbMXSQibzEqfnc33zllTz5sA0 p5SokMCIv5oq4+6bXYHaP/2Qb3V1zQrS5nVp1lPqdpqbHHaPGYsnAx3xm/sR67/j KJCEwpndr0mF8/jMvEMna3kO6ov4vv/B7FCKfFNgCivzVmJsI5PI0v5/h+4b0wNq kc/oEw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98hc05-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:26 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3fae6f60so6040584285a.1 for ; Fri, 06 Mar 2026 08:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815645; x=1773420445; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=fTIyG7bMI7yD+vUIT9Jw+eV+bm3K0F9W85SxCEgIaYic9X05ltT//IBQEL5U8f7sfW 8it+sAhpImUZZTPPuecJ9og1N9gqziY/a+qQzx1Z/XN86zTI4KWA3wxAkPFDj8Cpf9Qx s1UI4++xWvDU5IVp+2V3nWuoTF5JiQaRJnehuefJoWYDpym2o3epn0rE0s2EElX6GGUF rX9V/LXW/ibKhhGO7mGYi/DlcRlZVpiHrbvAIeJeD/kl0uDTTIyo2Dx9Cb5yEvd+XHDW IJsPBFFZo4DdcqGD24VTTr99mGOvR8AYCyLAV9y304NCWsBoVtwUOcOhtQimvVEg3ne3 7LTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815645; x=1773420445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=rVSN7Rrcf99bKxL9HYC5kxlS/pN3giyPenyEV0xsP4FEvxQ23DLHK9qKd+Vi9NnkMu PIeqbTlLU74n0TOUkDAqWNqEVhlYpN+e+sFs5oKVI/qSrq22LsB5EM9Pa09r32Tr7Ioz 3IZMWgXBWyCRO0pYEliGN851N2fq6rZgF+IscJ2GdrrHdx+0Gsw224zKG78iwtWv1WuN DkdOXffHN3QQOUOAht1XDE3BDUcBN1zvsZMjQ4tL5EH7mc918CYIbENJW7d6ZGrMc3KD qvUnWPpvTJgdfEutSEcMA/faK88ByFu4Ptwkxjjjqcp5sXBrpqHwpeDJkCc5MtgR+eP8 UrQg== X-Forwarded-Encrypted: i=1; AJvYcCV3hh7HJ2C7oM1eTuyx/1cBTsyL0KbEf9A7KoH1jCszE+Mfp5kvOKsKpCmS+dnUJNmpAatyGs54ylzvAfo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzemjj62hV6mPB/8xQ0ICyClH0SsvxkJ0YV1VDdCjdvHOEXopDj 7IB5DjoUINNoshWJJZ9y/WTFYvM2t7VDkOXL4CEDCDdhDPn30luE/X/pVnMxCQT68yrGnFoV8MN abqNgx+vV4YazvU0VyDT+XGhGQIRir0Sp59x6I/HifLblS/7tFbhcHVR1p5BRNxZ1z+Vv9cdohT 4= X-Gm-Gg: ATEYQzyHitnDeXBD5xzW0MvDOgcOkJhkknzKMKZo33C5qw/RzQ/k7AfMtMl5Zw+AGbN A83RaE0MUtbItpudsTD7KABpBda2R89QBCmvcovtn30ZVe/GyxnNM29M7dvM6D/XeOMk4MfEIXN mNt+zCOeGiTvuw4qIuh2tBNAl/JSNc3YB2Wa1F0kX4QHWaqdj2otjL/PK0zZngpFbz9eH77Xedn +/Eqpv2r+skZ3jCLR7CraBaMO8uX6MKGPDGstESwKTdOT2cZDpai0snNm8eR/OgYiTv14BfNLcH mg8x/YrmichdcjEMnSCpRODmVne1LojN5T4ilyIhMg2kbvufETrH1tl+I0/2NB+ET1nX01P4m8Z EgLv3l1layFnkziw2xx+SdKOCu+TIOqxHFBN/F20lWKkzqL8OggFHhME1YOn2PWfT8ga43drjb9 4Yohsr/J59YNzihqpjbt6n5N2FIGC6poIBVm4= X-Received: by 2002:a05:620a:199b:b0:8cb:5566:c947 with SMTP id af79cd13be357-8cd6343c5cemr797013485a.17.1772815645250; Fri, 06 Mar 2026 08:47:25 -0800 (PST) X-Received: by 2002:a05:620a:199b:b0:8cb:5566:c947 with SMTP id af79cd13be357-8cd6343c5cemr797009685a.17.1772815644753; Fri, 06 Mar 2026 08:47:24 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:23 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:12 +0200 Subject: [PATCH 06/24] drm/msm/adreno: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-6-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1349; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vcRHbEAGLYLgXe4iaZftIzhetGkuS44tvnfyt/ZXY1c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUN0M51LuLgAx3YyuCL48phbnK5fMROS9qi1 euBp6KEcTmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1WJlB/9Oz7JEzX3QKA7BjY8IyUp2+2tsRDo2zVU5FKUVwpGc9iyqGM4h3U1PlrmwvgX3DV0dVvh CV2xUDKSOESWI0vMmSyFDF8wMGMcfZdHX868x5tsU90+PDmp5lhO74oXF49f6a2Gz08a9hoXMI/ LLTSoslChzkN0lGLVH8rRiQRvBztGeiyt5FtXit2+diGGo7K29j8LlYymUZ1/ZO5+pqSe0vFEq2 JenIZic/ODA7a1FXTiS1gWaRZQWnge2646sghNpqP56COCqOe6L/TiRPD6WbMhImm8TbuZvxxhp jSebVtaT4XqFmziMacklq7vcn2lzi/g2/5QvYZYrc2wbP+ix X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: GCR50OilDZGs_-fzKtnBB1AWxAaoQ8LT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXx7hyoVDvHvVN 98KTgFGr6nN9b93g+Wg/ZSAAfAZ+A8qFmO2N3MXjYhcUG5oL9LCFAxbig976unc7squCFuh56Yk NvU0y159T7CZs9xFzUGmDH59uaUI93HU4U9d5y8zpInwMM7eL6GNivYfKjnSWutC/1b821JL7lj XNNkCkjTcThVijZWGtJIS50TVnGhnMjMb7e8xi4aEcFxlnBl3lPKlsRGZwrTSJzN6Eud/pFVQkR NUkmhrNzrzNtt8Hypz/XiRVfH/YBuZDW1tWBfRINGiwXSDiQoJEzmrKhPFv9PIJ5VolMU7wWwYJ 5T80DYNdLcBNcVpn8xtwPmJFtqMUvhL3CO5Gm+Y5yXK6OwYERrBZ1RpQu/UF71plwEHSwDSkd9W 0TwroOeNcChs974e3oCCoY+t7WguEf2lW9nqSiAsUNFjdkzgWnhjVbj5r7f1xjulhnxP+czGucs XOH+r+2KQ45qmTAI0Sg== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69ab051e cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: GCR50OilDZGs_-fzKtnBB1AWxAaoQ8LT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 6eca7888013b..2027e479d5b1 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -744,7 +744,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; - bool min_acc_len_64b =3D false; + bool min_acc_len_64b; u8 uavflagprd_inv =3D 0; u32 hbb_hi =3D hbb >> 2; u32 hbb_lo =3D hbb & 3; @@ -752,8 +752,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) if (adreno_is_a650_family(adreno_gpu) || adreno_is_a7xx(adreno_gpu)) uavflagprd_inv =3D 2; =20 - if (adreno_is_a610(adreno_gpu) || adreno_is_a702(adreno_gpu)) - min_acc_len_64b =3D true; + min_acc_len_64b =3D qcom_ubwc_min_acc_length_64b(cfg); =20 gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL, level2_swizzling_dis << 12 | --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174B9410D2F for ; Fri, 6 Mar 2026 16:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815654; cv=none; b=KnyvUyJzxUiz721UKotCxCEyZenSi6FIb5d+VwjQAs0utJYnjeWoLrqh1ggKyTK0IdDgAdyO+GIGbsZKgFYuugdG+WeqagmhjiOH8enC5oCr4sMXlFCc//P9dSvUY8pR6xXa70zMakftFm+bJofsp+NmdntJbUP7RdaRjsCVMoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815654; c=relaxed/simple; bh=jfhtlunzk9GwTp//Me1L6mf+GhU7QSZw7jcsDFdN4VI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ORoW/yJ6oVYkWH6s619Ehx70GCrHU40aK0xpTGcsS4790gAhtZU1AN+r1VZDsz853V7rExXjYrudQKBXMF2Fp03Jl4Uvj075STpEovUaYFMS7YblXaiPxcf2RUvVpdrpXF2FT+yI8fBZjRcIQXG4E53e/okIh7whaD/lz+YqnPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UgXDXmIx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cB5EuwdB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UgXDXmIx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cB5EuwdB" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrQ692008935 for ; Fri, 6 Mar 2026 16:47:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tJzrziKqS66K8BTFV7yRFO0U3JoxSa5Zc+pCmKaMPzQ=; b=UgXDXmIxS0HdjyD7 y+NlaWZQ1s3gc+g591ESMTwKb598rpvC2HRitDqRmzUydFY2/29N8BXtxITMPGep 2I+CclEvBA8c9SNd9Si4LiN/VlKFoEbqwx6tesc+pZOsWxszr/VSaHKDtzcF9z4J RtCLM8LK2HjQJGFJbHFIJOtgAWYtKUjkZMjyhuHzksEqApBdifKSJwqY+nj5KcXj osSoRTlShdlZzAbhUpl7crxZk0XWDpRD+dLYFtpC0awcCuVsajZ8kntv8YPIg/3c WGtew1duxsckLmJq1xw55Hw0CkW6OYmwLCIWo1GdQqfhFytEYotfQqOkwTAzpM8S LhGIOA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv9ahcjs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:27 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c71500f274so1017720385a.1 for ; Fri, 06 Mar 2026 08:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815647; x=1773420447; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tJzrziKqS66K8BTFV7yRFO0U3JoxSa5Zc+pCmKaMPzQ=; b=cB5EuwdB3zuPd/u4YNXBXwn+ASrc4YzYGJ3u6JDEHrDo3+rdzJns5W7Bf0aZyWRFjD wjCwoJh8/oKexd09Z2EG8U84yj25qwNOctco1tV3vjyeR5tmut1FOPq/bIO9RJmp4Hq1 mMvjSjiliGCBif1fBlIdR4cg3O0JHUycBDNtlvqiGi9GW1/88xwxiczlav92sram7rb6 9EeN/4FJALh9IhfgBpeN61CbslSAcIFVFJ4EXc60cWngErSoxL9zYEPrkBwHrXKBmAGV BPb3+298bL4Oc62nxUmKXYH2gYY7AY6jSdDJMEwitsapLGCw5O86g1rHKJMfS6AMV9X0 SWxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815647; x=1773420447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tJzrziKqS66K8BTFV7yRFO0U3JoxSa5Zc+pCmKaMPzQ=; b=inh58wHW5DtWiF3BoHDMY78bZ9AT/idCosSpMILTi7bSVE2EVlaQqibhOoTwMpog8Q 2PzsS5Y7gMpffWgLBsveTm08vwurPCpZvqWSdMGBhtfMxtB5TykVcND5OO6wA16cfUGs 4wIvrqnnn3+5CKs1v1ieARxoYxU/0dw72hypnTTy+t0qWL6zzBYEwziQhNF3yyKEKGRm lsUaDstyZMCymsFCztQkor0OWu4qZza0nP2AormhP3lgCg/eL/E079j55oNXrxXqrn9U xMiZr2eoW7Pigg17Wcee5Whc0b1WZN0xxq8BB7q23EfdWHykoiQ2h51LH2ZS2glX56Ck +svg== X-Forwarded-Encrypted: i=1; AJvYcCWh0pUVZDu7K8vVumw//e+bdEfd+Ee4M85hLCST1FcTXQD3nHTVrL87Ih1u6/g7Q8SEXR4Mg6+Le3zoW6s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2lZraX3ksBuVDyNQ8pWxDF7LgXa6qYCMDXoYxATKmqIKER64q Bv2Yk2jayPrjYC3qdJsEkkZcoGZD6QhqjPSFXRcHQn4C+jqIjz+qjVXAOvKF35L9ZgSmKzt+MzW vsSilHnKv1vfc87/nUNc90tMh8b8hAbUxH2eqndOEBysx54LjcAyxhaF4edpAdtVFjUY2QBgMX3 o= X-Gm-Gg: ATEYQzw3YKTyFXhBzmp02pvYmcZL3kj7mMRKHkKn8lhXZ92DgePx/2trR8++Y1NA3tH B/5/M5It28QNjdoJ+TWh4LFX8wCKoIyWDEcVjcsmIpmgmAj7dkqey2VDrVlRTkdLYhJgcJAU23T SJxw151OohPN/mUkp5Ljfh1Dxf0ytRSypIT9wdEV51aCKPZqNm7HZJ8AKNmaQ5JZDPcANbuEJr4 lQbiWw5K5axmbDmO4DwUfmYhgucs4Yalu1sNGJSTabo8mvfdVZWjOixSxOEdr9JRV2vgeeZeMPy +VjIoNr7bh8ZA0T0iA0IQ/mbFWSJDl6g9en5UGL20u5fzT8d+LAXNOQc1KEyT/ncx7/Q6WTyGAs b4+lysJvFePa0atpbf60V5KZU/SgTZ4W94bfjcw0j1dsrZMiUm72UTdJrXyAPm+aGPBIP1K296t 2yQh/Va39Eb5bXFlFU1tCNdb+jAu3ZT1xo+zY= X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr346106185a.6.1772815646794; Fri, 06 Mar 2026 08:47:26 -0800 (PST) X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr346101485a.6.1772815646235; Fri, 06 Mar 2026 08:47:26 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:25 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:13 +0200 Subject: [PATCH 07/24] drm/msm/mdss: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-7-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1420; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jfhtlunzk9GwTp//Me1L6mf+GhU7QSZw7jcsDFdN4VI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUNlQJZkBObTPhQ9Zlm0bWm4Fh06JPeRJhSf /dUM7IqdyOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1dqPB/43amVQBWWwwVe5xbDNn6w9ZozH9OsgFmzp4BgoeO0swcs8jgDuNpU2qDRl++Iw17k7dB3 PwRY0MLxk0C1p9uCnJgLUUHvOkVR5r04JLSOa8wVEhdtJ2TaX1ildgcrGv+gPHajDVq9pV4sgOK WlV1TjETXKWGnM1usLnGCVQey/xVtSn84DcYEaGi2sTnuBIuEzfu9p0/+7F0gZT+d1x9wKwy1QY DA7NNKqdL+Xglw+F0ZMuHcmhsHSJXnz+nVckTbbDpSNLwTdP1F7Aa/tIeiPdogDGArGGqAkvNhI nvXBFUiFTevcuEKfPkRDVLPU68kuiGJQgrEN621haTpd3THw X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: bGxVvAcgn24bhPbQkazq35pY4hLYJeIZ X-Proofpoint-ORIG-GUID: bGxVvAcgn24bhPbQkazq35pY4hLYJeIZ X-Authority-Analysis: v=2.4 cv=G4wR0tk5 c=1 sm=1 tr=0 ts=69ab051f cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX6v45WimNPpE0 XvasOt53QneNegHayvqZM9jLzZ+K5gut/GZZOBKvSAkm6fFa/N+2R9Y/kcyAgWaXSqLUOiLi9Wa VDVWroxH5XTeXS30mAA8LTEGamDsv8Wv3oJp52+ivdcuw9HJcHaym5fcPsn7qoMhWzy+9bmgFg/ IqeSigD0UwwERul10s+b5LMPuZsuPNIG/BKbsbIVPU8o4zidmLblJRABPxKYnT5h8vzverlJ65H okF3eqzqHbnNGB4dNAusL4ieKoTkhG13MYIzbcYGBs7BER9z9h57govuoKhxDJRCxAQlKZeU6N+ 25zkxh2pGMOlsX5wTsRCHv56xLU7h7eIeE0BhQYY1HWM93ciAcdgkdaWh0uinDsbYrlTu+Ejvc6 uugyy5/UyztOz/+fH/wx3A8huflrWhnXB5uCX9NzjN5uacuymJpr40uleb3FDGUoIMVaLHZS9Ox 5JWUWSj1g8cUc7gMG7g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 798a23fbc906..16bc9589f696 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_setup_ubwc_v4(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -193,8 +192,7 @@ static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm= _mdss) if (data->ubwc_enc_version =3D=3D UBWC_3_0) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B35FF41C0BF for ; Fri, 6 Mar 2026 16:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815657; cv=none; b=jy+Dl6bIUO1gs2GRzn9kccuq/9LfomL7iocaZ7Ssr2XfmHs877guwhu6Zz2EP+UZGW0okpc6nEs8PXIXsFyTDga0yF+gMUuCtnglZgZ+i9jTtY8HqgSoMtftnS9iEzokl5XZ5f1rmjhxm0+mDmGIQU79r6d7qQWLul0uYaDRlvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815657; c=relaxed/simple; bh=2pmZHdByL6nsS8Ik/InzKdBxSCO/78Oop/N0tOJ6bIw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gFzH2+9dKLryhlMcwOWFakzDlHxWWAytEBmWCtyz9TpFIS/2dikCSCyhdQwotZqOc0GcCuOvHO5jB/Xm+jdJ20D6IA8jKucbqgqJTne7LRi1vYzhf95eXgZrAVQg881yFa5Ih92Bzwxce9lQCcjkZuMNJq5tMC+Y2vujDXUzp/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YT1MJ58+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AFsSOE0v; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YT1MJ58+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AFsSOE0v" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr5Gd1424358 for ; Fri, 6 Mar 2026 16:47:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2imLQEZ3DP0uNNL0l/EieMjW7GOO6W8UDPQGg+15sw8=; b=YT1MJ58+zS/vxieL iQToHMG6NFJ7+kvIo5dasQKgmMzRg//1iAV+FAm+/iMgLQKJ1Uk909c/QKTzH9sN JhkDTO1nxVAx23B5XgGqSDvzYQZvzSZGfQ/y312ohYTjtOy654y4ww3zxaDRbhVq LQvLJDVeRfSnjT9OY/57cnGjdU+ZCu4tqltF0jLho9PFBzkc756zElueWOLoTmfi Rr73VKW5qY3qyiWOBr2CvEPMWAKhVXkb9HqgSa8moUloE589Egwpk7phuCsYomk/ JxnUF96Of8zvS05q5ePWpVCE/3YsKURQktRR8MyTolcn/vSfZzJThJXzWIoBw2pH EO3LXw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqrf5t7wq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:29 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb403842b6so5878297185a.1 for ; Fri, 06 Mar 2026 08:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815648; x=1773420448; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2imLQEZ3DP0uNNL0l/EieMjW7GOO6W8UDPQGg+15sw8=; b=AFsSOE0vJmgW6nLYyaN9d9d9uIvNMZ7phuK1Q7n9efpnpdxf38UiLAiHiJ1YYhKh7k 4Frm/b+owocS/zFa1yvWw6Z1X5l7oOmZEegahtOrIknncpaMq72oXuJbDxEUd/qiFdWt Ke61IkJo7e3M2YZcxxjIS6szbijzjMl3wQgrqETGJbL8++L2oxp1rTFUnjRs4WNt5D0L as9hd0JxwzSGZuE1npsMkNQFsHuJQ1GB/nKOpDH8vsLbLa86JkyYtvid1fIdOI9EerzA F1pVD0rtcobTHpISuqubH3qfA0EVBgJ2D3BkQDv8HEZMGkbvHLCN7hgMVcMe7bdPmOcw BdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815648; x=1773420448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2imLQEZ3DP0uNNL0l/EieMjW7GOO6W8UDPQGg+15sw8=; b=VVzUFDhDpq09hpj3p+qqpPOrcV5d6csRJFZcxvm7wTRg63EYW+rLk9Ih3xn+q5Sgqs qtItXqmGmluXAUecfyqcQgVOGCqAPb3uRJtlulFhGR6tmVxjyx4P4AGLAJnKeVZgxnAm b+7i60vEWqpBuGe3p8Y/PxTPGH6lIT4QA/psU7GdehbfLThL7C94gd3UWUYKkmWzXc2r 99FzVcCnt/GcB+SmjNNeApMcrMQruyYEMCR90h15oIZbP9bfaXQ11/paLLkTEKX/NPIS c/PA6QMa1beA9JFxluOv3RKBQl3uJ9MbzjWZZnyuajiZnL99fnMqiewgh0qiPYsLyc6w enkw== X-Forwarded-Encrypted: i=1; AJvYcCVhXD43a1S/imubxobsODBEU7d6Aaw+qoEZN8b4SLfZBFS+fomoX5eltKdVM4CunsqlXmLzNHA6a32+52s=@vger.kernel.org X-Gm-Message-State: AOJu0YyjFJhNanKCXOGj+q+0yyVWGrocGrf/d8ElkW5cfegxhDAUbkkK fGnjsnuE784//7SGyOWGSVOrucpzWqJJc6GtcgilgtSZl39pKf10YUPRKYzoikxYGpCRBXuXCmN QFeSNyFK2ch4QZifdiaOvK+u70ir3ReNI/olWQgHqhrFP4uWBfEZWatYpeaUAW92mSUjcNChTOl U= X-Gm-Gg: ATEYQzxHze45UmyZBiOnKA4IdTdhd4b7kp7cxDRxjPWiUoNB0wlNTqs+MrwDkDxBfC9 C42+GmZe5OvFrhb6QWRM6GgReC7zoV9/Qa4L4teAEpOCbNXDixpo4KyUnu0Iqt8FouooQ+884Z2 4lzGhK9l+DxGCHlCg7HnsPf2nuCfYj1rghHouVnELkY0tl6K9FFmgbQcAs2gx7Tog2hPoEq73K9 jaxo0apmDMRclQJ64FjVbW/eil3Vjgzt6Hb+pocYOWU5Q1vbOkVJlVNdnOCyRCD/YSZRjz/YI8Q XU4O6RQd4lULmEskYE5wT2oCS3zBJzn3yEu9uzCRX997GoBzgCFmOx/bfcw3W4zojmjV3YZwPVw kgPwNWJMtS4jMHEuE3aJwIMWRJccTf7omXEmKjJXy75SeCHN4zq0dhYK4CjNtjQrigcZQ0ry84C TYTWhTflcUzqu6GkYBV2dORq591p1BpV0/4fo= X-Received: by 2002:a05:620a:1a9b:b0:8cb:4c23:3de2 with SMTP id af79cd13be357-8cd6d4fc41amr337642485a.76.1772815648308; Fri, 06 Mar 2026 08:47:28 -0800 (PST) X-Received: by 2002:a05:620a:1a9b:b0:8cb:4c23:3de2 with SMTP id af79cd13be357-8cd6d4fc41amr337638085a.76.1772815647750; Fri, 06 Mar 2026 08:47:27 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:26 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:14 +0200 Subject: [PATCH 08/24] drm/msm/adreno: use new helper to set macrotile_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-8-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1533; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=2pmZHdByL6nsS8Ik/InzKdBxSCO/78Oop/N0tOJ6bIw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUN3jF8qXyArrCcHGzumnoU/rLkRvcjzIeeW u3qt/YDcJKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1Y7oB/kBzsVGYGRPO8u6SXF9W5IddIs+b2Kkr6+hZ2mQBAry76g7CM7RK16IvDydZ5Oz0QWS2co F4m6FvQpl9umm6E5jdlKnyWijC6NERW46twWfyKw5Za7W14lI/dvgJEtUJzni/tVTfoBAFj79lb 0/tbqV9/co5GDj9wmVKJXOPOPgezW7ZqPWsAC84yIfifeoXnm2s6MtO1iCIK62ai2Fhbo0oeeke rwJz2JaxIe5xch9IztaFL7uo6SXBkoHQcqiDol+v9AThjfxel1nZcoqUos+8nuV3CU1IRRETm1M OSy0rXgqC6Kn5y6PfOuSaswu34+aYvBWPDJam3SpRRs8yslg X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: Eaib1JFvfhPUUFOSyWTV5Bp6W36bTDMy X-Proofpoint-GUID: Eaib1JFvfhPUUFOSyWTV5Bp6W36bTDMy X-Authority-Analysis: v=2.4 cv=L+oQguT8 c=1 sm=1 tr=0 ts=69ab0521 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=8BxV0iZMnHvn5dZpj2MA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX98cK9hMHYD7o iSEUyyzxM+UpbAVo7avb0lYPS4NI1xVgrXhZOY4KhkdmA0iTxN4JGvngXZPT7SjFO9kzjW02umu hKB7S/5vXyeWi4QgTvfEDZ3p01uuTif1+Tnu+vWeU3K6pRFWkKUCiukt3GCTyMje5/EKkLdgbjx Q3Czm969Hq/DkwahWtq+SSJdVc39NNoSIJxnRg3uPtAkrtjvBAGDg0XXjt0IhWtXyj7I7SQ5Bwx /3Xx7gmqRUb99iy8UGs9Phr+iVCRwRhVIpjR3w1JFW0RwRTlEypLmwxme5afSGF0g1Rn1W2xF1F OEElwGblYBx5XUai9guXP/FkJLuUzePciVGWMe5h0DgL6iYc8ran+2sVi+jMwrR40B+TbitaSI4 lqkE7nJ4myKY81Ij/P+LlMdswpFQ83ptdnv/JIBIaxCwrYS2O2bBJ0IEOiL/AktGVkx77ceMlIw Ldx6u76+YUbwj+SA5Sw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 2027e479d5b1..56a820ffa613 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -787,7 +787,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) min_acc_len_64b << 23 | hbb_lo << 21); =20 gpu_write(gpu, REG_A6XX_RBBM_NC_MODE_CNTL, - cfg->macrotile_mode); + qcom_ubwc_macrotile_mode(cfg)); } =20 static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index d5fe6f6f0dec..4814233d8dba 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -435,7 +435,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; return 0; case MSM_PARAM_MACROTILE_MODE: - *value =3D adreno_gpu->ubwc_config->macrotile_mode; + *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_UCHE_TRAP_BASE: *value =3D adreno_gpu->uche_trap_base; --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C2E41C2FA for ; Fri, 6 Mar 2026 16:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815658; cv=none; b=UUxelAKdJjWOlZ1bin7qJr1c0VoA7PoQyRqeZ0SaG/0N38GoxBEQvDqnehmPEI/83kSZ0t13D3WkDOBY0Wj0ntmTmLTjA5nXoFtlcfJ6q7qq4bcbc1MiYVZ9m3in045jFZmP8hN6KoQrbyAFTvBRlTC7KV95hieqGIzKKzJkSjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815658; c=relaxed/simple; bh=cNUVi8GGg8ORsbdj0ijaFrB7Eb4PIC5uP3bKn2pf2xk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QBUqdOyaEd4RGTMNksc2dqkI6j/g/GbNhhnuefvxeaHZ5EfrzNWF4c13lyJx+5GsgTOiKeRD2VonFb/3QdbrRSwHLC96CZ3LlnV42sTDDwUcc49BIw9bTicS85wcnb5h1Q3URnoZfQ3jrt1Vk7LSfaW6KrLowfwysPPlHSEc6Ik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YPKou1Ck; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GdcBwZre; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YPKou1Ck"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GdcBwZre" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr27M550043 for ; Fri, 6 Mar 2026 16:47:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3wMwGrhT+6wGV+QqWZ3abUAX5y5DEnILFWoqJJJ8JfA=; b=YPKou1CkHJyybE9A 5jcuN9qA22CrCflNrI4lc0quCx1cLiizxT/7tr29ZfN6gkEqzgyd/RG+gOSlvk/x BOPTydVfGa3wK5AHZqfdUgvgjARpQ79K44TsonjH468DxZvkbX2KmWbcAA008aeH 2pVCNH5Up/AmFDNrITTWqjrsDuWLV5X+8YV7m1SG8s0jZabKxPlmwB6ShC5w/DFs 2dOs+L9cmGtVo5v5sFNTIlhMsDOUP89i9xUCcM3uO7wut1Xjd03IvHgCyf43ZuD3 sEH/AG763dh7bBBInZ9LL/wpDcU16h7bVyDW+6RSHxmZsdAbxAxDaFxJ53Gq4Kf3 +XE5lQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka67x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:30 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8ca3ef536ddso2476092285a.0 for ; Fri, 06 Mar 2026 08:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815650; x=1773420450; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3wMwGrhT+6wGV+QqWZ3abUAX5y5DEnILFWoqJJJ8JfA=; b=GdcBwZrebwTGHEWEfubVhgg2CXSGl6VTfyXYxqno6v7eBBK0iC2Chgqg/q6QTAJPlb RqXgNJ7dgVqE/2AutRu0Kg7b6Gm1GbCgXSlNPbLkUyDtMbd0CLdPQqVWZ6gHbfGc1wxT qbtnyi9D+Umu9nAkMSUJjIAQXsWYxKnnozHnUslevbkWWjIynS3ufO5OZwMWl0fbPrpQ WfczcEfnQuDIqxrRrLP70wNybMtUkeVoM/PWLMmims6OghRhNpumqfNnIkm8eoXuZ6tx jbzblI6HSUFXAyarltLVcN8EnJqDJOKXy0oazTnzf4ihGvUwkJfI4oeOlni0qoQblcsb pRfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815650; x=1773420450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3wMwGrhT+6wGV+QqWZ3abUAX5y5DEnILFWoqJJJ8JfA=; b=RFiL/scfplgQqlnWc+P7dLawiqD2pKE12sTA9tCA5s4Q5xfE76EULRkc6gCXthNheG GuKNo3S0ro84IxtWDfpmgmfAp67kEndsqNrEQL7NQPeR3PXiMF/4pVzlWRlqdW8hHLkl tUc87BOxVi7GwoiI4uuagiIn2vzzLOjFbA7+rNGWd804G8hpW2sL6z4i3SBF0FuyYyfS 5OAGVJeFioUNo7kbYfnDw6YF805qD6gK13I62bxoZqRXau91/TU9YSxBHQuGeEkXHnEm Zr4eCPt16ssERj93LDrs4N+1GvPN40Tnc3zLiXODyA0U4GreKQ7B7tyQaxJW0zVDJdVV Cglg== X-Forwarded-Encrypted: i=1; AJvYcCXkp+OWCnxg7Q/0bc7N5O93vAxmLCIkAL5Q8EYv6bpJbV2d3Lpd8Elf6caWiP+z5QCjXNxTFA6JuLsGMuM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1tOK4J+5tPQpfoep45bo73+a6IHjU0zpRvjgQFtXooNDkjVMv D9XPF5Wnd2OEBdareMeDvOuNV0SnITJZWklpxQLyKjkyjJFqTG/Ff4I0k7sQATzDoqqvZkirWff yRLtuYOEEMrXtHJ+81IfaV+y9m0ep1wLWj7YOF5xSAPSXC1JBgxHs97Qaork3YccotNXI+YxdQ3 0= X-Gm-Gg: ATEYQzxURoo0l50ESabaueJrjkFh0/HugCRrE9PuUGSXPxI2XeucdwECi4zqmh1OLoU COGHlUS+ibaioYMBdn9B8sX6cGo0FzCC5AGolfYgftnENZ9alGSe1nU5hU+bokREn1FwzxyPBsI Q79mIuszTFvAokskovr3YvqoO5kX9CmiAYpAS0OgG0kGTljia+Tac9hB6W8B42EzSc+dJxIsEiw S0DDkJqv1nshrXyPx6Gz2/cEYUS6g955mEJjXDeQA2ktYwc8ftl8GPJ0pKty3i1Jdqp2tS770JG YwZ93Fm1wAry09m8XzsV+MKctqboE/THQFGy9lBfJOb1xjasLG7KUHJ0/TN0/LUQDhOptLdCBoX c73CIvsyBpPFYsdPlCzHebG6I3Qrc6PA4eFG81NSMF4scBRBfS9RGI/VkZ6AtSDCN7L67tqJoJ+ nJe0g9VDU5HquhKuzmun//84eOvJ0n/GK5Gjo= X-Received: by 2002:a05:620a:4044:b0:8c0:d16b:b0a7 with SMTP id af79cd13be357-8cd6d340439mr333987785a.2.1772815649875; Fri, 06 Mar 2026 08:47:29 -0800 (PST) X-Received: by 2002:a05:620a:4044:b0:8c0:d16b:b0a7 with SMTP id af79cd13be357-8cd6d340439mr333984785a.2.1772815649299; Fri, 06 Mar 2026 08:47:29 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:28 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:15 +0200 Subject: [PATCH 09/24] drm/msm/mdss: use new helper to set macrotile_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-9-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1170; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=cNUVi8GGg8ORsbdj0ijaFrB7Eb4PIC5uP3bKn2pf2xk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUNPNyiAskeVyt3JIkN4/qJnuZp3EfyQ2g39 P7v4Dt6EumJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1XG1CACMWskmpv/iNW23lzWv1mFDidXHoBto5XIAMA9A7lhfb/9RI5NBL5RgT4LQUs95Rih5S5j lh3wXtUZGipqRHeGt4P/rdhwQPefTZ/UFe7Wq/IB+DGeaHDTjqiFBhukQlN+vDPUD3yqt9TyQiQ bvKOeAPFl6E7uh2BHKp99b2/r0kYcESKOldbx+d6E27ZQB0Y+qH7CoGABKnOAXnwJ0HyOtSOSO3 IjfxihtojQCK/EZqI8pte2fbV85pVsgB7PXZ7X7ro7KYxKx/1EfAnv1Xl0ZbglA/mrOouZTAbGv mfz3wyuinPMzaKonkt+gbSZF2pIn0/b0ui1EPfwcj6zRYnnA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX9ilM2sBLXAGI IVRftSJmagLGeXT5GPIJxQ11HGb60ArCQowaoRmFKgt6f23F/ilk+RN9mAbOMr8/yyY9YYKQDgH C1gQVsx7KN4V7utDQrWYxRvvjU9mLS8X+vj6zu1aPfLkFoAPiqvgP3Up2LvbXh93puwfDZjPwOU 2fc83ZAiwScJHMmUXa5gsk2czxICiZkaZPG099KoDC+oSNMo0Ye2dTDmtW6qWIcvQZdoynR66R/ GcMoww4QzIsV8ux20YCPTc2Gr2hC6vYLd9h/RAd5sD4MeG9WSCKqTPCPNpuEqumqGQksRK9cbhX snO4ykPMNSQbulVuDbp5LPDpu9r6d3EEsoMLeF4gMtwXI2Iw2BzpgineQ81Q/EKt9Ild6fZogva P9tiEESIbi5FwyHAPScHbvZg30h5YKtr7mzh26Ni1CsO94uMBuVYE0BFE6mBEEbB7cuBmNJiUX3 Meo/Is7d+6EKkw8L6qg== X-Proofpoint-ORIG-GUID: fH22gXTlaPxOaJdzoQNRXLLPbGMUvoFa X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab0522 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=ujCctoy6CNRHcyqwK_8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: fH22gXTlaPxOaJdzoQNRXLLPbGMUvoFa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 16bc9589f696..41289606407a 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -186,7 +186,7 @@ static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm= _mdss) if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 - if (data->macrotile_mode) + if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 if (data->ubwc_enc_version =3D=3D UBWC_3_0) @@ -207,7 +207,7 @@ static void msm_mdss_setup_ubwc_v6(struct msm_mdss *msm= _mdss) if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 - if (data->macrotile_mode) + if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 if (data->ubwc_enc_version =3D=3D UBWC_1_0) --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01AAC41B35C for ; Fri, 6 Mar 2026 16:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815660; cv=none; b=XHnXv55rAJkNqnmQK4CoB9DNrjB64uC7GYfe22Isd1BGR9otaCjUZvMmebhOBBgYPh14Y1eQ6y1So9WSi2mvWO0giRRqJwZzNyzvnyxi7vMNUB4zfNzDmLjXTke1zomIau2YOD2QEGTPpegy3oBt9D/Cv9bETfRRvYNwGIPsQqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815660; c=relaxed/simple; bh=T4XlIf9sWC6G5eodtz3g7Nl/H7ebAymEe1iQ8N83kkg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gouqG7b1g4btuncJsWnaK5vGsEcaBZEA/Na20U39H7fMWAs4it926E5+yux5jsBDPS7gQRLp6jc3+C7i0mXqIeL7V5819gLCiIi1wPLKe93oI52e+K17YBKna23QpjzBIBkQydnXU189OvqQhcwymNsTOb7i+l8RI7R9q/aGnsw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SHyqn30/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ETtnqHtS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SHyqn30/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ETtnqHtS" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FqwUX549921 for ; Fri, 6 Mar 2026 16:47:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gmnFPJlHzxIIFhYmKoQungMgxWFw/K8lJH5qH0kO8lQ=; b=SHyqn30//lKMgHjk YbJvYJ4ll9vpAgyGxrgQNSXvNDSWaMUVX9IRRfmNNKHyNAEpA4OFXUaSfS0DiPYI ymFOZyRxXCQ9tkv0uIsYhQ1SFRSqEKEtqYGhuEk4pMmQCWiMUTQr8KD3NfcBGQ9X /DwkdMpy98DWXY4mNzNVwTOz28E3/rYRtP2BtenQOG48G4iy47sbrqM4QpvG/x4H qJyB68zyWfG8ja7EW1cGBAG2qTW8sSk3XbNskmFhyBHvn+Pe2P1KsLUMXdkdc5lW nwvMd4gQK6wJ2Zt7zBsVZgINpuENU0G9kCkRpp/+pNt+BW0YH/wa+aC2d/kQ95yX /+BKTg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka686-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:32 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb3ff05c73so4800176685a.0 for ; Fri, 06 Mar 2026 08:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815652; x=1773420452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gmnFPJlHzxIIFhYmKoQungMgxWFw/K8lJH5qH0kO8lQ=; b=ETtnqHtSqrIrUn8kIVLSM6GYbXT+oMk0xWBA7ZXyYkn+FEk1kCCDtrz8norlmyeL+P 3bOheLW4rE4pUV/rPSWqfMYZ+wQF1SxSWIuPTHZBQ86EQ0KcxXYFlT01kZz3vez6QOM8 QfE8lYK0aZPkJvZ7+4drhqppVNdFX0ZzulMcLFTG4OxKd0ply8Q5WJlt3Jbq7ALmWB2R kdeFt/Q+kNelLZ5g7NecX6peyDVe3SYkFS/Zd8DD88kaL5ANTZpjovM8abWWxiiVsqJI hKRtFG9PLoq2Isaujv2bpsZnwwyTnteQ4CSn6UQApbPqwIZ3+duD2xy/yZPB7tUDL8hk FlTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815652; x=1773420452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gmnFPJlHzxIIFhYmKoQungMgxWFw/K8lJH5qH0kO8lQ=; b=qIwoRmM/ExKTnlOw+CY/adH8WkdR7cbRYpWDd+SGdClYm0HkHkTmd4sdDJbuALxar4 IfiN+7GhgRRH8yIM0cfAvaC6wudQkpb26IutziSY0zhYDLAbBAngLgoPghQMa1ER5hL6 mPilJ2rFWBd5d+xZZRH8MG9KVi9Nxi+i0RzXYB+pxSBOSA+gxxCisaKfB0nBIYn5VHss gfrE06wJbGeB/Nz4Afw/j0PhYRCxo3WoQ4KH1QqCWH0gz2y3w8fc4477Xw2KhWm69OxQ zxOlBdO84RAvq07wPxoAtzp8DVsSqY0/F+Orkdwf88qFBkQwqtYw/QR2GP5dp19T4neL y1FQ== X-Forwarded-Encrypted: i=1; AJvYcCWU5vFVlm/fpNQ5zRzgppeL4kb8Hi/V1I0gO68NusiCC4Tt5MJOcAlVKW2FqdxanvcE5nimXC7vTywTmFs=@vger.kernel.org X-Gm-Message-State: AOJu0YySpJ7ktLa87WgFckPFkNT1hmAU7k1pxd7fBBzxFdMVcDlIYQqe UpA/KtlV7w/V7gTJPj/6DZ7VDRUCN8DJTWUTCYDfKR5MBMffievs8Wv1Of9vVul5ceDt5oeaVE9 8S4r0VyTV+qR8+Vl3HvaAQhSN3zhw1qr9rF14SyM96wOQBHr+7s+ebtA4Wpvb8ZhviBr+lAINyu E= X-Gm-Gg: ATEYQzzTWrSYvc9w9Qx+B7tczLsc1Gb2M/hYYxG+Yos26+vaAN8DSfXVT4ezfLnyrci d2COAF4PzIgq4SwCG/lM5tnNVcrOrfhMdaj3dfcHUURFbVBeouPwIc6ZyQ8FKkw2UhSvqU5dXmx rdxKgdnKFeDXvdWGtjL4IRoWjAtpy3PAaAWAppMzIFkIb+wlVQT8rQWiI3Lwshhd02Z2lIdOO/8 RcaKC+taCgIIDbTqg5Evm8lTvtfwYKpfdyghHi9NBxeCaVCF+gZmU7GhYFFWnr5jNuiDJgWxFKC Lpv2CNwnWuV1iSzZBKa9kl5siYCxlZtA50JGAAp75uVU1cRD80FIiOyY7i+WP/Jt2qeIf4Hq2Oe d+/6//FQaAuXOvJRa9+taydw1Tkn6hSVBcCxyG6qZyMWPZKHf3o9RCLZGdfswAva0HyR3vMSg4N sfOHeegT0q7zuHFeyhCWoDci8+aoayM2qNnNQ= X-Received: by 2002:a05:620a:f03:b0:8b2:d72d:e41c with SMTP id af79cd13be357-8cd6d3d9183mr369893585a.5.1772815651573; Fri, 06 Mar 2026 08:47:31 -0800 (PST) X-Received: by 2002:a05:620a:f03:b0:8b2:d72d:e41c with SMTP id af79cd13be357-8cd6d3d9183mr369888485a.5.1772815651062; Fri, 06 Mar 2026 08:47:31 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:29 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:16 +0200 Subject: [PATCH 10/24] drm/msm/mdss: use new helper to set UBWC bank spreading Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-10-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1239; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=T4XlIf9sWC6G5eodtz3g7Nl/H7ebAymEe1iQ8N83kkg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUOCroA14RUSjBXpDlMJpG4G9tbOzhXJ7jnX AHTxgYfdp+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1cCLB/sH5fdyjgJAnBqdlTRluLWUCiX+r9ZILouuB0tLMDmHwLENSLGdiFpafUBOnwRtvXV4sS/ 72MZ27DxVesz+OFeul+RrNQCrj6YomzTsVqIeWRrhmUulx/MlLuCrgyCTCSTBJYDVMRWPBJYaKb YILzDE9wkXQJf2puwhieUS7rZ9MfRAy2ZcwCwJczI0qRjyk4VJmEq/V9fQN9hTfeH0mfiwpaYcx uSwIQOU27/dhRM0QJgEcaqZQE5debAvAgCA9X/BdgFGByPzRxtdhJ9wA55scqELFuD0FHnpr7+Q zJ5/2s6mTr//sVQ9Um2aCrUz8D4Pq/f3DCPW0xHH4TQkz2aq X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX7JG7XvjAjL5L yPKagfB+K24iv9AHRJKucK8tP6e+1kTONsC6QLQ3H621IxmqSwNUC19LImOR06AbT1xp+W72iGP 41u765V7K5iOs3T7L9E+PfEBoJTmmKGHRF6jLPo1NPB295LurtNJ0vwXNKoftYhPXLTov5iFLkS mjwejMBBn3D9z7soUQpuV0OC0YGsRn3eTB+RnLQnm5tl6g/TV5P7lBRWI5xeWeZjn/4GhhvlgCm UBX4AFAIuSnNuYyq/sFF2OPz90tKEu45aYtNa/sFfLL1cLvP66jQymeeKllyd7yCsUAwhnK/y3H 6xWuodPEoIMzUQbBIJ5Gl6xenbE8u/enK/fAvvGVl4Og5x7hub5Etqq0dIuytyA4FbKe7hWR7na UPCQU+rOcR9wmzHtms8AgMczQJOsUG2ZLbeiwJiZ1HoB5d2/FAZNTQTHLG/g8kAGobF0BrpeWrf tq5pqhTXmhxDlU+Jo/Q== X-Proofpoint-ORIG-GUID: vaX3qU5kULmHxnW1d8tXAaCX8GxdJOYm X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab0524 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=ujCctoy6CNRHcyqwK_8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: vaX3qU5kULmHxnW1d8tXAaCX8GxdJOYm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 41289606407a..90a4b579776a 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -183,7 +183,7 @@ static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_bank_spread) + if (qcom_ubwc_bank_spread(data)) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 if (qcom_ubwc_macrotile_mode(data)) @@ -204,7 +204,7 @@ static void msm_mdss_setup_ubwc_v6(struct msm_mdss *msm= _mdss) MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 - if (data->ubwc_bank_spread) + if (qcom_ubwc_bank_spread(data)) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 if (qcom_ubwc_macrotile_mode(data)) --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26CBD421A06 for ; Fri, 6 Mar 2026 16:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815661; cv=none; b=JFFeVsp4z1hS+pRyw9sX2rFxRRNCIIVsfC7HeOJw1iBHCxT5+WunNdK0uRoXBs8UrMNto0GpfdqjQbs0ufROu8n51FGAQZruoByxTJr/ISLa5dsapZnX/bQ7hpm3GdwqtwDc21StUSVYeen1p1UQmxF2oieNrFAcCyUaJImyFy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815661; c=relaxed/simple; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uPjD6P+PUgZz0oAYNDWMxT+RUSaG5nopyWP9cB7P5tA/SnCVFZi3i6r4iJKZlyWjGA7Cus2DdfmE//dXHC1AA6NBmq7yBJSi9u0ZdbDI84L6Yb9nZNsgkwz40foTTyNjxaYopNukJ9+1X9PD7EXA2K9/tFbXG+c7tD1eXQ8R18Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cW81b1BY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=InMPEqcI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cW81b1BY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="InMPEqcI" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr8c9080007 for ; Fri, 6 Mar 2026 16:47:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=cW81b1BYiUy2ELXh BzCE03Hei4NK6Qkx+HQeA9DKgLOTIUxtVkBxK7kZfJta+IAfpVXG8JGltlc2wtrr LRdLoM0Xqq5Xl+89uqD3tOQuB1usfHWpVkfb6Npam0mkeJhkD2mJRmvoQab5jn0X VHlf0mYp62MCWcynvhLtQ/iYv8AHaeaaYBDBzIXWhvxS/DMj6YTtvCA4HsGuy8VH 9ENQIckaf1N5O0169V+6olSGSlT0DiJOIYLmwjqGmlSk4PvJWh7YgAj+jQ3ioQX0 XYeBkrhQ69FNtay535XQNpTqOU+gLBHwt8DnhEa02eRkZAb79/7mRzyfTzdT50MQ GD0GSQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp43k78-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb4d191ef1so1258668885a.0 for ; Fri, 06 Mar 2026 08:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815653; x=1773420453; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=InMPEqcI1qnsAxcpdv+zzmes3wvlAoJVNcQRA1vsD3exVfu/whEhYpO4ZNhnzMKGKn Km507mHT9pC2Vzn9g87LMnAVVOvq3/a2HX1dK8y699QW+6mxFtpCkrBTkkiNlVGoSwsy JJKNxgDoBpJWnXXX+iwUiziADgf+ds86uTQB5yl0qOza2SJ3iMEiodqKAuMgi0wu5mK+ P+wDh5b8zpOQoAuxk6OnCHyLK9m5oO+3mUr7YWBCjCgv1LFspe9TYm/rGzPo0U29BFlu nv0LYas//OhCjCWNi9X0uipnQBk/jc1lj1fSv9y1NWMIR6RfAjfS9A3GkgCCAm2aFNgh 2W7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815653; x=1773420453; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=AeDmGa5i1/uveoyrzua0KpLZw+cN9Wgobins8rQJTp2TCuPq1MgSn7TaO9PWhh+kPX +RehHC/FjmrOKdKZGamt93ERmteuF/QnIOu/7omnT7xBOJu/tEiA8Hn71Odrxnh3G7y5 01SZMeTL+8gsHJUCjpAJsIrQn/oziRPWyoaQ1eqn467FbgfJ81+c1eiYScUclmLt7yem aClSYkhNNovtQP70FOBcJycVIfagn/iLZHfy3xz9YtU6DG1Q0MsvxsMwFek51m4gES2v MqRGXnTLHIPd/hJ7er7lkqDwRtJ8ZL2R27c0EmOhmMGao9m+LWGp1cSj+IQ3lCM39vza 3NZg== X-Forwarded-Encrypted: i=1; AJvYcCWavD8CTGXf1fOj954O0vqJzbUtGs6BzVeCatK09GiPIYdodXjuCdqUTMDCqnfgtkXLkGnXGhz3Ii4RMd8=@vger.kernel.org X-Gm-Message-State: AOJu0YwwX3U4gnY1H5dDRiZGYuIlET5pIxa0tZtXBHFK/p4Ke/NL8Ytc Z+p0GcmvSe9FyDVh6tCQGuI6KDOlnQ4D0e/qPoWtUoJDn93dzOHklYwV2DwxIamGcdz8RasuiHn vmCOMPzaQGgQEb8CGY6RG/cPia1SrIYxfVoeGBpJSUBS1rdYgCutkVjzYwrLhWVzCEuqgqIwFk8 w= X-Gm-Gg: ATEYQzwDeT/L51x8hMOiQ9TgFHWqo4y9OhcyMBrylRUO6+jTt4/bcEWm5rqpFzV+7pQ BP3htoac91qSWnb/G5dzezLjLA6+j77z86/buyUMvuWaWgCFhiuGptR197+WVDXslGGwXJsjYfR ppJoJ6Mg7o+hUTSfBeWtB8bEqyGCwvHGalU/sUeD+I8LGwkCGaC6t5BjUqpZDk7ZmqLwqQWnS+W Mwn7IASoNjwCkLPF0viOXqqgStcnZcvpCdHat05B7vOIjlOBmdbJGW7Wf52X8EZdVo2sM5HMmJU pmjSnp8palvKk9/Xy3zFYkLL5LVbfLJkgbs/ecWEY5f0PRrUYqDyO1CmhLr5Mr8xpPm4PD9DAg6 5h54J+FWC4Adtzzqvx4j7E6WMzm8nmyASIIpvjNTntFcDMeBpC6U49tdMYAb5fNNVQK1r9oHKRR lyEdEyV0BwbQBxUvCBSKRePMUyPAjlj7uQNiQ= X-Received: by 2002:a05:620a:4607:b0:8b1:1585:225d with SMTP id af79cd13be357-8cd6d4a6d76mr316673585a.82.1772815653099; Fri, 06 Mar 2026 08:47:33 -0800 (PST) X-Received: by 2002:a05:620a:4607:b0:8b1:1585:225d with SMTP id af79cd13be357-8cd6d4a6d76mr316667885a.82.1772815652532; Fri, 06 Mar 2026 08:47:32 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:31 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:17 +0200 Subject: [PATCH 11/24] drm/msm/adreno: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-11-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2707; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUO+cW8IttvRxZ7kZaN6gVeCBanRcrfHvEmx kmoALrut5GJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1YJ4B/9qW5rJ1SwBReASY5/KyLYyVFXtnjWwxBXVf4i7cC5e28xYc9gm8NT7GoRPB20/E0y2ou6 0GNyzRYWdMTmAECPm6+7kmuGlYLCc5pGOZCdyhIFOKESeIfanckIhENp8b+6Tq/yZivgUKeVs40 XTV7DyLtlZ7TRwDGcnSwwwtQtF1hBVIF6+mxyJdVnpor3bs6u7FY949gj6rzXaKozsCRfcbaPWf n6uccbmnA3zHYVmh0W/CDobRy2tS7xp8HGf4NdA4ewB8t7dM6q/tkP3cSuqulcoU5fSRIszdYaJ HctLR77k44CBc/zt3DPSj6H+8Oz22e73q0GvlOKyDpLXo1WK X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: WXAtsJyjU3U5bqbMXy98_6D-KL6WbTyl X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69ab0526 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=0JjmiBfSQHijSEXDZO0A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXz2NAmEOAiW/P KFZekJB+TflW4kYOV3BJX8Gq6XIiqVilSPbHcL8MwPErnJ7gZ/qkDnfNxIemdExOh00GpwjN+5i HYVGRuua3N25OlLBvgGz0cC7Sc35b5nrIocYlULOK42dGSgbgsD5HMpTFbVEvOjq7STN5J6qfeY bjky5g3a8juHthPPzdXNOg5jzRHViFjQ2uyA5Te6yVxCN4HyXRkUsC7wMimuWJ0xqQk4bNn/OuW SPSNQ5uKwswkUf0turAXQlOKekMauiPeleEDXM3E0zYw9GU4rpNe7G/z2NTYVsBtq1mZ0UxSBKi Dls77wct6pKtlOVGzcStMuu3oAUyNqnW354yd2ERrqQ3H4hTQHGJgY4h8omrQeVbNAviI096AwR bH3XkyyV3zJ6rb2s58/RMNE1JrDBInCZ4zdWmF1/GrCDaiMS/W6t7L+ARIuUeXXn/nfjkM3k2Fm a2nDnBVMJobNYW6PjqA== X-Proofpoint-GUID: WXAtsJyjU3U5bqbMXy98_6D-KL6WbTyl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 56a820ffa613..7be31de3b525 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -741,7 +741,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) BUG_ON(cfg->highest_bank_bit < 13); u32 hbb =3D cfg->highest_bank_bit - 13; bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; bool min_acc_len_64b; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 6dc1d81fcaeb..680f0b1803a1 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -265,8 +265,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); const struct qcom_ubwc_cfg_data *cfg =3D adreno_gpu->ubwc_config; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); - u32 level3_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L3); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); + u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; bool rgb565_predicator =3D false, amsbc =3D false; diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 4814233d8dba..cc21b41cae26 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -432,7 +432,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + *value =3D qcom_ubwc_swizzle(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_MACROTILE_MODE: *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB044421A1D for ; Fri, 6 Mar 2026 16:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815664; cv=none; b=DoA/DsMJ01lsqFkEHKi9amaOwJeOZ6rv2CVYEc0teHo8aOGY/1p1sZStKeOzmYJ1o6OLaWLMfcYABkfiO4kBHUSU1M5GLj65DBW9jRiJNNyvu0kHp2b0Qn6BlvMPmM4oxvJ8FgN7LylhHCeF1hTXFOb9pyOrdEgulcEqaaYCBrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815664; c=relaxed/simple; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tDTVVi4we9IaRAelB4R2r5dD4Zk+c/rIt5e2qSlC20LeHZXz8D81N6PfkycIjrKdgCaHcAEQSWFxgAt305qg1NqQyCKmXtDn+KMmrGQOZIYTltf+P6XF8Iq54cXAldRhxRxvaiI8m7PF1hE73fEBDbktkPxJ+DP/hcAxYYiMd8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b3OMDOX5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ASPrvEjH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b3OMDOX5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ASPrvEjH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrBnO3959900 for ; Fri, 6 Mar 2026 16:47:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=b3OMDOX5BD8+4950 W/lo6or1iwD9WF2ECLHehO6KeYMuvr7U+Mzz+hf7LkAWmIZEHUj+SEMhC6vIRfgU PbrDrr8q5QB2buqRY53bAcuJtoIEyxZkSJTnI2fakhSF9mp7CShcn8mAN+Wd0Gd+ mbyjLI3uQOdLdyc6x34HVCkXYDtUP3489D47J9vc8j3sQgwxbATDRl8KIxHyJvSM mHVWeXtB2yeY+RAvXlLG9wiaN0145ECceJNeMKJ8xxEm6KYwHCqWzKYuNWoAELvT Yo7kqDbGjhRtlVLK0NCJy+bUr8tkrWjvzx+FnDa5sr/cp9KgGDlKQTGHlLQLlLNo 4YSrMQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv9u9cas-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:35 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb4817f3c8so4613483085a.3 for ; Fri, 06 Mar 2026 08:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815655; x=1773420455; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=ASPrvEjH2ttG1J4pD9mXzTljzkEkRz+LsocH8A1d+o1Y3EPF40E0B/gzIXyda5yLHE WZRGpIW4rfVibEI+mBdRLbUDNOInRuNYWc9a3U7RBt1C5V92gD8yErgX1ETc42HxiV+6 amyucmww4Y/wbe1LFlbRrxjLUmwTrm/qOgcCI/VKNkSVdFFrbsN1ZCaQWBF4iEmO6WdU 0+Yh1Ddsw6aJuzsag8HUEebGw0RF2qe5Vo2qShHhtXotaZY9UnMAAaigLWHl91hCu7DA 6i72Nakg8XWeSh8Ens7G0WYrLOTbD6BMlGBvbZ4rumKiyMCF3ZYpKxhZBHrUqPHJixSq kC2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815655; x=1773420455; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=OKLP9pYVEWfU3q0Nl0VTes+0DaV1Dz5DIwUsJawhsI6rxZHaKH04UAWs6EN67w/Ah4 CDPr2S9N0wXt7v/mpiy9VDc1W10hjHc0RncDCiHmfK79RNcUL1l8dAMcSsYg03Q2jPgI /0xvf5pBe2iv5HxyVDDw/Ki6WBTthUuzREoIiIKL7CbTnqxwhgOtiA7mvlI+wuu1eB1M 1qcTU8SOrei9tRkSlfmorI8/tKjohbCa4oddKnJ3aoh8KJhn1rk4y3O2NECZkgNKIZY9 OdWBPlaA5x1SQmgc583ZHr0jUuGKfZdj4wQQb52H6NvxYCqKn/KuTktUAt6TnITXlLQe 8woA== X-Forwarded-Encrypted: i=1; AJvYcCU9M4RaDsFYHAORgnrj/YlImCnYgKJfgjXxl/QZdfq6N+a6OFoULf1PsUq4W24D184tm7ONYQlJ3Nc7l0k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2bNwDNVo2USqu4zAVJe2rOOYeFDpsSooXPHWi6V+ImlK6oE7I uRh9FF9w8r/iRb0alHd73Gmgf8e4MTLBq6B1Ov6V4UlBNceLrec4H3tPSyR8hCTs+9kBl1WrFAQ qMQuLAeLuu+5HXAiHA2rv+UvPGcH9I7AWqoPRzcj/W/5d9iDjUneX6mtFzQPbiSjEFBjznEd120 w= X-Gm-Gg: ATEYQzypZ9HGJCgDCaZuKq14TAa6Vn4w7td2zRUy7Zn+YaROimGQBKjA10V4IdSxd6Z nMtB1OKH6qUB/GvV7fEks98P2foe3Irq1X6PPQaJuzIakWXMqbFJj+BwaHVrCkrmi1u/gBLooRf ujWvVhTHrPiAVXhS9CrzZ2ZOQyKIEo5LpA7Bdjy8UGyprSKQ78PpjPFgHG/fJgUivM47Ys6uZDy GM5+ceMsyiX7saTrEJ8h8dQ4a9f/dCG/DQ5p2lVOVDde4Y6SzLIky0GOFZbjyL3Kx73hQ5I2sLU OlHHtOx6YXdfvsGBKjUD0BuVD2h6e8KTg9imH/QasoxuXQbOQBAvz1MHlMaBlU/TjEeNzIng1Qq BGC6Qoj8PkYK3HUAUDZIdi6ADQNkMBQNTr4t6eOpn+r7U/u8gK1xce8CZ2qDm17AhycK/T6tY54 qqvvDGtRZVy+gkbA9HY9Xmu9tnD/8a8JY8c/I= X-Received: by 2002:a05:620a:4721:b0:8c9:eacc:dc16 with SMTP id af79cd13be357-8cd6d37176fmr366710285a.29.1772815654616; Fri, 06 Mar 2026 08:47:34 -0800 (PST) X-Received: by 2002:a05:620a:4721:b0:8c9:eacc:dc16 with SMTP id af79cd13be357-8cd6d37176fmr366705185a.29.1772815654039; Fri, 06 Mar 2026 08:47:34 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:33 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:18 +0200 Subject: [PATCH 12/24] drm/msm/dpu: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-12-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUO8Ex+JPWJ+F1STr1Fz8blrRQSL1616YHar fhCWu7KFZ6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1eLWB/4qKS9M2QSk4gBgTzuR+lBoo3EFQLXIn28BVsW9tNK5u4BmuuHD8+4m1d6vzLWv4w/VNVL QIlcjUamaXYmVv+YncwGEG/H+ZQuywNypjD0+rjZwiy+ip9aJvCydE81IeOnU91amSAI5shWxzz GaQLVVo7eImBApIUz73/Z+STHTKj+Bj2xtMnVH0urEW9YwHjiZ48To8lTKRhXeou25f3cFluJhF aDmnNeOAxwtBJ4njrgMNDcNlJaN0ndH8+/Qxc0s8jqRzkL293BMDIvOFM3guxLs2V9tj//4tH+A U+pHfC27wAaO2QxuSmkyC6nu1uMV7MfWWNv5/a3D5ZTPJINj X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX/UxWiOFAwvdc U7d6l+vVV6bvJb/m8Dwu0nP0qamzBmP1boY777uWIUmRUP9TAnKITGsVSlGaQqOJYYxpRkzlKPF ABnQTyLfEeEHhzfO4PLd5P7nGK8tIIrgzTN9wyeciJo19oIeTsSgCMogS0lym7zTmGyJwpa2lkz pINPX8aapuaHIiLsyvmtftrB/+/Ihm2y7dFbh2nYKAoYwSId29zlZ+VpVimJ0mjMPsiEJye26pV VyWCia9h8/a6B/9mI0NMisAYCfiONvN/eZlcC7e/IB+FuoFlojdjnRjUR9z4oWndZBI7tedXGP9 h9bD8MR6ImTTzLKXTaaLLemNG8FCJxFxp5QiXPD+0G2Mqi2XkqGNtSMTYhYRnhTKwgrMU0Yhu0b VA2CN7W8kxjAP19LD8/sjvE4NXwLSc+NRna2ETMxwTSQGDQWuxNcOiASYYZe5D0QneWviZ/YVO7 ET+IrlITOTjgtYQW09w== X-Proofpoint-ORIG-GUID: Zc5Kn_lntvWz9RqqFlhZzxABkJReRw2G X-Proofpoint-GUID: Zc5Kn_lntvWz9RqqFlhZzxABkJReRw2G X-Authority-Analysis: v=2.4 cv=eJoeTXp1 c=1 sm=1 tr=0 ts=69ab0527 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=46QewcZEoJiMQYndSOUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index d3da70009234..6089a58074ac 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -318,13 +318,14 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pip= e, const struct msm_format =20 if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + ctrl_val =3D fast_clear | + (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { - ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE9241C0D6 for ; Fri, 6 Mar 2026 16:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815663; cv=none; b=Ase0kDVr3OHyq+UInAOI184idoqZz5X2DI8A7sqrD+gRqsix3Vns9ECUnB9+HOfkTXG9eZKWjjAmnovaFKmCCWuHphThSY6BI+Uq/aMu+2EuNk9x08OMNsb/Cbt1xGO8+RFJwaNraeTolyXb+m/shf732bgIrQye4Jd2Z8HssuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815663; c=relaxed/simple; bh=qsOpdLggOXLMpfbLwFYg8PlGDKmsRsIEs54oYjYlw/0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TmCEpOp5KY9KcImmOvY/Ss8MWX09DCLJYqQkcoXmZGO9Dnf660EahnKHGBpaw06UFWimv6vMqSgmIbyC3zJ2D63NFeyKjzHx6TFhGSfQMx5mRmlyjr/FepBH+Cw4ehAjcjtNwGExQslQXJFoYRzDBeFwsCTIz9+ffITjjSg2THw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RUo/ZWRh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FDRyPOsj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RUo/ZWRh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FDRyPOsj" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr5jm2577618 for ; Fri, 6 Mar 2026 16:47:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Aie/7ZFKISr7ex2L2qy7vWj/+PsvZZhXHj0gPDXAjM8=; b=RUo/ZWRh/8xT01VC bRYEW5v8dCgJtq+Jio/JoywLt2w5tQffzAwEQYS0dEX00XMymcOxEXbIyL4Xt4jm aas/XjwGagNROUYBqF2qn4KMLrctlO5dTIkfTgbkpuTSg6dwxWbxuqQoXGjQ41zK yonQti4zSCCn/1iIBcBzTFEJTnmUuRwfXWLhX1OKXjVhfKxJ6pCDYP2Rkw7/WYM7 iMy9z4APiIWIiJSgXOCyZ5PrYG8pLCf4++K2iLGqhFDvKhFnC9k/VSIH1RtV3Qb1 PQXlwqh332s+MFRAtQUQQCYH0Em5HONvXNNRXDm+eppn6D0v49AB00dA4ZO3Lv6y uk+fMg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqfg6bye8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:37 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899f6e5b909so343464156d6.1 for ; Fri, 06 Mar 2026 08:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815656; x=1773420456; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Aie/7ZFKISr7ex2L2qy7vWj/+PsvZZhXHj0gPDXAjM8=; b=FDRyPOsjDy0qwoLx+RU5rI3007AP0bJ9z8AzcTIsENWBnH847SimQwT34CJvbhgFYX PRuKymXtQZtYitVcKdZi4GFztB/7CN3X7WSU4SrtcDLcEqKKQDKHzNMnZPwG8rBhKFTY VSyoYcN1Z4rp8/4JzHo19qPde+D7aTaF9raq8/j0Gh+h7zBAEETDrvvJVRxLM0r/ymLf 1vHZNj4ZIqq/+y7Qc9GtkaIzJDgXH0L/Ooy8iEWjPbDqaulQ82/jSAVPvhOgz6K7xOja T/LAW78zkxdSZJ88WyYy2YA+m1ShpLZVvGjeRNViqmFFu2kVv5N6H8xAGJjy9wpHuUoc 0pPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815656; x=1773420456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Aie/7ZFKISr7ex2L2qy7vWj/+PsvZZhXHj0gPDXAjM8=; b=Jr5/MbsayEXepQJll3u6l1QY1EADhAn/R+mazZQSRkPAh4mT/puYAeIE1p55G8VdBR tb5JzlcWuO8fUVINMIwoPeLsvzi5T5uih5CXa6mnG98ALO69AWR57CAvZ+yg5E7tTXhI ULO838NFJP6UBy/al/iVbcefnzF+acYRZL0f1+21Wzz358BrCT8m0jBI3YuROjRXJfQv I3XAdKuMrVWhME1GH2nWGVe86Hz/5vVHj+WzA0t+opRhQb/x/adhAZbPDouMgq1AKVHb bPg008lc9SeK4zueUVWk0XNsc8sNve1doRYfaUs0UUpkLkSCJHrKK7/oYdbllgvesCRH qrhQ== X-Forwarded-Encrypted: i=1; AJvYcCXKkDU1BoDkYTBMr/v0OgSRlxUvEhkQXQyYC77g2IdIJTmnoiOUvGqcTtOmGNk5TgoCVGUp7hoFYgeKZEA=@vger.kernel.org X-Gm-Message-State: AOJu0YyyHHZ5uu4mi6ZxQXv7AmdofgtibwpbVvxIfunWtQmjSdQ9Z1NF 2F6TxnXQwC4kA0YWfew8/S8TiwEiZ5/tFQpFJktPw5hTA/Covj50RIc/Z4YLjwSty4ATqg9cLrt lOgUXfVwxdvayfNPLpHkE6KjWnxly4kvw7ikw72QYfUPDAyD2/0U6SRmu20ij+rpk0Qan/1NTHL Y= X-Gm-Gg: ATEYQzyLyO8iIhCdoMhsA42i1pYTytoIFx57DyU9soAFWI8hzHaK2vtJy2OIYZvVHtA B6pIqQwrxTJT79R0g222pn1cP9eEYxajLAScUx9IZqmPpx/48KCO9cE3mR+CVt7xAnuhkYHo1W2 bjImnNpnz5IA7PGNgqg0KktirP6SFGju3f4LnpltJG95yYtYd2YzsuV2f/9xc0nKdNZIowN9Scn QwkHuVo4FPxQX5vA9cCN+0c4lCi7l5V9S9IegD98kMIxyORzIGU1mcAdmOrz4A6p080qutrIdsc entJGxyBdH6PYfuNYMViKgLHDGN3mtkFcVQb4DNfBaS+WTDS10tZjAXLZBJcYn288F9Qa0tjS5h t8+Ag5VO9wMRMVdE+25QhXP2fkhTTyDzhOfyUCvmHuYFMbAHEn51E+S+2fjUQ3FWVyWQgloewbM YqTl8rnnZvjOH5oR29aXE/WMh+yA30dEtz5Xs= X-Received: by 2002:a05:620a:4093:b0:8c7:106c:cbd4 with SMTP id af79cd13be357-8cd6d324021mr353872685a.12.1772815656004; Fri, 06 Mar 2026 08:47:36 -0800 (PST) X-Received: by 2002:a05:620a:4093:b0:8c7:106c:cbd4 with SMTP id af79cd13be357-8cd6d324021mr353869385a.12.1772815655528; Fri, 06 Mar 2026 08:47:35 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:34 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:19 +0200 Subject: [PATCH 13/24] drm/msm/mdss: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-13-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1997; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=qsOpdLggOXLMpfbLwFYg8PlGDKmsRsIEs54oYjYlw/0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUOwmtRsGD4tC9puPqHYNiohxXzcLjDEA5Uh CAgwY2R9lSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1dcOB/9RSpFMP6nY1bR64RNcJvTiVkU2qOr2TrLnNTTJdrKYmebkWCnVJR4OawMqK9lHX1rn1QK oZwfQDrzMkq7vhgODaLuZwp9Lz+zZcLVBcS3QbxMSUtQXvFw/DewIC2Nllol7BQ2iH0vndNjg2M m7fEzvOEKpZz23v2ndm5pM9L4omgJZzSnYo7ueL1glzcdLBH6CdBK7er1EnEY5Sw2pqFjqb4zr2 AMHgLiltIygWZWI9zOZe7jGued11wULPqYWI6NzkKZd77RCFz94sL0NKXKRMy3YyodMHq0DU6tC pKBBos0H9ueHjLKhp79Q39DtztobCoXWvzSIeP1IuAxjciSM X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: My3akI4tOdk5Q9UDknApO60MForwqdML X-Proofpoint-ORIG-GUID: My3akI4tOdk5Q9UDknApO60MForwqdML X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX9S1xBc5B52So gN7WIxC7RvKyM5u8OlMh4ggplM5sZsFE8yD4fDsC8sBNcyByA7zmUBVkPrqlCTFo6QlONowv+Cd 3EcQ99lFuk165WG2hIfMe/pwrSVVV9EVZW6EjneFsHyLGH40oPiwgEqBPnxPQ+H1d/f6zNKCY2l d0ZiCGHKpJ8dEvkvWWcNF02+bldJeSJl3sQ3F0VR03SIJ+ydwzL8eSPTAZhvCDk4VFBA27ftBKW v/mHAWYHN5bD8lWXdlHIDlMZSlBpl5K/EsxFmwxRxs8GAn/HYbXQ0itOOmpy9GFM2qYdCJ1vp28 rkSvPN3JwYDg4Ef0R1XsB1wloEOm2b7/JyiX6VMyH0eD73/g4vSB2RtmXegmdDyJlZ6I+eX7kv5 TjOgSKMnYkmFttOFUIyWx4vJ+BredZ0dbKuRdzsSlwVn8p5H9/1pFnZViHqH6M0o6DlJHodLx5G 6Uvd3X7upDAgU4PVeZQ== X-Authority-Analysis: v=2.4 cv=XKg9iAhE c=1 sm=1 tr=0 ts=69ab0529 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=o1f3_DkCrcuZBLJIWnwA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 90a4b579776a..2c2cfefe9b9a 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -169,7 +169,8 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *ms= m_mdss) static void msm_mdss_setup_ubwc_v4(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); @@ -180,7 +181,7 @@ static void msm_mdss_setup_ubwc_v4(struct msm_mdss *msm= _mdss) static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (qcom_ubwc_bank_spread(data)) @@ -200,7 +201,7 @@ static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm= _mdss) static void msm_mdss_setup_ubwc_v6(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2417041B361 for ; Fri, 6 Mar 2026 16:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815664; cv=none; b=qauQNuKK/KellSW1RwOL8qnAzH4200uOzfWl7SgMUa9kF1OTl0hl0xGITRKkkyomqdHWr0vPbNDE+coomMZZNlSqUFbLDw9m/JX4AapmDzgOoKMnMlWwQk4s2MkdpeHHw9oFPRKN3iFTIivuHVrfuaderejv88FOc6xCYRp4tN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815664; c=relaxed/simple; bh=hheiMl8VJ8rTRpyUKrTSw/T/7nX7ElA8etZcspaY4GU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S4txb/fp6L4PqDY6/UeAHYVEln8MNlWrit5HpNJhKQvVMd6eVUc4rPCfQN14HuMkbcNe6EWbdUySicq7yZCUdURlsqGl0fmY/dQ4d9lE3rezppSuhGL3cV53YXNZRhNa4zwvMK5CPbYJvg+fftgpf9tI4EFX9+M5OPXyyAlSnFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Mo8Nwd3M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AcpwSN9y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Mo8Nwd3M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AcpwSN9y" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr27R550043 for ; Fri, 6 Mar 2026 16:47:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h4ycaMV7nlSUQ5du4YcIwqCqGJ98D+lbtRqht+ED2K0=; b=Mo8Nwd3M4MIJKTJH gMRjuGDEY9pr/EtnflqEOJFHn5zQOokp2UUS00B8IUA32El4IZbjeKVe/17IQ0mD OF0VgTVl35aI685dBjmUWeEC/+wGbuBeffmfZIhhtamL0Ym0FJQPE2ioNOafJGuu 95tsocTXyJ5CGh6+90m/qwrefFHYjDZ+a9vjkrZm1lsdNXyG6YMDeH97UKL3jfY6 cgyTwb65lUP9pG666Fibfl9Ng91HlW4x49tvHlNE8TnWGv6u6Qm3rVJDD3zeOTuc woa+bCuzrCKt2TkNlK05Vz1e7YOg5kIlBWz54Z7YYWPASjT0ip1oSuuFqFIEP5q5 rweDYw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka68x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:38 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c70b6a5821so4465859985a.0 for ; Fri, 06 Mar 2026 08:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815657; x=1773420457; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h4ycaMV7nlSUQ5du4YcIwqCqGJ98D+lbtRqht+ED2K0=; b=AcpwSN9yNTTvTOADKa1JCw3aehJEdhxu+dzPRusRWSKGBNVQ0c+z+87Xkf+hTh1HI8 Yd1GcxtttrrsBjGSmUfu3nGu6bGBKfc4rKKw5eY2X/Olt6Is/UjtO5CHqf3pj45nFgdg qh3K5tJvYObHUMtR6XmG+WMcafE6vDLYZJapJ5q0XTcsiSLfhmjprfDd+eVDVXMBx0ay 2eWGfa9uhANWVPwqyUcb0s+EB/dTz8R6giKCTgJ7a+FroVHpG/ocD5MVQmahN94VURF4 /LY+AtQ3Xa3oVoiUJsUQBmfHZPuX0hq2+GpBXuTPm6OJqOroP2oFTaoJwOSusRlfCCQH BqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815657; x=1773420457; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=h4ycaMV7nlSUQ5du4YcIwqCqGJ98D+lbtRqht+ED2K0=; b=mjFf89FIhaIMwK11EtTBttGegffQbnRtHgZUx6Ea6k/VwD+bjMqLQ/MYp6y3p19JvD CiOCpdM1v2O1UjnonLOBuo+48OL0HDHrGjVnIg1p3hpVeNRJ1O30D0yxh9uM3D6q4PXM vlrAqPdGwjw5HayhVpseyPYeTtlW7Rcq0uaYcVhHgmlnMMMQxVjZOo4Kawp4G5puEKCb Y05GlyK4uvbiudpmicwjhhVt1fyhFG7ckg05CrtFIwLYyTu+mVUbY6jHr77XcVaqfanU HN4v19W5ntiS7Nw76NptFy0dVQj8x5127gvPp8Yk7Ns77Xy9gF87v7LRUcavJysJPrHQ 8Ujg== X-Forwarded-Encrypted: i=1; AJvYcCW2Ya8WyCgpH57DW1U6/zum8ilQRS6bUcfRlMzUfhOWYiKRKxfTuf3tG2MnrSb5xUDmih5OP63CvGWTxxo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj8dOBnfGcqcTTd/NIAxR8tEsiFM7x8+mClRET414EvrLZuisB ZxA/WeyZB9WLo5rh4toVjvONCFnQ8BxMTYBM8IzXvIQPQxF2xjI2t40V9Y0QyMm+wcAwZW7j5HO ARXpj70MM3DSWE6YHDVitDyuM54IyJqEnl4yzDIm2fTZEd3gOtfO21pYXPVWZUYiFcPPX3E10XO E= X-Gm-Gg: ATEYQzy4ae59oEWhzcQIH/C9/d2sojIFxd0Qwm9o4lpkiLmnVF7qKphlKfWtrYWag8P zeztU7v7NdhJOc8isHeefzhDKh7wJREY3vnIyvP2YVh8s04/89dOd8/wsR79o6yng9kWPMSkIoC DPxfwZ9+jt3fMth06EH4n7gLFxLyrvFkOJ+e5mWMbeuooiylBhvvX1jhyi4SIlvVmFOq1v53Sy1 6N5f5F5u14R9uSiSmxEBb4qhGsX/491eAxM5VIT+vi8uYGWnWVllsDPPXJrhLKFNmtPlnOX07O/ aVZu2l+WuI5TgLpss/l45AHq8y2cro7xZomLrKn9B4+6Z5ryTsP4wwn9JCnkpbIOjceyHtP7OHm sw303oU2MKVkwJJ5R555iHf+j2B8nQtUDzCSmvDFUk3Z7wlq4FlyXAYOzGjEAlCKwpA6n6jMqcF AghkhU3Up6M89jRWWxM6ZYrgEho/Yw3QgpJIQ= X-Received: by 2002:a05:620a:29c3:b0:8cb:8a78:2cd1 with SMTP id af79cd13be357-8cd6d44199bmr345357485a.20.1772815657445; Fri, 06 Mar 2026 08:47:37 -0800 (PST) X-Received: by 2002:a05:620a:29c3:b0:8cb:8a78:2cd1 with SMTP id af79cd13be357-8cd6d44199bmr345353785a.20.1772815656971; Fri, 06 Mar 2026 08:47:36 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:35 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:20 +0200 Subject: [PATCH 14/24] drm/msm/dpu: drop ubwc_dec_version Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-14-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1070; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=hheiMl8VJ8rTRpyUKrTSw/T/7nX7ElA8etZcspaY4GU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUOe72d0ff8IYJr6eCZASzSx5JMmxu/GZKTO 1j+DdC89oaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1TZRCACKEJlsDwLebkHT5WKmGXXP6U/u9hsEV4J60U2+TmsXK/aV+XiwJHwzs1I4E7yy5PVl9ny U+9WF4fLO2dsaHD25UhmwpzZ3tBbs831aoqZ/U1CUQsB0r9BzKWmmTuEWZD126W9UmqaJvwEW8d eIGjzAc8XPMHhTD5/8EtZeNWDAAP7Kqu2Zg42d7vSObGox0Tb4x0irCBRkjCI3huRV7PFuDOT+y A96mczQNmJ+Y2W16vL7u82ql87bQKRm/RX3e6PGEJEi9mGKxfL12n2yM+E0MbckaMRapt0BJ7bm AXVNaEahYhJ98K4LLbGsG1G/F+YDfZptgq9if1CaA4ngG7et X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX5VZel4ivieSy 9121JZC4IOTxZ1Ha0z6LqHhQwUIaX3v5ghwu0SjL8IubP2tSpgNsTM05QD6fcSnI/bna+JeUlzM dbnWPr0PsVynTxT1j4s1odaXFH+cMdYemtdEr4Dxw0lbqu+JMnQZHVyIokfn96fsYLUFCuyW+L4 IvNSfJ6j6eKg1gUykn7WJJFLISRyL4tnD72+mPsXhTcZENkGhX6iGUFOtEkIadXC7+mIlkuRTkE 95MsHNE2KgJgVvLLZWskAR0UVu6HNr/CGcZiR6Jtnlx4A+Wu8ZsPboZM5Mnrrk/dylGgyFtOZRT uOEGwuP7GnenVGsNva1NDVVgswvwf7hvLawBtpmFFX7Uz05UWgUhyzyLMHmcD7id29LZBXI+sWB l/04Pr8ZUG20vMy+k0WUmhLsXYl2iISVgfftAb6Q8/sAuRubxuJjYmpeLHAss1mJbyv4f5QOv5L +GbKF11hQNUWnsHi58A== X-Proofpoint-ORIG-GUID: rysS403k7hp0ezPp_IpbldatLUBW76mw X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab052a cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=OFVxzADIxEWc22agC70A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: rysS403k7hp0ezPp_IpbldatLUBW76mw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Stop using ubwc_dec_version (the version of the UBWC block in the display subsystem) for detecting the enablement of the UBWC. Use only ubwc_enc_version, the version of the UBWC which we are setting up for. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index 547d084f2944..f424be5ad82b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1718,8 +1718,7 @@ static bool dpu_plane_format_mod_supported(struct drm= _plane *plane, uint32_t format, uint64_t modifier) { struct dpu_kms *dpu_kms =3D _dpu_plane_get_kms(plane); - bool has_no_ubwc =3D (dpu_kms->mdss->ubwc_enc_version =3D=3D 0) && - (dpu_kms->mdss->ubwc_dec_version =3D=3D 0); + bool has_no_ubwc =3D (dpu_kms->mdss->ubwc_enc_version =3D=3D 0); =20 if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR) return true; --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D81423A67 for ; Fri, 6 Mar 2026 16:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815664; cv=none; b=PT2qaTHeF3hi3mb3dsywsQwUXnFKIBbAnRYSW3OOFtL5el9UubsxVt3xesidrF7j7zqvPJ8rxIiQm1Wgyjk9h9rFzRCWRAnd45WffwBxtEmchjOphHCoECeoV/RWPLY/vNndNe//sdwoqyg1bSDzTOKANgXGZy8VdUwkjglHRUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815664; c=relaxed/simple; bh=jQr7R3+YepKvgcTe6jp82KzUXB8bK1KOSbD7btdKNGs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q4vOA3EE4rSBzhhkqJ5fIUxqGM8fYEwLJIYCIGwoEvnQNhzH7AFq+RQXJZCAlmNvSDyJbEEXPxoNcJquCkJsDZVq2NZiPhkOIgvxq9IVWnaoSafTMpM126vL8qSMqhTL5AOW317Jty6q1odizpA2FNiILCigeNqMhrdnM895quY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X4WtKU46; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GUGuBPZa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X4WtKU46"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GUGuBPZa" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrBeU082793 for ; Fri, 6 Mar 2026 16:47:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YzMnkl155rfInvEKL9ifI6QydBewp39sV6azipPoMOc=; b=X4WtKU46ctLZhQ3K myQD/6t1G7Uew7UkRZ7ZwluxW7JZFqWQDZc302cpeE1vEpCamD9Osc/s6lXHxvxI r9jusATZRfXGkC5mUK3skAHr7RlyzP4YerRWh5sHpAXRTnE6UP2vBC1Unr+2fvm5 UDvzvGRub0By5hX5u5o6ZbCixFvLycq5cNVpLRCYlosWgy9Hda8xzN38hC54Xmy6 hdxKwkBnBeKgp/jFOuiePVSLaMZqymgrUPLboiw327tP58mwqjCzzijQlSH7eJ9T fwy6R04xRVV5S/LoD3V+qiczdjOze6UI18+dtOdgbB6T7aQ11UVKbN+Lp80fEgXL HPXJcQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98hc19-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:39 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb3a129cd2so5931983985a.0 for ; Fri, 06 Mar 2026 08:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815659; x=1773420459; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YzMnkl155rfInvEKL9ifI6QydBewp39sV6azipPoMOc=; b=GUGuBPZal85o+xwt7MLOGmfzurMwN2vp5/wCRm4RQQIF+gJOP6WhvfDpBIj1NA4lqx YuP4tI7DAjZSo/toknDiMJlqaNjZe4oOQWhNlgs5za7j1NT9TLbPgQmKpLxWHtHuFwR4 zJR58hYJTLTjFKeH038m1eaIwCM33W4i8JL95A5zkVEDHQ3dhZ20AplnPA4ByIyCgLW9 58O7JeIRV0T8bYboyjCj5srRCEB0KuA8lGF3sWiN8EfNX3zrbgMAx24x1fgkKyBIFGnO 2M6PnJBb2nRayQm6e+EyjHIrdd0ItftW7LazoAXwrXe/DG0y2TOLl+PBeG4D9mlxHt5t W7Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815659; x=1773420459; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YzMnkl155rfInvEKL9ifI6QydBewp39sV6azipPoMOc=; b=mD24ZWACtMieJ1YSaEfm87meRENC3E7d1fmSrQNwpklnPZDf0aIYzbjbz6eIpKLc6P JjE7KroITY8MknDggBSTxhRIsb4j133EcCNJdVBjwFV1Is2quTwDT39PnVhvqyL8qSoq LY8HXPP2XkeoHKIgMmYtaqlcDtk19oKUevb+RPwBYA5fdnl/UfjuqmHzlI2Up5MVjFdl exaA1RQd08Alh4+B1vsdPdk+SOQrXs2p3nmV+j5cEth5o4b5CAG7EJEK968wbIK8T9hr H4nzaBG3IPRPzD/0V88yQbj5g9yn89yzahC8MgLBBIDnNoasA64S/+t0ssjY4/1CuAh0 3i/w== X-Forwarded-Encrypted: i=1; AJvYcCW0wJ5pXT0d1iI8e8GcHjeTw0Ge+Sd/Q3Af6WZt93nYPz+Zc51smzJwFa9efUr66smqehCOcqX8VwJwdUM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2o2BV0qKzTqlQVUWgzgz5ruGwbwbCneinUCDQgnEVP1yMsd6l t8Rr4EJfBhs2sT7+Pyo7YlMnq3OPUCSqWEyopMdAD+y52Aa6y/nkvFEneH8XqutWwd0gMc7c902 +EsPhIY6QCeLZTWOxTMPXkZjBShdYC+9oF3erMHBKYUZjJ5gA/Ws1pAf/DeFrFy73YbmD0q/2wr Y= X-Gm-Gg: ATEYQzyfR7x5qongQl4SrALSf3AnnVyviH6q8Fnzhe3/A1WJ8GeOh1VpPFJZFvfeiRN 2GzJD17KyPRwMO/ZYSc5TAqlo5Bbd/XRKQ6sq17FW0Dzqk5bNYOuCiCUE4NUVMn5jHDAWQVcA5G mwHY3buzVnxeYHZgsMekw66YfYP4iZp60c67qDlCqp92EJvlxS4xH5z9b/zFj/gdRtV4vlnLLYt CW7NUX4BHVLkOk2RHCkVcxy/tMRFpAE/SRsEfFri6upuVjX+6BIIOmr+1GVnOHehAkYHWhETrvx Ie3P/AyXMgD+yveglJAFmaWwacgfaU+wr3T5VQoD/pjpq5kElgWjzzMGzn0Al41aefdmf47Bm57 6gP0j4dl6MShB99gRTXLzq+LIGo7wQqhIcmu3qqrHDazm2LGjDsiktxM4uXXTP8TiTEgK5JhMcA QdCWrsW1KnAC+pnRe04IeT0zTIzGyYlMGtS1I= X-Received: by 2002:a05:620a:4056:b0:8c5:3045:854f with SMTP id af79cd13be357-8cd634f4e24mr744635285a.30.1772815659114; Fri, 06 Mar 2026 08:47:39 -0800 (PST) X-Received: by 2002:a05:620a:4056:b0:8c5:3045:854f with SMTP id af79cd13be357-8cd634f4e24mr744631685a.30.1772815658631; Fri, 06 Mar 2026 08:47:38 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:37 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:21 +0200 Subject: [PATCH 15/24] drm/msm/adreno: adapt for UBWC 3.1 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-15-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=744; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jQr7R3+YepKvgcTe6jp82KzUXB8bK1KOSbD7btdKNGs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUO2Mh9VtIMGbSLApYQvh1/12VtHGBuGs96J LKj2n9wd2CJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDgAKCRCLPIo+Aiko 1fM0B/0aePn2nUdVqrcTb/zKAEPyRqZvsdd/RFmXHhDcTIM1DzeaDRpKCBdbgCBupqy7wxdYpeT Q28bxCxttL64fQMq5FfqaQU5YYfaYGQOd/pdtZvyIrlxv0Kh0rgt6UtETgp9+kmr8w7ySgjBkxD yY+NTnmmhTo11WoMqXRadin0/nNVIud9JU1aQuA6OBOwL0kLtCL0AwkwmHQWpZ+H+/Z4imEoIQw d26bCyB1xLGkmsiMQ4Im6KSMjQTgVUhxNZsYMOmYVFvuiztrFIOVqkU0BLkglfde+F83fPVpwLl WMDUtthT8s4nfWrZNR6I1HOYSKt8P2mEwooM77KkSR9RtkJ3 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: rtSwbevSGSUMHhcA199IVssTBgPsB7Qt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX9d1Wb4eW3SdK eHHTn0dHQPfIq3/Pyma2NYgEZv0x05+ynuJ8dnXPfVUyFJyzpiaXCcq1oEfAtVug4KpwUnFRQFi fm3pNuP3J7b7zXdOeahtStCdD39i4OCukJ1P/gXaRR6r7XBDeh0AHT35bFpgo3D+aZuMTxH9vfq VxuXr/LoKEFGgvxlHZq/IOk8eY/+Nge7FNMn53cChc7gd5mIzIsgX7Mt4q++CP//lnfYkoFShw6 yU2nkj39gDbh9X4rN12IgaJBoH7GuklPOHuflcwqsQcN+bluftUfueqkofMgyKMBu0XnMcytB2x F/r4LGQ1U5v71y/kD7yktQGwvIYlZUio66Ghf6qtuJregBY5/oRIMCGJPTTPXY1C9eMMD9mQQmx QEi5H6YWvRgrvWPu8paYTQKD7IEJrBhq+N+EQ7kdxyecQ4N0CxS85OhW7vebU9eStcO+Yzf+H7y Jxo+8hbuxiot40HjRNQ== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69ab052b cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=h0EdKdWjJzRczO_IdhYA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: rtSwbevSGSUMHhcA199IVssTBgPsB7Qt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Extend the driver to handle UBWC 3.1 (in the same way as we handle UBWC 3.0). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 680f0b1803a1..45f260db729f 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -289,6 +289,7 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) fp16compoptdis =3D true; rgba8888_lossless =3D true; break; + case UBWC_3_1: case UBWC_3_0: amsbc =3D true; break; --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6475B426EA0 for ; Fri, 6 Mar 2026 16:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815667; cv=none; b=cYCxOmP5gdDdNFv3yfNcs6uPOG8k11RxAAd9CGuFNIriat3x8aVEVbTdBegtHhWTDC4vFxF8LD/VeMzkZMVs+KF1NSGlzuXG6sVEyf3M1XjSx2pKgX3nS1KMO8EA8yvpPvcA41YOqSss74X36pfj43lC/tFGcGgwT7iSXcL1H80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815667; c=relaxed/simple; bh=vwRo08OJVutBorS+YUDrF98Dwqb7dE59/dcjOq0vApo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LJtZkH7An5C6Z8XQUEhRtKWPkEmoh2oKpjqJTuGi+okE+mW0UclCVf9NECA3ycVYQBULKNAbdwf+9Hw7wDwyjZzhMj/F7l38fffNleHe5/qmmERXGbFYfpk+bffZwjTYDaNRJMmGyXU/aJn5aboxxN1JBVlsshCc5KW0A2Mefww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VUFNn2O0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g2Qk5czJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VUFNn2O0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g2Qk5czJ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr81k1424370 for ; Fri, 6 Mar 2026 16:47:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ywz55t77MzTGeWA2SI0gC7OmSPpeiWuIVuyHjN4dOpk=; b=VUFNn2O04bSHDmBy sUJKq5bTCIXbmEqZV60HspAfaAUBL3M6CHYt6j9f3o6ivfVfdztqMUTsy++FxZdf QzSfasNBMTvOmAPkbEPgllvhJ/jcK7Yu5AplEse0GA5S3abang4uZub42jcBHx9D 74Xr/JIfUsonMbe2R74qhiK00DQBBXmllIo1X0OvPVqLVgm0Xk731ALI5m7cEKKm 6cG5Xt2BreFFMnumKNPaUvWmaXj4Wk4Q42LUFU7llAttQfJxZpcPZ4/oLtOyVdxq 3+PFpuUKssO7zOFiVoYEfv3XOXf2TPpia/thGfBmlJhRMWFrlklE96i2P/AqzNiN ccQXlA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqrf5t7xy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:42 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb0595def4so6476554785a.0 for ; Fri, 06 Mar 2026 08:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815661; x=1773420461; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ywz55t77MzTGeWA2SI0gC7OmSPpeiWuIVuyHjN4dOpk=; b=g2Qk5czJSRJ4p4VADwWvIs4B4kf/sr0DDNDGl3AulLji8Kj627jxlpP7h1+aBNu5L6 sVcU01dnUYsJl/0LyvBAhVYY48X6wqYgZBjjakAQcR7gYvjUZ8zeO7yCMEOvilSQU99a 3OOcB0qAuXuwtSvBmK+MMEy10FZZdPM6AsVHwYHYygPzJBmMI7NUfjjmP5XTnIRsBGTb hl6vtpgXPjC9J+jLFFnovcfCRNBIm2Ty+EOZ1L23VImBFmT1cFgn4GiO/S5at32P4wrW K8I4xKMI2k37wBOpJ3O2omzHyzPbDS0JY4efmzr0YYsJGeDJnIynQ7ADMCUT+HSUQMkX LLRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815661; x=1773420461; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ywz55t77MzTGeWA2SI0gC7OmSPpeiWuIVuyHjN4dOpk=; b=CLL/J37KvmmAsDBTkpFfCyAVS35L05gTZI+Kg0pxJiAQgaP0MkKLE56ch4MAsI5491 JZwRhXBfYWAQmGTrms0R1Wv3VTBsJkyImZwGs1CA6vsuuJSRbapL4whV81k+aQDWoQOd oWPu+YxmalsaaJUwWhyVbEvc9XNCvG7ApSRq3HyZn6aO4vATCUqg4YZbSyH5hOF8Lk8D SvwaAUTztnFgqggYWa5M55z6LQoAaR0vMgIdQAT4X1ydhHBTXmUZ386d6CO0id/bVxni 3B2txkbFlsmVjgPQ3PNqCP3Tkdyr/G9/DampW9Q38lz+mhnQux45rMQXKxCizdSWsWwT 3sww== X-Forwarded-Encrypted: i=1; AJvYcCWO2Fsv5PRI8UMPuXq/aIFkQyTME3igKWtmITvZs8LPWpBE6rpqABHEv2FtpbvJd1Y8Ml2QypmqF68LVi0=@vger.kernel.org X-Gm-Message-State: AOJu0YzGawCCuC6JQO5+lXmLRWQiCUeu9MPFeE5/J+Bw0pFI+Hw56Pav Y/6DYdxWruK+4mVCSTxD2WrfiTnQL7K/1ijMPMS2hHc1Pta5HZN0owmUtDmUEXAnGtGbV+Q7wFW HlJvmNWaQIs0XJHzAkkWAlGMbu7U0Hc1wDNmBP90Wy6TEY2E9I2bvKoLX48+S3IDUOvsxZt1/OP k= X-Gm-Gg: ATEYQzz9OwrYE8LpOSbyTLYNqszkJaganEdNZ7TTstUMgh2OlsCKRu4wKCQExgaIMYO SSwRheWbyZttDycKcZOXQ+mwL0CRTc7m8Xbf0xKkdFmYq9gu+HG8NsLvyxh5kjPzXNLXmdBs4zY FbWLiqZCvznwPaH4fWF/dUVwkQzjW/QdIus5N37xE3WwRha6+p9bF1w7WZqwlJSqKeD23FbfBIg 5cwUU6T8ayo37goMyVUFVKvRScJHGadib+cADlqxJj075UslQFh/AP0HB+j+OJE6zdf716PKtwe RTRA03jKwVsRfzRfmlcXomEIA7axbKdZGujLld2vSeipcEn99z/hYL00vIw95a9KYtpN1KqvinX 0HB3U2pU95l72IPQDAesGdIPkBTREfLs9HWctvMkawE9AZAnQJBGvviGKrC9DgfkMHtRA6EYxDG 6rq830IoRkcVAzajLL0Fn6TyfIiW23pmUsRPw= X-Received: by 2002:a05:620a:4014:b0:8c7:1181:779f with SMTP id af79cd13be357-8cd63505988mr773192185a.35.1772815660644; Fri, 06 Mar 2026 08:47:40 -0800 (PST) X-Received: by 2002:a05:620a:4014:b0:8c7:1181:779f with SMTP id af79cd13be357-8cd63505988mr773189285a.35.1772815660151; Fri, 06 Mar 2026 08:47:40 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:39 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:22 +0200 Subject: [PATCH 16/24] drm/msm/mdss: adapt for UBWC 3.1 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-16-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=949; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vwRo08OJVutBorS+YUDrF98Dwqb7dE59/dcjOq0vApo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUPwUEnRX71NuA9Gi5WebRwDt6TiTaRrUNAv nUWm6hl8LmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1bStB/9BcXAxIUP2RtzC7dV//W9EtFmgN7NbJA5eNFvekMnqAPi6UQnD4/9sXCZrEq9f2vgbELS 3fxYn5T9j/rTXhtfElX4KaIkOioOpy0IUwGHDgUOraMjrQUOOiyEW447wUgkdnI5y6jY+pc4WlP EHUbIIcHHtDTKStyGC+dGOam5DV8tU6iSS6AYtRVSsqAzry5xtrjAZUJMz+jpHeuJSRh8VUvE5S hapj1m0OL/RUg96fiRTvhrTcCiOB3LWWK7JQv4DstQw63Q4tbTGpEA59/x7Z029T/tBwObOIs83 VojDx08SvHL8z82LStmPD6OjDDMCdmCO3W03OE4JUgEJvJSp X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: 77LMHUxDSbaQZ7_0fQ1PY9xKWceP6OLA X-Proofpoint-GUID: 77LMHUxDSbaQZ7_0fQ1PY9xKWceP6OLA X-Authority-Analysis: v=2.4 cv=L+oQguT8 c=1 sm=1 tr=0 ts=69ab052e cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=ou6ODICaiX18ouMgCewA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX81W7FJxroVdO H/2Gs/oWO1XkjqGf0pwkILYnaRfghEtkEbqpZJtemvKchqaA/oERKYsEIcdbFlgMWsOvnaezoy5 PXYw1LDt0yYSpOD+glcNqM0nILuIO3xZfeuMhr4ezclvM8JqwwDAfO/xs2eHMtixIJ0I7kpMnwo EDZUxbgdzuhLl0UCm/1ATkHeQofq4oxiR9fizV/jAcwViQ/AtB+TbB2xlwPEzSMiNdY2cGoL+z3 uhLMKom9HfQsJmOINUXAFpkdZb6iyxe7Vm3dbABRD5RBy3nBCc5HpnDnsBCoT4zYOxgba+Kwqif jq/OMsDGeTV9cxBFD6+xGxLXMWnJrbIjckUMiuK6XORt0wSuu3Mk5yCNsDnFGLzfnenG5EDHzVP dWRzugSZVxzkLBurJMwvwYMPbEWJzOcXQllJmpwc6Gnrnb5O+BcnpJNy/rkQ3oy3G0Smh1iMAgu nPNjHDeNkRXqEWG8EGA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Extend the driver to handle UBWC 3.1 (in the same way as we handle UBWC 3.0). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 2c2cfefe9b9a..a63a3545929d 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -190,7 +190,8 @@ static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm= _mdss) if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - if (data->ubwc_enc_version =3D=3D UBWC_3_0) + if (data->ubwc_enc_version =3D=3D UBWC_3_0 || + data->ubwc_enc_version =3D=3D UBWC_3_1) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8114B428484 for ; Fri, 6 Mar 2026 16:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815669; cv=none; b=lVvkgLtOzxvhLKUKkntCDCElkTlsU8vI8IxT6Lz6A5r/nKrfeESUH+khPxZE4IE4G0x1TN4QHRpBrZBIzQBHkGUTGEpfiswwK1m5Q2rSQBrEZtNQN2416yi/WtAA0tlmwpX/IM272Mueh6hxrNA3F38Qoue1BXwP+aS2ogspsS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815669; c=relaxed/simple; bh=z4RQ2542mdKmT7Il7PrHpeGFC5QNfj01HavCYOFO0fw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ikZB4JthDLGvrh69lm6hIL1in8sTBltrExk5XqXCPVYF3SCOjHcUH3Tf0FolFAZktw/WAoD4NNMkLi0qpJ8jBCw6Liyl0i+qJ3/TjSjmQAUm6pU+KwUe4CCkS41CnrRFARpLbUs5SnNYOPDnqUBvGlMY/4B3bXXAFH6s1O7xl08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fg7sAIPR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AlEs6wTm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fg7sAIPR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AlEs6wTm" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrZ6g3805497 for ; Fri, 6 Mar 2026 16:47:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M38kDb4qB9NXYQ+LHNR5zTGrfaGpw+7+YITovw8Gl8A=; b=Fg7sAIPRN9rmbSYy HHLD0I03VNTDzuvZQW0NZEK70cJcRcbMs5WZ105UmpGmQgmdEWJVtdUK3SV5gqdy Y5+witzW1N0Yt/Lux3lC7NtrzS9uiBOZftJjVnsduK57kBlD55+rlYlu2oznPKNb ER4I4Mo0au1Tdak9b9sHd/9SYVeQKAEG8W5aPNqy2XEBjkVOpX71FEKeewgLiq5n MMdGZrIBnJS9Ujg9gdPCHlArZHqLsBuUL52Kpk5PkC4xzr6jULVDiW9P0EF7VNRY ROeuep0aawKUcByF11dIwCeN96whWWDFvRIbRv8nwa3EBQpoAFhl7SPSf8X7As6I 7+S10w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqg09uvd8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:43 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89a0013d87bso275148576d6.2 for ; Fri, 06 Mar 2026 08:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815662; x=1773420462; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M38kDb4qB9NXYQ+LHNR5zTGrfaGpw+7+YITovw8Gl8A=; b=AlEs6wTmLj467iPlzvLZPaF09ihLM6JUUrKfVW1SAkiL5FCVh9tdO5b2V6wwlQoczP Croh/vqQfjoO+gvbukUZT0Ay9z0ihW1dVxJM0p41UwWaFWcv0IUtrmcl029VBn3oGRVJ 9LmnsPfoegckD86OVgRTqnZSeTBuGjoIngATtk9DqcCwPoRy3sJN+a/I0K7hrYFHjUn0 DoyHp8tcu4USm3E8Uhajxzk2pX6qRHoYw/dah+5Isvebdhuj+kusK/6/JERZCORgOwiJ KM5S370Wr2YiAIN7Ce9NAQTc7vvyCJDlC5Ei2MmB+zB7kmEWAkht0pRC34mP8oWbxyG5 tZOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815662; x=1773420462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=M38kDb4qB9NXYQ+LHNR5zTGrfaGpw+7+YITovw8Gl8A=; b=QLB4lTY0px8SeZule2djWJhLK+qhrpR9b0nIqnAk0unKzM5eghdyRYcXgZedEgooto lQEdR69ljjhMjDY+12lwWPCai8QEQiwm/Ldfh7zvuyMyCmjm39vnHCj1wpS7QTLKQtQn 4Cor62TnStao53SHYwjgoI1C5GjAp9dKBAJw32nsdsYiL4a7U1DwjMr/sSkOGoLxFgDv BIpRLAYXE4sx62JU8m6Qdag40KSR0hPK2sHhMBrLHjLwcX38/OwEjKokfS1p4DIHdIq1 FMYZwdV9VJ0I9iGSSHx7QcqQSnLjisIDZiHj3dJLROoll78e1uH2Yf87Gnql+R17BkvB RbSg== X-Forwarded-Encrypted: i=1; AJvYcCWYR8UkTSsUwmheqGNcrbWiRpUIMCHyWutr69Kv4rCS2atXb6+hvDEobtx8bXFo/8cJuqgKfLPS6F1UGck=@vger.kernel.org X-Gm-Message-State: AOJu0YxVsFyZqDYjT0gAmmCCmHaFrkX0ZkrpJfV/YWsIBTx7p8881TN+ +qAKh9stP9WJpjyG4YEqdButB/li+Es4Dl0kc2OysEh6a9izOnTFI5fcv2yypShEWFOuOV3FFzZ UPVK1xpFU5zLoQpDL/zbSAe4U01wIwjmsbM5tcVxXm3ftlpVBbLMjVNmwj0pe6F/WqzVmRu0GEC w= X-Gm-Gg: ATEYQzzGJI4vnsIGAjVDW/y4ItfDtTgjT1XY69rUsDugTIKEqmprtiqLXJwCMRmhY9u qIfuYCOCACJhWyztyuAf+VuJn5STqmXCIWas6TAKDRxjYvFF0K2QDcP9eeUqaAXVJgs6TJUevl9 lI1IB18psiSnssIHVxrqau6E5mX1Jn6MKDWNVPb1zOrxP8pDLz6n+VNSeS9EyTB8c6E3j1QauCQ nTeMQZrlql3UQ+Fyzb/F7Eko06aoV525INMFI0DXvyLWZyPLBQKxA9DTTfUazWe8VPGmYlA9vSd d3xr6HRxDqgMKPO2HTeLsb8D5paL8T2OjLSF6J0dcuDkquzSROIOcnPUXS9S2gZD4PcC4JGSh+0 pmO0dx2IU7IX+jKQ1IMN6vd2usU0lBhVuMOGDrYYmAxHARaziexVXe0aCsM9uMtU9mXTSFaoKwW L7nl5GFlf5u11lqLhz3rHLOvx26cKYTK4+qDk= X-Received: by 2002:a05:620a:372a:b0:8cb:68ed:cc26 with SMTP id af79cd13be357-8cd6d3fae29mr342147585a.6.1772815662173; Fri, 06 Mar 2026 08:47:42 -0800 (PST) X-Received: by 2002:a05:620a:372a:b0:8cb:68ed:cc26 with SMTP id af79cd13be357-8cd6d3fae29mr342142585a.6.1772815661569; Fri, 06 Mar 2026 08:47:41 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:40 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:23 +0200 Subject: [PATCH 17/24] drm/msm/dpu: adapt for UBWC 3.1 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-17-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1214; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=z4RQ2542mdKmT7Il7PrHpeGFC5QNfj01HavCYOFO0fw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUP2sCuaPevdnSUx3Y/gS/IOR3Qx+EGuqMcK /UBoTsYZo6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1SxJB/9DDzGSeQowiab9wf8vtsjy56GXYpuY020hSbY5xU1mSPCrN5QAtzKAM1ASP6ipmyRuqLE GOoVO8WVjgVmmvbnQ8IrABipILsbJbpq+5WCF6NCZ6i1ebFjwh7jA04DI2diRfPsu7FI+gCjIuA 1MQBIKyO/waj7TjzMedkFdKcVmyFjKZj23WzlTjjAnlhMFT8QFdU3N5gZ+t0UR6WKZNeilA7F1M ESjWNBB9A2mDKYVwmi8VNMtuO6H+10pDwEWJZcHV7PeWx9mzg/P2wjeBips9F8HWRBeSeE2KnNz VBgiirurU9xOJShJBphLiyxpL/XCXb3IgaGUEpQpv0bosMij X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: raVpXuRNrl2O6ucfK1OOJ1XUS8eD2xte X-Authority-Analysis: v=2.4 cv=b/u/I9Gx c=1 sm=1 tr=0 ts=69ab052f cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=2jSDvX-ur01rGIY0dUYA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: raVpXuRNrl2O6ucfK1OOJ1XUS8eD2xte X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX4/lW29DUBrR+ j7cn/P0JgvYripc8rW0T8yeuAgpITTFtexnjN0EOOV4jxyG9PpaTZGXeqPDaRia3dXCN88OvmDU hw7JSbghxx0MCLbLm/dB9DWwl2t5nMPqW8cOlCRE1gK9r3Y+p/0oPAbwhITGVn0YDluxhhRA62J eruwtx7SZ6Y/JpXfACGp/bstVOthLPW8y/POUAlP2HXB7LLqFKBitrfpxXNSrufzqPSRsRjVi4x sL7P0xVyctXt3DA3aqn3UDhmcfl3Do51/HCGFLy6st5Tx78gsJPJWNN/YY9tvWebJH46L/nmGsK rZZ8YS7RQjCKkxvKen4PsF7qaTQT4Jc551s7DoYM3UdysbVLEjRMKk/WGgEmXmKwC0+Ah/oge2L GxrweLqVgwDwEqYEuHJ3TBRFTGIw0tWIIqYOw/GRImcgZoKNI2SwDaxL0OY1BoG+hWBTAIdUQmc ckfCnSWo1mU33NqoHbw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Extend the driver to handle UBWC 3.1 (in the same way as we handle UBWC 3.0). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6089a58074ac..cb06db3cb367 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -324,7 +324,8 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pipe,= const struct msm_format } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0 || + ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_1) { ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D08C042DFEA for ; Fri, 6 Mar 2026 16:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815669; cv=none; b=t6r5sgkyEA8CS5oDw44DEDOan7d8YzcD6hGY01/N6vnTogF92khrQtoz6/OKFzNdeDEWcQc0uxMzfUpa6GI0SK4PHKF0iod68rkNtNUNknoEdybB7tosB3SrTKw10HMvL7+J+WizZtf3SZx+E+5pxClF9zWgaK+HtzMXcpWctsw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815669; c=relaxed/simple; bh=2LnoPNi3lG29ZP56cipc86DccHTmRuMtPFNBgsiCAGI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qUCM09zVYCJWR5oSoBPBxVS7Ftpxs0WRJtMhU3Lv1K/rtNUShELGzTFOwwJXwpeRDdl1POrXRtyHx0R+oFUTr/5cAhupISXlV3RzTKSu0oDN/pIEblXplNzZZDT0ihail3Zq5b1V5FapeqKiFJcbL4ZjnHTpwKkAEcLfh7bAsIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HlT+Jjb9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LdBzwrxC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HlT+Jjb9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LdBzwrxC" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrIs81188125 for ; Fri, 6 Mar 2026 16:47:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nBxlchdjbjF0eiY4KPqTod21EA8PMrHUqOAvrBh9nVA=; b=HlT+Jjb9QWfBBkkR VaO3WTUceFibqyHYE2cGZx6cyhAVHlg0vCoorfDSiZsWmF76dvLI0TX3OUJOURR/ 5trz2GS8Ax01CXT81e+oMxTiUqx1TaUNDYqyMH4rOKgnFnNVad+ws3YEhFYqENYQ e8KBfYsTMhS4XucWSUDZ8C9zU3vAn2xXgPxywFZ2Fa9gw+d+RhXKqtZo0c4Qgj+r WMJbHe4fV2xilyoXbfp7xJtPS48mFOgzBVw2U27bKN47ec94tHPm7EupV3/8TEEp aRPEkzj8yyms8bdIP33qBrGVdFUasUR5tHEAsRc3Vd54CnxzrZRMKAdU4XzfpvuI C+9OzA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqj4sbfgy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:44 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5061d1ef1f3so780813681cf.0 for ; Fri, 06 Mar 2026 08:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815664; x=1773420464; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nBxlchdjbjF0eiY4KPqTod21EA8PMrHUqOAvrBh9nVA=; b=LdBzwrxC1qobtHMWqXGf8ejGV/zjwspnop9sePWogxzMSGZsb+KYw7amhPo/FrS3BB OWEyKWshY9RhFhCl6aFAK80i04XQEP/0TLMYhdbnDh0aHyCF8aogLe7E/cCYwLtNwjL9 OsKu39yLW+a6IKAjdFpYVw9pWy2AYLa9cRF0sbu+KPUhWxgA//LWcAu91RNf7c9yzsgI ltF5rKGqnlO2IIF+i/6SZv622dDESNoCMVZnoYgOQJ3kbqm8foBVjNh6RqaZv6Eenp/h Mf1ikYxPgp3WLB49qVXTRzYsnrdiKe1lX2dnu+Nz/N9RU0gFfFmSZAzew2TR/dse3xH/ KufQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815664; x=1773420464; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nBxlchdjbjF0eiY4KPqTod21EA8PMrHUqOAvrBh9nVA=; b=jdCkKj48t+nchZJCKx7OHlJY8NFd/JkPljLicy4rJw6TzsjklxQVh/2ZN6qBVF3Q3A s9IDrLcDSDkm2Ro5x8SLyUeiAzpfYacoOaDBfBoNpIp3Pzb3B8oc/mL2ineB5GL4kb7q Uv6Zg6FTRyZJ2DotGIwcgtL/jR1B3hISnDVfb8Z7zhv///0M2JifVHZzkG2+YfeIW8jF wJVIBL84bUrlGLpw/zl5hP/6jMUy6pJlPPuSCeAPuPa4eHPoixkaQEcnivyaohTDy9S2 sdZpB2Sy/0j17MwwGLsWD0SbZS06nA6OGzcqney8OxhNaKmzUyCFna9jPEC9tUQb24LB pDWg== X-Forwarded-Encrypted: i=1; AJvYcCWIIJmsCAlOZN7cKo3wRp4A0+RESJt1yuri9lwV4E1jNcVYvVZlowhBP8IWpt8B9HP5FHXUjjHDbg1DFM0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf653MSOBVy7kTEZLoDzhWbQ7fGDdlwZ7QzuYZ7xMrQtth4F/D YjcNhsaUTbtMPG6n3rNhRpep7m/sAUazut2ExHHFobVWly2HzrGh6Y1OdUOkyLbtVofyvyXdFjw p4MqrkHoiUH/4e0t9TIUwWxMxM8tReG4WVuhKItnoAnWHhsdXO8Y4T40iW0Rd+Fs6wxguYjvFUK U= X-Gm-Gg: ATEYQzxq+UBI0pdX6PokSFlihyb08dqNHiXbdh+8apqhdSQIWOZUSrC4nezuSWskLxU CWhd9ZAdH2DOx8USbCd4CcISHEd7YqlQ4OmxYRz0BOBLEyf3Vfn6QOFkPf4Ra1nLN3zh07FehkW tEpDyP+iTC6l2uE4HIj8Dob09OTiZOCIhVDJBBE1UNMy72gn9ka2emN+SNvEVF25QKt3L2WEXzo Yo0wq5yvH3pZwP08UiAD1CmKGv9P2TtzPGiFKzq3FEAtgSBxJmANjq7fK5Ehz560NtoTw+JGNNo ny8p9YMnwvKnCe3hCy9jG4c1O+d4OImqsM8yH/Ymq5LC31u+Nvs3SKqEFVfiyAZQtHn40ShFxY1 lGNddKJP8jxwC4tZQX6M7QmCQStyY8g46tj4X34XmRJ+CrGF6usq7jlsxnpGrCo/F284qsOQ9hs uI9vUdG0140sXHZ+YpyY+lknwarObZlrxo7X0= X-Received: by 2002:a05:620a:3911:b0:8ca:4288:b179 with SMTP id af79cd13be357-8cd6d33640cmr332128885a.5.1772815663682; Fri, 06 Mar 2026 08:47:43 -0800 (PST) X-Received: by 2002:a05:620a:3911:b0:8ca:4288:b179 with SMTP id af79cd13be357-8cd6d33640cmr332125485a.5.1772815663109; Fri, 06 Mar 2026 08:47:43 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:42 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:24 +0200 Subject: [PATCH 18/24] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-18-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1362; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=2LnoPNi3lG29ZP56cipc86DccHTmRuMtPFNBgsiCAGI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUP7fAZuZ7ND3U+/FN5XiQXOIgBgLaDwD1uB +sv993BXuyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1dP5B/48lH/bJArDUccceJfeYEiOGLwGTQVVIQOUfakt3ewOl771WXgXe8a8uKwujZhZ8kDQ93k FW83HP4T++VRJXLt3PkHjI5ZN09Libr64T0xwVWix6PxGrmpnFY1VJ3NrfCavuHs30Qmf09OmCC cmYirAMMIwZqdiymhHNHSd2yEYMhZtM2fgzGBkXe8IouLErStgIfJ6DRkx464ianFIAw+GzOOrz xdaQ8Wfth34N9BkIGwFCl/cOJ16INL/3KZ/lKvoyfB7AOsKRnBoe9ImOGg8duam7OhRZn3eYcSo fBGpn8uiCW7nQQ1yxruRWcD5L3AAr/MBoRIvJmbi1XFGYX7p X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX/K5GbACI2KmY YmCUghJIX57odQQqM3AGR3jAtYD42mevT4GvC0fVIPqt5p9RLQAjYi8QrK3H1A93tW2rUjKp0nj YWTX8+7n+4zZfP5vCMt0BpQQij23FSJfccOK+Ge9t0uXUZMcIrvhxTbsCyKf9qttSOFBTdtqwYj SHRsSV8C53fJ/QxuOA8l0TcReEQ7Qk9udNiBvZ8Z5H/wERUtC5CB5OQdu+EVcKmCb2fMSY0sVx1 KAJQJuUfVRK9EONyCtG6/uXpIupQSJJf7ONvsJk7xm5bzxMWDuX+jtcnghcRqNCd3to8F7wozxs 6snyvx0+G4wrdrCV8inlBt7TD/MPAhs9yhIPWr0Atkav7ZdExO6AwNOikc820z6p10gRpTojuNW LLeC9ifywkDiRVc8GqMPh0bVrOklA5z54lF/0h/woFOevnaGY957PW0qTMMf2JGQD5Bf+2wuAu+ jfUK+mb6yQhIx+1pUQQ== X-Proofpoint-ORIG-GUID: VxVwIlBb1F3n2klIAlikj157788Poo3U X-Proofpoint-GUID: VxVwIlBb1F3n2klIAlikj157788Poo3U X-Authority-Analysis: v=2.4 cv=T8uBjvKQ c=1 sm=1 tr=0 ts=69ab0530 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=5ZsywSmvcCt_NWGkcqUA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 According to the documentation, the MAL should be set for all UBWC 1.0 targets, no matter what is the version of the UBWC decoders are present on the device. The helper comes from DPU / GPU world, where there was no separate bit to control MAL before UBWC 2.0. As the helper is now being used by other drivers too, correct the helper to return the correct MAL value (Iris doesn't support UBWC 1.0 devices for now, so there is no changes of the behaviour). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 8355ffe40f88..ddd7b15d9ff1 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -80,9 +80,7 @@ static inline bool qcom_ubwc_get_ubwc_mode(const struct q= com_ubwc_cfg_data *cfg) */ static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg= _data *cfg) { - return cfg->ubwc_enc_version =3D=3D UBWC_1_0 && - (cfg->ubwc_dec_version =3D=3D UBWC_2_0 || - cfg->ubwc_dec_version =3D=3D UBWC_3_0); + return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_dat= a *cfg) --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DA842F57C for ; Fri, 6 Mar 2026 16:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815671; cv=none; b=MzYtuo6Z+RM5Z/UhXQqy426P1TudPTyyZR0HA5Zc3nNbcEhM4Nzsf+1mc9do3PhRA3I2csHCTI0A2rGg0/bR1eqOkaE2dRNgXgPlt+BmYR4uhWhcCRl8qeZC1KkYybzEI+h7vBX8MbktgigSiDdV9q25uTVvaLGUjG3h6Xfy76M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815671; c=relaxed/simple; bh=I5lnRHVGhO47eC0F1oaZyDm7ZkFRRSTBKLhGEMk45GY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JHooU8fkKlHa9sj3PACyFP4eksiewYThOFUGtbHevNsQbk+VsG9DuUL6CmjyLg2NF3WCytsRTB3XqCB1v6J34gdaWPjMECuU3thPtUu8lTNqea7GGLPbyc15lILSsxXmT7RB0e4vs7pHFcyz5ZTXtTXEL3/W50+n36kGrlH1bVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PDBxg8JD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MXmojc+l; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PDBxg8JD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MXmojc+l" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr99N550299 for ; Fri, 6 Mar 2026 16:47:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8B2fY2szI51s2UktTG+lS/Bhx/xmTLE0O8Z2hjeZB3M=; b=PDBxg8JDCSiA3WVR enTPdP5d9XO9pAernapCAeIqryYtByS7W/S+OP3dCE1qp4zXuBhbtyPoKJ31jMSi rhliyrfKI93sRZ2kQ8+eYSzqrOUwJUmP9kb53KgcIVprxyvTA5NiF0/CoJ2tW9Bh Fc518ERGOumHD4cXKFr6QsASPvKhGn60bMs9LsdpvuUSIfw1ngNZoMlQ0PC4Y0oj 77cv3ifn7WEigftJpvm6MovP91psx4/bJG6NaZ3/U48toTmWp3k3LqU3hK7ptlWR yD7hyVVtbLKySjvddKqwUB5JgEUS/2z6TFFiJFbL51KKrVm8jjNTCA5vSKnSDO4+ AFRUrg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka69j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:46 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c711251ac5so5155903785a.1 for ; Fri, 06 Mar 2026 08:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815665; x=1773420465; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8B2fY2szI51s2UktTG+lS/Bhx/xmTLE0O8Z2hjeZB3M=; b=MXmojc+lDpJo1lofXZV9qxB4Y344SH7n3y/z8ztkOjyknHr/K5DBEhRJhAjf8goqnJ sSlI3n9FfC0+bkqj71/f6ymYmhW8CzubkYhwOdiD4asM+GvAG6Cw40YMMMvgE+WJuVsl rS0TAHJNoGqvNVma4+NAU3ukjnzSJVL8b4q5snDLhW5Pa6rpxfqcUqELJVoJRk5C8Gxz ie19o9MCXeZV7saSQE04yaySGfi35uyXQnKoENetG+5m4OabESuGcMQ+8woQixfIUSgu AZSAsPc4DhxM0hcw2hB9ifaB3o/E5lS8VDejKalXEykO5qD6pnhhNT/dHUbIzKQg5dNx NOTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815665; x=1773420465; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8B2fY2szI51s2UktTG+lS/Bhx/xmTLE0O8Z2hjeZB3M=; b=QntP2HqJiCD3/UX5sJXojlg/pJD+q1vr0B+IzALWc7Ct+yMiDq3Py3MK5CXBXYJsA1 nyc/klaIhBxEVlxHOzRCWUt7tqM0bQJgOv2Zz2SE3ZXfisdAfkB6d1dISVpxmWb1EpIN ++oZqCsz6pHzdMnJuVapUb2VZbQ01Wf99aCHZiMOhGjkuGulKkY2FkCexdWk8KIg3WOg JB7uh+M0vlw6JlnUxEWt3xAEGQI+EfDVX+Pom+rseyqYBp1dlJmqEPucK0sJ+lWNMIDd KT7QMjFEVQFhZXwKuQliuMu8j4zPt15zhiOVZLHCtqHdxaRSAudZA7nRWwZi/kyiYGgf e0Xg== X-Forwarded-Encrypted: i=1; AJvYcCUQ5XSh1E5eXg5Y5mkTXPsv/pBothwW1Eel+lyGJ0jaVN+TFKU2Kbv4/6DANeUPUUCxi9Yk9+vC53bNuwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YybZZ79y3UDcpCt253f3w4ESmEVSX7AYZOk3xQH+JmoOWN2L59l oJE7YuENsw5Si1sZ2CgoreLp+NVa/G1f7ntKM4zcn138B7n29xZSyiqTSxSY/2630fli93hMsLE L8FwftXAwG5IUOrjJei0iK8u7lLOddWEvuCzJmR6Tl5DYTl5dKjtV36gnvdtDuyw6c6nO2HjJoJ g= X-Gm-Gg: ATEYQzxwEJbunZsbFbd3i0ARiGQa1wMi3aYo8+rPE7Ydj2n0bsqpF0vsV/3ImPrDUWU mDesC8E7vgo7M3k6N9itSYcqdnaPxC2e/vj29Dhw+Zi1OsDfgAmiDqL62PRiatTSHGMKgj0INNQ WQYpDIHGI2ZUAdgZ14oj5P1qSKEWjWS5g3HT4sOuK3p00I/iq6W82mnEaxUSgcozRT4Zq5m58X8 NCj4f6bpeYLgBIpd5Fc8rDyrg7o3wR5YGWoIKnS2U9ZxxNuzubJaW4GfVxz9D0fM2iuJZlg4owW w4+8zX3dj6ChzcbEQuaBepopwjUgaeO4sKa9XN56oR3P4viMTBG3XqGwiH6qCm6LzDLpWw/YSzI +Uyendlz2RKD0Kna+GsRsYOF1GLG2XmdL/NL5Hj/P2/IM4MOcYHWitRhJ5h/+DCYRags8uMfIg8 92PbBKIXtUcTIkHXZTB+XfwqvC+Q2hUnSG5Ko= X-Received: by 2002:a05:620a:4588:b0:8c7:7a3:501c with SMTP id af79cd13be357-8cd6d4285famr320359885a.52.1772815665308; Fri, 06 Mar 2026 08:47:45 -0800 (PST) X-Received: by 2002:a05:620a:4588:b0:8c7:7a3:501c with SMTP id af79cd13be357-8cd6d4285famr320355185a.52.1772815664713; Fri, 06 Mar 2026 08:47:44 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:43 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:25 +0200 Subject: [PATCH 19/24] soc: qcom: ubwc: drop ubwc_dec_version Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-19-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=7985; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=I5lnRHVGhO47eC0F1oaZyDm7ZkFRRSTBKLhGEMk45GY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUP2OplnHHja4BRO4yhK/fj0N6AFxrAN6uGe IpWOa6IgaeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1e8+B/9VHHMj3Z1WJ6gHWxG4HrplPXaGNkLWk9J7IRA0MoH+jP5w3tXUEHYfYE/UJuj10kDg9k+ WOXq50TAQT7uM9FFbba9r+ufgQEtnfEgC5rlskKCNglsQSKewLV1LQT1bOdck2lHLSNn8wCz9FK yCRcNHJe/2PqXdT5Md09RiHWOvhWLLzbIy0UdrOy/l5R56Dmc0G2Cog+L9/eL95sDiWDj+ZR6Js HBvI18TIlErDhTDE9Kgal48p9fTf0KTEJy2rbg66vTtl/ry9m7b/JLP3CJ9BKPRpW3KgbfFFq7/ CAKtTaO1vaTWJi8sNyBMM4SlTOQ3HkCU61Y8QYwjsg9Yrwtg X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX2Ce24aCWAs7s GfAQUH7ohuUYS6yu91mrPBqMuaDNbQqEViwADfw0mkztIZ1c8semE5/CHHZBHFgPEwrBsdc5ZBI VFtjHnto+EU6o2//Ch9X6p+siLEvsDgcrEpLL6b3PC0mZ4aYCZY+lcDS8epwA/WTAm5HPtlAMQk wXnpnTcJCBcEaHYzrlw1cRWhNUZdCH9Df44O2wHWZFvqt+eve6Bm0utS6RT0l9Hzohedsuh7Ton bVHzmaBMc3lKnKrbxj5S/vvQ33QCLlKoR3ZoJPtkSzkQf3aOtT+8geP26puypZz9Qf2jfEPGrPF v/KKX1QvTG2/v1K/nem94uTgeJXtZD1Cry7jmyVcESbgpHoOXsZ8qE0XM/J8PBppWMfm37hbPVY HfzbL6qaTGI7RZ0ey3zeEHnRUCjW/eEMc9T+K8rmFScJNy9hct/EGd3rRifKuRtvLl9mUbUllgd HJUvWfSIh8qT0ofAOTw== X-Proofpoint-ORIG-GUID: UUnudMasCdYB_kn4v8S0jZTkDRBau5HK X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab0532 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=LGEa-qlQBoucZRe8vqkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: UUnudMasCdYB_kn4v8S0jZTkDRBau5HK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 The ubwc_dec_version field has been inherited from the MDSS driver and it is equal to the version of the UBWC decoder in the display block only. Other IP Cores can have different UBWC decoders and so the version would vary between blocks. As the value is no longer used as is not relevant to other UBWC database consumers, drop it from the UBWC database. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 22 ---------------------- include/linux/soc/qcom/ubwc.h | 2 -- 2 files changed, 24 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index e63daf748e30..c5c7fcb4d013 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -18,7 +18,6 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data =3D { =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { .ubwc_enc_version =3D UBWC_6_0, - .ubwc_dec_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -28,7 +27,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_1_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -37,7 +35,6 @@ static const struct qcom_ubwc_cfg_data msm8937_data =3D { =20 static const struct qcom_ubwc_cfg_data msm8998_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_1_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -51,7 +48,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { =20 static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, @@ -60,7 +56,6 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D { =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ - .ubwc_dec_version =3D UBWC_4_3, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -70,7 +65,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -79,7 +73,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -89,7 +82,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, @@ -98,7 +90,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data =3D { =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -108,7 +99,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D= { =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -116,7 +106,6 @@ static const struct qcom_ubwc_cfg_data sdm670_data =3D { =20 static const struct qcom_ubwc_cfg_data sdm845_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, @@ -124,7 +113,6 @@ static const struct qcom_ubwc_cfg_data sdm845_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -134,7 +122,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6125_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -143,7 +130,6 @@ static const struct qcom_ubwc_cfg_data sm6125_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -151,7 +137,6 @@ static const struct qcom_ubwc_cfg_data sm6150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -160,7 +145,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { =20 static const struct qcom_ubwc_cfg_data sm7150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -168,7 +152,6 @@ static const struct qcom_ubwc_cfg_data sm7150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8150_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, @@ -176,7 +159,6 @@ static const struct qcom_ubwc_cfg_data sm8150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -187,7 +169,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -198,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_3, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -209,7 +189,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ @@ -219,7 +198,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index ddd7b15d9ff1..c5f049eab07d 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -13,8 +13,6 @@ =20 struct qcom_ubwc_cfg_data { u32 ubwc_enc_version; - /* Can be read from MDSS_BASE + 0x58 */ - u32 ubwc_dec_version; =20 /** * @ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A22D430BA1 for ; Fri, 6 Mar 2026 16:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815673; cv=none; b=HpEV3wx8iFD2EmYs6nyYhpDHBA9wZFZfMmxgH3R5zl1reyLP5sCqu8p8KQwR2lfD8c+2mR8g+MzTKFrZ4GRD6S43+CLPzKuTPGIOjJ1RqguEBWohGuARl22nzbhFGI3nAHSoQpxoTcM2I7yfpGjc7VElyQp+UXn94/ad7NtUL/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815673; c=relaxed/simple; bh=mDvAIGusOne0ET0zqDfmYH/uZpA3s+5yjk3GrtdImQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tyb/bV80QpynqTN0hQxD5+ATlX87kzkL+ziTFjkKlmbHKttgXxVpyf9kfKs422SefW19VTYNgQIqqwRATiKvBpqP8ITflDGxTk4KCEAX5zf1C5l9Sr+ZNMB04greSK392SlFuWhRZeDSGKGsueL/uMoxxAaP3G2mX194zdH0kfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d+iW9e8B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Li33hvkJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d+iW9e8B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Li33hvkJ" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrIQp1743495 for ; Fri, 6 Mar 2026 16:47:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0OCwYQ2Sg4X39o+2p54LoIZKEdb8rGR+XgJMOS0WD3g=; b=d+iW9e8BFoL4xh7j FCnltjm/CNSaq7IrNakHc72lQ9UK6c+bFMQaRjVE6nlL1I1HA6Caa9efRaQHSRtm 3Q/G73wDHAFWbJff87TIN3H6ixBbikfTQ48wz+h4biWgWhMGMSjuCFxTUXKEDdU6 7/jpTAKiN2YrDs4+su6xKcr5vpqcPQev8hvGHNAJbTIixetMaDAdVWInrIH6wgXY V7qj9enuvWw8JbGtvqLLEIS6UpCq2yhPF60pLYhD6zGhEf1xW1pTbVWGmCYm6hIe klJe+3uU9ltejgx9AnzlshyBJyP+kQQlTxyTwIRo3OIE3CQpy+jcmRm3y3qHRMLd 5Vjqqg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqx14h0bv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:48 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899e76aa555so279264206d6.2 for ; Fri, 06 Mar 2026 08:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815667; x=1773420467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0OCwYQ2Sg4X39o+2p54LoIZKEdb8rGR+XgJMOS0WD3g=; b=Li33hvkJmNittdAHKJKXKggYJNM1m4t066XLsqQkGlV1isLnNVWdDtVlOUU6PK5sgc 3b5AW4S3yM6b6bjbrQNyXwf1I4ePfgqbto78Rd9sruLeU82QewBIC/uzVjpSRWJklr6f JZsA29Sl61Mdi83SXWGN+BeZw3jxEoiN/gXH/2ZD6L5oepXxj8Mb2bEAZhtoLg4mXq12 XzToIfJ4yyv/RO90yHPJStev+vcYLJx0RskoXBCH/E0mLv0I9qiMc6GaY856WfWh9Quz aujoUzNxU/SGoLyIIeeYQxJ1HhZT/FUBDV64fs1YBY2VCth6fgCNkSoGUiNTmmFXIlgj +Hiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815667; x=1773420467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0OCwYQ2Sg4X39o+2p54LoIZKEdb8rGR+XgJMOS0WD3g=; b=aGP9FfDOqo9uObAa6MQoW+UKomHXxCW5BUOuvA3zzK1BKrOQXr4AFWIp3agJORhj1z wvPE/E8Daoxm5MOa8qVw339g6fIl0F/PfrtPfXPA+CxbLyZNRzAuaLWNdNe2g/XD7NJP puC99NtJ2Emq9GT6vetK4pfKW4/TFBbmZCkk4MKJhuOvm/8t+5GvUXNkZacfG4Rtz+AX ntWyZ2Bg8gnG361R14IqEXsr7s5PpifibpRcCfIA+S+FwhwsZeC8jzCyHAvmFfjC8g+7 xpMSF9c/QgVoLLLOSoZt733DqGPbzK7paNMc8bngp6iOKPoQGwa6Lw74dNorFc9SSFxr 9zqg== X-Forwarded-Encrypted: i=1; AJvYcCUAgSh9iXWVhfumj2z1S6UEucfiSPwTvKgO46FLGXv1nSpHtrHvT0acH1YshVEHHSw8o87Ca3JO61BnKNU=@vger.kernel.org X-Gm-Message-State: AOJu0YwwvnSTW6ulEO3gZHpo4yC0PDRl2Cf3sXcln2UiwF97xYdFWPDg 4v5/4Nbmb1gVrmPhoYTKzmwLhUBqOKyT7fF3CfLiEk+RR1oF03zFbTHGs5ZkQqjwLM0PHpKspDC Z0v/5P1XMm3gbZMjI4piXiWCb/Sihv7FUkJ5Le6T5ttFZIrb9GCly+QPtJBB/FNkszLp81HFy/v c= X-Gm-Gg: ATEYQzyIyUFzUnRdSCp66Q0GejCyc2hZbXfk3r7UKZoJE0gi+fcuKc3k5tfqsxpNF13 R8URMgADLqtlJIdPejEHlW/hr4myB5NhHcDjnlc6R35scNCE8truZ4dz8RAmtRm4yJ9TKppbvi4 DQpmgyFAtyXf8leAXIylfuoP0PdlagBdLyDxwQ0x4MdZU5tuPuNh+VdqigQR93z/txcPNRj4Rrr BKQXWS2jFYKuqOgKPgEaw4aDGSbGVVg7SpPxcS+asrKgHAV2nb6MbcUSYjsoXVSqm8mmWWKfXk6 evBf4Kj+33nT+egiyVQVG/Z7gpU6ki9N5kBjFdM1mfwIv9LndYAcSWEgay1rMIhcBRndD/HE4y0 AF9PljTTpymvVKW+IySlDPStsiOKpeQUts61MEawMlw3NY5UAEUwA8HjRgDjFoje9MCmLbaaF3N y19TYfPs+7J2+lZbwJ1bzSWGJQTpp3Y/vCqPk= X-Received: by 2002:a05:620a:4586:b0:8ca:2ba8:b988 with SMTP id af79cd13be357-8cd6d44053dmr354356385a.41.1772815666943; Fri, 06 Mar 2026 08:47:46 -0800 (PST) X-Received: by 2002:a05:620a:4586:b0:8ca:2ba8:b988 with SMTP id af79cd13be357-8cd6d44053dmr354349785a.41.1772815666266; Fri, 06 Mar 2026 08:47:46 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:45 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:26 +0200 Subject: [PATCH 20/24] soc: qcom: ubwc: drop ubwc_bank_spread Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-20-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5229; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=mDvAIGusOne0ET0zqDfmYH/uZpA3s+5yjk3GrtdImQU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUPFtY6u5zVLvLenx4CUnulpHnNP6pHdDvS2 9vT2ZvTUjmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1TlnB/9VSPpVHj4eq2C76Ph/xyzmxPrCnKrdpIAWV5wSf9C8Pbg3OjbUiUkj6t5GMkzeblM6Vrb eerbaQyi9IpBjeF13fKvFv0TXxdlbDjq8yr0Svyo6LTQGnl0X9pYNA9/Kx3LEVU8xG0pKDG3spM W36kseSYDPCxH/h6k6pm9yfE5YsRGRfStCHAehsO2lN8yRjzrRoZ4jNCQ30mbC07D5D0YKo0Art T6C8eCw1afRpqoSb9qbnYqYmpi3e0486K/VUelYJAjLPe2y4y2fpfZbIv+3tZ5MTPecMSvyzdZE Ss1Bwc/O3lDPC5zQqtZcKCcO7mjOEJBoz1yHLRYH47snTNJu X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX/8LTQ6Pdw5Qe 6KP+sINM7fYsyzV8u3Dwnc67ILzo2sKL5ISOhYTOlDB3tArKH8XN9pfz2JBUKxOznb4WaWZ263H aLPBqR58yb5KNghyuZI5XtSHcf0xG1LnG7TuFOT0SBJfyuOmadko1ITiakWeSthUJmV3/vxCBP2 EolH7477aylk8ceQhXk+94DPTdVe3EfHNAjkseN1n993VkAC0ghRnITfEX1LpdtG7L54hfZzfN3 SQbul28/5huwj92rHLp8qWvJx2y9VzyhrK9BbIlrLyBk8Qxak37xKodydbv1wXWMv3S/5w9unIa BElkQBOkcctyTFZ3sqPPAw11Vrw0pIZoIsjLYIlK9s/T9M4HzqAqRCN/1Ps2Yb4uITrWjc4fKNs FS5OK2Np89OT/ntbk9uJxNfROJYYR0Rt2O5PslmEdYs/WYe+ilCuoVh3oZUta/kkqSSOJACwl2x ZBdIJKFYVNsmqiEtHIg== X-Proofpoint-GUID: 2YLnwxMv7og4IgD-x6BHZZgCQNwxmjyk X-Proofpoint-ORIG-GUID: 2YLnwxMv7og4IgD-x6BHZZgCQNwxmjyk X-Authority-Analysis: v=2.4 cv=e/MLiKp/ c=1 sm=1 tr=0 ts=69ab0534 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=j0qWcOM9GDCbVNQ44DEA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 According to the documentation, UBWC bank spreading should be enabled for all targets. It's just not all targets have separate bit to control it. Drop the bit from the database and make the helper always return true. If we need to change it later, the helper can be adjusted according to the programming guides. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 13 ------------- include/linux/soc/qcom/ubwc.h | 3 +-- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index c5c7fcb4d013..070bf97e134e 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -20,7 +20,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_enc_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -49,7 +48,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -58,7 +56,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -67,7 +64,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -75,7 +71,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, .macrotile_mode =3D true, }; @@ -92,7 +87,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -116,7 +110,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -139,7 +132,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -161,7 +153,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -171,7 +162,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -181,7 +171,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -190,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -199,7 +187,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index c5f049eab07d..405d83f8d95b 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,7 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - bool ubwc_bank_spread; =20 /** * @macrotile_mode: Macrotile Mode @@ -88,7 +87,7 @@ static inline bool qcom_ubwc_macrotile_mode(const struct = qcom_ubwc_cfg_data *cfg =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) { - return cfg->ubwc_bank_spread; + return true; } =20 static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D4D439015 for ; Fri, 6 Mar 2026 16:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815674; cv=none; b=ZQGQffbMhzWaSb1PbWvw1bqJK+blQE++s8QWg5sfNrFAVYSmZZWNhrsYQoI/Up7wkxaLgiwii4sivqM9Nva/foeTy/G4Yc0XjOH2VAvOk9aNXjSOYjK9LEbeUjYm+kFXHRe5H37MXW2mL/vvZpuwgcEW42GcqkDvsbJrw3JVsqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815674; c=relaxed/simple; bh=v7QXktkShy+wyahjFgEkbZoSxJ/5hj9cJD9SDRJzeIA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ab9U0Zg7iVvrbdsviPuq+bJVLe93JT76J0gt5CPH1pGXP8On/bGjjNJcFauLsI+MZy3HRbp3l49i1dY8l6Psu2Ip027ITCbYFXz1dCJGFeYLl6XEFod6pZiqUYwTN65te+xDXp4jEUCR59jLB9ec3ZyUbUHNn+lCBiIBnnSVbs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J9vrYKmO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XhWqmELI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J9vrYKmO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XhWqmELI" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr4lh3959760 for ; Fri, 6 Mar 2026 16:47:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qJ6Ex/AAn1uIE82cXCit/bkBSE8pPV30Id+vTgVPV2k=; b=J9vrYKmOpF8vAjb6 rPQvnradRPJjIzoN6HQ5mybVzIeyN38qibCV8fZ4NxdzlvFgEdAieL50o3JnhlW2 QXOjeEpI4nE9F33/BDfQlsqTlmvg+voePvZPZytd6HR/7GmUvuyxYQrvrsSKplfi YzebplJhuaIunDpNXUN1EgIkmcJeiYlKu/WTJ1k1Zyom90uBWRL9+RW4+5CPMlfO Kc5LYz9qjL36vrDGs+FkCUqzry3+O2ZLJGcsaf0z+rgWj5dIBgEhZfeBKBQKNLvg 4WchuuexcRAL33Amt252zUgn8z+el3Ascttq0AwgVKzT9A5ZS4mXSWYKDfqd2v25 f0QHow== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv9u9cbs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:49 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb52a9c0eeso6931302885a.2 for ; Fri, 06 Mar 2026 08:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815669; x=1773420469; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qJ6Ex/AAn1uIE82cXCit/bkBSE8pPV30Id+vTgVPV2k=; b=XhWqmELI3L7zAIPWpKKiK1lwIlFwSUwEnTFNdTyV7+/DbORdRFATJoGk5+HF/Scu+O xgP+zM/83Hf44jqnE0zRE1PO17N8KVhINqdYz4PvVKgaOqiq5YQ+87yccf70lO2OLz3E Omi2LwZHcm/3T6dGri6nuWudbcdrYYSj7kdAgVDlBECT0oknT/5XCYKQyLYuExSPSVUu b0R+EdebCr2oLQQ9ZiJNV0vKD26Nn1QwjxQSJIXeP5GnPF3oSuKOyAQASBekMV8YUgPc ipjA06hVOZUqUu3TV/ni8/JowDE3xuGJJnFOB3cXQdWISLriLGFzjWeeN6R4+Xtbgi+F LR/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815669; x=1773420469; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qJ6Ex/AAn1uIE82cXCit/bkBSE8pPV30Id+vTgVPV2k=; b=Cy747+u7SXUBHtlWxEmgec1z9gM5poYk7LOEWAkub2K0iIbzKUvSWTzq5IbFf7VyFY +iQx22nwec9VYX258VnxRyg4yK6Mkl8yaUosuv0omreyQBkMQJpZKe+wLHoSfpTKDiVM KJ8nrN/US20A0C4VLCgidHekyXFMVkbU9iUsJhblYvvQ7KthMyBagXd05d2jfyOTMRLH FW64fzhBltDhoutr2PZRP1IlylfDwBohqKJGOQUrAwx23e3wdY40HgLYfWu30o+04oif 1cGcRzQhnFlaKrl7buupmo6wl7uDlmni6C/9jV4QDWpM2djist+4RA5wx8Wilx4r89UW e1cQ== X-Forwarded-Encrypted: i=1; AJvYcCVAXmjmcM87Laku/p6OHd5nHArI66ppAqVKNQExDKD00uDWux91xjOxMRm9CzLt0sFoX1kXsNj7Qu9ArUY=@vger.kernel.org X-Gm-Message-State: AOJu0YxIZGkDW5fvhZJdPL5Vce/Nsq5qyT3Bv67IGzPt/jJygbU4kDDM f+sxcp6Qk+erw8i7wBijsOFsOzzsRRzCHFl4wt6T4BPcqZdUZAg21FGEEGxmE5MOSqvUV8EZSDE pU/VTOQ7cTlgc5Ew8we67HFeYul7c5BumsMIitulZ6bAwPb80wF3V3wQ486VvtBA82N0LzKCNmF U= X-Gm-Gg: ATEYQzwTEt4s0giKLrWM04IhQvJTdJczjpp4IIgCoQTi5t+sqS5kdODY69ezl182NXw pRSKzlFirBVOhS3hi820A8buSnbqAYV5bOEQGIIh+f+cd51kYu/V9MELTfKLbr9RJwtGoX8/GDY oMCgf/P4UeRbGBq1ciH+rlS1pyZT5VcKBMF+DUi5VoGBPjdP/it7RlTqJAHWKwo+B2iSSx8YXPu UXliLEBXHrzaRvidyn852duGt6t/8OU8idzQjGdiHaXzJEyiOh2UBnIAXjH+CWXXo7M4IxvVGHI Z78/BXVL2A5S6b33cfeOYFT+2NaO7vb3QT8b5I9u7IqoQtt2Ybr/Rlvo9YrYbADLi36cEbA2eoB eQgpPLpA/Bhzg7XwBXHEr675AQvz3aGT3bHLvywvds7k4EVH1ImLFAHet4SKea5B5y4nTtUvT8r N8Ptx3nWRpZenjzFZuITrT77cGHxOtCpdbyOw= X-Received: by 2002:a05:620a:29c1:b0:8cb:55cc:6245 with SMTP id af79cd13be357-8cd6d3ed360mr340183785a.12.1772815668550; Fri, 06 Mar 2026 08:47:48 -0800 (PST) X-Received: by 2002:a05:620a:29c1:b0:8cb:55cc:6245 with SMTP id af79cd13be357-8cd6d3ed360mr340178785a.12.1772815668030; Fri, 06 Mar 2026 08:47:48 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:46 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:27 +0200 Subject: [PATCH 21/24] soc: qcom: ubwc: drop macrotile_mode from the database Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-21-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5167; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=v7QXktkShy+wyahjFgEkbZoSxJ/5hj9cJD9SDRJzeIA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUPRKAvBaKiSIudQZ6xcRbzFB5Ni1CIbhtqf LAVbZ5TkD+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDwAKCRCLPIo+Aiko 1duWB/9x/MZJSqKyKCvfl+tFrH5M2zgQzGC5zoXk01bxR5/XZp1OqdW6dAkklTyaVff+nePOaZk ZvV9hZnsPlfBZvPs0pPseyE69Hn83m0sL4a9Pj3NJITfWfMM7T1QDGHU9jF+A5lt6Oi0iXJiJMC PhzPdMROuMJ4ESsMZO7HPohhGAViLefRSlQnI0/htVQF7JaVnb6U324uAu4vInd8Rq0/+UNjheu BVANPv2Qdgds1ErPS7t4qZ9EnkQeq5goawF+DLORk52IBPdJGzTkxVdiTbeEgc4RAeTGNumI+aw g2WI6UsKDZrdvxuyuk9sww+UT8Q3ujOcI5uoPlxBB8ldn8xF X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXwOoddNRLp3H+ zAEhpj2PrAC5sGVzmYK93TJWzel0hdUuPn0UNOQ/+mPNuMsJSY6uWlVHowLgwL8fK87XDRtr72A B4KeejqxlUtCY47/oM5z8DNsdy9WedLRKrY5SnRkwq3oDhDWxBsKCF3AIjtEhBASVkgF5KIfxnU MyaRCmEWdMEZXHW9s34zgGKAa4Ztp8myNL+U+K4kOWiVm/7g2wIu2XKT2O8KzKacCzl06BjLCFD aXyOt2c0ADYy6PQDky0dNt8LAmPm5Zj8S+WTH935t/OauP+TcIGvHBQWre+Ag+F8xRSIgyeyItP Rb98bObSCMon2X0QM4CAVT7ylOzZicVgWxb28JoIQxMesqtytd2H58huXoJEWT1YY4lz4hcO0vS IEAagYmAoDYVkB1P+seUhkVWGK1jSlAWN1JpWhj1pPw0VxuHiGpNUXbzk7VHQQtAqUzlaa4G+Pk 2wYAE+in6RlmVdzzZPA== X-Proofpoint-ORIG-GUID: dlJ-YQu7Ck99p5pW2Pr-ddjPvi-fT50v X-Proofpoint-GUID: dlJ-YQu7Ck99p5pW2Pr-ddjPvi-fT50v X-Authority-Analysis: v=2.4 cv=eJoeTXp1 c=1 sm=1 tr=0 ts=69ab0535 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=lOjMx_-Oxa8n0LcNG1gA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 All the users have been migrated to using qcom_ubwc_macrotile_mode() instead of reading the raw value from the config structure. Drop the field from struct qcom_ubwc_cfg_data and replace it with the calculated value. Split single UBWC_3_0 into UBWC_3_0 (no macrotile mode) and UBWC_3_1 (with macrotile mode). Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 15 ++------------- include/linux/soc/qcom/ubwc.h | 18 ++++++++---------- 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 070bf97e134e..51de36f5f40b 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -21,7 +21,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { @@ -49,15 +48,13 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D= { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { - .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ + .ubwc_enc_version =3D UBWC_3_1, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { @@ -68,11 +65,10 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { }; =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { - .ubwc_enc_version =3D UBWC_3_0, + .ubwc_enc_version =3D UBWC_3_1, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { @@ -80,7 +76,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { @@ -88,7 +83,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { @@ -155,7 +149,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { @@ -164,7 +157,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { @@ -173,7 +165,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { @@ -181,7 +172,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_swizzle =3D 6, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { @@ -189,7 +179,6 @@ static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_swizzle =3D 0, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct of_device_id qcom_ubwc_configs[] __maybe_unused =3D { diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 405d83f8d95b..d4a0cfb133fa 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,15 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - - /** - * @macrotile_mode: Macrotile Mode - * - * Whether to use 4-channel macrotiling mode or the newer - * 8-channel macrotiling mode introduced in UBWC 3.1. 0 is - * 4-channel and 1 is 8-channel. - */ - bool macrotile_mode; }; =20 #define UBWC_1_0 0x10000000 @@ -80,9 +71,16 @@ static inline bool qcom_ubwc_min_acc_length_64b(const st= ruct qcom_ubwc_cfg_data return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 +/* + * @qcom_ubwc_macrotile_mode: whether to use 4-channel or 8-channel macrot= iling + * + * The 8-channel macrotiling mode was introduced in UBWC 3.1. + * + * Returns: false for the 4-channel and true for 8-channel. + */ static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_dat= a *cfg) { - return cfg->macrotile_mode; + return cfg->ubwc_enc_version >=3D UBWC_3_1; } =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B32543D4EF for ; Fri, 6 Mar 2026 16:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815676; cv=none; b=H+HDgoS2DRV/vpiWzFOB68QLcxdOhQjxiExTZnr1ixTUAC7mQsElL3NxC1CjklFx53822dwiPk0rb4e9qEFeSeIN3DpGkxJBFXEalVx4W20FtscxkomlDzk1DwwR/iXm8KiNgaGg7aAk7UJaPkxieG+i0l6b56/Djc50uS4VCPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815676; c=relaxed/simple; bh=tj6XzNi8kmutyETp0LxvPkXmIY6ffqvxy5q//a2BCA8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gvFz8WAN9fOtEQ1vY4Ruhb3O3wZ2+lKoIU8xJlsoCJrRCr8iWC8e2rwrqFnCvUlbPhpnTbskx3C3bjfoP6hw+c8gdasLL9GXeIsvOI9Kdfb+lf2tGOb7nVSC01Wo4k2Djh2VIxsLv6LNipiK8j3OFjvoOJ5nMlm2U3P1jg9tKHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A2f4iqvG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fXvmLpah; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A2f4iqvG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fXvmLpah" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr6FQ1424362 for ; Fri, 6 Mar 2026 16:47:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vA3WhLlP1iWl7UcsLAeaGw5jmPq/306vzHJjVKcA9Vk=; b=A2f4iqvGh5/XTNxD 4BsQ1urPOXzpo2jJkDEyA+P+E5+678DZqJB4tOYGf2b6C2Lc3HtfdYVByFj9uvvh W2sHYGapgvK8Za2JHW8JEvi9eKAObnJjbxpHYPZ0ABbuVu6QQbu26O72MG0ElRx0 YIYMwoNVWxQWMO/bwt0TNWwK1X7ONAtpNgHIpdnJVXuXGp1Qd+UTxdIGdEb3fhWy 64wETICqqpcdy8U1f0EGhGuezmIl3LN7mM2VqXqj0EK2wR0xKhY1Q9ooe+qMCvZJ n+YEOzdYbpdLA7/LF/8k45G4euVRIWQRbahEIBQ9S22oCymIHqmGJHE+i4Hg481k /Xly3g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqrf5t7yr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:51 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3fae6f60so6040711085a.1 for ; Fri, 06 Mar 2026 08:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815670; x=1773420470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vA3WhLlP1iWl7UcsLAeaGw5jmPq/306vzHJjVKcA9Vk=; b=fXvmLpahdqlSYQ8urhNdcBfUeoQIN5KW3ZDMclHTGUCfjwkVwuvRrm6x3SNBAS6aZC yAdq9lqbRzfmE2YvkK0Py5YKXgo+8fSqdptldtVXXp7SO13ncsEvwgtDn/HQiZ2NGnEr 9OtIwS75NbG6DRA/jxkhkD3CIxvqqv5CgiuIJMkAch28U+9tKbEKgcIl1q9wXr9OU4Kk OCZtihUO5DtPGbFcU2RqfvG2n3rn0jjY2kXPDyS9cLJzePUEX0WCXqfuQvJzORKjfkHF Yx+Ese05Z4ttTSGZsGT8clIs6v4PLrzOUGkTsEpM8Gyxc6/AdwC+Wno3PCTWO1LpjleN 0pTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815670; x=1773420470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vA3WhLlP1iWl7UcsLAeaGw5jmPq/306vzHJjVKcA9Vk=; b=PRFrzmZyFU8CUeZODsFplKG6jxN0wQDygEJgeATprapeStzg+0PiUIAQDQ86tpHT8o 2pzNYxXotB2Scl9JZIU/Zl6GTdAV68cURVwVmqbNFNb1mmcUIApcouUEXHNqthqzEmyx uXLBZVfWidMSRPfoc3h9+/CJnYNYiPU3NadFwUKh9JPGjtvpXYJs+m5fN/mHRu70jOEk bA43SQwLrAh5BSbatoD3M4vxZhz0HselZzsbc78UTByfF/0TkPzxb07bLInfHpe9TMY7 r9l1aNRuCP6ReXWw90HJ18hedJfx8uM+ZjsfKG2tvegH+P0MU1qA18i9CWZ82r2Epy1C pUfQ== X-Forwarded-Encrypted: i=1; AJvYcCWbOk/KD+1A63dbtDLGMicifR4wO/2MCm297Ex6XUVuc/TdPynPaDi/H8Ac8thoS8ESbyhNrOO9rZ1i0Hg=@vger.kernel.org X-Gm-Message-State: AOJu0YxVhEkNk2qBgKwcX/m+V2gdqIX4Mi6i5QlbgSUKfwqD5W3O5hC+ NRvsxgaSDM3nC+HVS6LWAFWloEPyaJHIG8BFESY7lpMIUrbYJyJfT2NEHsRAI425fxVri6oak7C LKN+4clejN+8u+3saLGdy+hRp6USCwtyBFwvzmImHiGHJ5NsplY8oT4koZB/q0EH1uJ7QltQKpC o= X-Gm-Gg: ATEYQzwY719K4AfLj1u9Im703ntedgOiWdMZqTxtjieIx4uWaH+ONEMFS5PDUxalDbw 0BMbwPUstIb32SFiCGUlRV2MIfC4FhMiUwr2zj/cXRRTCNW6AUPh/kB8yjwYHGyUjmT18rLjdyn Gnn0lvTDRkpVZzHyOIdz+mgr9yllsnYojCxrE1eHHoWmvwuTaGrV77lB9rZtPGyqXdKxw3hMlF3 TiuzagbEgVDXrg2tzpHLj1KUPGj+MwhRaupyLzW5wfPaG//C3/giIql3Cte8YmeeWQlN4sejxbH 0zIvR1kd1q5f6FwO2+ABV9XfP1BhTZybYw5glKXBvSH3BPLji/JZFO9LnPT0o7g32AYaVYCRjCv m9jh0Eyg6vjVspY6H/qRNCCiaYJ09BBQ/Xgzrq/M7XsOwh6lyfjc1NpUFGivqYkbC9uU5YI4phP 0Lm+j87GnynuzsNNwq8odxqjqi9/wO2YNB/dU= X-Received: by 2002:a05:620a:1a2a:b0:8c7:79d:f91b with SMTP id af79cd13be357-8cd6340944dmr796464285a.6.1772815670165; Fri, 06 Mar 2026 08:47:50 -0800 (PST) X-Received: by 2002:a05:620a:1a2a:b0:8c7:79d:f91b with SMTP id af79cd13be357-8cd6340944dmr796458785a.6.1772815669559; Fri, 06 Mar 2026 08:47:49 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:48 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:28 +0200 Subject: [PATCH 22/24] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-22-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5938; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=tj6XzNi8kmutyETp0LxvPkXmIY6ffqvxy5q//a2BCA8=; b=kA0DAAoBizyKPgIpKNUByyZiAGmrBRDIinuB5A3uj3d1RagdnQTSCFpIvCmm/XUFw1DrPZ2uS okBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJpqwUQAAoJEIs8ij4CKSjV4rwH/jRY pPq5zx6h96JKw20tkm5J1a3/9U3wAxmnVKSgEH/W5IKGN8m2rXObPKmsT0yndu9ogJ301zVtdLZ l+exOi6aBj24x/cd8Jv2uni9gAkcFJBtZ+McTmRJhdG93gaA759YowzZXt4KaSQu+Hy1uADwPEG GJp7IA1m82AzotujR36vroGpqziCk4Ra75MquvlFwjtz0TroezsCvghusAflWjX81jV9rxnI4oW VDQnR+I7JkxCWgA5C6sE4LnKV22oeawjA0+p6K1RKl+dbTGjQSQQZo7Ccpd986sXAy6yOBSFnfB UdnxYzutczs/Yl0/Znk+4dNtw0q0JuOoc3NYzTw= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: gJ35t95R_oe7JHoNiZkLMn1fT8s2RJxE X-Proofpoint-GUID: gJ35t95R_oe7JHoNiZkLMn1fT8s2RJxE X-Authority-Analysis: v=2.4 cv=L+oQguT8 c=1 sm=1 tr=0 ts=69ab0537 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=8a_ODPMxA7UucN5sxwIA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX838qanrCRS1L CnMjS3t6pr/p7uoU78+FB548j5GxxRxK1LZxV+3GgTfRrDET/I8JpXydDceKNtU/snlKnW1SWQE 2wEWjmkqb4K/q/oClKTHeuWaYYdn81A1K3XeGtx+ArK3gk5/v77oFNBrbA9oxGDQocsyZUcT7Vk Io9PHlr/eGSxPBNbpxr9W3NDv1hPSoxWkK0aAguScZ2uOLR3zPMo8GPc6V7wHIAx1hUjIh4ZAs7 K7rX7KZLWcvegqZaNhp/kyHPVYX6tiUKn5XcYlBS9YfcjBKPP5FU49sF2zlYamC+AZ8fkyRwaTM N1ZfbSYi6ChGmt7Sm7jtMofeuAcpsBaoy/2OD9Fy1FWKytofwl4ZzYkqBXKeKzz87yPX0bGKj3/ I+n0/8jFmyBaMTebQascS0vt3dcUEH9ZLUyXlaNIcNzUqt1kUfHxzM5PV97pzGSONMgEp33Q/7B OtyZrfdnr05HKmwCnGQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 UBWC devices before 4.0 use standard UBWC swizzle levels. As all the drivers now use the qcom_ubwc_swizzle() helper, move those values to the helper, leaving UBWC 4.0+ intact for now. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 34 ---------------------------------- include/linux/soc/qcom/ubwc.h | 33 ++++++++++++++++++++++++--------- 2 files changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 51de36f5f40b..49edfabb5e18 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -25,17 +25,11 @@ static const struct qcom_ubwc_cfg_data kaanapali_data = =3D { =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data msm8998_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 @@ -52,94 +46,66 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D= { =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_1, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, }; =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_1, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sdm845_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6125_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm7150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm8150_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index d4a0cfb133fa..0cbd20078ada 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -22,9 +22,6 @@ struct qcom_ubwc_cfg_data { * UBWC 4.0 adds the optional ability to disable levels 2 & 3. */ u32 ubwc_swizzle; -#define UBWC_SWIZZLE_ENABLE_LVL1 BIT(0) -#define UBWC_SWIZZLE_ENABLE_LVL2 BIT(1) -#define UBWC_SWIZZLE_ENABLE_LVL3 BIT(2) =20 /** * @highest_bank_bit: Highest Bank Bit @@ -55,12 +52,7 @@ static inline const struct qcom_ubwc_cfg_data *qcom_ubwc= _config_get_data(void) =20 static inline bool qcom_ubwc_get_ubwc_mode(const struct qcom_ubwc_cfg_data= *cfg) { - bool ret =3D cfg->ubwc_enc_version =3D=3D UBWC_1_0; - - if (ret && !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL1)) - pr_err("UBWC config discrepancy - level 1 swizzling disabled on UBWC 1.0= \n"); - - return ret; + return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 /* @@ -88,8 +80,31 @@ static inline bool qcom_ubwc_bank_spread(const struct qc= om_ubwc_cfg_data *cfg) return true; } =20 +#define UBWC_SWIZZLE_ENABLE_LVL1 BIT(0) +#define UBWC_SWIZZLE_ENABLE_LVL2 BIT(1) +#define UBWC_SWIZZLE_ENABLE_LVL3 BIT(2) + +/** + * @qcom_ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. + * + * UBWC 1.0 always enables all three levels. + * UBWC 2.0 removes level 1 bank swizzling, leaving levels 2 & 3. + * UBWC 4.0 adds the optional ability to disable levels 2 & 3. + */ static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) { + if (cfg->ubwc_enc_version =3D=3D 0) + return 0; + + if (cfg->ubwc_enc_version =3D=3D UBWC_1_0) + return UBWC_SWIZZLE_ENABLE_LVL1 | + UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->ubwc_enc_version < UBWC_4_0) + return UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + return cfg->ubwc_swizzle; } =20 --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0854611C1 for ; Fri, 6 Mar 2026 16:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815676; cv=none; b=WPhI9ek+nuGPMp0UjPxAajPE7mRYJOknGU2SUz00VFDuVGcy/p78XxBaDjmjLEhGVFGdnxqCpLNUOKpJzArHvdB+IBLcmyQ9IvHRBycN7jYB0lkmq6aDrSWpYKu3JA7rf2sX6Jq0tEFnNEhSloDcyvdkOUBm5vZo7lIHfgpZupk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815676; c=relaxed/simple; bh=8WidFnFU6pX9ecJLzeiZrTJ8KzhlV2H6Mjpf2nc28Pk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g2Luh2m3nDS89M1UGHhos5HOMMxCm2F5zwqEscL0FVf/063p4vKNv3YbHiEmPAbNkbMOr/DPKUcFUdC6VatRUTSbJb0j4Atj6xO/MmesB6xhZONyC7QKffPYwNmgKbvDIAZ5wbqfXq8bdpeae9veHSW4UF0UyEM3gzVfZtG8Qf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LiZ2bxYL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Btth3Huk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LiZ2bxYL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Btth3Huk" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrBeZ082793 for ; Fri, 6 Mar 2026 16:47:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cZb8eZw+Q83o+RlHHgWXaiw17CCH07r6st3FY/t2sq8=; b=LiZ2bxYLzVssMrjQ dwtQ6ZtcQ4t6ddMaCjo4d7gdEsCbn9iR82OtxuasTZtEIhnfQY6/RIGT/N2yEFNp 6qj2VIFaMWgAEnYoJfW9rxw3lerXUmkrEziC0DTWV28eBoOEz4U4lhYiXHKj3ArS csoLIY5O3spFkHqNw9RwO/8rtViW7PAU9CAjVps/YGg0t6zMTx49zH1RCCgfbBfD KyiFo2rHTC9KwlwMjWE1JRCaZHn02tYfSOM7OiPGlhq/Si5lW5FJ4Nj2gluxSNuq Z9RBMxl/QfP3gtdafRSldV+SAuWtsGVhi4AiA0Ejo3IX1HH8b/3p5kG6vyv9Okla BFIFDw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98hc2g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:53 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd722c1a69so171394585a.0 for ; Fri, 06 Mar 2026 08:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815672; x=1773420472; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cZb8eZw+Q83o+RlHHgWXaiw17CCH07r6st3FY/t2sq8=; b=Btth3Huk6PP6u6jrttFC0OKNDOCWAGjiQ6Xyi9MbsL2QPtYuqYAZ+HxdvhIW6CGyNL 8n1lToT6BWfa9seEYIbMrZvcV44qnOZilXZmihKKuG/rojnCriLcntphwjPA6JuYdGxa SnrVuHIvm58hQ4Acinto4Mrkka3IaYrT/Tq7CUTUt1XvZP11rzAJ4iOnKxi1t4hmuxRx 3SiGTEmV20UFE+XC5QBoXEoVs/qfV7+lFOJCPPUjj23ad97uu1hnL8/jwSzMIH0EN0/W xRIRcS3syc2S68Y4jpCWGlnrTB3VXULwimFbJhZw7DkvH4cfkbQQ+U7ZJnsLavLXby1j E9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815672; x=1773420472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cZb8eZw+Q83o+RlHHgWXaiw17CCH07r6st3FY/t2sq8=; b=jPJCEvHioIIbtaC5N1JXiAkVPnzNYb+v5SJyRd/R292hr0yoelttsOxjjWfwVA93pg 1wLF9NryJ1DtEBzUCdOdJEI+tALY4mqHmxY+aNfldr+1d1+yIAdpimIdAX3WSOnymk9K RHnuRYEv5hRewZNjMUclQz4+aTIK08C7XRN8gjXFNkm0eVeZeCR3feJjY//MfzasisP9 jb52FDVKiUf96AXn1Ts3KM+wvMKt1nWa/IjOfh78fgq+cXEOg3ef4hv0WeZzOYu5DToj 3Z9hK6tLtitSAz4Lzo0a98S5cLfL5PEzEdM7hDyt9M4cXBlJsGVv1dH6fpYj9VBKrJHn y+Bg== X-Forwarded-Encrypted: i=1; AJvYcCVTkwkd3kk2C9N8oLkCgWZQOTQAzTAJdvY4hlslENPMS5AIksN1eHA8NpBtKeUPe6VIritbVc342JG1CSU=@vger.kernel.org X-Gm-Message-State: AOJu0YzUAMga+eMZgfgGUDEt7IMlGWlyfK3bujD88IhcpU+1m6sgmGot JVD5UGRQCcQyzmAb/3bm473Lau5XjU8vPddUUeirq1rJZVQmjVP1gpdEPJCz7g7KT59Of8fD8M5 YEw94B7q2+1xZN346havh9rUs/0ENRfWyiO7uRw0zuRw01wIHQG/zKaf8IrBcI2qOUIWwIXVPNS c= X-Gm-Gg: ATEYQzye6pU8lD7V35w/Rum7JT+92hcwiVF7wOj9wHc8qawO+HuWQiaHXWsdZR/osUS 9Wj6VLb8JlOXqZEmRSiwWMEnhOagwTanUc6sYVlMkvekwjeMRVdg3GI0TtK4VU0EobRhP7fa2lP dUIn+l8q0PirRfLtD9/dfdPSJyjmh2eiOYy4+6bZ9rp4xDOJjslr0w9sw3CHVXem6g19lpGlkUM y3h7VTgYFFSOAX/w8UUe3En/K4yNlhGdyJ+uvRHpdsdLPdRe3fBTaSOKF492ykinUKWevCJd60a Z2m1PsA/1M7kbBectXleNzfmCxdkEK2Zp3couoCFuUbGBcPn7Mj9xPIHvPKBeOixt1uY548jJ2y JpJbbenb8da2H6V0DMNBElr573otg4F0+9ALpenhlCdPpOKZ569asIztf91zlD3RUylO9dXmEsG pXZF88RZMurseTQJS+nKIWF+Ib34FHV8NYO8o= X-Received: by 2002:a05:620a:450e:b0:8c7:19f4:b585 with SMTP id af79cd13be357-8cd6d437e12mr357961885a.43.1772815671545; Fri, 06 Mar 2026 08:47:51 -0800 (PST) X-Received: by 2002:a05:620a:450e:b0:8c7:19f4:b585 with SMTP id af79cd13be357-8cd6d437e12mr357957685a.43.1772815671045; Fri, 06 Mar 2026 08:47:51 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:50 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:29 +0200 Subject: [PATCH 23/24] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-23-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4110; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=8WidFnFU6pX9ecJLzeiZrTJ8KzhlV2H6Mjpf2nc28Pk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUQAZ+0aWPY3IVYykrhRri6p7g+LTvnjvKP6 ufdhY52g+yJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFEAAKCRCLPIo+Aiko 1WrJB/0eS0DHsvjpFfzh4DNP0t5Gk/kPiCgl8jnqQExo+9O/doJAZffcqd/dT4qe22aibnWMn6E VTgdGYhjRrKycFpmz/JpnDz+5YABXYX6ABlXi55nugrW1JVtxQUmhRSDsRn3aCEtf2zafBZlBq7 OuDu67brybndsSHN4tV/NERdu/ww2CF8HaQmPBM+6Kv741dx8X0pMWWcI3ImuhE4uzGwai3iMuH +9aWnuJUYxjrHaHKO7fT4UFV/HFFVx1gD9EyMTr9/khOokC8QlQZXRbiSQPbLDxVrtLqqbRYQho vD2z9Fi+LabuDcuYVkaLHIm3RpLEmgyqoPGuQa6BjuTNAVs6 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: qbMLUEH6oy8Dw_qosUVXd2OMb4K0ilek X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXyccLeH6DG3tP AYRr+7ifLM5vh35Y2aUS2mk53GpqTyYa53qXZKweSAKLrqO4yKNbwEed9kUbrztFMwkws3tYPJp +I/NrVh9Fo5nw23FdC0gcPIlgO+XbuLN5m8joGINHV1VthGCtAvQD9lJAjxRhY4HpE0sg75VdcD 2aTdW/Y1srrVG/9k5FA3sFh+dQ1t7m3WLeJianfHXQGoFAbZaKgUVFweWo05LWr1yUMcnx8ne6K emBrRZFWibTbo8zdcFrkEqjUV08/ERKndAIZFZ+Uzr9nKEb3TToBpMwArG/Zn7dCPekcoQpwkDs VNbZVhKYpTox233LoG/obsobWyiEwu/HdE3wHKpNk7VFvfkvK4HpF5apKFB3IbbriETiQx6wwnz k04/YOMD9j9dnE8nke+Tnr71wRUlLUj1GlyjPmXiCQiCvCd17EL377lt0SXGsrPFgBqTmguE4RV 2wKLadm8eUtRqfGF4nA== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69ab0539 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=SdgSTUjA-qPM3NZmnp0A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: qbMLUEH6oy8Dw_qosUVXd2OMb4K0ilek X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 Sort out the remaining UBWC swizzle values, using flags to control whether level 2 and level 3 swizzling are enabled or not. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 14 +++----------- include/linux/soc/qcom/ubwc.h | 26 +++++++++++++------------- 2 files changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 49edfabb5e18..ccee20913115 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -18,8 +18,6 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data =3D { =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { .ubwc_enc_version =3D UBWC_6_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 @@ -40,7 +38,7 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { =20 static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, .highest_bank_bit =3D 13, }; =20 @@ -111,38 +109,32 @@ static const struct qcom_ubwc_cfg_data sm8150_data = =3D { =20 static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D 6, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D 0, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2 | + UBWC_FLAG_DISABLE_SWIZZLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 0cbd20078ada..953094b73459 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -14,15 +14,6 @@ struct qcom_ubwc_cfg_data { u32 ubwc_enc_version; =20 - /** - * @ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. - * - * UBWC 1.0 always enables all three levels. - * UBWC 2.0 removes level 1 bank swizzling, leaving levels 2 & 3. - * UBWC 4.0 adds the optional ability to disable levels 2 & 3. - */ - u32 ubwc_swizzle; - /** * @highest_bank_bit: Highest Bank Bit * @@ -30,6 +21,10 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; + + unsigned int flags; +#define UBWC_FLAG_DISABLE_SWIZZLE_LVL2 BIT(0) +#define UBWC_FLAG_DISABLE_SWIZZLE_LVL3 BIT(1) }; =20 #define UBWC_1_0 0x10000000 @@ -101,11 +96,16 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_= ubwc_cfg_data *cfg) UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3; =20 - if (cfg->ubwc_enc_version < UBWC_4_0) - return UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3; + u32 ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL2) + ubwc_swizzle &=3D ~UBWC_SWIZZLE_ENABLE_LVL2; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL3) + ubwc_swizzle &=3D ~UBWC_SWIZZLE_ENABLE_LVL3; =20 - return cfg->ubwc_swizzle; + return ubwc_swizzle; } =20 static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *c= fg) --=20 2.47.3 From nobody Thu Apr 9 17:58:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A57466B7B for ; Fri, 6 Mar 2026 16:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815677; cv=none; b=oHJO8QYSkFEsryj/SwfPWKt06QuROf2SWbtWT4wp0OnfiAO4PzJsunAExmipNFykY+L3teBisonTBgrjeR+BmKcK2MoD/LwNL3mzH+cE8qiNRTHqMwQo+v1jumEOyeS6x+5kvhAgdd/r1k/3bbYrUeBlau1m+wYUUVw9hQ+HGiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772815677; c=relaxed/simple; bh=/BbDUKCz/O5KmFNyRz0+9nN5/pGmPXixxn1sr+yj/UM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GmeHrgED7HNW4Eu+1IPxHCh3l39aMfV2It9IBxOzqKp/3xdhu4z97UmOFDLoeNKBYNyJuyF6O8SQEhfFbfpmcJsRMm9yigVfBe0p/YdWMbqqqUi03tIedVT5s4mCPTU/oDo3caTcdWDBM1tEp4jFIDIC+vfsZmLUs2ezbutcdhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RaJH+McP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iLiytFuN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RaJH+McP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iLiytFuN" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr6iM082651 for ; Fri, 6 Mar 2026 16:47:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Kc0CUSfqNxkAu0RnvxpVDUQEcmtNJShHwAZtVe0NfAI=; b=RaJH+McPRDZR3nFP oUP+Ye6Ookspvrk3Ou42479ZpuB+v7sBAWJ98SpTgkS2eEkWngJk51d1Hh36k9Wv fXw24IiEHBa5Wdh1sdRDiUkM6jESruR4YhSlp2Kc+4JKI0shqMNrmd3RHiFFhtNZ Xi39uxYuOX/1BuoXes/lXA2kM+1V/X03L6qRI+GZtfnJKXTmHsoLZebP9qMX656i ZLzuTlmwu+WgcXqIN3gMlJh4joq0uRO2PEPw7XDwdZSseLoxXcJcEB/DF1ZYES5b +xE/aE4vYZ+2NqRJ2r6xdHghiulCWz9EkTq7tVUWgQBpDsF3udgyiARA4kNOdbE4 E7v6ug== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98hc2p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:54 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89a0796368eso282884326d6.0 for ; Fri, 06 Mar 2026 08:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815673; x=1773420473; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Kc0CUSfqNxkAu0RnvxpVDUQEcmtNJShHwAZtVe0NfAI=; b=iLiytFuNazyeU9HP3ErdBKR0uqstycN1T05nau57hk/HVkjV4wSxMPvuo5Dp36LaDf kdHLqI2LIahfaSkCIeUJ4so1CzbdwEjiyNbhoZLuW+HFyyHDZdtvv3U/704AkKfb0aj5 n3eHp+Kt/tO5ziyR/sB9P7YZzuGsJfwgdrR2VQUPOYkpaQmtA0bDfPv+reMatF9oawgT syPsAlly6IrlxmKT0efNm18sLRDRuXHyqycdwqwgDWM4QgCJ0v4BnEBY9vSBn6HOJpPA IxZMXSFUsR/+jib/DdRP3Ukbjgj5oZRuLu86U0K33T4SNjGuOcxbDSiBXfwds93ZRXXN DIBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815673; x=1773420473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Kc0CUSfqNxkAu0RnvxpVDUQEcmtNJShHwAZtVe0NfAI=; b=GNribGvrBl59Rc87fJTk+wnmTNHUqep/c/gu4pWNfiMUcLFASqYml9iU1jwA5QiBPi PECKemo1avLBi5aPBg7UhKVT3D3iVLlxf++PH5BNw1P0KyjbHy6kQXzADwU4Nqt+c2Ex 7EL1qI7VGlD5nCGmLfkZdKp6vlnIiEkeGo9U5otciio+KUIsirIUsHtbwfTaa4uV4pNg wT1VA8r6RFNX/qM+tX5pKQyQbRqhKAmdo1KTpCFB0ETeC3aaanbms0JFLzE9FmZGzwWk hxrXdCJjawwJTR/KTPXEZqoPXkmVw8AExH5u2ZIADLjFZxWMR3XuF8TuZM89O9fDUSfN tCRw== X-Forwarded-Encrypted: i=1; AJvYcCXOnWb5N/nXZ63h4FmhOweyPR3Jc7Ftk8zeVliPOFBk3hOkgJcIDtPADVLjq3FCSXl0YzxbRfqx0mmq+2Y=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfb2TIlFD/aIisXLkW8iZrg+il4LukzhDHbMyxsCP9T6r65ebE C3GA4Uq+AZBI/aibPfh0IvNCBBkNfTU5hC6AJ/fG/naydeKHauPPl1fhn7GtoUySG1UZ18u/o3T hLp4pUgg0a19WzIHZIVLoEkZlsr0QLXSV9o/KcHxW0vzLvgyrZ10ZXdhzIfqENE4GcmO6CQIN8p k= X-Gm-Gg: ATEYQzwxdKcPOFWLx1UDV9MkKd79rSkMtPf+rBrLsyaNx8ula8e5f7xNJ5l4wQDaydV ACTzGcBdyEI27TXIf8vytkEnkTWpZCLCimOG+n7iALlx9KNsCSDRyCk7CE9QakRGqrz/vdOTfZ6 u4mCasnNhXOoa4msXFoSBsOKVWi5PzTl2P62wopRoMDsu5GByHHuFkWr0GKT5OBuF+J8jbubi3d yCsi7kVx9hxt6Qsfy3Y7SZnfw9I+/PcEP9499FoLYkYBOxmWzmbQTJ2vVoORB4j9AS4vDwwt6Tq ia2XgDqU7vwCZYFVdn1eOTR6mwLnUxmeerAqLgRyteda3ZHHe7IpiuBLi0aU1ZkKJ5iZ+r/V4Kq kkuwCAyGA+0W8uDDGYxyj6WfAhZrDk84OZxLq85GE5fqEeWnp3ZvrIFA/AC2OJ3zZiGIE+X7koa DOvx+nYxqeDI64hyy3o+WlmPItpi/Y/9UgJKo= X-Received: by 2002:a05:620a:25cc:b0:8c6:abc5:f169 with SMTP id af79cd13be357-8cd6d4a8e8amr359971685a.73.1772815673020; Fri, 06 Mar 2026 08:47:53 -0800 (PST) X-Received: by 2002:a05:620a:25cc:b0:8c6:abc5:f169 with SMTP id af79cd13be357-8cd6d4a8e8amr359968385a.73.1772815672532; Fri, 06 Mar 2026 08:47:52 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:51 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:30 +0200 Subject: [PATCH 24/24] soc: qcom: ubwc: deduplicate UBWC configuration data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-ubwc-rework-v1-24-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=11041; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=/BbDUKCz/O5KmFNyRz0+9nN5/pGmPXixxn1sr+yj/UM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUQ/tteObGEMjsi7b2r8xJL56ZQfGZyKnIDh 2aBbGt7G7aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFEAAKCRCLPIo+Aiko 1X3pB/sF4Dh+COqQRMpVibvjeOIpX3Uo1z1aJukR266gLx4TmlUr70Ww+iioMG2y8oznCbLTc5A UP5D/w+z0fVI5Pc++uhwsdgPOkv5EFjZ2i+ttXtXYz7mIeNjKJ0CgwXe8rJYS9hZshT8PTXl7IP xfvAsCJ3l83KET6tD+JnwsQluN7wak3sjLrrhGOLqm4ezVMpJd2hY1KvhdYUkR4Wm/Gd5UEL6aP yWaeqfyECHIOOYo3uLbWYVyAXJJ3Yl+6zgCTvTDDl4jGqweeT4+MGarIy1+zFtignwdOavE6McJ Q6Lt8b97wUzK6QQ4HMCY44I8SF3hdsyWwgstKaRxHFCXXe5r X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: p5PKcKRArWewDjRDMHFGr6_U05uKUq6b X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfX890eb9nWMEPv VMe4SuiRfsXI6fsWVLauy2TKCDUHnSoDjFWjECFSNVANTWosZ119W3fZ03MsxajsnVEfNFZS1sO H84LjZ86g2ukFykhJ1ge6DzggwfidrXJuSP+SgwKbnKLLEvlYgsY781LuxljvRrU+herNJRoVVl aPnEtWuAibaDsgmUrTm1l6q3/vQrVlEHC5//llzMocyRXQFCgz3+RL2eOAF3vroUZ9AvhAv9Bg4 obI0V7mTJMPgkOonlNdDMVcbMCDtOMd6bf1ychGSIYS2GZtuBrTpupsiz0jPmGma6/72h9gZ7Tm P/7QQj0lexBtuwfnLdCzCKltGVhm3/IobR/jg9XaNnsVMu2VLeNV0FtMZq3P9GehdFpV1gD7VDC USK03yaHueD1oO0FA5LJkQlBIS67xYPzLI6UquAOZD9NzkQNJGSalS01IHHiG3KVZCOGcfl+VAY HnweB1FA9pz7zNsqYuA== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69ab053a cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=f57iFBScQPT45aafJKQA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: p5PKcKRArWewDjRDMHFGr6_U05uKUq6b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 After removing all extra entries from the UBWC database it is easy to define generic entries, common for all machine classes. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 189 +++++++++++++++----------------------= ---- 1 file changed, 70 insertions(+), 119 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index ccee20913115..2ee40a26ec68 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -16,119 +16,70 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data = =3D { /* no UBWC, no HBB */ }; =20 -static const struct qcom_ubwc_cfg_data kaanapali_data =3D { - .ubwc_enc_version =3D UBWC_6_0, - .highest_bank_bit =3D 16, +static const struct qcom_ubwc_cfg_data ubwc_0_0_hbb15 =3D { + /* no UBWC */ + .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data msm8937_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb14 =3D { .ubwc_enc_version =3D UBWC_1_0, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data msm8998_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb15 =3D { .ubwc_enc_version =3D UBWC_1_0, .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data qcm2290_data =3D { - /* no UBWC */ - .highest_bank_bit =3D 15, -}; - -static const struct qcom_ubwc_cfg_data sa8775p_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, - .highest_bank_bit =3D 13, -}; - -static const struct qcom_ubwc_cfg_data sar2130p_data =3D { - .ubwc_enc_version =3D UBWC_3_1, - .highest_bank_bit =3D 13, -}; - -static const struct qcom_ubwc_cfg_data sc7180_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_2_0_hbb14 =3D { .ubwc_enc_version =3D UBWC_2_0, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data sc7280_data =3D { - .ubwc_enc_version =3D UBWC_3_1, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sc8180x_data =3D { - .ubwc_enc_version =3D UBWC_3_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sdm670_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sdm845_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_2_0_hbb15 =3D { .ubwc_enc_version =3D UBWC_2_0, .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm6115_data =3D { - .ubwc_enc_version =3D UBWC_1_0, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sm6125_data =3D { - .ubwc_enc_version =3D UBWC_1_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_0_hbb15 =3D { + .ubwc_enc_version =3D UBWC_3_0, + .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm6150_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_3_0, + .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm6350_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb13 =3D { + .ubwc_enc_version =3D UBWC_3_1, + .highest_bank_bit =3D 13, }; =20 -static const struct qcom_ubwc_cfg_data sm7150_data =3D { - .ubwc_enc_version =3D UBWC_2_0, +static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb14 =3D { + .ubwc_enc_version =3D UBWC_3_1, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data sm8150_data =3D { - .ubwc_enc_version =3D UBWC_3_0, - .highest_bank_bit =3D 15, -}; - -static const struct qcom_ubwc_cfg_data sm8250_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_4_0_hbb16 =3D { .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8350_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_5_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_5_0, .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8550_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_6_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_6_0, .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8750_data =3D { - .ubwc_enc_version =3D UBWC_5_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ - .highest_bank_bit =3D 16, +static const struct qcom_ubwc_cfg_data sa8775p_data =3D { + .ubwc_enc_version =3D UBWC_4_0, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, + .highest_bank_bit =3D 13, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { @@ -143,59 +94,59 @@ static const struct of_device_id qcom_ubwc_configs[] _= _maybe_unused =3D { { .compatible =3D "qcom,apq8016", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,apq8026", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,apq8074", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,apq8096", .data =3D &msm8998_data }, - { .compatible =3D "qcom,kaanapali", .data =3D &kaanapali_data, }, + { .compatible =3D "qcom,apq8096", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,kaanapali", .data =3D &ubwc_6_0_hbb16 }, { .compatible =3D "qcom,glymur", .data =3D &glymur_data}, { .compatible =3D "qcom,msm8226", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8916", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8917", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8937", .data =3D &msm8937_data }, + { .compatible =3D "qcom,msm8937", .data =3D &ubwc_1_0_hbb14 }, { .compatible =3D "qcom,msm8929", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8939", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8953", .data =3D &msm8937_data }, + { .compatible =3D "qcom,msm8953", .data =3D &ubwc_1_0_hbb14 }, { .compatible =3D "qcom,msm8956", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8974", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8976", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8996", .data =3D &msm8998_data }, - { .compatible =3D "qcom,msm8998", .data =3D &msm8998_data }, - { .compatible =3D "qcom,qcm2290", .data =3D &qcm2290_data, }, - { .compatible =3D "qcom,qcm6490", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,qcs8300", .data =3D &sc8280xp_data, }, - { .compatible =3D "qcom,sa8155p", .data =3D &sm8150_data, }, - { .compatible =3D "qcom,sa8540p", .data =3D &sc8280xp_data, }, + { .compatible =3D "qcom,msm8996", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,msm8998", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,qcm2290", .data =3D &ubwc_0_0_hbb15, }, + { .compatible =3D "qcom,qcm6490", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,qcs8300", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sa8155p", .data =3D &ubwc_3_0_hbb15, }, + { .compatible =3D "qcom,sa8540p", .data =3D &ubwc_4_0_hbb16, }, { .compatible =3D "qcom,sa8775p", .data =3D &sa8775p_data, }, - { .compatible =3D "qcom,sar2130p", .data =3D &sar2130p_data }, - { .compatible =3D "qcom,sc7180", .data =3D &sc7180_data }, - { .compatible =3D "qcom,sc7280", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,sc8180x", .data =3D &sc8180x_data, }, - { .compatible =3D "qcom,sc8280xp", .data =3D &sc8280xp_data, }, - { .compatible =3D "qcom,sda660", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm450", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm630", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm632", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm636", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm660", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm670", .data =3D &sdm670_data, }, - { .compatible =3D "qcom,sdm845", .data =3D &sdm845_data, }, - { .compatible =3D "qcom,sm4250", .data =3D &sm6115_data, }, - { .compatible =3D "qcom,sm6115", .data =3D &sm6115_data, }, - { .compatible =3D "qcom,sm6125", .data =3D &sm6125_data, }, - { .compatible =3D "qcom,sm6150", .data =3D &sm6150_data, }, - { .compatible =3D "qcom,sm6350", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm6375", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm7125", .data =3D &sc7180_data }, - { .compatible =3D "qcom,sm7150", .data =3D &sm7150_data, }, - { .compatible =3D "qcom,sm7225", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm7325", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,sm8150", .data =3D &sm8150_data, }, - { .compatible =3D "qcom,sm8250", .data =3D &sm8250_data, }, - { .compatible =3D "qcom,sm8350", .data =3D &sm8350_data, }, - { .compatible =3D "qcom,sm8450", .data =3D &sm8350_data, }, - { .compatible =3D "qcom,sm8550", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,sm8650", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,sm8750", .data =3D &sm8750_data, }, - { .compatible =3D "qcom,x1e80100", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,x1p42100", .data =3D &sm8550_data, }, + { .compatible =3D "qcom,sar2130p", .data =3D &ubwc_3_1_hbb13 }, + { .compatible =3D "qcom,sc7180", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sc7280", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,sc8180x", .data =3D &ubwc_3_0_hbb16, }, + { .compatible =3D "qcom,sc8280xp", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sda660", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm450", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm630", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm632", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm636", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm660", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm670", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sdm845", .data =3D &ubwc_2_0_hbb15, }, + { .compatible =3D "qcom,sm4250", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6115", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6125", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6150", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm6350", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm6375", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7125", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7150", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7225", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7325", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,sm8150", .data =3D &ubwc_3_0_hbb15, }, + { .compatible =3D "qcom,sm8250", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8350", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8450", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8550", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8650", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8750", .data =3D &ubwc_5_0_hbb16, }, + { .compatible =3D "qcom,x1e80100", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,x1p42100", .data =3D &ubwc_4_0_hbb16, }, { } }; =20 --=20 2.47.3