From nobody Thu Apr 9 17:58:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96EA3344DA4 for ; Fri, 6 Mar 2026 17:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772817796; cv=none; b=oG8d8uPdCMKlqpNZyEO2mWgSh59DHOJdHiXE/nGjtFn9Oo6VYIM3tSExN9C7Gci2W5QaRhB0hwHEMRU/tjwJnzzxeH7znI+VIO4FGM09fWy4TxiCh9dEzEWYMblPU4HBju7JUXZ9YUUmxCO+NxpVlCyHvE+tRXgWPVsY9zEeUWs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772817796; c=relaxed/simple; bh=+mk4ppL9XWF9OnQIKVkGYEAnsfhU9QaSc9cxpk6TKTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OYYnxV+1KrEV56KuCY0tpaV37IIJi4wodDmk5myCeVTHCTUnshAbu2xW7RdeF5dZi5QqGASGTBQR83vKlwPEFXXSjxstwas31hII9SVo4R+ItM5UhV/WAyECGony3ZbJPZ8epCNaYz8OafbRRZ9zLMZcG4Oyzi7l2XdvNeO1oI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OpTHM7dz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TXCgZxVq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OpTHM7dz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TXCgZxVq" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626H1cIe1343467 for ; Fri, 6 Mar 2026 17:23:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q3cNLjTDzr/nLnZnG7PjL1WTHdf61SjrQzPwxu8BAtc=; b=OpTHM7dzpodWzTs/ yxAFrzmlkm4P9xoroXuQUvIrzvmk1AJcLRAoPAo+WCJxXWuRsWGqlc3bJ8Gtl15a bYNQkIvlxSdQefk8kKKWrVF//YCD3y9yuILPjKMSPvsEJ2AAFnW68mhiH9GWdiy2 5wA4by7nvNdU7O0JJ5oJEnxiq+TSggIgVPhRTaUPCrLuCqK5VbotSP72g6/461hK 9wz/3BahAJbW2HVdx1EUYjQQDDSndR8Q7n1K2lYyIkRidsCLVaj4KbHWo+Uke6qk viIiGGsz/sJSykg+vWDNotEzeQmi4EoX+H4/sKaaFZCg+Lfo9fQ5L9AaKGsINg28 DFNOLQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cr2uqr4f5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 17:23:14 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c70d16d5a9so4975355585a.3 for ; Fri, 06 Mar 2026 09:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772817794; x=1773422594; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q3cNLjTDzr/nLnZnG7PjL1WTHdf61SjrQzPwxu8BAtc=; b=TXCgZxVqEjhPpp3hqL114kl4xhfnqouzuOty8wX2cPHmX0IMyJAx/oDVqAKMhBbDHW 1X4l7ja5RU88MLzRx2kMqFmuwdME4gAQwCs4ndsHG83kY0zY1K7tUlxn4+D9ZHF0MpiG q6TOUz7ysqaPZjG5R+eZBZUN6b8nuhF4C6JJVrYigtpspV2+JSOdMAKVIwt72bF8AObY i/Sqm7Fon8nXnl6lp7ILHyeAgOWb/hh/2JhUuAjaqnlkfeLxfyjgka3cj9YipLa0bZRu qefMMXFNe2odcgGbudjasfV5QNE+oSUFzDu7HOxtnCiubY10nw+dDg5sC1ZsWbiGU1DE wtOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772817794; x=1773422594; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q3cNLjTDzr/nLnZnG7PjL1WTHdf61SjrQzPwxu8BAtc=; b=ZUC9gRnyyI+h+Gfy8i0jLl4lGHVfmWgcvaDgd7N6SIXURM6x5lCwoJ91Ui2dR9V6zA pOqSO8cRYj5IigwobDbIgsS6yJognJ2O2h+kIBVUjs0S6oWjMFbY3UoeXS6Z3UyyedgL KXbPhUK8SrcG0/dSeB4oER5UTJr/Ms9VWVRrLEXckw1jpPTsH5FpwFro1Nb+v0P/t3rO P8fIuDPIGwAt/XhwxyiYxKTbql7DHaj/l5kEzpMz1k1OHcEZdg7983LC3z0xDknTlR69 juDtViXzJywHh351s65HSFydLdNOfeoKBah3ryEUG19rWKcHamL4LAC0FEbiXUddeop2 BZeA== X-Gm-Message-State: AOJu0YxESxwKrxX2mmtKlJmm3vqKLLWcgotIdJ66mX2kOdJO6F7eEVB1 g7aa1CQWurYFKXBmaZLnAcB4IkFfTJ0mMIzrnWGJeuntcnZ07pPi7CfHmXO0GoEHKG1y1pjzmY1 g7QRdMjpmB08IKGZq3y6wtylx5DKBS8+riOmOFcgvlTact9LdoSiMDyAZUgv0vFS2C6U= X-Gm-Gg: ATEYQzwPAiVD1B4teq3H0iz10PjiFrTtkRnGfpWVrAMWgpsHqzxU7XWc8EDRUdHgTbF BjoS30ybUSyogxMiJP4g0x9YZNV7nfg6Tk0lyrc6SNqDBDh3A47xrVLSP5/hIaEchcNKtNevWQX 5XiZ4GxVlxjpT39EnBREEUjQFTTVRVqutaIPatztkO/1xGvGCaguSeKgUD6gxEGCKX1xtRor/0N loL4GhOVId1sjWuXVj7Y8OR4cN/9isl/w4Cn0O9sxLrhVmrejNWDokOnoUWZ99rxQ7Fw/QaKBp1 8neQTyVUFnCsZvj7FccBhaPPqdifK8nSIdjhhqaHwAIdOXTh9rzJa8PmX2hW+XdJXn63XOwGj0u o16TihyYDOYHEe/NJp3a69L9jssaFlKQgnrVgZ+zoMg7ur2YBx8qE X-Received: by 2002:a05:620a:1925:b0:8c9:f4ed:c383 with SMTP id af79cd13be357-8cd6d47f328mr338634585a.33.1772817793842; Fri, 06 Mar 2026 09:23:13 -0800 (PST) X-Received: by 2002:a05:620a:1925:b0:8c9:f4ed:c383 with SMTP id af79cd13be357-8cd6d47f328mr338630085a.33.1772817793417; Fri, 06 Mar 2026 09:23:13 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:28b1:4950:7702:bb20]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48527686fa9sm61488475e9.8.2026.03.06.09.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 09:23:12 -0800 (PST) From: Bartosz Golaszewski Date: Fri, 06 Mar 2026 18:22:45 +0100 Subject: [PATCH v3 01/14] reset: gpio: remove unneeded OF-node put Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-reset-core-refactor-v3-1-599349522876@oss.qualcomm.com> References: <20260306-reset-core-refactor-v3-0-599349522876@oss.qualcomm.com> In-Reply-To: <20260306-reset-core-refactor-v3-0-599349522876@oss.qualcomm.com> To: Krzysztof Kozlowski , Philipp Zabel , Jonathan Corbet , Shuah Khan Cc: linux-kernel@vger.kernel.org, brgl@kernel.org, linux-doc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1749; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=+mk4ppL9XWF9OnQIKVkGYEAnsfhU9QaSc9cxpk6TKTM=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpqw1xOkQhd+rB6pDIeELX9xfWtZzzDx0q39wy6 j5KEYFbCTSJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaasNcQAKCRAFnS7L/zaE wwx5EACstGVJDVO7uTcvBIPfJlwLjEfER2IA2XhDmvu0hwG8oLhF+1KWbY6Io2rAmfOx/ypJmDe nl+VNpEryICAbvye3FZXLDoc2mrbySNHcdRY/uIC6D4VxZXNtlatAQnUGfdCFdpm2WRliBdpZrk Np2pUL7rwogp2gc9Mp+YiNN9ELeDmehGg9+QzMP2QCNWNTzr11zXE9bZyrDbLvv4T2Nou02AaUD Rg8gIoSibOEJ22Xls24z6DdRIw2c1C4P13rtv7FQbo1RZDRpwUjUQnrA4xxcQ5xLjVGbyg6MSjx hhm3rOjtTzPVRrWc6xY9unW+FWEMeaVbn7Oyopcacz/nzUQ39KEmwY+7YlG+2zzK7aZh7SMHjNP Nz+vo4UP1NJ+qxZCeuofxMxoLstXdLFCtasgKFp6X317VL9ypo52m87H8JOrzWHBOuoApkchYog 3HLPbf6DIKOvl6vFj232hFwQX/nkESA5ctYpWXQEal6ymt4Ircy65vgrGWcEEX9sCRcIwR88Lfs M8iO9y5QCtiGHr+SpsppTT8GL/IVgO+86ewSbJY+1qNV8vzx6upQcTg8APSWEgZlAAwhHlOov2w 7rCSV5EsMp2HU4G7FfYJbJZ2/ywphbSSrS/4Z5gskuuFNEdE41O5wk4Wi+TcTZ5UcHx5cQCqW4j UPFSVYm6YJi20aA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE2NCBTYWx0ZWRfX/MV+BkUasqHM w2kTklR7gvBs3q8HmGimV0XWErcBm2Jwj1PTcHxK1fZSbhA0TEyG0+VtaXC3bzy5Ys9vhD3Owmr 02m7TPctj/yGHMGpNuETrQF5bAlY1DstlYgFOeZlusor+JNejB5FPNiL5LHB+U8DC9o/noBzvdz /wuwqWCan0RgtNxjOl+Fs4f5NVucXHLYPbF1I23nyJDS5+3WQ4q2m/bfdiKjvDoM+DAZvgHdkpG WVoQ3CYuuzQ5+hLmo3N3znJMMkssq2yDrewTjdgLuGZyv1mhF8/ARxwchazfvPA0IE7WaR81Nl6 TIyEyAIN1J7uqH85fc7S3pVJBrqmpt0AAbrD4PYk/ozXnkeQEq4hlRjuvxRdKcVFxoUbFH/XKzM I0YyI011vMGAMQmDQLTdbyqM6yeDYSJxC8V9Y9SgO1to2XfLNNYKbaKRM4GXBaPuzj4gwghrMvF NOo9aO9BZzW+FwzQTlg== X-Proofpoint-GUID: P1YMGRFOfeY4IhAW13UE78SykTBXQ6bD X-Proofpoint-ORIG-GUID: P1YMGRFOfeY4IhAW13UE78SykTBXQ6bD X-Authority-Analysis: v=2.4 cv=Q+HfIo2a c=1 sm=1 tr=0 ts=69ab0d82 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ygpbbqW4ee5_35vKHe4A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060164 priv->rc.of_node is never set in reset core. Even if it were: tasking the reset-gpio driver with controlling the reference count of an OF node set up in reset core is a weird inversion of responsability. But it's also wrong in that the underlying device never actually gets removed so the node should not be put at all and especially not at driver detach. Remove the devres action. Reviewed-by: Philipp Zabel Signed-off-by: Bartosz Golaszewski --- drivers/reset/reset-gpio.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c index 0a1610d9e78a3f1db8f523654a548fbba6087106..ad5bfe27aaef7de57f956633025= 3333aa2b1253f 100644 --- a/drivers/reset/reset-gpio.c +++ b/drivers/reset/reset-gpio.c @@ -52,18 +52,12 @@ static int reset_gpio_of_xlate(struct reset_controller_= dev *rcdev, return reset_spec->args[0]; } =20 -static void reset_gpio_of_node_put(void *data) -{ - of_node_put(data); -} - static int reset_gpio_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) { struct device *dev =3D &adev->dev; struct of_phandle_args *platdata =3D dev_get_platdata(dev); struct reset_gpio_priv *priv; - int ret; =20 if (!platdata) return -EINVAL; @@ -83,10 +77,6 @@ static int reset_gpio_probe(struct auxiliary_device *ade= v, priv->rc.owner =3D THIS_MODULE; priv->rc.dev =3D dev; priv->rc.of_args =3D platdata; - ret =3D devm_add_action_or_reset(dev, reset_gpio_of_node_put, - priv->rc.of_node); - if (ret) - return ret; =20 /* Cells to match GPIO specifier, but it's not really used */ priv->rc.of_reset_n_cells =3D 2; --=20 2.47.3