From nobody Sun Apr 5 16:27:56 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012011.outbound.protection.outlook.com [52.101.43.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC24374178; Fri, 6 Mar 2026 07:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781736; cv=fail; b=ASW5CQ0gHKrcvVp026yrxA7Jh1MVQs50InfCnTLKZhL9Jwd3gWkssUiTIW5QRteYgETY31MblNx1CCOQh2uerjsxkHQsKtdACeOxM0292fLUQfujuCGL+pcGRyJLgxk2TGkCJSv/lX0oCF7CVbXnMokiOz/SwX3+UTy8PkZ3FPw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781736; c=relaxed/simple; bh=lkOr3PqHOZQRe53fKYGGKhYAkA3COG0a1hRb8KLJ2DQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=DUMn6Az/5ggQdtYeD46eR4ERL6mHMjcIq7JGkl5n65c/NM5OkJLWWfkFvaqGEmZcLXZd43PX3dUdJUbQJ6a7UJpDRbKKthTHoRfkWeI81pU3JrPJjsKeoTQ+/fYQGqlzc+BVoXhPxcy2GXvv392Rr2dev7bI2RbXEjOOItPIm/I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VypXoRCC; arc=fail smtp.client-ip=52.101.43.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VypXoRCC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d4ipT/D43IS3vvXkRcVplAUovybAl6L3MocDgE1ZDO8+U8b4KiZX6WSQYpUSoT1JGANuYoUyQgqKVlXzT+3xju5WINBvCJAzEO2bL/HPsEDJr6/7hF8iXFFklwvhj0+GCF+sf+vIsub5oH5TQi5BIx8Ntx19Fn4ObqstdEtT7F0Z5++9niTVQBh6KnkL9q4h0QIle3TidxLYnzDzL+m9xwh5PSYSKT44UJE8X2E4YnNBzXclmo07gMtC7CKa+vUH0JvGJZD5EQEpnAUeUx33w0le6echHIRlvGMax0acWjaL2gREGkNwSnI085ShLV06hVKjc5M0xiLeqvdT8LZTDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RlV2elmORmaHKw7bZCVBzJCNQE8R07ffJJ9cr27FbKM=; b=biWrdxztGv2ETXR5IabzdXIhVZyx6j/oY4Cou7i1X1zPNN5FSLGJDMcsMZ3WO2yaPLhSyoVdfbO8anvMFYRDFN3EyTmEgy62ePoYiNm45LVAdT1YPeEBeyYdSq10VDiZqLY+NlaIjEFixKKZwc3blNSndvjSYQmIr2XxA6a4Tm6Vmv/VGvJNkEb3i+Uy5LQ9x1AWVX7d8BdNIWSvPrgeTMJ7BLURgjYPSMQTBSx16wETlhvO9dUe2C3rQJNqVPsz+av3OnofkP5hHADYCFVniWd6nnoa9RVLtZg9BkDUXr7Mb9RKKXHoRh4CKycEcUzmF6K1ek5mUKjty8ZYXmJAQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlV2elmORmaHKw7bZCVBzJCNQE8R07ffJJ9cr27FbKM=; b=VypXoRCC3Z8XVftRbRxRz/X+dkTbx8y6RTXl35JfWx+iPLqMp3xTu47e93+DhZBaq/Ma8pbr8daPTOdeZwAexAXGAbfTLp9uaSCqUR9vVK6Rz3b67qSM7MMFEUuggWOKuDXIllWYsDyn+8ciyiIhjwOrNXQrYsW5X6+ksjugBJvbakWQ68QmAoA3Y+XtH9cVjAnNBVZJ58Da7YMkJY3+7ftcElt+h6QDU6DiSOfr2eDv5kn5WrnLhZoKGoH2ADT/KC7sU4K1CUxYKNmiwC/LoDAThUrtxwbHwcm2RBd6s87vUqLWQwQm8DRd9oilAV3w1pZNKAS5KtAcmOO/56KKjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by SA3PR12MB7951.namprd12.prod.outlook.com (2603:10b6:806:318::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.5; Fri, 6 Mar 2026 07:22:11 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:11 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:21:58 +0900 Subject: [PATCH v6 1/9] gpu: nova-core: gsp: sort `MsgFunction` variants alphabetically Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-1-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0022.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::14) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|SA3PR12MB7951:EE_ X-MS-Office365-Filtering-Correlation-Id: d6def3da-bd66-428b-4e78-08de7b511507 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|10070799003|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: J81J5fNCwH/R+MJqCDreQzPABDBXuNYjv1EepALHi1csjrwBPN+ysnbpgp0TIzQbw4ohdPrpYDe2o3YZtnEEsrrP2cc5ARVCWx5ofBeKheS5sL9iV0t9UkSEQ5WOjQ186iHCyMsYYo/kB9B7WZMiGaAXKSygJD6UYxHvgyE5wkVQEx+N42dM8BS0GeKf2suk7jp8ioJj19D0e2WhzOP7zp2wcr8lAapTYNY8JI20ApedJTrvJo3qNzvleTZMXBKOJaLzZA0q+B5Yy2cGqhrY0tZQvqXafYGWr5stN3Y3lzr5suyMng3ndukAyJTSWtSLXp6o7+o4Fadl+z/dJBc2maZNeSwDNs8KRg5C91u9wWKrNR/2H+npuSJORxqV0tEzxIUfdp1PAMCfeKN5MyZ3D9smBktazX08Gl2HCZEQn8booM4Shh/AszpC7djBBrtQRaxfzC8Mtj7M9xIiF8Tf3ksM60PHigqKp93a94188xkYEQr3/nlOz2CJOQsM5mRrPlyh2edSWq+c6WVzPTSTn8VwD+6IgLH3emiEeJEHjYVrQGBtdoxuZTHBDfnNNEqSxq//E+W3VvWXKrdRML9eZPaPsz1Xk1ZSXTFGbgzttG3gaLfTY/JGZGiQ9PqowQVMiXklTor3wXXEScvQOT9/dQ8lAq+ltowTSvQLkcrl1nRFAX51XFEiF+6POkRVB8h+YvPMMbqZcSTuadOfrSvuC+1BsQC4CCCwEAADmaxRopAjD+NydS7jr4vH8I1OSc8vG1IEkgcUd7xJqlMGLumoeA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXE3RHZlbWsyRFZ4dVlSRCtOWmJpWS81V2ZMeWJxTTBDamMvaDdLR0llaFFn?= =?utf-8?B?Z0s3dUptQytXWVdOQ1NCSEpHeEM3RFQxa1RTdSt0TGVvQmlGcCt1VVRFUnNT?= =?utf-8?B?OW5NRm1sRVozdW1lTlZuRFNDTWVwU1p3RFFuekR5TmsrSG4wVWtaaFNGV05Q?= =?utf-8?B?QzJvUWdIemhHVm0xbnZ1dGxXdXdLV0Y3bmZLaXBRMlNWZTB5TzNDUTZoYXlB?= =?utf-8?B?b1VuUHJrSjBESUEvcloyMWtPNjB4WjM5cEt2Mm9GZ0pzUjZBbitad2Z5L09N?= =?utf-8?B?MDNXMjJzRlptTFRKM3BKTXVMQ2JWanpQYXBaYjhySWlVYU5sNDhuVzNwYUFk?= =?utf-8?B?UXVydFc0c3JzSXdNTittZUxkczBFVUxTakpDdHIzVEdaamRwa3hhWHloQTJI?= =?utf-8?B?OUFvWHdnZGZuM0NDU2ZkU2ZINlhMb3hhazgranFUaWVsMGp4NUVITllnZlVq?= =?utf-8?B?Y3VJcE02aVpEL1BXci81U2JrQngzem5NK2krVE14V0ZWMDRUeWg4MTV6bnNQ?= =?utf-8?B?WmxlZzM2anZidFlWSTVKS0FZRzd6TTg2UFhHTDB3eVY4bjRLNDh0cXcyWEZ3?= =?utf-8?B?TlZ5ZW9lclZpYkNiNUJIVnFENy9oenR5emFrYVM2bUdnNHFlRXNNRlpLM25I?= =?utf-8?B?VEM2K3NFY1F3TE9WSjJTcVRCZmpBREZCVEN2andsMVROdm9xL25jWWhuRUsy?= =?utf-8?B?WHRZQ1lVdGNMR2FrUmE5bm5UYmk1dXdLOE5ROVZNUXNUbWl4dGFESzVRUTk5?= =?utf-8?B?YlF1Y3VPUFd1NkdtaUZqcmpZSjY1ZkVJTVp2ODhmb0ZyVnQ5VERoS0p4WlB6?= =?utf-8?B?VzR2NVB5R1R0T1BaazAvdnFXeXpjM3REZG9xTGV0SStzZkpOOCsrZnJhZThp?= =?utf-8?B?L3BYODZiUmRhd21ITnhMcloyVGdMRHppU2F3K0dkbVpxMlY4d0UzRmZZdmF0?= =?utf-8?B?SXZvUU9ZRkFtbUVodUF4NGhjUXM4akE2d0YxTlk3bEM0WWVwWGZUcjhpa0pj?= =?utf-8?B?VWxkbUxQcmt0L0poaXJMRmlDeWJhYXloN1JFMGFlNGR6TUhDOFFJUTFNcFRQ?= =?utf-8?B?ZjhnT3FCZnR6N2hqL1FaTkNpenRYUDNGUVUxQ2NDWHJMU09EaFNSNDBMWWtn?= =?utf-8?B?ZmdENFpOdHoySWt0czdVYUp4U2JLYlZnaFBTZm1RcDMxUi8yMjRhTVVrb1ow?= =?utf-8?B?KzgwVFA4ZDhKOGRNc1h0RStjSGVMRTl5MzNVK1VrR3hZcU9BOVlOb1M5WmYy?= =?utf-8?B?VGUwYW44MFBseloyVVVCcXJ3dHM1NXpZWGlNbWJRZEowV2Qzcy9mRHFyYWdC?= =?utf-8?B?QjFwUUlBclJLNGQxZlI4bGViRnhJVGhGMnptd1JaQU8yM004bU1VUUtJekI5?= =?utf-8?B?cVZmcFh1cXhDWHI5cmVoN0w1WUNiVHFzaW1iTjBNK2dxRG56TlIwcm5ucm00?= =?utf-8?B?d1pxMlJVV3IrQzl4UnBTR3RSS2lpL050VmMzV2VCWk14RkZrT0VwbVlaeklM?= =?utf-8?B?WmFLbXVWWElxZVJ5Q2VJM0Yxcmh6aXRzZ0VrWm5WUEx3eWh4SG1vTzNyVERi?= =?utf-8?B?a0twaU0zRG5KOGpyR0pzeEZCL1ZBQVFMOTcwdStvYm5GckpsMkpxaFpaN2hL?= =?utf-8?B?bDdnbngrWkdZSmZ0U1MwclFkTFFsL1hoTnFwSXBiY0I0U3B3ZGlZRWlRK1JZ?= =?utf-8?B?a2xYVVFxdzhpc0FIWTdWeldmNC9uZ2RUUGVHeUl6MmtURnNkcjB3eW1PZWJm?= =?utf-8?B?Z3FWUStpR21FK256OTJNSVFYVVpzQ2ZGN05SQ1BEbktVTGVDRSsyaUNWckRl?= =?utf-8?B?cjF4eTBDU3UvaU9SdUtJbk8xS3Y4dGdqVW92S3BuMC9WaWV5OGNabW1SdStI?= =?utf-8?B?Z09nb2lnazQ5QzVpaWErMFdRWEsraVFWV0NQNnR6OFI5RWx3THJ3VmI1aHk0?= =?utf-8?B?OWR3ZjlMTUFuWFVVM3R4bUpiL0g0WWhpNmJlWUl0L1l1WWVNUDRXcy9rVXlJ?= =?utf-8?B?Q2cxblZRL3JLVjFzZktZeldvZ213SFZheFowYmJEemFIZWY0Qm9DQndONzR5?= =?utf-8?B?dzd0RHNWTE54UTRwRVF2TzR5bXR0ZnROWjl4UFpwcG5DTjd1aUEyQ0p6cDBX?= =?utf-8?B?ZmJRT3lzVWNrMUY3Q2ZMWCs4SXMyN1RoNE1xaGtaSjI0ZkFsaU0xbEJ1NlIz?= =?utf-8?B?R3NMT2wvNytHRW0yci9mOVdtVUhQT3ZNQlVuTDFpdFJhOHhnU3JXcnBubFlM?= =?utf-8?B?RFNPMjZ1a0VsdE4zNFBmTkk2T3QwdkVKN3RPTjkrOXJjbXgrSzJhYTBOVjk5?= =?utf-8?B?OUJtQlB6RG1ZVmpkZEhqME41Tk5vM1dFeFpuRHM3Y3lpR211TXBMeW5MV256?= =?utf-8?Q?5VEOJKZbxWkn+rpXWA7prveD72ydLODeiWicSmk41REJ5?= X-MS-Exchange-AntiSpam-MessageData-1: 8wAhL0aKOv3Z/g== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6def3da-bd66-428b-4e78-08de7b511507 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:10.9626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZQO0VYgrmvcprmLmIWwH6ByeoOp4HBM07YGKb5krfyUarKD2GvkH3GhmMHHQG1B9SSo752r/Qsl6371phnlZ/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7951 There is no particular order required here and keeping them alphabetical will help preventing future mistakes. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/fw.rs | 67 +++++++++++++++++++++----------------= ---- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index f1797e1f0d9d..4b998485360b 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -191,34 +191,34 @@ pub(crate) fn new(gsp_firmware: &GspFirmware, fb_layo= ut: &FbLayout) -> Self { #[repr(u32)] pub(crate) enum MsgFunction { // Common function codes - Nop =3D bindings::NV_VGPU_MSG_FUNCTION_NOP, - SetGuestSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM= _INFO, - AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, + AllocChannelDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA, + AllocCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA, AllocDevice =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_DEVICE, AllocMemory =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_MEMORY, - AllocCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA, - AllocChannelDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA, - MapMemory =3D bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY, - BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, AllocObject =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT, + AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, + BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, Free =3D bindings::NV_VGPU_MSG_FUNCTION_FREE, - Log =3D bindings::NV_VGPU_MSG_FUNCTION_LOG, GetGspStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INF= O, - SetRegistry =3D bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY, - GspSetSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INF= O, + GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, GspInitPostObjGpu =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJ= GPU, GspRmControl =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL, - GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, + GspSetSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INF= O, + Log =3D bindings::NV_VGPU_MSG_FUNCTION_LOG, + MapMemory =3D bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY, + Nop =3D bindings::NV_VGPU_MSG_FUNCTION_NOP, + SetGuestSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM= _INFO, + SetRegistry =3D bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY, =20 // Event codes GspInitDone =3D bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE, + GspLockdownNotice =3D bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE, + GspPostNoCat =3D bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD, GspRunCpuSequencer =3D bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENC= ER, - PostEvent =3D bindings::NV_VGPU_MSG_EVENT_POST_EVENT, - RcTriggered =3D bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED, MmuFaultQueued =3D bindings::NV_VGPU_MSG_EVENT_MMU_FAULT_QUEUED, OsErrorLog =3D bindings::NV_VGPU_MSG_EVENT_OS_ERROR_LOG, - GspPostNoCat =3D bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD, - GspLockdownNotice =3D bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE, + PostEvent =3D bindings::NV_VGPU_MSG_EVENT_POST_EVENT, + RcTriggered =3D bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED, UcodeLibOsPrint =3D bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT, } =20 @@ -227,38 +227,41 @@ impl TryFrom for MsgFunction { =20 fn try_from(value: u32) -> Result { match value { - bindings::NV_VGPU_MSG_FUNCTION_NOP =3D> Ok(MsgFunction::Nop), - bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM_INFO =3D> { - Ok(MsgFunction::SetGuestSystemInfo) - } - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), + // Common function codes + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA =3D> Ok(MsgFu= nction::AllocChannelDma), + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA =3D> Ok(MsgFuncti= on::AllocCtxDma), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_DEVICE =3D> Ok(MsgFunctio= n::AllocDevice), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_MEMORY =3D> Ok(MsgFunctio= n::AllocMemory), - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA =3D> Ok(MsgFuncti= on::AllocCtxDma), - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA =3D> Ok(MsgFu= nction::AllocChannelDma), - bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY =3D> Ok(MsgFunction:= :MapMemory), - bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT =3D> Ok(MsgFunctio= n::AllocObject), + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), + bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), bindings::NV_VGPU_MSG_FUNCTION_FREE =3D> Ok(MsgFunction::Free), - bindings::NV_VGPU_MSG_FUNCTION_LOG =3D> Ok(MsgFunction::Log), bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INFO =3D> Ok(Msg= Function::GetGspStaticInfo), - bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY =3D> Ok(MsgFunctio= n::SetRegistry), - bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INFO =3D> Ok(Msg= Function::GspSetSystemInfo), + bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJGPU =3D> { Ok(MsgFunction::GspInitPostObjGpu) } bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL =3D> Ok(MsgFunct= ion::GspRmControl), - bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), + bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INFO =3D> Ok(Msg= Function::GspSetSystemInfo), + bindings::NV_VGPU_MSG_FUNCTION_LOG =3D> Ok(MsgFunction::Log), + bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY =3D> Ok(MsgFunction:= :MapMemory), + bindings::NV_VGPU_MSG_FUNCTION_NOP =3D> Ok(MsgFunction::Nop), + bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM_INFO =3D> { + Ok(MsgFunction::SetGuestSystemInfo) + } + bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY =3D> Ok(MsgFunctio= n::SetRegistry), + + // Event codes bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE =3D> Ok(MsgFunction:= :GspInitDone), + bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE =3D> Ok(MsgFun= ction::GspLockdownNotice), + bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD =3D> Ok(MsgF= unction::GspPostNoCat), bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENCER =3D> { Ok(MsgFunction::GspRunCpuSequencer) } - bindings::NV_VGPU_MSG_EVENT_POST_EVENT =3D> Ok(MsgFunction::Po= stEvent), - bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED =3D> Ok(MsgFunction::= RcTriggered), bindings::NV_VGPU_MSG_EVENT_MMU_FAULT_QUEUED =3D> Ok(MsgFuncti= on::MmuFaultQueued), bindings::NV_VGPU_MSG_EVENT_OS_ERROR_LOG =3D> Ok(MsgFunction::= OsErrorLog), - bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD =3D> Ok(MsgF= unction::GspPostNoCat), - bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE =3D> Ok(MsgFun= ction::GspLockdownNotice), + bindings::NV_VGPU_MSG_EVENT_POST_EVENT =3D> Ok(MsgFunction::Po= stEvent), + bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED =3D> Ok(MsgFunction::= RcTriggered), bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT =3D> Ok(MsgFunct= ion::UcodeLibOsPrint), _ =3D> Err(EINVAL), } --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013013.outbound.protection.outlook.com [40.93.196.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E55EE374732; Fri, 6 Mar 2026 07:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781739; cv=fail; b=M4IhT2qkd2v3L+0UtjXJ1ccCY1HR8UEs7DsL2wAUKr+xZ4zfG/HltvyxjWMGndGZBQKZs0mFwZ+isdG40IpMGZDvyNuKXTFfz8Qw2vck/Te2uwcaT+XM6zb8Am52J3TPpNFseMx+LpfOY8Urg+7WVd9NXcRBv3XvbXZXVThKWV8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781739; c=relaxed/simple; bh=8jy5jN4fNqeSUPhRa8k4JguI5XKxOqeaZEgIAv9qzEA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jafjE2Ttmhtsf5VNxvuusNBh1CiG36+dEktpc+8W7LYoIjED7II9T+OIGAp96Cxza/vwryQJ85/pflNszG6zabPxWOgXCymwui8WPuSVP7e1vy11encSWsjXxaXGtfClar/Qcb+xGUnt9QvjUa96/rwnA8BDfvxp0umu7VXMmGg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Z6LLc8lk; arc=fail smtp.client-ip=40.93.196.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Z6LLc8lk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bJ1p3KpsgUTkEHkNjxDbWrStuGNDXidxl3UdA8tnR+omu3FYQYlr3rv6v8rYrDgHGen07dm1d5LXAMFJoUEbYtW3HrKY+0fP8aouqzeIzTWJpqVnAVi0u3ec8MPJXDL1nPnBUh6s1CQmeb6bq+/MpCn8Ir0vgLZn7kCq2NHoUw/yQmPMJ8Hf78vQfyCk2EmfsRqBsCYfPm/jPtXUQ6NAyRa9olOXHhi1iMg/zC+4V+5F5p9vvY8pEfm9u15AOK6/HRkFbUtWvypZze2twuZVEb1RzXRDwmah7ilsObaX/UTFWDV8Axn7cqjxgnkzkkCKmVCnB46V3/z3bVnad7W1ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCDI1FfzpIaUEe+sRzK6rswblJQiKhPyjOAj8CGniP0=; b=g8r7YHQGGoQktwjLlocGEoWgfskPEmjuM7K36RvwHvWWe4CPYqFR++/baXHAAiAEoRxcxRdK0VV1fNYPaupoflxIO/qxMBcSehLLwgjHGIOEbMXFHyB/PwC8Qc93o/X/LhFSMif6f46QJpRIJL4eNmYlXviQ1wPr8uVEgEADU8DON1+6YFhx8HRRm9Ze9CCZ2Kk1aIdcxu6H7TyNQ8+qZ2CVO2o9pd2tBRF6axm/og5Bhc8yJBZ4J90fkdmCT7oYYgWh9EVbzAoZ9uCMdN5Po4RVqm77XDVaQ4TG6RG1oETwEpMoQgnIvJRpCtbfBmruvDtOFg111Rnf6bs/d59rNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CCDI1FfzpIaUEe+sRzK6rswblJQiKhPyjOAj8CGniP0=; b=Z6LLc8lkpdYDIuF3qFQEQwcEtNH6FbhK/fw1ktj85imtt772lpk8VtcLGq0ha5HP7MlOu207eyc91azLJPZYhW2ZxYTsmRCk38ty2pP+G74dtHQN/tLrqHMIM3QbPAW458bm9H1OOp6UdF2zVvC3GDjKyKPH05wA/+j+z8ksJ4gSXSKmN+UxuY8UlyAHo5MYZL9GCt5YAbyo1BpjARxV0sC8qd6iKYEp+ESQUJG1KAVRp83bAVXu4TJ1GCzN0FDn+U+c0ZOpU7zhabY/IBgHAQc6d30S3+rLgz2KlPIBXAVzMtjGAilzrK1euMHFLRvXfdNp0DVM3yDtvi93bCZJWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by SA3PR12MB7951.namprd12.prod.outlook.com (2603:10b6:806:318::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.5; Fri, 6 Mar 2026 07:22:14 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:14 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:21:59 +0900 Subject: [PATCH v6 2/9] gpu: nova-core: gsp: add mechanism to wait for space on command queue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-2-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0156.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:383::20) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|SA3PR12MB7951:EE_ X-MS-Office365-Filtering-Correlation-Id: 2efd1cc0-398b-4568-9e0b-08de7b511756 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|10070799003|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: yIr2muZ5wjflGBbmTvkpGgv6UnFPoNfwj3qVjdlxTYDdFHscDjh+T7eBYT6/HjiC43/PDUJYmMVDdT0rhkViOYvpaKdzGZ7L+bj9e2hIzEZTxAr2ePILmZEDemh5KyUCLFyhSSg2mpfHQi/pfXhhQhQGM63fZwP2xdlAG5X5Mq2Z1+b0b+MtGwRmStz2pVmArmTo92cUos/6D4R74TZIVrQl1bdPWNf6/eR0IRaFIKQ2Glymn6vJSbv/BeMs8ahicvkMd/2M+v5u9nBPmAAvbTyKq9+74ZBAPzlb7S/zF96cc7VNEm2R5SCmjMzN+jrqQ/8mzia0OiC8wWM3dP35XK61Ys4Vebs1P7XeuXr2tyaEENr1fBOyUlNl2fkYMjLfV/tfahFO3iT4VS+5xmtv9WaZt/gxyUH5R1KFI7FqY+PKJhFZ9RXxqm4vL5cskaWvSSnMxej8rUvaRO4opzckhV9Ty8WKWS824yxpMgnlU5fVf9A+lki41YZFw+ZYoBDvic7b98hqjbZ6YezDWcvDovUy0Z+6McV+hkvhCojhKHmPjfcgIisGykusiSBJHbRp3iL4vgzr0suaYEuHPKiV16V6JnS4hk60FpTZ21qTo8Txwd2PO4TPm4l5LiHlu1zhWlbbRgt8XZWGLCl0TsVm6ZPb2sHEPXjb+ByzA+Xa3oh8yvSrETZoKapVmi1I+sRaCsadK+VW2b9UeA5SJGRsO4e1jSQp7B2R+FUwMVbPfMWoKnbd++v8tHNofVmAxFtgSShBZtLkkOq4r80t974n/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0hIaWJNbVNqaEgvS05lL3J5aWlxMlFDd3ZSemdSajB3MDZqMjFEdjM4aGhL?= =?utf-8?B?V2swdnd4VmpyM3c3THo0UEFHTGJoQVMvRjdDZUxSM1JWUG5uUjBZdno2dzNp?= =?utf-8?B?cXpKemZlUkZpdC81bUpCUmZJbmJqRHhaMHd1OTlTTzJIdFMwMVI2dW0yVnZl?= =?utf-8?B?NFlPNXEvc2pvdGRlSDlaWndVUG01R1pabUE0dDV5UDB0ZDFDS1Q1UFBUc3Rr?= =?utf-8?B?bmQ4T2VRL3VjcGJMOVRXeHd4NUFnT281MG9RNmR2UzIwYmwzVSszYXFRV3R1?= =?utf-8?B?NXllclAvT1BLSUZnZVNXK0o1RnZPck91SnhLc3lPZVJDTVhHMmFVbWdTWE5P?= =?utf-8?B?V3oyNzVCWC93aWlRQ3YyYVlCV3ZHUnNTdGlpRWRDd0w3TVFUandKNjIrNzZZ?= =?utf-8?B?bGxQWlNlWG8rYmthRXR2RURBbktiSXRvbVJ6RjNXZ1lVbGF0V0FmUzNpbkhQ?= =?utf-8?B?aTNKMGIzMk0zL2lPTzhiTTJjK1llcTNKeit3TzRJckxRdHoyQytpQXJ3K0RB?= =?utf-8?B?Sk8rZlhuWFY2eGVKU1QxL01vcStqSFlXVXZ4c0VpaS96eVExRk1Uc0VwVFl6?= =?utf-8?B?b2FXTXdwb3ZjV1dwWWtwQ3pTTUVBMmZ0YWRtQjVlMUZrQ2pxT09WWjNRQVNq?= =?utf-8?B?c1JyQ2VERWNyK3ZwYVQ0ajc4SHlKanJnZjMzQ1E3VXJLWFh6Qkh6UzFUMW81?= =?utf-8?B?WUh1cldFTVFjVW14NHVNVEZCUG5mWjArRUROQ3QyNW1idjlKbEtqK1NrT3hm?= =?utf-8?B?SU5SQUZrNHQ3dTA3MkpSbnFkNnpaNDV4cXRmaWc2TWhZdjVOTFhBK2pWNG9F?= =?utf-8?B?OGt1dUppZVA2VjYxTWVnRWIrc2xLWTNvSm9aNlJsd01SY205SjdLd0pibW1s?= =?utf-8?B?akNpUEYrL0k4OUNHLzU2NHBHZFI3d0t1MXpydjR5N0xodmFEaTQ4M1NhZ3Mr?= =?utf-8?B?bUZITE1UY0c1eEpaQzM3djN4YUhDbWh5UFQzR3lSSjdLZVVBMUtWQ0RiQ1li?= =?utf-8?B?UEE3bXRhbmJodDNIellzZnhmNE43c25TbktYeWJpQnVocHlMU3JTelhMZzE5?= =?utf-8?B?Vytta1dhc2hTYWlVTUhqeldQYnZUMkdzZUVid0JYVm5kbnEwakN3ZVZCUXFm?= =?utf-8?B?b1VJNjQwbFUzVTYxYWVpZXdUcTl1M3d0Qm5SWlZSS0l6RmhQMSt2Z3Iwejdy?= =?utf-8?B?R2lCeFovSkFiNGp6RjNjOU41a0w0NDRZSjZwNkdLMm5iK1dBY0xnY3c5MmZ0?= =?utf-8?B?NEFSRGlmckdEY3c3ek5HOXllMktSaXVUREFZelA1d3RkNTAwOUl0bTlhVmhG?= =?utf-8?B?eE42SWlhQncvNUtuYlYrNk9UTE9XdlVzQllHY0Q5NVF2MjlTV2xveTlqUjE1?= =?utf-8?B?ODdGY0IxOXZYVjdKWHRJaDJMMlpmVDZpMjBaQktEVUpzMWM2eHVSSHJjZWMy?= =?utf-8?B?VnZQRTFlWjF6bkI2N1N5UjVvb1Q1a1JMeER0TXBPY04xR0JwaG4ySGV6UW1Z?= =?utf-8?B?d2JGeDJVTnJWL28vRHlNclNEYXUxQjllVWtEd2VPMFh6N05IaTJjK2xCQmx5?= =?utf-8?B?MjNwTUNCbnRyM21GMnRmay9xYXQ5R24xKzNIZnE4WkZjUnE0ZU1RTlZZWTJ1?= =?utf-8?B?ZEpXRXhoUmFNU0t2VDB1N1IyRkRkcm9Ea0xNV2N3UFZXUG1LQnF2MGZ4NDVL?= =?utf-8?B?UXhxUUhQcElXRlAzOUpweWZ2NVY3YWNLYU91SlVNSGRHaDZrMGRDc2hpek5v?= =?utf-8?B?cXlBYS9nREhZQ2E0YzlQcUQwQjIyNVRBTkdpS0s3TEhSUVd3R3pxNGg4VTVU?= =?utf-8?B?Z3JsU2ZhU1hqU0xOYmE0WHNDKzRnZHRFR0ZyeGcySWU1RUpEa1diSXI5bDEw?= =?utf-8?B?bWxXTlJIaURDNnNLcDR5aXFodEhIM0IxRko4UFpkUitvUVBWUWMzbEVNbVlu?= =?utf-8?B?LzVZOUM2MWt3RThaUi90YjJpcHhwRjFOVDNaZzdSZW1qZHk0UGNPTkJwUTdH?= =?utf-8?B?SVZEQmJjSEhQVkZaZHZTMGgvU2dSWHRwcjlIbFhRQmpvRUc0dElCU0xkUzdU?= =?utf-8?B?cEtpTE0xL0dsWGticUw4UVJXL2Z6SWExWGNSSml0TDI4VCtSejBjMzdreDMz?= =?utf-8?B?QlpIWWt1alVLQjZUTEs1clVJWFlmK2pIVithWmhqMDloc3JMYzZ1dkdFOHFk?= =?utf-8?B?SncrNktlUFpWVkhON0RwdGxEQk5ra21qY3RQNmI5Q3NtekpDNG5KVWhQUGto?= =?utf-8?B?bS9PNG51RTNLVDdBS1BmRHNKM1dKdkNPN09YYlRLUVJJREN6WGxTTUs4c2hn?= =?utf-8?B?VDAzSXpwb2YvaHREUW1JdVVkTVZ6RDl4VC9vSTZlZWxSVkdqSTdUMElndUNU?= =?utf-8?Q?QB5D/2wuayH7L4WsfmZHPncyl250AEhVsCkQM7RF+lN6I?= X-MS-Exchange-AntiSpam-MessageData-1: EpUfKcmjk4udQA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2efd1cc0-398b-4568-9e0b-08de7b511756 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:14.8176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FNkqlj69wmolT6sVaDYIvYXoH0S43AkdIugdhtD42AwKXjLyxEiU0/nIX330t/h8q5XTsdQFEQ2RsZdlfJg0Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7951 Add a timeout to `allocate_command` which waits for space on the GSP command queue. It uses a similar timeout to nouveau. This lets `send_command` wait for space to free up in the command queue. This is required to support continuation records which can fill up the queue. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 42 ++++++++++++++++++++++++++++-------= ---- 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 87dbbd6d1be9..12849bc057f2 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -250,6 +250,19 @@ fn new(dev: &device::Device) -> Result<= Self> { } } =20 + /// Returns the size of the region of the CPU message queue that the d= river is currently allowed + /// to write to, in bytes. + fn driver_write_area_size(&self) -> usize { + let tx =3D self.cpu_write_ptr(); + let rx =3D self.gsp_read_ptr(); + + // `rx` and `tx` are both in `0..MSGQ_NUM_PAGES` per the invariant= s of `gsp_read_ptr` and + // `cpu_write_ptr`. The minimum value case is where `rx =3D=3D 0` = and `tx =3D=3D MSGQ_NUM_PAGES - + // 1`, which gives `0 + MSGQ_NUM_PAGES - (MSGQ_NUM_PAGES - 1) - 1 = =3D=3D 0`. + let slots =3D (rx + MSGQ_NUM_PAGES - tx - 1) % MSGQ_NUM_PAGES; + num::u32_as_usize(slots) * GSP_PAGE_SIZE + } + /// Returns the region of the GSP message queue that the driver is cur= rently allowed to read /// from. /// @@ -281,15 +294,22 @@ fn new(dev: &device::Device) -> Result= { } =20 /// Allocates a region on the command queue that is large enough to se= nd a command of `size` - /// bytes. + /// bytes, waiting for space to become available based on the provided= timeout. /// /// This returns a [`GspCommand`] ready to be written to by the caller. /// /// # Errors /// - /// - `EAGAIN` if the driver area is too small to hold the requested c= ommand. + /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the command header is not properly aligned. - fn allocate_command(&mut self, size: usize) -> Result> { + fn allocate_command(&mut self, size: usize, timeout: Delta) -> Result<= GspCommand<'_>> { + read_poll_timeout( + || Ok(self.driver_write_area_size()), + |available_bytes| *available_bytes >=3D size_of::() + size, + Delta::from_micros(1), + timeout, + )?; + // Get the current writable area as an array of bytes. let (slice_1, slice_2) =3D { let (slice_1, slice_2) =3D self.driver_write_area(); @@ -298,13 +318,6 @@ fn allocate_command(&mut self, size: usize) -> Result<= GspCommand<'_>> { (slice_1.as_flattened_mut(), slice_2.as_flattened_mut()) }; =20 - // If the GSP is still processing previous messages the shared reg= ion - // may be full in which case we will have to retry once the GSP has - // processed the existing commands. - if size_of::() + size > slice_1.len() + slice_2.len= () { - return Err(EAGAIN); - } - // Extract area for the `GspMsgElement`. let (header, slice_1) =3D GspMsgElement::from_bytes_mut_prefix(sli= ce_1).ok_or(EIO)?; =20 @@ -462,6 +475,9 @@ impl Cmdq { /// Number of page table entries for the GSP shared region. pub(crate) const NUM_PTES: usize =3D size_of::() >> GSP_PAGE_S= HIFT; =20 + /// Timeout for waiting for space on the command queue. + const ALLOCATE_TIMEOUT: Delta =3D Delta::from_secs(1); + /// Creates a new command queue for `dev`. pub(crate) fn new(dev: &device::Device) -> Result= { let gsp_mem =3D DmaGspMem::new(dev)?; @@ -497,7 +513,7 @@ fn notify_gsp(bar: &Bar0) { /// /// # Errors /// - /// - `EAGAIN` if there was not enough space in the command queue to s= end the command. + /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the variable payload requested by the command has not b= een entirely /// written to by its [`CommandToGsp::init_variable_payload`] method. /// @@ -509,7 +525,9 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result Error: From, { let command_size =3D size_of::() + command.variable_pa= yload_len(); - let dst =3D self.gsp_mem.allocate_command(command_size)?; + let dst =3D self + .gsp_mem + .allocate_command(command_size, Self::ALLOCATE_TIMEOUT)?; =20 // Extract area for the command itself. let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011031.outbound.protection.outlook.com [40.93.194.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C557374178; Fri, 6 Mar 2026 07:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781743; cv=fail; b=o5+MzPUejb5u/KFZU6vnDhx1YEQkdwjzFOnScbfpwAGAELqCSM+0qUk4jrID+fdwEnVbLaCxaKQ8qOBQqbuIXU3pShIH/UVwwqiPEMKi0XPqGpj4wq2aRA1zN8gr6Et3RoSlAsBzztCIwX7V4R8XMOhzQl5jmHKnYij9XDInIho= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781743; c=relaxed/simple; bh=hI9RiLOGFqbmkjBzas/mXo7xbFBGQ7Z2QkMgFkVT7DE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=AHCIzvuwbAm1s7bHkCjjZ6+Bb0Whx9ldS+G5t0pTPSGjY2Zsh8E0x2Gn2YOA0LsN5B1mUpit7eWI4t7cFrYeCBU9QfteRDEg0togQi7Ps8PXnLDnPy2BKkihf76x0MLYoX3QGbFLP0YG6T32loNj3ivN5NMLVUl4IWhOoj6T0WI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ByCRzgNV; arc=fail smtp.client-ip=40.93.194.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ByCRzgNV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y4p9d4fS9xkfLHmn73HkRxwdIz1Vfdq2yhntH1BElFXcbQ62drWBgXArt+SUVsJmCdEkjoo57aOsN1G3NfTi56yEuneoxjnLX2J5wccXpuJDc4syDbYe1WRAiN2oe4eYojjX2URpgeUuCORqhvqpR37Q5MOrYXSVQGUFiXeWuMyKRnmxLFKGprDhdDeSmU6kUAxGil616XzNO5qcFVzn6V8qSfHNQmFoWnRC5QJpvTTJZ/VprFmuwTAViZeF7Usy541oLpfrFeUZHeBP+wKH+Y6c9+mvbcNdWVg812hu9Ksym9thme+9QacFsbGhM5B8Uo/s/i6JaVyAyeyqPE6wbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DedK0I1ZCfVF8ktQPAR1XHEkfPGPkuR/RtE4Thh/05o=; b=ZSM7Lz6MfukZQHutpzn+lTWOVje+V4iY5jVak+bG9EHZsmzP39A5Gpx0jJ+27DCXCnvxmZap0DwtDXnUUnOcA1oLCZ0Ybr6QXrGjriEixS+TMiT2fpGVKjac5xfP0BzqrHtk3WxKvsnB6X0nSz14nNVPWnXia59XZ8e2+pPOLcsTckEJVLdvTiKNbCgGX/VsrZ+LYcor768PgpaSFN6pmwOdJSohX+B42LEmWQrYxt5CjXCi3vsSH1/TXhghm9h08CBnDAz6HZPe+y/hrCuwimIv08kbuk1y2AOpUiyqYG4eRyy7mUqtzX4vTBArPK1smvPgXmgh66p92TRo3SX5BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DedK0I1ZCfVF8ktQPAR1XHEkfPGPkuR/RtE4Thh/05o=; b=ByCRzgNVsY3vnI5LQDoHNZuhecWgjImH+uMM+QFSCB1uurmB4OWC8ASO7LYTHbORbHvRR9LRvVUQtGkvluPvudH/Fs9iIME5hwFkCarg2PncsdBUa/YWMhaA0Bo0jc1CBU2T8P7TYvJtlYD3l22kpOfigwC4CO4QmVQRzBQ5n6kGifrD3tisZ4hOeEj2bNOPd1I86WKdXaUV9ypme8tzTHTx2FZ5JqsSEbq9KarnehYHRYQTvHDmJbTmpyQXrJStiszNXtEsxgMuWJ8TAwOQfpsy2hettZ2rjKQvQipi585EPJzc+xMFoXok6T3cBeZUuXm0YVBsP/K9PmIiNOXckg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by SA3PR12MB7951.namprd12.prod.outlook.com (2603:10b6:806:318::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.5; Fri, 6 Mar 2026 07:22:19 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:19 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:00 +0900 Subject: [PATCH v6 3/9] rust: add EMSGSIZE error code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-3-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYWP286CA0011.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::18) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|SA3PR12MB7951:EE_ X-MS-Office365-Filtering-Correlation-Id: a5f22a8b-75cb-4408-0dda-08de7b5119cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|10070799003|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: VDlkjSLFjB8PBXOv2/7ml47cCxrlHMCSoCp+ACkOAr9ebnA0f66CMW6D/PGhvNT7MaPHKWbFncPJ0h0gK79xTNwhnXD2NVXNdwhNSN07Ye2Yba3v77rruz90/iq37K5eD/YGYlRCh09v0G7EIt1sdbcjgulVBshAGUxAYf5MuPg9d+MfbbPolB+g2HoR8nqugoght5nmwE/ZuWi3AWgj1ICYO3t9snQUstCSrWT/DmJzh8Ff5QQqn/H7YuhVW9i+Wx9IJ4ZVEtsmFjwfIzyjgTvicjSqVcNUE36uCDwiq10aI3qHRkJ+nkzRnVN9VVRlQ1k2hbdSydPPil0f3jpPilEd9C2T5KS1h3ndwGKJg8Z2jbebn7wcLQ54jbFpySIn3+bJm7pMqunyEtRSkRzIZL0HSQg5VbkseVW9wj9bAxImdVa3rL/1r2a9uGq/hTjjvS78yk4EthNbaAR+6LqbdwJ0wcz4cULi8xHB9MfoYPnSnon/cWFlfg2KkIn/I1s1QrScB2ZCSPU4zeZEd7KiWpLbfCTBtcjpl938sEqDpsXa67obqrKobxZa/TLEajlCEYVX99EIE1T42bEk2wZDHVKU32800t5r7opjzOLbUqXKGlZZ4ZMbEIyXRmGjf2C8iVMRKrPjplhu9c1VduR0r26+pOw+NOurJIiJzID+UwZQkGVTIIkHceJgnY2OVOxMcjzpvg4q7HUXeZ6D4GZw2t8NNDGRSnXCHRynIWS8+9j4OIcR1uyqBR0Q8w+vHyAEcUR++Z2XL3j+8FfCIg6lsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnRnSGgycVVlbytBVlBoWEVRQTJHa1lueXluR0kxSkl4aGhvRzJPcFlZQzBC?= =?utf-8?B?M1RKNVdpS0JBYS8zN0N3R1hDY3RMNkNrRjJVUFNmUGJZclFOYXFXS3d6UTdW?= =?utf-8?B?bURPUDhWcjdCbmZPd0F5ckh5YzNOV1NYdHdGT0ZRek9VVHVqZExEZmhjc0ht?= =?utf-8?B?Tnh0eTdXbVBiRncyejBRUVBlWitGcS82bEZiZ0VuWTErVDhLTjhWeURrWkNF?= =?utf-8?B?UlVuNldpR1JiNTdNM0ZteG1JVlVjbkdOV2ZRblNZdC92bWpHSm45RnRBN1l3?= =?utf-8?B?MTBVZGJ4RmlBMFlnWXM2YnZKWE92cUgxR1hJejdjSVJIVURTNDFoeWozL01R?= =?utf-8?B?WllrWXJrTkswUlpzSnc2TUtNRTlFVEZuVkNvN1hUV3hLSDdWeHNOeXpXV3lN?= =?utf-8?B?YytqcGNuTFhxdUNsbk51RHRTSENSazFkakVQbVVLVVFIL1JZdEwwZ2JONWxz?= =?utf-8?B?V0lOY0tyZGNINlNibmUwbldCM2RlazJFNWpJN21MTGRCVlZUc3Z4OS9mUzFY?= =?utf-8?B?NkNwdk4rZVZYUVNOOGZaMnZ1ZkhKa3JaWFNXc3JsYlNtTzdQY0FrQWdldUIr?= =?utf-8?B?M1pJSytRelNkTjAwcG5DL0pWYXYrWHlWNmJJK0F1NDNYM093OWo2RUREeGox?= =?utf-8?B?YzQ2SytzdXJlSWhncXNMNXUrUEVSOGVFbVJiaU12L3hJZTdqZW9BVlY5Rk03?= =?utf-8?B?MTM3cE53Zno2STUxVkVxRUp3cE50R2RRa3h4TlJkVWtoWFFlemNTcW12bG8y?= =?utf-8?B?NHJCTllUbXFWVWppeTJROTkzRmdQR1NCVmgzSFZjY25LczNna1kzMzlNWXpN?= =?utf-8?B?VVQrM1JJa1Jta21IRmNCbENpVlE3Mk5OUk8yTkVZMVpUUzdKV2pQMFpQMlNC?= =?utf-8?B?ZEN5cmpYcU41QWM5STVFSktKUG9rR2VseVZ0a09mdE1oeDM3TnFMMlNROCs2?= =?utf-8?B?TnBha1dLZWlSR29RQW9aR255ajM5Mk5ITjJwaDRMQVRNdzI0SCtYU1gydW1M?= =?utf-8?B?RlNMV3NEcWViL0dtUnNoWkpjYmsxaDdxb011L2FCa05hTDZCb1pCYkszM0k4?= =?utf-8?B?Skk3bnB0Qkc1dnlWQXpEWTdDa2U4RldJTzlGM0YyTmc2bisxTnI2c1ZjUzBz?= =?utf-8?B?Zjl1MDhwcm9PTnJvUEZrZkxHbmpvbWhvUEVIbHVoUVpHL2ZLK1gyQmthb0w4?= =?utf-8?B?V1N2QkxnS2pmbHR4SzhreVNuZ2c4c2ZCS2V2NytyNHBtb0ZIMGFVYk00L2lL?= =?utf-8?B?VzRHM2ZqOVVvYU9DRG8vMS9VRTlHV00wdDdFYVpFcWlXZXRjOEZuZXBseUty?= =?utf-8?B?WE42R1ByTGN4QnZtNVVuZnpETmRBcXRoRllVWlEvZ1JCRTd6VGo3L3BIaDh1?= =?utf-8?B?TnltSFhBekpCMzhNdmlUWHZWWFZSZzBWRW43WTJwdGhqUWpPQkpka2JWRXJv?= =?utf-8?B?QklXSmhyMkkvY0dPSXZRV1pnM1owZkJURkV5cm83ck1SVlFQdFJQTFJob0cx?= =?utf-8?B?RnVVOEorZGxFT0ZCQkZ5UjlIQ2MrNWVCREgxd2Q1U0pPMFVMWDJvNXgzeFlq?= =?utf-8?B?TlVFTGxkTWt0ckxpTFVYdkNKeFBoYUsxc0RMQ2lJQWtSYzZtNitHMlpreEpY?= =?utf-8?B?YWpLZTF3VEsxTEtFQ3FudlpMbVY2VlVMK1lOY1k1cWs2RHBKbHRZbklqbFgv?= =?utf-8?B?Ylo5OVBYVTJxL2ZoZk5jdk1nd2NldEk1L21mNHdrM1BSRHgvZkJFakUyUmg0?= =?utf-8?B?NlNWdGhwanhYaC9lQVcxRjRJbG9pRWl5YjZiaWczZC9sOWllNFJ5U1hOVzVD?= =?utf-8?B?R1pTb1VsQWlGcjkwVnJRYjJqbEdvQWwvYVpCTlBhOGJVd3hsNnc1NFZFZFBL?= =?utf-8?B?eDVkL283TWowbzgyMGtBajV6WTZpL1ZPNU1BU1VNUFR4VXg2aDNCUkJ4V0pi?= =?utf-8?B?WDFRTHRwWndOYkNwYlVWSXRaR3dNYXhHODVVQ2ZlM0t6eDBidEdRUXhRcTVZ?= =?utf-8?B?MytDVmI0RWpIWjV4OG12THI5cHJ5eXlCbGR5TU5hVytoVkovdkRIRnVLVE9D?= =?utf-8?B?Z0xDaEk0WnBnSFF3OUc2Nk05bm5hTUs3SXBMVnZRaWRhVFdqamJwMVE2MTls?= =?utf-8?B?YWdVUE1QYy9RaHJuRE15bEVIM2VUZitQMVp3dHlDbUVRa0xCVDJMTk1RZFUr?= =?utf-8?B?T1hXdDJNRXFQMHVwQmIvNnIxZ0lGOEdrTFU4em5WMWVJa0tPTmFOT1RwVDdM?= =?utf-8?B?TUhqVXBnTlVRZ3p5cVpYZ0tXVEM0SWdvVGc3NndRblAwMUt4Q21WaXBDZ1o3?= =?utf-8?B?MUU0RFMzc3E5OXRXQ25oTXErMUZIeVpRZnp4ZkhISkpydW5sRS9QMGFieUxK?= =?utf-8?Q?JAxZOzHjux+BAhKcE+qIYq9obQI3ySsv0UoR6a8UhqaX3?= X-MS-Exchange-AntiSpam-MessageData-1: Ige52ysbl4aKiw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5f22a8b-75cb-4408-0dda-08de7b5119cd X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:18.9477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H14Gc1ADlDIXoNGeFcoovtZIE0zA634taikxqc30CpScLKN4q0bjeX7plO61aGHsOJhQg+RonwN7mKgKifP/cA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7951 Add the EMSGSIZE error code, which indicates that a message is too long. Tested-by: Zhi Wang Acked-by: Miguel Ojeda Reviewed-by: Gary Guo Signed-off-by: Eliot Courtney --- rust/kernel/error.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index 258b12afdcba..10fcf1f0404d 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -67,6 +67,7 @@ macro_rules! declare_err { declare_err!(EDOM, "Math argument out of domain of func."); declare_err!(ERANGE, "Math result not representable."); declare_err!(EOVERFLOW, "Value too large for defined data type."); + declare_err!(EMSGSIZE, "Message too long."); declare_err!(ETIMEDOUT, "Connection timed out."); declare_err!(ERESTARTSYS, "Restart the system call."); declare_err!(ERESTARTNOINTR, "System call was interrupted by a signal = and will be restarted."); --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012007.outbound.protection.outlook.com [52.101.53.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C87BF375F9A; Fri, 6 Mar 2026 07:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781748; cv=fail; b=QcwrIxQmz8CB6PVuMOSf2vr297Ovi+srng/uv//TJvYBWKb9llTj9qr8Lx+me6BUuMN+ujlyJjYesNZHepO10ve8Ls5f83RtUX2q4XUiPgHk7A7RJLndm5E4dePV6t4q+RO/so3yLLETp+5nyMTclw/EaVWuqxtFMSMWC+gqvw8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781748; c=relaxed/simple; bh=jkMcbjfs7sxdnhtqNlUM6ZrgIZ8IFjQTBPMMdaCX4jY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=e4giod/DaSiWfbqANWYZWBdAQL6qP8bEhsLmm4DeaBSfSxCz8sjZBE1K897U5xspu1ZZIw2+/NkGOupGyC0lyNBjnJIX/Ejp62eLUD+q0zEvP8EP+jXsCpgR6DAA/qR5AZRRAk98E6TME+XzGUZcvA4WXfu14s7m1ZZcZu7gN9E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Rn0vShzA; arc=fail smtp.client-ip=52.101.53.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Rn0vShzA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C476F/FUHdLUnekRYZYRZ5vWUsjNH2mYP6JHsQJnDrw/EFMzuVenXhEaYp4KC54GXvDesDjys8o7NH1mK4PqKZqM1YIPerC/XLIaro7IJd+dNBMnEQI5Xom9Zhr3tJV0bVdxk0QiL0v5+8Q3bZRCdUULVtQuW3hQ6biDIQXtJBaE9kKLJ5CDa6sj6RGcxFhqXzWaHeLp1PUif9dus0iMVRdJZ9odBQrqxRHHVwPvZtbCEsMUA42vgbTGvH5xpbr1P5bKhjQFLjmZc+os/udLldsOp30sTT9KZhgazxh+rs0SB4KjmGfWHsOy1CnRtQyCHyHBo3VHMYFRNChZlwG1UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a1KVY7qcxbc+Kqw3oDNpVcn+Wcf/mXSmiLOKD/C/lhI=; b=TP2uDAp4iXJ5BtYPAl9+q9cnUd6WT0RsmiI4XDbviU6DdQ11gu1kWj9j/5E/svjdkQr8gYMw26kV+nqYnj3CfGTBS0JxO64a+9cO4XZWyxFNN+uKg5nnHPdXRKAVZcUzu9FrkTvwD0Im//IZ7X3gLlqx/YbOnUmvJOs0gI1nWma9+jmcCEdk+BgfueGJH1yboCxKDPwE9bdFWPMta3oHz3x+QfIDwf4Em6n6NsWHV68wwst+zEsPQjrXDn6szym0T2C7Agniz4glfk757Y5CFF6TXfdUmaj9ncLDYDOS0if/6/ONJUGn++fCyt7+pGkj/h3Nd88Uc6Ytqcaqapcj5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a1KVY7qcxbc+Kqw3oDNpVcn+Wcf/mXSmiLOKD/C/lhI=; b=Rn0vShzA7w3xiATcbzbLV8j/HsrxIwFlj/3zM4k268jfmSFnsLuPWLpbjovmBlwleD858ReJiZIcx9mySuo/ma+Oyfs/rtdyCrBGsWbuZBPAAHRTXbBfse79ZmovbcJGGOsXq/KRMmvTQX6gQ4uUzs+qYuaQXxRP87/YuU9hQFVqJ3fK+9L/Z95Iv8HLWy6ektNpMyWnA5gKu17ZVwWDtvO7oRdlbMfTpfMynrIRJox4rA2a90niZxu6VcdEyK1iRMDUP7W+ivGENBLAQcxVGRO16WH6P4nISY1p+tgki8j92YI8aA0yzbz8hl1/fbNaN1pswFP/eb6NLXhmKlW0HA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by SA3PR12MB7951.namprd12.prod.outlook.com (2603:10b6:806:318::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.5; Fri, 6 Mar 2026 07:22:22 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:22 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:01 +0900 Subject: [PATCH v6 4/9] gpu: nova-core: gsp: add checking oversized commands Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-4-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYWP286CA0014.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::20) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|SA3PR12MB7951:EE_ X-MS-Office365-Filtering-Correlation-Id: d3265141-4ec2-42c2-3225-08de7b511c17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|10070799003|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: 6PEs4enP30zK8NJW9qLIR8PWd9Ugw55+TAWfDsEg/N+XqhRcLb/RBfX4SPbjcjN4z77A3vz9pfKFVky4EfxhHUQYJGjymeEDnTRR/lPs9wX1Nx6PKA5IdgpeYloOBbCS62H9PamAIrcBRrhKH3hsvQ4RCP2NbSzpWUejMHQzT5yEB//xF3aq8Rm3pak2eJIAW7K28TAPkRk8BoSmSu0vWHt+Ss1otOQrfiqYkAAarJ8BG42Dx6FqV/Y+OZeumrLFuw7Du6gdDgDJwl84Y6627ZRww5E70smzheIOK1c8GQqvpSo4qiXmCppP4GgCCwGWXS4Yp+2H8MWNOSUAtJZaijQmrF0ZldAnqFqMlBxN+FwpPomDIT38yYGyuzVeqz/ksFwwpsM2vL/e1l0COdJgZp5w8R5eVej0uTCuJS2KKudiFlnO0K375s2KWUlO8bxsuK+9fWjl44sCq3hULVeWO1ZB+rKpZ+Mpuuf1sRy5VpZL6YQJEy7Hjkll3kdSrzSAbjTnABBTSO/tORURVzi64whPp6L8YQVoIJggh68SS2/mNVHbtpAdbsb40d5gly6jnfp/BQPn0vF8RKipzs/zjkrPu7lQazqhF+mJpczmli88MawinnqoCLafxw7tPRS9FyaICl+R4E/cK83EfXvrP9vugTAldgaojdbun7OWAj+bS+TaO0zCnt0hZ3XUTaC2iq8WgGREgEfk/zi3w1ZwImyYw8Xkk6HAwRPaROyClnJeBpu+Fl+ySaEAIodj3Kw1MB7xCQx9Lk2IzAS+qWxMHA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDBramdaKzgzc2RLaWU4aDVFaE5uZzNnS1FmeHZPYWtiZWRpcHVtUjVmWkRy?= =?utf-8?B?bUhJcW1uK0o2M21zVVRsL3lDYk5pTzl6RUlGV21ucXlxWFpTemh3Zi9GWEFk?= =?utf-8?B?VnlvcjRGS0dwMk82VTRLQnVIOFpYK2R2VmpyOC96bm45MEFpaDBwczUzeDhy?= =?utf-8?B?dFZLdlcvSUlVVjZBK1pNQXl6aVQ2QnBZZ3V1RlJEeFYwVnFOaXpFQkRSUGEr?= =?utf-8?B?VC9YYlNrOHBhWUpEUTc4RXNtb2dhdG1XK2hBeW4xNHAyS0VpV2pqdnNxSWcx?= =?utf-8?B?bDM4VXlPREdHdmVTQlZ6bWd4aUg1LytxQU8zZEl2YVpCM1M5V1l1K3lYam43?= =?utf-8?B?VDB1L244OHppdGRNZHFGSGdxNWU2OVhUQVREQ2phZW9xYVlYVGpHd1Q0aWdL?= =?utf-8?B?UkRkOU82N2F2cHpIWXhBUzdFSVlWU0tMVGFXUGpBR1gzby8vU0R4M3lldURt?= =?utf-8?B?a0FYSUhMVGRPVHNhSnRJcE5hZ3daaEJWb2lpMHBwYVdreFZVbjNBdkZVQ05U?= =?utf-8?B?NUFjZXAxVVNzN0NXZmI3bGgwbkNNcTdOR2J1R2dzM3pKYlFzUDFKNUlHOVhX?= =?utf-8?B?RTRnQkZIbWpOSzJXYVB2UE9hdnE5RGNPblpXZ0o0N0oxZitRQThwVjhhR2JN?= =?utf-8?B?Mjd5eWNMZ3RMUnBhbDhnK1E5V2FORlZMU2VtcUIvM01IWlRsaU9yK1VhUlNS?= =?utf-8?B?OVUyQUh3SFFCNC9GNHQrUXBhc1JIMnFjeHErcmphZTd2UElraTc4OUk1QXJ3?= =?utf-8?B?Z1hHWnRkeTMrWnV0cExwS1FuNTF3K0xseGdYcHB5Y2NxNFllamtOM3h3N3dx?= =?utf-8?B?bWRNTWpYZ0FKdXlXYVdZNFpvZll3VkQ2SzNXdVZGZUhqblNtYXZsOGZNenJK?= =?utf-8?B?U1FTZWl2VnZScm55UFdqd3V4ZFVpUi9Rcm1zZXA3dGJRellJVXQwa050UVp3?= =?utf-8?B?OWd4Q01tUWh3U3FwMVREZ1F4WnRNaGR5VWZDWjhxNmNLYXFNOERlZ0g2U1Q2?= =?utf-8?B?aUl3MGVPN21pVHpUc2JQQnY1N2I0TVp3RXcrRTVjZ2NMLzhOZ0JXWUtoRGFz?= =?utf-8?B?dnV6a2EzRWFLWjJKSWJIaWJhN0RuU0orR3FLZFk2bTRLNUhYQ1prRDlZa3JB?= =?utf-8?B?dW0xcVlVUkJiYTFnM2VNeUR3c3JMRE9jTjNrY0RUb3FSTGZOOTU4TlMvbnBB?= =?utf-8?B?cVJhOXovQytWUEsrVWJ2cXp0M04ybWU2Nk5rMkZEY01aSndVRElYemswM1kx?= =?utf-8?B?WDM4YkQxcHV0TlRLV0cyeFRGcGhRZjVQNnlKdjNoMlA1aUxjNHd0SHZEZ2NK?= =?utf-8?B?QWRQWDNJSm9UbWxLNjY1WEpTUDRhcGNCRGZQZFkzVmNrZEo0S1h4bEYwNktQ?= =?utf-8?B?QzJyekJSS0cvNEdyZmw0V3FBMVlNa2RQYTh1aDdhSkN0SWRPUjM1dk9ETGRh?= =?utf-8?B?K1pHL2ZuN0o0WHR0V0ZsSWhxYUthcnQ2OFdoRWdXaHBHQVZFTmtaZjR2RDdE?= =?utf-8?B?cmozRmlVeXc5OHVEVUYrR2U5dUl6U25mVWx5OFZkUnJXOFpIaC9aZ0VSczRG?= =?utf-8?B?M2p3YWZUV2FuSDlTeFVtbmViRklXUHNzNE4zTDcwYmxPNFhmME13V2daWHQr?= =?utf-8?B?bEdiVzl5bXZ0V25UNmdEQ29QNEp1eHpsWWxNSEgrdUVyeHFiVlF4RFVjZHlH?= =?utf-8?B?V1lrRFFOS0pVekVaR2RPQ1gxMkJWYjdDRE54emYzNlRETkhYajFUMFZGRFdP?= =?utf-8?B?RERXZkZrRE0wZE9IY3RhYW1kQ2h0U1VKa0hPSEZ3YlpBQ1dhQ1k1VktTUzlz?= =?utf-8?B?YVZpTnd4elRGUlZOOXhWVTM4NS8zeG9wVzkzTTVkbW4rZWVOS1FhanErZHNI?= =?utf-8?B?Z01uSERGY3lZelloWUhaS2I5dy9rZHVOaHRVYW90TnBOd2xMbFpJNzdkbFg5?= =?utf-8?B?VUo2MWRtS0Z3UU9GNHdoYWNVVnNHNXRvOEI0eGZ3RVQ5MHliT3ZxUXB1MHll?= =?utf-8?B?aW5GcU5tc0ZTV2hLMlYweHZpN3JQVlQ0YUFBQWpvMGh4VWJrbWcvRmxyZFk5?= =?utf-8?B?KzhjcDlmWmM1MFJVSjU3bmNrMzB3b1ZIb3dZM0Y2bEhmbG9oNU1HM3RCWHRw?= =?utf-8?B?TVdrbndhZld5ZjB4VTVTRUNobkVQa2Z6REl4QmNRL0VlSkd0QXFZTXhPSkZK?= =?utf-8?B?ajM5QTJDK1RJeVFncUdwUnVBcExZYWhRZHRsUGV5ODVCNzlOY0VmZDRLUGp3?= =?utf-8?B?cHpkVE85NWRNeFByS3dJaFZJWnc2U3NBWTVFWnFORzJzMzJDRFBCZHpRdEFm?= =?utf-8?B?cjcwdkhIb2cxQU9jaGR5Mzhka2l0R1kxVGxEcEJveDM4dFUvS1lmeXQ4ejR2?= =?utf-8?Q?T5LmJQbONJcf4T2oKsIUyOh27RD/J8licslZLUWaLDJns?= X-MS-Exchange-AntiSpam-MessageData-1: AYa44RxKckJCvA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3265141-4ec2-42c2-3225-08de7b511c17 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:22.8447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6RM7uAuvOHK3mQ6qNl9XEUaFWn/jvV4l+pAXkeLLzzOCXRSl24JwLpvFEei9gGrdCgmR5PrMyWgOlkPiP8VCQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7951 The limit is 16 pages for a single command sent to the GSP. Return an error if `allocate_command` is called with a too large size. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 7 ++++++- drivers/gpu/nova-core/gsp/fw.rs | 4 ++++ drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 12849bc057f2..8b970523d789 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -32,7 +32,8 @@ GspMsgElement, MsgFunction, MsgqRxHeader, - MsgqTxHeader, // + MsgqTxHeader, + GSP_MSG_QUEUE_ELEMENT_SIZE_MAX, // }, PteArray, GSP_PAGE_SHIFT, @@ -300,9 +301,13 @@ fn driver_write_area_size(&self) -> usize { /// /// # Errors /// + /// - `EMSGSIZE` if the command is larger than [`GSP_MSG_QUEUE_ELEMENT= _SIZE_MAX`]. /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the command header is not properly aligned. fn allocate_command(&mut self, size: usize, timeout: Delta) -> Result<= GspCommand<'_>> { + if size_of::() + size > GSP_MSG_QUEUE_ELEMENT_SIZE_= MAX { + return Err(EMSGSIZE); + } read_poll_timeout( || Ok(self.driver_write_area_size()), |available_bytes| *available_bytes >=3D size_of::() + size, diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 4b998485360b..6005362450cb 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -39,6 +39,10 @@ }, }; =20 +/// Maximum size of a single GSP message queue element in bytes. +pub(crate) const GSP_MSG_QUEUE_ELEMENT_SIZE_MAX: usize =3D + num::u32_as_usize(bindings::GSP_MSG_QUEUE_ELEMENT_SIZE_MAX); + /// Empty type to group methods related to heap parameters for running the= GSP firmware. enum GspFwHeapParams {} =20 diff --git a/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs b/drivers/gp= u/nova-core/gsp/fw/r570_144/bindings.rs index 6d25fe0bffa9..334e8be5fde8 100644 --- a/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs +++ b/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs @@ -43,6 +43,7 @@ fn fmt(&self, fmt: &mut ::core::fmt::Formatter<'_>) -> ::= core::fmt::Result { pub const GSP_FW_WPR_META_REVISION: u32 =3D 1; pub const GSP_FW_WPR_META_MAGIC: i64 =3D -2577556379034558285; pub const REGISTRY_TABLE_ENTRY_TYPE_DWORD: u32 =3D 1; +pub const GSP_MSG_QUEUE_ELEMENT_SIZE_MAX: u32 =3D 65536; pub type __u8 =3D ffi::c_uchar; pub type __u16 =3D ffi::c_ushort; pub type __u32 =3D ffi::c_uint; --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010053.outbound.protection.outlook.com [52.101.201.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6257377EBB; Fri, 6 Mar 2026 07:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781752; cv=fail; b=ITQfb72KvhzWHknvZRUC5Oqt4VL+7pzGGKdE63Lmz+MLETYketJZCICgWyYNTjrrl0D+TnCbsy1CUXzOxWnnLf2NujTHreOSHSwVjgwIFpU4nZBfFDBx1FZ3FWaW1uwAhb4fajwJUCHmOiUi2vlByCTCN3lBTuPBSZXw9o935Dc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781752; c=relaxed/simple; bh=R+HjiiIbr59auActjKBb5ebCY42CrDPzAat4+S56Y/4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=T/IuJLFPb8bXR2WLFad34zEdtNoyMFgjzELlrlPsdgAF3GhsrSvF1tgfMJpNxWRsb1jzRVJVTqSwt4+8gaUj+x5yX9xtjhz8/U3C++JPdWisqqA1Yhoq/djLEbE6Z/NF5MIzomj6XTK23p/ySxkYG94zdyfUkiwTwpH1Bh4caGg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Mzy1td3l; arc=fail smtp.client-ip=52.101.201.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Mzy1td3l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pNLs6gPGSjabq8jETnRCeqLdtFO7z+buO/v/ox1af4wD75H2AlMLvNaZq5Nk7VuqRQT1nYKb5IN22jemW806gmMejC6i/TXGzkRBK8YkMPLCtwHVgZPl71fDFXWSlexVQ7QZBxBLKfPc5Z7bFXNGN8qEOlZBRdxeq0V4mkdng+eLxzBoRQbaz7hKWHPVfattRRSqbED5iifnth2pAg9uFDL+1YtAu/lC8IsCiFv+jsPXD23ePGmPOofwdHTsihF5gFiyP8rl2OpFsK+CkF9Z+OGufH953GiH+gkDElXMdQtM8cIsgcnt6z7MCwQvAIUPq2ZIP6El0pjQ2NY6JamVGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7VcqYqch5y1E7gwqPzm8XJnkZWMBjcUgsIhQDBnQ8nw=; b=TkvrBOK2M3919EldXzfi2m0zVC884FF8znqw+++LYHKFa8QhwSx+HdzzhyiJOvk+RDIebpluvLQ8MDTfllG5cDoIy+ytCFWWhFAf3D3Wk/cBnyZm5gJGEKJnvWADp3r2UNdklmhgmhEc9FazrGYvu6MlM3W85ghGRY8E+WGslH4I7+c5zcwFXljaJ2rNmgju8BC/P0rREr0tE9Jn+9vCLzwyoDOfUeRdrTqQPer6FYjnfP9c+GnT+nRNEX1ljJT7cgFFbBoNz9nm/zVLN7yFFkCcRoAOElKkhJYKCIfXjeecsxWHiIhfZfdx/yItVdsYTedXr72OblgpJthKdBq3eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7VcqYqch5y1E7gwqPzm8XJnkZWMBjcUgsIhQDBnQ8nw=; b=Mzy1td3lS1t23DF/f5nfl4fAbc5IkA2JbI6ZU8DRUHYptY8fvZ/Lw6eF8Zvm34VjoTbaDaQoTcPeBr+CRV3XZXhWG7ZFxznXznM2hDE0+IRmftCEAlPAT6tC+MBHSJcdo3qVpkZ7RHfGlRZx9TrABA3+yS2pBrLZ01Yg8uF7BOUJKJku02jvtacENaQx6oFC7c7yjn5GjbUzenk/A9HKU/5fhq5dfjd3uUpCavK7RNWSTQ6I/KeBq8hO7n6rbrYU3yDbYezp4bmbZsKlecXYHsvHvHXxIPkmQwMGyrZ50+SG+3gEv/EJ592MVL7gtZXc5Y6PaoMNn0ZCWpnijznP/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by CY8PR12MB7340.namprd12.prod.outlook.com (2603:10b6:930:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Fri, 6 Mar 2026 07:22:27 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:27 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:02 +0900 Subject: [PATCH v6 5/9] gpu: nova-core: gsp: clarify invariant on command queue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-5-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0136.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31b::20) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|CY8PR12MB7340:EE_ X-MS-Office365-Filtering-Correlation-Id: 472b8a8e-25a2-4027-2fce-08de7b511ea1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: YdW5oz5NiIElm13cnV501w3uuretH07rLHQoQ3seTpB4du2WI+BvEvEZhcdRvKDDnM6lt425j7go0r+w92ow5y9/0QQDI5YdDWexznbo86DdZk6kqKeHapoYaLZG5tPbpBdCxUqhHqZdyfSq3Vbcb0L2Z2LkeQSIRgGXIjUwl7TFQvHAjSL8u4bgVPUVSttwUNgqhJUiG8Rzx2pj9xQOa6JbGj1N4IqTtMRe0YBrbC9jMJChqdn7AEKkMXtcNRF3C+Vgse5mVrjcq7P4lJwqb/U5p0rh9VLZ9lijK4+l2Ak5EThl/mCicaIzqr45QFV+e03JPUe0l7IKGqPpTEAY/KJGX07wReHwnH7xjNJK7SxqeQmWA+I33kI1e2nK6xtBzDM2H1fw8yjMWsRC7SXow9PwNd3jFJqZMDo8pjWRYlx82SxTn34THJlnm8QVIgyRP2LkUeNm2tOBWpMcmbfmpdnEXusLPbxZ4yAaUxaiP5G1U25WrGxdy+NT6dzP/PBaI5V4qGBReYdipW6/8kUfiACN01eas2Q8t6FXU3+NO9uFJGqPqfYJZ/YYK4omZTwy1nXyVQO79Ii7pfQhmezlOX99LCIR6rOVX3EuNBcpKiCWABAOJXInOotPaVspPl/v7WviR8Pbc2LMiVJveiVX7dYxpfDvAwmB7j0OmLeKOFyFPzre+3xesn8mAqBbLL6q0DO88c+hvuWM1su8IxDH07pcNPwPCwLOzNyH0RUfcAdK4HDqnUgqMyIrdV/5XYD/9uGSjjCscALPBNcbiH69yg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amtORUV5Zk9XVmdsNFZQRTQ5SHlVUi9mSGZaalBTakdXVCtSU2NPMWZwbG1X?= =?utf-8?B?ampqeE11MjVyQllVMHRHVUc2N0FSK3ZyS2diVThldk9Gb0d3dzN3SytzaDdT?= =?utf-8?B?Y2VNcWRkZCtOS0NrcTFTL0VRelJ0L0I1c25WTEtnd0FyMGFodkltL3FqVURK?= =?utf-8?B?N0t1dWpJOUgwSzRGREg2bzN1d1FMREZ4RGc3T1ZLZlRxV2F3SVp5bXd4ZXlU?= =?utf-8?B?VVFJNmtFalJoU294Q1FPYnJnSFllUTVQYnNESkE1cDFNYWtDTlZIYnVPTkVI?= =?utf-8?B?MGlmZHRFY2dJWUR2NkNsaXBTNkdSYklMNlRNbndJTzhKM0pZUTk5WHo3TGFl?= =?utf-8?B?OFVHbFArYVV3Rk5ZTllJSzFsS2M5YktsT2dmYzh3MjJlRXIzRzNRS3JjM0du?= =?utf-8?B?M2JZdk5QVjZ1M2Rnbm4wTlhoVHRhUlgxaitlMWJ2ekwwUE1JWW9yamxwamI3?= =?utf-8?B?MHVtbWZzenNWSDdZUjZSc3lzUkpZbnNDUlVuWnZVWldWaEpiNTg1Mnh4MzRJ?= =?utf-8?B?Tlk5aC9GYVpmVlR3WWoyU2dVaW04WXljOXkvakJsMVByZmRCbGR0L29neGJr?= =?utf-8?B?Y2k2T0E4aG9vQmV1c2RweGczdkVvYTgxUm8zWEp6bjQwUWFMTTlkWkI2dkhU?= =?utf-8?B?TG1Ld2FUcUdNTXlwd1M1WDlveHhSa0ZlZVY2bllhME5UUFJXRlhxd1U3Q3Vt?= =?utf-8?B?dFUzeHJwKzgwUHJHd0dpWVE2clVpa2JBbW12RWUwMjJ6dDNDbFVhZ1RtL3FO?= =?utf-8?B?SGx6TTZlUE1xeFpCc1VUbnFIcVFaS2VUVDFVZmdlZkMwcGRzMGhNQksxcHE3?= =?utf-8?B?dGtpczNWdkszL0p6Mzc5ZDlrYzlxaHFpWndaOU5NNTV2UlppZkpWL1ZQVFk1?= =?utf-8?B?WmczUVo0aWtoTDNKTytRTGRBUEZpbUNoUEpCdHA0dW0zelZvN3MxdEpWTUFY?= =?utf-8?B?RW5hTy9nbjNJM01qUVdNMmRGUzEyRzN2SEIvSjFEcTdLSFlyOWk0WmNNRXBu?= =?utf-8?B?end5Nzhvck9hWjN4d1lWOFY3ekhWNFNucWtJY2RUSVVYalhRNlV2aFp5blho?= =?utf-8?B?dElYM1g0YVFsSklLV0pKcll2WUJuWUtSZzhTcno0S2JpRE5ReXR4THQzR2pH?= =?utf-8?B?NDJ0ZHJiNWsxM2NpMVpvZ1ltSjh6WXVXeHF0RE9ibnJWSU95bjRhWHExVEla?= =?utf-8?B?QmNIdVFZZ3crcU41OXA5TWFUdFJrNEduSkRSR0NEZGhIRlpOSnBvY0JnRU1q?= =?utf-8?B?QlVwWkhKS3o5S2ZVeW41NmhIWXJiV29xeTgrN2NjM3pteWtHS0NkWnBhU0lZ?= =?utf-8?B?Um00SzFpbmt1amsyanZqeGVTSzV4ZG05ZzRpTjJ4SG05UWUvSU5mRENVWVJ5?= =?utf-8?B?bk11UEtleTNQdEEvUlQrNHUxdWI2RkYvTzlhaENzT1lkMUtZQXZjRXArc2dO?= =?utf-8?B?QlhKVWVUZDFqVlp1VFhodGFQOUdGTDBQZ1c2bDV2bFdzSFdOS200NlkxbUFL?= =?utf-8?B?MHI1bE9KS3JIVjVNWGlYRlBlUXpIR1Q4enorZGhtSzFGK01vVkUvSGFacUw3?= =?utf-8?B?MU1ZRzZQbDBlMWw2WkZBc3lzUUxGM1dSVGhvbWhBR2FJbWRqeG5VWGlrZlNl?= =?utf-8?B?M2xKaC84ZDVzTFpHdFJoNHpjUWZBY3RDMGdRUjJGUDBoM3BxZnI2TmFpUk9w?= =?utf-8?B?UllYTktvM3pIMTNydFJMRzNVUDJKZHZoSnFGWmpLbEZ5NVdQNHpaNlJDeFJB?= =?utf-8?B?djdBSXZISDZvMjRHWHQ3V2gzQldNRzgzM0VGMS9yV1FDQ3ljMGxLbGJncXR1?= =?utf-8?B?MytZNkZzVGozMUN2aDdaNWhQeDVSTGRVajIxL2xJTXJyVDM3QkhVNmRFTEtu?= =?utf-8?B?UHV2Qyt4Ry8vaEc1a3cwYmRrUkZPWXgyakREZG52TnlDYXFWMVZrVUgwZm1q?= =?utf-8?B?L3pCODQwTlNrbm9GK1NSaWVWZlZHVm1rZWJWdUZ3bjRtQysyR1B2eWRxSmVP?= =?utf-8?B?d0hCVlpXZlNZejV3cTRGNGpjS21BZk9WQ3hYRFAwL3R4Qi9RdWUvRGlobEtN?= =?utf-8?B?Sm5XcW1vRWdzL1VsL0pnekx4Y2E2NkZFQ29zK2R4T2FYZFM1K2VaUCtDbWZM?= =?utf-8?B?MGI2VERxTnIxaWxRZDFkaElOWW13K0dtZHorckdPS0VVamJ3dFI0eWlPbUtG?= =?utf-8?B?UEQ0RFNLazVackhKYVp1RzZ4WjByQzJXby94TVRrdVIyYk92WjZFNi82QjJi?= =?utf-8?B?VzJZU3h6RzFZNmhjWXNLNGZSbWlZekpKZmZvY09XdWNNL3MwWXZnUFFLSTFQ?= =?utf-8?B?a1BpQVJtUU1mUWNNQ1NNOEpZSnppdEtaTlZhSG1ZaFNmUlFFMytaK1BvYnp6?= =?utf-8?Q?34rm4kPhNKQv2KMuAoGqO6UTKd7PPRYFzR0fP1CPo3cfJ?= X-MS-Exchange-AntiSpam-MessageData-1: sa41tqpdzQaLAA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 472b8a8e-25a2-4027-2fce-08de7b511ea1 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:27.0523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mOuUOg7r4SDEs/xiB0DRZNYDZ8d7k/vgzF5ScZNrPmJekLYCRqiUtqhQydzBsxa/m5c6vzDCRsZtjZPcHhZjVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7340 Clarify why using only the first returned slice from allocate_command for the message headers is okay. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 8b970523d789..806b1e02715e 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -534,7 +534,9 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result .gsp_mem .allocate_command(command_size, Self::ALLOCATE_TIMEOUT)?; =20 - // Extract area for the command itself. + // Extract area for the command itself. The GSP message header and= the command header + // together are guaranteed to fit entirely into a single page, so = it's ok to only look + // at `dst.contents.0` here. let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; =20 // Fill the header and command in-place. --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010022.outbound.protection.outlook.com [40.93.198.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8A59377EBD; Fri, 6 Mar 2026 07:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781755; cv=fail; b=QDK4SK0mwqfXQiQ5/7iWReiTQD4wUvumMKMJMGaIdUUha6Sz4SCul+S+SfRZjG3N39gGgU0NyiKWBV82PmrrnJAAAAEHuyafW7of3CYepQJwWFEIFdEyaqXDrHXTNgcQIHTCvWRuyGmIJJ+RS/aeqD2zF4Bcatkc9l5Xz1o9iCI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781755; c=relaxed/simple; bh=5O/od7qfCtnPTWm07OSOc38xBl0S+0VRYojrHBryP9w=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jyPFZfho3XT7mJpTmtwOu7gee4UzPf/FA9JKtXoAwRkux7Yg6fdE8EXvLwviwjjnMsMW5FVhMJ2t3QPY9DHEGyu+aDA7KWc1EqbcxM6Hmn1HgbEY+W++Lxh5nnFHQKZdxHOG1XJTUhSFRW5da3u/0fx6efvD6/3g7YaSjYga9a0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Y7kcvCDe; arc=fail smtp.client-ip=40.93.198.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Y7kcvCDe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=teWLN3vyEnlgTaJPm2aIZNiLMZmlr8B+l4+SZ+knzAtquKurSHva+1c1sfy+0xvp0S/rYLO1s8K7JlfJDPEuyFMOwofL0J4WA3GR04IoKT6WZDiLsSVYxDHOB+XKWjMQuls3OMgXuSulIEb8eqM3+o5dP2mrX0WmtXvz7BW+cfJ4ot8PXHIhf31V0kENV47Xqeqpwlh0fYUi7LheaDi2ODg/4w9VpcQN0pVxDY4eD0WTraUGRvIi8TZ18Dq9gW0rG7yB2FS+/9CCwYZ2pNWQ+n+dgvlgfKKpNvoS9wvd6oulcb6NXrO7fn9agEwCUN92S+f7e5f1ZCSIMA43KtuCqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i6+8ZVIrOnRtHmpp5Cegv3D2ZNRFsYmQMXZVMQ/K1oE=; b=kyFCn1S57J47JIoWbx9Opioj/nEDsmL61JTF/g6tkRbxZZ6cZzSJrz62d94LBGvhiv6SbmIZshai3Q6J91ZMa06BTKKZzgcPI1N2t5I+dtzp9YsU2BhEmz1xlIAJwOCfVxXR0gJwKYnUhBfy0pLcZyb1b4Y5MByfFHXnjffPEBPSbJ2SgQ6O98zJLOcSbxUibvB+yXfP8/oAQdgQJah3CPugBAh/8OPVAQKdAItnq/yakFynZ7dQYoep7n+rXCI9Idw4jHhIPuL325PKajkp6+nGfTDXDbjE9KDArByhGiP0I9d7HkNvAN0R5oci0z7ozLE3fo1jH5Uk1TjE3cDgIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i6+8ZVIrOnRtHmpp5Cegv3D2ZNRFsYmQMXZVMQ/K1oE=; b=Y7kcvCDeoGwyKFgREVeTyst6ND38UKHxuRLwMxI1QNp9CK0HuXjEd6BsgkXKI3mx/Edp4BrdfvZDFtn9q3ZuGToyXMOAiQQLXXJmuKUS31ICaUJj+cgAEXxtW1Ma99/jmwYg6e0ZUiNomnXwGY3qZvuWL3AmwGFvHcqA21mLl9QHc5w69wG0hNZqhrYDoAKgVLbiha8/nq2sn5xPwQMGuW+NPfZyIf5m7Jt3PcowEvejAWEm+BwRdpXhXSnS6f/6ySgg72LClrNwvDjMiDk9am5oV1p1qCDDiXQd238ubH8XurXhv2m4kXrCaWJvjDrBQoImDCacwsw33AF+Pj6p7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by CY8PR12MB7340.namprd12.prod.outlook.com (2603:10b6:930:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Fri, 6 Mar 2026 07:22:30 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:30 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:03 +0900 Subject: [PATCH v6 6/9] gpu: nova-core: gsp: unconditionally call variable payload handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-6-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCPR01CA0135.jpnprd01.prod.outlook.com (2603:1096:400:26d::15) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|CY8PR12MB7340:EE_ X-MS-Office365-Filtering-Correlation-Id: cb7bbccc-cdd2-4584-3bfc-08de7b5120a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: O0sEyvaseOgsjUm3dfMvi1Mwgkr2+MIAxx1giuiCZB8sIRtGTBeHWlokEfSJ0IqU/DUMQXEADgVt7SDoQ6ll5LDQnPQWPd7BNeJY5at7qbRISpdkl45Gy5z+EqAmn/YGYCf9b7P2aWgbFhjKVtStjTxbFLxuWa+L2KgbKIMqNXR7RdRpcvXZ0E/QRPqUs7JUeaawXEl2h5uOlWFq6I9+sZuE9hm8n0OqIancfvRt2g1yfiYQ0pezN+wsotEAzn/cMMhNeA0htumKaV8R11vgm6NqQmWcTwD9ZE2D4gT4BeuX2//sjyGEnRIFWssakcnMqTKUUvYWkx/0V2dQ9NO7JjZv7NT8jdhkJWZLPNDAXYnTgVDTVOMkTnY2FZP1XboKAU5Bus6ethGnf6w41rGsocrYYPsv1058iFLEy+wxFcrNQ4LMe8R2ptXyXjE85Ou0DlEEyem+dRrGKjr9/HT6RFg8Edaxek6sPDmMNtFy8YVNE3GC/8cXOCFmSlbuQdSUcfm0UyoRHembafs9I+BOs6agvFrMGCEcCsB/Zp47VnC6LkUSoICLBtg6U5L1GupHk4aolbsjddMY/eZsNA9ezXtp3WEluFWT1Jsod1JRRY8C2JKM5B9s3Mj9OUrPossUQRpp0hH1wAfo6MZp+CxFZp7ACtMIaMgUs06Vv7egZt1V/WfZ09CKmUMcksU7yZMC6Nc4GVCclevho82Qm6Pq+yaYQXQi/i/v2N2h9Ue/PKZdOUoFefUs3Oyf4Z8nGQ4cwkHdZSetPqcMS3dlyLWXBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGlZSmtwSXU1KzF2VjJRaVdzQnJyNmxydENTNjlpUDRlY3h1OEJDeFVoelFm?= =?utf-8?B?ZnpCSzZDTVZtUEZ4NmRpUHBrWWlleVRTclltblpZdHdkUDU0elVUS0k4TWZa?= =?utf-8?B?bWVBVHFyUDhJdFBRNVUzbkZKZisrd01qTm9DdXNzenY4YnNQbjI2SnRkOGg1?= =?utf-8?B?UmJlSlFpcjQvVXpZc0ZIOXZyY0xnSCtIVGVvYVcvbzQwOEhxaVg5eVZoNXhT?= =?utf-8?B?U1ZHeVp4a1k3MHdHWTQxeFZpVkJ1RG1ZTkJMU015STR2ODJlNWNiaTJpdWhP?= =?utf-8?B?N1RjMUdyb2s3QjcyeFZQSDNJcmliS21DVXZEbzVpT2tSamFtWUlrVG0rKzdF?= =?utf-8?B?QkZMMVJjSmFMc09uMnZlOHZBT0JtVXN3cE1DQXUvcCtJVmdRemcvaTBOVE9D?= =?utf-8?B?WlFzRnJGNWI0TWdjd3N6cThPUEwxOHNMcWZvQndGdFZjNTFBUFVHRk1CemNR?= =?utf-8?B?QU1rM29DMW9HOTJSNHMvYmFxdENLa3hlaFpHRFdPYUg4NEhva3hFV1J3d2V4?= =?utf-8?B?c1NHUE52Rkl1RE1wanNRc2ZBMTNJVkIwd2I2K0pMSC9WejZGTnNURWJ5czNu?= =?utf-8?B?c0Z1a3lzajFPcmttKzZMS2lnbjFWNzlZb05LWC9LWVRLQ3F5Qkx3Vkp3YWJq?= =?utf-8?B?T2FSVWZUZmtjdjQ1NWkxNk0zaDM2UVZ5RVFSN01zTWNTaklzRzQyR0lDNEE4?= =?utf-8?B?VFUwc2orTXlMNE1UUnZXMUpBVFZWOTFYUFl1b3IraHBwSkNuV0JRamh2aFE0?= =?utf-8?B?N3Zib2dZRGtveS9ueGYzVUtHby9RU1lyZStEdjl1ZFdiQUlCSUhKYitsUGNH?= =?utf-8?B?Q3M5VWRscGVQaHdQN252dWFJVUV5eXRiYks1Q250elJSTWtOUHlNc2lzbG1R?= =?utf-8?B?TFgzMlNuSGNzajhMUjVVNTFsb2hEMTBDUi9kckVycWI4Q2pId2o1d0pEaERZ?= =?utf-8?B?a29XT3EzSC9wWEVxQXA4UGRncGhVMzhnUFYrNTZYWUxqd3NwTmhiUldkcFVs?= =?utf-8?B?di9lcjRRRU9wR2V4a1BMSWtzQ3QrVUFiMklaZEtYOW1xNUtvaGxGU0N0bWF2?= =?utf-8?B?YmJmZVNxNERUSFJFNTBiTUNWc2VqMUg5VFBVdWp1Uk9MOElWQTF1T1RPMW92?= =?utf-8?B?Rm5YcjA5TlJZbGlrYmVWKytYT3I1ZWpqaFY5Rkpqd2lrOUNnMk81bjA1eXg5?= =?utf-8?B?ZnIyZ0huZko2RG5JSytxQkVPTmhpMFd3Q1BzQjVCbE9iUGg1dWZleGlPNHlT?= =?utf-8?B?QjVPQSszMi9oeTJzWU1WM055SDU3THVrNm9xNTRKWDdKemRnMjJUTjVZZGZG?= =?utf-8?B?UEpkZGdOSHhqQzhVWjlBZUhubnBUZzluVkhZZXIyZFJkcXRiZkZ3MTFUbXRO?= =?utf-8?B?Q1BrMDRZQXdjNjk1Q0hGK3hPVGw2M2RwbjF1MXo0eHVGZW44cENJOVZNWmRD?= =?utf-8?B?cm1ETHpXNWdEK2JyMVNBcEJ3cndIb25MQ1BLYXl6UDlnTVZVTS9OWmp5cmYx?= =?utf-8?B?cHhQblZHR1E3SWNCeG85Ykd2QlYzWUZhQ1JBaWV5a09SV00zZmo4ZEIyMG1r?= =?utf-8?B?eGxUa3dmMGNYOHp4TXowaHU1OFhhQnU3ODVGNGk2NkN0ejh0NXFmenRtVVI5?= =?utf-8?B?YzRFd0c1NmYvdkRiS21JcGxWK3RxRFl4ZVppOFAyd04yZmswZUlZTXhCMCtr?= =?utf-8?B?T0dVdEt2a2JaM2ttczBWWFAvZUl6Q2RYbGVKb2RxcG1Yci9PVW9oRmJRbGJM?= =?utf-8?B?ZVpFT1E1eU92T1BlOUU0U3AzSlpWdlE0TkRYcjFLK3prS20vOFNsVjl5NWdG?= =?utf-8?B?VGg3RW05S3JGT3Ywc1Q0QWFhVzg3eU9ZNWRnemxOWmZxWWFhMHZnRmZVZXNH?= =?utf-8?B?Q3l6NCtRMlhNWksrN3ZpM2c5N3dwamkydjNiSmtyaFFEVXRDS0RwUExJRzdE?= =?utf-8?B?eXhGL3VVTGtMbjEydzJZWXF4RDFlcWNrYUVJcnRwUnFUZlpLR3k5TmYrSm5C?= =?utf-8?B?ZllBYkVTOXN5LzFMd0dVNFRBMnBBb3NBRUd4SFZuSElYZ1prRjhlS1VHNzQ0?= =?utf-8?B?dExSb0FwNVBTcWhaczVKeUE3OG9HL3JpcFUyZklsbE5GV1FWVFZWT3VyeTVC?= =?utf-8?B?dDV4NFdodXJoN2VTL1E3WTZkb3ZLQzJDNzVNbVR0N0Z4cnBJUXVmODAzY1lS?= =?utf-8?B?NTFDZzJDKzdSblpXMkxjM0NLSTNTd3dFZjU3YVllUmNFZyt1ZFZ5ZGhabjZM?= =?utf-8?B?a1ZiSGx6bFNTRitYaHlBU0lFNkcwdHFpVkl6VUQ2cUxMTTJkL1ZoWkhTME9r?= =?utf-8?B?RlZQRnF6V0JIeW8xL25abFE4WVluTEtGTjI5U044SG8xL2w5VFdEZ010OXpZ?= =?utf-8?Q?0NYf6exCvz+bvNu3weiXrfIE3gGstcJOGNNlEkWIkBiwj?= X-MS-Exchange-AntiSpam-MessageData-1: KAuGGaRgiFyX0Q== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb7bbccc-cdd2-4584-3bfc-08de7b5120a9 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:30.4734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7AknO4XpHh+b+zL47XVeFfSnARJRmOF2aSrR6dA8hziFscSR1Urc0xnzcmTQEflMnk9/6M4MLrVaQ8FHbbAVIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7340 Unconditionally call the variable length payload code, which is a no-op if there is no such payload but could defensively catch some coding errors by e.g. checking that the allocated size is completely filled. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 806b1e02715e..b41a866e24da 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -548,16 +548,14 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, = command: M) -> Result command.init().__init(core::ptr::from_mut(cmd))?; } =20 - // Fill the variable-length payload. - if command_size > size_of::() { - let mut sbuffer =3D - SBufferIter::new_writer([&mut payload_1[..], &mut dst.cont= ents.1[..]]); - command.init_variable_payload(&mut sbuffer)?; + // Fill the variable-length payload, which may be empty. + let mut sbuffer =3D SBufferIter::new_writer([&mut payload_1[..], &= mut dst.contents.1[..]]); + command.init_variable_payload(&mut sbuffer)?; =20 - if !sbuffer.is_empty() { - return Err(EIO); - } + if !sbuffer.is_empty() { + return Err(EIO); } + drop(sbuffer); =20 // Compute checksum now that the whole message is ready. dst.header --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011063.outbound.protection.outlook.com [52.101.52.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A8183783C2; Fri, 6 Mar 2026 07:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781759; cv=fail; b=J6DUH9sW4mUdwe459QNgjfgkuVMk+eam8QeoGkOEUPmC67GGAqEbcTQMukFrtX72qR/7wy2jyKRtq7RJBBGBAIyGqi9/NthSyl9ZwQxSmaTY8OGOjASeJWgmYGXFsF157xXR7ASegmH9XqPw81/jtA51QcWPZZkE7IkB7jBjp+M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781759; c=relaxed/simple; bh=XlUqIGeZRmQSM/rBWK09aSaj+UrLbE8blemwe2oySXQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=VXrUtOGFLKrADQuaHH+SBbEOxIvRp7GGNfwNW+SOtdhTqoLi/hToPYhjahz7v/RJHBjFe2K4zjQUEV15Ggx9V6h6vakiJmFtwvKoeS1o2JYQM/jN6s6vXSqq2b4/FFvfUyPt4dJPahgh9Zqa4xPi+bVPSf9Mgm3UNc+EIvUXyHg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=SuuI0Nrv; arc=fail smtp.client-ip=52.101.52.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="SuuI0Nrv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wyIh1M5eBETZGVLuXg5qLGWxolLd2v1I5U4TvQ5D/4mZ4JOBAzOqXU3kEkWaErghBEOJ5enAGVly0smfYzFdMEA6BS+8bhjT84Lxmb1cB8BZWQ5IpmA7DJxWET1RXgdpSAFXLAjiPWB2wB7Kip9vAXkYSr7sY8vs8gRG685t/DIa4EqUKLKd1yP71ashmVCay/R6BIcZkrE348rdl9Orwty1HlkEWvTJwqdxTiAfndldWFb/nyFOYThw5r4m4B/SuPI2iY6VVq5WOUZXreqNu83TE+Yb+1bflwXjPTyYwaTgHg8FpzY+4MOJLLZtERWDZs8obs+Y1nySD1tl1Fb9ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NtSI1x+tXgrTn6AxMNX9hjfaFkfZ0bjfJdroggZg+ro=; b=DBInOBhai4NqeGqbU8jOiGVYR0hbw/yvYq3P0NbtaAsndeZVn6izGkGDbxq9frkPGuwdQoVQhpEWLMogpevLRmUd4z2uMiyj6Ql3JtGTGvInCodxWlCPOECK2UppklpL0DDsuaBgAE0TaIGI92HaVzt6BKnKrImsN4xB/Rfq/HnutNpSsJg4WVCDpL8+0BE7c+P1YM0ca29CsQt7VmW5qD8NCI+wkEcm/CW9o6g157Tf/+GClGroBrrQ024YsQYTkqTHD8vNcNIEVrTTv85pFmdu7kcGsY1QMBD5t+miRmpKjfpX/9cqgYPQgAlK+3dvvSUScGCiW6yKlCK2Ong1Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtSI1x+tXgrTn6AxMNX9hjfaFkfZ0bjfJdroggZg+ro=; b=SuuI0NrvkEaGFv7wJFX+FgfOPbRsp1DrxowYHoB1mT5WbZsTuLeRmOpqyG2o7kzfcWtgQZ8RztXzXedKuTP5vQGhGfgggqk6intEeM15sA8Ne4T7aytuLot7xYFmx18DplYULTIPZAP2jxCN7fB7Nz8aWypEgUBAnVfXRGFYscK6nHAbwwNGfnR4QS4mHKlDCRlfzWo5Xxtq1c8V9qSrbt8LH8A78NaNCIJ8CUYJLRryQ/2ZZM1Uat/CTqM6XJa5+RRUkh37RhEs6GpbNugb8VOSp82RZS7zQW2GzK3HgHpYxspxdS2ugbVMIOnO2yCNFblH6WQzFhP8OJPXpNIqvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by CY8PR12MB7340.namprd12.prod.outlook.com (2603:10b6:930:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Fri, 6 Mar 2026 07:22:34 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:34 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:04 +0900 Subject: [PATCH v6 7/9] gpu: nova-core: gsp: add `size` helper to `CommandToGsp` Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-7-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0138.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31b::13) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|CY8PR12MB7340:EE_ X-MS-Office365-Filtering-Correlation-Id: 80f74e43-ed55-4fbe-b603-08de7b512308 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: MO1t1Vk29072hk3OSf3wIt1rFuJNcxUDW++QC31D6G9WKGpufOcxp4sQpJ7lT3OZVeLbw0o9rwR0dEUgkNTUQQaCG8ZJ/s3v2EOPN/0Qd1pDn30lB+4xuxo1cR/2gyJp0fPBz0oTl0b/aptozmnss+2xtIw0N2S8vxQJbznzfrZcye2CbzziEOS/hISkAnb9h8oY9ll5KW1SKQXt2kgosr7Xo33CO9HzPi2YU+Ec9cuEsY3VmGHkg/aUNXJUNLiILg2qicawD06WKxPqzFDGBfGUoT0rkjq5qQm8mQWiKQgbrLWba0Ji/H/xvsyM0i9qOWGQsiyaQ1nWF1lBrWVJdCh/6e5riBi83M7OnLSyeOwMNQRfbX3+zZCzcMtQ4bDxRWA2Fg69WYOb+6NFPA7gnnQ/sR7jA6M5qubxq4oDOiOzZJQL84Ncu2uduM3WwWebtSgpwjhJXnZLpOEWvqwmY9mlMMVE0RxSS6u9JFBsbl+89JVXQIz5jmDv5zH3OSfj9MbfzyrXk+5OYG76SMUlXiM9gk8246X81sVcPPxBlxZ66VfU52OqB/JYF/ThKgTN8ddsQ+bOHSVWCrmeNSFfUKO2PErYDDtSkI2ctxJp4ArpG2NmTDf7q9CDWUB1sPAR/fPlcg5P0xioqDmIZDpoF6d+kdw7zEf9SZD3Y4Z7TfYQA1Ss9u1C8pMJahasuLAXq0s8K6eizrY1h46nLKR8l5lIWK0uU2x3E8Mftd9kzeSy/K3wQezzoMPnXDriXdbI3mpxjamRlICkjIYc0MGOjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXNoRkRVMXFlM256anUxNFlGOG1RUzZzcnBSS0Z2VlFUV1JNelMrKzIwLzhK?= =?utf-8?B?S3ZOc3MvOW9kcjYyTlMzUWVVMVRIczhKSVdFc3JaYW5CZSs5cWhCU2ZBY1h3?= =?utf-8?B?U3R4RlgraWpvcjF6TENNanRETDJIUFU2aWxtS1hNSGFoT1FoZnJHUXZGenFP?= =?utf-8?B?Sll2UUp5d1Q2bWx2ajRlZmxpUTB2SmdpVm1SOVowSG94MjAxQ09CMEJRS1hD?= =?utf-8?B?YzRtZ0FXU2NhaHhnYmI1VkQ4ZDQyZWFHTTNSUWZGYlpYQ3o5ZmlieTg4SEN2?= =?utf-8?B?RWppSS9uOGhoU0VLQXFuZVIvbDFFQkVoVzJ6L2duMU8vckJIZEFzc2NTVUwz?= =?utf-8?B?ak1aNytHY1NHMzZRNGJ4aUhVZnJtckhuenlvVFNscFRKdFJVaWxDdTRrTjMx?= =?utf-8?B?OHdpRFR5ZTVscStUOER0U3FJV3c1Q2dhalBSRmpPVWlvL09sMCtHbTd1VzRl?= =?utf-8?B?Y1lpMjRXMUllUDViYWFnR1E1TDZjcCsyeWZMaFhOcTgxbmhJUXpvVU9pRUsy?= =?utf-8?B?eDlxb0kxUFkrMnRMS3pBNDYwV0FsYU9Mc2lGVzM0dDZsWElyclRvREVmaTVl?= =?utf-8?B?UjhzcUJkcGVJS1FVNURRa1pNdHRQZXJiYWt1M3VSRmlPQmZWTUVpSFExRHFm?= =?utf-8?B?ZUUvcjFla2lRajlZeS8vcFN3TEVnSjIyZkdaZzZ0YXBYZ2hScDRYOVRMTXhm?= =?utf-8?B?T3RGTFlWNmt6UmlPbm9tVWJjR09UVGNBaGVFbjF1YkZFVXZudkt2aXZ3OERo?= =?utf-8?B?TXRraDN6aDQwTTBoUlBybURLQndVdTJKajEyaDFROTdNbGc0a1BDc2tjc0dk?= =?utf-8?B?TkRwTE04RDdBK1l5amJBWFhOd3d3MEtzQVU1enYwNnFyQXB3TGNTTTNYTzZy?= =?utf-8?B?cWxWdmNocWVWWEJrOU9FMXZxSXU3cmhDbHZxZ0FmM21GMnNoZGhkWm1JZ09Y?= =?utf-8?B?UkpjRUN2V0EzcVNKSkRaUkpYalpNZnhZVDc3TzJzTTNYVzVvWEZveFZ6d2Jz?= =?utf-8?B?RTk3ZHVxMW5MdU50NW9ZMXp4emtJS1dRdGpFNnA3SUxxN0RXbjhCUDY1UUVT?= =?utf-8?B?K1dCTUI4ZWR6ODgrMUlGSk9nWU5HK0NFVVNIQW55Y1JleEc4QytCVllkcGI2?= =?utf-8?B?cHE5UG53TDE2cmVWbEp4ZUpCTWszT3B5bTBRNmZJa05BaXZsMXJrL0hLMDVJ?= =?utf-8?B?NE9IK09IKzhRYnQ1Wm5IL0NTVlI2ekxoTTNuYVlsNkluc00vRktpMDhpcmc0?= =?utf-8?B?TG1Ed1NBR3ZmTXQvUUdpTGZZdjVOL205bEVFdkNUVThramREdlpRTFZZbGto?= =?utf-8?B?UDhQMUlaS0s3VDFyd3Brd25oZmFQdDhCVkRDRHJyR0NHWnBESkNwVCs5c1Rt?= =?utf-8?B?cHZYVlRjcXRRNTVENk5qY1pROWJLMWRqS0tmcVFyMENTMzRRU2pDWkxnTW9B?= =?utf-8?B?dDd0eEpNcUxnbzJjZU1KWHQ0RnhSVGsxeHpTb3ZLM0hNdXV1dzVPaWdiemlj?= =?utf-8?B?enl3SkF4SWgzNFNNYUd4SGEvNDMyS3o5UmpCUHlrTTgzcGhFdGtUQXkyWW91?= =?utf-8?B?SU5laUlzTjY0cmIwem9LQ3hzTW9LQms3WHo5SDlOLzB6QXdqdWVBYk8rVU1v?= =?utf-8?B?cHV6ZjZtWlVFSVo4VkU2b04xdFVuWlVoeDU5M3J1eURkQ3ZCK2pqKzNhTGFP?= =?utf-8?B?aGxoSjQ4bDNtUUszNTd5cEZPRW5SU2o4ZDFWT0pYb2h0R3A1WFdDRUpxRXlE?= =?utf-8?B?VVdGWnJmN1dqdXllT1U5TkZPNFBZd0s1S1ZxNlNDUXRWVHZCQi82b2p1YVh4?= =?utf-8?B?SXZEUnhqTnBiWnR0Zi9UQi9QZG1selhZMVpVSjlyZjVQcHZuazRwUXlNbWdQ?= =?utf-8?B?bFZCUHZVSGUyRzBSb1QvMlNRZXlFWkxEWGlZQ2hOc2xpeEVBMjJsb1JUZEM1?= =?utf-8?B?UHYyWmdYZ1VmelI3cVFLT3dPNXBySktuNStzc0VLRU1GZU5reEFaeDBCS2NI?= =?utf-8?B?Wi9RLzE3VlRUbW5HeVJwT3lpdUczTW5DTUZNQjRDaDgvQjcrNFRjeWZZNEpx?= =?utf-8?B?MUhLYjg2Nkpwc09kT0o5S0R0WWR0UXc5MW9oOGt3UlpuNFRaSW5rcFhDWXVL?= =?utf-8?B?bU5QelJHdGxCcERZNG9NM29JeTNMOWJybW5WS2wzTWhGaDQ3eUxFWTdRS3ZY?= =?utf-8?B?cWI1Zy9KZDlBd25Md20zRlNJMEhub2Q3UmJoSUQ4bWx1WEQxYlRlYnpveTJG?= =?utf-8?B?QzF2M0tFWlhRVWZITS80R2E3TW15dENZeGd3S0lCK2V1ZUtWZ0F2dlhtNnZ6?= =?utf-8?B?K2Nhb3Y3QkVUbkNjL05rMWVubWRPVlB4L3A0dG1OOW9tMVVueHdMaElObEhE?= =?utf-8?Q?RKMlAl5uO6YDgS045umMHK/j+RWt5sOOe82TOztFwSNQC?= X-MS-Exchange-AntiSpam-MessageData-1: 8+ytoNtjbgk9LA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80f74e43-ed55-4fbe-b603-08de7b512308 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:34.6046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1y2Lpis0PlcZv1D8XjzyvKvJmW4aptrIHmCYEaZTbxggDTtHUhqHvEO/OJ/ND8rOxB3ANCE1LHHMNDQPc9dJGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7340 Add a default method to `CommandToGsp` which computes the size of a command. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index b41a866e24da..861f5666fe7f 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -94,6 +94,12 @@ fn init_variable_payload( ) -> Result { Ok(()) } + + /// Total size of the command (including its variable-length payload) = without the + /// [`GspMsgElement`] header. + fn size(&self) -> usize { + size_of::() + self.variable_payload_len() + } } =20 /// Trait representing messages received from the GSP. @@ -529,10 +535,10 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, = command: M) -> Result // This allows all error types, including `Infallible`, to be used= for `M::InitError`. Error: From, { - let command_size =3D size_of::() + command.variable_pa= yload_len(); + let size_in_bytes =3D command.size(); let dst =3D self .gsp_mem - .allocate_command(command_size, Self::ALLOCATE_TIMEOUT)?; + .allocate_command(size_in_bytes, Self::ALLOCATE_TIMEOUT)?; =20 // Extract area for the command itself. The GSP message header and= the command header // together are guaranteed to fit entirely into a single page, so = it's ok to only look @@ -540,7 +546,7 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; =20 // Fill the header and command in-place. - let msg_element =3D GspMsgElement::init(self.seq, command_size, M:= :FUNCTION); + let msg_element =3D GspMsgElement::init(self.seq, size_in_bytes, M= ::FUNCTION); // SAFETY: `msg_header` and `cmd` are valid references, and not to= uched if the initializer // fails. unsafe { --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010060.outbound.protection.outlook.com [52.101.61.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DC9378802; Fri, 6 Mar 2026 07:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781764; cv=fail; b=l/aq4/Od9G8W4EZQWSFfUBrniOBmQHQsgRWh5EAYaZ9e0Y3b27e6G/pRJvkuNQ7X6Aa5qV7mmXnSE2GwzyMKSgLxtGJ3wNHbMv4E0R1fojzSrYMrFGyjxf8WpylZZj1lkCuWSA8vsCrdjSB0S4LofT/JluOvtpMvWet1ftQ1q+I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781764; c=relaxed/simple; bh=z0f6XvIA2vSAycIJCWMCI8RSvAPmWW+AD0zwHfmHnFY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=cOcr48oHPbanEKuz17FBWyzMJOuUWYko4pJcx+SiH0UZqb+GYk6ZxO3Ipu0CIOzXNBo2V8UyB2E2jfbyfOw5ZLCpRKbVEIkXP8d+jOWV0j4If2Lwe0+ycje5c3xDyL4gqwSJtmzyy0j8AeO3GGUvue/rPZoM8axvtA7xCMlJw+o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nNKCzo6l; arc=fail smtp.client-ip=52.101.61.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nNKCzo6l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vaJHvNdEANPZ8XE3pBoDq9dckEGw8M6QykZlqL1dgRtqdDDXmkF3h/ONoEJXwDWIg0bJYmt6tL7pbi1JuaJj3O8jc/3pP8asPZBcuyjLcH+lNmMfcIb+SFprGAiRbHhTgbbzgTdGr9pRTjdHxLpgfoRCWexOh+QS525afTu4rPve/jyHNYUiP2vcfR9/kEyIpEOazAtigBLZzb4MNnnS7D3l0osxMQeizfuaKV3jlP+2Pnd48fgCtkhkFyt450kdlwbaTnypblIyLBl1dFFvKMWll2ZhMYsrHl+6sH2jHQYdNxDZAVtC3NHmiPMQ5DhCX/9ZsAlZVaSCcMPbdvAomw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PLtd3okNEyu+UL3PmN4CTgjgHke95Gb8gwf/QbI16l0=; b=JpIAIa4Y84RTGY/lETPHsBXXMIdjzXv+HkQf6IAqzW7qGNqxlfqcHSRUNXLfVYRzLtV64JtVPx3sFB6MFJPKW8a2yN64P9YnZuR+xI1qa//1KtillaarrSK6uJSij2mR5MBk6BQTI6FuFSklvAJNoyTFfIZ5u73VOh8tvrUAjk9xChKkT6W67Tsw99uUsCK9L2WC7IzQ/BY3PUNWB5j67ShP50f39hbf/L0vhnoWASn/eSidBpGcANI91KMLRvGD5FGmLt7m5GCEMKXt/nkCzyyiVmYo1lPORtzuFSM/xf+hXdK8Jko8cHN5EjlUO80/KG0ATe5IOVNVEV8Ze5MfEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLtd3okNEyu+UL3PmN4CTgjgHke95Gb8gwf/QbI16l0=; b=nNKCzo6l0v7/RpMq/DEPcfP31G1U7nUVS2ZlzyKVqOb3/DEoy7gViybMydV7Rs9YuYZbcqHbxBEBn2ZcR+UhnKXfPY1QDLFdP4ICklpYqHBgk14a4hoIJy+Z/QvqIJiemNx3dDH5XjM27Y8TzOROaa5ynRe0OuzceuGOqxSWQmRX4o4BTC4CexAn9NDb3wPQsD07irQPlXzMJO6pStA6WRPJHbxIjFnMYLkyrkf9NrX7bCBkPF59DT7gZ6xsnJfvqMugGJcrleHY+Melk6agPUmKvX4lwvHSIux/b0KVpiYGpv/LoMU2C3xk07ttOmBRTYlvpsL+Ut5/j9MmJTJmsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by CY8PR12MB7340.namprd12.prod.outlook.com (2603:10b6:930:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Fri, 6 Mar 2026 07:22:38 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:38 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:05 +0900 Subject: [PATCH v6 8/9] gpu: nova-core: gsp: support large RPCs via continuation record Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-8-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0252.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:456::10) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|CY8PR12MB7340:EE_ X-MS-Office365-Filtering-Correlation-Id: fdee5a97-abe5-426b-5c20-08de7b512587 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: nnKQMIqBApPCFpN6jJBUdnoYiTr6P0aJ2p4fQkBAvg3tzTxclL2fdwpRjOHQjPlXAg4HQoPn+FVQeIPnkrSw6cJtpIOxv2ecn8nGX0yJF08FPqgmRGDxncvL0ejE9+gnjth6ChEFd7pco9exJDzdAvwQornxHJRwRPOJIAXGXdW0deWbO8/JRe67JJYzDW+ikFH8/nTck+s6LU7jD4DkzI2qjPAuci6a0H8qox/CH/DphNmHFfecJ+FtjfcgrocMX9O5k3CTeRADfgcdK97inX9F2sLl0JRtwDjz97VpEn1BGheCo396N+MQwglj2hjaFCnma8WXTZmAHS2E/cl650OB6Ecxox/d0z/JDgw2FOlGEYhc2zc1b/l8SkObvjPzKyyGn62m75p3XP8CM4PH5cN9v7D/woYHvfYGv6nSrOgqFopdmmTAL0bAotSYSp+RW4dNEukj3gVLbNyNN/YDeJVJx5uqppdURih3wgGyUEZcSh5RDqgqRWQu2u+rkMc2LcjhnlhAthM4E8+Ou2XFlPCQl1hpCd04+GrsHNJsJZk9KFokwRdacHMgkD6aTjwCu6jWTps4CoZW4MbkXvN/TEeM3p4XKAni9A49Ho51j0R7w894xpOp+SytqvS7v6GijFs378a4BoJSLVLOcgVSzHjj8SyT41B/pDia3u6WRh1QRJg/z/x8IQNw49xiATQ9UnQf9YVPiIcpH7cfVtURiZGpyTA8MopwL0EfOLlOurrKwGSjb7wJjHGremn8eZ4uIZJTOzvsuwL6CVt8/2PL7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjI3S3NvMmJ6OTBZNmY0RzY0Ry93bWlOdDlJSU4xa2NySjNDK01Uc3FNd1JC?= =?utf-8?B?amN0eGlRQ0dHRGlYZXBtaGxLSVR6djAzOFFmTTZQOHpsQ01uOXd0N2pQNEZ3?= =?utf-8?B?ZERiWkRDV2hsNlp3aHA2YWZRb3pyRzVDTndVeUVRa3dXQXRvUkg3K1NpbTZI?= =?utf-8?B?STRMWjZnaUxFdlhkck5OM1VkNTF1NUpTaWtTNkl6clRjOG81S1hQcjJURm1S?= =?utf-8?B?NTRtNUJISXlTQ0RWOHJ3c2RTQjZzRWJ5MGpiN1hXc2JkYTRzSWhDR2pteGFZ?= =?utf-8?B?SXgzRjl2RTA1V211QUFOTEpiL24xb2xwdDVRRTVIOTlQSkRNa0ZLSW1iODVw?= =?utf-8?B?Um5IdUdCNTFJZ2pPci81TEJuMkN2cy90Ym1wclBqZjVtbFJTR1dLRzRUd0gz?= =?utf-8?B?UmVEb0ludWN2M1U0WDVHMkNrazFCdm1UYnp4eGU0QjVjaVgzZzhrRGl0QjhK?= =?utf-8?B?ODNLeEVLdzVUWkUrUkRwRWowU0JSQ05zUG55NkN6Sm9CUnp6SFduSDhJT2Jz?= =?utf-8?B?VkhWZ1JFdnp3MzJqeVFmRTR3Z3pWVU4zOURWSzVFY3dDSlZjNUp3UHZVSXdJ?= =?utf-8?B?TFBDZzd3Y2huZExpWkxqOVdUTUgrUm1lTm9PQWFVZWlsYjVoYkp2NGdnbklx?= =?utf-8?B?eTN3NzlPZjlIREYrRkV1UWhVaEdLNE1pRHhqQ2l6Y1VrL3dhVkk0R1FiTWg4?= =?utf-8?B?cC9MQWZFV2hHYkc4b1NYaDdrUlZCdmVIY1FrSjdtZGsxNXkzQnA1YU1nNjlx?= =?utf-8?B?dEdnSlpFZHFOQnRIdEkwYTV4RjAxSXo5amhJa0hpQ3RLejU4cGpmS3N3Rkdt?= =?utf-8?B?Y3dGR2dmY0laN2I0Vko5NGg5Rys3M2QraFpOMFFHVkxuUjhIMzlmQzMzaGIz?= =?utf-8?B?TFArVjNZN3NJcEtMdU1QN1NxVWxLVC9URG9rUFZ1REZ0N0E3KzBQWTlCYzBX?= =?utf-8?B?SU44aFN1UzFtYWt4a1hUL0R6dDhXYzhrOHdQOFVHODdzSEVEWXQ1Y3JIVzF3?= =?utf-8?B?TERtaHBKZGk3bjhkcTBVaTJoLzJkZFJyWEtTTXhwazhZOXBPNEJjOUJYMHNk?= =?utf-8?B?R0N2ZzB4cUxnS0doZkg3ZGVjOFpyOU1sdU5sRU9idFc0WFRUeUEyUkxINzZh?= =?utf-8?B?eTVPK25WejlkV0lKSVZ6OTBVOXlkc2tQa0kzZUNQZGhYUTY4Tytnc2J1Zzlz?= =?utf-8?B?UG5leW5IUEZyQUs4dmY0dDZJbzFRYlh0bTBDemVRRytNNi9zRlFRUU8wdlRn?= =?utf-8?B?ZjZkc3J4aityTnpwNmdUeWVUUmFTekh5M0I2bTFHWEQwaUN2SFZCbytORmIr?= =?utf-8?B?TDh2eDFrUzJ6ZmhmN2FmdWRUdGVPL25DMTVRM0s4bkVjVVFVZWdBbG44SGpT?= =?utf-8?B?bkJaVjhVUjBacWtDMytjT051MFlLdUtoa05SSmpCOXNWNVJhR1FRYzB0Ukxj?= =?utf-8?B?YlFSdTd4U2hlSDJ6N2MydThzOTlqaERHTWtZTWxEM01rd3Fnd3FEcklNdFB0?= =?utf-8?B?QVdpT29QRW5mUW1xcXNqZGw2eVhEWjlEU09CV3NZNW5GLzV6QXViSFd6Yzlr?= =?utf-8?B?TUlNMnAwSENXTnNzamE3R29lQTFya3lsSlV2a09WMFdPMFN6WmVHTGl4MjR4?= =?utf-8?B?dGFmMDV0SUJFNzVURk02MlEyUzVZMEFFM2NqZjIzWWtPNVRqUm0rWFBHTHk3?= =?utf-8?B?NmlnMzlvekxBaUdmS216R1ljQzFFNlFJa2svYjNwZDc1NzJnNFFvcHZrcjB2?= =?utf-8?B?aXQ0dXJUcWpKdDhmY3Y2aElRaTZoczRqbFJ4TXNXazRPYXBVSTlERXN0UWhM?= =?utf-8?B?ZUFhZFAyV3VNZU1tcmlnMy9kVTBwVU9IUHdaeXJ1QUcydDYxMmhxcTZ6aDA2?= =?utf-8?B?OEliM2NHQW5rQzhac2RuQUJHV0g3WHZWV01QK3BDYitWZkhKdGExMEIzQ3Uz?= =?utf-8?B?cTV5dVY1Ulo1ejNXTW1MajBJN3BuWVE4Mmp3OTJoL25aTzdDejlDaE5vN21V?= =?utf-8?B?V1hyNHBpQk9nNEFubEo3R3p3Q1g2OE5Xb0NxcE56TndxRUZvQTFlQ3o2RlBY?= =?utf-8?B?U1dqS2NOZExIMlV2S3YxNlhadiszKytBT1pGbXFZeGM4eXZNR1dUQW15NmRy?= =?utf-8?B?bzE5OHpkQmZFVVQ4T29pWmp2OWswNzN4cWtya1luYkpleHFmZWNlNFdkUi8v?= =?utf-8?B?QUtKcVVoVm1xYnF5d0l5Y2RDNTFMTlQyQTNmNm1kbEVvK2NrNHVjNDJwNml2?= =?utf-8?B?VG9jT1RENjJiaGNDNnpRQllLRlBCOWZLd2hhVXlMbUVSRW96b3FERzVYT3dx?= =?utf-8?B?ZGFtb0R5S1N6MUcxVVY5VTJnQytrWVE5bmpJMnJacWlCL3ZMYUVpVVJZMjND?= =?utf-8?Q?i0GmlTcZyXNFdNwJ3y8tGEmmE3ndcFPBGuqrrFkQmkulU?= X-MS-Exchange-AntiSpam-MessageData-1: cz83IzxURNbrFw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdee5a97-abe5-426b-5c20-08de7b512587 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:38.6308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jiE+7sCMUXeWruSOgE3tkPLtySqcrBSqppUIjn00PTDgfKyZu9sIJLOLuZAjBEnWGDmR/JipLYl5OUuScwkeTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7340 Splits large RPCs if necessary and sends the remaining parts using continuation records. RPCs that do not need continuation records continue to write directly into the command buffer. Ones that do write into a staging buffer first, so there is one copy. Continuation record for receive is not necessary to support at the moment because those replies do not need to be read and are currently drained by retrying `receive_msg` on `ERANGE`. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 42 ++++++- drivers/gpu/nova-core/gsp/cmdq/continuation.rs | 163 +++++++++++++++++++++= ++++ drivers/gpu/nova-core/gsp/fw.rs | 4 + 3 files changed, 207 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 861f5666fe7f..e0b096546d23 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -1,5 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 +mod continuation; + use core::{ mem, sync::atomic::{ @@ -25,6 +27,11 @@ }, }; =20 +use continuation::{ + ContinuationRecord, + SplitState, // +}; + use crate::{ driver::Bar0, gsp::{ @@ -520,7 +527,7 @@ fn notify_gsp(bar: &Bar0) { .write(bar); } =20 - /// Sends `command` to the GSP. + /// Sends `command` to the GSP, without splitting it. /// /// # Errors /// @@ -529,7 +536,7 @@ fn notify_gsp(bar: &Bar0) { /// written to by its [`CommandToGsp::init_variable_payload`] method. /// /// Error codes returned by the command initializers are propagated as= -is. - pub(crate) fn send_command(&mut self, bar: &Bar0, command: M) -> Re= sult + fn send_single_command(&mut self, bar: &Bar0, command: M) -> Result where M: CommandToGsp, // This allows all error types, including `Infallible`, to be used= for `M::InitError`. @@ -588,6 +595,37 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, c= ommand: M) -> Result Ok(()) } =20 + /// Sends `command` to the GSP. + /// + /// The command may be split into multiple messages if it is large. + /// + /// # Errors + /// + /// - `ETIMEDOUT` if space does not become available within the timeou= t. + /// - `EIO` if the variable payload requested by the command has not b= een entirely + /// written to by its [`CommandToGsp::init_variable_payload`] method. + /// + /// Error codes returned by the command initializers are propagated as= -is. + pub(crate) fn send_command(&mut self, bar: &Bar0, command: M) -> Re= sult + where + M: CommandToGsp, + Error: From, + { + match SplitState::new(command)? { + SplitState::Single(command) =3D> self.send_single_command(bar,= command), + SplitState::Split(command, mut continuations) =3D> { + self.send_single_command(bar, command)?; + + while let Some(continuation) =3D continuations.next() { + // Turbofish needed because the compiler cannot infer = M here. + self.send_single_command::>(bar= , continuation)?; + } + + Ok(()) + } + } + } + /// Wait for a message to become available on the message queue. /// /// This works purely at the transport layer and does not interpret or= validate the message diff --git a/drivers/gpu/nova-core/gsp/cmdq/continuation.rs b/drivers/gpu/n= ova-core/gsp/cmdq/continuation.rs new file mode 100644 index 000000000000..67b3e03fd8ea --- /dev/null +++ b/drivers/gpu/nova-core/gsp/cmdq/continuation.rs @@ -0,0 +1,163 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Support for splitting large GSP commands across continuation records. + +use core::convert::Infallible; + +use kernel::prelude::*; + +use super::CommandToGsp; + +use crate::{ + gsp::fw::{ + GspMsgElement, + MsgFunction, + GSP_MSG_QUEUE_ELEMENT_SIZE_MAX, // + }, + sbuffer::SBufferIter, +}; + +/// Maximum command size that fits in a single queue element. +const MAX_CMD_SIZE: usize =3D GSP_MSG_QUEUE_ELEMENT_SIZE_MAX - size_of::(); + +/// Acts as an iterator over the continuation records for a split command. +pub(super) struct ContinuationRecords { + payload: KVVec, + offset: usize, +} + +impl ContinuationRecords { + /// Creates a new iterator over continuation records for the given pay= load. + fn new(payload: KVVec) -> Self { + Self { payload, offset: 0 } + } + + /// Returns the next continuation record, or [`None`] if there are no = more. + pub(super) fn next(&mut self) -> Option> { + let remaining =3D self.payload.len() - self.offset; + + if remaining > 0 { + let chunk_size =3D remaining.min(MAX_CMD_SIZE); + let record =3D + ContinuationRecord::new(&self.payload[self.offset..(self.o= ffset + chunk_size)]); + self.offset +=3D chunk_size; + Some(record) + } else { + None + } + } +} + +/// The [`ContinuationRecord`] command. +pub(super) struct ContinuationRecord<'a> { + data: &'a [u8], +} + +impl<'a> ContinuationRecord<'a> { + /// Creates a new [`ContinuationRecord`] command with the given data. + fn new(data: &'a [u8]) -> Self { + Self { data } + } +} + +impl<'a> CommandToGsp for ContinuationRecord<'a> { + const FUNCTION: MsgFunction =3D MsgFunction::ContinuationRecord; + type Command =3D (); + type InitError =3D Infallible; + + fn init(&self) -> impl Init { + <()>::init_zeroed() + } + + fn variable_payload_len(&self) -> usize { + self.data.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(self.data) + } +} + +/// Whether a command needs to be split across continuation records or not. +pub(super) enum SplitState { + /// A command that fits in a single queue element. + Single(C), + /// A command split across continuation records. + Split(SplitCommand, ContinuationRecords), +} + +impl SplitState { + /// Maximum variable payload size that fits in the first command along= side the command header. + const MAX_FIRST_PAYLOAD: usize =3D MAX_CMD_SIZE - size_of::(); + + /// Creates a new [`SplitState`] for the given command. + /// + /// If the command is too large, it will be split into a main command = and some number of + /// continuation records. + pub(super) fn new(command: C) -> Result { + let payload_len =3D command.variable_payload_len(); + + if command.size() > MAX_CMD_SIZE { + let mut command_payload =3D + KVVec::::from_elem(0u8, payload_len.min(Self::MAX_FIRS= T_PAYLOAD), GFP_KERNEL)?; + let mut continuation_payload =3D + KVVec::::from_elem(0u8, payload_len - command_payload.= len(), GFP_KERNEL)?; + let mut sbuffer =3D SBufferIter::new_writer([ + command_payload.as_mut_slice(), + continuation_payload.as_mut_slice(), + ]); + + command.init_variable_payload(&mut sbuffer)?; + if !sbuffer.is_empty() { + return Err(EIO); + } + drop(sbuffer); + + Ok(Self::Split( + SplitCommand::new(command, command_payload), + ContinuationRecords::new(continuation_payload), + )) + } else { + Ok(Self::Single(command)) + } + } +} + +/// A command that has been truncated to maximum accepted length of the co= mmand queue. +/// +/// The remainder of its payload is expected to be sent using [`Continuati= onRecords`]. +pub(super) struct SplitCommand { + command: C, + payload: KVVec, +} + +impl SplitCommand { + /// Creates a new [`SplitCommand`] wrapping `command` with the given t= runcated payload. + fn new(command: C, payload: KVVec) -> Self { + Self { command, payload } + } +} + +impl CommandToGsp for SplitCommand { + const FUNCTION: MsgFunction =3D C::FUNCTION; + type Command =3D C::Command; + type InitError =3D C::InitError; + + fn init(&self) -> impl Init { + self.command.init() + } + + fn variable_payload_len(&self) -> usize { + self.payload.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(&self.payload) + } +} diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 6005362450cb..25fca1f6db2c 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -202,6 +202,7 @@ pub(crate) enum MsgFunction { AllocObject =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT, AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, + ContinuationRecord =3D bindings::NV_VGPU_MSG_FUNCTION_CONTINUATION_REC= ORD, Free =3D bindings::NV_VGPU_MSG_FUNCTION_FREE, GetGspStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INF= O, GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, @@ -239,6 +240,9 @@ fn try_from(value: u32) -> Result { bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT =3D> Ok(MsgFunctio= n::AllocObject), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), + bindings::NV_VGPU_MSG_FUNCTION_CONTINUATION_RECORD =3D> { + Ok(MsgFunction::ContinuationRecord) + } bindings::NV_VGPU_MSG_FUNCTION_FREE =3D> Ok(MsgFunction::Free), bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INFO =3D> Ok(Msg= Function::GetGspStaticInfo), bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), --=20 2.53.0 From nobody Sun Apr 5 16:27:56 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010059.outbound.protection.outlook.com [52.101.46.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9A19374198; Fri, 6 Mar 2026 07:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781767; cv=fail; b=lDlbmopmny9J6cjIOabVJHB62zlGRAMYD2i85pIi+eZgzZQVGspd4lPGaF8oND1k/dnc04CqtkLRtqjA38aQPwpYpMpzNrAKqjzmCDZn9p+eM+lymX+qi6qRApvQOdQ/0WQZEV2coMEFpxRXLUj5vIEte+4uc12Tm168oPSDqgk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772781767; c=relaxed/simple; bh=nSfvdFIIwow7WQxh09c+7ICijDYf325eGxyABN+1U7c=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=EwgGjq4lDFtSOzh1UUCXj7LlAwi5+P6TfVsubY1GlVPaaCkFXkXZiwdXoMLwbt8QKGyb/uIHJ22e/4fERncvqj5WruJowzbWgnrUrtXR8L54bj0FloxQaUoY/zECDxoIVUTn282zrF1T3kQYmi5FuZdIlZeAkkF2V25P6TbTZZI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=RS2KEe5A; arc=fail smtp.client-ip=52.101.46.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="RS2KEe5A" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wZ/wx0UPwmjU4kNFFl9Dud3XPmZcxb5Hbf/8b9jDbXQyOx0q0/7YBBzbd2hmMxdW56o5M+6DFIyEveb//e9XsN3epylnIUENd4A74kw1SzLIBFs5P7YAruFgSHOfYU1O+JrSq0lHhCWbOk8VkAr+dlI44qveZJDbJx5B4Wrgpp4yrqyudYe8zBiYKn0tn0KauOpCfD/dIo9fBaN/OOSOximHm7zY+KpF645w/e1XB63a/ArISdzM4kP0PTgY3Lbb/U5A2Rdpo8n/9nG8snLw2u5SzNKcBYnmsD+OZa/6IPTiBRkN4Bx3o3mSL0Ft3vxGtUhF61MGFDrGHeHwETGY+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JhjPLt6NxTNFngqKhEkocI+NvtVDgY8YQLLP3r4SpW8=; b=gLl1VWD8v8VR3n9pQLLXDQArb40vOxam8GDU2vk4Bvhh/dX5gn/Pzf8JEAKQdcC5hPeVlGiMAm+DFNC8fid1+N1r8xDK2bPk22fDWMWzp/E8Ol8l0EBbHCkZpqyWgyNCJBoRoejNs/a3jHswnuLyciYqpZwLiJ8tod+jl9IstiwSnkMHBYlvZ33K5L0edKx1/4CU3kOqz/F5ygIC9gT2DKFPH/nuTYac5D6IrNaUPR4RdAEd2Rr6MrngbNCEWjd3yq2Ovd1s7T8xU8BZBG3qwnbtGxrCS7xlHg/iOJWIPRMS1wvGLrlXSLuzcr3vlVWnQtJ81nEhI2q0Qea1Ys1fuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhjPLt6NxTNFngqKhEkocI+NvtVDgY8YQLLP3r4SpW8=; b=RS2KEe5AKVBa1II1UeoTvETbLLKVzktBeJz+h8jTWZjY4gs1XviEWlg0m0V2T/4ClutRb4ahQbOdRq+B+8JL2tS1E0qvJYh3OSACXCrPMcokqyqSh9Taypgq8YqBVV9eIIDsmXKo771vZEtcXYHf108yjaYE0adq3wDMuuIFV7s9kBVzZDkyLan/7l9+98s/PRNEkXlK2EyudCtmooUA/jg6Pq1lfyiU2XgjWLTmimTQ8jyUtobIak4UJsu2+PBuZc51Xr0tqhZdd8ZT3sxQQ0LITosZ+dCGDvgZ9GmsRmTMo/3zVnXB5cc/FU93VFpPL25ciOgdo7/qDs/lUlT+eg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by CY8PR12MB7340.namprd12.prod.outlook.com (2603:10b6:930:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Fri, 6 Mar 2026 07:22:42 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 07:22:42 +0000 From: Eliot Courtney Date: Fri, 06 Mar 2026 16:22:06 +0900 Subject: [PATCH v6 9/9] gpu: nova-core: gsp: add tests for continuation records Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-cmdq-continuation-v6-9-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: Zhi Wang , John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4PR01CA0106.jpnprd01.prod.outlook.com (2603:1096:405:378::13) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|CY8PR12MB7340:EE_ X-MS-Office365-Filtering-Correlation-Id: c48f6ec0-fbac-40b5-666e-08de7b512765 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: qownsbJh03gvXZq89MidlxO2OyNwaLxAiE62DhkT25UVc4CmwiCCc0+WFccASrDvbCzU+m3D2M38Hlx5pSDuvGT1k3z5HQAmhjFh/QhXgblp66Q9Vo1u44evhUuw5MeTS47IjyvmmR8kquBXSuhgkAYaiag/CbuVPybPlwsEf1kK4hxaaUzeqOCPh/D6lodlHaSR1C36AMB0d1LXBnRUATuin/c35T3M/tcM54KGpge5/OlreEToidNBb0qG5oFNBbGQR7VV7bdRSxHKj9ojejGsg4F4JjyEFF0cVOwQgKPFQWKuyITdFrgi97reOl7xNcKZgOzoLEfYPC6WA9O4GA13TF5efcdKAMRea2giqWCPNB2AHOsm3g/2pSwVL26BOATQwr8gd1Z1FHVJegP2XFKX5fiUDVemjW5rIexi/pS5CgOWWuftPrU6K4czXNkwY4lcqF3r4TLfOLjCCwZ8rKwnDqv6YxTEY4/7yEgXNqJU992RTKJ2yHFFagDk9xgsXCyZivLYkOeGQAdkb47zcq+BfTSKqO8jW1D5e1gXVOAoPDGM1RPdh8khGENt5cANCHIbbrqHUnv/z1jyYx3FKX53b6xwfXxo/b+oXWDYBxYHA/wL4m/VCIb+Uek56uraqdoRhtK2aLHc1D42gz+ounGYcA92gQHpTrGixFGbaj6sE7N7sxqSEpUERGRTXlsMSb8GI5rUXcKzjnykqXGFkEj/t3TxwBJtinCnXar74OvtsAZ5p324l6zU3MG9a4B10e+BH+yijBQuXPav65YGkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnA0TU1Xd3NVdlJ6WTFOb0RnZWRNRHNETC91alZyb04vSWg5b2w3WDRzd3pP?= =?utf-8?B?T3J4ZUV5V2JEQm4vdktFTmpybTdoRmtHcmtyMFUyZlVtY3pLOWxVaFh3Z2Rl?= =?utf-8?B?b0pxNDNiT2kyRWw4TldEMi9tdWwzZkduenkyc0tHRUczTEdLeEVyUUpWd1Nt?= =?utf-8?B?SXRlUWlXL2tkNTFEaFMxTThyWnRXNVpLTHB0cU5NWkkxZkJ0Zy9oV05PNmJG?= =?utf-8?B?anR1bDZJcEpDZzA5cXRPYndHeWl0NHBSRFJRNjNZNkk4cUlXNUd0blJVUytB?= =?utf-8?B?dVpSYkJrMnliYndkVk1va2pQdlM0QVpWbW5LN2E4bDVXdi9WNUh0SXNJSEp5?= =?utf-8?B?UERHNUNMSWVCR0Z0VXpaY1g4UDZxd3RsM3RPZzRia1BIUk1CcS90NjBlNTVv?= =?utf-8?B?MU5aUWlYVmtmRDV0eVNubG50cnMwNlBuN1lGNHFQOWgxZmF1T2pBN2NhbEJF?= =?utf-8?B?TVUzMGZVcEh5R2lUdzhWWnlGY1U5T2lqNkN0ZXJMVFRJNFFzdEZiRjZKOHBy?= =?utf-8?B?RU1YTUlIREMvSUp3SmFRT0hGOVVJOVFoVHNSSlN2U2RRSVJ3ak16YjFwSUJx?= =?utf-8?B?VW9NQUtkblhzaTJVMndkaXJpWFlPWjZYRitMTThFL2xHdkZqT05pdm1BeXNq?= =?utf-8?B?QllqczNXVHZWRUZDTXF4T3g3c24yQmFRSk1hSGdGbDVnbWF5Vkhuck81MTk0?= =?utf-8?B?Y3VGTDZxYkQyTjUrU3MxMlRra3FwN0RaMmJCQTBQNExrQzVPamFCdEZpRWc1?= =?utf-8?B?bUUxZWdPdEVRenVHV2VoMldrTXE0YWQvNUVOOXdUNkhuUDBsSURHRSs1VUM1?= =?utf-8?B?Qk5JSitpb0RaUld4V1QxWWlMM2FzSmlrNFdtM0llT1pNbS8xNTQyWE15Tlcx?= =?utf-8?B?bnMwZmZMTHdDWnUxbHB1T0dLajRFay9oQVlzWlpiSlk1RWZyMTEvdGRRUmVl?= =?utf-8?B?U1NKeUtqdnZoRDZJc1Vsak9IZy9EOWdaWGFvV0lCcHpoclVXeHEyZzQyY0tT?= =?utf-8?B?aFlSdStFNEV0VnovLzV5RWhpVjFZTFRFK2dwcnYyaXVYT0Y0WUkya2F1elpZ?= =?utf-8?B?VGlvRmJzMGVGN2pVR1lNTE85NUlpbHlxdTR2OUNZQjhyc1czUnVjQ3FXYlpI?= =?utf-8?B?ejZ5R2V5KzJkVWRKRVBZQkxGdkZMQmtEOU9JdDd6VXpaYUJuVnNia0NRSWZj?= =?utf-8?B?Tml1Uy9pQUZlNHN5L0w4aE0xbXNpblBqSkxQWXpyazlCSFRLRnhKYW1qaFVW?= =?utf-8?B?TGxOUWdlNGlGQ0NRL2EwRzhwZGVyK1dxZHc1em40bzM3ajZlNlVUcVhwYnBw?= =?utf-8?B?Rm5MK04zQ1pqZVlvTlFGQ2hWWThRTm1NNzNncE1iUXlEb3ErSUZ2VmVaVGlz?= =?utf-8?B?VitvVzJJRURFOGs5eG1TaEgyY1A3OE5uZXF1bHdPTWd0bUFNWitqbStHTGp3?= =?utf-8?B?anRNdnZ1V2RPQkVYZlFkbW5WOUtGUXphOWhRUXpZN2RlaDNpMjlycXhTS05C?= =?utf-8?B?K21PU25LL3RmZHpxb1V1ZGJzQWxob1RFWVB4dGZaNWo1eHBoTDVwWGcvZlFT?= =?utf-8?B?Zkd3TGg1YTZINEQrYmJkUGpvblNKdDFreWgxRWw3cGNYNDZFOUJOUFJKSGpX?= =?utf-8?B?Y3JPYzA0dDViWjdYYnU1NHpmVHNvajBEYkdKTk5MTm1JTUVabUMxVUcwOVp3?= =?utf-8?B?cDhORGc2M0MybWZ4cFRwZFh4bTVNbWFzK2NSSTBnSlFjMGpMcjdidU42dlR4?= =?utf-8?B?aE8zSXQyazV0bHVnTkZsWC8yNVBZUkJPQmFWTFdMNmtHMDVxY1Qzd1UwUGE5?= =?utf-8?B?dmNBQ1NTUXlkTXRvVy9SSnlkSkF3MDNydWY5WmxTR2RGdkRhelVrRU9ocGdv?= =?utf-8?B?T05vQ2F5VFU0K1ZTanFBelV3MytTdDFxR3dPVkJwM05IaW4vU1oxQzhXU0hU?= =?utf-8?B?ditldG4zV05YalJUMXZEUW56T2ZmUnZVK0Q4cWhUUisxRUQxQzJ0bFhBemUw?= =?utf-8?B?UFdZbmVvUHRsUUgwNFZVdmxQUE9HblZaUHplNkU3T2JLWGw2dTdneVZlSVVq?= =?utf-8?B?WGIwaG4rWStpejRkVVMrZWFnSllZRDhYeTZCOXRnQkwyQ2hRMXBKdnBxQ2FZ?= =?utf-8?B?MjlUK1VPSjg3Y2dhTDFKMWxWVitqZzh3eTluMjVmZjRUMUxiYzJjcUxDdTdF?= =?utf-8?B?M2JqUVFwelEzcXd5SFM2OHhtSWRFdUdnN01tdzBQTndnTWpVZUE0RmkvczZT?= =?utf-8?B?aWs5L0E2L2c1OHAwNFQvRFoxeXY3b0l6TXFjVmFPdVdPQnZycDh6MXp0dXB2?= =?utf-8?B?aWd6YTlQMm5pNzlwbjFtVkVRV082MWordkxXbkYrWVV6eWxiTGtoTENMN3g5?= =?utf-8?Q?MaxEsVH6NYls7woq9GDar05Lxins1kNc1of2F1MQanbVa?= X-MS-Exchange-AntiSpam-MessageData-1: qUqOoQC9/IlKsA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c48f6ec0-fbac-40b5-666e-08de7b512765 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 07:22:41.9511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +kgDindNBS9gJkQGrfsXFUu8s1abF7jlSBr82/BNo/hy8xisvrGKxpmfqsXdxehEjfez0xO4LswYAWk+mEjaHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7340 Add tests for continuation record splitting. They cover boundary conditions at the split points to make sure the right number of continuation records are made. They also check that the data concatenated is correct. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq/continuation.rs | 138 +++++++++++++++++++++= ++++ 1 file changed, 138 insertions(+) diff --git a/drivers/gpu/nova-core/gsp/cmdq/continuation.rs b/drivers/gpu/n= ova-core/gsp/cmdq/continuation.rs index 67b3e03fd8ea..2aa17caac2e0 100644 --- a/drivers/gpu/nova-core/gsp/cmdq/continuation.rs +++ b/drivers/gpu/nova-core/gsp/cmdq/continuation.rs @@ -161,3 +161,141 @@ fn init_variable_payload( dst.write_all(&self.payload) } } + +#[kunit_tests(nova_core_gsp_continuation)] +mod tests { + use super::*; + + use kernel::transmute::{ + AsBytes, + FromBytes, // + }; + + /// Non-zero-sized command header for testing. + #[repr(C)] + #[derive(Clone, Copy, Zeroable)] + struct TestHeader([u8; 64]); + + // SAFETY: `TestHeader` is a plain array of bytes for which all bit pa= tterns are valid. + unsafe impl FromBytes for TestHeader {} + + // SAFETY: `TestHeader` is a plain array of bytes for which all bit pa= tterns are valid. + unsafe impl AsBytes for TestHeader {} + + struct TestPayload { + data: KVVec, + } + + impl TestPayload { + fn generate_pattern(len: usize) -> Result> { + let mut data =3D KVVec::with_capacity(len, GFP_KERNEL)?; + for i in 0..len { + // Mix in higher bits so the pattern does not repeat every= 256 bytes. + data.push((i ^ (i >> 8)) as u8, GFP_KERNEL)?; + } + Ok(data) + } + + fn new(len: usize) -> Result { + Ok(Self { + data: Self::generate_pattern(len)?, + }) + } + } + + impl CommandToGsp for TestPayload { + const FUNCTION: MsgFunction =3D MsgFunction::Nop; + type Command =3D TestHeader; + type InitError =3D Infallible; + + fn init(&self) -> impl Init { + TestHeader::init_zeroed() + } + + fn variable_payload_len(&self) -> usize { + self.data.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(self.data.as_slice()) + } + } + + /// Maximum variable payload size that fits in the first command along= side the header. + const MAX_FIRST_PAYLOAD: usize =3D SplitState::::MAX_FIRS= T_PAYLOAD; + + fn read_payload(cmd: impl CommandToGsp) -> Result> { + let len =3D cmd.variable_payload_len(); + let mut buf =3D KVVec::from_elem(0u8, len, GFP_KERNEL)?; + let mut sbuf =3D SBufferIter::new_writer([buf.as_mut_slice(), &mut= []]); + cmd.init_variable_payload(&mut sbuf)?; + drop(sbuf); + Ok(buf) + } + + struct SplitTest { + payload_size: usize, + num_continuations: usize, + } + + fn check_split(t: SplitTest) -> Result { + let payload =3D TestPayload::new(t.payload_size)?; + let mut num_continuations =3D 0; + + let buf =3D match SplitState::new(payload)? { + SplitState::Single(cmd) =3D> read_payload(cmd)?, + SplitState::Split(cmd, mut continuations) =3D> { + let mut buf =3D read_payload(cmd)?; + assert!(size_of::() + buf.len() <=3D MAX_CMD_S= IZE); + + while let Some(cont) =3D continuations.next() { + let payload =3D read_payload(cont)?; + assert!(payload.len() <=3D MAX_CMD_SIZE); + buf.extend_from_slice(&payload, GFP_KERNEL)?; + num_continuations +=3D 1; + } + + buf + } + }; + + assert_eq!(num_continuations, t.num_continuations); + assert_eq!( + buf.as_slice(), + TestPayload::generate_pattern(t.payload_size)?.as_slice() + ); + Ok(()) + } + + #[test] + fn split_command() -> Result { + check_split(SplitTest { + payload_size: 0, + num_continuations: 0, + })?; + check_split(SplitTest { + payload_size: MAX_FIRST_PAYLOAD, + num_continuations: 0, + })?; + check_split(SplitTest { + payload_size: MAX_FIRST_PAYLOAD + 1, + num_continuations: 1, + })?; + check_split(SplitTest { + payload_size: MAX_FIRST_PAYLOAD + MAX_CMD_SIZE, + num_continuations: 1, + })?; + check_split(SplitTest { + payload_size: MAX_FIRST_PAYLOAD + MAX_CMD_SIZE + 1, + num_continuations: 2, + })?; + check_split(SplitTest { + payload_size: MAX_FIRST_PAYLOAD + MAX_CMD_SIZE * 3 + MAX_CMD_S= IZE / 2, + num_continuations: 4, + })?; + Ok(()) + } +} --=20 2.53.0