From nobody Thu Apr 9 18:45:34 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3DA3AE1AC for ; Fri, 6 Mar 2026 14:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807614; cv=none; b=W8umKzWLfD+6OPpsYxO58quYSNzxQ0a/Aw7eWMaFuSeqckhx+Ote2xUcyebMosoQXFazhIfcGM1VNMTuB3DNiRkuF/kjBBlC81HoobNF5+DoPBSpOcRMhPANEFDErfUSkDh77gq2XsCfCSC4LH00FcsbIfde3I6CHQC6vaOzMU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807614; c=relaxed/simple; bh=fqgV7d8c4BXshhw1gqL0HWfj9aw9iK9J0f1QWTNLAG8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WuZQaCTVb59e+1I5iW6LAiwv1+YyRAyPlbyA2yhQ0ETGtCQwUW83VsNWS4WXPul9hDCQ6xii+PpuKXaqSa9y+cO6nwerhUiammyDkj3kV76T5bczSOrAXrVJuLT4wjEG75nY/0PfNICgmanyaMWtexRsUEt2ClLcv1QduFWs5II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=86C9qTSB; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="86C9qTSB" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439b8a3f2bcso4454893f8f.3 for ; Fri, 06 Mar 2026 06:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807611; x=1773412411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G3vNgmqYmO5UknTO3x1kCPV7VqUspCxEKfK8SFuWCw4=; b=86C9qTSBOxKfG2vT8h98Npx9FZhWZYsroH/7Dw38suMcLOmY+kYC6w0nQQzWw5x3Pa 1b1MX7NUz5wEOMVhPa8NqhVZl0EGh9tb1zh3ZFnJm3N339PLSkX39NgrdRCu8FHz+1jc sTNg5AQveH0AXgCoebzjGZl6Zs5v/v3x4oA4lQYa20T4mKNCduhk07NnwI10Jz3yM/6v pcH2tIo0l+hARK3+J5we0ms7guRG7UvEnbbuCy6f2EKCdMqpRnf0dciSKoCAVVfzSg1X azKpNI+jFGPA7Ws4TTB3S5A4f0ClMM4xFBivxIDRTs4Ni3XpQWZpNML2Qh1HKmZYkqFU bwMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807611; x=1773412411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=G3vNgmqYmO5UknTO3x1kCPV7VqUspCxEKfK8SFuWCw4=; b=uRl0Y/0GgQiX2WNWii8Qc5cJ5eG95IRGeN1nB3y2JnVQjeIPWZiFCcBS9ihvHInZ87 x9Zo/T9TkukVL4TidSuYIcCel7C6VmxJ6KVw4NiYJOfAhlNHDmy00HERdSQhwPrl9oLW BPobsUjfOcFR2gx7V2FIZrcGzMg3JfksoISKti6zmphQuMzVLo+7I5yJLN3U0F4ptJXQ 7eHWj0CnKb+GUd330WKew2b3sMajHPhRJ2O9LLhs3psh9VChfz+gDizg5kH4r8g2fiQu CDSBqeAGvDNHXaxc2oTy3fhbkuVtXmd+SfhBMu1eJvkJWQEWmMc2iH+YORhPIB6H0FsS ZwRw== X-Forwarded-Encrypted: i=1; AJvYcCX3ARV2zNyNHkIbhRkOsuO5+PsvUsYViKKpvMkKLV0xVJhj+y7AjdgGbN6AeSVDwjMrQbcT/R+wdZqSkkM=@vger.kernel.org X-Gm-Message-State: AOJu0YywapPWv6M4pf4InuMd0bMb/Hxj6leGsdW1pEV9DQxDX32e11Ez u88Ay85hYPnugJiIcDTbIxN2BDPKXktTtrrObTezCGdKvfsLXXfuOvgX0g+CIzXvAalfln//R5Y 9Ywai X-Gm-Gg: ATEYQzwvy3S1G5kpUskmk2LZqsPuG3fSwj3Uneqmg76U4hROoLQ40TXVYaL+Dz/gWjR 4BrPTTeHTW99KgdW79k0FN6UmY4tT7nrzxVrOT6YhjTqXAxWXvDzpHlYx19D6IeDf5AcqZxjw6J LUfrTmAOKryLn9uXDNScfzr9Rj3pPWprTFltZYQ/UpFAVwbJZ8k6QwEwAY7WnhwqvANIr5loZ8Y WpPeDW4ClBpusSfmbBd+keK2nw+ENjDNx+xAtyXWwhRI/Q693UOBGj+663vzmknQWAg4+rvPYgj +g0m38zZbJw9QOSbDa5Du/zzvkgrYX+7W+wKWdITGYXGW5nVJS9IVnsuu9f/XdAVQ3UCBF3yOiA fwREi/epb1ZxWxnsQdahuCVdQwkZ8rAGTwJWp5UJNaFkJ4TTRZcMFUtrkhBRp/mH2RizOvURsCa 7RFxdpbI+MLcuFTuxqUsOP0qhb1Af+nJsFRwKb0TSO9i3HLZWOV3SMn/IfnR8VoQKWaOCoOEjZ9 cPp7g== X-Received: by 2002:a05:6000:1785:b0:439:af25:e4ea with SMTP id ffacd0b85a97d-439da66c26fmr4336958f8f.25.1772807611534; Fri, 06 Mar 2026 06:33:31 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:31 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:08 +0400 Subject: [PATCH v2 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-8-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2470; i=alchark@flipper.net; h=from:subject:message-id; bh=fqgV7d8c4BXshhw1gqL0HWfj9aw9iK9J0f1QWTNLAG8=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerrE+sdFtp9H3jRtXiPzfcbnQ3pfbz9Qqv8kdjLSo iY+8eYU5Y6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCm+hI7w//4xZlTLh4QOrJsF2vvTL2z3oti+w48/Ps03T/lQMxGnR2qjAwH/y8 X0zBNN3I747Xmq8qfHQXq0bvKmxcfKNubLP7pRBITAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index deb60a9bd222..951abd035fc5 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -64,8 +64,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -99,8 +101,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -471,14 +475,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0