From nobody Thu Apr 9 18:45:14 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A181B33B960 for ; Fri, 6 Mar 2026 14:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807612; cv=none; b=cFKMgvFe1JTT3KeQHfTZZHY0jnLkbEnt241SHEQQ5oZHK0UQEr/apTzRfGL2p1ZhTNfw2YP2R4bxGIncdNP6NusRmE2Dh7++DlkkrtPhUAMLhgSeBMVQFAdaj8Vw1NIxehmbUSlxraCWmBCzpO3MCEE+R0rws7P0crexy8oFMlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807612; c=relaxed/simple; bh=rZeSH+p/sWb94+YtWuBoX7zwjk1MlkPbjBLWjAkhzPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mcn+e/B8chpdDrDwnxYUDVm3JKrBgclbM9Wi/4xUHCn+eQ2ZcAcxVmyVRpfHf16dmkRRQ14G9i8F+DVbmtbukR1drzjDY7kKo7QsVGKzIHRbvp//I5CmkhDjjfUbGGuaZdUihVySGNFqyTIDfV6zhE8+QFCudBvkGFlXglOr+eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=EweMiyHU; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="EweMiyHU" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48329eb96a7so61550505e9.3 for ; Fri, 06 Mar 2026 06:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807609; x=1773412409; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I8FV20nY94XdgsSpk3nNKgaUktiutL3Fj9XNodWc9Os=; b=EweMiyHUqlgtoxy20WJ+dlyC8cMiOwddivymdEGCf6tD/xxzAgRM06PnJCTRGti1L0 DvW4y3ocSuI9+d/9RRr2IZds+u7CCR++RvvhggHJoRruYqVESDJt5WMmJcUlvPmZpdt9 XSEie3HniWPZ/yFd0ZoTjyJX/jx5yZkoK95PGzcLTo9jjn3wpwRM1aRq3adFhK+bCIpM fvrxAbG/ETbBIqUWrOPb/YKmyx0yh3kBd3rRysF9VmCij0bcIKmd4lxAD69fgZT8P2Z9 aHYjcf9N8c4EnubEysahCpi3WXPMia1qtXI5faXI+uSgc8+gnH08L+9JGhlZKPMaxgBD Ry4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807609; x=1773412409; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I8FV20nY94XdgsSpk3nNKgaUktiutL3Fj9XNodWc9Os=; b=dtx9bzMC0P5NjcjQkuqFRpzo4fd8t2k0vEA+mBz+XIVB7egNwyVAc3DV1xXG1Bsm6z 7w2aGEbPINDM/bUSY7OnWoLXnnHZEUikEtqFWjMHgXUJ7mrhWgjcFV52PmC5aLBav1Fu Q0pybh3u8D9I8lj9e05kJJCizxUv6m64Crg8cT4XD4//9XK0GKH8a6k2ROQGUYwUIvRg khWHkaCNCoO+/vHEhSirmnyTegW1fu9oRZY97d50NCdxDWosNldI4RIpGXEqAUSbcT1W eP0Timp6nMyOI2XncPu0XUuzhtAq2xFUwqcYKuazVnK6WXea7mrDj/HX2luAFUe5jBxY /UVg== X-Forwarded-Encrypted: i=1; AJvYcCUO1Lm4vjVxsqvlSXsIGdREFn+rhBf3u7fW92JMvlltgEBX0Ogk7E/KuRB28B+nc2kObUEijNxofaVZxl4=@vger.kernel.org X-Gm-Message-State: AOJu0YwDBkp+TD/535b7STMYbUKNcgtF5gnxLHD+6u/gEchNpAg9sbUY fHcb0+f1yi/YCiW4qvK98HlHIfKgFfLCuM9KE7Q2Ks9o4DQVMHgK/7eGgf0UjhedeY8SL/2LjCw Q3cmq X-Gm-Gg: ATEYQzxnwObzsFUN6seTQJiL7Y67r/+cvAy1563sYyjyH00xmsyFqXLehzAefoDpo37 otzr4FwLUu0JJxl1CV2BscCiDECcxIx54iFm8iJuPLOUjCx0RC3v6x5G1JnV3FLxPA1EW+/bHfU +k5/ChGvqjtw5Az9F12tI+WOKNo5FF9cOdGh5uySCBRNjNt4Cuh9wCD8x2avoPBvGXyBkLe9+SC wH7KP8WbFwhuQzWhp89SXKf8N0O/29fl/Lbk0ZPOQc3DDJd3cG+yNlh3Rq4LgR8KOdqpM9TWb6F BuHvO51eqTVlOEYbCEUgYEwtbM78/yIn5X0kLFFZv9txESVrhEL0LKb9jEY0FpRttMmNVOyo4u3 HxQcnigvop/G9sq9YmxIQdI65OiHvMVwMAQO2mMHTC3OvQSLGK7H1FrV7MtQo125oGSrT6X7AkK ko0QasS6XJfD4tOjj/CaiZ8sTXBigszIIgxUwpZY9DDjtWCvu/3sa2QzX+EiyRYh94zifB+w8H1 wjXtl1U6qqvY7ES X-Received: by 2002:a05:600c:3596:b0:483:6f37:1b51 with SMTP id 5b1f17b1804b1-4852697955fmr34852995e9.23.1772807608970; Fri, 06 Mar 2026 06:33:28 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:28 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:07 +0400 Subject: [PATCH v2 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-7-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3364; i=alchark@flipper.net; h=from:subject:message-id; bh=rZeSH+p/sWb94+YtWuBoX7zwjk1MlkPbjBLWjAkhzPY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerqkvnqiT8+3o1lGnJ6+pseXrQtbEfuxb0n2fe6/l S8sK9O3dExkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDVKZ8ZGWbal1zZket5rlD8nmCb+NMpAdHSdU9eCk+YHR+g8jKtiI3hf/7UMw0 PA/9WlbM6JSx4vmg7b9/mhi+rZa+uy3oV/ebHHy4A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index e14dd16f9d08..deb60a9bd222 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -30,9 +30,15 @@ struct bq257xx_chip_info { int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -489,22 +495,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -632,9 +638,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0