From nobody Thu Apr 9 18:45:34 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E99B33B960 for ; Fri, 6 Mar 2026 14:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; cv=none; b=IxZxdZ75gLLoKreXzbH3VYJ/YxlI9z0dIsqSCkpgaHkO1PJQ6FG2kj1+57byxfXoVGQcJNapVP36BH+CUV5IZj19noJiLwx/aYq0BJC0bOYi2M5qv3Dky26YQMByG4wQkHNHWV6k5S2y6AOslddjpFOGnJPK78Rv0pnaUfPSj10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; c=relaxed/simple; bh=Q9D7eBKxq86MNvlgm1qDMnqHysA/422W4yV9eBroyC4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aZBC3qESTrbhi9E8K8mO64Fky7VE4EEKscIg1p7laYvbAvikADjcKkOP9oA078u3EmMmfdlLvDrcgqqgky7b7yt2HUO+dQn4Amq+3Bnr+QiRxS3UQxerVnkEA7PRDN7gi/HCIC74L0jns8iepYSW1an1dpm7/CGJtpYpP/ysEOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=hb07hmKV; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="hb07hmKV" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439c4bde55cso2454123f8f.1 for ; Fri, 06 Mar 2026 06:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807604; x=1773412404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Sz4biLahYPKsT9J1ufLdEia90vJM1vdO3bq5iy8XGEM=; b=hb07hmKVFklaYksufnqvG4Dtv82VpVtF284kZVDLekZ0Hlo9DqXt9fT5waLAqEe6zW EsaajfcccqaDX+qHghQidCN5OYGIpkR+TZNcbOR4iUu+TGflTsANcqu3O6OHBX8atPBa rjxLvfDX1kH+jpaguxpa0ezpG83xwZB2LUE+gV0tV4/Q80I7LBHExvu/9E/HHHM7oBEJ jXHBg1chLmBy5KRpTveuGfmJlhTvYO9gPZyXAyDVTnk1cs+qxwJeDCPNkPtz/jImCadY 83PvoEm3N6Loi8P0aMss9ElA9l3ZRE9uIY5FF3BFaXq4IJtj9tpmoz/vIZGdTMYLGDsf vKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807604; x=1773412404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Sz4biLahYPKsT9J1ufLdEia90vJM1vdO3bq5iy8XGEM=; b=qs9YjraAv+AhWyIh+hFRhdME7xUfBQft3SIo0aVOMGmbugjQ32Z9ce9ICKkm0xCkV7 CloElK3pM/8uA3pWqrC0adGYnSk2Xp9gTLVG1SxfV47Zn9eHyu2+93aAMt5Ylmg92RyC odS7pCtLfRfxiGGyBoP7rENWydJNzofubz5EE2+6b9uatPd5tDRu3q4CM6p1a2IOrmzM quPrYmziSZZuLsPXHnxCB8qyOn8PvII/0GORO3Hs29DOko7k+RcTo+opL8VhGpTM8DsK Jmue9RRHbEuCNH3P3KmPWA4iuNcKIiMnwiPvdhH+tKoyFBkN5GPHXq+pImPRKy++I/6P j2BA== X-Forwarded-Encrypted: i=1; AJvYcCXg/gM1DXy9GohTZb35dI8r0eD1Qg2htElhkOqiqkozG9+1W8upyrt/4HDQy4j9SNGEc8HppoundZPmr0U=@vger.kernel.org X-Gm-Message-State: AOJu0Yxcno/yV6W3/WT2uMIRt+uCCQjBARLgIULkZ4BhWiSix7gGvH3r sAqCCKEpsWuD/Ad28Z/VBhT3+H7NkVC6L9wUDJrkCN9DZiPkk0mjn+LcuIM/Xh/fB84= X-Gm-Gg: ATEYQzz5WWSfKV0UQou4nsOY6VOPAFShXKv8bM4ML9h3Y/l/xdK6KteIWFzX+yOyZZg iP9MUtQQ0QUJOfrF4usTP83zwFWBy7Exr13/aRhGMN5fdU35oM8tACjI+qCrpeCJUQ1mMOZDZXf /wSGK/UmNT8uLJW+jHFcr/yZgp9Sf9LSwYijkv2j9/gCkCZQv5sxAWU52YNmgXJhNbHLGSFClO2 mC1UB8vWD9kt/0PhzFx8fAlF6S10vfwgoycNrMRl5l3SvuSbwP9Pyd7wJlWtw4dV1isXTev+F1i B9rGXMJ1fUoFKAivUxy7VdYzvC82NSZO30KwMTuksnNdPDESnnQJGSGQRupxzWdiSQsb4/NiAC0 sB4EX0UjM7t9geF+wEE6bzmTK0d4wyGZVv+R7Sx7AH+PKhuiTkHjV0fSNu/dUTO8cV2BAByaJbF rHr6dIYPrAQo1mlbGObv5mVVH2H+Djc/dCm52xZuPHvErdr/9UWHSXuZLMn+WTjzocXQava53WI 8U3nVU65U7P/tGg X-Received: by 2002:a05:6000:1843:b0:439:c9b2:6571 with SMTP id ffacd0b85a97d-439da3697a9mr4240301f8f.41.1772807603922; Fri, 06 Mar 2026 06:33:23 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:23 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:05 +0400 Subject: [PATCH v2 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-5-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1911; i=alchark@flipper.net; h=from:subject:message-id; bh=Q9D7eBKxq86MNvlgm1qDMnqHysA/422W4yV9eBroyC4=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerpE+vDa17tWlximfOM7VrhvSUAK8zyHheyO53Xnl rdY82/w65jIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQ2RKSBAQhYGPhyE/NKjXSM9Ey1DfUM DXWMdYwYuDgFYKp7PzP8M//80iNKkmFiwPTSVjahl+VfuOfK3/8m9Om+59sddeppiQx/BQWXTFr woJp39uYHy4J1nTRuVzd86xO5b8EnXVLct+AWGwA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0