From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AEC634CFBA for ; Fri, 6 Mar 2026 14:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807596; cv=none; b=Z6RQXFUMctk1szmR+rlvQ9HRvGFYTdz3FggF/A6JFUpEn6SULYJ6c3ROtdBTbO4theZt6kQggBicL+nq1w58MtL+d2Szu4rUR3+7+tnDUx3nTeX29pXTxxqO8RFDZ845YuMTioVUKQdV4+BpuznHTKyf1yWLCx02ahV+judk1RQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807596; c=relaxed/simple; bh=58YP2dJRgAizAOikYaKjM/irmjn+e7RczszyYkhkS9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KMJqpiQUP4FrmxFwewwE/5CvqXmgX6ZojPIA9Tdx8NQJgvbbfoVpuNGzLSfYGoyJX1vKAPkNnKA2zavPSLiVgPhshTr7ChHj1OHMc5L8BUgLVDvrhe6OUYQ9BCfl+n7hftBTt63T1rntopXuUcC5Sj3chTBC5Xay8LsrFBeBmTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=g0gDN96p; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="g0gDN96p" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439a89b6fd0so5965210f8f.2 for ; Fri, 06 Mar 2026 06:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807594; x=1773412394; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jt/bQE8Be9/7vIBUKX4+9xpaDCMMIJNvl2zw+VOvhnY=; b=g0gDN96pc3H1b+eveNBdoH6ko0Exh0Vn1npPf9W4gp+ELRvpKg6pIMmGbUc3X7JjZ8 PUd9CFrCsL2D1BdjI1KvnlMSaePMUeGq1h4VWXXuWS7k+W6c1B6gSXNySjZEZBGOAjtN ZRaxYSybu3V/nf2NqC3/O3uR74HVGqRKh/uNF8ZjuhTBVOwZlj0s5fOifyAv/grLiP1D g0D3C4bqtQ3foTm9H0egWAXzxdqIrNv9VuUDrgLKezHTeyErzrxjmejTLB1cO3McGrn2 CPWA9eun6iXBDRp7dmwuoHrb3zmbf8UMaysk381gur0JR7O2k+fSOm6fteSdMo2BdNA5 ZDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807594; x=1773412394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jt/bQE8Be9/7vIBUKX4+9xpaDCMMIJNvl2zw+VOvhnY=; b=L1qPHUvllEqb68qfi65ssyFHFEFJsnJQH4EUPGzBVVQlh9xPuEoIJ0bg72vzv49IXC o/c8ICXIxN/21j/XIObg1jUybftVDsd+ltZicNLzxPbDStpSARLYRGac+WzbmzKkNYG3 VJpEOU7MXmJMT3w/qfmQY7qx0ZZUo6qIEkuk24T8NktwwHS430Wb1y5I+FDgdaB5rp1D XqvN0fLk2UbkEFn8DAuminlXtJQLqDwehiap7fzLcXpLwBlNLMuYk0hlwxK7kb7/Ekx9 ldggDIADzCmM7jNNMvPhrSOG2p/i82zHp0w1ujNkxt/N5YBQmmXbRrM5sIq81TVHhy7F Q1+g== X-Forwarded-Encrypted: i=1; AJvYcCX3TxXeOShh2VMhqwItoaSUpq0kiEG627tJ1wFzs1QlpGf9zmmTuUP/y0LKa6KCrY7ScZ1ycS4acg767bA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkg5gudJX3Xs40f60sZm83986XwPJRiAR12rIxBXQEjOTYfJhE etIX1nhiK+jn03T+887x5WZvwBQCLCuO0N3MNOh1NpvSfjCXhJSccu2nD6M6u8RV6f0= X-Gm-Gg: ATEYQzzGi19XDlM3ppl4UxWyYwI3fLhC2eAjfjaqxskjtK/vAGaLTb18V4nzVwX4DFr AXt6Haz35Om7KzNXL4t3iLIgyktXLkpsuSTmE6tjcYc9+IWNGc76HuOWJC1pYSFS3ocJzoH9zri 8O38B4LRO/31dZ79B3F5/kGTk6nvAQc+8SCMoYWHoHBblCrO0tnRUsVuHmw8mhfjtg1zA9GqIi5 I8skbGU5bIUHTXxD8zO7SXZ64su/3+Z0xVYJPXTFVkvo+EG6CZYPbDH9e0ti8CG5ScXQxSY7WLe JE1YueZZPRIXD8UXgTDrYZSow+rRBbvtpcuJW6INbtGQx9saxBbRTvc3XEUpTb+eOAzff8NiRbr h6NgcL6VM4r7cu63hE+Y7I/wWMvUGLM6vKJkedob/dmW+6dQP5ObmokrZJv7t687O1AZmaI8Phu MmdSCaTYzFe0oubHFYPJGoK4rVJQTu4+fooLkh0WMsX7Y51VuPW8URFlwRdhRfzcXd6DNIroiY3 CtxgA== X-Received: by 2002:a5d:5c8a:0:b0:439:ac98:751f with SMTP id ffacd0b85a97d-439da65764cmr4107142f8f.23.1772807593609; Fri, 06 Mar 2026 06:33:13 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:13 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:01 +0400 Subject: [PATCH v2 01/11] dt-bindings: mfd: ti,bq25703a: Expand to include BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-1-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3798; i=alchark@flipper.net; h=from:subject:message-id; bh=58YP2dJRgAizAOikYaKjM/irmjn+e7RczszyYkhkS9E=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuero4VYovWf7P7kmhP2IWiaW2vvps0vCwm6f82eKKQ uYkqcovHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEx1gh4jw8TnCx92iPPs9ZaZef5tCBtXYwDT1NpztxyXhjwN7E47MZORYZNpoNW 7XAFNk9Uypct+i9/+PH39h5uaF5pM1rzivmLBzgcA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 TI BQ25792 is similar in operation to BQ25703A, but has a different register layout and different current/voltage capabilities. Expand the existing BQ25703A binding to include BQ25792, and move the voltage and current limits into per-variant conditional statements. Signed-off-by: Alexey Charkov Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/mfd/ti,bq25703a.yaml | 73 ++++++++++++++++++= +--- 1 file changed, 63 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml b/Docum= entation/devicetree/bindings/mfd/ti,bq25703a.yaml index ba14663c9266..cdce83f05804 100644 --- a/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml @@ -4,17 +4,16 @@ $id: http://devicetree.org/schemas/mfd/ti,bq25703a.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: BQ25703A Charger Manager/Buck/Boost Converter +title: BQ257xx Charger Manager/Buck/Boost Converter =20 maintainers: - Chris Morgan =20 -allOf: - - $ref: /schemas/power/supply/power-supply.yaml# - properties: compatible: - const: ti,bq25703a + enum: + - ti,bq25703a + - ti,bq25792 =20 reg: const: 0x6b @@ -25,7 +24,6 @@ properties: powering the device. minimum: 50000 maximum: 6400000 - default: 3250000 =20 interrupts: maxItems: 1 @@ -57,11 +55,11 @@ properties: minimum: 0 maximum: 6350000 regulator-min-microvolt: - minimum: 4480000 - maximum: 20800000 + minimum: 2800000 + maximum: 22000000 regulator-max-microvolt: - minimum: 4480000 - maximum: 20800000 + minimum: 2800000 + maximum: 22000000 enable-gpios: description: The BQ25703 may require both a register write and a GPIO @@ -74,6 +72,61 @@ properties: - regulator-min-microvolt - regulator-max-microvolt =20 +allOf: + - $ref: /schemas/power/supply/power-supply.yaml# + - if: + properties: + compatible: + const: ti,bq25703a + then: + properties: + input-current-limit-microamp: + minimum: 50000 + maximum: 6400000 + default: 3250000 + regulators: + properties: + vbus: + properties: + regulator-min-microamp: + minimum: 0 + maximum: 6350000 + regulator-max-microamp: + minimum: 0 + maximum: 6350000 + regulator-min-microvolt: + minimum: 4480000 + maximum: 20800000 + regulator-max-microvolt: + minimum: 4480000 + maximum: 20800000 + - if: + properties: + compatible: + const: ti,bq25792 + then: + properties: + input-current-limit-microamp: + minimum: 100000 + maximum: 3300000 + default: 3000000 + regulators: + properties: + vbus: + properties: + regulator-min-microamp: + minimum: 0 + maximum: 3320000 + regulator-max-microamp: + minimum: 0 + maximum: 3320000 + regulator-min-microvolt: + minimum: 2800000 + maximum: 22000000 + regulator-max-microvolt: + minimum: 2800000 + maximum: 22000000 + unevaluatedProperties: false =20 required: --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3AFA34A76B for ; Fri, 6 Mar 2026 14:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; cv=none; b=a42/zCqbWdSe4fxd+IxBN+1SWlnNUqEexMz6grtODnlgaTME5kIZI4Dw/UuB262hN+vJgPaug46mlIlcOqvGIlrA6izEU8r34OjKMXjJV/ez5lamGqvLVvmtZ1HLsLO3KlACBwtpDksKWCj2MT312twkZb1axBhnyCwAz76Gkjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; c=relaxed/simple; bh=6WH6bA59l7A4239NaRyToL++eIBKP9VFtNt1SDkD3qc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kWIfpaEcidDPcJ76IRok2/+Y75tZDg/Mkume+jT312w+N0t/+IpdV1IAUABhAeM+iALyhqbIB1rQLwI54cAZXTM4Jiw22hxnuybJVneGanQy9BNc1vzVQSCT/v1HERizyGvdjaZueT2+QRprMkO3DqQeRh9Ah3u1gYri6MKuMys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=37oNFRs0; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="37oNFRs0" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439b7c2788dso4095495f8f.1 for ; Fri, 06 Mar 2026 06:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807602; x=1773412402; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Kv9yW7nD0xBquE/Q0Gt4SkecfyIoKpDK3EsDR/0rlXU=; b=37oNFRs0D4LPmJrJGNv8a4ymZXAsfdUyefr97juF5pdrCsadzKA1ry7xBCmQXwqL8O x67gND6cN6FPyC5YnxVka+9RKixb4bGRnwDRdY59ceBTRYpRakONEuevm8poGqgKwuTL YIpq7tCPubDqeazOWeXZbTm1C/pQpCSX9MkgNKpp+2o8G80+iSedySqaYw8I93D5KxjB kcypsoEyaUeipBHXUG4PTEU82tAbCTlbREZBIU48vjTAfOIZa2w0eetWo7mGu9XXLp2q FJoDoIBoJNIaKjcnUDg5+8u+t2AE/CuVj5BlTg5cO5XpABwDqqeL0C6WpojhSgjkCiIi LwHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807602; x=1773412402; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Kv9yW7nD0xBquE/Q0Gt4SkecfyIoKpDK3EsDR/0rlXU=; b=JCQQOW/kKNOYeEzB9tqeXbB+LHBEX+plNLT4xvNzVBztiJuG9UckaIfVk0FJUfupcv U8/4VycuJSmiYG3Orfqo2NhcDVN/YWn0mf0zWWrDry+UeFyLLkOTuI0BH9aLbaw4UnOf 20beFkC/A2HEux5/sEdUOK5F1vPfC0LTohJCSsITWQDjvWuL59uJCPT/zOAre/3ABe75 aNHuJIUkfxMidfTG6oe3bjOt23yZsUnr0jW90qCxFK7up+KixyX2R6J4FNwfFlmSqANV 4/jXvL27Bs+xxQ7OGSUOj1Me6ITrEHH5jacEz1rGc77oFJfsBS9Xz1tRjDJwkvThq9Gf JV5g== X-Forwarded-Encrypted: i=1; AJvYcCV2542LjpvvBBQ74591Une1ZfL+2Ptz7JbnfdPg0p7I1PUmTa3nGrOuS7PbwuXS/AqR79r+2Zl89YzUIa8=@vger.kernel.org X-Gm-Message-State: AOJu0YzWGsRkyCOTiSqhiVpJLYTAGKX7o7+qtPje3mE6PHKXx3lCBXug hMcW1AVQPIWf4Q/9pNhFxef+s3gBQP7KQ3fnWHDRr/Y9BUH7ts5zuLKaKDDGUyudE1U= X-Gm-Gg: ATEYQzw8u17IXvqh/TyUlYYgTVOczGAEYBXQREp6eyurMpkODwKdPNC0S4TccoQuUuI RIaaoih6rluF65mRAJGapUSwiMpVhb8WCMEAw8RVryZVH3FpHJqmVMYI01nNHZKcm7LrgBbXtgJ IApn2rMZOA+IHaSmtT+kQ6D/St+bhDfMbvaQGZ/c3GFd1toahR6Sz+Wf3+NKULNI+totqj9/kpe fPj7lLMTVI1Ug3mmIDdRHp2u8qifFLFaGn7w/d7F3wFUSXUxOFFoK5ljip8ThSn/86HqYMy6/R5 WxNUc0D9r+TpkTiDimECoP1R4/HqxxSES66HntjW3VVKGFxQops6oPymkMbOoYYGL3zwgyJPxOY SjVsLAal1xrxqI/U2EryyxV3aVuOdM5Fl8U81ecAGzSIvyFxLDVlrU/99h/pjIvT9n3FDkJjbc5 i8IBrg6mrxyHMrQbE+oRk6z0DdlJoapbqj2jqQVS8+ombASEp3VlsmGRLpgqVSKtDzAqe8h8I3l 6M19g== X-Received: by 2002:a05:6000:40cb:b0:439:bdba:56c9 with SMTP id ffacd0b85a97d-439da348351mr4423578f8f.2.1772807596136; Fri, 06 Mar 2026 06:33:16 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:15 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:02 +0400 Subject: [PATCH v2 02/11] regulator: bq257xx: Remove reference to the parent MFD's dev Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-2-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2662; i=alchark@flipper.net; h=from:subject:message-id; bh=6WH6bA59l7A4239NaRyToL++eIBKP9VFtNt1SDkD3qc=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerrk2pUZe+4+m/S6YP9il6Wvi++qaNTKLlLrObCil uXfkkezzTsmsjCIcTFYiimyzP22xHaqEd+sXR4eX2HmsDKBDJEWaWAAAhYGvtzEvFIjHSM9U21D PUNDHWMdIwYuTgGY6oWeDP9TOZP37T4m5vS8PoZ34S5Pn3ruM5t4jxfEnOYwrrbj++7IyHDhfZ0 Wa/vl35MdeYxCO+dOmbdR0+72W5XVnRN8N+xZY8MIAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Drop the ->bq field from the platform data of the bq257xx regulator driver, which was only used to get the regmap of the parent MFD device, and use the regmap from the regulator_dev instead, slimming down the code a bit. Signed-off-by: Alexey Charkov Acked-by: Mark Brown --- drivers/regulator/bq257xx-regulator.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index dab8f1ab4450..812938e565e3 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -15,7 +15,6 @@ #include =20 struct bq257xx_reg_data { - struct bq257xx_device *bq; struct regulator_dev *bq257xx_reg; struct gpio_desc *otg_en_gpio; struct regulator_desc desc; @@ -23,11 +22,11 @@ struct bq257xx_reg_data { =20 static int bq25703_vbus_get_cur_limit(struct regulator_dev *rdev) { - struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); + struct regmap *regmap =3D rdev_get_regmap(rdev); int ret; unsigned int reg; =20 - ret =3D regmap_read(pdata->bq->regmap, BQ25703_OTG_CURRENT, ®); + ret =3D regmap_read(regmap, BQ25703_OTG_CURRENT, ®); if (ret) return ret; return FIELD_GET(BQ25703_OTG_CUR_MASK, reg) * BQ25703_OTG_CUR_STEP_UA; @@ -40,7 +39,7 @@ static int bq25703_vbus_get_cur_limit(struct regulator_de= v *rdev) static int bq25703_vbus_set_cur_limit(struct regulator_dev *rdev, int min_uA, int max_uA) { - struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); + struct regmap *regmap =3D rdev_get_regmap(rdev); unsigned int reg; =20 if ((min_uA > BQ25703_OTG_CUR_MAX_UA) || (max_uA < 0)) @@ -52,7 +51,7 @@ static int bq25703_vbus_set_cur_limit(struct regulator_de= v *rdev, if ((reg * BQ25703_OTG_CUR_STEP_UA) < min_uA) return -EINVAL; =20 - return regmap_write(pdata->bq->regmap, BQ25703_OTG_CURRENT, + return regmap_write(regmap, BQ25703_OTG_CURRENT, FIELD_PREP(BQ25703_OTG_CUR_MASK, reg)); } =20 @@ -137,7 +136,6 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_d= evice *pdev) static int bq257xx_regulator_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct bq257xx_device *bq =3D dev_get_drvdata(pdev->dev.parent); struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; @@ -149,7 +147,6 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) if (!pdata) return -ENOMEM; =20 - pdata->bq =3D bq; pdata->desc =3D bq25703_vbus_desc; =20 platform_set_drvdata(pdev, pdata); --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EA6232FA32 for ; Fri, 6 Mar 2026 14:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807605; cv=none; b=R1Fjts9Z8M6DxcSCZjMrkaSZNQJfWyFNzBmtwBKIzyOW8B0Jt+mSeA0PhY0D3gi+TMeZeBQz8YJvnxkLK5ULOGRUYPZx5mPqr/PzDU66YOLHd4F+USFPbCQi46lpuuH2xwNUGYTN/Drrf5qULBL4AOygRSFZEasdKJ1t6lKfS4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807605; c=relaxed/simple; bh=ZNpu1+QLWxDyG8uNZKHnXwGDlRkKFAgQ4JrcxwH4TZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mEEo+FeVYIfWk6znhRvwdrLfBRfkSmSZ6Ht4d8jnGQt32SCMIG14dtZ9zPqP2RgAz69PFvywF4ce3UlhXHb5jhYFWHpMzdfAdcqdDVmXMUMr0zQbGAfCxI878z8ZyKZxUKuQFfvFcxbQe9xxfoinTg8RXd/qI5P2ac2HVGbrZd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=XeR8uPVv; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="XeR8uPVv" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-439b6d9c981so4050912f8f.1 for ; Fri, 06 Mar 2026 06:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807599; x=1773412399; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eLnt0eflN8lFiwNCVheUlKB9RjgppzFmTMI48rlcPq0=; b=XeR8uPVvbnJMhtWITWm03vozrI7SkQtFNZ2eNVfCo0NfkLfXAmfowpDuP8Cl1pJcB/ ch59W871oaddf6D6/mbPyxNE/S/MnUbCIcMjgIes69D2SnaXTdI5E/qPkbj+QHS0UEL9 dTvjjbornjD56ALCOE7UWRH+Y50wUyXAM7W8O1rg6eB0QYe+zhPhVumOwdqJL9wkpix+ SqdBE1gVuZKCpRMhsJxrfRGejcdjCF4Em1fENa7sxJZbrMGbNYbHa2JuNo3vA8x16DS9 /Obwy62O9h+sh65aOKew/52LyGEtuE9oIz/YEelkBy7oP8N0jqmdHtlVa6LZsqZk4UBq +qtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807599; x=1773412399; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eLnt0eflN8lFiwNCVheUlKB9RjgppzFmTMI48rlcPq0=; b=OzEE7L3k4PWei+lAcmcfK/rqiRqwpZDIn1A0KQdpgCwcP3X7pVxySXNiPeNJTkZ6uk 2U8nh2iY82VK85HIzM98zAq2UukID+lc2hrzDhPpbfXk9FhQIHtUStWBdR2v9Pgrifyo WbqywRw4JXXsZl+y7tzz0Ta8wfGfXdt8DYRjlM0KTrkUZ6CBu01FAyqPvhQL3Dke0+pY iV1pxXb6bQjigNawwoNzL88y3P7BqYL6mG5NwrldAxOOndGttnuhgiI3GX1mUDEhA9vP xHTx0vTJOEZnwYDOh48Gfua3olqb/KUlLsUx3jEnwWkbsOx8rw3egW8qSYg5LSCGRcn4 tKIQ== X-Forwarded-Encrypted: i=1; AJvYcCUA479po6QGxGr2v9nr6dRMUXDr0QHIC4GKFeCtOTkWitSP2A3jPGu0OujOJIp9jM9TXXIWGEQ1T2Bhrzw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx30L6a9PFMf4O6O6JfGD76VcPZpJG8e+bQU7DA3FWjbwDGfd3X axp9fcTIu8+PlnfgWEunCiAFcwfqok+7HU2FNE7WEX8NzJDKeD4MKja016Ga4s9cbCqruNEQEg5 vIYQk X-Gm-Gg: ATEYQzx0BOmgTXUVlImQcMFEVXPIvijZDtL7AK7cVNCkOIv2yyenpE0o8FIvLI8gmZS ZMnFBvSk+1gHFCczO2eR7N4A7023fLrSj8XurMC4BdplOKOvaJM83ai0AxXl9B2I/guocUk4tJ3 GuKMyumHyuANVmDD8Ny9fwbVb43FM3PngVCpsBFWMEV5f8KCJterdvDxAXEdV7vt6jLH0vMzKu1 qI8hoJ430tTQ/Dy3Z90OXA6tc4VMFfMUuErWzBioIlnfLQiSX4N/Fs2AqmAnEkCi3o0m59wBzg1 heKtny/yFHH6qPGbEiu1es6VfndO9TxCFMFaM6KnfAMJS5ApXTU/RO/kcijthc2ZpgWKvvviqMK Tg4WjGuEdk+cZSrWYlg/KSnwATaGcipboaxMKnPIxuy2OS3IIMO/dV7bN1GfqJeufLjw8LqCi5Z G86+8FwKmPoJ/+rslGiult/PvHk1zrvvUJrsrAVM6T2FHmVLu74jA8davZCC4/waiAnjWch3aug Fj1Kw== X-Received: by 2002:a05:6000:4283:b0:439:8d39:47c7 with SMTP id ffacd0b85a97d-439da363f77mr4106618f8f.18.1772807598732; Fri, 06 Mar 2026 06:33:18 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:18 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:03 +0400 Subject: [PATCH v2 03/11] regulator: bq257xx: Drop the regulator_dev from the driver data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-3-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1549; i=alchark@flipper.net; h=from:subject:message-id; bh=ZNpu1+QLWxDyG8uNZKHnXwGDlRkKFAgQ4JrcxwH4TZY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerrk2a0quZy/T1pDi8oaJV+KHri+t/H+khVOHcm/J /XrNNdldUxkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDV6+QY/tdJCl5/8/1m3NmPxu58s/V/20mtf15+t8NCn3kVm+FUz0iG/zk/9n9 b5fvtVlR7C4/DyQkXDUwaWBhMTyv++cr9cGV0CDcA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The field was not used anywhere in the driver, so just drop it. This helps further slim down the platform data structure. Signed-off-by: Alexey Charkov Acked-by: Mark Brown --- drivers/regulator/bq257xx-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 812938e565e3..674dae6109e9 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -15,7 +15,6 @@ #include =20 struct bq257xx_reg_data { - struct regulator_dev *bq257xx_reg; struct gpio_desc *otg_en_gpio; struct regulator_desc desc; }; @@ -139,6 +138,7 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; + struct regulator_dev *rdev; =20 pdev->dev.of_node =3D pdev->dev.parent->of_node; pdev->dev.of_node_reused =3D true; @@ -159,9 +159,9 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) if (!cfg.regmap) return -ENODEV; =20 - pdata->bq257xx_reg =3D devm_regulator_register(dev, &pdata->desc, &cfg); - if (IS_ERR(pdata->bq257xx_reg)) { - return dev_err_probe(&pdev->dev, PTR_ERR(pdata->bq257xx_reg), + rdev =3D devm_regulator_register(dev, &pdata->desc, &cfg); + if (IS_ERR(rdev)) { + return dev_err_probe(&pdev->dev, PTR_ERR(rdev), "error registering bq257xx regulator"); } =20 --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DAE632D0D4 for ; Fri, 6 Mar 2026 14:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; cv=none; b=ezbgaHBb5EVVCQoSH8e/QznWJoukg4m6xg7q4/5YhcnqN+7i73/Xtg6LE9INZBkjf2xZcSB3VgYqtQBhxwUx78G31UInybWgrAi5YUkpyjgOqzYCQ3l5eC9airMfi8hzfduwUiIPopoMIJ6BBjb/XaWuVkBsUKBi9B08zDSRn6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; c=relaxed/simple; bh=boG9G+5QbeBW6aT+kko42e7K1ue9tm4B0o/XFrV9C0g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qZVIqrOr58K0dl57lVVCBLUI7FrtoDVYfrgMjvj4Uz1VzgUE9s2XMyaq5+PF6jJt1JN0lUScOyexN51iCDMoIcv7RBwTRnHrCRqnhyeg6/IF5RbQOHGTaXeMY8bWhl6i8Usj2EyLZwFTP1Ulkcfh/v19gQHyMZhqRRUCCLl1VJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=j6+s443b; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="j6+s443b" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-439d8df7620so599855f8f.0 for ; Fri, 06 Mar 2026 06:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807604; x=1773412404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ewnwkW8aeBnRH/Jc82nMn2tCnapdMhZRN1gE49Tbo+w=; b=j6+s443bFUnUnl0epPGVasH5aXpnVxRxEr16D30upeoC09evg6khxx2iihzAf4+a6l YgmC+dolfsKx1eC3hCPxa+We65MKZgDTnOB/pZ/hcfN2BFFuC0+eGMAZ9mdhyZeNWyqs CsZEiI1KptKidpPcAsSM1mvLWCWu/dGsI/wSSs2pS8ocvtZFFtWxAiMv5POEWqHcXrHp oXlzNVkyERMe4gzfFyggbf7PEIdKFFbZTO5XrpvrNl+wegmjUuNprCBkfSYVVc1PfbfC 0I3sfc2TSfRcVYdypZrsOd2utSB3SbDnrS7CKdpFVp2Sw5Vyd73bwsbd+dGJjLi3yrtj lyYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807604; x=1773412404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ewnwkW8aeBnRH/Jc82nMn2tCnapdMhZRN1gE49Tbo+w=; b=XW0cMjc9PHmsEXuwpRcJPy4irRbvgL92YJBSHIW3UeM5aNo8VWQ3y3h9lqcT666ODn SwD3qaenZaUoczLlKqkmIAZyPQu8sUS1E2nmv7Kt6NiSVkrjXgE1WtXM3XH5cdnEm4iO 0/lux5Z3wAwhcOBHtB68s509CtVINwOgUX317PVohHpG7zsbH4rhHKH9nZsCHnv+IiF7 iDuYD6KNSUuXmpMug8ojuSoYNZxQ/N6uCXuvMTyEou8jCfN4km+wrz5CLuQfcvrdc+O2 Dfp3xuqVSq2zyZas+cnO4bRZv0qFtiYDLEMOSnw+dwWG7XiPxtOPEiBASxbu2oB3IwYg XeGA== X-Forwarded-Encrypted: i=1; AJvYcCVVmaPLSTgQjdnpxiiVL2dj60GvwbraVort0Gg/oKQtCBd7tRnpzl9+gLtTNYCOejukQcO3KfJ7qzpyhoI=@vger.kernel.org X-Gm-Message-State: AOJu0YyyuRSM1TTMoMLN/AG+iGEr42VaHjDWcjkOFyeba2NJ313bPmeI ZoA6tNM3HRKkM4nROjl3JRgeEN6RtuVXqcLWPSZnlaGyDp+H6dtxeNjBNByu3VKB6mQGjSoOzLB 2vPN9 X-Gm-Gg: ATEYQzw4RT+iZieQbqfkJ7O4vK+4kNcYj3p68vYsaKAx74RXjkArfzrVAsB0ktDMOyG 6kXzGicuUTBrM+auP2dGNrGzMetFwZ5sc90A0NgQR2sbK0h617hkxLWFHG4c0nTX7CfUybUQr4O vsupcHEJpNo3x+Dy2+Xzi1HNeh0DvwSHPCzMRJheIQz85hl06lrR937I0is7TZD9DQgYs6Dnhbn ECxShHkHDjkgVLWPUcSh4hBbllaLLQQWtVKJuCG98cVcbzklG9WNp4EMB8902Nzgfh44ENLrapu 1htV/my87uloolWoaKxHWh3R4fNaVNkWUqSyLJCgdli6QYUlgr08ooRn4fp0fTbbBJA2rLGFzah uSbIlSBhO2v8b5DmF3Dj60f81OrSF5fdt6n5Da16gRG2ke28m/pt53qG9oz0RVr+iNnp3eO2c3P zZPFMpS6kKztygRrKoBo/dJNe6+76B9H3mtawUHd0hRcPONlaiGZczZc7KVa+vC8Q89uBRe7DaK zMn3A== X-Received: by 2002:a05:6000:250e:b0:439:bcc2:bf0a with SMTP id ffacd0b85a97d-439da65d52dmr4139837f8f.23.1772807601226; Fri, 06 Mar 2026 06:33:21 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:21 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:04 +0400 Subject: [PATCH v2 04/11] regulator: bq257xx: Make OTG enable GPIO really optional Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-4-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1089; i=alchark@flipper.net; h=from:subject:message-id; bh=boG9G+5QbeBW6aT+kko42e7K1ue9tm4B0o/XFrV9C0g=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerqk/mJMZptu1TL5jRs3fw/c58CRevt1WfZn6+7bM jwMy2xfdExkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDV72Yy/C+NNJ6xk/93f+QD99C2sOJFtxI7tV29/FuWS1odXLn5RybDP73JDGW BO23s9R5Fmb3dezk74ouARcYqC9UIC/PLqdlNDAA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The bindings describe the OTG enable GPIO as optional, but the driver gets upset if it's not provided in the device tree. Make the driver accept the absence of the GPIO, and just use register writes to handle OTG mode in that case, skipping the error message for -ENOENT. Signed-off-by: Alexey Charkov Acked-by: Mark Brown --- drivers/regulator/bq257xx-regulator.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 674dae6109e9..0bb58ab4b8d4 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -126,6 +126,12 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_= device *pdev) of_node_put(subchild); =20 if (IS_ERR(pdata->otg_en_gpio)) { + if (PTR_ERR(pdata->otg_en_gpio) =3D=3D -ENOENT) { + /* No GPIO, will only use register writes for OTG */ + pdata->otg_en_gpio =3D NULL; + return; + } + dev_err(&pdev->dev, "Error getting enable gpio: %ld\n", PTR_ERR(pdata->otg_en_gpio)); return; --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E99B33B960 for ; Fri, 6 Mar 2026 14:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; cv=none; b=IxZxdZ75gLLoKreXzbH3VYJ/YxlI9z0dIsqSCkpgaHkO1PJQ6FG2kj1+57byxfXoVGQcJNapVP36BH+CUV5IZj19noJiLwx/aYq0BJC0bOYi2M5qv3Dky26YQMByG4wQkHNHWV6k5S2y6AOslddjpFOGnJPK78Rv0pnaUfPSj10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807607; c=relaxed/simple; bh=Q9D7eBKxq86MNvlgm1qDMnqHysA/422W4yV9eBroyC4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aZBC3qESTrbhi9E8K8mO64Fky7VE4EEKscIg1p7laYvbAvikADjcKkOP9oA078u3EmMmfdlLvDrcgqqgky7b7yt2HUO+dQn4Amq+3Bnr+QiRxS3UQxerVnkEA7PRDN7gi/HCIC74L0jns8iepYSW1an1dpm7/CGJtpYpP/ysEOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=hb07hmKV; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="hb07hmKV" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439c4bde55cso2454123f8f.1 for ; Fri, 06 Mar 2026 06:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807604; x=1773412404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Sz4biLahYPKsT9J1ufLdEia90vJM1vdO3bq5iy8XGEM=; b=hb07hmKVFklaYksufnqvG4Dtv82VpVtF284kZVDLekZ0Hlo9DqXt9fT5waLAqEe6zW EsaajfcccqaDX+qHghQidCN5OYGIpkR+TZNcbOR4iUu+TGflTsANcqu3O6OHBX8atPBa rjxLvfDX1kH+jpaguxpa0ezpG83xwZB2LUE+gV0tV4/Q80I7LBHExvu/9E/HHHM7oBEJ jXHBg1chLmBy5KRpTveuGfmJlhTvYO9gPZyXAyDVTnk1cs+qxwJeDCPNkPtz/jImCadY 83PvoEm3N6Loi8P0aMss9ElA9l3ZRE9uIY5FF3BFaXq4IJtj9tpmoz/vIZGdTMYLGDsf vKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807604; x=1773412404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Sz4biLahYPKsT9J1ufLdEia90vJM1vdO3bq5iy8XGEM=; b=qs9YjraAv+AhWyIh+hFRhdME7xUfBQft3SIo0aVOMGmbugjQ32Z9ce9ICKkm0xCkV7 CloElK3pM/8uA3pWqrC0adGYnSk2Xp9gTLVG1SxfV47Zn9eHyu2+93aAMt5Ylmg92RyC odS7pCtLfRfxiGGyBoP7rENWydJNzofubz5EE2+6b9uatPd5tDRu3q4CM6p1a2IOrmzM quPrYmziSZZuLsPXHnxCB8qyOn8PvII/0GORO3Hs29DOko7k+RcTo+opL8VhGpTM8DsK Jmue9RRHbEuCNH3P3KmPWA4iuNcKIiMnwiPvdhH+tKoyFBkN5GPHXq+pImPRKy++I/6P j2BA== X-Forwarded-Encrypted: i=1; AJvYcCXg/gM1DXy9GohTZb35dI8r0eD1Qg2htElhkOqiqkozG9+1W8upyrt/4HDQy4j9SNGEc8HppoundZPmr0U=@vger.kernel.org X-Gm-Message-State: AOJu0Yxcno/yV6W3/WT2uMIRt+uCCQjBARLgIULkZ4BhWiSix7gGvH3r sAqCCKEpsWuD/Ad28Z/VBhT3+H7NkVC6L9wUDJrkCN9DZiPkk0mjn+LcuIM/Xh/fB84= X-Gm-Gg: ATEYQzz5WWSfKV0UQou4nsOY6VOPAFShXKv8bM4ML9h3Y/l/xdK6KteIWFzX+yOyZZg iP9MUtQQ0QUJOfrF4usTP83zwFWBy7Exr13/aRhGMN5fdU35oM8tACjI+qCrpeCJUQ1mMOZDZXf /wSGK/UmNT8uLJW+jHFcr/yZgp9Sf9LSwYijkv2j9/gCkCZQv5sxAWU52YNmgXJhNbHLGSFClO2 mC1UB8vWD9kt/0PhzFx8fAlF6S10vfwgoycNrMRl5l3SvuSbwP9Pyd7wJlWtw4dV1isXTev+F1i B9rGXMJ1fUoFKAivUxy7VdYzvC82NSZO30KwMTuksnNdPDESnnQJGSGQRupxzWdiSQsb4/NiAC0 sB4EX0UjM7t9geF+wEE6bzmTK0d4wyGZVv+R7Sx7AH+PKhuiTkHjV0fSNu/dUTO8cV2BAByaJbF rHr6dIYPrAQo1mlbGObv5mVVH2H+Djc/dCm52xZuPHvErdr/9UWHSXuZLMn+WTjzocXQava53WI 8U3nVU65U7P/tGg X-Received: by 2002:a05:6000:1843:b0:439:c9b2:6571 with SMTP id ffacd0b85a97d-439da3697a9mr4240301f8f.41.1772807603922; Fri, 06 Mar 2026 06:33:23 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:23 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:05 +0400 Subject: [PATCH v2 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-5-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1911; i=alchark@flipper.net; h=from:subject:message-id; bh=Q9D7eBKxq86MNvlgm1qDMnqHysA/422W4yV9eBroyC4=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerpE+vDa17tWlximfOM7VrhvSUAK8zyHheyO53Xnl rdY82/w65jIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQ2RKSBAQhYGPhyE/NKjXSM9Ey1DfUM DXWMdYwYuDgFYKp7PzP8M//80iNKkmFiwPTSVjahl+VfuOfK3/8m9Om+59sddeppiQx/BQWXTFr woJp39uYHy4J1nTRuVzd86xO5b8EnXVLct+AWGwA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165CA392C3D for ; Fri, 6 Mar 2026 14:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807609; cv=none; b=EFqRiJiml5jpRqQr8w4nkyFGx9cyJNJOGO7GF65tWcTr4tArass98QF9ht9+BRTAfYIADurEakKUZQNka41GoLxWWmwvqyD69W9ydpGQHHnwC9uCK74kLoP6RdHGMPUjA0Y2YToag6DkHm3x4u5CiprV6Lky+bAd1EJ/tMrVFsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807609; c=relaxed/simple; bh=rI3qlTJ6sVlqcAKmwgpX1F1kJ2fiqBBvb2/yVu30Rak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OdtlTIWkryyPe1n/ds5gsaPY9XdIk0FPeL7C4iTBN9OTmaEaQUQ7gmxXi4vff9eDtv7aGJPGZ8aQ1k9ZnnmRk6QhnwYVQGWKV5xJu7mYTTU/Sokg0tirOJHww/rCuK347eOe0xfI6SvLKKtMBH2cYNzRzXCHXJZ5obd35Qs5dyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=07HutCqE; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="07HutCqE" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-439b94a19fdso5319211f8f.0 for ; Fri, 06 Mar 2026 06:33:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807606; x=1773412406; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UNXZcw1aJqSKR83mcQk2RSs9v+AW3Tva6N8ZbjfBrlI=; b=07HutCqEanVTkgsAQZ1eu/ajYE+l43WRqlTAg8j85xD+h5tREo0XGU49ybKAf3z/8/ HUW0QZqpJBRJHXzR3Y9b31s2ytQK2GRHTe3FNJAAZFr58lDf3qxOKML+CVvaJ2K/q/8u onAwz3Lt0ErgZRtesf1qQLb+xSv+yxsJ4Jek7kSgHdlOE85A0QdWg10+68wUQUYoKOcW /GvV9UId9NFdhVKT36ByxqfPhPJtEc/Z2PpPxMxFCWx+CYmydqFh3XawUh1qFsGeYZUy Kt1jvXSy1nVX6yfJAJ3TSG92fvlOJ/FIxjQw6/gmbhTuRy0otcaCF00G08wfr5kINRXi aDrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807606; x=1773412406; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UNXZcw1aJqSKR83mcQk2RSs9v+AW3Tva6N8ZbjfBrlI=; b=O4ADjwWrNlMrv6NwCgR9mvoIX3YdttcHgPLzHT27AU2Y/TQCHxSX9DDBry1Q2zv2f7 qdSjK7Rif4fgzCLcZNpEckjWMQlhbiJ1SmKa77fhm1zgiwSuuHjntbqfXsdr92AdDwyI QN0Td/E+Gq7/qEufSiBX+OAhEg9EWP78vDEx6OvYLNfSCN+xjnCWZLwD0n2QdSD1OTCl oGB8Pb3oFNl6u0P/NW5J38joxxOVIDs+Psd4RF6HoQxIdvkK6zOhREXo1mK/OmJB6VA+ 7AemiLt91vhTBzarCBhKebhXxxy5Cd8MuZ3XxcV2nx58A7s4s0QjAS+WNR6GmNhkXqXX W+Vg== X-Forwarded-Encrypted: i=1; AJvYcCXAVKpI/zzig2+R0ERELIPAc7CpwaqJBbw8eqCC1hcZ+Z+RSlOo++BhABAPl42pxm6mo/2fMxVMkKlfIyk=@vger.kernel.org X-Gm-Message-State: AOJu0YxiabS7JzrCk5zi5uVZzS25ls2TlH4kCa8xTdr/0MEJEOXWQTyk iv2Jb3jMmQpYG8FQHPu8G+OqSMw1wTxLwRoeyaGD3wm7hyTRho5ls6sXS6NiLF0UF9HxqFKik6a XzrkS X-Gm-Gg: ATEYQzzeudx134gn6NG9gC8+9nnVt/vUo7JfogJIVY5L9pi7ErMqH+6DXR1MJz8PL3n m04cQEnP+mk3Vo5ssxN1KAKG/vKl7XC91is2gK23QJnWeX02SOFBBTOPCoxuH2r9soowMinTcz0 nOxFnoMJu4Lp/DS76EY7E/dQlXiwAj3bin7HalLDC8yrQNeTPW04rDVorTgbpA7n6tap3ATYlq0 5fCp9qWxUI+wI2DYl/YjRB2AaSKuC7DYZTmgtfZUahVIMP7zhW8wlW7j9wV2PhRioitejQTejeo gRaUe5fsJ2riQ7Vu8NbOVEpHneQ93PE5HvreU6vrYnVnc/hM6hQgiRsjxbdcNtk7t9PNEUtAgkr NQrbdtN4BrVmExoHyG5+pC0NY1/IrPMx5DIHFkI5Pxv6RezENQdO7cCsdj6PlWHDG1bCz5DPcgi mc7u2/mOrBxXtvwN8A4KqRtwDDTV7/S46XpBhH/xnja6uIiKwiOh2TMaJ5D8GHJDpCp4JotoQbV 64Qkg== X-Received: by 2002:a05:6000:186b:b0:439:9282:e728 with SMTP id ffacd0b85a97d-439da654ce4mr4361366f8f.2.1772807606440; Fri, 06 Mar 2026 06:33:26 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:26 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:06 +0400 Subject: [PATCH v2 06/11] power: supply: bq257xx: Make the default current limit a per-chip attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-6-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1615; i=alchark@flipper.net; h=from:subject:message-id; bh=rI3qlTJ6sVlqcAKmwgpX1F1kJ2fiqBBvb2/yVu30Rak=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerpEulGU2U+WZdGfB9M2vhS2frju+WXT2bVh327xH X2YsXv1qY6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rExgQ0QaGICAhYEvNzGv1EjHSM9U21DP 0FDHWMeIgYtTAKb6LxMjwzNX+19bA3ff0FntdihP+tNDa9MFP7cUlH9i/Cj4S+RtYRPDP5v/zTP fTeKuOLJYdXqDmdZFTzf/Sz+vT/UMnCIlIxeazw0A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add a field for the default current limit to the bq257xx_info structure and use it instead of the hardcoded value in the probe function. This prepares the driver for allowing different electrical constraints for different chip variants. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 7ca4ae610902..e14dd16f9d08 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -26,6 +26,7 @@ struct bq257xx_chg; * @bq257xx_set_iindpm: set maximum input current (in uA) */ struct bq257xx_chip_info { + int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); @@ -627,6 +628,7 @@ static const struct power_supply_desc bq257xx_power_sup= ply_desc =3D { }; =20 static const struct bq257xx_chip_info bq25703_chip_info =3D { + .default_iindpm_uA =3D BQ25703_IINDPM_DEFAULT_UA, .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, @@ -675,7 +677,7 @@ static int bq257xx_parse_dt(struct bq257xx_chg *pdata, "input-current-limit-microamp", &pdata->iindpm_max); if (ret) - pdata->iindpm_max =3D BQ25703_IINDPM_DEFAULT_UA; + pdata->iindpm_max =3D pdata->chip->default_iindpm_uA; =20 return 0; } --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A181B33B960 for ; Fri, 6 Mar 2026 14:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807612; cv=none; b=cFKMgvFe1JTT3KeQHfTZZHY0jnLkbEnt241SHEQQ5oZHK0UQEr/apTzRfGL2p1ZhTNfw2YP2R4bxGIncdNP6NusRmE2Dh7++DlkkrtPhUAMLhgSeBMVQFAdaj8Vw1NIxehmbUSlxraCWmBCzpO3MCEE+R0rws7P0crexy8oFMlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807612; c=relaxed/simple; bh=rZeSH+p/sWb94+YtWuBoX7zwjk1MlkPbjBLWjAkhzPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mcn+e/B8chpdDrDwnxYUDVm3JKrBgclbM9Wi/4xUHCn+eQ2ZcAcxVmyVRpfHf16dmkRRQ14G9i8F+DVbmtbukR1drzjDY7kKo7QsVGKzIHRbvp//I5CmkhDjjfUbGGuaZdUihVySGNFqyTIDfV6zhE8+QFCudBvkGFlXglOr+eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=EweMiyHU; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="EweMiyHU" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48329eb96a7so61550505e9.3 for ; Fri, 06 Mar 2026 06:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807609; x=1773412409; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I8FV20nY94XdgsSpk3nNKgaUktiutL3Fj9XNodWc9Os=; b=EweMiyHUqlgtoxy20WJ+dlyC8cMiOwddivymdEGCf6tD/xxzAgRM06PnJCTRGti1L0 DvW4y3ocSuI9+d/9RRr2IZds+u7CCR++RvvhggHJoRruYqVESDJt5WMmJcUlvPmZpdt9 XSEie3HniWPZ/yFd0ZoTjyJX/jx5yZkoK95PGzcLTo9jjn3wpwRM1aRq3adFhK+bCIpM fvrxAbG/ETbBIqUWrOPb/YKmyx0yh3kBd3rRysF9VmCij0bcIKmd4lxAD69fgZT8P2Z9 aHYjcf9N8c4EnubEysahCpi3WXPMia1qtXI5faXI+uSgc8+gnH08L+9JGhlZKPMaxgBD Ry4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807609; x=1773412409; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I8FV20nY94XdgsSpk3nNKgaUktiutL3Fj9XNodWc9Os=; b=dtx9bzMC0P5NjcjQkuqFRpzo4fd8t2k0vEA+mBz+XIVB7egNwyVAc3DV1xXG1Bsm6z 7w2aGEbPINDM/bUSY7OnWoLXnnHZEUikEtqFWjMHgXUJ7mrhWgjcFV52PmC5aLBav1Fu Q0pybh3u8D9I8lj9e05kJJCizxUv6m64Crg8cT4XD4//9XK0GKH8a6k2ROQGUYwUIvRg khWHkaCNCoO+/vHEhSirmnyTegW1fu9oRZY97d50NCdxDWosNldI4RIpGXEqAUSbcT1W eP0Timp6nMyOI2XncPu0XUuzhtAq2xFUwqcYKuazVnK6WXea7mrDj/HX2luAFUe5jBxY /UVg== X-Forwarded-Encrypted: i=1; AJvYcCUO1Lm4vjVxsqvlSXsIGdREFn+rhBf3u7fW92JMvlltgEBX0Ogk7E/KuRB28B+nc2kObUEijNxofaVZxl4=@vger.kernel.org X-Gm-Message-State: AOJu0YwDBkp+TD/535b7STMYbUKNcgtF5gnxLHD+6u/gEchNpAg9sbUY fHcb0+f1yi/YCiW4qvK98HlHIfKgFfLCuM9KE7Q2Ks9o4DQVMHgK/7eGgf0UjhedeY8SL/2LjCw Q3cmq X-Gm-Gg: ATEYQzxnwObzsFUN6seTQJiL7Y67r/+cvAy1563sYyjyH00xmsyFqXLehzAefoDpo37 otzr4FwLUu0JJxl1CV2BscCiDECcxIx54iFm8iJuPLOUjCx0RC3v6x5G1JnV3FLxPA1EW+/bHfU +k5/ChGvqjtw5Az9F12tI+WOKNo5FF9cOdGh5uySCBRNjNt4Cuh9wCD8x2avoPBvGXyBkLe9+SC wH7KP8WbFwhuQzWhp89SXKf8N0O/29fl/Lbk0ZPOQc3DDJd3cG+yNlh3Rq4LgR8KOdqpM9TWb6F BuHvO51eqTVlOEYbCEUgYEwtbM78/yIn5X0kLFFZv9txESVrhEL0LKb9jEY0FpRttMmNVOyo4u3 HxQcnigvop/G9sq9YmxIQdI65OiHvMVwMAQO2mMHTC3OvQSLGK7H1FrV7MtQo125oGSrT6X7AkK ko0QasS6XJfD4tOjj/CaiZ8sTXBigszIIgxUwpZY9DDjtWCvu/3sa2QzX+EiyRYh94zifB+w8H1 wjXtl1U6qqvY7ES X-Received: by 2002:a05:600c:3596:b0:483:6f37:1b51 with SMTP id 5b1f17b1804b1-4852697955fmr34852995e9.23.1772807608970; Fri, 06 Mar 2026 06:33:28 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:28 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:07 +0400 Subject: [PATCH v2 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-7-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3364; i=alchark@flipper.net; h=from:subject:message-id; bh=rZeSH+p/sWb94+YtWuBoX7zwjk1MlkPbjBLWjAkhzPY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerqkvnqiT8+3o1lGnJ6+pseXrQtbEfuxb0n2fe6/l S8sK9O3dExkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDVKZ8ZGWbal1zZket5rlD8nmCb+NMpAdHSdU9eCk+YHR+g8jKtiI3hf/7UMw0 PA/9WlbM6JSx4vmg7b9/mhi+rZa+uy3oV/ebHHy4A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index e14dd16f9d08..deb60a9bd222 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -30,9 +30,15 @@ struct bq257xx_chip_info { int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -489,22 +495,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -632,9 +638,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3DA3AE1AC for ; Fri, 6 Mar 2026 14:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807614; cv=none; b=W8umKzWLfD+6OPpsYxO58quYSNzxQ0a/Aw7eWMaFuSeqckhx+Ote2xUcyebMosoQXFazhIfcGM1VNMTuB3DNiRkuF/kjBBlC81HoobNF5+DoPBSpOcRMhPANEFDErfUSkDh77gq2XsCfCSC4LH00FcsbIfde3I6CHQC6vaOzMU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807614; c=relaxed/simple; bh=fqgV7d8c4BXshhw1gqL0HWfj9aw9iK9J0f1QWTNLAG8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WuZQaCTVb59e+1I5iW6LAiwv1+YyRAyPlbyA2yhQ0ETGtCQwUW83VsNWS4WXPul9hDCQ6xii+PpuKXaqSa9y+cO6nwerhUiammyDkj3kV76T5bczSOrAXrVJuLT4wjEG75nY/0PfNICgmanyaMWtexRsUEt2ClLcv1QduFWs5II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=86C9qTSB; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="86C9qTSB" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439b8a3f2bcso4454893f8f.3 for ; Fri, 06 Mar 2026 06:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807611; x=1773412411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G3vNgmqYmO5UknTO3x1kCPV7VqUspCxEKfK8SFuWCw4=; b=86C9qTSBOxKfG2vT8h98Npx9FZhWZYsroH/7Dw38suMcLOmY+kYC6w0nQQzWw5x3Pa 1b1MX7NUz5wEOMVhPa8NqhVZl0EGh9tb1zh3ZFnJm3N339PLSkX39NgrdRCu8FHz+1jc sTNg5AQveH0AXgCoebzjGZl6Zs5v/v3x4oA4lQYa20T4mKNCduhk07NnwI10Jz3yM/6v pcH2tIo0l+hARK3+J5we0ms7guRG7UvEnbbuCy6f2EKCdMqpRnf0dciSKoCAVVfzSg1X azKpNI+jFGPA7Ws4TTB3S5A4f0ClMM4xFBivxIDRTs4Ni3XpQWZpNML2Qh1HKmZYkqFU bwMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807611; x=1773412411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=G3vNgmqYmO5UknTO3x1kCPV7VqUspCxEKfK8SFuWCw4=; b=uRl0Y/0GgQiX2WNWii8Qc5cJ5eG95IRGeN1nB3y2JnVQjeIPWZiFCcBS9ihvHInZ87 x9Zo/T9TkukVL4TidSuYIcCel7C6VmxJ6KVw4NiYJOfAhlNHDmy00HERdSQhwPrl9oLW BPobsUjfOcFR2gx7V2FIZrcGzMg3JfksoISKti6zmphQuMzVLo+7I5yJLN3U0F4ptJXQ 7eHWj0CnKb+GUd330WKew2b3sMajHPhRJ2O9LLhs3psh9VChfz+gDizg5kH4r8g2fiQu CDSBqeAGvDNHXaxc2oTy3fhbkuVtXmd+SfhBMu1eJvkJWQEWmMc2iH+YORhPIB6H0FsS ZwRw== X-Forwarded-Encrypted: i=1; AJvYcCX3ARV2zNyNHkIbhRkOsuO5+PsvUsYViKKpvMkKLV0xVJhj+y7AjdgGbN6AeSVDwjMrQbcT/R+wdZqSkkM=@vger.kernel.org X-Gm-Message-State: AOJu0YywapPWv6M4pf4InuMd0bMb/Hxj6leGsdW1pEV9DQxDX32e11Ez u88Ay85hYPnugJiIcDTbIxN2BDPKXktTtrrObTezCGdKvfsLXXfuOvgX0g+CIzXvAalfln//R5Y 9Ywai X-Gm-Gg: ATEYQzwvy3S1G5kpUskmk2LZqsPuG3fSwj3Uneqmg76U4hROoLQ40TXVYaL+Dz/gWjR 4BrPTTeHTW99KgdW79k0FN6UmY4tT7nrzxVrOT6YhjTqXAxWXvDzpHlYx19D6IeDf5AcqZxjw6J LUfrTmAOKryLn9uXDNScfzr9Rj3pPWprTFltZYQ/UpFAVwbJZ8k6QwEwAY7WnhwqvANIr5loZ8Y WpPeDW4ClBpusSfmbBd+keK2nw+ENjDNx+xAtyXWwhRI/Q693UOBGj+663vzmknQWAg4+rvPYgj +g0m38zZbJw9QOSbDa5Du/zzvkgrYX+7W+wKWdITGYXGW5nVJS9IVnsuu9f/XdAVQ3UCBF3yOiA fwREi/epb1ZxWxnsQdahuCVdQwkZ8rAGTwJWp5UJNaFkJ4TTRZcMFUtrkhBRp/mH2RizOvURsCa 7RFxdpbI+MLcuFTuxqUsOP0qhb1Af+nJsFRwKb0TSO9i3HLZWOV3SMn/IfnR8VoQKWaOCoOEjZ9 cPp7g== X-Received: by 2002:a05:6000:1785:b0:439:af25:e4ea with SMTP id ffacd0b85a97d-439da66c26fmr4336958f8f.25.1772807611534; Fri, 06 Mar 2026 06:33:31 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:31 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:08 +0400 Subject: [PATCH v2 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-8-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2470; i=alchark@flipper.net; h=from:subject:message-id; bh=fqgV7d8c4BXshhw1gqL0HWfj9aw9iK9J0f1QWTNLAG8=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerrE+sdFtp9H3jRtXiPzfcbnQ3pfbz9Qqv8kdjLSo iY+8eYU5Y6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCm+hI7w//4xZlTLh4QOrJsF2vvTL2z3oti+w48/Ps03T/lQMxGnR2qjAwH/y8 X0zBNN3I747Xmq8qfHQXq0bvKmxcfKNubLP7pRBITAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index deb60a9bd222..951abd035fc5 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -64,8 +64,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -99,8 +101,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -471,14 +475,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06BC43B3BE0 for ; Fri, 6 Mar 2026 14:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807618; cv=none; b=IxBZpg4w4O9B98RUKuOY9wrRex8acmzvQPryZ3JQyLNwQYj7ywXWZxAgJX2LDz546BboffjXTZiPdAuo/HyYrjyX2Virl2foevIl+I4UTlJ3PWW7gw5FKlWC2YRaDrK+ytJ+9zUPI3HJAa/a8/oa66wpGLw0sDIeATA2pxOVWrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807618; c=relaxed/simple; bh=nOduz00h5fpXPu+UdGV0hj0gdsgtcCrHjSqgzrZqdz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=olozyoixKNwigmOHVqcKayFWRQOg6htWTi4v0cu2pcJsd0NbR+RENuwG8Adf03eLSLunGNoj1MbB3Zeo5CVsmv2YHWiO1UHAxcWrDSQm2DTjkFYgMxYXDUHeP0qfsuscmyfFFOTCLjORKghG7X5Rk4oaPn3fyHppmM1Ss5Vlocs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=1UiaYzMc; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="1UiaYzMc" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4837584120eso71578305e9.1 for ; Fri, 06 Mar 2026 06:33:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807614; x=1773412414; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JmALN9MGA9u53yKJNFJzqfov+Z/gHizGgvZq4z1BuiI=; b=1UiaYzMcSfP7ZBvCg7SonG1dAPs/eUonkzG2pTOrqqPWkfOT/Vp3q5QNrnex01K16Z yhMfw3zG37QlUbBUbHi9AFKisnnQxbGbxLTyxtB+O4k9yO6ufPR1O8vHj/zeVnfXQIAl Ef+JACheewOfyMREaTpcnAp1mE6Ciw8Hemg+tiPD1xO7/v1g+nvdFKHNd2/2EJROe+FT 0pulxZ4G2t9Y5RWhhTtSq6gduMN0xCyGbZjgBGUnjVj6j4EXApMJGAajb6ESb8pXseZo 0MxbPTLSnyQUQG6nY5jNpbEQnXNP8gsreq7LqnIZRZakTgvkkq+g1kLIuUdkkC8Zfrj7 wQTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807614; x=1773412414; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JmALN9MGA9u53yKJNFJzqfov+Z/gHizGgvZq4z1BuiI=; b=wykAlwQUntRlAw4pdDms2Nqfu9pXfD/3TNSY+sw72IAKjBR1wRX695VN3jp5a93ca6 5NWgXPR7g3SHwbgbh4+jBE99ZveEllbf0REdRj6IjxC59r525+BeL2dlohVybLa4KLLC g3rT4ppuBmaAYn8C7u00buUD7PvWW2a9Xb4IZyY4Wo5qI46LOo/+bJIFjonSCF9wFnQO S2J/evQmAYQwzISrGfDRQ3xO24w+yIXlYCsIuAer9La9MlwIrAa2AFwwvPyNFUfakCOg xCbQ2MPdyhwfoyBAObXrWQChiDds+ASSllObPdnW78gQiqcaxF3wvySd3K7hDLuGnv+J 205g== X-Forwarded-Encrypted: i=1; AJvYcCUvAX2GCLfgSQ1cO6r2rgu0lryEApb1trg/huvyASSPX7DOWgfSgttI2YDje7ouE0D06dUSKS/vYCzcMM0=@vger.kernel.org X-Gm-Message-State: AOJu0YyE5QKeQ5JA/e7yyWedrTdMzKnFjazoWh0xSpAFsLTvnsc/UMIb hyJodAJ/HO/VH48UESLvmI3u8LqunTFmw+JDnM64UifQHk+I1rnSo9RvbCEpXhnCkMI= X-Gm-Gg: ATEYQzwZGBM5eiXKyamVMYOHKivB7FF8n3gRmQz8giv7FogN2Wri8hnBjUTgrMi4gP8 qBAFU/rvVa7EMx2b+xnwe5OLNqIEqvAFRFxQMJGHEgFk2jxBl69l+M3wqHYuo1o8Pe0l18Uekn7 4ZijgUJY8R1VFNgFJC7POek/uyxPkVoyunFJBxJ1as60Usn5kKvk1lY6ROAQuTvN+BdHgQAtlIC UTbl7ZihQucwu4MZQ3q/nK51gnH13kZK0zRWXuycTg9PqHjsjzTA3OfOaBLA8dNOJSaT4w6Lzpl lKpdbF41pkvcy6DUGTgYeu4CTyQmBIYPoSu4GfO9fYFuIFiCjHXOOpZvFoGG4CQRbh+Q1YwfLzh y8Jqnh4V0lnL53cy7jJYcLx8RDyaNEGGY0z0Lv21ABut66A7j2Qt/bK0eFFEkRdR6qmW5Kb3z4o mUdily6KmEtuyp2FcJP0oMXZiBUVAq5CGnEkvhVFj+OBbGgqJ3n7LxzhR7+CHuyGEbi7TlIN76c KhD7dg/DROc/n1Z X-Received: by 2002:a05:600c:a12:b0:483:badb:618f with SMTP id 5b1f17b1804b1-48526966b07mr36088075e9.25.1772807614272; Fri, 06 Mar 2026 06:33:34 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:34 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:09 +0400 Subject: [PATCH v2 09/11] mfd: bq257xx: Add BQ25792 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-9-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=19885; i=alchark@flipper.net; h=from:subject:message-id; bh=nOduz00h5fpXPu+UdGV0hj0gdsgtcCrHjSqgzrZqdz4=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerrkmEWz3uHz3x89CT288I7OxrbKz8/u7XiSZuT8Y IFYVcKMio6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCm+vwdhv9ptpcDpPuMQpbb3ndoNTknnZ8gkRxx8HOB09Pe1Iu2iUGMDKc4Ny3 irH194P6pgyyWEi3hnj+b7VvN3RhS2g6cO7r9MBcA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add register definitions and a new 'type' enum to be passed in MFD platform data to support the BQ25792, which is a newer variant of the BQ257xx family. BQ25792 shares similar logic of operation with the already supported BQ25703A but has a completely different register map and different electrical constraints. Signed-off-by: Alexey Charkov --- drivers/mfd/bq257xx.c | 60 ++++++- include/linux/mfd/bq257xx.h | 417 ++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 472 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/bq257xx.c b/drivers/mfd/bq257xx.c index e9d49dac0a16..a6776c8c94f2 100644 --- a/drivers/mfd/bq257xx.c +++ b/drivers/mfd/bq257xx.c @@ -10,6 +10,11 @@ #include #include =20 +struct bq257xx_match_data { + const struct bq257xx_plat plat; + const struct regmap_config *regmap_config; +}; + static const struct regmap_range bq25703_readonly_reg_ranges[] =3D { regmap_reg_range(BQ25703_CHARGER_STATUS, BQ25703_MANUFACT_DEV_ID), }; @@ -39,13 +44,56 @@ static const struct regmap_config bq25703_regmap_config= =3D { .val_format_endian =3D REGMAP_ENDIAN_LITTLE, }; =20 -static const struct mfd_cell cells[] =3D { - MFD_CELL_NAME("bq257xx-regulator"), - MFD_CELL_NAME("bq257xx-charger"), +static const struct bq257xx_match_data bq25703a_match_data =3D { + .plat =3D { .type =3D BQ25703A }, + .regmap_config =3D &bq25703_regmap_config, +}; + +static const struct regmap_range bq25792_writeable_reg_ranges[] =3D { + regmap_reg_range(BQ25792_REG00_MIN_SYS_VOLTAGE, + BQ25792_REG18_NTC_CONTROL_1), + regmap_reg_range(BQ25792_REG28_CHARGER_MASK_0, + BQ25792_REG30_ADC_FUNCTION_DISABLE_1), +}; + +static const struct regmap_access_table bq25792_writeable_regs =3D { + .yes_ranges =3D bq25792_writeable_reg_ranges, + .n_yes_ranges =3D ARRAY_SIZE(bq25792_writeable_reg_ranges), +}; + +static const struct regmap_range bq25792_volatile_reg_ranges[] =3D { + regmap_reg_range(BQ25792_REG19_ICO_CURRENT_LIMIT, + BQ25792_REG27_FAULT_FLAG_1), + regmap_reg_range(BQ25792_REG31_IBUS_ADC, + BQ25792_REG47_DPDM_DRIVER), +}; + +static const struct regmap_access_table bq25792_volatile_regs =3D { + .yes_ranges =3D bq25792_volatile_reg_ranges, + .n_yes_ranges =3D ARRAY_SIZE(bq25792_volatile_reg_ranges), +}; + +static const struct regmap_config bq25792_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D BQ25792_REG48_PART_INFORMATION, + .cache_type =3D REGCACHE_MAPLE, + .wr_table =3D &bq25792_writeable_regs, + .volatile_table =3D &bq25792_volatile_regs, +}; + +static const struct bq257xx_match_data bq25792_match_data =3D { + .plat =3D { .type =3D BQ25792 }, + .regmap_config =3D &bq25792_regmap_config, }; =20 static int bq257xx_probe(struct i2c_client *client) { + const struct bq257xx_match_data *md =3D device_get_match_data(&client->de= v); + const struct mfd_cell cells[] =3D { + MFD_CELL_BASIC("bq257xx-regulator", NULL, &md->plat, sizeof(md->plat), 0= ), + MFD_CELL_BASIC("bq257xx-charger", NULL, &md->plat, sizeof(md->plat), 0), + }; struct bq257xx_device *ddata; int ret; =20 @@ -55,7 +103,7 @@ static int bq257xx_probe(struct i2c_client *client) =20 ddata->client =3D client; =20 - ddata->regmap =3D devm_regmap_init_i2c(client, &bq25703_regmap_config); + ddata->regmap =3D devm_regmap_init_i2c(client, md->regmap_config); if (IS_ERR(ddata->regmap)) { return dev_err_probe(&client->dev, PTR_ERR(ddata->regmap), "Failed to allocate register map\n"); @@ -74,12 +122,14 @@ static int bq257xx_probe(struct i2c_client *client) =20 static const struct i2c_device_id bq257xx_i2c_ids[] =3D { { "bq25703a" }, + { "bq25792" }, {} }; MODULE_DEVICE_TABLE(i2c, bq257xx_i2c_ids); =20 static const struct of_device_id bq257xx_of_match[] =3D { - { .compatible =3D "ti,bq25703a" }, + { .compatible =3D "ti,bq25703a", .data =3D &bq25703a_match_data }, + { .compatible =3D "ti,bq25792", .data =3D &bq25792_match_data }, {} }; MODULE_DEVICE_TABLE(of, bq257xx_of_match); diff --git a/include/linux/mfd/bq257xx.h b/include/linux/mfd/bq257xx.h index 1d6ddc7fb09f..b2e38a4a4738 100644 --- a/include/linux/mfd/bq257xx.h +++ b/include/linux/mfd/bq257xx.h @@ -98,7 +98,424 @@ =20 #define BQ25703_EN_OTG_MASK BIT(12) =20 +#define BQ25792_REG00_MIN_SYS_VOLTAGE 0x00 +#define BQ25792_REG01_CHARGE_VOLTAGE_LIMIT 0x01 +#define BQ25792_REG03_CHARGE_CURRENT_LIMIT 0x03 +#define BQ25792_REG05_INPUT_VOLTAGE_LIMIT 0x05 +#define BQ25792_REG06_INPUT_CURRENT_LIMIT 0x06 +#define BQ25792_REG08_PRECHARGE_CONTROL 0x08 +#define BQ25792_REG09_TERMINATION_CONTROL 0x09 +#define BQ25792_REG0A_RECHARGE_CONTROL 0x0a +#define BQ25792_REG0B_VOTG_REGULATION 0x0b +#define BQ25792_REG0D_IOTG_REGULATION 0x0d +#define BQ25792_REG0E_TIMER_CONTROL 0x0e +#define BQ25792_REG0F_CHARGER_CONTROL_0 0x0f +#define BQ25792_REG10_CHARGER_CONTROL_1 0x10 +#define BQ25792_REG11_CHARGER_CONTROL_2 0x11 +#define BQ25792_REG12_CHARGER_CONTROL_3 0x12 +#define BQ25792_REG13_CHARGER_CONTROL_4 0x13 +#define BQ25792_REG14_CHARGER_CONTROL_5 0x14 +/* REG15 reserved */ +#define BQ25792_REG16_TEMPERATURE_CONTROL 0x16 +#define BQ25792_REG17_NTC_CONTROL_0 0x17 +#define BQ25792_REG18_NTC_CONTROL_1 0x18 +#define BQ25792_REG19_ICO_CURRENT_LIMIT 0x19 +#define BQ25792_REG1B_CHARGER_STATUS_0 0x1b +#define BQ25792_REG1C_CHARGER_STATUS_1 0x1c +#define BQ25792_REG1D_CHARGER_STATUS_2 0x1d +#define BQ25792_REG1E_CHARGER_STATUS_3 0x1e +#define BQ25792_REG1F_CHARGER_STATUS_4 0x1f +#define BQ25792_REG20_FAULT_STATUS_0 0x20 +#define BQ25792_REG21_FAULT_STATUS_1 0x21 +#define BQ25792_REG22_CHARGER_FLAG_0 0x22 +#define BQ25792_REG23_CHARGER_FLAG_1 0x23 +#define BQ25792_REG24_CHARGER_FLAG_2 0x24 +#define BQ25792_REG25_CHARGER_FLAG_3 0x25 +#define BQ25792_REG26_FAULT_FLAG_0 0x26 +#define BQ25792_REG27_FAULT_FLAG_1 0x27 +#define BQ25792_REG28_CHARGER_MASK_0 0x28 +#define BQ25792_REG29_CHARGER_MASK_1 0x29 +#define BQ25792_REG2A_CHARGER_MASK_2 0x2a +#define BQ25792_REG2B_CHARGER_MASK_3 0x2b +#define BQ25792_REG2C_FAULT_MASK_0 0x2c +#define BQ25792_REG2D_FAULT_MASK_1 0x2d +#define BQ25792_REG2E_ADC_CONTROL 0x2e +#define BQ25792_REG2F_ADC_FUNCTION_DISABLE_0 0x2f +#define BQ25792_REG30_ADC_FUNCTION_DISABLE_1 0x30 +#define BQ25792_REG31_IBUS_ADC 0x31 +#define BQ25792_REG33_IBAT_ADC 0x33 +#define BQ25792_REG35_VBUS_ADC 0x35 +#define BQ25792_REG37_VAC1_ADC 0x37 +#define BQ25792_REG39_VAC2_ADC 0x39 +#define BQ25792_REG3B_VBAT_ADC 0x3b +#define BQ25792_REG3D_VSYS_ADC 0x3d +#define BQ25792_REG3F_TS_ADC 0x3f +#define BQ25792_REG41_TDIE_ADC 0x41 +#define BQ25792_REG43_DP_ADC 0x43 +#define BQ25792_REG45_DM_ADC 0x45 +#define BQ25792_REG47_DPDM_DRIVER 0x47 +#define BQ25792_REG48_PART_INFORMATION 0x48 + +/* Minimal System Voltage */ +#define BQ25792_REG00_VSYSMIN_MASK GENMASK(5, 0) + +#define BQ25792_MINVSYS_MIN_UV 2500000 +#define BQ25792_MINVSYS_STEP_UV 250000 +#define BQ25792_MINVSYS_MAX_UV 16000000 + +/* Charge Voltage Limit */ +#define BQ25792_REG01_VREG_MASK GENMASK(10, 0) + +#define BQ25792_VBATREG_MIN_UV 3000000 +#define BQ25792_VBATREG_STEP_UV 10000 +#define BQ25792_VBATREG_MAX_UV 18800000 + +/* Charge Current Limit */ +#define BQ25792_REG03_ICHG_MASK GENMASK(8, 0) + +#define BQ25792_ICHG_MIN_UA 50000 +#define BQ25792_ICHG_STEP_UA 10000 +#define BQ25792_ICHG_MAX_UA 5000000 + +/* Input Voltage Limit */ +#define BQ25792_REG05_VINDPM_MASK GENMASK(7, 0) + +/* Input Current Limit */ +#define BQ25792_REG06_IINDPM_MASK GENMASK(8, 0) +#define BQ25792_IINDPM_DEFAULT_UA 3000000 +#define BQ25792_IINDPM_STEP_UA 10000 +#define BQ25792_IINDPM_MIN_UA 100000 +#define BQ25792_IINDPM_MAX_UA 3300000 + +/* Precharge Control */ +#define BQ25792_REG08_VBAT_LOWV_MASK GENMASK(7, 6) +#define BQ25792_REG08_IPRECHG_MASK GENMASK(5, 0) + +/* Termination Control */ +#define BQ25792_REG09_REG_RST BIT(6) +#define BQ25792_REG09_ITERM_MASK GENMASK(4, 0) + +/* Re-charge Control */ +#define BQ25792_REG0A_CELL_MASK GENMASK(7, 6) +#define BQ25792_REG0A_TRECHG_MASK GENMASK(5, 4) +#define BQ25792_REG0A_VRECHG_MASK GENMASK(3, 0) + +/* VOTG regulation */ +#define BQ25792_REG0B_VOTG_MASK GENMASK(10, 0) + +#define BQ25792_OTG_VOLT_MIN_UV 2800000 +#define BQ25792_OTG_VOLT_STEP_UV 10000 +#define BQ25792_OTG_VOLT_MAX_UV 22000000 +#define BQ25792_OTG_VOLT_NUM_VOLT ((BQ25792_OTG_VOLT_MAX_UV \ + - BQ25792_OTG_VOLT_MIN_UV) \ + / BQ25792_OTG_VOLT_STEP_UV + 1) + +/* IOTG regulation */ +#define BQ25792_REG0D_PRECHG_TMR BIT(7) +#define BQ25792_REG0D_IOTG_MASK GENMASK(6, 0) + +#define BQ25792_OTG_CUR_MIN_UA 120000 +#define BQ25792_OTG_CUR_STEP_UA 40000 +#define BQ25792_OTG_CUR_MAX_UA 3320000 + +/* Timer Control */ +#define BQ25792_REG0E_TOPOFF_TMR_MASK GENMASK(7, 6) +#define BQ25792_REG0E_EN_TRICHG_TMR BIT(5) +#define BQ25792_REG0E_EN_PRECHG_TMR BIT(4) +#define BQ25792_REG0E_EN_CHG_TMR BIT(3) +#define BQ25792_REG0E_CHG_TMR_MASK GENMASK(2, 1) +#define BQ25792_REG0E_TMR2X_EN BIT(0) + +/* Charger Control 0 */ +#define BQ25792_REG0F_EN_AUTO_IBATDIS BIT(7) +#define BQ25792_REG0F_FORCE_IBATDIS BIT(6) +#define BQ25792_REG0F_EN_CHG BIT(5) +#define BQ25792_REG0F_EN_ICO BIT(4) +#define BQ25792_REG0F_FORCE_ICO BIT(3) +#define BQ25792_REG0F_EN_HIZ BIT(2) +#define BQ25792_REG0F_EN_TERM BIT(1) +/* bit0 reserved */ + +/* Charger Control 1 */ +#define BQ25792_REG10_VAC_OVP_MASK GENMASK(5, 4) +#define BQ25792_REG10_WD_RST BIT(3) +#define BQ25792_REG10_WATCHDOG_MASK GENMASK(2, 0) + +/* Charger Control 2 */ +#define BQ25792_REG11_FORCE_INDET BIT(7) +#define BQ25792_REG11_AUTO_INDET_EN BIT(6) +#define BQ25792_REG11_EN_12V BIT(5) +#define BQ25792_REG11_EN_9V BIT(4) +#define BQ25792_REG11_HVDCP_EN BIT(3) +#define BQ25792_REG11_SDRV_CTRL_MASK GENMASK(2, 1) +#define BQ25792_REG11_SDRV_DLY BIT(0) + +/* Charger Control 3 */ +#define BQ25792_REG12_DIS_ACDRV BIT(7) +#define BQ25792_REG12_EN_OTG BIT(6) +#define BQ25792_REG12_PFM_OTG_DIS BIT(5) +#define BQ25792_REG12_PFM_FWD_DIS BIT(4) +#define BQ25792_REG12_WKUP_DLY BIT(3) +#define BQ25792_REG12_DIS_LDO BIT(2) +#define BQ25792_REG12_DIS_OTG_OOA BIT(1) +#define BQ25792_REG12_DIS_FWD_OOA BIT(0) + +/* Charger Control 4 */ +#define BQ25792_REG13_EN_ACDRV2 BIT(7) +#define BQ25792_REG13_EN_ACDRV1 BIT(6) +#define BQ25792_REG13_PWM_FREQ BIT(5) +#define BQ25792_REG13_DIS_STAT BIT(4) +#define BQ25792_REG13_DIS_VSYS_SHORT BIT(3) +#define BQ25792_REG13_DIS_VOTG_UVP BIT(2) +#define BQ25792_REG13_FORCE_VINDPM_DET BIT(1) +#define BQ25792_REG13_EN_IBUS_OCP BIT(0) + +/* Charger Control 5 */ +#define BQ25792_REG14_SFET_PRESENT BIT(7) +/* bit6 reserved */ +#define BQ25792_REG14_EN_IBAT BIT(5) +#define BQ25792_REG14_IBAT_REG_MASK GENMASK(4, 3) +#define BQ25792_REG14_EN_IINDPM BIT(2) +#define BQ25792_REG14_EN_EXTILIM BIT(1) +#define BQ25792_REG14_EN_BATOC BIT(0) + +#define BQ25792_IBAT_3A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 0) +#define BQ25792_IBAT_4A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 1) +#define BQ25792_IBAT_5A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 2) +#define BQ25792_IBAT_UNLIM FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 3) + +/* Temperature Control */ +#define BQ25792_REG16_TREG_MASK GENMASK(7, 6) +#define BQ25792_REG16_TSHUT_MASK GENMASK(5, 4) +#define BQ25792_REG16_VBUS_PD_EN BIT(3) +#define BQ25792_REG16_VAC1_PD_EN BIT(2) +#define BQ25792_REG16_VAC2_PD_EN BIT(1) + +/* NTC Control 0 */ +#define BQ25792_REG17_JEITA_VSET_MASK GENMASK(7, 5) +#define BQ25792_REG17_JEITA_ISETH_MASK GENMASK(4, 3) +#define BQ25792_REG17_JEITA_ISETC_MASK GENMASK(2, 1) + +/* NTC Control 1 */ +#define BQ25792_REG18_TS_COOL_MASK GENMASK(7, 6) +#define BQ25792_REG18_TS_WARM_MASK GENMASK(5, 4) +#define BQ25792_REG18_BHOT_MASK GENMASK(3, 2) +#define BQ25792_REG18_BCOLD BIT(1) +#define BQ25792_REG18_TS_IGNORE BIT(0) + +/* ICO Current Limit */ +#define BQ25792_REG19_ICO_ILIM_MASK GENMASK(8, 0) + +/* Charger Status 0 */ +#define BQ25792_REG1B_IINDPM_STAT BIT(7) +#define BQ25792_REG1B_VINDPM_STAT BIT(6) +#define BQ25792_REG1B_WD_STAT BIT(5) +#define BQ25792_REG1B_POORSRC_STAT BIT(4) +#define BQ25792_REG1B_PG_STAT BIT(3) +#define BQ25792_REG1B_AC2_PRESENT_STAT BIT(2) +#define BQ25792_REG1B_AC1_PRESENT_STAT BIT(1) +#define BQ25792_REG1B_VBUS_PRESENT_STAT BIT(0) + +/* Charger Status 1 */ +#define BQ25792_REG1C_CHG_STAT_MASK GENMASK(7, 5) +#define BQ25792_REG1C_VBUS_STAT_MASK GENMASK(4, 1) +#define BQ25792_REG1C_BC12_DONE_STAT BIT(0) + +/* Charger Status 2 */ +#define BQ25792_REG1D_ICO_STAT_MASK GENMASK(7, 6) +#define BQ25792_REG1D_TREG_STAT BIT(2) +#define BQ25792_REG1D_DPDM_STAT BIT(1) +#define BQ25792_REG1D_VBAT_PRESENT_STAT BIT(0) + +/* Charger Status 3 */ +#define BQ25792_REG1E_ACRB2_STAT BIT(7) +#define BQ25792_REG1E_ACRB1_STAT BIT(6) +#define BQ25792_REG1E_ADC_DONE_STAT BIT(5) +#define BQ25792_REG1E_VSYS_STAT BIT(4) +#define BQ25792_REG1E_CHG_TMR_STAT BIT(3) +#define BQ25792_REG1E_TRICHG_TMR_STAT BIT(2) +#define BQ25792_REG1E_PRECHG_TMR_STAT BIT(1) + +/* Charger Status 4 */ +#define BQ25792_REG1F_VBATOTG_LOW_STAT BIT(4) +#define BQ25792_REG1F_TS_COLD_STAT BIT(3) +#define BQ25792_REG1F_TS_COOL_STAT BIT(2) +#define BQ25792_REG1F_TS_WARM_STAT BIT(1) +#define BQ25792_REG1F_TS_HOT_STAT BIT(0) + +/* FAULT Status 0 */ +#define BQ25792_REG20_IBAT_REG_STAT BIT(7) +#define BQ25792_REG20_VBUS_OVP_STAT BIT(6) +#define BQ25792_REG20_VBAT_OVP_STAT BIT(5) +#define BQ25792_REG20_IBUS_OCP_STAT BIT(4) +#define BQ25792_REG20_IBAT_OCP_STAT BIT(3) +#define BQ25792_REG20_CONV_OCP_STAT BIT(2) +#define BQ25792_REG20_VAC2_OVP_STAT BIT(1) +#define BQ25792_REG20_VAC1_OVP_STAT BIT(0) + +#define BQ25792_REG20_OVERVOLTAGE_MASK (BQ25792_REG20_VBUS_OVP_STAT | \ + BQ25792_REG20_VBAT_OVP_STAT | \ + BQ25792_REG20_VAC2_OVP_STAT | \ + BQ25792_REG20_VAC1_OVP_STAT) +#define BQ25792_REG20_OVERCURRENT_MASK (BQ25792_REG20_IBUS_OCP_STAT | \ + BQ25792_REG20_IBAT_OCP_STAT | \ + BQ25792_REG20_CONV_OCP_STAT) + +/* FAULT Status 1 */ +#define BQ25792_REG21_VSYS_SHORT_STAT BIT(7) +#define BQ25792_REG21_VSYS_OVP_STAT BIT(6) +#define BQ25792_REG21_OTG_OVP_STAT BIT(5) +#define BQ25792_REG21_OTG_UVP_STAT BIT(4) +#define BQ25792_REG21_TSHUT_STAT BIT(2) + + +/* Charger Flag 0 */ +#define BQ25792_REG22_IINDPM_FLAG BIT(7) +#define BQ25792_REG22_VINDPM_FLAG BIT(6) +#define BQ25792_REG22_WD_FLAG BIT(5) +#define BQ25792_REG22_POORSRC_FLAG BIT(4) +#define BQ25792_REG22_PG_FLAG BIT(3) +#define BQ25792_REG22_AC2_PRESENT_FLAG BIT(2) +#define BQ25792_REG22_AC1_PRESENT_FLAG BIT(1) +#define BQ25792_REG22_VBUS_PRESENT_FLAG BIT(0) + +/* Charger Flag 1 */ +#define BQ25792_REG23_CHG_FLAG BIT(7) +#define BQ25792_REG23_ICO_FLAG BIT(6) +#define BQ25792_REG23_VBUS_FLAG BIT(4) +#define BQ25792_REG23_TREG_FLAG BIT(2) +#define BQ25792_REG23_VBAT_PRESENT_FLAG BIT(1) +#define BQ25792_REG23_BC12_DONE_FLAG BIT(0) + +/* Charger Flag 2 */ +#define BQ25792_REG24_DPDM_DONE_FLAG BIT(6) +#define BQ25792_REG24_ADC_DONE_FLAG BIT(5) +#define BQ25792_REG24_VSYS_FLAG BIT(4) +#define BQ25792_REG24_CHG_TMR_FLAG BIT(3) +#define BQ25792_REG24_TRICHG_TMR_FLAG BIT(2) +#define BQ25792_REG24_PRECHG_TMR_FLAG BIT(1) +#define BQ25792_REG24_TOPOFF_TMR_FLAG BIT(0) + +/* Charger Flag 3 */ +#define BQ25792_REG25_VBATOTG_LOW_FLAG BIT(4) +#define BQ25792_REG25_TS_COLD_FLAG BIT(3) +#define BQ25792_REG25_TS_COOL_FLAG BIT(2) +#define BQ25792_REG25_TS_WARM_FLAG BIT(1) +#define BQ25792_REG25_TS_HOT_FLAG BIT(0) + +/* FAULT Flag 0 */ +#define BQ25792_REG26_IBAT_REG_FLAG BIT(7) +#define BQ25792_REG26_VBUS_OVP_FLAG BIT(6) +#define BQ25792_REG26_VBAT_OVP_FLAG BIT(5) +#define BQ25792_REG26_IBUS_OCP_FLAG BIT(4) +#define BQ25792_REG26_IBAT_OCP_FLAG BIT(3) +#define BQ25792_REG26_CONV_OCP_FLAG BIT(2) +#define BQ25792_REG26_VAC2_OVP_FLAG BIT(1) +#define BQ25792_REG26_VAC1_OVP_FLAG BIT(0) + +/* FAULT Flag 1 */ +#define BQ25792_REG27_VSYS_SHORT_FLAG BIT(7) +#define BQ25792_REG27_VSYS_OVP_FLAG BIT(6) +#define BQ25792_REG27_OTG_OVP_FLAG BIT(5) +#define BQ25792_REG27_OTG_UVP_FLAG BIT(4) +#define BQ25792_REG27_TSHUT_FLAG BIT(2) + +/* Charger Mask 0 */ +#define BQ25792_REG28_IINDPM_MASK BIT(7) +#define BQ25792_REG28_VINDPM_MASK BIT(6) +#define BQ25792_REG28_WD_MASK BIT(5) +#define BQ25792_REG28_POORSRC_MASK BIT(4) +#define BQ25792_REG28_PG_MASK BIT(3) +#define BQ25792_REG28_AC2_PRESENT_MASK BIT(2) +#define BQ25792_REG28_AC1_PRESENT_MASK BIT(1) +#define BQ25792_REG28_VBUS_PRESENT_MASK BIT(0) + +/* Charger Mask 1 */ +#define BQ25792_REG29_CHG_MASK BIT(7) +#define BQ25792_REG29_ICO_MASK BIT(6) +#define BQ25792_REG29_VBUS_MASK BIT(4) +#define BQ25792_REG29_TREG_MASK BIT(2) +#define BQ25792_REG29_VBAT_PRESENT_MASK BIT(1) +#define BQ25792_REG29_BC12_DONE_MASK BIT(0) + +/* Charger Mask 2 */ +#define BQ25792_REG2A_DPDM_DONE_MASK BIT(6) +#define BQ25792_REG2A_ADC_DONE_MASK BIT(5) +#define BQ25792_REG2A_VSYS_MASK BIT(4) +#define BQ25792_REG2A_CHG_TMR_MASK BIT(3) +#define BQ25792_REG2A_TRICHG_TMR_MASK BIT(2) +#define BQ25792_REG2A_PRECHG_TMR_MASK BIT(1) +#define BQ25792_REG2A_TOPOFF_TMR_MASK BIT(0) + +/* Charger Mask 3 */ +#define BQ25792_REG2B_VBATOTG_LOW_MASK BIT(4) +#define BQ25792_REG2B_TS_COLD_MASK BIT(3) +#define BQ25792_REG2B_TS_COOL_MASK BIT(2) +#define BQ25792_REG2B_TS_WARM_MASK BIT(1) +#define BQ25792_REG2B_TS_HOT_MASK BIT(0) + +/* FAULT Mask 0 */ +#define BQ25792_REG2C_IBAT_REG_MASK BIT(7) +#define BQ25792_REG2C_VBUS_OVP_MASK BIT(6) +#define BQ25792_REG2C_VBAT_OVP_MASK BIT(5) +#define BQ25792_REG2C_IBUS_OCP_MASK BIT(4) +#define BQ25792_REG2C_IBAT_OCP_MASK BIT(3) +#define BQ25792_REG2C_CONV_OCP_MASK BIT(2) +#define BQ25792_REG2C_VAC2_OVP_MASK BIT(1) +#define BQ25792_REG2C_VAC1_OVP_MASK BIT(0) + +/* FAULT Mask 1 */ +#define BQ25792_REG2D_VSYS_SHORT_MASK BIT(7) +#define BQ25792_REG2D_VSYS_OVP_MASK BIT(6) +#define BQ25792_REG2D_OTG_OVP_MASK BIT(5) +#define BQ25792_REG2D_OTG_UVP_MASK BIT(4) +#define BQ25792_REG2D_TSHUT_MASK BIT(2) + +/* ADC Control */ +#define BQ25792_REG2E_ADC_EN BIT(7) +#define BQ25792_REG2E_ADC_RATE BIT(6) +#define BQ25792_REG2E_ADC_SAMPLE_MASK GENMASK(5, 4) +#define BQ25792_REG2E_ADC_AVG BIT(3) +#define BQ25792_REG2E_ADC_AVG_INIT BIT(2) + +/* ADC Function Disable 0 */ +#define BQ25792_REG2F_IBUS_ADC_DIS BIT(7) +#define BQ25792_REG2F_IBAT_ADC_DIS BIT(6) +#define BQ25792_REG2F_VBUS_ADC_DIS BIT(5) +#define BQ25792_REG2F_VBAT_ADC_DIS BIT(4) +#define BQ25792_REG2F_VSYS_ADC_DIS BIT(3) +#define BQ25792_REG2F_TS_ADC_DIS BIT(2) +#define BQ25792_REG2F_TDIE_ADC_DIS BIT(1) + +/* ADC Function Disable 1 */ +#define BQ25792_REG30_DP_ADC_DIS BIT(7) +#define BQ25792_REG30_DM_ADC_DIS BIT(6) +#define BQ25792_REG30_VAC2_ADC_DIS BIT(5) +#define BQ25792_REG30_VAC1_ADC_DIS BIT(4) + +/* 0x31-0x45: ADC result registers (16-bit, RO): single full-width field */ + +#define BQ25792_ADCVSYSVBAT_STEP_UV 1000 +#define BQ25792_ADCIBAT_STEP_UA 1000 + +/* DPDM Driver */ +#define BQ25792_REG47_DPLUS_DAC_MASK GENMASK(7, 5) +#define BQ25792_REG47_DMINUS_DAC_MASK GENMASK(4, 2) + +/* Part Information */ +#define BQ25792_REG48_PN_MASK GENMASK(5, 3) +#define BQ25792_REG48_DEV_REV_MASK GENMASK(2, 0) + struct bq257xx_device { struct i2c_client *client; struct regmap *regmap; }; + +enum bq257xx_type { + BQ25703A, + BQ25792, +}; + +struct bq257xx_plat { + enum bq257xx_type type; +}; --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786043B4E89 for ; Fri, 6 Mar 2026 14:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807620; cv=none; b=fTEcxZs48hnBxE69tUhZ5NBDL2vLxVnygxGB9Qq9ki507N+z8z2rBW4ZkdWg6b7D6y2PtMXXeCrHxo+HK7u4npgcwQsrGTiCDZUik7dBt+oCGNlWbq9f7s9bwaFFRoeMxiBF9hApsPel8xbfCq1jq7vbfSyX3Epk/O0V3/j75uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807620; c=relaxed/simple; bh=iH5mpCf1lNBTH6mjGzgCdLsQQcgDZGR7r/s9cFLXbD4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O9Rnpf0jjDc/EfEEVjpEWgdfyChVicb5/HBzwiksot0mzgpguPwrRcd87pNAUGc4AqVRQtPCFPEQuP3A8Yy1900as60Ljome9yk9l7S0lcIRWJtVoibz9hxmGSefH41XVxPv5tjSqjIIn7nuq8psjf3s5HjAA1zjzGrc3wJrb8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=EHEicgfh; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="EHEicgfh" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-439b9b1900bso4196853f8f.1 for ; Fri, 06 Mar 2026 06:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807617; x=1773412417; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=T0cRGptLewZHd2CZtw6bpbZKdXjz61WL20vAMVdyWWU=; b=EHEicgfhBtREb/Vi9Ic9IMxHIl8FecUoWj5Pkf5l8I/xiAXsVol2jb90er5dBg2/iX 1Yqo8Cx8g7rwTqV9yJODNIrVQiXXliwGU/u9x0aQLkQqEm6yAwZ0cU6hux/hYL0ynQXd 0l0scUTxgoFn2D6tzjtNPd1fxdqT3S3W/I30G3YLwyzJZ6s5Peg7V9WT8holdQvucTrZ yEqmXk4pydWnUxR6QaS1+SDW7wHTDt0MiwGWDA0pIxhQlcHYcyskpW2X2ZriqjcnIh+w mP/s8M7UpdSj3PzNjkUROzerDSNUyWCayG2KT5QXIkCSTVx6zb14f9UJ84a7XmDQgGeg 9EBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807617; x=1773412417; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=T0cRGptLewZHd2CZtw6bpbZKdXjz61WL20vAMVdyWWU=; b=YvXAsQBAI/eDAItYg7JYad2cptElyN3jkoDTS4MsuXvrYFZoGisEQgzjZSMBIymrEz 4mGk9ybwZo1iZhfJJuNlpAZvm+2WFr47y+E/PPDe5WnhihyswxRiGPJ/PPLIFXufqKwo fa+HcUfqSV34ooOkEpJgT8eeDNyMSRNTfijokJj68s4e6ljiMOnwh7qqTzW/50yXdSsA GAsV97LfeVakpmtMKEGizd+ZQ05OmS0/9JWcumhORirb+9rrSatRI+mx41hjkBkrOI4+ KMPlUYs8p1EQzRUbPOMqOknL0VM9a8zY/FiXWz3pPLHOpfoP4AxzfARo6tpWx5bQC9y7 EFKg== X-Forwarded-Encrypted: i=1; AJvYcCXGVo5D2DUE/EmHgg+yOFuvmwxyRPMO7cdgVhFDvga/ATIa0APxX9URVjiGVeQgi2uveQ9HfjFs2v+dDNk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn67N9Fb3HlMBkb0Ff/SKHnsAVoPqXykKo7OKlR5j8o6ik9Qe/ JkG5O744LojJWsSszgcmWbbmcXkK/Sfr6mtLGSJbe0McqkR9+mSpvUI6zQ48gElclTU= X-Gm-Gg: ATEYQzx9xOw+s3ArJe6fEmmbM6VNk5PnkiZJYhVkmwtb7JjMJsKkbbetWy2aNZjz2FG 81VcVRs19WI+bq1YwA4owEJGLdLvvh+89nWnPeZ+1uQL8HmodqVS+ffqldIvROSkM4v8AzTiTwR bJagiwO0Tsf2FPWznIBg2jngrf+j8LSBK1jpD2DUWmFtMDkTYI6f+erQkZqkvlV/ceSkpIJrTNg oKc3Hpp9NhX+5tqMO2MAwUZotMc4xunxegCiPtC8FQSPh+Y12vFDD/pR01ip/jQ1QmXuZ5OpdrW qg8IzoHD6RrLlJKVt8D8IURBKKEy0AOkLn+CFbttjr/LR8QWkxqCOjYSCo9+fl9XWw0JfTa6wQi c4k9E8oFpalblRgqHuClVm2bkvUMr0ywXHNUJMYz/1z8/95BlE1iJ5qvAA9elDkzPNYrkdBj0jj 4E21l8e/1ncS6ZbAYbSZ8ObuT5+jvC4uzmlYJf4KT4inPlPGPYs21DzHrrrY7oEocWca4u1NMD+ JanBO+KAV/ObhmZ X-Received: by 2002:a05:6000:40dd:b0:439:cb5c:b18d with SMTP id ffacd0b85a97d-439da893f6cmr3957280f8f.38.1772807616798; Fri, 06 Mar 2026 06:33:36 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:36 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:10 +0400 Subject: [PATCH v2 10/11] regulator: bq257xx: Add support for BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-10-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4990; i=alchark@flipper.net; h=from:subject:message-id; bh=iH5mpCf1lNBTH6mjGzgCdLsQQcgDZGR7r/s9cFLXbD4=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerrk+fbfLw5xPD91xffVs7epM0IucG5JCu2tmqA0U 2fVK7sVZzsmsjCIcTFYiimyzP22xHaqEd+sXR4eX2HmsDKBDJEWaWAAAhYGvtzEvFIjHSM9U21D PUNDHWMdIwYuTgGYavFTDP/zPh5co3L3hPTPU1pvG7Ptvgp23r7zTOTAHbUlbAtkq7+/YfjvWHd s12uZidMyi1wa8pntIsOuzlv+51TqPktte8YH/P9YAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add support for TI BQ25792, an integrated battery charger and buck/boost regulator. This enables VBUS output from the charger's boost converter for use in USB OTG applications, supporting 2.8-22V output at up to 3.32A with 10mV and 40mA resolution. Signed-off-by: Alexey Charkov Acked-by: Mark Brown --- drivers/regulator/bq257xx-regulator.c | 98 +++++++++++++++++++++++++++++++= +++- 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 0bb58ab4b8d4..61911ac8613a 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -31,6 +31,32 @@ static int bq25703_vbus_get_cur_limit(struct regulator_d= ev *rdev) return FIELD_GET(BQ25703_OTG_CUR_MASK, reg) * BQ25703_OTG_CUR_STEP_UA; } =20 +static int bq25792_vbus_get_cur_limit(struct regulator_dev *rdev) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + int ret; + unsigned int reg; + + ret =3D regmap_read(regmap, BQ25792_REG0D_IOTG_REGULATION, ®); + if (ret) + return ret; + return FIELD_GET(BQ25792_REG0D_IOTG_MASK, reg) * BQ25792_OTG_CUR_STEP_UA; +} + +static int bq25792_vbus_get_voltage_sel(struct regulator_dev *rdev) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + __be16 reg; + int ret; + + ret =3D regmap_raw_read(regmap, BQ25792_REG0B_VOTG_REGULATION, + ®, sizeof(reg)); + if (ret) + return ret; + + return FIELD_GET(BQ25792_REG0B_VOTG_MASK, be16_to_cpu(reg)); +} + /* * Check if the minimum current and maximum current requested are * sane values, then set the register accordingly. @@ -54,6 +80,37 @@ static int bq25703_vbus_set_cur_limit(struct regulator_d= ev *rdev, FIELD_PREP(BQ25703_OTG_CUR_MASK, reg)); } =20 +static int bq25792_vbus_set_cur_limit(struct regulator_dev *rdev, + int min_uA, int max_uA) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + unsigned int reg; + + if ((min_uA > BQ25792_OTG_CUR_MAX_UA) || + (max_uA < BQ25792_OTG_CUR_MIN_UA)) + return -EINVAL; + + reg =3D (max_uA / BQ25792_OTG_CUR_STEP_UA); + + /* Catch rounding errors since our step is 40000uA. */ + if ((reg * BQ25792_OTG_CUR_STEP_UA) < min_uA) + return -EINVAL; + + return regmap_write(regmap, BQ25792_REG0D_IOTG_REGULATION, + FIELD_PREP(BQ25792_REG0D_IOTG_MASK, reg)); +} + +static int bq25792_vbus_set_voltage_sel(struct regulator_dev *rdev, + unsigned int sel) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + __be16 reg; + + reg =3D cpu_to_be16(FIELD_PREP(BQ25792_REG0B_VOTG_MASK, sel)); + return regmap_raw_write(regmap, BQ25792_REG0B_VOTG_REGULATION, + ®, sizeof(reg)); +} + static int bq25703_vbus_enable(struct regulator_dev *rdev) { struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); @@ -101,6 +158,34 @@ static const struct regulator_desc bq25703_vbus_desc = =3D { .vsel_mask =3D BQ25703_OTG_VOLT_MASK, }; =20 +static const struct regulator_ops bq25792_vbus_ops =3D { + /* No GPIO for enabling the OTG regulator */ + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .list_voltage =3D regulator_list_voltage_linear, + .get_voltage_sel =3D bq25792_vbus_get_voltage_sel, + .set_voltage_sel =3D bq25792_vbus_set_voltage_sel, + .get_current_limit =3D bq25792_vbus_get_cur_limit, + .set_current_limit =3D bq25792_vbus_set_cur_limit, +}; + +static const struct regulator_desc bq25792_vbus_desc =3D { + .name =3D "vbus", + .of_match =3D of_match_ptr("vbus"), + .regulators_node =3D of_match_ptr("regulators"), + .type =3D REGULATOR_VOLTAGE, + .owner =3D THIS_MODULE, + .ops =3D &bq25792_vbus_ops, + .min_uV =3D BQ25792_OTG_VOLT_MIN_UV, + .uV_step =3D BQ25792_OTG_VOLT_STEP_UV, + .n_voltages =3D BQ25792_OTG_VOLT_NUM_VOLT, + .enable_mask =3D BQ25792_REG12_EN_OTG, + .enable_reg =3D BQ25792_REG12_CHARGER_CONTROL_3, + .enable_val =3D BQ25792_REG12_EN_OTG, + .disable_val =3D 0, +}; + /* Get optional GPIO for OTG regulator enable. */ static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) { @@ -141,6 +226,7 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_d= evice *pdev) static int bq257xx_regulator_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; + struct bq257xx_plat *plat =3D dev_get_platdata(dev); struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; @@ -153,7 +239,17 @@ static int bq257xx_regulator_probe(struct platform_dev= ice *pdev) if (!pdata) return -ENOMEM; =20 - pdata->desc =3D bq25703_vbus_desc; + switch (plat->type) { + case BQ25703A: + pdata->desc =3D bq25703_vbus_desc; + break; + case BQ25792: + pdata->desc =3D bq25792_vbus_desc; + break; + default: + return dev_err_probe(&pdev->dev, -EINVAL, + "Unsupported device type\n"); + } =20 platform_set_drvdata(pdev, pdata); bq257xx_reg_dt_parse_gpio(pdev); --=20 2.52.0 From nobody Thu Apr 9 18:41:05 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50B693B52E3 for ; Fri, 6 Mar 2026 14:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807624; cv=none; b=oUCnbgxgimU4KvPr0v1K26CaJwR/0ipzhXHOau6mL9G/YmwMpR2zXzt6pwTRP0cgHnTaGxT+9mV2g9EJulvIQWrDLIz0XBMD6thgpSRxE5tQ7D1bJS8mZe5KHM7UTErRYl7bHLr45ZGko0oYZpmpUb9syUGF5pXiXtefzO7zQeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772807624; c=relaxed/simple; bh=2FRt1CMOeDBi+ujSYpU8g2MoZjv4gg2WASiAGR4BCTE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uXDNR6Q5qSW9UYB4Zaym1sxUE9l9s/JGeL3gEfKgP6F0bcP9Ky3EZWgT/mwWlvvokJD5RvLnwz/hpGADkFFywiOHJrn/LQWsn/3R7DJyFxHiw9HJvw7/vsMkcbI8w50eiX/ZMrZPurGWtAjiKKnzvBraQyb34y7aWyXqtym+SzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=KrpqSm2A; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="KrpqSm2A" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4327790c4e9so7154386f8f.2 for ; Fri, 06 Mar 2026 06:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772807621; x=1773412421; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IJMru6MZkUAstlWRCj83fHNH00MaKj2n7fewPDh1WhI=; b=KrpqSm2AqQbMEpZ97X7YBb9b9OYa0i7OK6dNVe1YJ8dAxQGXX6KbCY+JD0GA+lKrIS FR1Gishzf8zuimrT6agzkltVpaSmEihibPRZJFxwieX4qjOpKH1LctNA8Exou7zdXQPW kuYfx/LJnifxgy+B531A/+eYkoRG8tXq0kF8te+0aXzI02jkIbh5ey6no+ktRavcPE2M QNJ9rhwrb+kEt7eRyh87TqI4mCC7Wd528t1KmzgkN3EnVrYb/rwKiJSnicXevuiQ0+2g hDVV6Bnjv7Wb/N5RUu1Bx8tOytSpdo5zin0LrleKcZZWeeRbssEnzCacvx0WI1dlUHxD RVvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772807621; x=1773412421; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IJMru6MZkUAstlWRCj83fHNH00MaKj2n7fewPDh1WhI=; b=rgLcWFUzxDD2N44KVvxoMmQUUtezN8pXtjl8NTRYNdceia+VdQ8aOUF9s+MCs1f6No L8FIGZAUvgTSS8MDRn6u+9biFJMsMS48UUSsz64CjpDgRF0JILdE0m7vnW0EDzmBQU2J e8sBUw+O1YC3+DUrIUoqObba6ZPMqf8tLTYQTHUrMzaezMwl2HlLGia0hXJVIlG8edyb M4K+Z7Wt/S3dYSImzdHXkm0H/balVV6R8LKLyb2N0PjAKBl3dCI//wJqjAYDmUEtXXLM mgA9TGE/y706SOC0C9sOQXA1Twnei9FAU83U9EzqCLF5zQTY3TnmMkorl6ZxZQgnKrxY X7mA== X-Forwarded-Encrypted: i=1; AJvYcCXx3QOSLoIfV6n1wAL7yEMunBHGrbCwjk+i+MBENJfyX9FuFC5Gc5vVcky0oRMfsyPIFmiNO5Bo1AoQbR4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMBMSJsD4WdlQj30uHNzajV8NBjHlqbKyUScgeIYz/50Bsgsfx YlQPwHc5ZSmQVGbBPuB5bozKmbPkaQvqm2+t8WEz+vpiUkeqLJG2VPQNMlp8oIaHjkQ= X-Gm-Gg: ATEYQzy7sNz9PtZ5291GQnZbuRYqaNsmrw52/vSQgBQz33FWVeJpjlhp5Z9/IWXrOsy xOg3eJhumGYIZVV2xWO/g7f9wwmlFcZ7jr5Xlb0MiJRxqZ4MdcqdKDuI2Jkykuo6Wp3USKZ79wA rryX9dzPmk+aVAAd8AGCvoMNw4Ta8sgpUUdwcnJHZWuDGEsbfy4nc/39N0VPPW+sM8PQBwkt5Q4 VSl+96Y+Ej0x3nRJYqAIlBbywLG+GmRG4C/HRpBTMsi3vNPYcoYnE7siIVZ4GpPJjozkERrpHOA VVrrwrCvbDK7anaRSVVHxJZZ1Vgj4ajcYgvoCHpssutIrSWdQVgdP0A5mqFhKTIPE+qR/kI4euv q0KUrEVMoc4X9gnBBnJaSTRt/MBpE5Kq2XiImPF25qYCCfqfE1cqnoTsdAn03zRHMH/kf5ZiBGq c5WFmk3aiEYeu/kBSPY0DqM5r0veC1aFQG0yMKu/mLcqaUmcwl4cNNKZDXPtVy6NQE+MuuTfOql q9xsw== X-Received: by 2002:a05:6000:228a:b0:439:c202:99aa with SMTP id ffacd0b85a97d-439da885b6dmr4425282f8f.38.1772807619433; Fri, 06 Mar 2026 06:33:39 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm4635281f8f.2.2026.03.06.06.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 06:33:39 -0800 (PST) From: Alexey Charkov Date: Fri, 06 Mar 2026 18:33:11 +0400 Subject: [PATCH v2 11/11] power: supply: bq257xx: Add support for BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260306-bq25792-v2-11-6595249d6e6f@flipper.net> References: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> In-Reply-To: <20260306-bq25792-v2-0-6595249d6e6f@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=22800; i=alchark@flipper.net; h=from:subject:message-id; bh=2FRt1CMOeDBi+ujSYpU8g2MoZjv4gg2WASiAGR4BCTE=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuerpE6XUex9WfJ50S7f1C1x1LNo+12v/s7betn6JEl or7T5t3qmMiC4MYF4OlmCLL3G9LbKca8c3a5eHxFWYOKxPIEGmRBgYgYGHgy03MKzXSMdIz1TbU MzTUMdYxYuDiFICpzuVl+B9/n336LasXl1/khDTtjEjz8F0k4f9nQ8hNx986DxdbbHNl+F+3b8G OkrKDnyxtdqk+63739My7H3tyruSvv5dzovnQxCx2AA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add support for TI BQ25792 integrated battery charger and buck-boost converter. It shares high-level logic of operation with the already supported BQ25703A, but has a different register map, bit definitions and some of the lower-level hardware states. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 491 +++++++++++++++++++++++++++++= +++- include/linux/mfd/bq257xx.h | 6 +- 2 files changed, 492 insertions(+), 5 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 951abd035fc5..55337a9607fc 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -5,6 +5,7 @@ */ =20 #include +#include #include #include #include @@ -18,12 +19,19 @@ struct bq257xx_chg; =20 /** * struct bq257xx_chip_info - chip specific routines + * @default_iindpm_uA: default input current limit in microamps * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware + * @bq257xx_get_ichg: get maximum charge current (in uA) * @bq257xx_set_ichg: set maximum charge current (in uA) + * @bq257xx_get_vbatreg: get maximum charge voltage (in uV) * @bq257xx_set_vbatreg: set maximum charge voltage (in uV) + * @bq257xx_get_iindpm: get maximum input current (in uA) * @bq257xx_set_iindpm: set maximum input current (in uA) + * @bq257xx_get_cur: get battery current from ADC (in uA) + * @bq257xx_get_vbat: get battery voltage from ADC (in uV) + * @bq257xx_get_min_vsys: get minimum system voltage (in uV) */ struct bq257xx_chip_info { int default_iindpm_uA; @@ -47,8 +55,10 @@ struct bq257xx_chip_info { * @bq: parent MFD device * @charger: power supply device * @online: charger input is present + * @charging: charger is actively charging the battery * @fast_charge: charger is in fast charge mode * @pre_charge: charger is in pre-charge mode + * @overvoltage: overvoltage fault detected * @ov_fault: charger reports over voltage fault * @batoc_fault: charger reports battery over current fault * @oc_fault: charger reports over current fault @@ -79,6 +89,53 @@ struct bq257xx_chg { u32 vsys_min; }; =20 +/** + * bq25792_read16() - Read a 16-bit value from device register + * @pdata: driver platform data + * @reg: register address to read from + * @val: pointer to store the register value + * + * Read a 16-bit big-endian value from the BQ25792 device via regmap + * and convert to CPU byte order. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_read16(struct bq257xx_chg *pdata, unsigned int reg, u16= *val) +{ + __be16 regval; + int ret; + + ret =3D regmap_raw_read(pdata->bq->regmap, reg, ®val, sizeof(regval)); + if (ret) + return ret; + + *val =3D be16_to_cpu(regval); + return 0; +} + +/** + * bq25792_write16() - Write a 16-bit value to device register + * @pdata: driver platform data + * @reg: register address to write to + * @val: 16-bit value to write in CPU byte order + * + * Convert the value to big-endian and write a 16-bit value to the + * BQ25792 device via regmap. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_write16(struct bq257xx_chg *pdata, unsigned int reg, u1= 6 val) +{ + __be16 regval =3D cpu_to_be16(val); + int ret; + + ret =3D regmap_raw_write(pdata->bq->regmap, reg, ®val, sizeof(regval)); + if (ret) + return ret; + + return 0; +} + /** * bq25703_get_state() - Get the current state of the device * @pdata: driver platform data @@ -110,6 +167,43 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) return 0; } =20 +/** + * bq25792_get_state() - Get the current state of the device + * @pdata: driver platform data + * + * Get the current state of the BQ25792 charger by reading status + * registers. Updates the online, charging, overvoltage, and fault + * status fields in the driver data structure. + * + * Return: Returns 0 on success or error on failure to read device. + */ +static int bq25792_get_state(struct bq257xx_chg *pdata) +{ + unsigned int reg; + int ret; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG1B_CHARGER_STATUS_0, &r= eg); + if (ret) + return ret; + + pdata->online =3D reg & BQ25792_REG1B_PG_STAT; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG1C_CHARGER_STATUS_1, &r= eg); + if (ret) + return ret; + + pdata->charging =3D reg & BQ25792_REG1C_CHG_STAT_MASK; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG20_FAULT_STATUS_0, ®= ); + if (ret) + return ret; + + pdata->overvoltage =3D reg & BQ25792_REG20_OVERVOLTAGE_MASK; + pdata->oc_fault =3D reg & BQ25792_REG20_OVERCURRENT_MASK; + + return 0; +} + /** * bq25703_get_min_vsys() - Get the minimum system voltage * @pdata: driver platform data @@ -133,6 +227,31 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pd= ata, int *intval) return ret; } =20 +/** + * bq25792_get_min_vsys() - Get the minimum system voltage + * @pdata: driver platform data + * @intval: pointer to store the minimum voltage value + * + * Read the current minimum system voltage setting from the device + * and return it in microvolts. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_get_min_vsys(struct bq257xx_chg *pdata, int *intval) +{ + unsigned int reg; + int ret; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG00_MIN_SYS_VOLTAGE, &re= g); + if (ret) + return ret; + + reg =3D FIELD_GET(BQ25792_REG00_VSYSMIN_MASK, reg); + *intval =3D (reg * BQ25792_MINVSYS_STEP_UV) + BQ25792_MINVSYS_MIN_UV; + + return ret; +} + /** * bq25703_set_min_vsys() - Set the minimum system voltage * @pdata: driver platform data @@ -157,6 +276,29 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pd= ata, int vsys) reg); } =20 +/** + * bq25792_set_min_vsys() - Set the minimum system voltage + * @pdata: driver platform data + * @vsys: voltage value to set in uV + * + * Set the minimum system voltage by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_min_vsys(struct bq257xx_chg *pdata, int vsys) +{ + unsigned int reg; + int vsys_min =3D pdata->vsys_min; + + vsys =3D clamp(vsys, vsys_min, BQ25792_MINVSYS_MAX_UV); + reg =3D ((vsys - BQ25792_MINVSYS_MIN_UV) / BQ25792_MINVSYS_STEP_UV); + reg =3D FIELD_PREP(BQ25792_REG00_VSYSMIN_MASK, reg); + + return regmap_write(pdata->bq->regmap, + BQ25792_REG00_MIN_SYS_VOLTAGE, reg); +} + /** * bq25703_get_cur() - Get the reported current from the battery * @pdata: driver platform data @@ -186,6 +328,30 @@ static int bq25703_get_cur(struct bq257xx_chg *pdata, = int *intval) return ret; } =20 +/** + * bq25792_get_cur() - Get the reported current from the battery + * @pdata: driver platform data + * @intval: pointer to store the battery current value + * + * Read the current ADC value from the device representing the battery + * charge or discharge current and return it in microamps. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_get_cur(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG33_IBAT_ADC, ®); + if (ret < 0) + return ret; + + *intval =3D (s16)reg * BQ25792_ADCIBAT_STEP_UA; + + return ret; +} + /** * bq25703_get_ichg_cur() - Get the maximum reported charge current * @pdata: driver platform data @@ -209,6 +375,30 @@ static int bq25703_get_ichg_cur(struct bq257xx_chg *pd= ata, int *intval) return ret; } =20 +/** + * bq25792_get_ichg_cur() - Get the maximum reported charge current + * @pdata: driver platform data + * @intval: pointer to store the maximum charge current value + * + * Read the programmed maximum charge current limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_ichg_cur(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG03_CHARGE_CURRENT_LIMIT, ®); + if (ret) + return ret; + + *intval =3D FIELD_GET(BQ25792_REG03_ICHG_MASK, reg) * + BQ25792_ICHG_STEP_UA; + + return ret; +} + /** * bq25703_set_ichg_cur() - Set the maximum charge current * @pdata: driver platform data @@ -233,6 +423,28 @@ static int bq25703_set_ichg_cur(struct bq257xx_chg *pd= ata, int ichg) reg); } =20 +/** + * bq25792_set_ichg_cur() - Set the maximum charge current + * @pdata: driver platform data + * @ichg: current value to set in uA + * + * Set the maximum charge current by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_ichg_cur(struct bq257xx_chg *pdata, int ichg) +{ + int ichg_max =3D pdata->ichg_max; + u16 reg; + + ichg =3D clamp(ichg, BQ25792_ICHG_MIN_UA, ichg_max); + reg =3D FIELD_PREP(BQ25792_REG03_ICHG_MASK, + (ichg / BQ25792_ICHG_STEP_UA)); + + return bq25792_write16(pdata, BQ25792_REG03_CHARGE_CURRENT_LIMIT, reg); +} + /** * bq25703_get_chrg_volt() - Get the maximum set charge voltage * @pdata: driver platform data @@ -256,6 +468,30 @@ static int bq25703_get_chrg_volt(struct bq257xx_chg *p= data, int *intval) return ret; } =20 +/** + * bq25792_get_chrg_volt() - Get the maximum set charge voltage + * @pdata: driver platform data + * @intval: pointer to store the maximum charge voltage value + * + * Read the current charge voltage limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_chrg_volt(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG01_CHARGE_VOLTAGE_LIMIT, ®); + if (ret) + return ret; + + *intval =3D FIELD_GET(BQ25792_REG01_VREG_MASK, reg) * + BQ25792_VBATREG_STEP_UV; + + return ret; +} + /** * bq25703_set_chrg_volt() - Set the maximum charge voltage * @pdata: driver platform data @@ -282,6 +518,29 @@ static int bq25703_set_chrg_volt(struct bq257xx_chg *p= data, int vbat) reg); } =20 +/** + * bq25792_set_chrg_volt() - Set the maximum charge voltage + * @pdata: driver platform data + * @vbat: voltage value to set in uV + * + * Set the maximum charge voltage by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_chrg_volt(struct bq257xx_chg *pdata, int vbat) +{ + int vbat_max =3D pdata->vbat_max; + u16 reg; + + vbat =3D clamp(vbat, BQ25792_VBATREG_MIN_UV, vbat_max); + + reg =3D FIELD_PREP(BQ25792_REG01_VREG_MASK, + (vbat / BQ25792_VBATREG_STEP_UV)); + + return bq25792_write16(pdata, BQ25792_REG01_CHARGE_VOLTAGE_LIMIT, reg); +} + /** * bq25703_get_iindpm() - Get the maximum set input current * @pdata: driver platform data @@ -310,6 +569,30 @@ static int bq25703_get_iindpm(struct bq257xx_chg *pdat= a, int *intval) return ret; } =20 +/** + * bq25792_get_iindpm() - Get the maximum set input current + * @pdata: driver platform data + * @intval: pointer to store the maximum input current value + * + * Read the current input current limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_iindpm(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG06_INPUT_CURRENT_LIMIT, ®); + if (ret) + return ret; + + reg =3D FIELD_GET(BQ25792_REG06_IINDPM_MASK, reg); + *intval =3D reg * BQ25792_IINDPM_STEP_UA; + + return ret; +} + /** * bq25703_set_iindpm() - Set the maximum input current * @pdata: driver platform data @@ -335,6 +618,29 @@ static int bq25703_set_iindpm(struct bq257xx_chg *pdat= a, int iindpm) FIELD_PREP(BQ25703_IINDPM_MASK, reg)); } =20 +/** + * bq25792_set_iindpm() - Set the maximum input current + * @pdata: driver platform data + * @iindpm: current value in uA + * + * Set the maximum input current by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_iindpm(struct bq257xx_chg *pdata, int iindpm) +{ + u16 reg; + int iindpm_max =3D pdata->iindpm_max; + + iindpm =3D clamp(iindpm, BQ25792_IINDPM_MIN_UA, iindpm_max); + + reg =3D iindpm / BQ25792_IINDPM_STEP_UA; + + return bq25792_write16(pdata, BQ25792_REG06_INPUT_CURRENT_LIMIT, + FIELD_PREP(BQ25792_REG06_IINDPM_MASK, reg)); +} + /** * bq25703_get_vbat() - Get the reported voltage from the battery * @pdata: driver platform data @@ -359,6 +665,30 @@ static int bq25703_get_vbat(struct bq257xx_chg *pdata,= int *intval) return ret; } =20 +/** + * bq25792_get_vbat() - Get the reported voltage from the battery + * @pdata: driver platform data + * @intval: pointer to store the battery voltage value + * + * Read the current ADC value representing the battery voltage + * and return it in microvolts. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_vbat(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG3B_VBAT_ADC, ®); + if (ret) + return ret; + + *intval =3D reg * BQ25792_ADCVSYSVBAT_STEP_UV; + + return ret; +} + /** * bq25703_hw_init() - Set all the required registers to init the charger * @pdata: driver platform data @@ -425,6 +755,61 @@ static int bq25703_hw_init(struct bq257xx_chg *pdata) return ret; } =20 +/** + * bq25792_hw_init() - Initialize BQ25792 hardware + * @pdata: driver platform data + * + * Initialize the BQ25792 by disabling the watchdog, enabling discharge + * current sensing with 5A limit, and configuring input current regulation. + * Set the charge current, charge voltage, minimum system voltage, and + * input current limit from platform data. Enable and configure the ADC + * to measure all available channels. + * + * Return: Returns 0 on success or error code on error. + */ +static int bq25792_hw_init(struct bq257xx_chg *pdata) +{ + struct regmap *regmap =3D pdata->bq->regmap; + int ret =3D 0; + + /* Disable watchdog (TODO: make it work instead) */ + regmap_write(regmap, BQ25792_REG10_CHARGER_CONTROL_1, 0); + + /* + * Enable battery discharge current sensing, 5A discharge current + * limit, input current regulation + */ + regmap_write(regmap, BQ25792_REG14_CHARGER_CONTROL_5, + BQ25792_REG14_EN_IBAT | + BQ25792_IBAT_5A | + BQ25792_REG14_EN_IINDPM); + + ret =3D pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); + if (ret) + return ret; + + ret =3D pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); + if (ret) + return ret; + + ret =3D bq25792_set_min_vsys(pdata, pdata->vsys_min); + if (ret) + return ret; + + ret =3D pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); + if (ret) + return ret; + + /* Enable the ADC. */ + regmap_write(regmap, BQ25792_REG2E_ADC_CONTROL, BQ25792_REG2E_ADC_EN); + + /* Clear per-channel ADC disable bits - enable all channels */ + regmap_write(regmap, BQ25792_REG2F_ADC_FUNCTION_DISABLE_0, 0); + regmap_write(regmap, BQ25792_REG30_ADC_FUNCTION_DISABLE_1, 0); + + return ret; +} + /** * bq25703_hw_shutdown() - Set registers for shutdown * @pdata: driver platform data @@ -437,6 +822,30 @@ static void bq25703_hw_shutdown(struct bq257xx_chg *pd= ata) BQ25703_EN_LWPWR, BQ25703_EN_LWPWR); } =20 +/** + * bq25792_hw_shutdown() - Shutdown BQ25792 hardware + * @pdata: driver platform data + * + * Perform hardware shutdown for the BQ25792. Currently a no-op + * as the device does not require special shutdown configuration. + */ +static void bq25792_hw_shutdown(struct bq257xx_chg *pdata) +{ + /* Nothing to do here */ +} + +/** + * bq257xx_set_charger_property() - Set a power supply property + * @psy: power supply device + * @prop: power supply property to set + * @val: value to set for the property + * + * Handle requests to set power supply properties such as input current + * limit, constant charge voltage, and constant charge current. Routes + * the request to the chip-specific implementation. + * + * Return: Returns 0 on success or -EINVAL if property is not supported. + */ static int bq257xx_set_charger_property(struct power_supply *psy, enum power_supply_property prop, const union power_supply_propval *val) @@ -460,6 +869,19 @@ static int bq257xx_set_charger_property(struct power_s= upply *psy, return -EINVAL; } =20 +/** + * bq257xx_get_charger_property() - Get a power supply property + * @psy: power supply device + * @psp: power supply property to get + * @val: pointer to store the property value + * + * Handle requests to get power supply properties, including status, + * health, manufacturer, online state, and various voltage/current + * measurements. Reads current device state and routes chip-specific + * property requests to appropriate handlers. + * + * Return: Returns 0 on success or -EINVAL if property is not supported. + */ static int bq257xx_get_charger_property(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val) @@ -541,6 +963,17 @@ static enum power_supply_property bq257xx_power_supply= _props[] =3D { POWER_SUPPLY_PROP_USB_TYPE, }; =20 +/** + * bq257xx_property_is_writeable() - Check if a property is writeable + * @psy: power supply device + * @prop: power supply property to check + * + * Determines which power supply properties can be written to. Only + * charge current limit, charge voltage limit, and input current + * limit are writeable. + * + * Return: Returns 1 if property is writeable, 0 otherwise. + */ static int bq257xx_property_is_writeable(struct power_supply *psy, enum power_supply_property prop) { @@ -613,6 +1046,17 @@ static void bq257xx_external_power_changed(struct pow= er_supply *psy) power_supply_changed(psy); } =20 +/** + * bq257xx_irq_handler_thread() - Handle charger interrupt + * @irq: interrupt number + * @private: pointer to driver private data + * + * Thread handler for charger interrupts. Triggers re-evaluation of + * external power status and updates power supply state in response + * to charger events. + * + * Return: Returns IRQ_HANDLED if interrupt was processed. + */ static irqreturn_t bq257xx_irq_handler_thread(int irq, void *private) { struct bq257xx_chg *pdata =3D private; @@ -653,6 +1097,22 @@ static const struct bq257xx_chip_info bq25703_chip_in= fo =3D { .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 +static const struct bq257xx_chip_info bq25792_chip_info =3D { + .default_iindpm_uA =3D BQ25792_IINDPM_DEFAULT_UA, + .bq257xx_hw_init =3D &bq25792_hw_init, + .bq257xx_hw_shutdown =3D &bq25792_hw_shutdown, + .bq257xx_get_state =3D &bq25792_get_state, + .bq257xx_get_ichg =3D &bq25792_get_ichg_cur, + .bq257xx_set_ichg =3D &bq25792_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25792_get_chrg_volt, + .bq257xx_set_vbatreg =3D &bq25792_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25792_get_iindpm, + .bq257xx_set_iindpm =3D &bq25792_set_iindpm, + .bq257xx_get_cur =3D &bq25792_get_cur, + .bq257xx_get_vbat =3D &bq25792_get_vbat, + .bq257xx_get_min_vsys =3D &bq25792_get_min_vsys, +}; + /** * bq257xx_parse_dt() - Parse the device tree for required properties * @pdata: driver platform data @@ -698,10 +1158,22 @@ static int bq257xx_parse_dt(struct bq257xx_chg *pdat= a, return 0; } =20 +/** + * bq257xx_charger_probe() - Probe routine for charger platform device + * @pdev: platform device + * + * Probe the charger device, allocate driver data structure, select the + * appropriate chip-specific function pointers, register the power supply, + * parse device tree properties for battery limits, initialize hardware, + * and set up the interrupt handler if available. + * + * Return: Returns 0 on success or error code on failure. + */ static int bq257xx_charger_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct bq257xx_device *bq =3D dev_get_drvdata(pdev->dev.parent); + struct bq257xx_plat *plat =3D dev_get_platdata(dev); struct bq257xx_chg *pdata; struct power_supply_config psy_cfg =3D { }; int ret; @@ -713,7 +1185,17 @@ static int bq257xx_charger_probe(struct platform_devi= ce *pdev) return -ENOMEM; =20 pdata->bq =3D bq; - pdata->chip =3D &bq25703_chip_info; + + switch (plat->type) { + case BQ25703A: + pdata->chip =3D &bq25703_chip_info; + break; + case BQ25792: + pdata->chip =3D &bq25792_chip_info; + break; + default: + return dev_err_probe(dev, -EINVAL, "Unknown chip type\n"); + } =20 platform_set_drvdata(pdev, pdata); =20 @@ -751,6 +1233,13 @@ static int bq257xx_charger_probe(struct platform_devi= ce *pdev) return ret; } =20 +/** + * bq257xx_charger_shutdown() - Shutdown routine for charger platform devi= ce + * @pdev: platform device + * + * Called during system shutdown to perform charger cleanup, including + * disabling watchdog timers or other chip-specific shutdown procedures. + */ static void bq257xx_charger_shutdown(struct platform_device *pdev) { struct bq257xx_chg *pdata =3D platform_get_drvdata(pdev); diff --git a/include/linux/mfd/bq257xx.h b/include/linux/mfd/bq257xx.h index b2e38a4a4738..0d568e8b1835 100644 --- a/include/linux/mfd/bq257xx.h +++ b/include/linux/mfd/bq257xx.h @@ -353,12 +353,10 @@ #define BQ25792_REG20_VAC2_OVP_STAT BIT(1) #define BQ25792_REG20_VAC1_OVP_STAT BIT(0) =20 -#define BQ25792_REG20_OVERVOLTAGE_MASK (BQ25792_REG20_VBUS_OVP_STAT | \ - BQ25792_REG20_VBAT_OVP_STAT | \ +#define BQ25792_REG20_OVERVOLTAGE_MASK (BQ25792_REG20_VBAT_OVP_STAT | \ BQ25792_REG20_VAC2_OVP_STAT | \ BQ25792_REG20_VAC1_OVP_STAT) -#define BQ25792_REG20_OVERCURRENT_MASK (BQ25792_REG20_IBUS_OCP_STAT | \ - BQ25792_REG20_IBAT_OCP_STAT | \ +#define BQ25792_REG20_OVERCURRENT_MASK (BQ25792_REG20_IBAT_OCP_STAT | \ BQ25792_REG20_CONV_OCP_STAT) =20 /* FAULT Status 1 */ --=20 2.52.0