From nobody Thu Apr 9 20:27:12 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34FEB33A9C4 for ; Thu, 5 Mar 2026 21:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747646; cv=none; b=pYYMl8vtY9Kbd2PBmZtoQFuSElIYZBsgv/e6iklnmFu47UfWHvI1ttcjD0WXmH9ILAstMTcYi2Nk3jLzTXGwFO1F0GF43ZqiNvv7Qs63D7iUc1YU6dilEnpqyrhrMcUdOFJw+RnEMw7BYh0wAtnTYMfqcjgEdMlIe3JHhEpN4AA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747646; c=relaxed/simple; bh=HJCddEP3HpwEtFqNu8fH3f450OqH/961LoMvQQ4Dmvc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uPp6IZrT5jiYlp6pyTV55o9qz+YGhrZ13aIkhqxEKqLj03D2d4TEiR23qfuBWReqJ8njY3sDD8R4OPKn0Cw4bziBjpNmZfo6ETAuZ7pI6SCfdzexCBxI6NRlPgwSlwVGHStfGLqHhUMnWL+Ca+PZiYjZh+0p59sYUYcQvQbR8wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RoLsCsNV; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RoLsCsNV" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-797ab169454so87705847b3.3 for ; Thu, 05 Mar 2026 13:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772747644; x=1773352444; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LDyT5wYyzGLSfGloP9Q597W13aZWnETTygjbppIux2I=; b=RoLsCsNVO9/BSuieErIsbnqgIX1c5jJWKoiENzXkBGHT+LDBRxCehHEYRxcpqDhcpI R3FnlEvwZ3chRXv7fW/k2gfTSxRahBlg/lcA5NAzcLpJwBosZx1zPQI1OrHqXL64gcdI LMV97nbITiWn1X4HTo/uMI4S/W9fySASXcYMsuS2RLe4s2db2GN8HAiHhuD46e8fTP1V IzbHIqRnAuYwjQjf6KB3ee5Ev7mnPk2UUHocHGOAqHiQaWpVQVOMNNr0zrJRUyAudquH oV83RarCuDgHOAuwYvI66CURrVZQDAAAcrgBK/DyA3HarkjS9cg9BGsAPWILsDQRl4cL 7BKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772747644; x=1773352444; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LDyT5wYyzGLSfGloP9Q597W13aZWnETTygjbppIux2I=; b=C2khPqlqUMUDSlcnP0W52FNnum+ktDX89Id8/SXThI+gFBMMo4B0liLegxUhiSrtCH 8AvpCELbLPhjqn5w8agWpGWEwjaE5cbl4UENc10XzfETov6an3QoQmT0ddCNXxqvLhJ/ nCmQ8I3RSWwc1/Et9qtSS2+477Dgnf+PxsMM+7E24E2OIGvKi1ExbBLRq8LN2krgTwWz Fo4aHYKKW+ck4aSEHrEL9aAsOUDNLcL14x7TclykrnJdv/2ScDgfGvz+CsrUSJKXShCu frtQHBNsLlCsBe+JJmDo+xrzCT2MfBoQO0Bze7RLGByZwtqeYre4wpA7H5XEUpBdaqyP D0YQ== X-Forwarded-Encrypted: i=1; AJvYcCXS1KnJRD2Uc38emndD1aX+6JqjhjbOcpl0SBQSYpIck70eH2gGrElXZkB3rfZKDBBC5tI6QrmdLhTc+zU=@vger.kernel.org X-Gm-Message-State: AOJu0YxANi4J4fgJX9Gpo8u3YsX226lykZ6a78IDWsKFa5oiT4V3T3td 0/EGBlu0aZXNVDEULKipmfAzRnrYADws8nvNsjZ0Op88NRK9FyP6OkxW X-Gm-Gg: ATEYQzx0iqcG1U9RHNK3upmuslX9XAyMRAP0tHHk6ZC9lTOCqZsqRe1CoYhKkrI/Zby wvNZc6SUObxHQyoQWSlv8dLdMeziIjZIiZ8h/Y8Ber0r8Zbv1r7zRGRMdxJLBY3tywG991vx6kn y+QC6W4OBwZ/lem1zDOL+v7kpqGVBvIXD/CucKTTLhphgwSQNNR/gcHgCnh2LJEWuDJpNwIswlg XiXE4MJOdnHurtdyBLmMoXaEBjJcT6HlGnZbYoSfqie4Bjez8g+FEMnVmfxBmujgEbQIYfOCETE +3KoSMT+eUYhsOz5NQiKqYtld+wolg/WA9FlwehHgN+gKyduBeV6npyhfZ+XRWelWNqjG4iiLcZ c8fHiT7npB1MBk7X+kH7jSJ361IMoiL7XB6plLFDGKxsXcOy1FGvsYUrjdRng8nk46zbhEQcC4L igCTfDR5GK7KsDBUcrMhAcTCsW4eQWYowdQzVms4XAaBftmT3TyBIvIwzE X-Received: by 2002:a05:690c:660c:b0:798:6561:2a7c with SMTP id 00721157ae682-798c6ca2ea1mr59720497b3.41.1772747644186; Thu, 05 Mar 2026 13:54:04 -0800 (PST) Received: from desktop-linux.python-stargazer.ts.net ([50.168.180.218]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ca7354sm90121677b3.52.2026.03.05.13.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 13:54:03 -0800 (PST) From: Mehul Rao To: jmaloy@redhat.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: horms@kernel.org, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Mehul Rao Subject: [PATCH] tipc: validate conn_timeout to prevent divide-by-zero Date: Thu, 5 Mar 2026 16:53:36 -0500 Message-ID: <20260305215336.645186-1-mehulrao@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A user can set conn_timeout to any value via setsockopt(TIPC_CONN_TIMEOUT), including values less than 4. When a SYN is rejected with TIPC_ERR_OVERLOAD and the retry path in tipc_sk_filter_connect() executes: delay %=3D (tsk->conn_timeout / 4); If conn_timeout is in the range [0, 3], the integer division yields 0, and the modulo operation triggers a divide-by-zero exception, causing a kernel oops/panic. Fix this by rejecting conn_timeout values less than 4 in tipc_setsockopt() with -EINVAL. Values below 4ms are not meaningful as a connection timeout anyway. Oops: divide error: 0000 [#1] SMP KASAN NOPTI CPU: 0 UID: 0 PID: 119 Comm: poc-F144 Not tainted 7.0.0-rc2+ RIP: 0010:tipc_sk_filter_rcv+0x1b99/0x3040 Call Trace: tipc_sk_backlog_rcv+0xe4/0x1d0 __release_sock+0x1ef/0x2a0 release_sock+0x55/0x190 tipc_connect+0x140/0x510 __sys_connect+0x1bb/0x2e0 Fixes: 6787927475e5 ("tipc: buffer overflow handling in listener socket") Signed-off-by: Mehul Rao --- net/tipc/socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 4c618c2b871d..85c07b0ba0ec 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -3184,6 +3184,10 @@ static int tipc_setsockopt(struct socket *sock, int = lvl, int opt, tsk_set_unreturnable(tsk, value); break; case TIPC_CONN_TIMEOUT: + if (value < 4) { + res =3D -EINVAL; + break; + } tipc_sk(sk)->conn_timeout =3D value; break; case TIPC_MCAST_BROADCAST: -- 2.48.1