From nobody Thu Apr 9 20:25:37 2026 Received: from mail-vk1-f228.google.com (mail-vk1-f228.google.com [209.85.221.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9C73382CF for ; Thu, 5 Mar 2026 20:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772742232; cv=none; b=jUh5TCyNdzUMOxbOov4qw1cQtFFe+hzrd3890SlsaDK5qKx5JMBQ3ssVA2Oh0e4GOGRVA1SGoptD1zRpYaw6h5+3nHlzLQsjF1MggsyXC4EcxkllhCfk8ri7HQGCTFnXwH1ncJ+Ylt5LwhGYIp1BMld6rW6BkmcvxQg2G6Yzt0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772742232; c=relaxed/simple; bh=NJvRx7uMoRrnxwUkVs1UwfvPdxO8Jgy+kmRVf7Kvp8w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=UjWpgm4K2iQJqu0IaTlqPrBxBkztxVzIvW6X3JmqoEe7CcHkFpCIjAkWpwekjoK1i16HZ0kngJ+IBTPG1fJo5qxIOrvyphdZEiSq1LvQfZgs03EZuMK5j7bPzQRQTY9Ka+Dr2ObUNkOUVqe2m9BHE2ATvxiX2CLPZDfPigSVlH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=LeTewN6E; arc=none smtp.client-ip=209.85.221.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LeTewN6E" Received: by mail-vk1-f228.google.com with SMTP id 71dfb90a1353d-56adf76631cso1288974e0c.1 for ; Thu, 05 Mar 2026 12:23:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772742230; x=1773347030; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1NxoGImTSCkhbC7LhqJ5kMri0RwIzFL7xOu7X7Ff1N4=; b=JoXTeS8AsJ1v0ghCLs14TZSPNovVG/avQI1FlqILVLGa36DMOGv2kfaV3LRkeX0PtT 7n71w1nEBWjSudnNNhJz87x/A7P6MpGmmX5LzcZHPuVgTPP7XnhbfflQLwcSTqRZOeLq NtqxeQN8CruYYEu9EmKd/vJcWkdcdU5Wp5WD0IfQG8fPd6QC3m02geiRSsmNIGcEPF1Y RUMKb4NV2POFOYUrrGNiTbrQKszK8IUgND1BTu/teapWZm0wgHv9xX79YuDn4IvtSzWi M3oBUZesbl+mOdzlyuTbosLVsgS+DH7HgmuyxYlvd2/pRbglsH3c6jJtr7ewlGLDXSLB SGVw== X-Forwarded-Encrypted: i=1; AJvYcCXX8f1odrMjZmHtGPm32sR8R23SKxfN4adtYOkS0ad9ZaPhDWUuXVDcY5jOJRMCM5M8REUua7VXNsr7Yr0=@vger.kernel.org X-Gm-Message-State: AOJu0YyA+ojLnSSSRlAXV5jO+xWRAdhggr+KmBy8optTamxrF4qNcPBt nBtQH+F4X0K6/pMBb9HzaawbJ2afgF3i07796g6B6Y58Duq4CVXn30w+78ZzAWqRVXLnV5sV3nJ WmiG8GLXXUKMUmJy6TbLzF9dPSsmaC2nCeklyKIyngx5xhWVUHNwDebN1KuzHC3ub+zg9yCmWOr Bizk2/y6jZqK9MuvKTUhI9gvMgEij5J/lR39rfWQDi0rcfzCZPgmnbFkIZUpAvl8ocMoAgg+xli GnWIqWFm0R3TY6T X-Gm-Gg: ATEYQzysKmK7Kt+2KCKg2ho5PbgZ4WrtlZl0FVUSAMzqwIJcKD5tvGKlECOwamsx8V9 DP7DsJ1z9GgI3SNKR9pGQKaEO/N7YkBGK/2ZJ39zkrw+rZCsipnbAQZm+3KTaQKGeje6rByY2ct X9Sj8iW3HRF9OHwn62FJT8ZbN272BLFgBUp1aKstJAGdcldmLBjcUkIJLXKjC03ePYoVhV0ewTm +scLrkNFG5mBv/nx3W/CU4QD9oCbyTOgyw/mYjpaF8SRKAwDtFJY9bxJIkGJ9XKQ7lFE9XnIBmV 89H5hRb7bX4BaYgN/l8tSRBSd6GZ8ojSayi7Mi4sKHV43BnxmUNMMi0JQ+3EYscuXe34PZvE12c wmF0Za/2DZP+xhGE40EG+ibdIwarQPDPZ1wFydDjHk/yh5+rsJ2+ZyhDDHll9tFIqYmj6FlXUmY xd5GKWZLFvL5XrUxBY+BkTBZ3P2bUNUtrt7L8n9pa/3g1vq69sy7xo0A== X-Received: by 2002:a05:6122:4fa6:b0:55b:9c3f:55f with SMTP id 71dfb90a1353d-56ae78009e2mr3085616e0c.18.1772742229966; Thu, 05 Mar 2026 12:23:49 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-19.dlp.protect.broadcom.com. [144.49.247.19]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-56aea882006sm714541e0c.3.2026.03.05.12.23.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2026 12:23:49 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-12711ec96fbso3140918c88.0 for ; Thu, 05 Mar 2026 12:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772742229; x=1773347029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1NxoGImTSCkhbC7LhqJ5kMri0RwIzFL7xOu7X7Ff1N4=; b=LeTewN6EcOw/pFB8n4MVAWbWlHuhYyeFX0wZ1WCFcfEbW5EqdmOjwdgCuWin7wHeqw 4tmFUJDLOYCY9wQj7q1/UjK2txznnjw1Q5UpmPZaLHYz/trLiGLLn92DgglsFw9PUXK/ s9EcyV9nkJtI5MRN6CjW1yjxHwJSEulruqqLM= X-Forwarded-Encrypted: i=1; AJvYcCXqFFUQoGSGAaae7OjsrXqDPCPct3hw/PwmWsZJ7DFo6Tstad0MzphKiCuIZ+LoTeOuW3yWLMvwM2oEgts=@vger.kernel.org X-Received: by 2002:a05:7022:f89:b0:11b:9386:a3be with SMTP id a92af1059eb24-128b70eb57cmr3253389c88.41.1772742228825; Thu, 05 Mar 2026 12:23:48 -0800 (PST) X-Received: by 2002:a05:7022:f89:b0:11b:9386:a3be with SMTP id a92af1059eb24-128b70eb57cmr3253376c88.41.1772742228238; Thu, 05 Mar 2026 12:23:48 -0800 (PST) Received: from mail.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12789a32863sm21066718c88.10.2026.03.05.12.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:23:47 -0800 (PST) From: Kamal Dasu To: computersforpeace@gmail.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: florian.fainelli@broadcom.com, william.zhang@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Kamal Dasu Subject: [PATCH] mtd: rawnand: brcmnand: skip DMA during panic write Date: Thu, 5 Mar 2026 15:21:57 -0500 Message-Id: <20260305202157.3571334-1-kamal.dasu@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" When oops_panic_write is set, the driver disables interrupts and switches to PIO polling mode but still falls through into the DMA path. DMA cannot be used reliably in panic context, so make the DMA path an else branch to ensure only PIO is used during panic writes. Fixes: c1ac2dc34b51 ("mtd: rawnand: brcmnand: When oops in progress use pio= and interrupt polling") Signed-off-by: Kamal Dasu Reviewed-by: Florian Fainelli Reviewed-by: William Zhang --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/ra= w/brcmnand/brcmnand.c index 0427d76f45d0..5b9dadd5405e 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -2350,14 +2350,12 @@ static int brcmnand_write(struct mtd_info *mtd, str= uct nand_chip *chip, for (i =3D 0; i < ctrl->max_oob; i +=3D 4) oob_reg_write(ctrl, i, 0xffffffff); =20 - if (mtd->oops_panic_write) + if (mtd->oops_panic_write) { /* switch to interrupt polling and PIO mode */ disable_ctrl_irqs(ctrl); - - if (use_dma(ctrl) && (has_edu(ctrl) || !oob) && flash_dma_buf_ok(buf)) { + } else if (use_dma(ctrl) && (has_edu(ctrl) || !oob) && flash_dma_buf_ok(b= uf)) { if (ctrl->dma_trans(host, addr, (u32 *)buf, oob, mtd->writesize, CMD_PROGRAM_PAGE)) - ret =3D -EIO; =20 goto out; --=20 2.34.1