From nobody Thu Apr 9 20:28:23 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C129C2D661C for ; Thu, 5 Mar 2026 20:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772741642; cv=none; b=QYExfZb/i88YyRBJuqM7I5devnpgLRZWbOYmgwSsjaCoqiD+sETHganJTGPcLfkOD3CzE54QVtr/zPIg9z8dyO96W8OJ7cXYwcXDxGZHTSfKhGTzEFq6WfbOeElSkLJZdRnzzpiU3IjTx5BOkPyVp9sYrHyl6XEMQ2uuOhOU1RU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772741642; c=relaxed/simple; bh=BVSYajjX8QZ2uqBS6QQzCOARY2MJCC4I+vvzD+sr2nw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m0LyGsRB0FLEQcZi5+B+ux+z7b7Ca7B79/shs1my9PmFhEcS20cL7t+RSkXGSJ8PsfrOrwcjkNSwB44ll84vPOq15QKmQi1VuXqY4LvaEFbFA9Lk/Xnqcq11sWrtwMJVDbEZY8Y9/0BFlrRsgb30/XCCqJNbApZ2l9YLWhMjsgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UsBTFI6N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BuG3yMdl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UsBTFI6N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BuG3yMdl" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625CNBTZ720351 for ; Thu, 5 Mar 2026 20:13:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=zONKhg6P1Ev6MJUutYDZ+HCNI5aniluPAIz 4dKN7gG8=; b=UsBTFI6N3Y7HQuy1b8OqU39w3B05RgAUuHTKNpEKF0T8GIo2pC3 hg+R/27Yw974uzPol74k9cQ4JNztxjkYD+GOGe7Kh9GlRWdkbp7EYBdINTLhm00r kgvyZAOa9K4IoxcOnBWDQslx0ol7bVxjoqwBTbvblnUMv4SefqIGeQoMqtqRz+U3 xSL0nPc+8UckVU32Xh0eyyy/lnUi7KbTl60sF9tjLMRLQ4yocBvdRYJJuRT3Y/nL ZLHJMywMmn6csmg8dj8+xd6/ZHNFUmDpVuIW5IHuk1rF3hEw9M+7pYQz2tLNWdE6 UHUO+iup0iW6NbJPgx/3U4o+0rhOu2u4BsQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq9srhkc8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 20:13:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8ca3ef536ddso2011185785a.0 for ; Thu, 05 Mar 2026 12:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772741639; x=1773346439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zONKhg6P1Ev6MJUutYDZ+HCNI5aniluPAIz4dKN7gG8=; b=BuG3yMdlbpPUq2+A2/RritTOzQpUAmRxsA0YRgtawlIl6CdzCpR0UDHO3wk6yUBoHU x4HEr3iGi8WviZLjv5gVsDIqYaRfZ8K4R1meiSnadZDUIITpedud4mf5sFeKacJYSJ8o 3zCkX0NRFO7O0aD3GCqc83do/l6TieVGJroBYgN1+zhtA5ETV1KjFHid9GMCufyC+M5X st3Ushp0oXkdi9qRbif4NteT4J6otGLausBE9VLqxq5swsAW4CpvP08EW5z3fGaot8D6 hanW9hGuvdEI50o1v2nHh62aEKRFN5BYFW4JEM/hYV7hSWVf19Py2IwYkLy7ya58iLaI QWwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772741639; x=1773346439; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zONKhg6P1Ev6MJUutYDZ+HCNI5aniluPAIz4dKN7gG8=; b=ecufyY+hETJ50KKufCNtrtITWftTerD8mIvIYgg8lfrsX4UqLCPbcmPS7epDL1Ge1+ Fe40u0EUptHryrmVD1tCpVR0i8qYclg1f7C9AO+xpwMiHBYX6ikIjdxj+uKTu/8ZELZb t40XNoBtjLv9TR2AnL5fh55ruEfyhCfjX6XvR1ezKVi2IoMvlmJQwCHMmYYeJlnvEbcU vvQ39PU7hANPEJY8l+8lBhUjNNtbacPy2P5i4TVuLR+U7KxImnHaVSrGjnbgvz7asb3a A6eXbWNac55w91VIrR7+eObv0C/6n2kmik04pwgkH5x5U49aa8XrnrbdxTrj+PmSqqCa nadw== X-Forwarded-Encrypted: i=1; AJvYcCXuY+zFLakZgRqzBr3yHFZB1H9U0qszVKqnsBoMSFTMTJy70ORISfOdkd3e0hugsUJctgxtskuonIpPxDY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm7qa6Z0yIC5jXip+qJrqFqJAbM+PJklU/z+Dkih1uLZjFQX8u XNMKaGiJKJc3nwRkI+DAlC4qTUntJfHR6h6jpRA2SMs/JEMlTlIF7V/Hjk52RKiUA4Lr4P/7ByT uLJM8wDJo7k7kwdaxqt6k1u8mpBrM1SGSrLJt0/leJUGQvo8dxfEAHfU9o7JTXtRZZfc= X-Gm-Gg: ATEYQzyYyfNPpr2YthCHKiur1UZe7caHM6UPH6bYD0pjEEnvsggX1JYwo27gUmAhoi1 QSxyAF/aVCTNKrst+afAt6Mbal//BWskzEK/u+lD3ex8IM5e4KmgYz2ZJwAD5C5Vf3A1Ttv/Vmp PWn92+fFZIKLYgpTuwAfjMSLB28j3jZVWGMomcl+PmIgRA08ktUnN/X3ehYBP7r2SESV/gM5xol GfwS1iCWD1NC8ZXApitA3KXHg8gO/S087QY2rA345lbeeLk0NOC8oChExIXqGzj56/WpWAWUqHj tfA7LxFv2M8EIh6NARLbodujJu6yvsS+BjkTK8/7n10VZ70OUQRAvh+pddYQkAmfQ0RtEh6bRhe afiWPEBZQ0581DBDp0smjnmrbrfWbjBPDX1M4 X-Received: by 2002:a05:620a:4092:b0:8ca:2cf9:819c with SMTP id af79cd13be357-8cd5af8030fmr874672485a.40.1772741639068; Thu, 05 Mar 2026 12:13:59 -0800 (PST) X-Received: by 2002:a05:620a:4092:b0:8ca:2cf9:819c with SMTP id af79cd13be357-8cd5af8030fmr874669885a.40.1772741638630; Thu, 05 Mar 2026 12:13:58 -0800 (PST) Received: from quoll ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485244a5c0esm1294355e9.4.2026.03.05.12.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:13:56 -0800 (PST) From: Krzysztof Kozlowski To: Mark Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Cc: Krzysztof Kozlowski Subject: [PATCH] regmap: Simplify devres handling Date: Thu, 5 Mar 2026 21:13:50 +0100 Message-ID: <20260305201349.32734-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1873; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=BVSYajjX8QZ2uqBS6QQzCOARY2MJCC4I+vvzD+sr2nw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpqeP9h4JLHokM2Fwh2L5ctuREkg08wqWNxUWlV crDJS+wjSqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaanj/QAKCRDBN2bmhouD 13XcD/9DK0ydGrSvZrVHtTMD4aejjLltiA12r/YErrE7hlQ0QXeJXrxNKAyGbc4eCkQa3btcQiE CpvIzxoX+0qMDvamPrW9Ff3bTNDdq66Vo+PAm9xGC3miJCE/RQElN4rzYoEJYZY1/jqu3Hc7yN/ XHUU2TPRGGDCrLlDXO4LwyXWQTIdnBNqVBwNI4TGplenmbvoSjAU8yLMRs//SYUsnpcC2PzWlRj zo3Ybt7NROWeYe/TPM+M6omWjIbMSbjvIza/41+CAnAKj/N7HuVL26A8bg0jeR8AYAiu/a+5gER NQo1mLBsawRt94JZ6NoS6pOO/T4/tIhTEgFm4Jw53q76Lsbe1tJBfljd50DSfVWentYuu+AAaQ+ duoVYXaoEStbwBHn0m6p3w4YV8vZPtDo4CwFEQ/jFkABv1LYU+zyGCGBn8WqJehY/75B7Zt0ZDx +diH9AwqGYCh8n1kp/dhS6G6rsnyl+2CpoSpE3ySc2lDU6hsCQ/aLVcplT1c8GIgNEe+ZKZjg7w qOsCLBWVcFkCUTrXT72eUU2rZPDlJRus7wKKECZTu9pxZ+flvEFvwTzed3nC1l73g/W6N4wi+uq 2fOVWTgbU2FthytykhiV6u+j9C+h2hxj4RpxQMmU89mRASmMd18rphSzAkQB9Ta04HHTYYCS1g3 t4Pu0N3D/Knp/eQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=a/I9NESF c=1 sm=1 tr=0 ts=69a9e407 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=X6npvS0fHPtJAOho-mwA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: 82D-dqfb2zA4iSIlwfmOiCH7cDVtFhMx X-Proofpoint-ORIG-GUID: 82D-dqfb2zA4iSIlwfmOiCH7cDVtFhMx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDE2OSBTYWx0ZWRfXz7X2I7j+OVBK nN68N016/96LdR8rVCVCOvZDrME6EcqARiTUqkbKxNhyR9zzaFDfUe8EhjXzw9J4TUVTBAFfiDQ WZPT/k5jfE7EQSKXfVOjJSJcTZb2h7DLUCAiBMRIXk0bAQgBA64s+IqVoGVqJnEP+pLtB5xr0sv wtD9GELdWizEUavTNx+quJiP6YPHGs8s2PWSP8nxXiRkaUjIHTHyPtZDwKNEc0LpSxfPYmAqNym m1y0FAOhVdwtIyyE1prWCDWpw3bV9p+beLA9dzEbxmgFNItHPO6MQFs6LM1gndzaWfl04zPAseT ++PxfGAx5Pyx5u51+0AGx4cpaEqRjXbIBsfZ3AEiCFD1m/G7wfMd9otSVXz9fl0QBLpPdTfc7CJ HlO1tLN53b3/N94KlTK7Zj8QeIzRAnmAnTNk2g2nDYZPbZOD2Pr297painFr9ziTa9TjzYkkej1 zjAc1mOd9SNf3a2fqqg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_05,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050169 Content-Type: text/plain; charset="utf-8" The resource-managed devm_regmap_init() can be a bit simpler by using devm_add_action_or_reset() instead of devres_alloc(). This allows to drop the less-obvious pointer to pointer (struct regmap **ptr) and make devm_regmap_release() interface simpler. Code is functionally equivalent with minor difference: devres_alloc() will happen now after successful resource init (__regmap_init()). Signed-off-by: Krzysztof Kozlowski --- drivers/base/regmap/regmap.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 607c1246d994..f888a83aa9c3 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1182,9 +1182,9 @@ struct regmap *__regmap_init(struct device *dev, } EXPORT_SYMBOL_GPL(__regmap_init); =20 -static void devm_regmap_release(struct device *dev, void *res) +static void devm_regmap_release(void *regmap) { - regmap_exit(*(struct regmap **)res); + regmap_exit(regmap); } =20 struct regmap *__devm_regmap_init(struct device *dev, @@ -1194,20 +1194,17 @@ struct regmap *__devm_regmap_init(struct device *de= v, struct lock_class_key *lock_key, const char *lock_name) { - struct regmap **ptr, *regmap; - - ptr =3D devres_alloc(devm_regmap_release, sizeof(*ptr), GFP_KERNEL); - if (!ptr) - return ERR_PTR(-ENOMEM); + struct regmap *regmap; + int ret; =20 regmap =3D __regmap_init(dev, bus, bus_context, config, lock_key, lock_name); - if (!IS_ERR(regmap)) { - *ptr =3D regmap; - devres_add(dev, ptr); - } else { - devres_free(ptr); - } + if (IS_ERR(regmap)) + return regmap; + + ret =3D devm_add_action_or_reset(dev, devm_regmap_release, regmap); + if (ret) + return ERR_PTR(ret); =20 return regmap; } --=20 2.51.0